From 0d441325f89dd3820fb9d301f934d99d4508d94d Mon Sep 17 00:00:00 2001 From: Ray Speth Date: Fri, 3 Mar 2023 20:51:32 -0500 Subject: [PATCH] [Thermo] Fix cv calculation in RedlichKisterVPSSTP Partially resolves #1320 --- src/thermo/RedlichKisterVPSSTP.cpp | 2 +- test/data/consistency-cases.yaml | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/thermo/RedlichKisterVPSSTP.cpp b/src/thermo/RedlichKisterVPSSTP.cpp index d36705023..8d0309846 100644 --- a/src/thermo/RedlichKisterVPSSTP.cpp +++ b/src/thermo/RedlichKisterVPSSTP.cpp @@ -89,7 +89,7 @@ doublereal RedlichKisterVPSSTP::cp_mole() const doublereal RedlichKisterVPSSTP::cv_mole() const { - return cp_mole() - GasConstant; + return cp_mole(); } void RedlichKisterVPSSTP::getPartialMolarEnthalpies(doublereal* hbar) const diff --git a/test/data/consistency-cases.yaml b/test/data/consistency-cases.yaml index c12670834..ccab5cdc7 100644 --- a/test/data/consistency-cases.yaml +++ b/test/data/consistency-cases.yaml @@ -321,8 +321,6 @@ Redlich-Kister: setup: file: thermo-models.yaml phase: Redlich-Kister-LiC6 - known-failures: - cv_eq_.+: "Implementation of cv is incorrect. See GitHub Issue #1320" states: - {T: 300, P: 1 atm, X: {Li(C6): 0.85, V(C6): 0.15}} - {T: 440, P: 1 atm, X: {Li(C6): 0.75, V(C6): 0.25}}