Address review comments

This commit is contained in:
Ingmar Schoegl
2024-02-20 07:38:36 -06:00
committed by Ray Speth
parent 497926bcb2
commit cfcb2f2f80
5 changed files with 12 additions and 14 deletions

View File

@@ -68,8 +68,8 @@ class TestReactor(utilities.CanteraTest):
self.assertEqual(len(R.kinetics.net_production_rates), g.n_species)
def test_volume(self):
with pytest.warns(DeprecationWarning, match="must not be empty"):
R = self.reactorClass(volume=11)
g = ct.Solution('h2o2.yaml', transport_model=None)
R = self.reactorClass(g, volume=11)
self.assertEqual(R.volume, 11)
R.volume = 9
@@ -855,8 +855,8 @@ class TestReactor(utilities.CanteraTest):
x.foobar
def test_bad_kwarg(self):
with pytest.warns(DeprecationWarning, match="must not be empty"):
self.reactorClass(name='ok')
g = ct.Solution('h2o2.yaml', transport_model=None)
self.reactorClass(g, name='ok')
with self.assertRaises(TypeError):
r1 = self.reactorClass(foobar=3.14)