_MSC_VER < 1900 corresponds to 1800 and earlier, which is
VC++ version 12.0 (Visual Studio 2013). Cantera now uses the C++17
standard, with the current minimum requirement VC++ version 14.1
(Visual Studio 2017).
Unit tests cover 'clib' from within C++ googletest code
- port test-clib to google tests
- rename pre-existing version to test-clib-demo
- add tests indirectly probing SharedCabinet
- add tests for Solution access routines
- add tests for ctonedim
Mole fractions have to be set before T and P; otherwise, the pressure
changes. Before the change, the pressure was significantly lower than
5 atm. Also fix incorrect use of 'kin_newFromFile', which causes
unintended linkages to default objects that do not raise exceptions
but may lead to erroneous results.
The nondimensional EOS should always be dimensionalized to a mass
basis using the value of R given in the original source. Values on
a molar basis can then be computed consistently using the best available
value for the molecular weight of water.
Partially resolves#1315
Cygwin support is untested and Cygwin has uncertain usage for Cantera.
Modern replacements such as the Windows Subsystem for Linux v2 (WSL2)
should be used instead.
Defines molar volume to be zero. Density remains defined as being
per unit area or length, depending on the dimensionality of the phase.
Also fixes setting surface composition using mass/mole fractions so
that the sum of concentrations always equals the site density.
Partially resolves#1312
LiC6_electrodebulk.yaml was the only file in data/sample-data. Moving this file
to samples/data mimics the input file location for the jupyter repository.
This class provides access to the thermo and kinetics objects as the
correct derived types, i.e. SurfPhase and InterfaceKinetics, so
methods defined only for these derived types can be called easily.
Doxygen only recognizes lowercase '@todo'.
This commit also changes instances of @TODO that aren't actually read
by Doxygen, such as ones in Python files or ones inside C++ methods to
standardize use of the lowercase version in the places where it does
matter.
Some polynomial coefficients were fit to 6th order polynomial but only
evaluated as 5th order polynomials, using the first 6 coefficients of
the 7 fitted coefficients. This changes the evaluation to use all of
the fitted coefficients.
Fixes#1070
Gandhali Kogekar
Ray Speth
Ingmar Schoegl
Sammo Gabay
Tim Gallagher
Mark E. Fuller