Commit Graph

11 Commits

Author SHA1 Message Date
Ray Speth
884cc9f0d4 [ck2yaml] Fix converting surface mechanisms with separate thermo data 2023-12-06 21:12:15 -05:00
Ingmar Schoegl
475d855099 [unittest] Ensure yaml2ck handles notes correctly 2023-09-09 18:15:48 -05:00
Ingmar Schoegl
1118711332 [unittests] Add test for Solution.write_chemkin 2023-09-09 18:15:48 -05:00
Ingmar Schoegl
395a7d2252 [ck2yaml] Rename convert_mech to convert
Adopt the same naming convention as used by other converter scripts.
2023-09-09 18:15:48 -05:00
Ray Speth
309bf34a73 Remove code deprecated in Cantera 3.0
This takes care of simple removals of deprecated methods/classes
2023-08-26 19:03:02 -07:00
Ray Speth
c281601c2c Convert C++ NotImplementedError to Python NotImplementedError 2023-03-19 16:32:38 -05:00
Ray Speth
9153ef23ab Deprecate class MaskellSolidSolnPhase
This phase model is incomplete, has numerous thermodynamic consistency
issues as documented in #1321, and has no known non-trivial examples.

Resolves #1321
2023-03-13 22:58:24 -05:00
Ray Speth
f04ea58338 Deprecate class IonsFromNeutralVPSSTP and class PDSS_IonsFromNeutral
This model has had a request for tests/examples out for many years (#267)
with no response, and the addition of consistency tests revealed multiple
errors in the implementation (documented in #1322). Further, there is no
mathematical description of the model or references to literature to use
as a reference in trying to correct any of these issues.

Resolves #1322.
2023-03-13 22:58:24 -05:00
Cory Kinney
81633c31b7 Allow float input of integer geometry flags in ck2yaml
If `permissive` is given, `float` geometry flags are cast to `int` and are accepted if the values are equal, otherwise, `InputError` is raised. If `permissive` is not given, existing behavior is unchanged.

Add tests to check for correct behavior with and without permissive, for float rounding error, and for character inputs.

Closes #1395
2023-01-24 07:30:28 -05:00
Ingmar Schoegl
957dd2414b [yaml2ck] Fix explicit third body reaction output
Prior to this fix, third body efficiencies were erroneously specified
for third body reactions with explicit collision partners (see #1415).
2023-01-04 09:07:29 -05:00
Ingmar Schoegl
6e3c7e8296 [UnitTests] Move Python test suite and update SCons build process 2022-08-06 15:11:53 -04:00