From 40d47f24d1f3e5e85d5aedf5921c9514f3edcd69 Mon Sep 17 00:00:00 2001 From: Kevin Schaaf Date: Fri, 8 Dec 2017 10:55:33 -0800 Subject: [PATCH] Avoid _setPendingProperty warning due to types not understanding deduping mixin. --- externs/closure-types.js | 3 ++- lib/mixins/properties-changed.html | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/externs/closure-types.js b/externs/closure-types.js index e3ff8c59..81a2fa86 100644 --- a/externs/closure-types.js +++ b/externs/closure-types.js @@ -52,9 +52,10 @@ Polymer_PropertiesChanged.prototype._getProperty = function(property){}; /** * @param {string} property Name of the property * @param {*} value Value to set +* @param {boolean=} ext Not used here; affordance for closure * @return {boolean} */ -Polymer_PropertiesChanged.prototype._setPendingProperty = function(property, value){}; +Polymer_PropertiesChanged.prototype._setPendingProperty = function(property, value, ext){}; /** * @return {undefined} */ diff --git a/lib/mixins/properties-changed.html b/lib/mixins/properties-changed.html index f80a16fd..91964cb3 100644 --- a/lib/mixins/properties-changed.html +++ b/lib/mixins/properties-changed.html @@ -240,10 +240,11 @@ subject to an additional IP rights grant found at http://polymer.github.io/PATEN * * @param {string} property Name of the property * @param {*} value Value to set + * @param {boolean=} ext Not used here; affordance for closure * @return {boolean} Returns true if the property changed * @protected */ - _setPendingProperty(property, value) { + _setPendingProperty(property, value, ext) { let old = this.__data[property]; let changed = this._shouldPropertyChange(property, value, old); if (changed) {