mirror of
https://github.com/Polymer/polymer.git
synced 2025-02-25 18:55:30 -06:00
_removeInstance -> _detachAndRemoveInstance
This commit is contained in:
parent
f447c0eb70
commit
ba7a16f888
@ -491,7 +491,7 @@ Then the `observe` property should be configured as follows:
|
||||
}
|
||||
// Remove any extra instances from previous state
|
||||
for (var j=this._instances.length-1; j>=i; j--) {
|
||||
this._removeInstance(j);
|
||||
this._detachAndRemoveInstance(j);
|
||||
}
|
||||
},
|
||||
|
||||
@ -544,7 +544,7 @@ Then the `observe` property should be configured as follows:
|
||||
var idx = removedIdxs[i];
|
||||
// Removed idx may be undefined if item was previously filtered out
|
||||
if (idx !== undefined) {
|
||||
this._removeInstance(idx);
|
||||
this._detachAndRemoveInstance(idx);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -606,7 +606,7 @@ Then the `observe` property should be configured as follows:
|
||||
splices.forEach(function(s) {
|
||||
// Detach & pool removed instances
|
||||
for (var i=0; i<s.removed.length; i++) {
|
||||
this._removeInstance(s.index);
|
||||
this._detachAndRemoveInstance(s.index);
|
||||
}
|
||||
for (var i=0; i<s.addedKeys.length; i++) {
|
||||
this._insertPlaceholder(s.index+i, s.addedKeys[i]);
|
||||
@ -632,7 +632,7 @@ Then the `observe` property should be configured as follows:
|
||||
}
|
||||
},
|
||||
|
||||
_removeInstance: function(idx) {
|
||||
_detachAndRemoveInstance: function(idx) {
|
||||
var inst = this._detachInstance(idx);
|
||||
if (inst) {
|
||||
this._pool.push(inst);
|
||||
|
Loading…
Reference in New Issue
Block a user