GreenPolyProducts/polymer
5
0
Fork 0
mirror of https://github.com/Polymer/polymer.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5650 from Polymer/attribute-override-types

Browse Source 
Fix TypeScript breakages by specifying types for overridden `setAttribute` and `getAttribute`.
This commit is contained in:
Russell Bicknell
2020-04-27 20:37:37 -07:00
committed by GitHub
parent 282bd340f7 370ae5ebab
commit f73c89b544
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/legacy/legacy-element-mixin.js
View File

@@ -143,7 +143,12 @@ export const LegacyElementMixin = dedupingMixin((base) => {
} }
} }
/** @override */ /**
* Sets the value of an attribute.
* @override
* @param {string} name The name of the attribute to change.
* @param {string} value The new attribute value.
*/
setAttribute(name, value) { setAttribute(name, value) {
if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) { if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
const oldValue = this.getAttribute(name); const oldValue = this.getAttribute(name);
@@ -155,7 +160,11 @@ export const LegacyElementMixin = dedupingMixin((base) => {
} }
} }
/** @override */ /**
* Removes an attribute.
* @override
* @param {string} name The name of the attribute to remove.
*/
removeAttribute(name) { removeAttribute(name) {
if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) { if (legacyNoObservedAttributes && !this._legacyForceObservedAttributes) {
const oldValue = this.getAttribute(name); const oldValue = this.getAttribute(name);