Kevin Schaaf
77ac3ec2b4
Merge branch 'master' into strict-no-warnings
2019-02-05 11:56:53 -08:00
Kevin Schaaf
cb86634d6e
Merge pull request #5474 from Polymer/legacy-warnings-3.x
...
Legacy warnings 3.x
2019-02-04 16:59:19 -08:00
Kevin Schaaf
21e83e9e94
Remove unused import
2019-02-04 15:23:27 -08:00
Kevin Schaaf
67caf458ba
Add comment re: undefined issue
2019-02-04 15:15:55 -08:00
Kevin Schaaf
11cd9cb241
Move undeclared property warning to element-mixin.
2019-02-04 15:12:06 -08:00
Kevin Schaaf
98304fb601
Updates based on review.
2019-02-04 12:01:09 -08:00
Kevin Schaaf
28f2281b7a
Remove addressed TODO comment.
2019-02-01 10:13:26 -08:00
Kevin Schaaf
9dea1f780f
Clarify warning. Add comment.
2019-02-01 10:12:47 -08:00
Kevin Schaaf
35c48d8952
Add warnings for disabling boolean settings.
2019-02-01 10:12:35 -08:00
Kevin Schaaf
c78f679989
Refactor to make code more readable, add tests, remove dead code.
2019-01-31 16:35:03 -08:00
Kevin Schaaf
4d99099d1a
Ensure that marshalArgs pulls wildcard info value from __data
...
It currently pulls the value from `changedProps` rather than __data, meaning it could provide stale data for re-entrant changes.
2019-01-31 11:01:16 -08:00
Kevin Schaaf
563bc8586c
Fix lint warning
2019-01-30 10:33:34 -08:00
Kevin Schaaf
007f3cc251
Add warning for redeclared computed properties.
2019-01-30 10:08:58 -08:00
Kevin Schaaf
63dadbf248
Add warning for undeclared properties used in bindings.
2019-01-30 10:08:58 -08:00
Daniel Freedman
d577c8c875
Disable auto strip-whitespace on template with legacyOptimizations
...
External copy of cl/225100591
2019-01-29 17:25:32 -08:00
Daniel Freedman
c22b87c797
Merge pull request #5464 from Polymer/copy-properties
...
Allow `Polymer({})` calls with ES6 class
2019-01-29 11:32:09 -08:00
Daniel Freedman
86db24cd87
use a regular for-loop intead of for-of
2019-01-28 16:30:06 -08:00
Peter Burns
bdcd37c513
Lint clean
2019-01-15 12:54:09 -08:00
Peter Burns
f15b137d14
Remove @override from static methods on mixins.
...
Closure compiler is improving its handling of class inheritance, and it does not understand our mixins well enough to notice that these methods override their superclasses. These annotations cause compiler errors in an upcoming version of the compiler.
2019-01-15 12:02:44 -08:00
Alexander Marks
7f2d736a96
Add @suppress annotations for missing property checks.
...
Upstream of cl/228620162
2019-01-10 12:23:55 -08:00
Daniel Freedman
3624a140df
Allow Polymer({}) calls with ES6 class
...
External copy of cl/228511716
2019-01-09 15:16:22 -08:00
Peter Burns
cf2cd05e73
Suppress upcoming jscompiler errors.
...
These errors don't exist yet, but we need to suppress them in the files that will have them so that we're not broken when they're turned on.
2018-12-19 16:15:06 -08:00
Alexander Marks
0da022fd9d
Add type jsdoc to templatize root property.
...
This allows analyzer to understand it for typings/docs.
2018-12-13 12:19:51 -08:00
Alexander Marks
fcc8752724
Remove meaningless "undefined" in settings.js
2018-12-11 14:43:44 -08:00
Kevin Schaaf
c23ff5e0da
Merge branch 'master' into 5422-ldm-templatizer-fix
2018-11-20 15:50:35 -08:00
Kevin Schaaf
1092719f68
Merge branch 'master' into 5422-ldm-templatizer-fix
2018-11-19 17:10:27 -08:00
Daniel Freedman
5422792f0e
Remove double-import of settings
...
Causing warnings with Closure Compiler
External copy of cl/222162967
2018-11-19 20:02:45 -05:00
Peter Burns
3a4db3b112
Document properties for eslint.
2018-11-19 10:06:48 -08:00
Kevin Schaaf
6c93955bac
Merge branch 'css-build-dir' into behaviors-no-mixin
2018-11-14 15:23:58 -08:00
Steven Orvell
ed5f7f279b
Use closure-safe name
2018-11-14 11:02:18 -08:00
Steven Orvell
ad5cb2686a
Ensure properties and observers are interleaved per behavior
2018-11-13 19:36:47 -08:00
Steven Orvell
2b35a74f2a
Ensure property values are always overridden by extendors/behaviors
2018-11-13 16:24:44 -08:00
Steven Orvell
50ad018c8d
Ensure registered is always called on element prototype
...
Previously, it could be called on a superclass' prototype and not the element's prototype.
2018-11-13 15:32:41 -08:00
Steven Orvell
d64a9c27e5
Do lazy behavior copying only when legacyOptimizations is set
2018-11-09 18:48:48 -08:00
Steven Orvell
310c7ead07
Behavior property copying fixes
...
* ensure element has `is` on prototype early as this is sometimes checked in user code.
* ensure properties copied onto elements from info/behaviors are forced to configurable so they can be re-configured by later behaviors.
* add `_noAccessors` optimization for faster property copying
2018-11-09 18:18:06 -08:00
Steven Orvell
65a3149b8c
Ensure initial static classes are preserved when a class$ binding is present
...
This ensures ShadyCSS scoping classes are not removed when a class binding's initial literal value is set.
2018-11-09 18:03:55 -08:00
Peter Burns
bbf24c0c67
Get typescript compiling again.
2018-11-09 17:13:30 -08:00
Steven Orvell
82c9d17e23
Remove extra space
2018-11-09 11:33:12 -08:00
Steven Orvell
cf30a8cc35
Avoid copying certain properties from behaviors
...
This better matches what Polymer 1.x did for:
* hostAttributes
* listeners
* properties
* observers
2018-11-09 11:31:35 -08:00
Daniel Freedman
ec00d26b58
Move __activateDir into check instead of replace
...
Remove unused imports in testing
2018-11-07 15:21:06 -08:00
Daniel Freedman
08bc1ff5ed
Don't set up observer in ShadyDOM
...
It won't be used
2018-11-07 15:04:55 -08:00
Steven Orvell
d5e0043abc
Manually merge changes from #5418
2018-11-06 15:59:23 -08:00
Steven Orvell
0ca8407f63
Merge branch 'master' into behaviors-no-mixin
2018-11-06 15:14:30 -08:00
Peter Burns
419dce634d
Fix merge conflict around toggleAttribute
2018-11-05 09:19:20 -08:00
Peter Burns
566dcfaefe
Get Polymer compiling clean under closure recommended flags
...
With these changes we have zero errors and zero warnings with `RECOMMENDED_FLAGS`!
Most of the changes were adding `@override` for methods and properties in mixins. Apparently if you implement an interface you need to say `@override` for each method or property on the interface. This combines with our mixin strategy to the tune of needing to add `@override` on every non-private method and property.
I'm not sure this is intended behavior of the compiler. Filed https://github.com/google/closure-compiler/issues/3137 to see if it is.
2018-11-04 13:29:04 -08:00
Daniel Freedman
5341dbd298
Merge pull request #5413 from Polymer/polymer-dom-externs
...
Hybrid compatibility for PolymerDomApi and Polymer.Iconset types.
2018-11-02 12:58:51 -07:00
Kevin Schaaf
6dd3456940
Apply LegacyDataMixin to TemplatizeInstanceBase. Fixes #5422
2018-11-01 23:15:56 -07:00
Steven Orvell
d57e05e5ba
TemplateStamp
...
Fix TreeWalker on older browsers were arguments are not optional.
Also updates package-lock
2018-11-01 16:03:00 -07:00
Steven Orvell
725d52c6a0
Lint fix
2018-10-31 19:22:21 -07:00
Steven Orvell
a08c9840d6
Updates ported from perf-opt branch
...
Merging manually from https://github.com/Polymer/polymer/pull/5418 .
2018-10-31 19:21:04 -07:00