2018-07-05 11:02:02 -05:00
|
|
|
<?php
|
|
|
|
/**
|
|
|
|
* TransactionValidation.php
|
|
|
|
* Copyright (c) 2018 thegrumpydictator@gmail.com
|
|
|
|
*
|
|
|
|
* This file is part of Firefly III.
|
|
|
|
*
|
|
|
|
* Firefly III is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* Firefly III is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
*/
|
|
|
|
|
|
|
|
declare(strict_types=1);
|
|
|
|
|
|
|
|
namespace FireflyIII\Validation;
|
|
|
|
|
|
|
|
use FireflyIII\Models\Transaction;
|
2019-04-06 01:10:50 -05:00
|
|
|
use FireflyIII\Models\TransactionGroup;
|
2018-07-05 11:02:02 -05:00
|
|
|
use Illuminate\Validation\Validator;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Trait TransactionValidation
|
|
|
|
*/
|
|
|
|
trait TransactionValidation
|
|
|
|
{
|
2019-04-06 01:10:50 -05:00
|
|
|
/**
|
|
|
|
* If type is set, source + destination info is mandatory.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
protected function validateAccountPresence(Validator $validator): void
|
|
|
|
{
|
|
|
|
// TODO
|
|
|
|
}
|
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
|
2018-07-05 11:02:02 -05:00
|
|
|
/**
|
|
|
|
* Validates the given account information. Switches on given transaction type.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
2019-03-31 06:36:49 -05:00
|
|
|
*
|
|
|
|
* @throws \FireflyIII\Exceptions\FireflyException
|
2018-07-05 11:02:02 -05:00
|
|
|
*/
|
|
|
|
public function validateAccountInformation(Validator $validator): void
|
|
|
|
{
|
2019-03-31 06:36:49 -05:00
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
2018-07-05 11:02:02 -05:00
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
/** @var AccountValidator $accountValidator */
|
|
|
|
$accountValidator = app(AccountValidator::class);
|
2018-07-05 11:02:02 -05:00
|
|
|
|
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
foreach ($transactions as $index => $transaction) {
|
|
|
|
$transactionType = $transaction['type'] ?? 'invalid';
|
|
|
|
$accountValidator->setTransactionType($transactionType);
|
|
|
|
|
|
|
|
// validate source account.
|
|
|
|
$sourceId = isset($transaction['source_id']) ? (int)$transaction['source_id'] : null;
|
|
|
|
$sourceName = $transaction['source_name'] ?? null;
|
|
|
|
$validSource = $accountValidator->validateSource($sourceId, $sourceName);
|
2018-07-05 11:02:02 -05:00
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
// do something with result:
|
|
|
|
if (false === $validSource) {
|
|
|
|
$validator->errors()->add(sprintf('transactions.%d.source_id', $index), $accountValidator->sourceError);
|
|
|
|
$validator->errors()->add(sprintf('transactions.%d.source_name', $index), $accountValidator->sourceError);
|
2018-07-05 11:02:02 -05:00
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
return;
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
2019-03-31 06:36:49 -05:00
|
|
|
// validate destination account
|
|
|
|
$destinationId = isset($transaction['destination_id']) ? (int)$transaction['destination_id'] : null;
|
|
|
|
$destinationName = $transaction['destination_name'] ?? null;
|
|
|
|
$validDestination = $accountValidator->validateDestination($destinationId, $destinationName);
|
|
|
|
// do something with result:
|
|
|
|
if (false === $validDestination) {
|
|
|
|
$validator->errors()->add(sprintf('transactions.%d.destination_id', $index), $accountValidator->destError);
|
|
|
|
$validator->errors()->add(sprintf('transactions.%d.destination_name', $index), $accountValidator->destError);
|
|
|
|
|
|
|
|
return;
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
2019-03-31 06:36:49 -05:00
|
|
|
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Adds an error to the "description" field when the user has submitted no descriptions and no
|
|
|
|
* journal description.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
public function validateDescriptions(Validator $validator): void
|
|
|
|
{
|
2019-03-31 06:36:49 -05:00
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
$validDescriptions = 0;
|
2018-07-05 11:02:02 -05:00
|
|
|
foreach ($transactions as $index => $transaction) {
|
2019-01-01 11:03:24 -06:00
|
|
|
if ('' !== (string)($transaction['description'] ?? null)) {
|
2018-07-05 11:02:02 -05:00
|
|
|
$validDescriptions++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
// no valid descriptions?
|
|
|
|
if (0 === $validDescriptions) {
|
2019-04-06 01:10:50 -05:00
|
|
|
$validator->errors()->add(
|
|
|
|
'transactions.0.description', (string)trans('validation.filled', ['attribute' => (string)trans('validation.attributes.description')])
|
|
|
|
);
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* If the transactions contain foreign amounts, there must also be foreign currency information.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
public function validateForeignCurrencyInformation(Validator $validator): void
|
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
foreach ($transactions as $index => $transaction) {
|
|
|
|
// must have currency info.
|
|
|
|
if (isset($transaction['foreign_amount'])
|
|
|
|
&& !(isset($transaction['foreign_currency_id'])
|
|
|
|
|| isset($transaction['foreign_currency_code']))) {
|
|
|
|
$validator->errors()->add(
|
|
|
|
'transactions.' . $index . '.foreign_amount',
|
2018-07-15 02:38:49 -05:00
|
|
|
(string)trans('validation.require_currency_info')
|
2018-07-05 11:02:02 -05:00
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
2019-03-31 06:36:49 -05:00
|
|
|
public function validateGroupDescription(Validator $validator): void
|
2018-07-05 11:02:02 -05:00
|
|
|
{
|
2019-03-31 06:36:49 -05:00
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
$groupTitle = $data['group_title'] ?? '';
|
|
|
|
if ('' === $groupTitle && \count($transactions) > 1) {
|
|
|
|
$validator->errors()->add('group_title', (string)trans('validation.group_title_mandatory'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Adds an error to the validator when there are no transactions in the array of data.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
public function validateOneTransaction(Validator $validator): void
|
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
// need at least one transaction
|
2018-07-15 03:00:08 -05:00
|
|
|
if (0 === \count($transactions)) {
|
2019-04-06 01:10:50 -05:00
|
|
|
$validator->errors()->add('transactions.0.description', (string)trans('validation.at_least_one_transaction'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Make sure that all the splits accounts are valid in combination with each other.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
public function validateSplitAccounts(Validator $validator): void
|
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$count = isset($data['transactions']) ? \count($data['transactions']) : 0;
|
|
|
|
if ($count < 2) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
// this is pretty much impossible:
|
|
|
|
// @codeCoverageIgnoreStart
|
|
|
|
if (!isset($data['type'])) {
|
|
|
|
// the journal may exist in the request:
|
|
|
|
/** @var Transaction $transaction */
|
|
|
|
$transaction = $this->route()->parameter('transaction');
|
|
|
|
if (null === $transaction) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
$data['type'] = strtolower($transaction->transactionJournal->transactionType->type);
|
|
|
|
}
|
|
|
|
// @codeCoverageIgnoreEnd
|
|
|
|
|
|
|
|
// collect all source ID's and destination ID's, if present:
|
|
|
|
$sources = [];
|
|
|
|
$destinations = [];
|
|
|
|
|
|
|
|
foreach ($data['transactions'] as $transaction) {
|
|
|
|
$sources[] = isset($transaction['source_id']) ? (int)$transaction['source_id'] : 0;
|
|
|
|
$destinations[] = isset($transaction['destination_id']) ? (int)$transaction['destination_id'] : 0;
|
|
|
|
}
|
|
|
|
$destinations = array_unique($destinations);
|
|
|
|
$sources = array_unique($sources);
|
|
|
|
// switch on type:
|
|
|
|
switch ($data['type']) {
|
|
|
|
case 'withdrawal':
|
|
|
|
if (\count($sources) > 1) {
|
2018-07-15 02:38:49 -05:00
|
|
|
$validator->errors()->add('transactions.0.source_id', (string)trans('validation.all_accounts_equal'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
case 'deposit':
|
|
|
|
if (\count($destinations) > 1) {
|
2018-07-15 02:38:49 -05:00
|
|
|
$validator->errors()->add('transactions.0.destination_id', (string)trans('validation.all_accounts_equal'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
case 'transfer':
|
|
|
|
if (\count($sources) > 1 || \count($destinations) > 1) {
|
2018-07-15 02:38:49 -05:00
|
|
|
$validator->errors()->add('transactions.0.source_id', (string)trans('validation.all_accounts_equal'));
|
|
|
|
$validator->errors()->add('transactions.0.destination_id', (string)trans('validation.all_accounts_equal'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2019-03-31 06:36:49 -05:00
|
|
|
* All types of splits must be equal.
|
2018-07-05 11:02:02 -05:00
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
2019-03-31 06:36:49 -05:00
|
|
|
public function validateTransactionTypes(Validator $validator): void
|
2018-07-05 11:02:02 -05:00
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
2019-03-31 06:36:49 -05:00
|
|
|
$types = [];
|
2018-07-05 11:02:02 -05:00
|
|
|
foreach ($transactions as $index => $transaction) {
|
2019-03-31 06:36:49 -05:00
|
|
|
$types[] = $transaction['type'] ?? 'invalid';
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
2019-03-31 06:36:49 -05:00
|
|
|
$unique = array_unique($types);
|
|
|
|
if (count($unique) > 1) {
|
|
|
|
$validator->errors()->add('transactions.0.type', (string)trans('validation.transaction_types_equal'));
|
2018-07-05 11:02:02 -05:00
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
return;
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
2019-03-31 06:36:49 -05:00
|
|
|
$first = $unique[0] ?? 'invalid';
|
|
|
|
if ('invalid' === $first) {
|
|
|
|
$validator->errors()->add('transactions.0.type', (string)trans('validation.invalid_transaction_type'));
|
2018-07-05 11:02:02 -05:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-06 01:10:50 -05:00
|
|
|
/**
|
|
|
|
* All types of splits must be equal.
|
|
|
|
*
|
|
|
|
* @param Validator $validator
|
|
|
|
*/
|
|
|
|
public function validateTransactionTypesForUpdate(Validator $validator): void
|
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
$types = [];
|
|
|
|
foreach ($transactions as $index => $transaction) {
|
|
|
|
$types[] = $transaction['type'] ?? 'invalid';
|
|
|
|
}
|
|
|
|
$unique = array_unique($types);
|
|
|
|
if (count($unique) > 1) {
|
|
|
|
$validator->errors()->add('transactions.0.type', (string)trans('validation.transaction_types_equal'));
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @param Validator $validator
|
|
|
|
* @param TransactionGroup $transactionGroup
|
|
|
|
*/
|
|
|
|
private function validateJournalIds(Validator $validator, TransactionGroup $transactionGroup): void
|
|
|
|
{
|
|
|
|
$data = $validator->getData();
|
|
|
|
$transactions = $data['transactions'] ?? [];
|
|
|
|
if (count($transactions) < 2) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
foreach ($transactions as $index => $transaction) {
|
|
|
|
$journalId = (int)($transaction['transaction_journal_id'] ?? 0);
|
|
|
|
$count = $transactionGroup->transactionJournals()->where('id', $journalId)->count();
|
|
|
|
if (0 === $journalId || 0 === $count) {
|
|
|
|
$validator->errors()->add(sprintf('transactions.%d.source_name', $index), (string)trans('validation.need_id_in_edit'));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-03-31 06:36:49 -05:00
|
|
|
// /**
|
|
|
|
// * Throws an error when this asset account is invalid.
|
|
|
|
// *
|
|
|
|
// * @noinspection MoreThanThreeArgumentsInspection
|
|
|
|
// *
|
|
|
|
// * @param Validator $validator
|
|
|
|
// * @param int|null $accountId
|
|
|
|
// * @param null|string $accountName
|
|
|
|
// * @param string $idField
|
|
|
|
// * @param string $nameField
|
|
|
|
// *
|
|
|
|
// * @return null|Account
|
|
|
|
// */
|
|
|
|
// protected function assetAccountExists(Validator $validator, ?int $accountId, ?string $accountName, string $idField, string $nameField): ?Account
|
|
|
|
// {
|
|
|
|
// /** @var User $admin */
|
|
|
|
// $admin = auth()->user();
|
|
|
|
// $accountId = (int)$accountId;
|
|
|
|
// $accountName = (string)$accountName;
|
|
|
|
// // both empty? hard exit.
|
|
|
|
// if ($accountId < 1 && '' === $accountName) {
|
|
|
|
// $validator->errors()->add($idField, (string)trans('validation.filled', ['attribute' => $idField]));
|
|
|
|
//
|
|
|
|
// return null;
|
|
|
|
// }
|
|
|
|
// // ID belongs to user and is asset account:
|
|
|
|
// /** @var AccountRepositoryInterface $repository */
|
|
|
|
// $repository = app(AccountRepositoryInterface::class);
|
|
|
|
// $repository->setUser($admin);
|
|
|
|
// $set = $repository->getAccountsById([$accountId]);
|
|
|
|
// Log::debug(sprintf('Count of accounts found by ID %d is: %d', $accountId, $set->count()));
|
|
|
|
// if (1 === $set->count()) {
|
|
|
|
// /** @var Account $first */
|
|
|
|
// $first = $set->first();
|
|
|
|
// if ($first->accountType->type !== AccountType::ASSET) {
|
|
|
|
// $validator->errors()->add($idField, (string)trans('validation.belongs_user'));
|
|
|
|
//
|
|
|
|
// return null;
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// // we ignore the account name at this point.
|
|
|
|
// return $first;
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// $account = $repository->findByName($accountName, [AccountType::ASSET]);
|
|
|
|
// if (null === $account) {
|
|
|
|
// $validator->errors()->add($nameField, (string)trans('validation.belongs_user'));
|
|
|
|
//
|
|
|
|
// return null;
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// return $account;
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// /**
|
|
|
|
// * Throws an error when the given opposing account (of type $type) is invalid.
|
|
|
|
// * Empty data is allowed, system will default to cash.
|
|
|
|
// *
|
|
|
|
// * @noinspection MoreThanThreeArgumentsInspection
|
|
|
|
// *
|
|
|
|
// * @param Validator $validator
|
|
|
|
// * @param string $type
|
|
|
|
// * @param int|null $accountId
|
|
|
|
// * @param null|string $accountName
|
|
|
|
// * @param string $idField
|
|
|
|
// *
|
|
|
|
// * @return null|Account
|
|
|
|
// */
|
|
|
|
// protected function opposingAccountExists(Validator $validator, string $type, ?int $accountId, ?string $accountName, string $idField): ?Account
|
|
|
|
// {
|
|
|
|
// /** @var User $admin */
|
|
|
|
// $admin = auth()->user();
|
|
|
|
// $accountId = (int)$accountId;
|
|
|
|
// $accountName = (string)$accountName;
|
|
|
|
// // both empty? done!
|
|
|
|
// if ($accountId < 1 && '' === $accountName) {
|
|
|
|
// return null;
|
|
|
|
// }
|
|
|
|
// if (0 !== $accountId) {
|
|
|
|
// // ID belongs to user and is $type account:
|
|
|
|
// /** @var AccountRepositoryInterface $repository */
|
|
|
|
// $repository = app(AccountRepositoryInterface::class);
|
|
|
|
// $repository->setUser($admin);
|
|
|
|
// $set = $repository->getAccountsById([$accountId]);
|
|
|
|
// if (1 === $set->count()) {
|
|
|
|
// /** @var Account $first */
|
|
|
|
// $first = $set->first();
|
|
|
|
// if ($first->accountType->type !== $type) {
|
|
|
|
// $validator->errors()->add($idField, (string)trans('validation.belongs_user'));
|
|
|
|
//
|
|
|
|
// return null;
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// // we ignore the account name at this point.
|
|
|
|
// return $first;
|
|
|
|
// }
|
|
|
|
// }
|
|
|
|
//
|
|
|
|
// // not having an opposing account by this name is NOT a problem.
|
|
|
|
// return null;
|
|
|
|
// }
|
2018-07-22 13:32:02 -05:00
|
|
|
}
|