IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Refactor isSplitJournal()

Browse Source
This commit is contained in:
James Cole 2018-08-09 16:14:47 +02:00
parent 136f983353
commit 0c2093753d
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
2 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/Http/Controllers/Transaction/SingleController.php
View File

@ -445,18 +445,4 @@ class SingleController extends Controller
// redirect to previous URL. // redirect to previous URL.
return redirect($this->getPreviousUri('transactions.edit.uri')); return redirect($this->getPreviousUri('transactions.edit.uri'));
} }
/**
* Checks if journal is split.
*
* @param TransactionJournal $journal
*
* @return bool
*/
protected function isSplitJournal(TransactionJournal $journal): bool // validate objects
{
$count = $this->repository->countTransactions($journal);
return $count > 2;
}
} }

17
app/Support/Http/Controllers/ModelInformation.php
View File

@ -25,6 +25,7 @@ namespace FireflyIII\Support\Http\Controllers;
use FireflyIII\Models\TransactionJournal; use FireflyIII\Models\TransactionJournal;
use FireflyIII\Models\TransactionType; use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
/** /**
* Trait ModelInformation * Trait ModelInformation
@ -45,5 +46,21 @@ trait ModelInformation
return TransactionType::OPENING_BALANCE === $journal->transactionType->type; return TransactionType::OPENING_BALANCE === $journal->transactionType->type;
} }
/**
* Checks if journal is split.
*
* @param TransactionJournal $journal
*
* @return bool
*/
protected function isSplitJournal(TransactionJournal $journal): bool // validate objects
{
/** @var JournalRepositoryInterface $repository */
$repository = app(JournalRepositoryInterface::class);
$repository->setUser($journal->user);
$count = $repository->countTransactions($journal);
return $count > 2;
}
} }