Code cleanup.

app/Providers/AppServiceProvider.php

@@ -6,6 +6,8 @@ use Illuminate\Support\ServiceProvider;
  * Class AppServiceProvider
  *
  * @package FireflyIII\Providers
+ *
+ * @codeCoverageIgnore
  */
 class AppServiceProvider extends ServiceProvider
 {

app/Providers/BusServiceProvider.php

@@ -6,6 +6,8 @@ use Illuminate\Support\ServiceProvider;
 /**
  * Class BusServiceProvider
  *
+ * @codeCoverageIgnore
+ *
  * @package FireflyIII\Providers
  */
 class BusServiceProvider extends ServiceProvider

app/Providers/ConfigServiceProvider.php

@@ -6,6 +6,8 @@ use Illuminate\Support\ServiceProvider;
  * Class ConfigServiceProvider
  *
  * @package FireflyIII\Providers
+ * @codeCoverageIgnore
+ *
  */
 class ConfigServiceProvider extends ServiceProvider
 {

app/Providers/FireflyServiceProvider.php

@@ -23,6 +23,7 @@ use Validator;
  * Class FireflyServiceProvider
  *
  * @package FireflyIII\Providers
+ * @codeCoverageIgnore
  */
 class FireflyServiceProvider extends ServiceProvider
 {

app/Providers/RouteServiceProvider.php

@@ -7,6 +7,7 @@ use Illuminate\Routing\Router;
  * Class RouteServiceProvider
  *
  * @package FireflyIII\Providers
+ * @codeCoverageIgnore
  */
 class RouteServiceProvider extends ServiceProvider
 {

app/Providers/TestingServiceProvider.php

@@ -8,6 +8,7 @@ use Illuminate\Support\ServiceProvider;
 /**
  * Class TestingServiceProvider
  *
+ * @codeCoverageIgnore
  * @package FireflyIII\Providers
  */
 class TestingServiceProvider extends ServiceProvider

app/Repositories/PiggyBank/PiggyBankRepositoryInterface.php

@@ -13,18 +13,6 @@ use Illuminate\Support\Collection;
 interface PiggyBankRepositoryInterface
 {
 
-    /**
-     * @return Collection
-     */
-    public function getPiggyBanks();
-
-    /**
-     * @param PiggyBank $piggyBank
-     *
-     * @return Collection
-     */
-    public function getEvents(PiggyBank $piggyBank);
-
     /**
      * @param PiggyBank $piggyBank
      * @param           $amount
@@ -33,6 +21,13 @@ interface PiggyBankRepositoryInterface
      */
     public function createEvent(PiggyBank $piggyBank, $amount);
 
+    /**
+     * @param PiggyBank $piggyBank
+     *
+     * @return bool
+     */
+    public function destroy(PiggyBank $piggyBank);
+
     /**
      * @param PiggyBank $piggyBank
      *
@@ -43,9 +38,14 @@ interface PiggyBankRepositoryInterface
     /**
      * @param PiggyBank $piggyBank
      *
-     * @return bool
+     * @return Collection
      */
-    public function destroy(PiggyBank $piggyBank);
+    public function getEvents(PiggyBank $piggyBank);
+
+    /**
+     * @return Collection
+     */
+    public function getPiggyBanks();
 
     /**
      * Set all piggy banks to order 0.

tests/controllers/BudgetControllerTest.php

@@ -57,6 +57,24 @@ class BudgetControllerTest extends TestCase
 
     }
 
+    /**
+     * @covers FireflyIII\Http\Controllers\BudgetController::amount
+     */
+    public function testAmountZero()
+    {
+        $repository      = $this->mock('FireflyIII\Repositories\Budget\BudgetRepositoryInterface');
+        $limitRepetition = FactoryMuffin::create('FireflyIII\Models\LimitRepetition');
+        $budget          = $limitRepetition->budgetlimit->budget;
+        $this->be($budget->user);
+        $today = new Carbon;
+
+        $this->session(['start' => $today]);
+        $repository->shouldReceive('updateLimitAmount')->once()->andReturn($limitRepetition);
+        $this->call('POST', '/budgets/amount/' . $budget->id, ['amount' => 0, '_token' => 'replaceme']);
+        $this->assertResponseOk();
+
+    }
+
     /**
      * @covers FireflyIII\Http\Controllers\BudgetController::create
      */
@@ -128,12 +146,13 @@ class BudgetControllerTest extends TestCase
         $collection = new Collection;
         $collection->push($budget);
         $repository = $this->mock('FireflyIII\Repositories\Budget\BudgetRepositoryInterface');
+        $repetition = FactoryMuffin::create('FireflyIII\Models\LimitRepetition');
 
         $repository->shouldReceive('getActiveBudgets')->once()->andReturn($collection);
         $repository->shouldReceive('getInactiveBudgets')->once()->andReturn($collection);
         $repository->shouldReceive('cleanupBudgets')->once();
         $repository->shouldReceive('spentInPeriodCorrected')->once();
-        $repository->shouldReceive('getCurrentRepetition')->once();
+        $repository->shouldReceive('getCurrentRepetition')->once()->andReturn($repetition);
         Amount::shouldReceive('getCurrencySymbol')->andReturn('x');
         Amount::shouldReceive('format')->andReturn('x');
         Amount::shouldReceive('getCurrencyCode')->andReturn('X');

tests/controllers/HelpControllerTest.php

@@ -38,6 +38,7 @@ class HelpControllerTest extends TestCase
 
     /**
      * Everything present and accounted for, and in cache:
+     *
      * @covers FireflyIII\Http\Controllers\HelpController::show
      */
     public function testGetHelpText()
@@ -59,6 +60,7 @@ class HelpControllerTest extends TestCase
 
     /**
      * Everything present and accounted for, but not cached
+     *
      * @covers FireflyIII\Http\Controllers\HelpController::show
      */
     public function testGetHelpTextNoCache()
@@ -82,6 +84,7 @@ class HelpControllerTest extends TestCase
 
     /**
      * No such route.
+     *
      * @covers FireflyIII\Http\Controllers\HelpController::show
      */
     public function testGetHelpTextNoRoute()

tests/helpers/ReportHelperTest.php

@@ -233,16 +233,20 @@ class ReportHelperTest extends TestCase
         $left->save();
 
         // save meta for account:
-        AccountMeta::create([
+        AccountMeta::create(
+            [
                 'account_id' => $left->id,
                 'name'       => 'accountRole',
                 'data'       => 'defaultAsset'
-                            ]);
+            ]
-        AccountMeta::create([
+        );
+        AccountMeta::create(
+            [
                 'account_id' => $right->id,
                 'name'       => 'accountRole',
                 'data'       => 'defaultAsset'
-                            ]);
+            ]
+        );
 
 
         for ($i = 0; $i < 5; $i++) {
@@ -292,16 +296,20 @@ class ReportHelperTest extends TestCase
         $right->account_type_id = $asset->id;
 
         // save meta for account:
-        AccountMeta::create([
+        AccountMeta::create(
+            [
                 'account_id' => $left->id,
                 'name'       => 'accountRole',
                 'data'       => 'defaultAsset'
-                            ]);
+            ]
-        AccountMeta::create([
+        );
+        AccountMeta::create(
+            [
                 'account_id' => $right->id,
                 'name'       => 'accountRole',
                 'data'       => 'defaultAsset'
-                            ]);
+            ]
+        );
 
         $right->save();
         $left->save();

tests/models/TagModelTest.php

@@ -38,24 +38,6 @@ class TagModelTest extends TestCase
         parent::tearDown();
     }
 
-    /**
-     * @covers FireflyIII\Models\Tag::firstOrCreateEncrypted
-     */
-    public function testFirstOrCreateEncryptedNew()
-    {
-        $tag = FactoryMuffin::create('FireflyIII\Models\Tag');
-
-        $search = [
-            'tagMode' => 'something',
-            'tag'     => 'Something else',
-            'user_id' => $tag->user_id,
-        ];
-
-        $result = Tag::firstOrCreateEncrypted($search);
-
-        $this->assertNotEquals($tag->id, $result->id);
-    }
-
     /**
      * @covers FireflyIII\Models\Tag::firstOrCreateEncrypted
      */
@@ -74,4 +56,22 @@ class TagModelTest extends TestCase
         $this->assertEquals($tag->id, $result->id);
     }
 
+    /**
+     * @covers FireflyIII\Models\Tag::firstOrCreateEncrypted
+     */
+    public function testFirstOrCreateEncryptedNew()
+    {
+        $tag = FactoryMuffin::create('FireflyIII\Models\Tag');
+
+        $search = [
+            'tagMode' => 'something',
+            'tag'     => 'Something else',
+            'user_id' => $tag->user_id,
+        ];
+
+        $result = Tag::firstOrCreateEncrypted($search);
+
+        $this->assertNotEquals($tag->id, $result->id);
+    }
+
 }