From 13c2db53785ac1adbac1d4f0177efbe983d73506 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 21 Nov 2014 19:18:44 +0100 Subject: [PATCH] Removed some todo's --- app/controllers/TransactionController.php | 3 --- bootstrap/start.php | 8 ++++---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 7a8cbdcae0..048c470ce5 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -351,9 +351,6 @@ class TransactionController extends BaseController */ public function update(TransactionJournal $journal) { - /* - * TODO if the piggybank_id is set to 0, does this undo all piggy bank event(s)? - */ /** @var \FireflyIII\Database\TransactionJournal $repos */ $repos = App::make('FireflyIII\Database\TransactionJournal'); diff --git a/bootstrap/start.php b/bootstrap/start.php index df2b9bde6c..3f375d48cf 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -111,8 +111,8 @@ Event::subscribe('FireflyIII\Event\TransactionJournal'); // direct calls to models are BAD // cleanup everything related to reminders because it still feels a bit sloppy. // use a Database\Reminder thing instead of self-made ORM. -// TODO create static calls instead of all the App::make() things. -// TODO see if the various has-many-throughs actually get used. -// TODO set very tight rules on all models -// TODO create custom uniquely rules. +// create static calls instead of all the App::make() things. +// see if the various has-many-throughs actually get used. +// set very tight rules on all models +// create custom uniquely rules. return $app;