From 168d6f403c9b72c6a55b2416e51d04ca951338ea Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Fri, 15 Jan 2016 13:09:27 +0100
Subject: [PATCH] Shorter method names.

---
 app/Http/Controllers/RuleGroupController.php | 16 ++++++++--------
 app/Http/routes.php                          | 16 ++++++++--------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/app/Http/Controllers/RuleGroupController.php b/app/Http/Controllers/RuleGroupController.php
index 1444da86a8..d2312c8c30 100644
--- a/app/Http/Controllers/RuleGroupController.php
+++ b/app/Http/Controllers/RuleGroupController.php
@@ -33,7 +33,7 @@ class RuleGroupController extends Controller
     /**
      * @return View
      */
-    public function createRuleGroup()
+    public function create()
     {
         $subTitleIcon = 'fa-clone';
         $subTitle     = trans('firefly.make_new_rule_group');
@@ -56,7 +56,7 @@ class RuleGroupController extends Controller
      *
      * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      */
-    public function storeRuleGroup(RuleGroupFormRequest $request, RuleGroupRepositoryInterface $repository)
+    public function store(RuleGroupFormRequest $request, RuleGroupRepositoryInterface $repository)
     {
         $data = [
             'title'       => $request->input('title'),
@@ -85,7 +85,7 @@ class RuleGroupController extends Controller
      *
      * @return View
      */
-    public function editRuleGroup(RuleGroup $ruleGroup)
+    public function edit(RuleGroup $ruleGroup)
     {
         $subTitle = trans('firefly.edit_rule_group', ['title' => $ruleGroup->title]);
 
@@ -108,7 +108,7 @@ class RuleGroupController extends Controller
      *
      * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      */
-    public function updateRuleGroup(RuleGroupFormRequest $request, RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
+    public function update(RuleGroupFormRequest $request, RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
     {
         $data = [
             'title'       => $request->input('title'),
@@ -139,7 +139,7 @@ class RuleGroupController extends Controller
      *
      * @return View
      */
-    public function deleteRuleGroup(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
+    public function delete(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
     {
         $subTitle = trans('firefly.delete_rule_group', ['title' => $ruleGroup->title]);
 
@@ -161,7 +161,7 @@ class RuleGroupController extends Controller
      *
      * @return \Illuminate\Http\RedirectResponse
      */
-    public function destroyRuleGroup(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
+    public function destroy(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
     {
 
         $title  = $ruleGroup->title;
@@ -184,7 +184,7 @@ class RuleGroupController extends Controller
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      */
-    public function upRuleGroup(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
+    public function up(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
     {
         $repository->moveRuleGroupUp($ruleGroup);
 
@@ -198,7 +198,7 @@ class RuleGroupController extends Controller
      *
      * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
      */
-    public function downRuleGroup(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
+    public function down(RuleGroupRepositoryInterface $repository, RuleGroup $ruleGroup)
     {
         $repository->moveRuleGroupDown($ruleGroup);
 
diff --git a/app/Http/routes.php b/app/Http/routes.php
index 14a6424893..69d7b901d9 100644
--- a/app/Http/routes.php
+++ b/app/Http/routes.php
@@ -255,16 +255,16 @@ Route::group(
 
 
     // rule groups GET
-    Route::get('/rules/groups/create', ['uses' => 'RuleGroupController@createRuleGroup', 'as' => 'rules.rule-group.create']);
-    Route::get('/rules/groups/edit/{ruleGroup}', ['uses' => 'RuleGroupController@editRuleGroup', 'as' => 'rules.rule-group.edit']);
-    Route::get('/rules/groups/delete/{ruleGroup}', ['uses' => 'RuleGroupController@deleteRuleGroup', 'as' => 'rules.rule-group.delete']);
-    Route::get('/rules/groups/up/{ruleGroup}', ['uses' => 'RuleGroupController@upRuleGroup', 'as' => 'rules.rule-group.up']);
-    Route::get('/rules/groups/down/{ruleGroup}', ['uses' => 'RuleGroupController@downRuleGroup', 'as' => 'rules.rule-group.down']);
+    Route::get('/rules/groups/create', ['uses' => 'RuleGroupController@create', 'as' => 'rules.rule-group.create']);
+    Route::get('/rules/groups/edit/{ruleGroup}', ['uses' => 'RuleGroupController@edit', 'as' => 'rules.rule-group.edit']);
+    Route::get('/rules/groups/delete/{ruleGroup}', ['uses' => 'RuleGroupController@delete', 'as' => 'rules.rule-group.delete']);
+    Route::get('/rules/groups/up/{ruleGroup}', ['uses' => 'RuleGroupController@up', 'as' => 'rules.rule-group.up']);
+    Route::get('/rules/groups/down/{ruleGroup}', ['uses' => 'RuleGroupController@down', 'as' => 'rules.rule-group.down']);
 
     // rule groups POST
-    Route::post('/rules/groups/store', ['uses' => 'RuleGroupController@storeRuleGroup', 'as' => 'rules.rule-group.store']);
-    Route::post('/rules/groups/update/{ruleGroup}', ['uses' => 'RuleGroupController@updateRuleGroup', 'as' => 'rules.rule-group.update']);
-    Route::post('/rules/groups/destroy/{ruleGroup}', ['uses' => 'RuleGroupController@destroyRuleGroup', 'as' => 'rules.rule-group.destroy']);
+    Route::post('/rules/groups/store', ['uses' => 'RuleGroupController@store', 'as' => 'rules.rule-group.store']);
+    Route::post('/rules/groups/update/{ruleGroup}', ['uses' => 'RuleGroupController@update', 'as' => 'rules.rule-group.update']);
+    Route::post('/rules/groups/destroy/{ruleGroup}', ['uses' => 'RuleGroupController@destroy', 'as' => 'rules.rule-group.destroy']);
 
     /**
      * Search Controller