IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix for #2555

Browse Source
This commit is contained in:
James Cole 2019-09-07 19:40:44 +02:00
parent 0c967cb011
commit 1c68b0902d
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/Validation/AccountValidator.php
View File

@ -106,6 +106,10 @@ class AccountValidator
return false; return false;
} }
// whatever happens, source cannot equal destination:
switch ($this->transactionType) { switch ($this->transactionType) {
default: default:
$this->destError = sprintf('AccountValidator::validateDestination cannot handle "%s", so it will always return false.', $this->transactionType); $this->destError = sprintf('AccountValidator::validateDestination cannot handle "%s", so it will always return false.', $this->transactionType);
@ -508,7 +512,14 @@ class AccountValidator
$this->destination = $search; $this->destination = $search;
// must not be the same as the source account // must not be the same as the source account
return !(null !== $this->source && $this->source->id === $this->destination->id); if (null !== $this->source && $this->source->id === $this->destination->id) {
$this->sourceError = 'Source and destination are the same.';
$this->destError = 'Source and destination are the same.';
return false;
}
return true;
} }
/** /**