Remove all constructors.

This commit is contained in:
James Cole 2017-01-30 16:46:30 +01:00
parent 311c1a3c84
commit 1e947870a6
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
26 changed files with 128 additions and 252 deletions

View File

@ -43,16 +43,6 @@ class AccountRepository implements AccountRepositoryInterface
/** @var array */ /** @var array */
private $validFields = ['accountRole', 'ccMonthlyPaymentDate', 'ccType', 'accountNumber', 'currency_id', 'BIC']; private $validFields = ['accountRole', 'ccMonthlyPaymentDate', 'ccType', 'accountNumber', 'currency_id', 'BIC'];
/**
* AttachmentRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* Moved here from account CRUD * Moved here from account CRUD
* *

View File

@ -31,16 +31,6 @@ class AccountTasker implements AccountTaskerInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* AttachmentRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @see self::amountInPeriod * @see self::amountInPeriod
* *

View File

@ -14,12 +14,12 @@ declare(strict_types = 1);
namespace FireflyIII\Repositories\Attachment; namespace FireflyIII\Repositories\Attachment;
use Carbon\Carbon; use Carbon\Carbon;
use Crypt;
use FireflyIII\Helpers\Attachments\AttachmentHelperInterface; use FireflyIII\Helpers\Attachments\AttachmentHelperInterface;
use FireflyIII\Models\Attachment; use FireflyIII\Models\Attachment;
use FireflyIII\User; use FireflyIII\User;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
use Storage; use Storage;
use Crypt;
/** /**
* Class AttachmentRepository * Class AttachmentRepository
@ -30,22 +30,6 @@ class AttachmentRepository implements AttachmentRepositoryInterface
{ {
/** @var User */ /** @var User */
private $user; private $user;
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/**
* AttachmentRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param Attachment $attachment * @param Attachment $attachment
@ -123,6 +107,14 @@ class AttachmentRepository implements AttachmentRepositoryInterface
return ''; return '';
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param Attachment $attachment * @param Attachment $attachment
* @param array $data * @param array $data

View File

@ -26,11 +26,6 @@ use Illuminate\Support\Collection;
interface AttachmentRepositoryInterface interface AttachmentRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Attachment $attachment * @param Attachment $attachment
* *
@ -65,6 +60,11 @@ interface AttachmentRepositoryInterface
*/ */
public function getContent(Attachment $attachment): string; public function getContent(Attachment $attachment): string;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Attachment $attachment * @param Attachment $attachment
* @param array $attachmentData * @param array $attachmentData

View File

@ -36,22 +36,6 @@ class BillRepository implements BillRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/**
* BillRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param Bill $bill * @param Bill $bill
@ -526,6 +510,14 @@ class BillRepository implements BillRepositoryInterface
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param array $data * @param array $data
* *

View File

@ -26,11 +26,6 @@ use Illuminate\Support\Collection;
*/ */
interface BillRepositoryInterface interface BillRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Bill $bill * @param Bill $bill
* *
@ -164,6 +159,11 @@ interface BillRepositoryInterface
*/ */
public function scan(Bill $bill, TransactionJournal $journal): bool; public function scan(Bill $bill, TransactionJournal $journal): bool;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param array $data * @param array $data
* *

View File

@ -38,22 +38,6 @@ class BudgetRepository implements BudgetRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* BudgetRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @return bool * @return bool
*/ */
@ -439,6 +423,14 @@ class BudgetRepository implements BudgetRepositoryInterface
return true; return true;
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param Collection $budgets * @param Collection $budgets
* @param Collection $accounts * @param Collection $accounts

View File

@ -27,11 +27,6 @@ use Illuminate\Support\Collection;
*/ */
interface BudgetRepositoryInterface interface BudgetRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @return bool * @return bool
*/ */
@ -154,6 +149,11 @@ interface BudgetRepositoryInterface
*/ */
public function setAvailableBudget(TransactionCurrency $currency, Carbon $start, Carbon $end, string $amount): bool; public function setAvailableBudget(TransactionCurrency $currency, Carbon $start, Carbon $end, string $amount): bool;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Collection $budgets * @param Collection $budgets
* @param Collection $accounts * @param Collection $accounts

View File

@ -34,22 +34,6 @@ class CategoryRepository implements CategoryRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* CategoryRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param Category $category * @param Category $category
* *
@ -390,6 +374,14 @@ class CategoryRepository implements CategoryRepositoryInterface
return $result; return $result;
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param Collection $categories * @param Collection $categories
* @param Collection $accounts * @param Collection $accounts

View File

@ -25,11 +25,6 @@ use Illuminate\Support\Collection;
*/ */
interface CategoryRepositoryInterface interface CategoryRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Category $category * @param Category $category
* *
@ -127,6 +122,11 @@ interface CategoryRepositoryInterface
*/ */
public function periodIncomeNoCategory(Collection $accounts, Carbon $start, Carbon $end): array; public function periodIncomeNoCategory(Collection $accounts, Carbon $start, Carbon $end): array;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Collection $categories * @param Collection $categories
* @param Collection $accounts * @param Collection $accounts

View File

@ -30,15 +30,6 @@ class CurrencyRepository implements CurrencyRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* CategoryRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param User $user * @param User $user
*/ */
@ -46,6 +37,7 @@ class CurrencyRepository implements CurrencyRepositoryInterface
{ {
$this->user = $user; $this->user = $user;
} }
/** /**
* @param TransactionCurrency $currency * @param TransactionCurrency $currency
* *

View File

@ -26,11 +26,6 @@ use Illuminate\Support\Collection;
*/ */
interface CurrencyRepositoryInterface interface CurrencyRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param TransactionCurrency $currency * @param TransactionCurrency $currency
* *
@ -100,6 +95,11 @@ interface CurrencyRepositoryInterface
*/ */
public function getCurrencyByPreference(Preference $preference): TransactionCurrency; public function getCurrencyByPreference(Preference $preference): TransactionCurrency;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param array $data * @param array $data
* *

View File

@ -29,22 +29,6 @@ class ExportJobRepository implements ExportJobRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* ExportJobRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param ExportJob $job * @param ExportJob $job
* @param string $status * @param string $status
@ -155,4 +139,12 @@ class ExportJobRepository implements ExportJobRepositoryInterface
return $content; return $content;
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
} }

View File

@ -23,11 +23,6 @@ use FireflyIII\User;
*/ */
interface ExportJobRepositoryInterface interface ExportJobRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param ExportJob $job * @param ExportJob $job
* @param string $status * @param string $status
@ -67,4 +62,9 @@ interface ExportJobRepositoryInterface
*/ */
public function getContent(ExportJob $job): string; public function getContent(ExportJob $job): string;
/**
* @param User $user
*/
public function setUser(User $user);
} }

View File

@ -28,22 +28,6 @@ class ImportJobRepository implements ImportJobRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* ExportJobRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param string $fileType * @param string $fileType
* *
@ -101,4 +85,12 @@ class ImportJobRepository implements ImportJobRepositoryInterface
return $result; return $result;
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
} }

View File

@ -23,11 +23,6 @@ use FireflyIII\User;
*/ */
interface ImportJobRepositoryInterface interface ImportJobRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param string $fileType * @param string $fileType
* *
@ -41,4 +36,9 @@ interface ImportJobRepositoryInterface
* @return ImportJob * @return ImportJob
*/ */
public function findByKey(string $key): ImportJob; public function findByKey(string $key): ImportJob;
/**
* @param User $user
*/
public function setUser(User $user);
} }

View File

@ -43,15 +43,6 @@ class JournalRepository implements JournalRepositoryInterface
/** @var array */ /** @var array */
private $validMetaFields = ['interest_date', 'book_date', 'process_date', 'due_date', 'payment_date', 'invoice_date', 'internal_reference', 'notes']; private $validMetaFields = ['interest_date', 'book_date', 'process_date', 'due_date', 'payment_date', 'invoice_date', 'internal_reference', 'notes'];
/**
* JournalRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param User $user * @param User $user
*/ */
@ -59,6 +50,7 @@ class JournalRepository implements JournalRepositoryInterface
{ {
$this->user = $user; $this->user = $user;
} }
/** /**
* @param TransactionJournal $journal * @param TransactionJournal $journal
* @param TransactionType $type * @param TransactionType $type

View File

@ -27,10 +27,6 @@ use Illuminate\Support\MessageBag;
*/ */
interface JournalRepositoryInterface interface JournalRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param TransactionJournal $journal * @param TransactionJournal $journal
* @param TransactionType $type * @param TransactionType $type
@ -41,11 +37,6 @@ interface JournalRepositoryInterface
*/ */
public function convert(TransactionJournal $journal, TransactionType $type, Account $source, Account $destination): MessageBag; public function convert(TransactionJournal $journal, TransactionType $type, Account $source, Account $destination): MessageBag;
/**
* @return Collection
*/
public function getTransactionTypes(): Collection;
/** /**
* Deletes a journal. * Deletes a journal.
* *
@ -71,6 +62,15 @@ interface JournalRepositoryInterface
*/ */
public function first(): TransactionJournal; public function first(): TransactionJournal;
/**
* @return Collection
*/
public function getTransactionTypes(): Collection;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param array $data * @param array $data

View File

@ -35,15 +35,6 @@ class JournalTasker implements JournalTaskerInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* JournalRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param TransactionJournal $journal * @param TransactionJournal $journal

View File

@ -25,11 +25,6 @@ use Illuminate\Support\Collection;
*/ */
interface JournalTaskerInterface interface JournalTaskerInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param TransactionJournal $journal * @param TransactionJournal $journal
* *
@ -46,4 +41,9 @@ interface JournalTaskerInterface
* @return array * @return array
*/ */
public function getTransactionsOverview(TransactionJournal $journal): array; public function getTransactionsOverview(TransactionJournal $journal): array;
/**
* @param User $user
*/
public function setUser(User $user);
} }

View File

@ -32,22 +32,6 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* PiggyBankRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param PiggyBank $piggyBank * @param PiggyBank $piggyBank
* @param string $amount * @param string $amount
@ -173,6 +157,14 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
return true; return true;
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param array $data * @param array $data
* *

View File

@ -30,22 +30,6 @@ class RuleRepository implements RuleRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* BillRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @return int * @return int
*/ */
@ -224,6 +208,14 @@ class RuleRepository implements RuleRepositoryInterface
} }
/**
* @param User $user
*/
public function setUser(User $user)
{
$this->user = $user;
}
/** /**
* @param array $data * @param array $data
* *

View File

@ -26,10 +26,6 @@ use FireflyIII\User;
*/ */
interface RuleRepositoryInterface interface RuleRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @return int * @return int
*/ */
@ -98,6 +94,11 @@ interface RuleRepositoryInterface
*/ */
public function resetRulesInGroupOrder(RuleGroup $ruleGroup): bool; public function resetRulesInGroupOrder(RuleGroup $ruleGroup): bool;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param array $data * @param array $data
* *

View File

@ -30,15 +30,6 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* BillRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param User $user * @param User $user
*/ */
@ -46,6 +37,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
{ {
$this->user = $user; $this->user = $user;
} }
/** /**
* @return int * @return int
*/ */

View File

@ -34,15 +34,6 @@ class TagRepository implements TagRepositoryInterface
/** @var User */ /** @var User */
private $user; private $user;
/**
* TagRepository constructor.
*
* @param User $user
*/
public function __construct(User $user)
{
$this->user = $user;
}
/** /**
* @param User $user * @param User $user
*/ */
@ -50,6 +41,7 @@ class TagRepository implements TagRepositoryInterface
{ {
$this->user = $user; $this->user = $user;
} }
/** /**
* *
* @param TransactionJournal $journal * @param TransactionJournal $journal

View File

@ -27,11 +27,6 @@ use Illuminate\Support\Collection;
*/ */
interface TagRepositoryInterface interface TagRepositoryInterface
{ {
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* This method will connect a journal with a tag. * This method will connect a journal with a tag.
* *
@ -95,6 +90,11 @@ interface TagRepositoryInterface
*/ */
public function lastUseDate(Tag $tag): Carbon; public function lastUseDate(Tag $tag): Carbon;
/**
* @param User $user
*/
public function setUser(User $user);
/** /**
* @param Tag $tag * @param Tag $tag
* @param Carbon $start * @param Carbon $start