IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-08-17 16:35:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix a variety of Mago issues.

Browse Source
This commit is contained in:
James Cole
2026-03-18 05:26:50 +01:00
parent 0f30eb59a4
commit 1eb4ae3a2c
12 changed files with 108 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Exceptions/Handler.php
+1
View File
@@ -250,6 +250,7 @@ class Handler extends ExceptionHandler
'json' => request()->acceptsJson(), 'json' => request()->acceptsJson(),
'method' => request()->method(), 'method' => request()->method(),
'headers' => $headers, 'headers' => $headers,
// @mago-expect lint:no-request-all
'post' => 'POST' === request()->method() ? json_encode(request()->all()) : '', 'post' => 'POST' === request()->method() ? json_encode(request()->all()) : '',
]; ];
app/Generator/Report/Standard/YearReportGenerator.php
+7 -3
View File
@@ -56,9 +56,13 @@ class YearReportGenerator implements ReportGeneratorInterface
$reportType = 'default'; $reportType = 'default';
try { try {
$result = view('reports.default.year', ['accountIds' => $accountIds, 'reportType' => $reportType]) $result = view('reports.default.year',
->with('start', $this->start) [
->with('end', $this->end) 'accountIds' => $accountIds,
'reportType' => $reportType,
'start' => $this->start,
'end' => $this->end,
])
->render() ->render()
; ;
} catch (Throwable $e) { } catch (Throwable $e) {
app/Generator/Report/Tag/MonthReportGenerator.php
+9 -7
View File
@@ -63,13 +63,15 @@ class MonthReportGenerator implements ReportGeneratorInterface
// render! // render!
try { try {
$result = view('reports.tag.month', ['accountIds' => $accountIds, 'reportType' => $reportType, 'tagIds' => $tagIds]) $result = view('reports.tag.month', [
->with('start', $this->start) 'accountIds' => $accountIds,
->with('end', $this->end) 'reportType' => $reportType,
->with('tags', $this->tags) 'tagIds' => $tagIds,
->with('accounts', $this->accounts) 'start' => $this->start,
->render() 'end' => $this->end,
; 'tags' => $this->tags,
'accounts' => $this->accounts,
])->render();
} catch (Throwable $e) { } catch (Throwable $e) {
Log::error(sprintf('Cannot render reports.tag.month: %s', $e->getMessage())); Log::error(sprintf('Cannot render reports.tag.month: %s', $e->getMessage()));
Log::error($e->getTraceAsString()); Log::error($e->getTraceAsString());
app/Http/Controllers/Admin/NotificationController.php
+1 -1
View File
@@ -132,7 +132,7 @@ final class NotificationController extends Controller
return redirect(route('settings.notification.index')); return redirect(route('settings.notification.index'));
} }
$all = $request->all(); $all = $request->only(['channel']);
$channel = $all['test_submit'] ?? ''; $channel = $all['test_submit'] ?? '';
switch ($channel) { switch ($channel) {
app/Http/Controllers/Auth/RegisterController.php
+2 -2
View File
@@ -83,8 +83,8 @@ final class RegisterController extends Controller
throw new FireflyException('Registration is currently not available :('); throw new FireflyException('Registration is currently not available :(');
} }
$this->validator($request->all())->validate(); $this->validator($request->only(['email', 'password']))->validate();
$user = $this->createUser($request->all()); $user = $this->createUser($request->only(['email', 'password']));
Log::info(sprintf('Registered new user %s', $user->email)); Log::info(sprintf('Registered new user %s', $user->email));
$owner = new OwnerNotifiable(); $owner = new OwnerNotifiable();
event(new NewUserRegistered($owner, $user)); event(new NewUserRegistered($owner, $user));
app/Http/Controllers/Auth/ResetPasswordController.php
+1 -1
View File
@@ -132,7 +132,7 @@ final class ResetPasswordController extends Controller
$allowRegistration = false; $allowRegistration = false;
} }
return view('auth.passwords.reset')->with([ return view('auth.passwords.reset', [
'token' => $token, 'token' => $token,
'email' => $request->email, 'email' => $request->email,
'allowRegistration' => $allowRegistration, 'allowRegistration' => $allowRegistration,
app/Http/Controllers/Budget/BudgetLimitController.php
+5 -5
View File
@@ -137,15 +137,15 @@ final class BudgetLimitController extends Controller
*/ */
public function store(Request $request): JsonResponse|RedirectResponse public function store(Request $request): JsonResponse|RedirectResponse
{ {
Log::debug('Going to store new budget-limit.', $request->all()); Log::debug('Going to store new budget-limit.');
// first search for existing one and update it if necessary. // first search for existing one and update it if necessary.
$currency = $this->currencyRepos->find((int) $request->get('transaction_currency_id')); $currency = $this->currencyRepos->find((int) $request->input('transaction_currency_id'));
$budget = $this->repository->find((int) $request->get('budget_id')); $budget = $this->repository->find((int) $request->input('budget_id'));
if (!$currency instanceof TransactionCurrency || !$budget instanceof Budget) { if (!$currency instanceof TransactionCurrency || !$budget instanceof Budget) {
throw new FireflyException('No valid currency or budget.'); throw new FireflyException('No valid currency or budget.');
} }
$start = Carbon::createFromFormat('Y-m-d', $request->get('start')); $start = Carbon::createFromFormat('Y-m-d', $request->input('start'));
$end = Carbon::createFromFormat('Y-m-d', $request->get('end')); $end = Carbon::createFromFormat('Y-m-d', $request->input('end'));
if (!$start instanceof Carbon || !$end instanceof Carbon) { if (!$start instanceof Carbon || !$end instanceof Carbon) {
return response()->json(); return response()->json();
app/Http/Controllers/PiggyBank/AmountController.php
+1 -1
View File
@@ -135,7 +135,7 @@ final class AmountController extends Controller
*/ */
public function postAdd(Request $request, PiggyBank $piggyBank): RedirectResponse public function postAdd(Request $request, PiggyBank $piggyBank): RedirectResponse
{ {
$data = $request->all(); $data = $request->only(['amount']);
$amounts = $data['amount'] ?? []; $amounts = $data['amount'] ?? [];
$total = '0'; $total = '0';
Log::debug('Start with loop.'); Log::debug('Start with loop.');
app/Http/Controllers/PreferencesController.php
+67 -64
View File
@@ -44,7 +44,6 @@ use Illuminate\Support\Facades\Log;
use Illuminate\View\View; use Illuminate\View\View;
use JsonException; use JsonException;
use Safe\Exceptions\FilesystemException; use Safe\Exceptions\FilesystemException;
use function Safe\file_get_contents; use function Safe\file_get_contents;
use function Safe\json_decode; use function Safe\json_decode;
@@ -61,7 +60,7 @@ final class PreferencesController extends Controller
parent::__construct(); parent::__construct();
$this->middleware(static function ($request, $next) { $this->middleware(static function ($request, $next) {
app('view')->share('title', (string) trans('firefly.preferences')); app('view')->share('title', (string)trans('firefly.preferences'));
app('view')->share('mainTitleIcon', 'fa-gear'); app('view')->share('mainTitleIcon', 'fa-gear');
return $next($request); return $next($request);
@@ -76,22 +75,22 @@ final class PreferencesController extends Controller
* @throws FireflyException * @throws FireflyException
* @throws FilesystemException * @throws FilesystemException
*/ */
public function index(AccountRepositoryInterface $repository): Factory|\Illuminate\Contracts\View\View public function index(AccountRepositoryInterface $repository): Factory | \Illuminate\Contracts\View\View
{ {
$accounts = $repository->getAccountsByType([ $accounts = $repository->getAccountsByType([
AccountTypeEnum::DEFAULT->value, AccountTypeEnum::DEFAULT->value,
AccountTypeEnum::ASSET->value, AccountTypeEnum::ASSET->value,
AccountTypeEnum::LOAN->value, AccountTypeEnum::LOAN->value,
AccountTypeEnum::DEBT->value, AccountTypeEnum::DEBT->value,
AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::MORTGAGE->value,
]); ]);
$isDocker = config('firefly.is_docker'); $isDocker = config('firefly.is_docker');
$groupedAccounts = []; $groupedAccounts = [];
/** @var Account $account */ /** @var Account $account */
foreach ($accounts as $account) { foreach ($accounts as $account) {
$type = $account->accountType->type; $type = $account->accountType->type;
$role = sprintf('opt_group_%s', $repository->getMetaValue($account, 'account_role')); $role = sprintf('opt_group_%s', $repository->getMetaValue($account, 'account_role'));
if (in_array($type, [AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::LOAN->value], true)) { if (in_array($type, [AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::LOAN->value], true)) {
$role = sprintf('opt_group_l_%s', $type); $role = sprintf('opt_group_l_%s', $type);
@@ -100,48 +99,48 @@ final class PreferencesController extends Controller
if ('opt_group_' === $role) { if ('opt_group_' === $role) {
$role = 'opt_group_defaultAsset'; $role = 'opt_group_defaultAsset';
} }
$groupedAccounts[(string) trans(sprintf('firefly.%s', $role))][$account->id] = $account->name; $groupedAccounts[(string)trans(sprintf('firefly.%s', $role))][$account->id] = $account->name;
} }
ksort($groupedAccounts); ksort($groupedAccounts);
/** @var array<int, int> $accountIds */ /** @var array<int, int> $accountIds */
$accountIds = $accounts->pluck('id')->toArray(); $accountIds = $accounts->pluck('id')->toArray();
$viewRange = Navigation::getViewRange(false); $viewRange = Navigation::getViewRange(false);
$frontpageAccountsPref = Preferences::get('frontpageAccounts', $accountIds); $frontpageAccountsPref = Preferences::get('frontpageAccounts', $accountIds);
$frontpageAccounts = $frontpageAccountsPref->data; $frontpageAccounts = $frontpageAccountsPref->data;
if (!is_array($frontpageAccounts)) { if (!is_array($frontpageAccounts)) {
$frontpageAccounts = $accountIds; $frontpageAccounts = $accountIds;
} }
$language = Steam::getLanguage(); $language = Steam::getLanguage();
$languages = config('firefly.languages'); $languages = config('firefly.languages');
$locale = Preferences::get('locale', config('firefly.default_locale', 'equal'))->data; $locale = Preferences::get('locale', config('firefly.default_locale', 'equal'))->data;
$listPageSize = Preferences::get('listPageSize', 50)->data; $listPageSize = Preferences::get('listPageSize', 50)->data;
$darkMode = Preferences::get('darkMode', 'browser')->data; $darkMode = Preferences::get('darkMode', 'browser')->data;
$customFiscalYear = Preferences::get('customFiscalYear', 0)->data; $customFiscalYear = Preferences::get('customFiscalYear', 0)->data;
$fiscalYearStartStr = Preferences::get('fiscalYearStart', '01-01')->data; $fiscalYearStartStr = Preferences::get('fiscalYearStart', '01-01')->data;
$convertToPrimary = $this->convertToPrimary; $convertToPrimary = $this->convertToPrimary;
if (is_array($fiscalYearStartStr)) { if (is_array($fiscalYearStartStr)) {
$fiscalYearStartStr = '01-01'; $fiscalYearStartStr = '01-01';
} }
$fiscalYearStart = sprintf('%s-%s', Carbon::now()->format('Y'), (string) $fiscalYearStartStr); $fiscalYearStart = sprintf('%s-%s', Carbon::now()->format('Y'), (string)$fiscalYearStartStr);
$tjOptionalFields = Preferences::get('transaction_journal_optional_fields', [])->data; $tjOptionalFields = Preferences::get('transaction_journal_optional_fields', [])->data;
$availableDarkModes = config('firefly.available_dark_modes'); $availableDarkModes = config('firefly.available_dark_modes');
// notifications settings // notifications settings
$slackUrl = Preferences::getEncrypted('slack_webhook_url', '')->data; $slackUrl = Preferences::getEncrypted('slack_webhook_url', '')->data;
$pushoverAppToken = (string) Preferences::getEncrypted('pushover_app_token', '')->data; $pushoverAppToken = (string)Preferences::getEncrypted('pushover_app_token', '')->data;
$pushoverUserToken = (string) Preferences::getEncrypted('pushover_user_token', '')->data; $pushoverUserToken = (string)Preferences::getEncrypted('pushover_user_token', '')->data;
$ntfyServer = Preferences::getEncrypted('ntfy_server', 'https://ntfy.sh')->data; $ntfyServer = Preferences::getEncrypted('ntfy_server', 'https://ntfy.sh')->data;
$ntfyTopic = (string) Preferences::getEncrypted('ntfy_topic', '')->data; $ntfyTopic = (string)Preferences::getEncrypted('ntfy_topic', '')->data;
$ntfyAuth = '1' === Preferences::get('ntfy_auth', false)->data; $ntfyAuth = '1' === Preferences::get('ntfy_auth', false)->data;
$ntfyUser = Preferences::getEncrypted('ntfy_user', '')->data; $ntfyUser = Preferences::getEncrypted('ntfy_user', '')->data;
$ntfyPass = (string) Preferences::getEncrypted('ntfy_pass', '')->data; $ntfyPass = (string)Preferences::getEncrypted('ntfy_pass', '')->data;
$channels = config('notifications.channels'); $channels = config('notifications.channels');
$forcedAvailability = []; $forcedAvailability = [];
$anonymous = Steam::anonymous(); $anonymous = Steam::anonymous();
// notification preferences // notification preferences
$notifications = []; $notifications = [];
foreach (config('notifications.notifications.user') as $key => $info) { foreach (config('notifications.notifications.user') as $key => $info) {
if (true === $info['enabled']) { if (true === $info['enabled']) {
$notifications[$key] = [ $notifications[$key] = [
@@ -167,7 +166,7 @@ final class PreferencesController extends Controller
Log::error($e->getMessage()); Log::error($e->getMessage());
$locales = []; $locales = [];
} }
$locales = ['equal' => (string) trans('firefly.equal_to_language')] + $locales; $locales = ['equal' => (string)trans('firefly.equal_to_language')] + $locales;
// an important fallback is that the frontPageAccount array gets refilled automatically // an important fallback is that the frontPageAccount array gets refilled automatically
// when it turns up empty. // when it turns up empty.
if (0 === count($frontpageAccounts)) { if (0 === count($frontpageAccounts)) {
@@ -231,16 +230,17 @@ final class PreferencesController extends Controller
Log::debug('postIndex for preferences.'); Log::debug('postIndex for preferences.');
// front page accounts // front page accounts
$frontpageAccounts = []; $frontpageAccounts = [];
if (is_array($request->get('frontpageAccounts')) && count($request->get('frontpageAccounts')) > 0) { if (is_array($request->input('frontpageAccounts')) && count($request->input('frontpageAccounts')) > 0) {
foreach ($request->get('frontpageAccounts') as $id) { foreach ($request->input('frontpageAccounts') as $id) {
$frontpageAccounts[] = (int) $id; $frontpageAccounts[] = (int)$id;
} }
Log::debug('Update frontpageAccounts', $frontpageAccounts); Log::debug('Update frontpageAccounts', $frontpageAccounts);
Preferences::set('frontpageAccounts', $frontpageAccounts); Preferences::set('frontpageAccounts', $frontpageAccounts);
} }
// extract notifications: // extract notifications:
$all = $request->all(); $keys = array_map(function(string $value): string {return sprintf('notification_%s', $value);}, array_keys(config('notifications.notifications.user')));
$all = $request->only($keys);
foreach (config('notifications.notifications.user') as $key => $info) { foreach (config('notifications.notifications.user') as $key => $info) {
$key = sprintf('notification_%s', $key); $key = sprintf('notification_%s', $key);
if (array_key_exists($key, $all)) { if (array_key_exists($key, $all)) {
@@ -252,10 +252,11 @@ final class PreferencesController extends Controller
Preferences::set($key, false); Preferences::set($key, false);
} }
} }
unset($all);
// view range: // view range:
Log::debug(sprintf('Let viewRange to "%s"', $request->get('viewRange'))); Log::debug(sprintf('Let viewRange to "%s"', $request->input('viewRange')));
Preferences::set('viewRange', $request->get('viewRange')); Preferences::set('viewRange', $request->input('viewRange'));
// forget session values: // forget session values:
session()->forget('start'); session()->forget('start');
session()->forget('end'); session()->forget('end');
@@ -264,6 +265,7 @@ final class PreferencesController extends Controller
// notification settings, cannot be set by the demo user. // notification settings, cannot be set by the demo user.
if (!auth()->user()->hasRole('demo')) { if (!auth()->user()->hasRole('demo')) {
$variables = ['slack_webhook_url', 'pushover_app_token', 'pushover_user_token', 'ntfy_server', 'ntfy_topic', 'ntfy_user', 'ntfy_pass']; $variables = ['slack_webhook_url', 'pushover_app_token', 'pushover_user_token', 'ntfy_server', 'ntfy_topic', 'ntfy_user', 'ntfy_pass'];
$all = $request->only($variables);
foreach ($variables as $variable) { foreach ($variables as $variable) {
if ('' === $all[$variable]) { if ('' === $all[$variable]) {
Preferences::delete($variable); Preferences::delete($variable);
@@ -274,9 +276,10 @@ final class PreferencesController extends Controller
} }
Preferences::set('ntfy_auth', $all['ntfy_auth'] ?? false); Preferences::set('ntfy_auth', $all['ntfy_auth'] ?? false);
} }
unset($all);
// convert primary // convert primary
$convertToPrimary = 1 === (int) $request->get('convertToPrimary'); $convertToPrimary = 1 === (int)$request->input('convertToPrimary');
if ($convertToPrimary && !$this->convertToPrimary) { if ($convertToPrimary && !$this->convertToPrimary) {
// set to true! // set to true!
Log::debug('User sets convertToPrimary to true.'); Log::debug('User sets convertToPrimary to true.');
@@ -288,9 +291,9 @@ final class PreferencesController extends Controller
Preferences::set('convert_to_primary', $convertToPrimary); Preferences::set('convert_to_primary', $convertToPrimary);
// custom fiscal year // custom fiscal year
$customFiscalYear = 1 === (int) $request->get('customFiscalYear'); $customFiscalYear = 1 === (int)$request->input('customFiscalYear');
Preferences::set('customFiscalYear', $customFiscalYear); Preferences::set('customFiscalYear', $customFiscalYear);
$fiscalYearString = (string) $request->get('fiscalYearStart'); $fiscalYearString = (string)$request->input('fiscalYearStart');
if ('' !== $fiscalYearString) { if ('' !== $fiscalYearString) {
$fiscalYearStart = Carbon::parse($fiscalYearString, config('app.timezone'))->format('m-d'); $fiscalYearStart = Carbon::parse($fiscalYearString, config('app.timezone'))->format('m-d');
Preferences::set('fiscalYearStart', $fiscalYearStart); Preferences::set('fiscalYearStart', $fiscalYearStart);
@@ -298,15 +301,15 @@ final class PreferencesController extends Controller
// save page size: // save page size:
Preferences::set('listPageSize', 50); Preferences::set('listPageSize', 50);
$listPageSize = (int) $request->get('listPageSize'); $listPageSize = (int)$request->input('listPageSize');
if ($listPageSize > 0 && $listPageSize < 1337) { if ($listPageSize > 0 && $listPageSize < 1337) {
Preferences::set('listPageSize', $listPageSize); Preferences::set('listPageSize', $listPageSize);
} }
// language: // language:
/** @var Preference $currentLang */ /** @var Preference $currentLang */
$currentLang = Preferences::get('language', 'en_US'); $currentLang = Preferences::get('language', 'en_US');
$lang = $request->get('language'); $lang = $request->input('language');
if (array_key_exists($lang, config('firefly.languages'))) { if (array_key_exists($lang, config('firefly.languages'))) {
Preferences::set('language', $lang); Preferences::set('language', $lang);
} }
@@ -317,14 +320,14 @@ final class PreferencesController extends Controller
// same for locale: // same for locale:
if (!auth()->user()->hasRole('demo')) { if (!auth()->user()->hasRole('demo')) {
$locale = (string) $request->get('locale'); $locale = (string)$request->input('locale');
$locale = '' === $locale ? null : $locale; $locale = '' === $locale ? null : $locale;
Preferences::set('locale', $locale); Preferences::set('locale', $locale);
} }
// optional fields for transactions: // optional fields for transactions:
$setOptions = $request->get('tj') ?? []; $setOptions = $request->input('tj') ?? [];
$optionalTj = [ $optionalTj = [
'interest_date' => array_key_exists('interest_date', $setOptions), 'interest_date' => array_key_exists('interest_date', $setOptions),
'book_date' => array_key_exists('book_date', $setOptions), 'book_date' => array_key_exists('book_date', $setOptions),
'process_date' => array_key_exists('process_date', $setOptions), 'process_date' => array_key_exists('process_date', $setOptions),
@@ -341,17 +344,17 @@ final class PreferencesController extends Controller
Preferences::set('transaction_journal_optional_fields', $optionalTj); Preferences::set('transaction_journal_optional_fields', $optionalTj);
// dark mode // dark mode
$darkMode = $request->get('darkMode') ?? 'browser'; $darkMode = $request->input('darkMode') ?? 'browser';
if (in_array($darkMode, config('firefly.available_dark_modes'), true)) { if (in_array($darkMode, config('firefly.available_dark_modes'), true)) {
Preferences::set('darkMode', $darkMode); Preferences::set('darkMode', $darkMode);
} }
// anonymous amounts? // anonymous amounts?
$anonymous = '1' === $request->get('anonymous'); $anonymous = '1' === $request->input('anonymous');
Preferences::set('anonymous', $anonymous); Preferences::set('anonymous', $anonymous);
// save and continue // save and continue
session()->flash('success', (string) trans('firefly.saved_preferences')); session()->flash('success', (string)trans('firefly.saved_preferences'));
Preferences::mark(); Preferences::mark();
Log::debug('Done saving settings.'); Log::debug('Done saving settings.');
@@ -360,12 +363,12 @@ final class PreferencesController extends Controller
public function testNotification(Request $request): mixed public function testNotification(Request $request): mixed
{ {
$all = $request->all(); $all = $request->only(['channel']);
$channel = $all['channel'] ?? ''; $channel = $all['channel'] ?? '';
switch ($channel) { switch ($channel) {
default: default:
session()->flash('error', (string) trans('firefly.notification_test_failed', ['channel' => $channel])); session()->flash('error', (string)trans('firefly.notification_test_failed', ['channel' => $channel]));
break; break;
@@ -377,7 +380,7 @@ final class PreferencesController extends Controller
$user = auth()->user(); $user = auth()->user();
Log::debug(sprintf('Now in testNotification("%s") controller.', $channel)); Log::debug(sprintf('Now in testNotification("%s") controller.', $channel));
event(new UserTestsNotificationChannel($channel, $user)); event(new UserTestsNotificationChannel($channel, $user));
session()->flash('success', (string) trans('firefly.notification_test_executed', ['channel' => $channel])); session()->flash('success', (string)trans('firefly.notification_test_executed', ['channel' => $channel]));
} }
return ''; return '';
app/Http/Controllers/Transaction/ConvertController.php
+1 -1
View File
@@ -153,7 +153,7 @@ final class ConvertController extends Controller
foreach ($group->transactionJournals as $journal) { foreach ($group->transactionJournals as $journal) {
// catch FF exception. // catch FF exception.
try { try {
$this->convertJournal($journal, $destinationType, $request->all()); $this->convertJournal($journal, $destinationType, $request->only(['source_id', 'source_name', 'destination_id', 'destination_name',]));
} catch (FireflyException $e) { } catch (FireflyException $e) {
session()->flash('error', $e->getMessage()); session()->flash('error', $e->getMessage());
app/Http/Controllers/UserGroup/EditController.php
+1 -1
View File
@@ -43,6 +43,6 @@ final class EditController extends Controller
$mainTitleIcon = 'fa-book'; $mainTitleIcon = 'fa-book';
Log::debug(sprintf('Now at %s', __METHOD__)); Log::debug(sprintf('Now at %s', __METHOD__));
return view('administrations.edit')->with(['title' => $title, 'subTitle' => $subTitle, 'mainTitleIcon' => $mainTitleIcon]); return view('administrations.edit', ['title' => $title, 'subTitle' => $subTitle, 'mainTitleIcon' => $mainTitleIcon]);
} }
} }
mago.toml
+12 -12
View File
@@ -24,18 +24,12 @@ integrations = ["symfony", "laravel", "phpunit"]
excludes = ["app/Providers/AppServiceProvider.php"] # Additionally excluded from linter only excludes = ["app/Providers/AppServiceProvider.php"] # Additionally excluded from linter only
[linter.rules] [linter.rules]
ambiguous-function-call = { enabled = false } halstead = { effort-threshold = 250000, volume-threshold = 200000, difficulty-threshold = 1000, enabled = true } # way too high
literal-named-argument = { enabled = false } cyclomatic-complexity = { enabled = true, threshold = 255 } # way too high
halstead = { effort-threshold = 7000, enabled = false } kan-defect = { enabled = true, threshold = 20 } # way too high
prefer-early-continue = { enabled = false } too-many-properties = { enabled = true, threshold = 25 } # way too high
cyclomatic-complexity = { enabled = false } no-request-all = { enabled = true }
middleware-in-routes = { enabled = false } prefer-view-array = { enabled = false } # to be continued.
too-many-methods = { enabled = false }
kan-defect = { enabled = false }
no-request-all = { enabled = false }
tagged-todo = { enabled = false }
too-many-properties = { enabled = false }
prefer-view-array = { enabled = false }
assertion-style = { enabled = false } assertion-style = { enabled = false }
no-boolean-flag-parameter = { enabled = false } no-boolean-flag-parameter = { enabled = false }
prefer-static-closure = { enabled = false } prefer-static-closure = { enabled = false }
@@ -45,6 +39,12 @@ tagged-fixme = { enabled = false }
excessive-parameter-list = { enabled = false } excessive-parameter-list = { enabled = false }
prefer-first-class-callable={ enabled = false } prefer-first-class-callable={ enabled = false }
prefer-arrow-function = { enabled = false } prefer-arrow-function = { enabled = false }
ambiguous-function-call = { enabled = false } # very specific rule.
literal-named-argument = { enabled = false } # insanely specific.
prefer-early-continue = { enabled = false } # does NOT improve readability.
middleware-in-routes = { enabled = false } # I like to do this.
too-many-methods = { enabled = false, threshold = 100 } # arbitrary nonsense.
tagged-todo = { enabled = false } # weird rule