IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2024-11-23 09:26:29 -06:00
Code Issues Packages Projects Releases Wiki Activity

Code cleanup

Browse Source
This commit is contained in:
James Cole 2019-08-17 10:47:10 +02:00
parent 44823c6fec
commit 23479790fe
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
45 changed files with 38 additions and 177 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/Account/EditController.php
View File

@ -75,8 +75,6 @@ class EditController extends Controller
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function edit(Request $request, Account $account, AccountRepositoryInterface $repository)
{

4
app/Http/Controllers/Account/ShowController.php
View File

@ -39,7 +39,7 @@ use View;
/**
* Class ShowController
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class ShowController extends Controller
{
@ -138,8 +138,6 @@ class ShowController extends Controller
* @param Request $request
* @param Account $account
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|View
*
*
* @throws Exception
*/
public function showAll(Request $request, Account $account)

4
app/Http/Controllers/BillController.php
View File

@ -43,7 +43,7 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class BillController.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class BillController extends Controller
{
@ -339,8 +339,6 @@ class BillController extends Controller
*
* @return RedirectResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function store(BillFormRequest $request): RedirectResponse
{

5
app/Http/Controllers/Budget/AmountController.php
View File

@ -25,18 +25,15 @@ namespace FireflyIII\Http\Controllers\Budget;
use Carbon\Carbon;
use FireflyIII\Helpers\Collector\GroupCollectorInterface;
use FireflyIII\Http\Controllers\Controller;
use FireflyIII\Http\Requests\BudgetIncomeRequest;
use FireflyIII\Models\Budget;
use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Support\Http\Controllers\DateCalculation;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Log;
/**
* Class AmountController
@ -75,8 +72,6 @@ class AmountController extends Controller
* @param Budget $budget
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function amount(Request $request, Budget $budget): JsonResponse
{

2
app/Http/Controllers/Budget/IndexController.php
View File

@ -74,8 +74,6 @@ class IndexController extends Controller
* @param Carbon|null $end
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function index(Request $request, Carbon $start = null, Carbon $end = null)
{

3
app/Http/Controllers/Category/ShowController.php
View File

@ -31,13 +31,12 @@ use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
use FireflyIII\Support\Http\Controllers\PeriodOverview;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Log;
/**
*
* Class ShowController
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class ShowController extends Controller
{

8
app/Http/Controllers/Chart/AccountController.php
View File

@ -43,9 +43,9 @@ use Log;
/**
* Class AccountController.
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*
*
*/
class AccountController extends Controller
{
@ -436,8 +436,6 @@ class AccountController extends Controller
* @param Carbon $end
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function period(Account $account, Carbon $start, Carbon $end): JsonResponse
{

12
app/Http/Controllers/Chart/BudgetController.php
View File

@ -40,8 +40,8 @@ use Illuminate\Support\Collection;
/**
* Class BudgetController.
*
* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*
*
*/
class BudgetController extends Controller
@ -181,8 +181,6 @@ class BudgetController extends Controller
* @param BudgetLimit|null $budgetLimit
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function expenseAsset(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse
{
@ -232,8 +230,6 @@ class BudgetController extends Controller
* @param BudgetLimit|null $budgetLimit
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function expenseCategory(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse
{
@ -282,8 +278,6 @@ class BudgetController extends Controller
* @param BudgetLimit|null $budgetLimit
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function expenseExpense(Budget $budget, ?BudgetLimit $budgetLimit): JsonResponse
{
@ -333,8 +327,6 @@ class BudgetController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function frontpage(): JsonResponse
{

8
app/Http/Controllers/Chart/BudgetReportController.php
View File

@ -39,7 +39,7 @@ use Illuminate\Support\Collection;
*
* Class BudgetReportController
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class BudgetReportController extends Controller
{
@ -79,8 +79,6 @@ class BudgetReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function accountExpense(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -110,8 +108,6 @@ class BudgetReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function budgetExpense(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -141,8 +137,6 @@ class BudgetReportController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function mainChart(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end): JsonResponse
{

6
app/Http/Controllers/Chart/CategoryController.php
View File

@ -71,8 +71,6 @@ class CategoryController extends Controller
* @param Category $category
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function all(CategoryRepositoryInterface $repository, Category $category): JsonResponse
{
@ -204,8 +202,6 @@ class CategoryController extends Controller
* @param Carbon $end
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function reportPeriod(Category $category, Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{
@ -272,8 +268,6 @@ class CategoryController extends Controller
* @param Carbon $end
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function reportPeriodNoCategory(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{

12
app/Http/Controllers/Chart/CategoryReportController.php
View File

@ -74,8 +74,6 @@ class CategoryReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function accountExpense(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -102,8 +100,6 @@ class CategoryReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function accountIncome(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -133,8 +129,6 @@ class CategoryReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function categoryExpense(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -164,7 +158,7 @@ class CategoryReportController extends Controller
* @param string $others
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*
*/
public function categoryIncome(Collection $accounts, Collection $categories, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -195,9 +189,7 @@ class CategoryReportController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*/
public function mainChart(Collection $accounts, Collection $categories, Carbon $start, Carbon $end): JsonResponse
{

4
app/Http/Controllers/Chart/ExpenseReportController.php
View File

@ -77,9 +77,7 @@ class ExpenseReportController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.NPathComplexity)
*
*/
public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse
{

2
app/Http/Controllers/Chart/PiggyBankController.php
View File

@ -63,8 +63,6 @@ class PiggyBankController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function history(PiggyBankRepositoryInterface $repository, PiggyBank $piggyBank): JsonResponse
{

4
app/Http/Controllers/Chart/ReportController.php
View File

@ -138,8 +138,6 @@ class ReportController extends Controller
* @param Carbon $end
*
* @return \Illuminate\Http\JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function operations(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{
@ -200,8 +198,6 @@ class ReportController extends Controller
*
* @return \Illuminate\Http\JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function sum(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{

16
app/Http/Controllers/Chart/TagReportController.php
View File

@ -66,8 +66,6 @@ class TagReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function accountExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -97,8 +95,6 @@ class TagReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function accountIncome(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -127,8 +123,6 @@ class TagReportController extends Controller
* @param Carbon $end
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function budgetExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse
{
@ -157,8 +151,6 @@ class TagReportController extends Controller
* @param Carbon $end
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function categoryExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse
{
@ -188,9 +180,7 @@ class TagReportController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*/
public function mainChart(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse
{
@ -305,8 +295,6 @@ class TagReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function tagExpense(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse
{
@ -336,8 +324,6 @@ class TagReportController extends Controller
* @param string $others
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
*/
public function tagIncome(Collection $accounts, Collection $tags, Carbon $start, Carbon $end, string $others): JsonResponse
{

2
app/Http/Controllers/Controller.php
View File

@ -33,7 +33,7 @@ use Route;
/**
* Class Controller.
*
* @SuppressWarnings(PHPMD.NumberOfChildren)
*
*/
class Controller extends BaseController
{

2
app/Http/Controllers/CurrencyController.php
View File

@ -333,8 +333,6 @@ class CurrencyController extends Controller
* @param CurrencyFormRequest $request
*
* @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function store(CurrencyFormRequest $request)
{

6
app/Http/Controllers/DebugController.php
View File

@ -39,7 +39,7 @@ use Route as RouteFacade;
/**
* Class DebugController
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class DebugController extends Controller
{
@ -113,8 +113,6 @@ class DebugController extends Controller
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function index(Request $request)
{
@ -192,8 +190,6 @@ class DebugController extends Controller
* Return all possible routes.
*
* @return string
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function routes(): string
{

2
app/Http/Controllers/Import/IndexController.php
View File

@ -71,8 +71,6 @@ class IndexController extends Controller
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function create(string $importProvider)
{

4
app/Http/Controllers/Import/JobConfigurationController.php
View File

@ -68,8 +68,6 @@ class JobConfigurationController extends Controller
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function index(ImportJob $importJob)
{
@ -119,8 +117,6 @@ class JobConfigurationController extends Controller
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function post(Request $request, ImportJob $importJob)
{

8
app/Http/Controllers/Import/PrerequisitesController.php
View File

@ -67,8 +67,6 @@ class PrerequisitesController extends Controller
* @param ImportJob $importJob
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function index(string $importProvider, ImportJob $importJob = null)
{
@ -111,15 +109,13 @@ class PrerequisitesController extends Controller
* Whatever storePrerequisites does, it should make sure that the system is ready to continue immediately. So
* no extra calls or stuff, except maybe to open a session
*
* @see PrerequisitesInterface::storePrerequisites
*
* @param Request $request
* @param string $importProvider
* @param ImportJob $importJob
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @see PrerequisitesInterface::storePrerequisites
*
*/
public function post(Request $request, string $importProvider, ImportJob $importJob = null)
{

2
app/Http/Controllers/Json/AutoCompleteController.php
View File

@ -43,7 +43,7 @@ use Log;
*
* TODO autocomplete for transaction types.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class AutoCompleteController extends Controller
{

6
app/Http/Controllers/Json/BoxController.php
View File

@ -52,8 +52,6 @@ class BoxController extends Controller
* @param BudgetRepositoryInterface $repository
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function available(BudgetRepositoryInterface $repository): JsonResponse
{
@ -110,8 +108,6 @@ class BoxController extends Controller
* @param CurrencyRepositoryInterface $repository
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function balance(CurrencyRepositoryInterface $repository): JsonResponse
{
@ -237,8 +233,6 @@ class BoxController extends Controller
* Total user net worth.
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function netWorth(): JsonResponse
{

6
app/Http/Controllers/Json/RecurrenceController.php
View File

@ -63,11 +63,9 @@ class RecurrenceController extends Controller
*
* @param Request $request
*
* @throws FireflyException
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
* @throws FireflyException
*/
public function events(Request $request): JsonResponse
{

8
app/Http/Controllers/PiggyBankController.php
View File

@ -41,8 +41,8 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class PiggyBankController.
*
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*
*/
class PiggyBankController extends Controller
{
@ -188,8 +188,6 @@ class PiggyBankController extends Controller
* @param PiggyBank $piggyBank
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function edit(PiggyBank $piggyBank)
{
@ -230,8 +228,6 @@ class PiggyBankController extends Controller
* @param Request $request
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function index(Request $request)
{

4
app/Http/Controllers/Popup/ReportController.php
View File

@ -31,7 +31,7 @@ use Illuminate\Http\Request;
/**
* Class ReportController.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class ReportController extends Controller
{
@ -43,7 +43,7 @@ class ReportController extends Controller
* @param Request $request
*
* @return JsonResponse
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function general(Request $request): JsonResponse
{

2
app/Http/Controllers/PreferencesController.php
View File

@ -100,8 +100,6 @@ class PreferencesController extends Controller
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function postIndex(Request $request)
{

8
app/Http/Controllers/ProfileController.php
View File

@ -51,8 +51,8 @@ use PragmaRX\Recovery\Recovery;
* Class ProfileController.
*
* @method Guard guard()
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
*
*
*/
class ProfileController extends Controller
{
@ -438,8 +438,6 @@ class ProfileController extends Controller
* @param TokenFormRequest $request
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function postCode(TokenFormRequest $request)
{
@ -524,8 +522,6 @@ class ProfileController extends Controller
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function undoEmailChange(UserRepositoryInterface $repository, string $token, string $hash)
{

2
app/Http/Controllers/Recurring/EditController.php
View File

@ -77,8 +77,6 @@ class EditController extends Controller
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
* @throws \FireflyIII\Exceptions\FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function edit(Request $request, Recurrence $recurrence)
{

2
app/Http/Controllers/Recurring/IndexController.php
View File

@ -74,7 +74,7 @@ class IndexController extends Controller
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
* @throws \FireflyIII\Exceptions\FireflyException
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function index(Request $request)
{

8
app/Http/Controllers/ReportController.php
View File

@ -38,7 +38,7 @@ use Log;
/**
* Class ReportController.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class ReportController extends Controller
{
@ -276,7 +276,7 @@ class ReportController extends Controller
* @param string $reportType
*
* @return mixed
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function options(string $reportType)
{
@ -310,9 +310,7 @@ class ReportController extends Controller
*
* @throws \FireflyIII\Exceptions\FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*/
public function postIndex(ReportFormRequest $request)
{

6
app/Http/Controllers/Rule/CreateController.php
View File

@ -70,8 +70,6 @@ class CreateController extends Controller
* @param RuleGroup $ruleGroup
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function create(Request $request, RuleGroup $ruleGroup = null)
{
@ -120,8 +118,6 @@ class CreateController extends Controller
* @param Bill $bill
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function createFromBill(Request $request, Bill $bill)
{
@ -168,7 +164,7 @@ class CreateController extends Controller
* @param RuleFormRequest $request
*
* @return RedirectResponse|\Illuminate\Routing\Redirector
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function store(RuleFormRequest $request)
{

2
app/Http/Controllers/Rule/EditController.php
View File

@ -70,8 +70,6 @@ class EditController extends Controller
* @param Rule $rule
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function edit(Request $request, Rule $rule)
{

1
app/Http/Controllers/Rule/IndexController.php
View File

@ -135,7 +135,6 @@ class IndexController extends Controller
* @param Rule $rule
*
* @return RedirectResponse|\Illuminate\Routing\Redirector
* @SuppressWarnings(PHPMD.ShortMethodName)
*/
public function up(Rule $rule)
{

6
app/Http/Controllers/Rule/SelectController.php
View File

@ -47,7 +47,7 @@ use Throwable;
/**
* Class SelectController.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class SelectController extends Controller
{
@ -147,8 +147,6 @@ class SelectController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function testTriggers(TestRuleFormRequest $request): JsonResponse
{
@ -216,8 +214,6 @@ class SelectController extends Controller
*
* @return JsonResponse
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function testTriggersByRule(Rule $rule): JsonResponse
{

1
app/Http/Controllers/RuleGroup/EditController.php
View File

@ -105,7 +105,6 @@ class EditController extends Controller
*
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*
* @SuppressWarnings(PHPMD.ShortMethodName)
*/
public function up(RuleGroup $ruleGroup)
{

5
app/Http/Controllers/TagController.php
View File

@ -31,7 +31,6 @@ use FireflyIII\Repositories\Tag\TagRepositoryInterface;
use FireflyIII\Support\Http\Controllers\PeriodOverview;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;
use Log;
/**
@ -177,8 +176,6 @@ class TagController extends Controller
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function show(Request $request, Tag $tag, Carbon $start = null, Carbon $end = null)
{
@ -219,8 +216,6 @@ class TagController extends Controller
*
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function showAll(Request $request, Tag $tag)
{

2
app/Http/Controllers/Transaction/BulkController.php
View File

@ -92,8 +92,6 @@ class BulkController extends Controller
* @param BulkEditJournalRequest $request
*
* @return mixed
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function update(BulkEditJournalRequest $request)
{

4
app/Http/Controllers/Transaction/MassController.php
View File

@ -42,7 +42,7 @@ use Log;
/**
* Class MassController.
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class MassController extends Controller
{
@ -90,7 +90,7 @@ class MassController extends Controller
* @param MassDeleteJournalRequest $request
*
* @return mixed
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function destroy(MassDeleteJournalRequest $request)
{

2
app/Http/Middleware/Authenticate.php
View File

@ -83,8 +83,6 @@ class Authenticate
* @return mixed
* @throws AuthenticationException
* @throws FireflyException
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
protected function authenticate($request, array $guards)
{

6
app/Http/Middleware/Installer.php
View File

@ -41,15 +41,13 @@ class Installer
/**
* Handle an incoming request.
*
* @throws FireflyException
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
*
* @return mixed
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
* @throws FireflyException
*
*/
public function handle($request, Closure $next)

2
app/Http/Middleware/Range.php
View File

@ -118,8 +118,6 @@ class Range
/**
* Set the range for the current view.
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
private function setRange(): void
{

8
app/Http/Requests/RecurrenceFormRequest.php
View File

@ -56,8 +56,6 @@ class RecurrenceFormRequest extends Request
* @return array
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function getAll(): array
{
@ -225,9 +223,7 @@ class RecurrenceFormRequest extends Request
* @return array
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.NPathComplexity)
*
*/
public function rules(): array
{
@ -318,8 +314,6 @@ class RecurrenceFormRequest extends Request
* Parses repetition data.
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
private function parseRepetitionData(): array
{

4
app/Http/Requests/Request.php
View File

@ -33,7 +33,7 @@ use Log;
*
* @codeCoverageIgnore
*
* @SuppressWarnings(PHPMD.NumberOfChildren)
*
*/
class Request extends FormRequest
{
@ -183,8 +183,6 @@ class Request extends FormRequest
* @param string $field
*
* @return string
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*/
public function string(string $field): string
{

2
app/Http/Requests/RuleFormRequest.php
View File

@ -45,8 +45,6 @@ class RuleFormRequest extends Request
*
* @return array
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*/
public function getRuleData(): array
{