From 2b9996b84436263856cb92f1f91817a57457aa1a Mon Sep 17 00:00:00 2001
From: James Cole <james@firefly-iii.org>
Date: Fri, 30 Dec 2022 20:48:48 +0100
Subject: [PATCH] Remove some unreachable code.

---
 app/Api/V2/Controllers/Chart/AccountController.php |  1 -
 .../Report/Category/MonthReportGenerator.php       |  2 --
 .../Report/Standard/MonthReportGenerator.php       |  2 --
 .../Report/Standard/MultiYearReportGenerator.php   |  2 --
 resources/assets/js/components/webhooks/Index.vue  |  2 +-
 resources/assets/js/components/webhooks/Show.vue   | 14 +++++++-------
 6 files changed, 8 insertions(+), 15 deletions(-)

diff --git a/app/Api/V2/Controllers/Chart/AccountController.php b/app/Api/V2/Controllers/Chart/AccountController.php
index 185947b255..a9e396cc68 100644
--- a/app/Api/V2/Controllers/Chart/AccountController.php
+++ b/app/Api/V2/Controllers/Chart/AccountController.php
@@ -121,6 +121,5 @@ class AccountController extends Controller
         }
 
         return response()->json($chartData);
-        return response()->json(['x']);
     }
 }
diff --git a/app/Generator/Report/Category/MonthReportGenerator.php b/app/Generator/Report/Category/MonthReportGenerator.php
index 5c2f2856e7..0422ad565d 100644
--- a/app/Generator/Report/Category/MonthReportGenerator.php
+++ b/app/Generator/Report/Category/MonthReportGenerator.php
@@ -86,8 +86,6 @@ class MonthReportGenerator implements ReportGeneratorInterface
             $result = sprintf('Could not render report view: %s', $e->getMessage());
             throw new FireflyException($result, 0, $e);
         }
-
-        return $result;
     }
 
     /**
diff --git a/app/Generator/Report/Standard/MonthReportGenerator.php b/app/Generator/Report/Standard/MonthReportGenerator.php
index b84476aa0b..de98825895 100644
--- a/app/Generator/Report/Standard/MonthReportGenerator.php
+++ b/app/Generator/Report/Standard/MonthReportGenerator.php
@@ -61,8 +61,6 @@ class MonthReportGenerator implements ReportGeneratorInterface
             $result = 'Could not render report view.';
             throw new FireflyException($result, 0, $e);
         }
-
-        return $result;
     }
 
     /**
diff --git a/app/Generator/Report/Standard/MultiYearReportGenerator.php b/app/Generator/Report/Standard/MultiYearReportGenerator.php
index 4cdec1f11f..79c5441a1e 100644
--- a/app/Generator/Report/Standard/MultiYearReportGenerator.php
+++ b/app/Generator/Report/Standard/MultiYearReportGenerator.php
@@ -65,8 +65,6 @@ class MultiYearReportGenerator implements ReportGeneratorInterface
             $result = sprintf('Could not render report view: %s', $e->getMessage());
             throw new FireflyException($result, 0, $e);
         }
-
-        return $result;
     }
 
     /**
diff --git a/resources/assets/js/components/webhooks/Index.vue b/resources/assets/js/components/webhooks/Index.vue
index d78cfeaf17..f8196b16b3 100644
--- a/resources/assets/js/components/webhooks/Index.vue
+++ b/resources/assets/js/components/webhooks/Index.vue
@@ -32,7 +32,7 @@
             <a href="webhooks/create" class="btn btn-success"><span class="fa fa-plus fa-fw"></span>{{ $t('firefly.create_new_webhook') }}</a>
           </div>
 
-          <table class="table table-responsive table-hover" v-if="webhooks.length > 0">
+          <table class="table table-responsive table-hover" v-if="webhooks.length > 0" aria-label="A table.">
             <thead>
             <tr>
               <th>Title</th>
diff --git a/resources/assets/js/components/webhooks/Show.vue b/resources/assets/js/components/webhooks/Show.vue
index 69cfe382c1..1521c7dd4d 100644
--- a/resources/assets/js/components/webhooks/Show.vue
+++ b/resources/assets/js/components/webhooks/Show.vue
@@ -40,26 +40,26 @@
             <table class="table table-hover">
               <tbody>
               <tr>
-                <td style="width:40%;">Title</td>
+                <th style="width:40%;">Title</th>
                 <td>{{ title }}</td>
               </tr>
               <tr>
-                <td>{{ $t('list.active') }}</td>
+                <th>{{ $t('list.active') }}</th>
                 <td>
                   <em class="fa fa-check text-success" v-if="active"></em>
                   <em class="fa fa-times text-danger" v-if="!active"></em>
                 </td>
               </tr>
               <tr>
-                <td>{{ $t('list.trigger') }}</td>
+                <th>{{ $t('list.trigger') }}</th>
                 <td> {{ trigger }}</td>
               </tr>
               <tr>
-                <td>{{ $t('list.response') }}</td>
+                <th>{{ $t('list.response') }}</th>
                 <td> {{ response }}</td>
               </tr>
               <tr>
-                <td>{{ $t('list.delivery') }}</td>
+                <th>{{ $t('list.delivery') }}</th>
                 <td> {{ delivery }}</td>
               </tr>
               </tbody>
@@ -85,7 +85,7 @@
             <table class="table table-hover">
               <tbody>
               <tr>
-                <td style="width:40%;">{{ $t('list.url') }}</td>
+                <th style="width:40%;">{{ $t('list.url') }}</th>
                 <td><input type="text" readonly class="form-control" :value=url></td>
               </tr>
               <tr>
@@ -128,7 +128,7 @@
             </p>
           </div>
           <div class="box-body no-padding" v-if="messages.length > 0">
-            <table class="table table-hover">
+            <table class="table table-hover" aria-label="A table">
               <thead>
               <tr>
                 <th>