IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-01-19 13:03:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

Experimental new transfer filter.

Browse Source
This commit is contained in:
James Cole 2017-02-10 17:21:44 +01:00
parent b9dac5ff55
commit 3914796e4e
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
1 changed files with 12 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
app/Helpers/Collector/JournalCollector.php
View File

@ -618,7 +618,7 @@ class JournalCollector implements JournalCollectorInterface
* account, chances are the set include double entries: transfers get selected
* on both the source, and then again on the destination account.
*
* This method filters them out.
* This method filters them out by removing transfers that have been selected twice.
*
* @param Collection $set
*
@ -627,36 +627,18 @@ class JournalCollector implements JournalCollectorInterface
private function filterTransfers(Collection $set): Collection
{
if ($this->filterTransfers) {
$set = $set->filter(
function (Transaction $transaction) {
if (!($transaction->transaction_type_type === TransactionType::TRANSFER && bccomp($transaction->transaction_amount, '0') === -1)) {
Log::debug(
sprintf(
'Included journal #%d (transaction #%d) because its a %s with amount %f',
$transaction->transaction_journal_id,
$transaction->id,
$transaction->transaction_type_type,
$transaction->transaction_amount
)
);
return $transaction;
}
Log::debug(
sprintf(
'Removed journal #%d (transaction #%d) because its a %s with amount %f',
$transaction->transaction_journal_id,
$transaction->id,
$transaction->transaction_type_type,
$transaction->transaction_amount
)
);
return false;
$count = [];
$new = new Collection;
/** @var Transaction $transaction */
foreach($set as $transaction) {
$journalId =$transaction->transaction_journal_id;
if(!isset($count[$journalId]) ) {
// not yet counted? add to new set and count it:
$new->push($transaction);
$count[$journalId] = 1;
}
);
}
return $new;
}
return $set;