First code set for #330

app/Http/Controllers/Transaction/ConvertController.php

@@ -0,0 +1,108 @@
+<?php
+/**
+ * ConvertController.php
+ * Copyright (C) 2016 thegrumpydictator@gmail.com
+ *
+ * This software may be modified and distributed under the terms of the
+ * Creative Commons Attribution-ShareAlike 4.0 International License.
+ *
+ * See the LICENSE file for details.
+ */
+
+declare(strict_types = 1);
+
+namespace FireflyIII\Http\Controllers\Transaction;
+
+use ExpandedForm;
+use FireflyIII\Http\Controllers\Controller;
+use FireflyIII\Models\AccountType;
+use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
+use FireflyIII\Repositories\Account\AccountRepositoryInterface;
+use Illuminate\Http\Request;
+use Session;
+use View;
+
+/**
+ * Class ConvertController
+ *
+ * @package FireflyIII\Http\Controllers\Transaction
+ */
+class ConvertController extends Controller
+{
+    /** @var  AccountRepositoryInterface */
+    private $accounts;
+
+    /**
+     * ConvertController constructor.
+     */
+    public function __construct()
+    {
+        parent::__construct();
+
+        // some useful repositories:
+        $this->middleware(
+            function ($request, $next) {
+                $this->accounts = app(AccountRepositoryInterface::class);
+
+                View::share('title', trans('firefly.transactions'));
+                View::share('mainTitleIcon', 'fa-exchange');
+
+                return $next($request);
+            }
+        );
+    }
+
+    /**
+     * @param TransactionType    $destinationType
+     * @param TransactionJournal $journal
+     *
+     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector|View
+     */
+    public function convert(TransactionType $destinationType, TransactionJournal $journal)
+    {
+        $positiveAmount = TransactionJournal::amountPositive($journal);
+        $assetAccounts  = ExpandedForm::makeSelectList($this->accounts->getActiveAccountsByType([AccountType::DEFAULT, AccountType::ASSET]));
+        $sourceType     = $journal->transactionType;
+
+        $subTitle     = trans('firefly.convert_to_' . $destinationType->type, ['description' => $journal->description]);
+        $subTitleIcon = 'fa-exchange';
+
+        if ($sourceType->type === $destinationType->type) {
+            Session::flash('info', trans('firefly.convert_is_already_type_' . $destinationType->type));
+
+            return redirect(route('transactions.show', [$journal->id]));
+        }
+        if ($journal->transactions()->count() > 2) {
+            Session::flash('error', trans('firefly.cannot_convert_split_journl'));
+
+            return redirect(route('transactions.show', [$journal->id]));
+        }
+        $sourceAccount      = TransactionJournal::sourceAccountList($journal)->first();
+        $destinationAccount = TransactionJournal::destinationAccountList($journal)->first();
+
+        return view(
+            'transactions.convert', compact(
+                                      'sourceType', 'destinationType', 'journal', 'assetAccounts',
+                                      'positiveAmount', 'sourceAccount', 'destinationAccount', 'sourceType',
+                                      'subTitle', 'subTitleIcon'
+
+                                  )
+        );
+
+
+        // convert withdrawal to deposit requires a new source account ()
+        //  or to transfer requires
+    }
+
+    public function submit(Request $request)
+    {
+        echo '<pre>';
+
+        var_dump($request->all());
+
+
+        exit;
+    }
+
+}

app/Http/breadcrumbs.php

@@ -25,6 +25,7 @@ use FireflyIII\Models\RuleGroup;
 use FireflyIII\Models\Tag;
 use FireflyIII\Models\TransactionCurrency;
 use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\User;
 
 /**
@@ -595,13 +596,24 @@ Breadcrumbs::register(
 Breadcrumbs::register(
     'transactions.show', function (BreadCrumbGenerator $breadcrumbs, TransactionJournal $journal) {
 
-    $what = strtolower($journal->transaction_type_type ?? $journal->transactionType->type);
+    $what = strtolower($journal->transactionType->type);
     $breadcrumbs->parent('transactions.index', $what);
     $breadcrumbs->push($journal->description, route('transactions.show', [$journal->id]));
-
 }
 );
 
+Breadcrumbs::register(
+    'transactions.convert', function (BreadCrumbGenerator $breadcrumbs, TransactionType $destinationType, TransactionJournal $journal) {
+
+    $breadcrumbs->parent('transactions.show', $journal);
+    $breadcrumbs->push(
+        trans('firefly.convert_to_' . $destinationType->type, ['description' => $journal->description]),
+        route('transactions.convert', [strtolower($destinationType->type), $journal->id])
+    );
+}
+);
+
+
 /**
  * SPLIT
  */

app/Models/TransactionType.php

@@ -15,6 +15,7 @@ namespace FireflyIII\Models;
 
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\SoftDeletes;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * FireflyIII\Models\TransactionType
@@ -43,6 +44,25 @@ class TransactionType extends Model
 
     protected $dates = ['created_at', 'updated_at', 'deleted_at'];
 
+    /**
+     * @param string $type
+     *
+     * @return Model|null|static
+     */
+    public static function routeBinder(string $type)
+    {
+        if (!auth()->check()) {
+            throw new NotFoundHttpException;
+        }
+        $transactionType = self::where('type', $type)->first();
+        if (!is_null($transactionType)) {
+            return $transactionType;
+        }
+        throw new NotFoundHttpException;
+
+    }
+
+
     /**
      * @return bool
      */