IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Expand tests

Browse Source
This commit is contained in:
James Cole 2018-12-21 07:36:40 +01:00
parent 8ede404b8a
commit 3c9c46d574
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
3 changed files with 409 additions and 405 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/Support/Import/Routine/Bunq/StageImportDataHandler.php
View File

@ -141,12 +141,11 @@ class StageImportDataHandler
* @return array
* @throws FireflyException
*/
private function convertPayment(BunqPayment $payment, int $bunqAccountId, LocalAccount $source): array
private function convertPayment(BunqPayment $payment, LocalAccount $source): array
{
Log::debug(sprintf('Now at payment with ID #%d', $payment->getId()));
return $this->converter->convert($payment, $source);
exit;
}
/**
@ -308,7 +307,7 @@ class StageImportDataHandler
Log::debug('Now looping results from bunq...');
/** @var BunqPayment $payment */
foreach ($response->getValue() as $index => $payment) {
$return[] = $this->convertPayment($payment, $bunqAccountId, $localAccount);
$return[] = $this->convertPayment($payment, $localAccount);
$paymentId = $payment->getId();
/*
* If oldest and newest transaction are null, they have to be set:
@ -412,7 +411,7 @@ class StageImportDataHandler
*/
/** @var BunqPayment $payment */
foreach ($response->getValue() as $payment) {
$return[] = $this->convertPayment($payment, $bunqAccountId, $localAccount);
$return[] = $this->convertPayment($payment, $localAccount);
$paymentId = $payment->getId();
/*

804
tests/Unit/Support/Import/Routine/Bunq/StageImportDataHandlerTest.php
View File

@ -33,13 +33,13 @@ use bunq\Model\Generated\Object\Pointer;
use Carbon\Carbon;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Factory\AccountFactory;
use FireflyIII\Models\AccountType;
use FireflyIII\Models\ImportJob;
use FireflyIII\Models\Preference;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use FireflyIII\Services\Bunq\ApiContext;
use FireflyIII\Services\Bunq\Payment;
use FireflyIII\Support\Import\Routine\Bunq\PaymentConverter;
use FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler;
use Log;
use Mockery;
@ -121,47 +121,47 @@ class StageImportDataHandlerTest extends TestCase
$value = [$payment];
$list = new BunqResponsePaymentList($value, [], null);
$expectedTransactions = [
[
'user' => 1,
'type' => 'Deposit',
'date' => $today->format('Y-m-d'),
'description' => $payment->getDescription(),
'piggy_bank_id' => null,
'piggy_bank_name' => null,
'bill_id' => null,
'bill_name' => null,
'tags' => [null, null],
'internal_reference' => null,
'external_id' => null,
'notes' => null,
'bunq_payment_id' => null,
'transactions' => [
[
'description' => null,
'amount' => '150',
'currency_id' => null,
'currency_code' => 'EUR',
'foreign_amount' => null,
'foreign_currency_id' => null,
'foreign_currency_code' => null,
'budget_id' => null,
'budget_name' => null,
'category_id' => null,
'category_name' => null,
'source_id' => $deposit->id,
'source_name' => null,
'destination_id' => $account->id,
'destination_name' => null,
'reconciled' => false,
'identifier' => 0,
],
$expectedTransaction = [
'user' => 1,
'type' => 'Deposit',
'date' => $today->format('Y-m-d'),
'timestamp' => $today->toAtomString(),
'description' => $payment->getDescription(),
'piggy_bank_id' => null,
'piggy_bank_name' => null,
'bill_id' => null,
'bill_name' => null,
'tags' => [null, null],
'internal_reference' => null,
'external_id' => null,
'notes' => null,
'bunq_payment_id' => null,
'transactions' => [
[
'description' => null,
'amount' => '150',
'currency_id' => null,
'currency_code' => 'EUR',
'foreign_amount' => null,
'foreign_currency_id' => null,
'foreign_currency_code' => null,
'budget_id' => null,
'budget_name' => null,
'category_id' => null,
'category_name' => null,
'source_id' => $deposit->id,
'source_name' => null,
'destination_id' => $account->id,
'destination_name' => null,
'reconciled' => false,
'identifier' => 0,
],
'original-source' => 'bunq-v' . config('firefly.version'),
],
'original-source' => 'bunq-v' . config('firefly.version'),
];
$expectedTransactions = [$expectedTransaction];
// mock used objects:
$repository = $this->mock(ImportJobRepositoryInterface::class);
@ -169,6 +169,7 @@ class StageImportDataHandlerTest extends TestCase
$accountFactory = $this->mock(AccountFactory::class);
$context = $this->mock(ApiContext::class);
$payment = $this->mock(Payment::class);
$converter = $this->mock(PaymentConverter::class);
// mock calls:
$repository->shouldReceive('setUser')->once();
@ -176,82 +177,7 @@ class StageImportDataHandlerTest extends TestCase
$accountFactory->shouldReceive('setUser')->once();
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
$context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
$repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
$accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
$payment->shouldReceive('listing')->once()->andReturn($list);
$accountFactory->shouldReceive('create')->withArgs([$expectedAccount])
->andReturn($deposit)->once();
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
$handler = new StageImportDataHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertFalse(true, $e->getMessage());
}
$transactions = $handler->getTransactions();
$this->assertEquals($expectedTransactions, $transactions);
}
/**
* @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
*/
public function testRunEmpty(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sidA_bbunq_' . random_int(1, 10000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'bunq';
$job->file_type = '';
$job->configuration = [];
$job->save();
// fake objects:
$account = $this->user()->accounts()->where('account_type_id', 3)->first();
$contextPreference = new Preference;
$contextPreference->name = 'Some name';
$contextPreference->data = '{"a":"b"}';
$config = [
'accounts' => [
['id' => 1234], // bunq account
],
'mapping' => [
1234 => 5678, // Firefly III mapping.
],
];
$expectedTransactions = [];
$value = [];
$list = new BunqResponsePaymentList($value, [], null);
// mock used objects:
$repository = $this->mock(ImportJobRepositoryInterface::class);
$accountRepository = $this->mock(AccountRepositoryInterface::class);
$accountFactory = $this->mock(AccountFactory::class);
$context = $this->mock(ApiContext::class);
$payment = $this->mock(Payment::class);
// mock calls:
$repository->shouldReceive('setUser')->once();
$accountRepository->shouldReceive('setUser')->once();
$accountFactory->shouldReceive('setUser')->once();
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
$context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
$converter->shouldReceive('setImportJob')->atLeast()->once();
$repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
$accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
$payment->shouldReceive('listing')->once()->andReturn($list);
@ -260,11 +186,14 @@ class StageImportDataHandlerTest extends TestCase
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
//
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// converter should convert:
$converter->shouldReceive('convert')->atLeast()->once()->andReturn($expectedTransaction);
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
@ -278,293 +207,366 @@ class StageImportDataHandlerTest extends TestCase
}
$transactions = $handler->getTransactions();
$this->assertEquals($expectedTransactions, $transactions);
}
/**
* @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
*/
public function testRunIban(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sidh_bbunq_' . random_int(1, 10000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'bunq';
$job->file_type = '';
$job->configuration = [];
$job->save();
// fake objects:
$deposit = $this->user()->accounts()->where('account_type_id', 5)->first();
$account = $this->user()->accounts()->where('account_type_id', 3)->first();
$contextPreference = new Preference;
$contextPreference->name = 'Some name';
$contextPreference->data = '{"a":"b"}';
$config = [
'accounts' => [
['id' => 1234], // bunq account
],
'mapping' => [
1234 => 5678, // Firefly III mapping.
],
];
$today = new Carbon;
$amount = new Amount('150', 'EUR');
$pointer = new Pointer('iban', 'ES2364265841767173822054', 'Test Site');
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
// ignore the deprecated fields:
$amount->setValue('150');
$amount->setCurrency('EUR');
$pointer->setType('iban');
$pointer->setValue('ES2364265841767173822054');
$pointer->setName('Test Site');
$labelMonetaryAccount = new LabelMonetaryAccount();
$labelMonetaryAccount->setDisplayName('James');
$labelUser = new LabelUser('x', 'James', 'NL');
$labelUser->setDisplayName('James');
$labelMonetaryAccount->setLabelUser($labelUser);
$labelMonetaryAccount->setIban('RS88844660406878687897');
$payment = new BunqPayment($amount, $pointer, 'Some descr', null, null);
$payment->setAmount($amount);
$payment->setDescription('Some random thing #' . random_int(1, 10000));
$payment->setCounterpartyAlias($labelMonetaryAccount);
$value = [$payment];
$list = new BunqResponsePaymentList($value, [], null);
$expectedTransactions = [
[
'user' => 1,
'type' => 'Deposit',
'date' => $today->format('Y-m-d'),
'description' => $payment->getDescription(),
'piggy_bank_id' => null,
'piggy_bank_name' => null,
'bill_id' => null,
'bill_name' => null,
'tags' => [null, null],
'internal_reference' => null,
'external_id' => null,
'notes' => null,
'bunq_payment_id' => null,
'transactions' => [
[
'description' => null,
'amount' => '150',
'currency_id' => null,
'currency_code' => 'EUR',
'foreign_amount' => null,
'foreign_currency_id' => null,
'foreign_currency_code' => null,
'budget_id' => null,
'budget_name' => null,
'category_id' => null,
'category_name' => null,
'source_id' => $deposit->id,
'source_name' => null,
'destination_id' => $account->id,
'destination_name' => null,
'reconciled' => false,
'identifier' => 0,
],
],
'original-source' => 'bunq-v' . config('firefly.version'),
],
];
// mock used objects:
$repository = $this->mock(ImportJobRepositoryInterface::class);
$accountRepository = $this->mock(AccountRepositoryInterface::class);
$accountFactory = $this->mock(AccountFactory::class);
$context = $this->mock(ApiContext::class);
$payment = $this->mock(Payment::class);
// mock calls:
$repository->shouldReceive('setUser')->once();
$accountRepository->shouldReceive('setUser')->once();
$accountFactory->shouldReceive('setUser')->once();
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
$context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
$repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
$accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
$payment->shouldReceive('listing')->once()->andReturn($list);
$accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturn($deposit);
$handler = new StageImportDataHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertFalse(true, $e->getMessage());
}
$transactions = $handler->getTransactions();
$this->assertEquals($expectedTransactions, $transactions);
}
/**
* @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
*/
public function testRunIbanAsset(): void
{
$job = new ImportJob;
$job->user_id = $this->user()->id;
$job->key = 'sidh_bbunq_' . random_int(1, 10000);
$job->status = 'new';
$job->stage = 'new';
$job->provider = 'bunq';
$job->file_type = '';
$job->configuration = [];
$job->save();
// fake objects:
$account = $this->user()->accounts()->where('account_type_id', 3)->first();
$asset = $this->user()->accounts()->where('account_type_id', 3)->where('id', '!=', $account->id)->first();
$contextPreference = new Preference;
$contextPreference->name = 'Some name';
$contextPreference->data = '{"a":"b"}';
$config = [
'accounts' => [
['id' => 1234], // bunq account
],
'mapping' => [
1234 => 5678, // Firefly III mapping.
],
];
$amount = new Amount('150', 'EUR');
$pointer = new Pointer('iban', 'ES2364265841767173822054', 'Test Site');
$expectedAccount = [
'user_id' => 1,
'iban' => null,
'name' => 'James',
'account_type_id' => null,
'accountType' => 'Revenue account',
'virtualBalance' => null,
'active' => true,
];
// ignore the deprecated fields:
$amount->setValue('150');
$amount->setCurrency('EUR');
$pointer->setType('iban');
$pointer->setValue('ES2364265841767173822054');
$pointer->setName('Test Site');
$labelMonetaryAccount = new LabelMonetaryAccount();
$labelMonetaryAccount->setDisplayName('James');
$labelUser = new LabelUser('x', 'James', 'NL');
$labelUser->setDisplayName('James');
$labelMonetaryAccount->setLabelUser($labelUser);
$labelMonetaryAccount->setIban('RS88844660406878687897');
$today = new Carbon;
$payment = new BunqPayment($amount, $pointer, 'Some descr', null, null);
$payment->setAmount($amount);
$payment->setCounterpartyAlias($labelMonetaryAccount);
$payment->setDescription('Random transfer #' . random_int(1, 10000));
$value = [$payment];
$list = new BunqResponsePaymentList($value, [], null);
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->once();
$expectedTransactions = [
[
'user' => 1,
'type' => 'Transfer',
'date' => $today->format('Y-m-d'),
'description' => $payment->getDescription(),
'piggy_bank_id' => null,
'piggy_bank_name' => null,
'bill_id' => null,
'bill_name' => null,
'tags' => [null, null],
'internal_reference' => null,
'external_id' => null,
'notes' => null,
'bunq_payment_id' => null,
'transactions' => [
[
'description' => null,
'amount' => '150',
'currency_id' => null,
'currency_code' => 'EUR',
'foreign_amount' => null,
'foreign_currency_id' => null,
'foreign_currency_code' => null,
'budget_id' => null,
'budget_name' => null,
'category_id' => null,
'category_name' => null,
'source_id' => $asset->id,
'source_name' => null,
'destination_id' => $account->id,
'destination_name' => null,
'reconciled' => false,
'identifier' => 0,
],
],
],
];
// mock used objects:
$repository = $this->mock(ImportJobRepositoryInterface::class);
$accountRepository = $this->mock(AccountRepositoryInterface::class);
$accountFactory = $this->mock(AccountFactory::class);
$context = $this->mock(ApiContext::class);
$payment = $this->mock(Payment::class);
// mock calls:
$repository->shouldReceive('setUser')->once();
$accountRepository->shouldReceive('setUser')->once();
$accountFactory->shouldReceive('setUser')->once();
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
$context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
$repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
$accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
$payment->shouldReceive('listing')->once()->andReturn($list);
$accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturnNull();
$accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::ASSET]])->once()->andReturn($asset);
// set new last transaction ID:
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(1);
$lastPref = new Preference;
$lastPref->data = 0;
Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
// todo: improve test thing:
Preferences::shouldReceive('setForUser');
$handler = new StageImportDataHandler;
$handler->setImportJob($job);
try {
$handler->run();
} catch (FireflyException $e) {
$this->assertFalse(true, $e->getMessage());
}
$transactions = $handler->getTransactions();
//$this->assertEquals($expectedTransactions, $transactions);
}
// /**
// * @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
// */
// public function testRunEmpty(): void
// {
// $job = new ImportJob;
// $job->user_id = $this->user()->id;
// $job->key = 'sidA_bbunq_' . random_int(1, 10000);
// $job->status = 'new';
// $job->stage = 'new';
// $job->provider = 'bunq';
// $job->file_type = '';
// $job->configuration = [];
// $job->save();
//
// // fake objects:
// $account = $this->user()->accounts()->where('account_type_id', 3)->first();
// $contextPreference = new Preference;
// $contextPreference->name = 'Some name';
// $contextPreference->data = '{"a":"b"}';
// $config = [
// 'accounts' => [
// ['id' => 1234], // bunq account
// ],
// 'mapping' => [
// 1234 => 5678, // Firefly III mapping.
// ],
// ];
// $expectedTransactions = [];
// $value = [];
// $list = new BunqResponsePaymentList($value, [], null);
//
// // mock used objects:
// $repository = $this->mock(ImportJobRepositoryInterface::class);
// $accountRepository = $this->mock(AccountRepositoryInterface::class);
// $accountFactory = $this->mock(AccountFactory::class);
// $context = $this->mock(ApiContext::class);
// $payment = $this->mock(Payment::class);
//
// // mock calls:
// $repository->shouldReceive('setUser')->once();
// $accountRepository->shouldReceive('setUser')->once();
// $accountFactory->shouldReceive('setUser')->once();
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
// $context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
// $repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
// $accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
// $payment->shouldReceive('listing')->once()->andReturn($list);
//
// // set new last transaction ID:
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
//
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
//
// // todo: improve test thing:
// Preferences::shouldReceive('setForUser');
//
// $handler = new StageImportDataHandler;
// $handler->setImportJob($job);
// try {
// $handler->run();
//
// } catch (FireflyException $e) {
// $this->assertFalse(true, $e->getMessage());
// }
// $transactions = $handler->getTransactions();
// $this->assertEquals($expectedTransactions, $transactions);
//
// }
//
// /**
// * @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
// */
// public function testRunIban(): void
// {
// $job = new ImportJob;
// $job->user_id = $this->user()->id;
// $job->key = 'sidh_bbunq_' . random_int(1, 10000);
// $job->status = 'new';
// $job->stage = 'new';
// $job->provider = 'bunq';
// $job->file_type = '';
// $job->configuration = [];
// $job->save();
//
// // fake objects:
// $deposit = $this->user()->accounts()->where('account_type_id', 5)->first();
// $account = $this->user()->accounts()->where('account_type_id', 3)->first();
// $contextPreference = new Preference;
// $contextPreference->name = 'Some name';
// $contextPreference->data = '{"a":"b"}';
// $config = [
// 'accounts' => [
// ['id' => 1234], // bunq account
// ],
// 'mapping' => [
// 1234 => 5678, // Firefly III mapping.
// ],
// ];
// $today = new Carbon;
// $amount = new Amount('150', 'EUR');
// $pointer = new Pointer('iban', 'ES2364265841767173822054', 'Test Site');
//
// // set new last transaction ID:
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(2);
//
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
//
// // todo: improve test thing:
// Preferences::shouldReceive('setForUser');
//
//
// // ignore the deprecated fields:
// $amount->setValue('150');
// $amount->setCurrency('EUR');
// $pointer->setType('iban');
// $pointer->setValue('ES2364265841767173822054');
// $pointer->setName('Test Site');
// $labelMonetaryAccount = new LabelMonetaryAccount();
// $labelMonetaryAccount->setDisplayName('James');
// $labelUser = new LabelUser('x', 'James', 'NL');
// $labelUser->setDisplayName('James');
// $labelMonetaryAccount->setLabelUser($labelUser);
// $labelMonetaryAccount->setIban('RS88844660406878687897');
//
// $payment = new BunqPayment($amount, $pointer, 'Some descr', null, null);
// $payment->setAmount($amount);
// $payment->setDescription('Some random thing #' . random_int(1, 10000));
// $payment->setCounterpartyAlias($labelMonetaryAccount);
// $value = [$payment];
// $list = new BunqResponsePaymentList($value, [], null);
//
// $expectedTransactions = [
// [
// 'user' => 1,
// 'type' => 'Deposit',
// 'date' => $today->format('Y-m-d'),
// 'description' => $payment->getDescription(),
// 'piggy_bank_id' => null,
// 'piggy_bank_name' => null,
// 'bill_id' => null,
// 'bill_name' => null,
// 'tags' => [null, null],
// 'internal_reference' => null,
// 'external_id' => null,
// 'notes' => null,
// 'bunq_payment_id' => null,
// 'transactions' => [
// [
// 'description' => null,
// 'amount' => '150',
// 'currency_id' => null,
// 'currency_code' => 'EUR',
// 'foreign_amount' => null,
// 'foreign_currency_id' => null,
// 'foreign_currency_code' => null,
// 'budget_id' => null,
// 'budget_name' => null,
// 'category_id' => null,
// 'category_name' => null,
// 'source_id' => $deposit->id,
// 'source_name' => null,
// 'destination_id' => $account->id,
// 'destination_name' => null,
// 'reconciled' => false,
// 'identifier' => 0,
// ],
// ],
// 'original-source' => 'bunq-v' . config('firefly.version'),
// ],
// ];
//
// // mock used objects:
// $repository = $this->mock(ImportJobRepositoryInterface::class);
// $accountRepository = $this->mock(AccountRepositoryInterface::class);
// $accountFactory = $this->mock(AccountFactory::class);
// $context = $this->mock(ApiContext::class);
// $payment = $this->mock(Payment::class);
//
// // mock calls:
// $repository->shouldReceive('setUser')->once();
// $accountRepository->shouldReceive('setUser')->once();
// $accountFactory->shouldReceive('setUser')->once();
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
// $context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
// $repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
// $accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
// $payment->shouldReceive('listing')->once()->andReturn($list);
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturn($deposit);
//
//
// $handler = new StageImportDataHandler;
// $handler->setImportJob($job);
// try {
// $handler->run();
//
// } catch (FireflyException $e) {
// $this->assertFalse(true, $e->getMessage());
// }
// $transactions = $handler->getTransactions();
// $this->assertEquals($expectedTransactions, $transactions);
// }
//
// /**
// * @covers \FireflyIII\Support\Import\Routine\Bunq\StageImportDataHandler
// */
// public function testRunIbanAsset(): void
// {
// $job = new ImportJob;
// $job->user_id = $this->user()->id;
// $job->key = 'sidh_bbunq_' . random_int(1, 10000);
// $job->status = 'new';
// $job->stage = 'new';
// $job->provider = 'bunq';
// $job->file_type = '';
// $job->configuration = [];
// $job->save();
//
// // fake objects:
// $account = $this->user()->accounts()->where('account_type_id', 3)->first();
// $asset = $this->user()->accounts()->where('account_type_id', 3)->where('id', '!=', $account->id)->first();
// $contextPreference = new Preference;
// $contextPreference->name = 'Some name';
// $contextPreference->data = '{"a":"b"}';
// $config = [
// 'accounts' => [
// ['id' => 1234], // bunq account
// ],
// 'mapping' => [
// 1234 => 5678, // Firefly III mapping.
// ],
// ];
// $amount = new Amount('150', 'EUR');
// $pointer = new Pointer('iban', 'ES2364265841767173822054', 'Test Site');
// $expectedAccount = [
// 'user_id' => 1,
// 'iban' => null,
// 'name' => 'James',
// 'account_type_id' => null,
// 'accountType' => 'Revenue account',
// 'virtualBalance' => null,
// 'active' => true,
// ];
//
// // ignore the deprecated fields:
// $amount->setValue('150');
// $amount->setCurrency('EUR');
// $pointer->setType('iban');
// $pointer->setValue('ES2364265841767173822054');
// $pointer->setName('Test Site');
// $labelMonetaryAccount = new LabelMonetaryAccount();
// $labelMonetaryAccount->setDisplayName('James');
// $labelUser = new LabelUser('x', 'James', 'NL');
// $labelUser->setDisplayName('James');
// $labelMonetaryAccount->setLabelUser($labelUser);
// $labelMonetaryAccount->setIban('RS88844660406878687897');
// $today = new Carbon;
// $payment = new BunqPayment($amount, $pointer, 'Some descr', null, null);
// $payment->setAmount($amount);
// $payment->setCounterpartyAlias($labelMonetaryAccount);
// $payment->setDescription('Random transfer #' . random_int(1, 10000));
// $value = [$payment];
// $list = new BunqResponsePaymentList($value, [], null);
//
// // set new last transaction ID:
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->once();
//
// $expectedTransactions = [
// [
// 'user' => 1,
// 'type' => 'Transfer',
// 'date' => $today->format('Y-m-d'),
// 'description' => $payment->getDescription(),
// 'piggy_bank_id' => null,
// 'piggy_bank_name' => null,
// 'bill_id' => null,
// 'bill_name' => null,
// 'tags' => [null, null],
// 'internal_reference' => null,
// 'external_id' => null,
// 'notes' => null,
// 'bunq_payment_id' => null,
// 'transactions' => [
// [
// 'description' => null,
// 'amount' => '150',
// 'currency_id' => null,
// 'currency_code' => 'EUR',
// 'foreign_amount' => null,
// 'foreign_currency_id' => null,
// 'foreign_currency_code' => null,
// 'budget_id' => null,
// 'budget_name' => null,
// 'category_id' => null,
// 'category_name' => null,
// 'source_id' => $asset->id,
// 'source_name' => null,
// 'destination_id' => $account->id,
// 'destination_name' => null,
// 'reconciled' => false,
// 'identifier' => 0,
// ],
// ],
// ],
// ];
//
// // mock used objects:
// $repository = $this->mock(ImportJobRepositoryInterface::class);
// $accountRepository = $this->mock(AccountRepositoryInterface::class);
// $accountFactory = $this->mock(AccountFactory::class);
// $context = $this->mock(ApiContext::class);
// $payment = $this->mock(Payment::class);
//
// // mock calls:
// $repository->shouldReceive('setUser')->once();
// $accountRepository->shouldReceive('setUser')->once();
// $accountFactory->shouldReceive('setUser')->once();
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq_api_context', null])->andReturn($contextPreference);
// $context->shouldReceive('fromJson')->withArgs(['{"a":"b"}'])->once();
// $repository->shouldReceive('getConfiguration')->withArgs([Mockery::any()])->andReturn($config)->once();
// $accountRepository->shouldReceive('findNull')->withArgs([5678])->andReturn($account)->once();
// $payment->shouldReceive('listing')->once()->andReturn($list);
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturnNull();
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::ASSET]])->once()->andReturn($asset);
//
//
// // set new last transaction ID:
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-oldest-transaction-1234', 0])->andReturn($lastPref)->times(1);
//
// $lastPref = new Preference;
// $lastPref->data = 0;
// Preferences::shouldReceive('getForUser')->withArgs([Mockery::any(), 'bunq-newest-transaction-1234', 0])->andReturn($lastPref)->once();
//
// // todo: improve test thing:
// Preferences::shouldReceive('setForUser');
//
// $handler = new StageImportDataHandler;
// $handler->setImportJob($job);
// try {
// $handler->run();
//
// } catch (FireflyException $e) {
// $this->assertFalse(true, $e->getMessage());
// }
// $transactions = $handler->getTransactions();
// //$this->assertEquals($expectedTransactions, $transactions);
// }
}

3
tests/Unit/Support/Import/Routine/Bunq/StageNewHandlerTest.php
View File

@ -211,6 +211,7 @@ class StageNewHandlerTest extends TestCase
'default_avatar_status' => null,
'restriction_chat' => null,
],
'iban' => 'SM72C9584723533916792029340'
],
],
];
@ -297,7 +298,9 @@ class StageNewHandlerTest extends TestCase
'default_avatar_status' => null,
'restriction_chat' => null,
],
'iban' => 'SM72C9584723533916792029340'
],
],
];