IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2024-12-28 18:01:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix https://github.com/firefly-iii/firefly-iii/issues/6040

Browse Source
This commit is contained in:
James Cole 2022-05-04 20:27:18 +02:00
parent a258b35236
commit 3d1233314a
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Factory/TransactionGroupFactory.php
View File

@ -36,10 +36,8 @@ use Log;
*/
class TransactionGroupFactory
{
/** @var TransactionJournalFactory */
private $journalFactory;
/** @var User The user */
private $user;
private TransactionJournalFactory $journalFactory;
private User $user;
/**
* TransactionGroupFactory constructor.

7
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@ -238,6 +238,13 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
Log::debug(sprintf('The currency is %s and the amount is %s', $currency->code, $amount));
$room = bcsub((string) $piggyBank->targetamount, (string) $repetition->currentamount);
$compare = bcmul($repetition->currentamount, '-1');
if(bccomp((string) $piggyBank->targetamount,'0') === 0) {
// amount is zero? then the "room" is positive amount of we wish to add or remove.
$room = app('steam')->positive($amount);
Log::debug(sprintf('Room is now %s', $room));
}
Log::debug(sprintf('Will add/remove %f to piggy bank #%d ("%s")', $amount, $piggyBank->id, $piggyBank->name));
// if the amount is positive, make sure it fits in piggy bank: