diff --git a/app/Repositories/PiggyBank/ModifiesPiggyBanks.php b/app/Repositories/PiggyBank/ModifiesPiggyBanks.php index b0acdd08ee..122eccabf5 100644 --- a/app/Repositories/PiggyBank/ModifiesPiggyBanks.php +++ b/app/Repositories/PiggyBank/ModifiesPiggyBanks.php @@ -62,7 +62,7 @@ trait ModifiesPiggyBanks $repetition->save(); // create event - $this->createEvent($piggyBank, $amount); + //$this->createEvent($piggyBank, $amount); return true; } diff --git a/app/Validation/FireflyValidator.php b/app/Validation/FireflyValidator.php index e20e3b7f7d..7a86b7787a 100644 --- a/app/Validation/FireflyValidator.php +++ b/app/Validation/FireflyValidator.php @@ -34,6 +34,7 @@ use FireflyIII\Models\TransactionType; use FireflyIII\Repositories\Account\AccountRepositoryInterface; use FireflyIII\Repositories\Bill\BillRepositoryInterface; use FireflyIII\Repositories\Budget\BudgetRepositoryInterface; +use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface; use FireflyIII\Services\Password\Verifier; use FireflyIII\Support\ParseDateString; use FireflyIII\TransactionRules\Triggers\TriggerInterface; @@ -289,10 +290,11 @@ class FireflyValidator extends Validator return null !== $account; } - // must be numeric for piggy bank things: if ('update_piggy' === $actionType) { - $value = str_replace(',', '.', $value); - return '' !== $value && is_numeric($value); + /** @var PiggyBankRepositoryInterface $repository */ + $repository = app(PiggyBankRepositoryInterface::class); + $piggy = $repository->findByName($value); + return null !== $piggy; } // return true for the rest.