From 033210473865e4bb37ce26852ed92bec78dbd9d7 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 19:00:31 +0100 Subject: [PATCH 01/84] Expanded tests for piggy banks. --- tests/functional.suite.yml | 2 +- tests/functional/PiggyBankControllerCest.php | 167 +++++++++++++++++++ 2 files changed, 168 insertions(+), 1 deletion(-) diff --git a/tests/functional.suite.yml b/tests/functional.suite.yml index 6c67a707ca..4d61ccdd3f 100644 --- a/tests/functional.suite.yml +++ b/tests/functional.suite.yml @@ -10,7 +10,7 @@ modules: config: Db: populate: false - cleanup: false + cleanup: true Laravel4: environment: 'testing' filters: false \ No newline at end of file diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index 136eb6cbd7..c92cc84f3d 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -105,6 +105,20 @@ class PiggyBankControllerCest $I->wantTo('process adding money to a piggy bank'); $I->amOnPage('/piggybanks/add/1'); $I->see('Add money to New camera'); + $I->submitForm('#add', ['amount' => 100]); + $I->see(',00 to "New camera".'); + } + + /** + * @param FunctionalTester $I + */ + public function postAddTooMuch(FunctionalTester $I) + { + $I->wantTo('try to add too much money to a piggy bank'); + $I->amOnPage('/piggybanks/add/1'); + $I->see('Add money to New camera'); + $I->submitForm('#add', ['amount' => 100000]); + $I->see(',00 to "New camera".'); } /** @@ -113,10 +127,33 @@ class PiggyBankControllerCest public function postRemove(FunctionalTester $I) { $I->wantTo('process removing money from a piggy bank'); + $I->amOnPage('/piggybanks/add/1'); + $I->see('Add money to New camera'); + $I->submitForm('#add', ['amount' => 100]); + $I->see(',00 to "New camera".'); $I->amOnPage('/piggybanks/remove/1'); $I->see('Remove money from New camera'); + $I->submitForm('#remove', ['amount' => 50]); + $I->see(',00 from "New camera".'); } + /** + * @param FunctionalTester $I + */ + public function postRemoveFail(FunctionalTester $I) + { + $I->wantTo('process removing too much money from a piggy bank'); + $I->amOnPage('/piggybanks/add/1'); + $I->see('Add money to New camera'); + $I->submitForm('#add', ['amount' => 100]); + $I->see(',00 to "New camera".'); + $I->amOnPage('/piggybanks/remove/1'); + $I->see('Remove money from New camera'); + $I->submitForm('#remove', ['amount' => 500]); + $I->see(',00 from "New camera".'); + } + + /** * @param FunctionalTester $I */ @@ -145,6 +182,54 @@ class PiggyBankControllerCest $I->wantTo('store a new piggy bank'); $I->amOnPage('/piggybanks/create'); $I->see('Create new piggy bank'); + $I->submitForm( + '#store', ['name' => 'Some new piggy bank', + 'rep_every' => 0, + 'reminder_skip' => 0, + 'remind_me' => 0, + 'order' => 3, + 'account_id' => 1, 'targetamount' => 1000] + ); + $I->see('Piggy bank "Some new piggy bank" stored.'); + } + + /** + * @param FunctionalTester $I + */ + public function storeAndReturn(FunctionalTester $I) + { + $I->wantTo('store a new piggy bank and return'); + $I->amOnPage('/piggybanks/create'); + $I->see('Create new piggy bank'); + $I->submitForm( + '#store', ['name' => 'Some new piggy bank', + 'rep_every' => 0, + 'reminder_skip' => 0, + 'post_submit_action' => 'create_another', + 'remind_me' => 0, + 'order' => 3, + 'account_id' => 1, 'targetamount' => 1000] + ); + $I->see('Piggy bank "Some new piggy bank" stored.'); + } + + /** + * @param FunctionalTester $I + */ + public function storeFail(FunctionalTester $I) + { + $I->wantTo('fail storing a new piggy bank'); + $I->amOnPage('/piggybanks/create'); + $I->see('Create new piggy bank'); + $I->submitForm( + '#store', ['name' => null, + 'rep_every' => 0, + 'reminder_skip' => 0, + 'remind_me' => 0, + 'order' => 3, + 'account_id' => 1, 'targetamount' => 1000] + ); + $I->see('Name is too short'); } /** @@ -155,6 +240,88 @@ class PiggyBankControllerCest $I->wantTo('update a piggy bank'); $I->amOnPage('/piggybanks/edit/1'); $I->see('Edit piggy bank "New camera"'); + $I->submitForm( + '#update', [ + 'name' => 'Updated camera', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'update', + ] + ); + $I->see('Piggy bank "Updated camera" updated.'); + + + } + + /** + * @param FunctionalTester $I + */ + public function updateAndReturn(FunctionalTester $I) + { + $I->wantTo('update a piggy bank and return'); + $I->amOnPage('/piggybanks/edit/1'); + $I->see('Edit piggy bank "New camera"'); + $I->submitForm( + '#update', [ + 'name' => 'Updated camera', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'return_to_edit', + ] + ); + $I->see('Piggy bank "Updated camera" updated.'); + + + } + + /** + * @param FunctionalTester $I + */ + public function updateValidateOnly(FunctionalTester $I) + { + $I->wantTo('validate a piggy bank'); + $I->amOnPage('/piggybanks/edit/1'); + $I->see('Edit piggy bank "New camera"'); + $I->submitForm( + '#update', [ + 'name' => 'Updated camera', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'validate_only', + ] + ); + $I->see('Updated camera'); + + + } + + /** + * @param FunctionalTester $I + */ + public function updateFail(FunctionalTester $I) + { + $I->wantTo('update a piggy bank and fail'); + $I->amOnPage('/piggybanks/edit/1'); + $I->see('Edit piggy bank "New camera"'); + $I->submitForm( + '#update', [ + 'name' => '', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'update', + ] + ); + $I->see('Name is too short'); + $I->seeInDatabase('piggybanks', ['name' => 'New camera']); + } } \ No newline at end of file From 335279e72888ecf23f946671f6da40867e02ce8f Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 19:13:15 +0100 Subject: [PATCH 02/84] Renamed lots of "piggybank" to "piggyBank". --- app/breadcrumbs.php | 44 +++--- app/controllers/GoogleChartController.php | 6 +- app/controllers/PiggybankController.php | 134 ++++++++---------- .../Database/PiggyBank/PiggyBank.php | 6 +- app/lib/FireflyIII/Event/Piggybank.php | 32 ++--- .../FireflyIII/Shared/Toolkit/Reminders.php | 2 +- app/views/piggybanks/add.blade.php | 4 +- app/views/piggybanks/delete.blade.php | 6 +- app/views/piggybanks/edit.blade.php | 4 +- app/views/piggybanks/index.blade.php | 28 ++-- app/views/piggybanks/remove.blade.php | 8 +- app/views/piggybanks/show.blade.php | 38 ++--- 12 files changed, 152 insertions(+), 160 deletions(-) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 3269c6e773..487b182ed3 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -134,35 +134,35 @@ Breadcrumbs::register( // piggy banks Breadcrumbs::register( - 'piggybanks.index', function (Generator $breadcrumbs) { + 'piggyBanks.index', function (Generator $breadcrumbs) { $breadcrumbs->parent('home'); - $breadcrumbs->push('Piggy banks', route('piggybanks.index')); + $breadcrumbs->push('Piggy banks', route('piggyBanks.index')); } ); Breadcrumbs::register( - 'piggybanks.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('piggybanks.index'); - $breadcrumbs->push('Create new piggy bank', route('piggybanks.create')); + 'piggyBanks.create', function (Generator $breadcrumbs) { + $breadcrumbs->parent('piggyBanks.index'); + $breadcrumbs->push('Create new piggy bank', route('piggyBanks.create')); } ); Breadcrumbs::register( - 'piggybanks.edit', function (Generator $breadcrumbs, Piggybank $piggybank) { - $breadcrumbs->parent('piggybanks.show', $piggybank); - $breadcrumbs->push('Edit ' . $piggybank->name, route('piggybanks.edit', $piggybank->id)); + 'piggyBanks.edit', function (Generator $breadcrumbs, Piggybank $piggyBank) { + $breadcrumbs->parent('piggyBanks.show', $piggyBank); + $breadcrumbs->push('Edit ' . $piggyBank->name, route('piggyBanks.edit', $piggyBank->id)); } ); Breadcrumbs::register( - 'piggybanks.delete', function (Generator $breadcrumbs, Piggybank $piggybank) { - $breadcrumbs->parent('piggybanks.show', $piggybank); - $breadcrumbs->push('Delete ' . $piggybank->name, route('piggybanks.delete', $piggybank->id)); + 'piggyBanks.delete', function (Generator $breadcrumbs, Piggybank $piggyBank) { + $breadcrumbs->parent('piggyBanks.show', $piggyBank); + $breadcrumbs->push('Delete ' . $piggyBank->name, route('piggyBanks.delete', $piggyBank->id)); } ); Breadcrumbs::register( - 'piggybanks.show', function (Generator $breadcrumbs, Piggybank $piggybank) { - $breadcrumbs->parent('piggybanks.index'); - $breadcrumbs->push($piggybank->name, route('piggybanks.show', $piggybank->id)); + 'piggyBanks.show', function (Generator $breadcrumbs, Piggybank $piggyBank) { + $breadcrumbs->parent('piggyBanks.index'); + $breadcrumbs->push($piggyBank->name, route('piggyBanks.show', $piggyBank->id)); } ); @@ -251,22 +251,22 @@ Breadcrumbs::register( ); Breadcrumbs::register( - 'repeated.edit', function (Generator $breadcrumbs, Piggybank $piggybank) { - $breadcrumbs->parent('repeated.show', $piggybank); - $breadcrumbs->push('Edit ' . $piggybank->name, route('repeated.edit', $piggybank->id)); + 'repeated.edit', function (Generator $breadcrumbs, Piggybank $piggyBank) { + $breadcrumbs->parent('repeated.show', $piggyBank); + $breadcrumbs->push('Edit ' . $piggyBank->name, route('repeated.edit', $piggyBank->id)); } ); Breadcrumbs::register( - 'repeated.delete', function (Generator $breadcrumbs, Piggybank $piggybank) { - $breadcrumbs->parent('repeated.show', $piggybank); - $breadcrumbs->push('Delete ' . $piggybank->name, route('repeated.delete', $piggybank->id)); + 'repeated.delete', function (Generator $breadcrumbs, Piggybank $piggyBank) { + $breadcrumbs->parent('repeated.show', $piggyBank); + $breadcrumbs->push('Delete ' . $piggyBank->name, route('repeated.delete', $piggyBank->id)); } ); Breadcrumbs::register( - 'repeated.show', function (Generator $breadcrumbs, Piggybank $piggybank) { + 'repeated.show', function (Generator $breadcrumbs, Piggybank $piggyBank) { $breadcrumbs->parent('repeated.index'); - $breadcrumbs->push($piggybank->name, route('repeated.show', $piggybank->id)); + $breadcrumbs->push($piggyBank->name, route('repeated.show', $piggyBank->id)); } ); diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index 2a5786c5f6..2b5c50c22d 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -312,16 +312,16 @@ class GoogleChartController extends BaseController } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return \Illuminate\Http\JsonResponse */ - public function piggyBankHistory(\Piggybank $piggybank) + public function piggyBankHistory(\Piggybank $piggyBank) { $this->_chart->addColumn('Date', 'date'); $this->_chart->addColumn('Balance', 'number'); - $set = \DB::table('piggy_bank_events')->where('piggybank_id', $piggybank->id)->groupBy('date')->get(['date', DB::Raw('SUM(`amount`) AS `sum`')]); + $set = \DB::table('piggy_bank_events')->where('piggybank_id', $piggyBank->id)->groupBy('date')->get(['date', DB::Raw('SUM(`amount`) AS `sum`')]); foreach ($set as $entry) { $this->_chart->addRow(new Carbon($entry->date), floatval($entry->sum)); diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 307197ac32..3f6b4d7626 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -35,29 +35,21 @@ class PiggybankController extends BaseController /** * Add money to piggy bank * - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return $this */ - public function add(Piggybank $piggybank) + public function add(Piggybank $piggyBank) { - \Log::debug('Now in add() for piggy bank #' . $piggybank->id . ' (' . $piggybank->name . ')'); - \Log::debug('Z'); - \Log::debug('currentRelevantRep is null: ' . boolstr($piggybank->currentRelevantRep())); - $leftOnAccount = $this->_repository->leftOnAccount($piggybank->account); - \Log::debug('A'); - - $savedSoFar = $piggybank->currentRelevantRep()->currentamount; - \Log::debug('B'); - $leftToSave = $piggybank->targetamount - $savedSoFar; - \Log::debug('C'); + $leftOnAccount = $this->_repository->leftOnAccount($piggyBank->account); + $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; + $leftToSave = $piggyBank->targetamount - $savedSoFar; $maxAmount = min($leftOnAccount, $leftToSave); - \Log::debug('D'); - \Log::debug('Now going to view for piggy bank #' . $piggybank->id . ' (' . $piggybank->name . ')'); + \Log::debug('Now going to view for piggy bank #' . $piggyBank->id . ' (' . $piggyBank->name . ')'); - return View::make('piggybanks.add', compact('piggybank', 'maxAmount')); + return View::make('piggybanks.add', compact('piggyBank', 'maxAmount')); } /** @@ -78,15 +70,15 @@ class PiggybankController extends BaseController } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return $this */ - public function delete(Piggybank $piggybank) + public function delete(Piggybank $piggyBank) { - $subTitle = 'Delete "' . e($piggybank->name) . '"'; + $subTitle = 'Delete "' . e($piggyBank->name) . '"'; - return View::make('piggybanks.delete', compact('piggybank', 'subTitle')); + return View::make('piggybanks.delete', compact('piggyBank', 'subTitle')); } /** @@ -104,11 +96,11 @@ class PiggybankController extends BaseController } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return $this */ - public function edit(Piggybank $piggybank) + public function edit(Piggybank $piggyBank) { /** @var \FireflyIII\Database\Account\Account $acct */ @@ -116,28 +108,28 @@ class PiggybankController extends BaseController $periods = Config::get('firefly.piggybank_periods'); $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); - $subTitle = 'Edit piggy bank "' . e($piggybank->name) . '"'; + $subTitle = 'Edit piggy bank "' . e($piggyBank->name) . '"'; $subTitleIcon = 'fa-pencil'; /* * Flash some data to fill the form. */ - if (is_null($piggybank->targetdate) || $piggybank->targetdate == '') { + if (is_null($piggyBank->targetdate) || $piggyBank->targetdate == '') { $targetDate = null; } else { - $targetDate = new Carbon($piggybank->targetdate); + $targetDate = new Carbon($piggyBank->targetdate); $targetDate = $targetDate->format('Y-m-d'); } - $preFilled = ['name' => $piggybank->name, - 'account_id' => $piggybank->account_id, - 'targetamount' => $piggybank->targetamount, + $preFilled = ['name' => $piggyBank->name, + 'account_id' => $piggyBank->account_id, + 'targetamount' => $piggyBank->targetamount, 'targetdate' => $targetDate, - 'reminder' => $piggybank->reminder, - 'remind_me' => intval($piggybank->remind_me) == 1 || !is_null($piggybank->reminder) ? true : false + 'reminder' => $piggyBank->reminder, + 'remind_me' => intval($piggyBank->remind_me) == 1 || !is_null($piggyBank->reminder) ? true : false ]; Session::flash('preFilled', $preFilled); - return View::make('piggybanks.edit', compact('subTitle', 'subTitleIcon', 'piggybank', 'accounts', 'periods', 'preFilled')); + return View::make('piggybanks.edit', compact('subTitle', 'subTitleIcon', 'piggyBank', 'accounts', 'periods', 'preFilled')); } /** @@ -145,134 +137,134 @@ class PiggybankController extends BaseController */ public function index() { - /** @var Collection $piggybanks */ - $piggybanks = $this->_repository->get(); + /** @var Collection $piggyBanks */ + $piggyBanks = $this->_repository->get(); $accounts = []; - /** @var Piggybank $piggybank */ - foreach ($piggybanks as $piggybank) { - $piggybank->savedSoFar = floatval($piggybank->currentRelevantRep()->currentamount); - $piggybank->percentage = intval($piggybank->savedSoFar / $piggybank->targetamount * 100); - $piggybank->leftToSave = $piggybank->targetamount - $piggybank->savedSoFar; + /** @var Piggybank $piggyBank */ + foreach ($piggyBanks as $piggyBank) { + $piggyBank->savedSoFar = floatval($piggyBank->currentRelevantRep()->currentamount); + $piggyBank->percentage = intval($piggyBank->savedSoFar / $piggyBank->targetamount * 100); + $piggyBank->leftToSave = $piggyBank->targetamount - $piggyBank->savedSoFar; /* * Fill account information: */ - $account = $piggybank->account; + $account = $piggyBank->account; if (!isset($accounts[$account->id])) { $accounts[$account->id] = [ 'name' => $account->name, 'balance' => Steam::balance($account), 'leftForPiggybanks' => $this->_repository->leftOnAccount($account), - 'sumOfSaved' => $piggybank->savedSoFar, - 'sumOfTargets' => floatval($piggybank->targetamount), - 'leftToSave' => $piggybank->leftToSave + 'sumOfSaved' => $piggyBank->savedSoFar, + 'sumOfTargets' => floatval($piggyBank->targetamount), + 'leftToSave' => $piggyBank->leftToSave ]; } else { - $accounts[$account->id]['sumOfSaved'] += $piggybank->savedSoFar; - $accounts[$account->id]['sumOfTargets'] += floatval($piggybank->targetamount); - $accounts[$account->id]['leftToSave'] += $piggybank->leftToSave; + $accounts[$account->id]['sumOfSaved'] += $piggyBank->savedSoFar; + $accounts[$account->id]['sumOfTargets'] += floatval($piggyBank->targetamount); + $accounts[$account->id]['leftToSave'] += $piggyBank->leftToSave; } } - return View::make('piggybanks.index', compact('piggybanks', 'accounts')); + return View::make('piggybanks.index', compact('piggyBanks', 'accounts')); } /** * POST add money to piggy bank * - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return \Illuminate\Http\RedirectResponse */ - public function postAdd(Piggybank $piggybank) + public function postAdd(Piggybank $piggyBank) { $amount = round(floatval(Input::get('amount')), 2); /** @var \FireflyIII\Database\PiggyBank\PiggyBank $acct */ $repos = App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - $leftOnAccount = $repos->leftOnAccount($piggybank->account); - $savedSoFar = $piggybank->currentRelevantRep()->currentamount; - $leftToSave = $piggybank->targetamount - $savedSoFar; + $leftOnAccount = $repos->leftOnAccount($piggyBank->account); + $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; + $leftToSave = $piggyBank->targetamount - $savedSoFar; $maxAmount = round(min($leftOnAccount, $leftToSave), 2); if ($amount <= $maxAmount) { - $repetition = $piggybank->currentRelevantRep(); + $repetition = $piggyBank->currentRelevantRep(); $repetition->currentamount += $amount; $repetition->save(); /* * Create event! */ - Event::fire('piggybank.addMoney', [$piggybank, $amount]); // new and used. + Event::fire('piggybank.addMoney', [$piggyBank, $amount]); // new and used. - Session::flash('success', 'Added ' . mf($amount, false) . ' to "' . e($piggybank->name) . '".'); + Session::flash('success', 'Added ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); } else { - Session::flash('error', 'Could not add ' . mf($amount, false) . ' to "' . e($piggybank->name) . '".'); + Session::flash('error', 'Could not add ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); } return Redirect::route('piggybanks.index'); } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return \Illuminate\Http\RedirectResponse */ - public function postRemove(Piggybank $piggybank) + public function postRemove(Piggybank $piggyBank) { $amount = floatval(Input::get('amount')); - $savedSoFar = $piggybank->currentRelevantRep()->currentamount; + $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; if ($amount <= $savedSoFar) { - $repetition = $piggybank->currentRelevantRep(); + $repetition = $piggyBank->currentRelevantRep(); $repetition->currentamount -= $amount; $repetition->save(); /* * Create event! */ - Event::fire('piggybank.removeMoney', [$piggybank, $amount]); // new and used. + Event::fire('piggybank.removeMoney', [$piggyBank, $amount]); // new and used. - Session::flash('success', 'Removed ' . mf($amount, false) . ' from "' . e($piggybank->name) . '".'); + Session::flash('success', 'Removed ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); } else { - Session::flash('error', 'Could not remove ' . mf($amount, false) . ' from "' . e($piggybank->name) . '".'); + Session::flash('error', 'Could not remove ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); } return Redirect::route('piggybanks.index'); } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return \Illuminate\View\View */ - public function remove(Piggybank $piggybank) + public function remove(Piggybank $piggyBank) { - return View::make('piggybanks.remove')->with('piggybank', $piggybank); + return View::make('piggybanks.remove',compact('piggyBank')); } /** - * @param Piggybank $piggybank + * @param Piggybank $piggyBank * * @return $this */ - public function show(Piggybank $piggybank) + public function show(Piggybank $piggyBank) { - $events = $piggybank->piggybankevents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->get(); + $events = $piggyBank->piggybankevents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->get(); /* * Number of reminders: */ - $amountPerReminder = $piggybank->amountPerReminder(); - $remindersCount = $piggybank->countFutureReminders(); - $subTitle = e($piggybank->name); + $amountPerReminder = $piggyBank->amountPerReminder(); + $remindersCount = $piggyBank->countFutureReminders(); + $subTitle = e($piggyBank->name); - return View::make('piggybanks.show', compact('amountPerReminder', 'remindersCount', 'piggybank', 'events', 'subTitle')); + return View::make('piggybanks.show', compact('amountPerReminder', 'remindersCount', 'piggyBank', 'events', 'subTitle')); } diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index 44d4a6adf9..9325da329b 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -221,17 +221,17 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface } /** - * @param \Piggybank $piggybank + * @param \Piggybank $piggyBank * @param Carbon $date * * @return mixed * @throws FireflyException * @throws NotImplementedException */ - public function findRepetitionByDate(\Piggybank $piggybank, Carbon $date) + public function findRepetitionByDate(\Piggybank $piggyBank, Carbon $date) { /** @var Collection $reps */ - $reps = $piggybank->piggybankrepetitions()->get(); + $reps = $piggyBank->piggybankrepetitions()->get(); if ($reps->count() == 1) { return $reps->first(); } diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index bd9ee555f5..1b1c9cde1c 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -15,14 +15,14 @@ class Piggybank { /** - * @param \Piggybank $piggybank + * @param \Piggybank $piggyBank * @param float $amount */ - public function addMoney(\Piggybank $piggybank, $amount = 0.0) + public function addMoney(\Piggybank $piggyBank, $amount = 0.0) { if ($amount > 0) { $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggybank); + $event->piggybank()->associate($piggyBank); $event->amount = floatval($amount); $event->date = new Carbon; if (!$event->isValid()) { @@ -76,15 +76,15 @@ class Piggybank } /** - * @param \Piggybank $piggybank + * @param \Piggybank $piggyBank * @param float $amount */ - public function removeMoney(\Piggybank $piggybank, $amount = 0.0) + public function removeMoney(\Piggybank $piggyBank, $amount = 0.0) { $amount = $amount * -1; if ($amount < 0) { $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggybank); + $event->piggybank()->associate($piggyBank); $event->amount = floatval($amount); $event->date = new Carbon; $event->save(); @@ -92,15 +92,15 @@ class Piggybank } /** - * @param \Piggybank $piggybank + * @param \Piggybank $piggyBank */ - public function storePiggybank(\Piggybank $piggybank) + public function storePiggybank(\Piggybank $piggyBank) { - if (intval($piggybank->repeats) == 0) { + if (intval($piggyBank->repeats) == 0) { $repetition = new \PiggybankRepetition; - $repetition->piggybank()->associate($piggybank); - $repetition->startdate = $piggybank->startdate; - $repetition->targetdate = $piggybank->targetdate; + $repetition->piggybank()->associate($piggyBank); + $repetition->startdate = $piggyBank->startdate; + $repetition->targetdate = $piggyBank->targetdate; $repetition->currentamount = 0; $repetition->save(); } @@ -112,18 +112,18 @@ class Piggybank /** * @param \TransactionJournal $journal - * @param int $piggybankId + * @param int $piggyBankId */ - public function storeTransfer(\TransactionJournal $journal, $piggybankId = 0) + public function storeTransfer(\TransactionJournal $journal, $piggyBankId = 0) { - if (intval($piggybankId) == 0) { + if (intval($piggyBankId) == 0) { return; } /** @var \FireflyIII\Database\PiggyBank\PiggyBank $repository */ $repository = \App::make('FireflyIII\Database\PiggyBank\PiggyBank'); /** @var \Piggybank $piggyBank */ - $piggyBank = $repository->find($piggybankId); + $piggyBank = $repository->find($piggyBankId); if ($journal->transactions()->where('account_id', $piggyBank->account_id)->count() == 0) { return; diff --git a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php index c70ea542e6..d3e582f916 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php @@ -72,7 +72,7 @@ class Reminders $today = Carbon::now(); - /** @var \Piggybank $piggybank */ + /** @var \Piggybank $piggyBank */ foreach ($set as $piggyBank) { /** @var \PiggybankRepetition $repetition */ $repetition = $piggyBank->currentRelevantRep(); diff --git a/app/views/piggybanks/add.blade.php b/app/views/piggybanks/add.blade.php index a4c7f5dc6e..c4f0a9cc3d 100644 --- a/app/views/piggybanks/add.blade.php +++ b/app/views/piggybanks/add.blade.php @@ -1,10 +1,10 @@ -
+ {{Form::token()}}
- +

diff --git a/app/views/piggybanks/delete.blade.php b/app/views/piggybanks/delete.blade.php index 0e37e8d585..967e8b7bc8 100644 --- a/app/views/piggybanks/delete.blade.php +++ b/app/views/piggybanks/delete.blade.php @@ -1,12 +1,12 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggybank) }} -{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('piggybanks.destroy',$piggybank->id)])}} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('piggybanks.destroy',$piggyBank->id)])}}

- Delete piggy bank "{{{$piggybank->name}}}" + Delete piggy bank "{{{$piggyBank->name}}}"

diff --git a/app/views/piggybanks/edit.blade.php b/app/views/piggybanks/edit.blade.php index 945be6387e..9cc580c989 100644 --- a/app/views/piggybanks/edit.blade.php +++ b/app/views/piggybanks/edit.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggybank) }} -{{Form::model($piggybank, ['class' => 'form-horizontal','id' => 'update','url' => route('piggybanks.update',$piggybank->id)])}} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }} +{{Form::model($piggyBank, ['class' => 'form-horizontal','id' => 'update','url' => route('piggybanks.update',$piggyBank->id)])}}

diff --git a/app/views/piggybanks/index.blade.php b/app/views/piggybanks/index.blade.php index 5d7a13d317..3bdc4ff6cc 100644 --- a/app/views/piggybanks/index.blade.php +++ b/app/views/piggybanks/index.blade.php @@ -2,52 +2,52 @@ @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }}
- @foreach($piggybanks as $piggybank) + @foreach($piggyBanks as $piggyBank)
- {{{$piggybank->name}}} + {{{$piggyBank->name}}}
- {{mf($piggybank->savedSoFar,true)}} + {{mf($piggyBank->savedSoFar,true)}}
percentage == 100) + @if($piggyBank->percentage == 100) class="progress-bar progress-bar-success" @else class="progress-bar progress-bar-info" @endif - role="progressbar" aria-valuenow="{{$piggybank->percentage}}" aria-valuemin="0" aria-valuemax="100" style="min-width: 40px;width: {{$piggybank->percentage}}%;"> - {{$piggybank->percentage}}% + role="progressbar" aria-valuenow="{{$piggyBank->percentage}}" aria-valuemin="0" aria-valuemax="100" style="min-width: 40px;width: {{$piggyBank->percentage}}%;"> + {{$piggyBank->percentage}}%
- {{mf($piggybank->targetamount,true)}} + {{mf($piggyBank->targetamount,true)}}
- @if($piggybank->leftToSave > 0) - + @if($piggyBank->leftToSave > 0) + @endif - +
- - + +
- @if($piggybank->leftToSave > 0) - {{mf($piggybank->leftToSave)}} + @if($piggyBank->leftToSave > 0) + {{mf($piggyBank->leftToSave)}} @endif
diff --git a/app/views/piggybanks/remove.blade.php b/app/views/piggybanks/remove.blade.php index d6d5a81f66..b0846bff2e 100644 --- a/app/views/piggybanks/remove.blade.php +++ b/app/views/piggybanks/remove.blade.php @@ -1,18 +1,18 @@ - + {{Form::token()}}
- +

- The maximum amount you can remove is {{mf($piggybank->currentRelevantRep()->currentamount)}} + The maximum amount you can remove is {{mf($piggyBank->currentRelevantRep()->currentamount)}}

€
- +
diff --git a/app/views/piggybanks/show.blade.php b/app/views/piggybanks/show.blade.php index 1dedd643d1..48f79b9f7d 100644 --- a/app/views/piggybanks/show.blade.php +++ b/app/views/piggybanks/show.blade.php @@ -1,6 +1,6 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggybank) }} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }}
@@ -25,8 +25,8 @@
@@ -36,54 +36,54 @@ - + - + - + - + - @if(!is_null($piggybank->reminder)) + @if(!is_null($piggyBank->reminder)) @@ -116,7 +116,7 @@ @section('scripts') From 7a9df05f6bc23b37707abc2ee379436a33aae4ef Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 20:55:42 +0100 Subject: [PATCH 03/84] A giant rename action in preparation of v3.2.2 --- app/breadcrumbs.php | 12 +-- app/commands/Cleanup.php | 2 +- app/config/firefly.php | 2 +- app/controllers/GoogleChartController.php | 6 +- app/controllers/PiggybankController.php | 86 +++++++++--------- app/controllers/ReminderController.php | 2 +- app/controllers/RepeatedExpenseController.php | 12 +-- app/controllers/TransactionController.php | 8 +- .../2014_12_13_190730_changes_for_v321.php | 1 + app/database/seeds/TestContentSeeder.php | 16 ++-- .../FireflyIII/Collection/PiggybankPart.php | 12 +-- .../Database/PiggyBank/PiggyBank.php | 30 +++---- .../Database/PiggyBank/RepeatedExpense.php | 26 +++--- .../Database/Transaction/Transaction.php | 4 +- app/lib/FireflyIII/Event/Event.php | 4 +- app/lib/FireflyIII/Event/Piggybank.php | 89 +++++++++---------- .../FireflyIII/Shared/Toolkit/Reminders.php | 8 +- app/lib/FireflyIII/Shared/Toolkit/Steam.php | 6 +- app/models/Account.php | 4 +- app/models/Piggybank.php | 30 +++---- app/models/PiggybankEvent.php | 6 +- app/models/PiggybankRepetition.php | 12 +-- app/models/Transaction.php | 3 +- app/models/TransactionJournal.php | 4 +- app/models/User.php | 2 +- app/routes.php | 44 ++++----- app/tests/PiggybankPartTest.php | 40 ++++----- app/views/list/piggybank-events.blade.php | 6 +- app/views/partials/menu.blade.php | 6 +- .../{piggybanks => piggy_banks}/add.blade.php | 2 +- .../create.blade.php | 2 +- .../delete.blade.php | 2 +- .../edit.blade.php | 2 +- .../index.blade.php | 10 +-- .../remove.blade.php | 2 +- .../show.blade.php | 10 +-- app/views/reminders/show.blade.php | 2 +- app/views/transactions/create.blade.php | 2 +- app/views/transactions/delete.blade.php | 2 +- app/views/transactions/edit.blade.php | 2 +- app/views/transactions/show.blade.php | 4 +- bootstrap/start.php | 5 -- .../firefly/{piggybanks.js => piggy_banks.js} | 6 +- .../functional/GoogleChartControllerCest.php | 2 +- tests/functional/PiggyBankControllerCest.php | 48 +++++----- 45 files changed, 289 insertions(+), 297 deletions(-) rename app/views/{piggybanks => piggy_banks}/add.blade.php (90%) rename app/views/{piggybanks => piggy_banks}/create.blade.php (98%) rename app/views/{piggybanks => piggy_banks}/delete.blade.php (94%) rename app/views/{piggybanks => piggy_banks}/edit.blade.php (98%) rename app/views/{piggybanks => piggy_banks}/index.blade.php (88%) rename app/views/{piggybanks => piggy_banks}/remove.blade.php (95%) rename app/views/{piggybanks => piggy_banks}/show.blade.php (92%) rename public/assets/javascript/firefly/{piggybanks.js => piggy_banks.js} (60%) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 487b182ed3..c4b3d78c15 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -147,20 +147,20 @@ Breadcrumbs::register( ); Breadcrumbs::register( - 'piggyBanks.edit', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'piggyBanks.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.show', $piggyBank); $breadcrumbs->push('Edit ' . $piggyBank->name, route('piggyBanks.edit', $piggyBank->id)); } ); Breadcrumbs::register( - 'piggyBanks.delete', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'piggyBanks.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.show', $piggyBank); $breadcrumbs->push('Delete ' . $piggyBank->name, route('piggyBanks.delete', $piggyBank->id)); } ); Breadcrumbs::register( - 'piggyBanks.show', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'piggyBanks.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.index'); $breadcrumbs->push($piggyBank->name, route('piggyBanks.show', $piggyBank->id)); @@ -251,20 +251,20 @@ Breadcrumbs::register( ); Breadcrumbs::register( - 'repeated.edit', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'repeated.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.show', $piggyBank); $breadcrumbs->push('Edit ' . $piggyBank->name, route('repeated.edit', $piggyBank->id)); } ); Breadcrumbs::register( - 'repeated.delete', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'repeated.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.show', $piggyBank); $breadcrumbs->push('Delete ' . $piggyBank->name, route('repeated.delete', $piggyBank->id)); } ); Breadcrumbs::register( - 'repeated.show', function (Generator $breadcrumbs, Piggybank $piggyBank) { + 'repeated.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.index'); $breadcrumbs->push($piggyBank->name, route('repeated.show', $piggyBank->id)); diff --git a/app/commands/Cleanup.php b/app/commands/Cleanup.php index 76b734fe53..aca68e02a1 100644 --- a/app/commands/Cleanup.php +++ b/app/commands/Cleanup.php @@ -43,7 +43,7 @@ class Cleanup extends Command $this->info('Cleared compiled...'); Artisan::call('ide-helper:generate'); $this->info('IDE helper, done...'); - Artisan::call('ide-helper:models', ['nowrite']); + Artisan::call('ide-helper:models'); $this->info('IDE models, done...'); Artisan::call('optimize'); $this->info('Optimized...'); diff --git a/app/config/firefly.php b/app/config/firefly.php index eea3380786..9d886aa4f9 100644 --- a/app/config/firefly.php +++ b/app/config/firefly.php @@ -3,7 +3,7 @@ return [ 'index_periods' => ['1D', '1W', '1M', '3M', '6M', '1Y', 'custom'], 'budget_periods' => ['daily', 'weekly', 'monthly', 'quarterly', 'half-year', 'yearly'], - 'piggybank_periods' => [ + 'piggy_bank_periods' => [ 'week' => 'Week', 'month' => 'Month', 'quarter' => 'Quarter', diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index 2b5c50c22d..634153bf0b 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -312,16 +312,16 @@ class GoogleChartController extends BaseController } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\Http\JsonResponse */ - public function piggyBankHistory(\Piggybank $piggyBank) + public function piggyBankHistory(\PiggyBank $piggyBank) { $this->_chart->addColumn('Date', 'date'); $this->_chart->addColumn('Balance', 'number'); - $set = \DB::table('piggy_bank_events')->where('piggybank_id', $piggyBank->id)->groupBy('date')->get(['date', DB::Raw('SUM(`amount`) AS `sum`')]); + $set = \DB::table('piggy_bank_events')->where('piggy_bank_id', $piggyBank->id)->groupBy('date')->get(['date', DB::Raw('SUM(`amount`) AS `sum`')]); foreach ($set as $entry) { $this->_chart->addRow(new Carbon($entry->date), floatval($entry->sum)); diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 3f6b4d7626..0ba6f9c8ce 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -13,10 +13,10 @@ use Illuminate\Support\Collection; * @SuppressWarnings("CouplingBetweenObjects") // There's only so much I can remove. * * - * Class PiggybankController + * Class PiggyBankController * */ -class PiggybankController extends BaseController +class PiggyBankController extends BaseController { /** @var Repository */ @@ -35,11 +35,11 @@ class PiggybankController extends BaseController /** * Add money to piggy bank * - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return $this */ - public function add(Piggybank $piggyBank) + public function add(PiggyBank $piggyBank) { $leftOnAccount = $this->_repository->leftOnAccount($piggyBank->account); $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; @@ -49,7 +49,7 @@ class PiggybankController extends BaseController \Log::debug('Now going to view for piggy bank #' . $piggyBank->id . ' (' . $piggyBank->name . ')'); - return View::make('piggybanks.add', compact('piggyBank', 'maxAmount')); + return View::make('piggy_banks.add', compact('piggyBank', 'maxAmount')); } /** @@ -61,52 +61,52 @@ class PiggybankController extends BaseController /** @var \FireflyIII\Database\Account\Account $acct */ $acct = App::make('FireflyIII\Database\Account\Account'); - $periods = Config::get('firefly.piggybank_periods'); + $periods = Config::get('firefly.piggy_bank_periods'); $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); $subTitle = 'Create new piggy bank'; $subTitleIcon = 'fa-plus'; - return View::make('piggybanks.create', compact('accounts', 'periods', 'subTitle', 'subTitleIcon')); + return View::make('piggy_banks.create', compact('accounts', 'periods', 'subTitle', 'subTitleIcon')); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return $this */ - public function delete(Piggybank $piggyBank) + public function delete(PiggyBank $piggyBank) { $subTitle = 'Delete "' . e($piggyBank->name) . '"'; - return View::make('piggybanks.delete', compact('piggyBank', 'subTitle')); + return View::make('piggy_banks.delete', compact('piggyBank', 'subTitle')); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\Http\RedirectResponse */ - public function destroy(Piggybank $piggyBank) + public function destroy(PiggyBank $piggyBank) { Session::flash('success', 'Piggy bank "' . e($piggyBank->name) . '" deleted.'); $this->_repository->destroy($piggyBank); - return Redirect::route('piggybanks.index'); + return Redirect::route('piggy_banks.index'); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return $this */ - public function edit(Piggybank $piggyBank) + public function edit(PiggyBank $piggyBank) { /** @var \FireflyIII\Database\Account\Account $acct */ $acct = App::make('FireflyIII\Database\Account\Account'); - $periods = Config::get('firefly.piggybank_periods'); + $periods = Config::get('firefly.piggy_bank_periods'); $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); $subTitle = 'Edit piggy bank "' . e($piggyBank->name) . '"'; $subTitleIcon = 'fa-pencil'; @@ -129,7 +129,7 @@ class PiggybankController extends BaseController ]; Session::flash('preFilled', $preFilled); - return View::make('piggybanks.edit', compact('subTitle', 'subTitleIcon', 'piggyBank', 'accounts', 'periods', 'preFilled')); + return View::make('piggy_banks.edit', compact('subTitle', 'subTitleIcon', 'piggyBank', 'accounts', 'periods', 'preFilled')); } /** @@ -141,7 +141,7 @@ class PiggybankController extends BaseController $piggyBanks = $this->_repository->get(); $accounts = []; - /** @var Piggybank $piggyBank */ + /** @var PiggyBank $piggyBank */ foreach ($piggyBanks as $piggyBank) { $piggyBank->savedSoFar = floatval($piggyBank->currentRelevantRep()->currentamount); $piggyBank->percentage = intval($piggyBank->savedSoFar / $piggyBank->targetamount * 100); @@ -167,17 +167,17 @@ class PiggybankController extends BaseController } } - return View::make('piggybanks.index', compact('piggyBanks', 'accounts')); + return View::make('piggy_banks.index', compact('piggyBanks', 'accounts')); } /** * POST add money to piggy bank * - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\Http\RedirectResponse */ - public function postAdd(Piggybank $piggyBank) + public function postAdd(PiggyBank $piggyBank) { $amount = round(floatval(Input::get('amount')), 2); @@ -197,22 +197,22 @@ class PiggybankController extends BaseController /* * Create event! */ - Event::fire('piggybank.addMoney', [$piggyBank, $amount]); // new and used. + Event::fire('piggy_bank.addMoney', [$piggyBank, $amount]); // new and used. Session::flash('success', 'Added ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); } else { Session::flash('error', 'Could not add ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); } - return Redirect::route('piggybanks.index'); + return Redirect::route('piggy_banks.index'); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\Http\RedirectResponse */ - public function postRemove(Piggybank $piggyBank) + public function postRemove(PiggyBank $piggyBank) { $amount = floatval(Input::get('amount')); @@ -226,35 +226,35 @@ class PiggybankController extends BaseController /* * Create event! */ - Event::fire('piggybank.removeMoney', [$piggyBank, $amount]); // new and used. + Event::fire('piggy_bank.removeMoney', [$piggyBank, $amount]); // new and used. Session::flash('success', 'Removed ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); } else { Session::flash('error', 'Could not remove ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); } - return Redirect::route('piggybanks.index'); + return Redirect::route('piggy_banks.index'); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\View\View */ - public function remove(Piggybank $piggyBank) + public function remove(PiggyBank $piggyBank) { - return View::make('piggybanks.remove',compact('piggyBank')); + return View::make('piggy_banks.remove',compact('piggyBank')); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return $this */ - public function show(Piggybank $piggyBank) + public function show(PiggyBank $piggyBank) { - $events = $piggyBank->piggybankevents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->get(); + $events = $piggyBank->piggyBankEvents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->get(); /* * Number of reminders: @@ -264,7 +264,7 @@ class PiggybankController extends BaseController $remindersCount = $piggyBank->countFutureReminders(); $subTitle = e($piggyBank->name); - return View::make('piggybanks.show', compact('amountPerReminder', 'remindersCount', 'piggyBank', 'events', 'subTitle')); + return View::make('piggy_banks.show', compact('amountPerReminder', 'remindersCount', 'piggyBank', 'events', 'subTitle')); } @@ -292,27 +292,27 @@ class PiggybankController extends BaseController // return to create screen: if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { - return Redirect::route('piggybanks.create')->withInput(); + return Redirect::route('piggy_banks.create')->withInput(); } // store: $piggyBank = $this->_repository->store($data); - Event::fire('piggybank.store', [$piggyBank]); // new and used. + Event::fire('piggy_bank.store', [$piggyBank]); // new and used. Session::flash('success', 'Piggy bank "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { - return Redirect::route('piggybanks.index'); + return Redirect::route('piggy_banks.index'); } - return Redirect::route('piggybanks.create')->withInput(); + return Redirect::route('piggy_banks.create')->withInput(); } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return $this * @throws FireflyException */ - public function update(Piggybank $piggyBank) + public function update(PiggyBank $piggyBank) { $data = Input::except('_token'); @@ -335,7 +335,7 @@ class PiggybankController extends BaseController // return to update screen: if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { - return Redirect::route('piggybanks.edit', $piggyBank->id)->withInput(); + return Redirect::route('piggy_banks.edit', $piggyBank->id)->withInput(); } // update @@ -344,11 +344,11 @@ class PiggybankController extends BaseController // go back to list if ($data['post_submit_action'] == 'update') { - return Redirect::route('piggybanks.index'); + return Redirect::route('piggy_banks.index'); } // go back to update screen. - return Redirect::route('piggybanks.edit', $piggyBank->id)->withInput(['post_submit_action' => 'return_to_edit']); + return Redirect::route('piggy_banks.edit', $piggyBank->id)->withInput(['post_submit_action' => 'return_to_edit']); } } \ No newline at end of file diff --git a/app/controllers/ReminderController.php b/app/controllers/ReminderController.php index e22823e836..2ef658ec04 100644 --- a/app/controllers/ReminderController.php +++ b/app/controllers/ReminderController.php @@ -36,7 +36,7 @@ class ReminderController extends BaseController $preFilled = [ 'amount' => round($amount, 2), 'description' => 'Money for ' . $reminder->remindersable->name, - 'piggybank_id' => $reminder->remindersable_id, + 'piggy_bank_id' => $reminder->remindersable_id, 'account_to_id' => $reminder->remindersable->account_id ]; Session::flash('preFilled', $preFilled); diff --git a/app/controllers/RepeatedExpenseController.php b/app/controllers/RepeatedExpenseController.php index 71f821dfbc..20c73aeee8 100644 --- a/app/controllers/RepeatedExpenseController.php +++ b/app/controllers/RepeatedExpenseController.php @@ -30,7 +30,7 @@ class RepeatedExpenseController extends BaseController /** @var \FireflyIII\Database\Account\Account $acct */ $acct = App::make('FireflyIII\Database\Account\Account'); - $periods = Config::get('firefly.piggybank_periods'); + $periods = Config::get('firefly.piggy_bank_periods'); $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); @@ -53,7 +53,7 @@ class RepeatedExpenseController extends BaseController $expenses = $repository->get(); $expenses->each( - function (Piggybank $piggyBank) use ($repository) { + function (PiggyBank $piggyBank) use ($repository) { $piggyBank->currentRelevantRep(); } ); @@ -62,11 +62,11 @@ class RepeatedExpenseController extends BaseController } /** - * @param Piggybank $piggyBank + * @param PiggyBank $piggyBank * * @return \Illuminate\View\View */ - public function show(Piggybank $piggyBank) + public function show(PiggyBank $piggyBank) { $subTitle = $piggyBank->name; $today = Carbon::now(); @@ -74,9 +74,9 @@ class RepeatedExpenseController extends BaseController /** @var \FireflyIII\Database\PiggyBank\RepeatedExpense $repository */ $repository = App::make('FireflyIII\Database\PiggyBank\RepeatedExpense'); - $repetitions = $piggyBank->piggybankrepetitions()->get(); + $repetitions = $piggyBank->piggyBankRepetitions()->get(); $repetitions->each( - function (PiggybankRepetition $repetition) use ($repository) { + function (PiggyBankRepetition $repetition) use ($repository) { $repetition->bars = $repository->calculateParts($repetition); } ); diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 7f1eb8ca3a..ba2035f3ad 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -227,7 +227,7 @@ class TransactionController extends BaseController 'date' => $journal->date->format('Y-m-d'), 'category' => '', 'budget_id' => 0, - 'piggybank_id' => 0 + 'piggy_bank_id' => 0 ]; /* @@ -289,8 +289,8 @@ class TransactionController extends BaseController $preFilled['account_to_id'] = $journal->transactions[0]->account->id; $preFilled['amount'] = floatval($journal->transactions[0]->amount); } - if ($journal->piggybankevents()->count() > 0) { - $preFilled['piggybank_id'] = $journal->piggybankevents()->first()->piggybank_id; + if ($journal->piggyBankEvents()->count() > 0) { + $preFilled['piggy_bank_id'] = $journal->piggyBankEvents()->first()->piggy_bank_id; } break; } @@ -461,7 +461,7 @@ class TransactionController extends BaseController * Trigger a search for the related (if selected) * piggy bank and store an event. */ - Event::fire('transactionJournal.store', [$journal, Input::get('piggybank_id')]); // new and used. + Event::fire('transactionJournal.store', [$journal, Input::get('piggy_bank_id')]); // new and used. /* * Also trigger on both transactions. */ diff --git a/app/database/migrations/2014_12_13_190730_changes_for_v321.php b/app/database/migrations/2014_12_13_190730_changes_for_v321.php index 7185cde1b8..40c878e971 100644 --- a/app/database/migrations/2014_12_13_190730_changes_for_v321.php +++ b/app/database/migrations/2014_12_13_190730_changes_for_v321.php @@ -2,6 +2,7 @@ use Illuminate\Database\Migrations\Migration; use Illuminate\Database\Schema\Blueprint; +use Illuminate\Support\Facades\Schema; /** * Down: diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index dabac9f474..a6aba6edbf 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -79,7 +79,7 @@ class TestContentSeeder extends Seeder Component::create(['user_id' => $user->id, 'name' => 'Some Component 7', 'class' => 'Category']); // piggy bank - $piggy = Piggybank::create( + $piggy = PiggyBank::create( [ 'account_id' => $savings->id, 'name' => 'New camera', @@ -96,10 +96,10 @@ class TestContentSeeder extends Seeder 'order' => 0, ] ); - PiggyBankEvent::create(['piggybank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); - PiggybankRepetition::create( + PiggyBankEvent::create(['piggy_bank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); + PiggyBankRepetition::create( [ - 'piggybank_id' => $piggy->id, + 'piggy_bank_id' => $piggy->id, 'startdate' => Carbon::now()->format('Y-m-d'), 'targetdate' => null, 'currentamount' => 0 @@ -107,7 +107,7 @@ class TestContentSeeder extends Seeder ); // piggy bank - $piggyTargeted = Piggybank::create( + $piggyTargeted = PiggyBank::create( [ 'account_id' => $savings->id, 'name' => 'New clothes', @@ -125,10 +125,10 @@ class TestContentSeeder extends Seeder ] ); - PiggyBankEvent::create(['piggybank_id' => $piggyTargeted->id, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); - PiggybankRepetition::create( + PiggyBankEvent::create(['piggy_bank_id' => $piggyTargeted->id, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); + PiggyBankRepetition::create( [ - 'piggybank_id' => $piggyTargeted->id, + 'piggy_bank_id' => $piggyTargeted->id, 'startdate' => Carbon::now()->format('Y-m-d'), 'targetdate' => Carbon::now()->addMonths(4)->format('Y-m-d'), 'currentamount' => 0 diff --git a/app/lib/FireflyIII/Collection/PiggybankPart.php b/app/lib/FireflyIII/Collection/PiggybankPart.php index 4c60b21591..17193d597b 100644 --- a/app/lib/FireflyIII/Collection/PiggybankPart.php +++ b/app/lib/FireflyIII/Collection/PiggybankPart.php @@ -6,11 +6,11 @@ namespace FireflyIII\Collection; use Carbon\Carbon; /** - * Class PiggybankPart + * Class PiggyBankPart * * @package FireflyIII\Collection */ -class PiggybankPart +class PiggyBankPart { /** @var float */ public $amountPerBar; @@ -21,7 +21,7 @@ class PiggybankPart /** @var \Reminder */ public $reminder; - /** @var \PiggybankRepetition */ + /** @var \PiggyBankRepetition */ public $repetition; /** @var Carbon */ @@ -36,7 +36,7 @@ class PiggybankPart public function getReminder() { if (is_null($this->reminder)) { - $this->reminder = $this->repetition->piggybank->reminders()->where('startdate', $this->getStartdate()->format('Y-m-d'))->where( + $this->reminder = $this->repetition->piggyBank->reminders()->where('startdate', $this->getStartdate()->format('Y-m-d'))->where( 'enddate', $this->getTargetdate()->format('Y-m-d') )->first(); } @@ -85,7 +85,7 @@ class PiggybankPart } /** - * @return \PiggybankRepetition + * @return \PiggyBankRepetition */ public function getRepetition() { @@ -93,7 +93,7 @@ class PiggybankPart } /** - * @param \PiggybankRepetition $repetition + * @param \PiggyBankRepetition $repetition */ public function setRepetition($repetition) { diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index 9325da329b..289810fb34 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -12,7 +12,7 @@ use Illuminate\Support\Collection; use Illuminate\Support\MessageBag; /** - * Class Piggybank + * Class PiggyBank * * @package FireflyIII\Database */ @@ -49,7 +49,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface if (!isset($data['remind_me']) || (isset($data['remind_me']) && $data['remind_me'] == 0)) { $data['reminder'] = null; } - $piggyBank = new \Piggybank($data); + $piggyBank = new \PiggyBank($data); $piggyBank->save(); return $piggyBank; @@ -63,7 +63,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface */ public function update(Eloquent $model, array $data) { - /** @var \Piggybank $model */ + /** @var \PiggyBank $model */ $model->name = $data['name']; $model->account_id = intval($data['account_id']); $model->targetamount = floatval($data['targetamount']); @@ -129,7 +129,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface if (floatval($model['targetamount']) < 0.01) { $errors->add('targetamount', 'Amount should be above 0.01.'); } - if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggybank_periods'))) { + if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); } // check period. @@ -152,7 +152,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface } } - $validator = \Validator::make($model, \Piggybank::$rules); + $validator = \Validator::make($model, \PiggyBank::$rules); if ($validator->invalid()) { $errors->merge($errors); } @@ -177,11 +177,11 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface */ public function find($objectId) { - return \Piggybank:: - leftJoin('accounts', 'accounts.id', '=', 'piggybanks.account_id')->where('piggybanks.id', '=', $objectId)->where( + return \PiggyBank:: + leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')->where('piggy_banks.id', '=', $objectId)->where( 'accounts.user_id', $this->getUser()->id ) - ->first(['piggybanks.*']); + ->first(['piggy_banks.*']); } /** @@ -205,7 +205,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface */ public function get() { - return $this->getUser()->piggybanks()->where('repeats', 0)->get(); + return $this->getUser()->piggyBanks()->where('repeats', 0)->get(); } /** @@ -221,17 +221,17 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface } /** - * @param \Piggybank $piggyBank + * @param \PiggyBank $piggyBank * @param Carbon $date * * @return mixed * @throws FireflyException * @throws NotImplementedException */ - public function findRepetitionByDate(\Piggybank $piggyBank, Carbon $date) + public function findRepetitionByDate(\PiggyBank $piggyBank, Carbon $date) { /** @var Collection $reps */ - $reps = $piggyBank->piggybankrepetitions()->get(); + $reps = $piggyBank->piggyBankRepetitions()->get(); if ($reps->count() == 1) { return $reps->first(); } @@ -240,7 +240,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface } // should filter the one we need: $repetitions = $reps->filter( - function (\PiggybankRepetition $rep) use ($date) { + function (\PiggyBankRepetition $rep) use ($date) { if ($date >= $rep->startdate && $date <= $rep->targetdate) { return $rep; } @@ -265,8 +265,8 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface \Log::debug('Now in leftOnAccount() for account #'.$account->id.' ('.$account->name.')'); $balance = \Steam::balance($account); \Log::debug('Steam says: ' . $balance); - /** @var \Piggybank $p */ - foreach ($account->piggybanks()->get() as $p) { + /** @var \PiggyBank $p */ + foreach ($account->piggyBanks()->get() as $p) { $balance -= $p->currentRelevantRep()->currentamount; } diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index 100e78a427..d0d35947b3 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -4,7 +4,7 @@ namespace FireflyIII\Database\PiggyBank; use Carbon\Carbon; -use FireflyIII\Collection\PiggybankPart; +use FireflyIII\Collection\PiggyBankPart; use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; use FireflyIII\Database\SwitchUser; @@ -35,14 +35,14 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface * other variables this method tries to divide the piggy bank into equal parts. Each is * accommodated by a reminder (if everything goes to plan). * - * @param \PiggybankRepetition $repetition + * @param \PiggyBankRepetition $repetition * * @return Collection */ - public function calculateParts(\PiggybankRepetition $repetition) + public function calculateParts(\PiggyBankRepetition $repetition) { - /** @var \Piggybank $piggyBank */ - $piggyBank = $repetition->piggybank()->first(); + /** @var \PiggyBank $piggyBank */ + $piggyBank = $repetition->piggyBank()->first(); $bars = new Collection; $currentStart = clone $repetition->startdate; @@ -66,7 +66,7 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface } $amountPerBar = floatval($piggyBank->targetamount) / $bars->count(); $cumulative = $amountPerBar; - /** @var PiggybankPart $bar */ + /** @var PiggyBankPart $bar */ foreach ($bars as $index => $bar) { $bar->setAmountPerBar($amountPerBar); $bar->setCumulativeAmount($cumulative); @@ -82,11 +82,11 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface /** * @param array $data * - * @return PiggybankPart + * @return PiggyBankPart */ public function createPiggyBankPart(array $data) { - $part = new PiggybankPart; + $part = new PiggyBankPart; $part->setRepetition($data['repetition']); $part->setAmountPerBar($data['amountPerBar']); $part->setCurrentamount($data['currentAmount']); @@ -128,7 +128,7 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface $data['reminder'] = null; } - $repeated = new \Piggybank($data); + $repeated = new \PiggyBank($data); $repeated->save(); return $repeated; @@ -200,11 +200,11 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface if (floatval($model['targetamount']) < 0.01) { $errors->add('targetamount', 'Amount should be above 0.01.'); } - if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggybank_periods'))) { + if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); } - if (!in_array(ucfirst($model['rep_length']), \Config::get('firefly.piggybank_periods'))) { + if (!in_array(ucfirst($model['rep_length']), \Config::get('firefly.piggy_bank_periods'))) { $errors->add('rep_length', 'Invalid repeat period (' . $model['rep_length'] . ')'); } @@ -228,7 +228,7 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface } } - $validator = \Validator::make($model, \Piggybank::$rules); + $validator = \Validator::make($model, \PiggyBank::$rules); if ($validator->invalid()) { $errors->merge($errors); } @@ -279,7 +279,7 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface */ public function get() { - return $this->getUser()->piggybanks()->where('repeats', 1)->get(); + return $this->getUser()->piggyBanks()->where('repeats', 1)->get(); } /** diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index 467ae5c9de..27dd9c6e39 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -44,8 +44,8 @@ class Transaction implements CUD, CommonDatabaseCalls $transaction->account()->associate($data['account']); $transaction->transactionJournal()->associate($data['transaction_journal']); $transaction->amount = floatval($data['amount']); - if (isset($data['piggybank'])) { - $transaction->piggybank()->associate($data['piggybank']); + if (isset($data['piggyBank'])) { + $transaction->piggyBank()->associate($data['piggyBank']); } if (isset($data['description'])) { $transaction->description = $data['description']; diff --git a/app/lib/FireflyIII/Event/Event.php b/app/lib/FireflyIII/Event/Event.php index 0f4bfda97a..74d334fe07 100644 --- a/app/lib/FireflyIII/Event/Event.php +++ b/app/lib/FireflyIII/Event/Event.php @@ -20,10 +20,10 @@ class Event public function deleteAccount(\Account $account) { // get piggy banks - $piggies = $account->piggybanks()->get(); + $piggies = $account->piggyBanks()->get(); // get reminders for each - /** @var \Piggybank $piggyBank */ + /** @var \PiggyBank $piggyBank */ foreach ($piggies as $piggyBank) { $reminders = $piggyBank->reminders()->get(); /** @var \Reminder $reminder */ diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index 1b1c9cde1c..3de0e84d00 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -7,22 +7,22 @@ use Carbon\Carbon; use Illuminate\Events\Dispatcher; /** - * Class Piggybank + * Class PiggyBank * * @package FireflyIII\Event */ -class Piggybank +class PiggyBank { /** - * @param \Piggybank $piggyBank + * @param \PiggyBank $piggyBank * @param float $amount */ - public function addMoney(\Piggybank $piggyBank, $amount = 0.0) + public function addMoney(\PiggyBank $piggyBank, $amount = 0.0) { if ($amount > 0) { $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggyBank); + $event->piggyBank()->associate($piggyBank); $event->amount = floatval($amount); $event->date = new Carbon; if (!$event->isValid()) { @@ -41,15 +41,15 @@ class Piggybank */ public function destroyTransfer(\TransactionJournal $journal) { - if ($journal->piggybankevents()->count() > 0) { + if ($journal->piggyBankEvents()->count() > 0) { /** @var \FireflyIII\Database\PiggyBank\PiggyBank $repository */ $repository = \App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - /** @var \Piggybank $piggyBank */ - $piggyBank = $journal->piggybankevents()->first()->piggybank()->first(); + /** @var \PiggyBank $piggyBank */ + $piggyBank = $journal->piggyBankEvents()->first()->piggyBank()->first(); - /** @var \PiggybankRepetition $repetition */ + /** @var \PiggyBankRepetition $repetition */ $repetition = $repository->findRepetitionByDate($piggyBank, $journal->date); $relevantTransaction = null; @@ -68,7 +68,7 @@ class Piggybank $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggyBank); + $event->piggyBank()->associate($piggyBank); $event->amount = floatval($relevantTransaction->amount * -1); $event->date = new Carbon; $event->save(); @@ -76,15 +76,15 @@ class Piggybank } /** - * @param \Piggybank $piggyBank + * @param \PiggyBank $piggyBank * @param float $amount */ - public function removeMoney(\Piggybank $piggyBank, $amount = 0.0) + public function removeMoney(\PiggyBank $piggyBank, $amount = 0.0) { $amount = $amount * -1; if ($amount < 0) { $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggyBank); + $event->piggyBank()->associate($piggyBank); $event->amount = floatval($amount); $event->date = new Carbon; $event->save(); @@ -92,13 +92,13 @@ class Piggybank } /** - * @param \Piggybank $piggyBank + * @param \PiggyBank $piggyBank */ - public function storePiggybank(\Piggybank $piggyBank) + public function storePiggyBank(\PiggyBank $piggyBank) { if (intval($piggyBank->repeats) == 0) { - $repetition = new \PiggybankRepetition; - $repetition->piggybank()->associate($piggyBank); + $repetition = new \PiggyBankRepetition; + $repetition->piggyBank()->associate($piggyBank); $repetition->startdate = $piggyBank->startdate; $repetition->targetdate = $piggyBank->targetdate; $repetition->currentamount = 0; @@ -122,13 +122,13 @@ class Piggybank /** @var \FireflyIII\Database\PiggyBank\PiggyBank $repository */ $repository = \App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - /** @var \Piggybank $piggyBank */ + /** @var \PiggyBank $piggyBank */ $piggyBank = $repository->find($piggyBankId); if ($journal->transactions()->where('account_id', $piggyBank->account_id)->count() == 0) { return; } - /** @var \PiggybankRepetition $repetition */ + /** @var \PiggyBankRepetition $repetition */ $repetition = $repository->findRepetitionByDate($piggyBank, $journal->date); $amount = floatval($piggyBank->targetamount); $leftToSave = $amount - floatval($repetition->currentamount); @@ -146,7 +146,7 @@ class Piggybank $repetition->currentamount += floatval($transaction->amount); $repetition->save(); $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggyBank); + $event->piggyBank()->associate($piggyBank); $event->transactionjournal()->associate($journal); $event->amount = floatval($transaction->amount); $event->date = new Carbon; @@ -160,10 +160,10 @@ class Piggybank public function subscribe(Dispatcher $events) { // triggers on piggy bank events: - $events->listen('piggybank.addMoney', 'FireflyIII\Event\Piggybank@addMoney'); - $events->listen('piggybank.removeMoney', 'FireflyIII\Event\Piggybank@removeMoney'); - $events->listen('piggybank.store', 'FireflyIII\Event\Piggybank@storePiggybank'); - $events->listen('piggybank.update', 'FireflyIII\Event\Piggybank@updatePiggybank'); + $events->listen('piggy_bank.addMoney', 'FireflyIII\Event\PiggyBank@addMoney'); + $events->listen('piggy_bank.removeMoney', 'FireflyIII\Event\PiggyBank@removeMoney'); + $events->listen('piggy_bank.store', 'FireflyIII\Event\PiggyBank@storePiggyBank'); + $events->listen('piggy_bank.update', 'FireflyIII\Event\PiggyBank@updatePiggyBank'); \App::before( function () { @@ -171,13 +171,10 @@ class Piggybank } ); - //$events->listen('piggybank.boo', 'FireflyIII\Event\Piggybank@updatePiggybank'); - - // triggers when others are updated. - $events->listen('transactionJournal.store', 'FireflyIII\Event\Piggybank@storeTransfer'); - $events->listen('transactionJournal.update', 'FireflyIII\Event\Piggybank@updateTransfer'); - $events->listen('transactionJournal.destroy', 'FireflyIII\Event\Piggybank@destroyTransfer'); + $events->listen('transactionJournal.store', 'FireflyIII\Event\PiggyBank@storeTransfer'); + $events->listen('transactionJournal.update', 'FireflyIII\Event\PiggyBank@updateTransfer'); + $events->listen('transactionJournal.destroy', 'FireflyIII\Event\PiggyBank@destroyTransfer'); } /** @@ -194,15 +191,15 @@ class Piggybank $list = $repository->get(); $today = Carbon::now(); - /** @var \Piggybank $entry */ + /** @var \PiggyBank $entry */ foreach ($list as $entry) { $start = $entry->startdate; $target = $entry->targetdate; // find a repetition on this date: - $count = $entry->piggybankrepetitions()->starts($start)->targets($target)->count(); + $count = $entry->piggyBankrepetitions()->starts($start)->targets($target)->count(); if ($count == 0) { - $repetition = new \PiggybankRepetition; - $repetition->piggybank()->associate($entry); + $repetition = new \PiggyBankRepetition; + $repetition->piggyBank()->associate($entry); $repetition->startdate = $start; $repetition->targetdate = $target; $repetition->currentamount = 0; @@ -216,10 +213,10 @@ class Piggybank $currentStart = \DateKit::subtractPeriod($currentTarget, $entry->rep_length, 0); $currentTarget = \DateKit::addPeriod($currentTarget, $entry->rep_length, 0); // create if not exists: - $count = $entry->piggybankrepetitions()->starts($currentStart)->targets($currentTarget)->count(); + $count = $entry->piggyBankRepetitions()->starts($currentStart)->targets($currentTarget)->count(); if ($count == 0) { - $repetition = new \PiggybankRepetition; - $repetition->piggybank()->associate($entry); + $repetition = new \PiggyBankRepetition; + $repetition->piggyBank()->associate($entry); $repetition->startdate = $currentStart; $repetition->targetdate = $currentTarget; $repetition->currentamount = 0; @@ -231,9 +228,9 @@ class Piggybank } /** - * @param \Piggybank $piggyBank + * @param \PiggyBank $piggyBank */ - public function updatePiggybank(\Piggybank $piggyBank) + public function updatePiggyBank(\PiggyBank $piggyBank) { // get the repetition: $repetition = $piggyBank->currentRelevantRep(); @@ -251,18 +248,18 @@ class Piggybank public function updateTransfer(\TransactionJournal $journal) { - if ($journal->piggybankevents()->count() > 0) { + if ($journal->piggyBankEvents()->count() > 0) { - $event = $journal->piggybankevents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->first(); - $eventSum = floatval($journal->piggybankevents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->sum('amount')); + $event = $journal->piggyBankEvents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->first(); + $eventSum = floatval($journal->piggyBankEvents()->orderBy('date', 'DESC')->orderBy('id', 'DESC')->sum('amount')); /** @var \FireflyIII\Database\PiggyBank\PiggyBank $repository */ $repository = \App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - /** @var \Piggybank $piggyBank */ - $piggyBank = $journal->piggybankevents()->first()->piggybank()->first(); + /** @var \PiggyBank $piggyBank */ + $piggyBank = $journal->piggyBankEvents()->first()->piggyBank()->first(); - /** @var \PiggybankRepetition $repetition */ + /** @var \PiggyBankRepetition $repetition */ $repetition = $repository->findRepetitionByDate($piggyBank, $journal->date); $relevantTransaction = null; @@ -285,7 +282,7 @@ class Piggybank $event = new \PiggyBankEvent; - $event->piggybank()->associate($piggyBank); + $event->piggyBank()->associate($piggyBank); $event->transactionJournal()->associate($journal); $event->amount = $diff; $event->date = new Carbon; diff --git a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php index d3e582f916..f506f81a98 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php @@ -65,16 +65,16 @@ class Reminders public function updateReminders() { /** @var Collection $set */ - $set = \Piggybank::leftJoin('accounts', 'accounts.id', '=', 'piggybanks.account_id') + $set = \PiggyBank::leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') ->where('accounts.user_id', \Auth::user()->id) - ->whereNotNull('reminder')->get(['piggybanks.*']); + ->whereNotNull('reminder')->get(['piggy_banks.*']); $today = Carbon::now(); - /** @var \Piggybank $piggyBank */ + /** @var \PiggyBank $piggyBank */ foreach ($set as $piggyBank) { - /** @var \PiggybankRepetition $repetition */ + /** @var \PiggyBankRepetition $repetition */ $repetition = $piggyBank->currentRelevantRep(); $start = \DateKit::startOfPeriod($today, $piggyBank->reminder); if ($repetition->targetdate && $repetition->targetdate <= $today) { diff --git a/app/lib/FireflyIII/Shared/Toolkit/Steam.php b/app/lib/FireflyIII/Shared/Toolkit/Steam.php index 03d0238e57..275089449a 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Steam.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Steam.php @@ -46,12 +46,12 @@ class Steam } /** - * @param \Piggybank $piggyBank - * @param \PiggybankRepetition $repetition + * @param \PiggyBank $piggyBank + * @param \PiggyBankRepetition $repetition * * @return int */ - public function percentage(\Piggybank $piggyBank, \PiggybankRepetition $repetition) + public function percentage(\PiggyBank $piggyBank, \PiggyBankRepetition $repetition) { $pct = $repetition->currentamount / $piggyBank->targetamount * 100; if ($pct > 100) { diff --git a/app/models/Account.php b/app/models/Account.php index e69680cdf1..b811e3d23e 100644 --- a/app/models/Account.php +++ b/app/models/Account.php @@ -57,9 +57,9 @@ class Account extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ - public function piggybanks() + public function piggyBanks() { - return $this->hasMany('Piggybank'); + return $this->hasMany('PiggyBank'); } /** diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index cb5d420795..75880a15bc 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -4,9 +4,9 @@ use Illuminate\Database\Eloquent\Model as Eloquent; use Watson\Validating\ValidatingTrait; /** - * Class Piggybank + * Class PiggyBank */ -class Piggybank extends Eloquent +class PiggyBank extends Eloquent { use ValidatingTrait; public static $rules @@ -62,12 +62,12 @@ class Piggybank extends Eloquent * @param Carbon $start * @param Carbon $target * - * @return PiggybankRepetition + * @return PiggyBankRepetition */ public function createRepetition(Carbon $start = null, Carbon $target = null) { - $rep = new \PiggybankRepetition; - $rep->piggybank()->associate($this); + $rep = new \PiggyBankRepetition; + $rep->piggyBank()->associate($this); $rep->startdate = $start; $rep->targetdate = $target; $rep->currentamount = 0; @@ -81,7 +81,7 @@ class Piggybank extends Eloquent * * Grabs the PiggyBankRepetition that's currently relevant / active * - * @returns \PiggybankRepetition + * @returns \PiggyBankRepetition */ public function currentRelevantRep() { @@ -89,13 +89,13 @@ class Piggybank extends Eloquent return $this->currentRep; } if ($this->repeats == 0) { - $rep = $this->piggybankrepetitions()->first(['piggybank_repetitions.*']); + $rep = $this->piggyBankRepetitions()->first(['piggy_bank_repetitions.*']); $this->currentRep = $rep; \Log::debug('currentRelevantRep() reports $rep is null: ' . boolstr(is_null($rep))); return $rep; } else { - $query = $this->piggybankrepetitions()->where( + $query = $this->piggyBankRepetitions()->where( function ($q) { $q->where( @@ -126,7 +126,7 @@ class Piggybank extends Eloquent } ) ->orderBy('startdate', 'ASC'); - $result = $query->first(['piggybank_repetitions.*']); + $result = $query->first(['piggy_bank_repetitions.*']); $this->currentRep = $result; \Log::debug('Found relevant rep in currentRelevantRep(): ' . $result->id); @@ -139,9 +139,9 @@ class Piggybank extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ - public function piggybankrepetitions() + public function piggyBankRepetitions() { - return $this->hasMany('PiggybankRepetition'); + return $this->hasMany('PiggyBankRepetition'); } /** @@ -155,9 +155,9 @@ class Piggybank extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ - public function piggybankevents() + public function piggyBankEvents() { - return $this->hasMany('PiggybankEvent'); + return $this->hasMany('PiggyBankEvent'); } /** @@ -175,11 +175,11 @@ class Piggybank extends Eloquent * * @param Carbon $date * - * @returns \PiggybankRepetition + * @returns \PiggyBankRepetition */ public function repetitionForDate(Carbon $date) { - $query = $this->piggybankrepetitions()->where( + $query = $this->piggyBankRepetitions()->where( function ($q) use ($date) { $q->where( diff --git a/app/models/PiggybankEvent.php b/app/models/PiggybankEvent.php index 3ef32f5504..b159ab360b 100644 --- a/app/models/PiggybankEvent.php +++ b/app/models/PiggybankEvent.php @@ -9,7 +9,7 @@ class PiggyBankEvent extends Eloquent public static $rules = [ - 'piggybank_id' => 'required|exists:piggybanks,id', + 'piggy_bank_id' => 'required|exists:piggy_banks,id', 'date' => 'required|date', 'amount' => 'required|numeric' ]; @@ -26,9 +26,9 @@ class PiggyBankEvent extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ - public function piggybank() + public function piggyBank() { - return $this->belongsTo('Piggybank'); + return $this->belongsTo('PiggyBank'); } /** diff --git a/app/models/PiggybankRepetition.php b/app/models/PiggybankRepetition.php index 79a6fc06ce..1b9ca645b0 100644 --- a/app/models/PiggybankRepetition.php +++ b/app/models/PiggybankRepetition.php @@ -4,14 +4,14 @@ use Illuminate\Database\Eloquent\Builder; use Watson\Validating\ValidatingTrait; use \Illuminate\Database\Eloquent\Model as Eloquent; /** - * Class PiggybankRepetition + * Class PiggyBankRepetition */ -class PiggybankRepetition extends Eloquent +class PiggyBankRepetition extends Eloquent { use ValidatingTrait; public static $rules = [ - 'piggybank_id' => 'required|exists:piggybanks,id', + 'piggy_bank_id' => 'required|exists:piggy_banks,id', 'targetdate' => 'date', 'startdate' => 'date', 'currentamount' => 'required|numeric']; @@ -31,7 +31,7 @@ class PiggybankRepetition extends Eloquent */ public function pct() { - $total = $this->piggybank->targetamount; + $total = $this->piggyBank->targetamount; $saved = $this->currentamount; if ($total == 0) { return 0; @@ -44,9 +44,9 @@ class PiggybankRepetition extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ - public function piggybank() + public function piggyBank() { - return $this->belongsTo('Piggybank'); + return $this->belongsTo('PiggyBank'); } /** diff --git a/app/models/Transaction.php b/app/models/Transaction.php index a6596cdea4..136941f0b0 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -13,7 +13,6 @@ class Transaction extends Eloquent use SoftDeletingTrait, ValidatingTrait; public static $rules = ['account_id' => 'numeric|required|exists:accounts,id', - 'piggybank_id' => 'numeric|exists:piggybanks,id', 'transaction_journal_id' => 'numeric|required|exists:transaction_journals,id', 'description' => 'between:1,255', 'amount' => 'required|between:-65536,65536|not_in:0,0.00',]; @@ -31,7 +30,7 @@ class Transaction extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ - public function piggybank() + public function piggyBank() { return $this->belongsTo('Piggybank'); } diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index 60183f51f7..2703bb4fe1 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -77,9 +77,9 @@ class TransactionJournal extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ - public function piggybankevents() + public function piggyBankEvents() { - return $this->hasMany('PiggybankEvent'); + return $this->hasMany('PiggyBankEvent'); } /** diff --git a/app/models/User.php b/app/models/User.php index cef29d346c..e86aa0da0b 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -53,7 +53,7 @@ class User extends Eloquent implements UserInterface, RemindableInterface /** * @return \Illuminate\Database\Eloquent\Relations\HasManyThrough */ - public function piggybanks() + public function piggyBanks() { return $this->hasManyThrough('Piggybank', 'Account'); } diff --git a/app/routes.php b/app/routes.php index 463bd66dd2..cf569382f6 100644 --- a/app/routes.php +++ b/app/routes.php @@ -116,13 +116,13 @@ Route::bind( ); Route::bind( - 'piggybank', function ($value, $route) { + 'piggy_bank', function ($value, $route) { if (Auth::check()) { - return Piggybank:: - where('piggybanks.id', $value) - ->leftJoin('accounts', 'accounts.id', '=', 'piggybanks.account_id') + return PiggyBank:: + where('piggy_banks.id', $value) + ->leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') ->where('accounts.user_id', Auth::user()->id) - ->where('repeats', 0)->first(['piggybanks.*']); + ->where('repeats', 0)->first(['piggy_banks.*']); } return null; @@ -132,11 +132,11 @@ Route::bind( Route::bind( 'repeated', function ($value, $route) { if (Auth::check()) { - return Piggybank:: - where('piggybanks.id', $value) - ->leftJoin('accounts', 'accounts.id', '=', 'piggybanks.account_id') + return PiggyBank:: + where('piggy_banks.id', $value) + ->leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') ->where('accounts.user_id', Auth::user()->id) - ->where('repeats', 1)->first(['piggybanks.*']); + ->where('repeats', 1)->first(['piggy_banks.*']); } return null; @@ -195,7 +195,7 @@ Route::group( Route::get('/chart/reports/income-expenses-sum/{year}', ['uses' => 'GoogleChartController@yearInExpSum']); Route::get('/chart/recurring/{recurring}', ['uses' => 'GoogleChartController@recurringOverview']); Route::get('/chart/budget/{budget}/{limitrepetition}', ['uses' => 'GoogleChartController@budgetLimitSpending']); - Route::get('/chart/piggyhistory/{piggybank}', ['uses' => 'GoogleChartController@piggyBankHistory']); + Route::get('/chart/piggy_history/{piggy_bank}', ['uses' => 'GoogleChartController@piggyBankHistory']); // google chart for components (categories + budgets combined) Route::get('/chart/budget/{budget}/spending/{year}', ['uses' => 'GoogleChartController@budgetsAndSpending']); @@ -215,14 +215,14 @@ Route::group( // piggy bank controller - Route::get('/piggybanks', ['uses' => 'PiggybankController@index', 'as' => 'piggybanks.index']); - Route::get('/piggybanks/add/{piggybank}', ['uses' => 'PiggybankController@add']); # add money - Route::get('/piggybanks/remove/{piggybank}', ['uses' => 'PiggybankController@remove']); #remove money + Route::get('/piggy_banks', ['uses' => 'PiggybankController@index', 'as' => 'piggy_banks.index']); + Route::get('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggybankController@add']); # add money + Route::get('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggybankController@remove']); #remove money - Route::get('/piggybanks/create', ['uses' => 'PiggybankController@create', 'as' => 'piggybanks.create']); - Route::get('/piggybanks/edit/{piggybank}', ['uses' => 'PiggybankController@edit', 'as' => 'piggybanks.edit']); - Route::get('/piggybanks/delete/{piggybank}', ['uses' => 'PiggybankController@delete', 'as' => 'piggybanks.delete']); - Route::get('/piggybanks/show/{piggybank}', ['uses' => 'PiggybankController@show', 'as' => 'piggybanks.show']); + Route::get('/piggy_banks/create', ['uses' => 'PiggybankController@create', 'as' => 'piggy_banks.create']); + Route::get('/piggy_banks/edit/{piggy_bank}', ['uses' => 'PiggybankController@edit', 'as' => 'piggy_banks.edit']); + Route::get('/piggy_banks/delete/{piggy_bank}', ['uses' => 'PiggybankController@delete', 'as' => 'piggy_banks.delete']); + Route::get('/piggy_banks/show/{piggy_bank}', ['uses' => 'PiggybankController@show', 'as' => 'piggy_banks.show']); // preferences controller Route::get('/preferences', ['uses' => 'PreferencesController@index', 'as' => 'preferences']); @@ -308,11 +308,11 @@ Route::group( Route::post('/currency/destroy/{currency}', ['uses' => 'CurrencyController@destroy', 'as' => 'currency.destroy']); // piggy bank controller - Route::post('/piggybanks/store', ['uses' => 'PiggybankController@store', 'as' => 'piggybanks.store']); - Route::post('/piggybanks/update/{piggybank}', ['uses' => 'PiggybankController@update', 'as' => 'piggybanks.update']); - Route::post('/piggybanks/destroy/{piggybank}', ['uses' => 'PiggybankController@destroy', 'as' => 'piggybanks.destroy']); - Route::post('/piggybanks/add/{piggybank}', ['uses' => 'PiggybankController@postAdd', 'as' => 'piggybanks.add']); # add money - Route::post('/piggybanks/remove/{piggybank}', ['uses' => 'PiggybankController@postRemove', 'as' => 'piggybanks.remove']); # remove money. + Route::post('/piggy_banks/store', ['uses' => 'PiggybankController@store', 'as' => 'piggy_banks.store']); + Route::post('/piggy_banks/update/{piggy_bank}', ['uses' => 'PiggybankController@update', 'as' => 'piggy_banks.update']); + Route::post('/piggy_banks/destroy/{piggy_bank}', ['uses' => 'PiggybankController@destroy', 'as' => 'piggy_banks.destroy']); + Route::post('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggybankController@postAdd', 'as' => 'piggy_banks.add']); # add money + Route::post('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggybankController@postRemove', 'as' => 'piggy_banks.remove']); # remove money. // repeated expense controller Route::post('/repeatedexpense/store', ['uses' => 'RepeatedExpenseController@store', 'as' => 'repeated.store']); diff --git a/app/tests/PiggybankPartTest.php b/app/tests/PiggybankPartTest.php index 8e98c22a18..5e98b7f5e4 100644 --- a/app/tests/PiggybankPartTest.php +++ b/app/tests/PiggybankPartTest.php @@ -1,12 +1,12 @@ object = new PiggybankPart; + $this->object = new PiggyBankPart; } /** @@ -28,7 +28,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getReminder + * @covers FireflyIII\Collection\PiggyBankPart::getReminder * @todo Implement testGetReminder(). */ public function testGetReminder() @@ -41,7 +41,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setReminder + * @covers FireflyIII\Collection\PiggyBankPart::setReminder * @todo Implement testSetReminder(). */ public function testSetReminder() @@ -53,7 +53,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getStartdate + * @covers FireflyIII\Collection\PiggyBankPart::getStartdate * @todo Implement testGetStartdate(). */ public function testGetStartdate() @@ -65,7 +65,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setStartdate + * @covers FireflyIII\Collection\PiggyBankPart::setStartdate * @todo Implement testSetStartdate(). */ public function testSetStartdate() @@ -77,7 +77,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getTargetdate + * @covers FireflyIII\Collection\PiggyBankPart::getTargetdate * @todo Implement testGetTargetdate(). */ public function testGetTargetdate() @@ -89,7 +89,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setTargetdate + * @covers FireflyIII\Collection\PiggyBankPart::setTargetdate * @todo Implement testSetTargetdate(). */ public function testSetTargetdate() @@ -101,7 +101,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getRepetition + * @covers FireflyIII\Collection\PiggyBankPart::getRepetition * @todo Implement testGetRepetition(). */ public function testGetRepetition() @@ -113,7 +113,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setRepetition + * @covers FireflyIII\Collection\PiggyBankPart::setRepetition * @todo Implement testSetRepetition(). */ public function testSetRepetition() @@ -125,7 +125,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::hasReminder + * @covers FireflyIII\Collection\PiggyBankPart::hasReminder * @todo Implement testHasReminder(). */ public function testHasReminder() @@ -137,7 +137,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::percentage + * @covers FireflyIII\Collection\PiggyBankPart::percentage * @todo Implement testPercentage(). */ public function testPercentage() @@ -149,7 +149,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getCurrentamount + * @covers FireflyIII\Collection\PiggyBankPart::getCurrentamount * @todo Implement testGetCurrentamount(). */ public function testGetCurrentamount() @@ -161,7 +161,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setCurrentamount + * @covers FireflyIII\Collection\PiggyBankPart::setCurrentamount * @todo Implement testSetCurrentamount(). */ public function testSetCurrentamount() @@ -173,7 +173,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getCumulativeAmount + * @covers FireflyIII\Collection\PiggyBankPart::getCumulativeAmount * @todo Implement testGetCumulativeAmount(). */ public function testGetCumulativeAmount() @@ -185,7 +185,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setCumulativeAmount + * @covers FireflyIII\Collection\PiggyBankPart::setCumulativeAmount * @todo Implement testSetCumulativeAmount(). */ public function testSetCumulativeAmount() @@ -197,7 +197,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::getAmountPerBar + * @covers FireflyIII\Collection\PiggyBankPart::getAmountPerBar * @todo Implement testGetAmountPerBar(). */ public function testGetAmountPerBar() @@ -209,7 +209,7 @@ class PiggybankPartTest extends \PHPUnit_Framework_TestCase } /** - * @covers FireflyIII\Collection\PiggybankPart::setAmountPerBar + * @covers FireflyIII\Collection\PiggyBankPart::setAmountPerBar * @todo Implement testSetAmountPerBar(). */ public function testSetAmountPerBar() diff --git a/app/views/list/piggybank-events.blade.php b/app/views/list/piggybank-events.blade.php index e80ddc4c61..9dad0362c7 100644 --- a/app/views/list/piggybank-events.blade.php +++ b/app/views/list/piggybank-events.blade.php @@ -1,6 +1,6 @@
Account{{{$piggybank->account->name}}}{{{$piggyBank->account->name}}}
Target amount{{mf($piggybank->targetamount)}}{{mf($piggyBank->targetamount)}}
Saved so far{{mf($piggybank->currentRelevantRep()->currentamount)}}{{mf($piggyBank->currentRelevantRep()->currentamount)}}
Left to save{{mf($piggybank->targetamount-$piggybank->currentRelevantRep()->currentamount)}}{{mf($piggyBank->targetamount-$piggyBank->currentRelevantRep()->currentamount)}}
Start date - @if(is_null($piggybank->startdate)) + @if(is_null($piggyBank->startdate)) No start date @endif - @if(is_object($piggybank->startdate)) - {{$piggybank->startdate->format('jS F Y')}} + @if(is_object($piggyBank->startdate)) + {{$piggyBank->startdate->format('jS F Y')}} @endif
Target date - @if(is_null($piggybank->targetdate)) + @if(is_null($piggyBank->targetdate)) No target date @endif - @if(is_object($piggybank->targetdate)) - {{$piggybank->targetdate->format('jS F Y')}} + @if(is_object($piggyBank->targetdate)) + {{$piggyBank->targetdate->format('jS F Y')}} @endif
Reminder - @if(intval($piggybank->remind_me) == 0) + @if(intval($piggyBank->remind_me) == 0) (no reminder) @else Every - @if($piggybank->reminder_skip != 0) - {{$piggybank->reminder_skip}} + @if($piggyBank->reminder_skip != 0) + {{$piggyBank->reminder_skip}} @endif - {{$piggybank->reminder}}(s) + {{$piggyBank->reminder}}(s) @endif
- @if(isset($showPiggybank) && $showPiggybank === true) + @if(isset($showPiggyBank) && $showPiggyBank === true) @endif @@ -8,9 +8,9 @@ @foreach($events as $event) - @if(isset($showPiggybank) && $showPiggybank === true) + @if(isset($showPiggyBank) && $showPiggyBank === true) @endif - + diff --git a/app/views/preferences/index.blade.php b/app/views/preferences/index.blade.php index 9dad68c853..0a3816f684 100644 --- a/app/views/preferences/index.blade.php +++ b/app/views/preferences/index.blade.php @@ -17,10 +17,10 @@
From 8ef659f5de85db8ee2172fd023a3468a09cf32ad Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 22:39:23 +0100 Subject: [PATCH 07/84] Tests for preferences controller. --- app/routes.php | 24 +++++------ app/views/preferences/index.blade.php | 2 +- composer.lock | 12 +++--- .../functional/PreferencesControllerCest.php | 41 +++++++++++++++++++ 4 files changed, 60 insertions(+), 19 deletions(-) create mode 100644 tests/functional/PreferencesControllerCest.php diff --git a/app/routes.php b/app/routes.php index cf569382f6..7288405638 100644 --- a/app/routes.php +++ b/app/routes.php @@ -215,14 +215,14 @@ Route::group( // piggy bank controller - Route::get('/piggy_banks', ['uses' => 'PiggybankController@index', 'as' => 'piggy_banks.index']); - Route::get('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggybankController@add']); # add money - Route::get('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggybankController@remove']); #remove money + Route::get('/piggy_banks', ['uses' => 'PiggyBankController@index', 'as' => 'piggy_banks.index']); + Route::get('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggyBankController@add']); # add money + Route::get('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggyBankController@remove']); #remove money - Route::get('/piggy_banks/create', ['uses' => 'PiggybankController@create', 'as' => 'piggy_banks.create']); - Route::get('/piggy_banks/edit/{piggy_bank}', ['uses' => 'PiggybankController@edit', 'as' => 'piggy_banks.edit']); - Route::get('/piggy_banks/delete/{piggy_bank}', ['uses' => 'PiggybankController@delete', 'as' => 'piggy_banks.delete']); - Route::get('/piggy_banks/show/{piggy_bank}', ['uses' => 'PiggybankController@show', 'as' => 'piggy_banks.show']); + Route::get('/piggy_banks/create', ['uses' => 'PiggyBankController@create', 'as' => 'piggy_banks.create']); + Route::get('/piggy_banks/edit/{piggy_bank}', ['uses' => 'PiggyBankController@edit', 'as' => 'piggy_banks.edit']); + Route::get('/piggy_banks/delete/{piggy_bank}', ['uses' => 'PiggyBankController@delete', 'as' => 'piggy_banks.delete']); + Route::get('/piggy_banks/show/{piggy_bank}', ['uses' => 'PiggyBankController@show', 'as' => 'piggy_banks.show']); // preferences controller Route::get('/preferences', ['uses' => 'PreferencesController@index', 'as' => 'preferences']); @@ -308,11 +308,11 @@ Route::group( Route::post('/currency/destroy/{currency}', ['uses' => 'CurrencyController@destroy', 'as' => 'currency.destroy']); // piggy bank controller - Route::post('/piggy_banks/store', ['uses' => 'PiggybankController@store', 'as' => 'piggy_banks.store']); - Route::post('/piggy_banks/update/{piggy_bank}', ['uses' => 'PiggybankController@update', 'as' => 'piggy_banks.update']); - Route::post('/piggy_banks/destroy/{piggy_bank}', ['uses' => 'PiggybankController@destroy', 'as' => 'piggy_banks.destroy']); - Route::post('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggybankController@postAdd', 'as' => 'piggy_banks.add']); # add money - Route::post('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggybankController@postRemove', 'as' => 'piggy_banks.remove']); # remove money. + Route::post('/piggy_banks/store', ['uses' => 'PiggyBankController@store', 'as' => 'piggy_banks.store']); + Route::post('/piggy_banks/update/{piggy_bank}', ['uses' => 'PiggyBankController@update', 'as' => 'piggy_banks.update']); + Route::post('/piggy_banks/destroy/{piggy_bank}', ['uses' => 'PiggyBankController@destroy', 'as' => 'piggy_banks.destroy']); + Route::post('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggyBankController@postAdd', 'as' => 'piggy_banks.add']); # add money + Route::post('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggyBankController@postRemove', 'as' => 'piggy_banks.remove']); # remove money. // repeated expense controller Route::post('/repeatedexpense/store', ['uses' => 'RepeatedExpenseController@store', 'as' => 'repeated.store']); diff --git a/app/views/preferences/index.blade.php b/app/views/preferences/index.blade.php index 0a3816f684..d57aa6636b 100644 --- a/app/views/preferences/index.blade.php +++ b/app/views/preferences/index.blade.php @@ -2,7 +2,7 @@ @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} -{{Form::open(['class' => 'form-horizontal'])}} +{{Form::open(['class' => 'form-horizontal','id' => 'preferences'])}}
diff --git a/composer.lock b/composer.lock index 20676b73a9..07850e0b5c 100644 --- a/composer.lock +++ b/composer.lock @@ -1825,21 +1825,21 @@ "packages-dev": [ { "name": "barryvdh/laravel-debugbar", - "version": "v1.8.4", + "version": "v1.8.5", "source": { "type": "git", "url": "https://github.com/barryvdh/laravel-debugbar.git", - "reference": "410e98739c58ccd1b9ad2f49afd77a8d40144515" + "reference": "548e12d45760ee66192029f4b642d2f4e3d64118" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/barryvdh/laravel-debugbar/zipball/410e98739c58ccd1b9ad2f49afd77a8d40144515", - "reference": "410e98739c58ccd1b9ad2f49afd77a8d40144515", + "url": "https://api.github.com/repos/barryvdh/laravel-debugbar/zipball/548e12d45760ee66192029f4b642d2f4e3d64118", + "reference": "548e12d45760ee66192029f4b642d2f4e3d64118", "shasum": "" }, "require": { "laravel/framework": "4.*|5.0.*", - "maximebf/debugbar": "~1.10.1", + "maximebf/debugbar": "~1.10.2", "php": ">=5.3.0", "symfony/finder": "~2.3" }, @@ -1875,7 +1875,7 @@ "profiler", "webprofiler" ], - "time": "2014-12-04 12:14:32" + "time": "2014-12-24 08:00:07" }, { "name": "barryvdh/laravel-ide-helper", diff --git a/tests/functional/PreferencesControllerCest.php b/tests/functional/PreferencesControllerCest.php new file mode 100644 index 0000000000..680ca70a49 --- /dev/null +++ b/tests/functional/PreferencesControllerCest.php @@ -0,0 +1,41 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + /** + * @param FunctionalTester $I + */ + public function index(FunctionalTester $I) + { + $I->wantTo('see my current set of preferences'); + $I->amOnPage('/preferences'); + $I->see('Preferences'); + } + + /** + * @param FunctionalTester $I + */ + public function postIndex(FunctionalTester $I) + { + $I->wantTo('want to update my preferences'); + $I->amOnPage('/preferences'); + $I->see('Preferences'); + $I->submitForm('#preferences', []); + $I->see('Preferences saved!'); + } +} \ No newline at end of file From 18c1223c7b3234296a8265af1372232ed71ea9eb Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 22:52:14 +0100 Subject: [PATCH 08/84] Tests for the profile controller --- app/views/profile/change-password.blade.php | 2 +- tests/functional/ProfileControllerCest.php | 147 ++++++++++++++++++++ 2 files changed, 148 insertions(+), 1 deletion(-) create mode 100644 tests/functional/ProfileControllerCest.php diff --git a/app/views/profile/change-password.blade.php b/app/views/profile/change-password.blade.php index ebc77df432..8cbcc0f8f9 100644 --- a/app/views/profile/change-password.blade.php +++ b/app/views/profile/change-password.blade.php @@ -8,7 +8,7 @@ Change your password
- {{Form::open(['class' => 'form-horizontal'])}} + {{Form::open(['class' => 'form-horizontal','id' => 'change-password'])}}
diff --git a/tests/functional/ProfileControllerCest.php b/tests/functional/ProfileControllerCest.php new file mode 100644 index 0000000000..fd7e1a53a6 --- /dev/null +++ b/tests/functional/ProfileControllerCest.php @@ -0,0 +1,147 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + /** + * @param FunctionalTester $I + */ + public function changePassword(FunctionalTester $I) + { + $I->wantTo('change my password.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + } + + /** + * @param FunctionalTester $I + */ + public function index(FunctionalTester $I) + { + $I->wantTo('see my profile options'); + $I->amOnPage('/profile'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Profile'); + } + + /** + * @param FunctionalTester $I + */ + public function postChangePassword(FunctionalTester $I) + { + $I->wantTo('submit a new password.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + $I->submitForm( + '#change-password', [ + 'old' => 'james', + 'new1' => 'James', + 'new2' => 'James' + ] + ); + $I->see('Password changed!'); + } + + /** + * @param FunctionalTester $I + */ + public function postChangePasswordInvalidCurrent(FunctionalTester $I) + { + $I->wantTo('submit a new password and enter the wrong current password.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + + $I->submitForm( + '#change-password', [ + 'old' => 'Blablabla', + 'new1' => 'James', + 'new2' => 'James' + ] + ); + $I->see('Invalid current password!'); + } + + /** + * @param FunctionalTester $I + */ + public function postChangePasswordNoNewPassword(FunctionalTester $I) + { + $I->wantTo('submit a new password and forget to fill in a new one.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + + $I->submitForm( + '#change-password', [ + 'old' => 'james', + 'new1' => '', + 'new2' => '' + ] + ); + $I->see('Do fill in a password!'); + + } + + /** + * @param FunctionalTester $I + */ + public function postChangePasswordToSame(FunctionalTester $I) + { + $I->wantTo('submit a new password but fill in my old one twice.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + + $I->submitForm( + '#change-password', [ + 'old' => 'james', + 'new1' => 'james', + 'new2' => 'james' + ] + ); + $I->see('The idea is to change your password.'); + } + + /** + * @param FunctionalTester $I + */ + public function postChangePasswordNoMatch(FunctionalTester $I) + { + $I->wantTo('submit a new password but make a mistake in filling it in twice.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + + $I->submitForm( + '#change-password', [ + 'old' => 'james', + 'new1' => 'blabla', + 'new2' => 'bla' + ] + ); + $I->see('New passwords do not match!'); + } + + +} \ No newline at end of file From ce27e97b92599560755e2ecef77f9ec2f34a7c54 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 25 Dec 2014 00:42:31 +0100 Subject: [PATCH 09/84] More tests! Yay! --- app/controllers/RecurringController.php | 154 ++++++++---------- app/database/seeds/TestContentSeeder.php | 2 +- .../Database/PiggyBank/PiggyBank.php | 1 + app/views/recurring/create.blade.php | 2 +- app/views/recurring/delete.blade.php | 2 +- app/views/recurring/edit.blade.php | 2 +- tests/functional/PiggyBankControllerCest.php | 30 ++-- tests/functional/RecurringControllerCest.php | 123 ++++++++++++++ 8 files changed, 208 insertions(+), 108 deletions(-) create mode 100644 tests/functional/RecurringControllerCest.php diff --git a/app/controllers/RecurringController.php b/app/controllers/RecurringController.php index 84be23917a..d3a730a5c9 100644 --- a/app/controllers/RecurringController.php +++ b/app/controllers/RecurringController.php @@ -1,6 +1,6 @@ _repository = $repository; View::share('title', 'Recurring transactions'); View::share('mainTitleIcon', 'fa-rotate-right'); @@ -47,17 +52,8 @@ class RecurringController extends BaseController */ public function destroy(RecurringTransaction $recurringTransaction) { - //Event::fire('recurring.destroy', [$recurringTransaction]); - - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repository */ - $repository = App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); - - $result = $repository->destroy($recurringTransaction); - if ($result === true) { - Session::flash('success', 'The recurring transaction was deleted.'); - } else { - Session::flash('error', 'Could not delete the recurring transaction. Check the logs to be sure.'); - } + $this->_repository->destroy($recurringTransaction); + Session::flash('success', 'The recurring transaction was deleted.'); return Redirect::route('recurring.index'); @@ -82,10 +78,7 @@ class RecurringController extends BaseController */ public function index() { - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repos */ - $repos = App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); - - $recurring = $repos->get(); + $recurring = $this->_repository->get(); return View::make('recurring.index', compact('recurring')); } @@ -100,16 +93,14 @@ class RecurringController extends BaseController if (intval($recurringTransaction->active) == 0) { Session::flash('warning', 'Inactive recurring transactions cannot be scanned.'); - return Redirect::back(); + return Redirect::intended('/'); } - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repos */ - $repos = App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); - $repos->scanEverything($recurringTransaction); + $this->_repository->scanEverything($recurringTransaction); Session::flash('success', 'Rescanned everything.'); - return Redirect::back(); + return Redirect::intended('/'); } /** @@ -134,45 +125,35 @@ class RecurringController extends BaseController */ public function store() { - $data = Input::except('_token'); - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repos */ - $repos = App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); + $data = Input::all(); + $data['user_id'] = Auth::user()->id; - switch ($data['post_submit_action']) { - default: - throw new FireflyException('Cannot handle post_submit_action "' . e($data['post_submit_action']) . '"'); - break; - case 'create_another': - case 'store': - $messages = $repos->validate($data); - /** @var MessageBag $messages ['errors'] */ - if ($messages['errors']->count() > 0) { - Session::flash('warnings', $messages['warnings']); - Session::flash('successes', $messages['successes']); - Session::flash('error', 'Could not save recurring transaction: ' . $messages['errors']->first()); - return Redirect::route('recurring.create')->withInput()->withErrors($messages['errors']); - } - // store! - $repos->store($data); - Session::flash('success', 'New recurring transaction stored!'); + // always validate: + $messages = $this->_repository->validate($data); - if ($data['post_submit_action'] == 'create_another') { - return Redirect::route('recurring.create')->withInput(); - } else { - return Redirect::route('recurring.index'); - } - break; - case 'validate_only': - $messageBags = $repos->validate($data); - Session::flash('warnings', $messageBags['warnings']); - Session::flash('successes', $messageBags['successes']); - Session::flash('errors', $messageBags['errors']); - - return Redirect::route('recurring.create')->withInput(); - break; + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not store recurring transaction: ' . $messages['errors']->first()); } + // return to create screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('recurring.create')->withInput(); + } + + // store: + $this->_repository->store($data); + Session::flash('success', 'Recurring transaction "' . e($data['name']) . '" stored.'); + if ($data['post_submit_action'] == 'store') { + return Redirect::route('recurring.index'); + } + + return Redirect::route('recurring.create')->withInput(); + } /** @@ -183,45 +164,38 @@ class RecurringController extends BaseController */ public function update(RecurringTransaction $recurringTransaction) { - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repos */ - $repos = App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); $data = Input::except('_token'); $data['active'] = isset($data['active']) ? 1 : 0; $data['automatch'] = isset($data['automatch']) ? 1 : 0; + $data['user_id'] = Auth::user()->id; - switch (Input::get('post_submit_action')) { - default: - throw new FireflyException('Cannot handle post_submit_action "' . e(Input::get('post_submit_action')) . '"'); - break; - case 'create_another': - case 'update': - $messages = $repos->validate($data); - /** @var MessageBag $messages ['errors'] */ - if ($messages['errors']->count() > 0) { - Session::flash('warnings', $messages['warnings']); - Session::flash('successes', $messages['successes']); - Session::flash('error', 'Could not save recurring transaction: ' . $messages['errors']->first()); + // always validate: + $messages = $this->_repository->validate($data); - return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput()->withErrors($messages['errors']); - } - // store! - $repos->update($recurringTransaction, $data); - Session::flash('success', 'Recurring transaction updated!'); - - if ($data['post_submit_action'] == 'create_another') { - return Redirect::route('recurring.edit', $recurringTransaction->id); - } else { - return Redirect::route('recurring.index'); - } - case 'validate_only': - $messageBags = $repos->validate($data); - Session::flash('warnings', $messageBags['warnings']); - Session::flash('successes', $messageBags['successes']); - Session::flash('errors', $messageBags['errors']); - - return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput(); - break; + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not update recurring transaction: ' . $messages['errors']->first()); } + // return to update screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput(); + } + + // update + $this->_repository->update($recurringTransaction, $data); + Session::flash('success', 'Recurring transaction "' . e($data['name']) . '" updated.'); + + // go back to list + if ($data['post_submit_action'] == 'update') { + return Redirect::route('recurring.index'); + } + + // go back to update screen. + return Redirect::route('piggy_banks.edit', $recurringTransaction->id)->withInput(['post_submit_action' => 'return_to_edit']); + } } \ No newline at end of file diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index a6aba6edbf..93e5fee98e 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -160,7 +160,7 @@ class TestContentSeeder extends Seeder 'amount_min' => 500, 'amount_max' => 700, 'date' => '2014-01-12', - 'active' => 1, + 'active' => 0, 'automatch' => 1, 'repeat_freq' => 'monthly', 'skip' => 0, diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index 289810fb34..796aa17272 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -36,6 +36,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface public function destroy(Eloquent $model) { $model->delete(); + } /** diff --git a/app/views/recurring/create.blade.php b/app/views/recurring/create.blade.php index ef42865842..a14eaf114d 100644 --- a/app/views/recurring/create.blade.php +++ b/app/views/recurring/create.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} -{{Form::open(['class' => 'form-horizontal','url' => route('recurring.store')])}} +{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('recurring.store')])}}
diff --git a/app/views/recurring/delete.blade.php b/app/views/recurring/delete.blade.php index a2013a65e4..261d505d12 100644 --- a/app/views/recurring/delete.blade.php +++ b/app/views/recurring/delete.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $recurringTransaction) }} -{{Form::open(['class' => 'form-horizontal','url' => route('recurring.destroy',$recurringTransaction->id)])}} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('recurring.destroy',$recurringTransaction->id)])}}
diff --git a/app/views/recurring/edit.blade.php b/app/views/recurring/edit.blade.php index d7bf99bc25..5824b10655 100644 --- a/app/views/recurring/edit.blade.php +++ b/app/views/recurring/edit.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $recurringTransaction) }} -{{Form::model($recurringTransaction, ['class' => 'form-horizontal','url' => route('recurring.update', $recurringTransaction->id)])}} +{{Form::model($recurringTransaction, ['class' => 'form-horizontal','id' => 'update','url' => route('recurring.update', $recurringTransaction->id)])}}
diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index c86b35f53a..c47862c21a 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -52,6 +52,7 @@ class PiggyBankControllerCest $I->wantTo('delete a piggy bank'); $I->amOnPage('/piggy_banks/delete/1'); $I->see('Delete "New camera"'); + } /** @@ -64,6 +65,7 @@ class PiggyBankControllerCest $I->see('Delete "New camera"'); $I->submitForm('#destroy', []); $I->see('Piggy bank "New camera" deleted.'); + } /** @@ -242,13 +244,13 @@ class PiggyBankControllerCest $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ - 'name' => 'Updated camera', - 'account_id' => 2, - 'targetamount' => 2000, - 'targetdate' => '', - 'reminder' => 'week', - 'post_submit_action' => 'update', - ] + 'name' => 'Updated camera', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'update', + ] ); $I->see('Piggy bank "Updated camera" updated.'); @@ -311,13 +313,13 @@ class PiggyBankControllerCest $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ - 'name' => '', - 'account_id' => 2, - 'targetamount' => 2000, - 'targetdate' => '', - 'reminder' => 'week', - 'post_submit_action' => 'update', - ] + 'name' => '', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'update', + ] ); $I->see('Name is too short'); $I->seeInDatabase('piggy_banks', ['name' => 'New camera']); diff --git a/tests/functional/RecurringControllerCest.php b/tests/functional/RecurringControllerCest.php new file mode 100644 index 0000000000..e2b296d679 --- /dev/null +++ b/tests/functional/RecurringControllerCest.php @@ -0,0 +1,123 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + /** + * @param FunctionalTester $I + */ + public function create(FunctionalTester $I) + { + $I->wantTo('create a recurring transaction'); + $I->amOnPage('/recurring/create'); + } + + /** + * @param FunctionalTester $I + */ + public function delete(FunctionalTester $I) + { + $I->wantTo('delete a recurring transaction'); + $I->amOnPage('/recurring/delete/1'); + $I->see('Delete "Huur"'); + } + + /** + * @param FunctionalTester $I + */ + public function destroy(FunctionalTester $I) + { + $I->wantTo('destroy a recurring transaction'); + $I->amOnPage('/recurring/delete/1'); + $I->see('Delete "Huur"'); + $I->submitForm('#destroy', []); + $I->see('The recurring transaction was deleted.'); + + } + + /** + * @param FunctionalTester $I + */ + public function edit(FunctionalTester $I) + { + $I->wantTo('edit a recurring transaction'); + $I->amOnPage('/recurring/edit/1'); + + + } + + /** + * @param FunctionalTester $I + */ + public function index(FunctionalTester $I) + { + $I->wantTo('see all recurring transactions'); + $I->amOnPage('/recurring'); + } + + /** + * @param FunctionalTester $I + */ + public function rescan(FunctionalTester $I) + { + $I->wantTo('rescan a recurring transaction'); + $I->amOnPage('/recurring/rescan/1'); + $I->see('Rescanned everything.'); + } + + /** + * @param FunctionalTester $I + */ + public function rescanInactive(FunctionalTester $I) + { + $I->wantTo('rescan an inactive recurring transaction'); + $I->amOnPage('/recurring/rescan/2'); + $I->see('Inactive recurring transactions cannot be scanned.'); + } + + /** + * @param FunctionalTester $I + */ + public function show(FunctionalTester $I) + { + $I->wantTo('show a recurring transaction'); + $I->amOnPage('/recurring/show/1'); + } + + /** + * @param FunctionalTester $I + */ + public function store(FunctionalTester $I) + { + $I->wantTo('store a recurring transaction'); + $I->amOnPage('/recurring/create'); + } + + /** + * @param FunctionalTester $I + */ + public function update(FunctionalTester $I) + { + $I->wantTo('update a recurring transaction'); + $I->amOnPage('/recurring/edit/1'); + } + +} \ No newline at end of file From 230bd6e40ad0aaa2fae5303ef933ba0d80b20cf7 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 25 Dec 2014 08:00:09 +0100 Subject: [PATCH 10/84] Tests for the recurring transaction controller. --- app/controllers/RecurringController.php | 2 +- tests/functional/PiggyBankControllerCest.php | 7 +- tests/functional/RecurringControllerCest.php | 134 +++++++++++++++++++ 3 files changed, 140 insertions(+), 3 deletions(-) diff --git a/app/controllers/RecurringController.php b/app/controllers/RecurringController.php index d3a730a5c9..01bb85db08 100644 --- a/app/controllers/RecurringController.php +++ b/app/controllers/RecurringController.php @@ -195,7 +195,7 @@ class RecurringController extends BaseController } // go back to update screen. - return Redirect::route('piggy_banks.edit', $recurringTransaction->id)->withInput(['post_submit_action' => 'return_to_edit']); + return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput(['post_submit_action' => 'return_to_edit']); } } \ No newline at end of file diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index c47862c21a..b657ff6f14 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -210,7 +210,8 @@ class PiggyBankControllerCest 'post_submit_action' => 'create_another', 'remind_me' => 0, 'order' => 3, - 'account_id' => 1, 'targetamount' => 1000] + 'account_id' => 1, + 'targetamount' => 1000] ); $I->see('Piggy bank "Some new piggy bank" stored.'); } @@ -229,7 +230,9 @@ class PiggyBankControllerCest 'reminder_skip' => 0, 'remind_me' => 0, 'order' => 3, - 'account_id' => 1, 'targetamount' => 1000] + 'account_id' => 1, + 'post_submit_action' => 'store', + 'targetamount' => 1000] ); $I->see('Name is too short'); } diff --git a/tests/functional/RecurringControllerCest.php b/tests/functional/RecurringControllerCest.php index e2b296d679..54a5524dc8 100644 --- a/tests/functional/RecurringControllerCest.php +++ b/tests/functional/RecurringControllerCest.php @@ -100,6 +100,7 @@ class RecurringControllerCest { $I->wantTo('show a recurring transaction'); $I->amOnPage('/recurring/show/1'); + $I->see('Huur'); } /** @@ -109,6 +110,84 @@ class RecurringControllerCest { $I->wantTo('store a recurring transaction'); $I->amOnPage('/recurring/create'); + $I->submitForm( + '#store', [ + 'name' => 'Some recurring', + 'match' => 'one,two', + 'amount_min' => 10, + 'amount_max' => 20, + 'post_submit_action' => 'store', + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->see('Recurring transaction "Some recurring" stored.'); + } + + /** + * @param FunctionalTester $I + */ + public function storeFail(FunctionalTester $I) + { + $I->wantTo('store a recurring transaction and fail'); + $I->amOnPage('/recurring/create'); + $I->submitForm( + '#store', [ + 'name' => 'Some recurring', + 'match' => '', + 'amount_min' => 10, + 'amount_max' => 20, + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->dontSeeInDatabase('recurring_transactions', ['name' => 'Some recurring']); + $I->see('Could not store recurring transaction'); + } + + public function storeRecreate(FunctionalTester $I) + { + $I->wantTo('validate a recurring transaction and create another one'); + $I->amOnPage('/recurring/create'); + $I->submitForm( + '#store', [ + 'name' => 'Some recurring', + 'match' => 'one,two', + 'amount_min' => 10, + 'amount_max' => 20, + 'post_submit_action' => 'create_another', + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0, + + ] + ); + $I->see('Recurring transaction "Some recurring" stored.'); + } + + /** + * @param FunctionalTester $I + */ + public function storeValidate(FunctionalTester $I) + { + $I->wantTo('validate a recurring transaction'); + $I->amOnPage('/recurring/create'); + $I->submitForm( + '#store', [ + 'name' => 'Some recurring', + 'match' => 'one,two', + 'amount_min' => 10, + 'amount_max' => 20, + 'post_submit_action' => 'validate_only', + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0, + + ] + ); + $I->see('form-group has-success has-feedback'); } /** @@ -118,6 +197,61 @@ class RecurringControllerCest { $I->wantTo('update a recurring transaction'); $I->amOnPage('/recurring/edit/1'); + $I->submitForm( + '#update', [ + 'name' => 'Some recurring', + 'match' => 'bla,bla', + 'amount_min' => 10, + 'amount_max' => 20, + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->see('Recurring transaction "Some recurring" updated.'); + } + + /** + * @param FunctionalTester $I + */ + public function updateReturn(FunctionalTester $I) + { + $I->wantTo('update a recurring transaction and return to edit it'); + $I->amOnPage('/recurring/edit/1'); + $I->submitForm( + '#update', [ + 'name' => 'Some recurring', + 'match' => 'bla,bla', + 'amount_min' => 10, + 'amount_max' => 20, + 'post_submit_action' => 'return_to_edit', + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->see('Recurring transaction "Some recurring" updated.'); + } + + /** + * @param FunctionalTester $I + */ + public function updateFail(FunctionalTester $I) + { + $I->wantTo('update a recurring transaction and fail'); + $I->amOnPage('/recurring/edit/1'); + $I->submitForm( + '#update', [ + 'name' => 'Some recurring', + 'match' => '', + 'amount_min' => 10, + 'amount_max' => 20, + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->see('Could not update recurring transaction'); } } \ No newline at end of file From 1659904f81548c60edab5a135cd817e6f5bc5974 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 25 Dec 2014 08:07:17 +0100 Subject: [PATCH 11/84] Various cleanup and spelling fixes. --- app/controllers/CurrencyController.php | 18 ++++++++++++++++++ app/controllers/GoogleChartController.php | 14 +++++++------- app/controllers/HomeController.php | 12 ++++++------ app/controllers/PiggybankController.php | 12 ++++++------ app/controllers/ProfileController.php | 2 ++ app/controllers/RecurringController.php | 6 +++++- app/lib/FireflyIII/Shared/Toolkit/Form.php | 7 +++---- 7 files changed, 47 insertions(+), 24 deletions(-) diff --git a/app/controllers/CurrencyController.php b/app/controllers/CurrencyController.php index bc2ae575ea..9daadad525 100644 --- a/app/controllers/CurrencyController.php +++ b/app/controllers/CurrencyController.php @@ -61,6 +61,8 @@ class CurrencyController extends BaseController /** * @param TransactionCurrency $currency + * + * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View */ public function delete(TransactionCurrency $currency) { @@ -74,6 +76,11 @@ class CurrencyController extends BaseController return View::make('currency.delete', compact('currency')); } + /** + * @param TransactionCurrency $currency + * + * @return \Illuminate\Http\RedirectResponse + */ public function destroy(TransactionCurrency $currency) { Session::flash('success', 'Currency "' . e($currency->name) . '" deleted'); @@ -98,6 +105,9 @@ class CurrencyController extends BaseController } + /** + * @return \Illuminate\View\View + */ public function index() { $currencies = $this->_repository->get(); @@ -112,6 +122,9 @@ class CurrencyController extends BaseController return View::make('currency.index', compact('currencies', 'defaultCurrency')); } + /** + * @return $this|\Illuminate\Http\RedirectResponse + */ public function store() { $data = Input::except('_token'); @@ -143,6 +156,11 @@ class CurrencyController extends BaseController } + /** + * @param TransactionCurrency $currency + * + * @return $this|\Illuminate\Http\RedirectResponse + */ public function update(TransactionCurrency $currency) { $data = Input::except('_token'); diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index d0be292c29..fcb2c8884b 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -235,8 +235,8 @@ class GoogleChartController extends BaseController return View::make('error')->with('message', 'Invalid year.'); } - /** @var \FireflyIII\Database\Budget\Budget $repos */ - $repos = App::make('FireflyIII\Database\Budget\Budget'); + /** @var \FireflyIII\Database\Budget\Budget $budgetRepository */ + $budgetRepository = App::make('FireflyIII\Database\Budget\Budget'); $this->_chart->addColumn('Month', 'date'); $this->_chart->addColumn('Budgeted', 'number'); @@ -246,8 +246,8 @@ class GoogleChartController extends BaseController $end = clone $start; $end->endOfYear(); while ($start <= $end) { - $spent = $repos->spentInMonth($component, $start); - $repetition = $repos->repetitionOnStartingOnDate($component, $start); + $spent = $budgetRepository->spentInMonth($component, $start); + $repetition = $budgetRepository->repetitionOnStartingOnDate($component, $start); if ($repetition) { $budgeted = floatval($repetition->amount); } else { @@ -283,8 +283,8 @@ class GoogleChartController extends BaseController return View::make('error')->with('message', 'Invalid year.'); } - /** @var \FireflyIII\Database\Category\Category $repos */ - $repos = App::make('FireflyIII\Database\Category\Category'); + /** @var \FireflyIII\Database\Category\Category $categoryRepository */ + $categoryRepository = App::make('FireflyIII\Database\Category\Category'); $this->_chart->addColumn('Month', 'date'); $this->_chart->addColumn('Budgeted', 'number'); @@ -295,7 +295,7 @@ class GoogleChartController extends BaseController $end->endOfYear(); while ($start <= $end) { - $spent = $repos->spentInMonth($component, $start); + $spent = $categoryRepository->spentInMonth($component, $start); $budgeted = null; $this->_chart->addRow(clone $start, $budgeted, $spent); diff --git a/app/controllers/HomeController.php b/app/controllers/HomeController.php index 4470615afb..163a3bce99 100644 --- a/app/controllers/HomeController.php +++ b/app/controllers/HomeController.php @@ -26,8 +26,8 @@ class HomeController extends BaseController /** @var \FireflyIII\Database\Account\Account $acct */ $acct = App::make('FireflyIII\Database\Account\Account'); - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $jrnls */ - $jrnls = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); + /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $journalRepository */ + $journalRepository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); /** @var \FireflyIII\Shared\Preferences\PreferencesInterface $preferences */ $preferences = App::make('FireflyIII\Shared\Preferences\PreferencesInterface'); @@ -39,16 +39,16 @@ class HomeController extends BaseController // get the preference for the home accounts to show: - $frontpage = $preferences->get('frontPageAccounts', []); - if ($frontpage->data == []) { + $frontPage = $preferences->get('frontPageAccounts', []); + if ($frontPage->data == []) { $accounts = $acct->getAssetAccounts(); } else { - $accounts = $acct->getByIds($frontpage->data); + $accounts = $acct->getByIds($frontPage->data); } $transactions = []; foreach ($accounts as $account) { - $set = $jrnls->getInDateRangeAccount($account, $start, $end, 10); + $set = $journalRepository->getInDateRangeAccount($account, $start, $end, 10); if (count($set) > 0) { $transactions[] = [$set, $account]; } diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 3e662323ae..e08cef2f62 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -42,9 +42,9 @@ class PiggyBankController extends BaseController public function add(PiggyBank $piggyBank) { $leftOnAccount = $this->_repository->leftOnAccount($piggyBank->account); - $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; - $leftToSave = $piggyBank->targetamount - $savedSoFar; - $maxAmount = min($leftOnAccount, $leftToSave); + $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; + $leftToSave = $piggyBank->targetamount - $savedSoFar; + $maxAmount = min($leftOnAccount, $leftToSave); \Log::debug('Now going to view for piggy bank #' . $piggyBank->id . ' (' . $piggyBank->name . ')'); @@ -182,9 +182,9 @@ class PiggyBankController extends BaseController $amount = round(floatval(Input::get('amount')), 2); /** @var \FireflyIII\Database\PiggyBank\PiggyBank $acct */ - $repos = App::make('FireflyIII\Database\PiggyBank\PiggyBank'); + $piggyRepository = App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - $leftOnAccount = $repos->leftOnAccount($piggyBank->account); + $leftOnAccount = $piggyRepository->leftOnAccount($piggyBank->account); $savedSoFar = $piggyBank->currentRelevantRep()->currentamount; $leftToSave = $piggyBank->targetamount - $savedSoFar; $maxAmount = round(min($leftOnAccount, $leftToSave), 2); @@ -243,7 +243,7 @@ class PiggyBankController extends BaseController */ public function remove(PiggyBank $piggyBank) { - return View::make('piggy_banks.remove',compact('piggyBank')); + return View::make('piggy_banks.remove', compact('piggyBank')); } /** diff --git a/app/controllers/ProfileController.php b/app/controllers/ProfileController.php index d5373ec0c5..19ca37ec0c 100644 --- a/app/controllers/ProfileController.php +++ b/app/controllers/ProfileController.php @@ -1,6 +1,8 @@ with('recurring', $recurringTransaction)->with( + return View::make('recurring.show', compact('journals', 'hideRecurring'))->with('recurring', $recurringTransaction)->with( 'subTitle', $recurringTransaction->name ); } diff --git a/app/lib/FireflyIII/Shared/Toolkit/Form.php b/app/lib/FireflyIII/Shared/Toolkit/Form.php index 036257fb1a..42d6270009 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Form.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Form.php @@ -2,7 +2,6 @@ namespace FireflyIII\Shared\Toolkit; -use Illuminate\Support\Collection; /** * Class Form @@ -14,12 +13,12 @@ class Form /** * Takes any collection and tries to make a sensible select list compatible array of it. * - * @param Collection $set - * @param bool $addEmpty + * @param \Illuminate\Support\Collection $set + * @param bool $addEmpty * * @return mixed */ - public function makeSelectList(Collection $set, $addEmpty = false) + public function makeSelectList(\Illuminate\Support\Collection $set, $addEmpty = false) { $selectList = []; if ($addEmpty) { From 290f25f1a07c28a78ae933a59553f6aa994c1089 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 25 Dec 2014 09:50:01 +0100 Subject: [PATCH 12/84] First attempt at new month report. --- app/controllers/ReportController.php | 32 ++++++++- .../2014_12_24_191544_changes_for_v322.php | 11 ++- app/lib/FireflyIII/Report/Report.php | 31 +++++++- app/lib/FireflyIII/Report/ReportInterface.php | 8 +++ app/lib/FireflyIII/Shared/Toolkit/Date.php | 53 +++++++------- app/routes.php | 3 +- app/views/list/journals-small.blade.php | 31 ++++++++ app/views/reports/index.blade.php | 39 ++++------- app/views/reports/month.blade.php | 70 +++++++++++++++++++ 9 files changed, 221 insertions(+), 57 deletions(-) create mode 100644 app/views/list/journals-small.blade.php create mode 100644 app/views/reports/month.blade.php diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 96e806fa0b..81e7de76b8 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -30,6 +30,9 @@ class ReportController extends BaseController $this->_journals = $journals; $this->_repository = $repository; + View::share('title', 'Reports'); + View::share('mainTitleIcon', 'fa-line-chart'); + } /** @@ -46,6 +49,33 @@ class ReportController extends BaseController return View::make('reports.index', compact('years', 'months', 'title', 'mainTitleIcon')); } + /** + * @param string $year + * @param string $month + * + * @return \Illuminate\View\View + */ + public function month($year = '2014', $month = '1') + { + try { + new Carbon($year . '-' . $month . '-01'); + } catch (Exception $e) { + View::make('error')->with('message', 'Invalid date'); + } + $date = new Carbon($year . '-' . $month . '-01'); + $subTitle = 'Report for ' . $date->format('F Y'); + $subTitleIcon = 'fa-calendar'; + $income = $this->_repository->getIncomeForMonth($date,false); + +// var_dump($income->toArray()); +// exit; + + + + + return View::make('reports.month', compact('date', 'subTitle', 'subTitleIcon','income')); + } + /** * @param $year * @param $month @@ -83,7 +113,7 @@ class ReportController extends BaseController return null; } ); - $deposits = $journals->filter( + $deposits = $journals->filter( function (TransactionJournal $journal) { $relations = $journal->transactiongroups()->where('relation', 'balance')->count(); $budgets = $journal->budgets()->count(); diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 49a66708c8..143c4fe376 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -13,7 +13,7 @@ class ChangesForV322 extends Migration */ public function down() { - + // TODO } @@ -27,6 +27,8 @@ class ChangesForV322 extends Migration // rename tables: Schema::rename('piggybank_repetitions', 'piggy_bank_repetitions'); Schema::rename('piggybanks', 'piggy_banks'); + + // rename fields Schema::table( 'piggy_bank_events', function (Blueprint $table) { $table->renameColumn('piggybank_id', 'piggy_bank_id'); @@ -38,6 +40,13 @@ class ChangesForV322 extends Migration $table->renameColumn('piggybank_id', 'piggy_bank_id'); } ); + + // add soft delete to piggy banks + Schema::table( + 'piggy_banks', function (Blueprint $table) { + $table->softDeletes(); + } + ); } } diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 8638ae20b0..0b59efcc4c 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -5,6 +5,7 @@ namespace FireflyIII\Report; use Carbon\Carbon; use FireflyIII\Database\Account\Account as AccountRepository; use FireflyIII\Database\SwitchUser; +use FireflyIII\Database\TransactionJournal\TransactionJournal as JournalRepository; use Illuminate\Support\Collection; // todo add methods to itnerface @@ -23,12 +24,16 @@ class Report implements ReportInterface /** @var AccountRepository */ protected $_accounts; + /** @var JournalRepository */ + protected $_journals; + /** * @param AccountRepository $accounts */ - public function __construct(AccountRepository $accounts) + public function __construct(AccountRepository $accounts, JournalRepository $journals) { $this->_accounts = $accounts; + $this->_journals = $journals; } @@ -75,6 +80,30 @@ class Report implements ReportInterface } + /** + * @param Carbon $date + * @param bool $shared + * + * @return Collection + */ + public function getIncomeForMonth(Carbon $date, $shared = false) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + $userId = $this->_accounts->getUser()->id; + + $list = \TransactionJournal::withRelevantData() + ->transactionTypes(['Deposit']) + ->where('user_id', $userId) + ->orderBy('date','DESC') + ->before($end)->after($start)->get(['transaction_journals.*']); + + + return $list; + } + /** * @param Carbon $start * diff --git a/app/lib/FireflyIII/Report/ReportInterface.php b/app/lib/FireflyIII/Report/ReportInterface.php index 4605beb75d..7cef787cb4 100644 --- a/app/lib/FireflyIII/Report/ReportInterface.php +++ b/app/lib/FireflyIII/Report/ReportInterface.php @@ -50,4 +50,12 @@ interface ReportInterface * @return array */ public function yearBalanceReport(Carbon $date); + + /** + * @param Carbon $date + * @param bool $shared + * + * @return Collection + */ + public function getIncomeForMonth(Carbon $date, $shared = false); } \ No newline at end of file diff --git a/app/lib/FireflyIII/Shared/Toolkit/Date.php b/app/lib/FireflyIII/Shared/Toolkit/Date.php index 347a9b3c85..5ec5af4148 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Date.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Date.php @@ -2,7 +2,6 @@ namespace FireflyIII\Shared\Toolkit; -use Carbon\Carbon; use FireflyIII\Exception\FireflyException; /** @@ -13,14 +12,14 @@ use FireflyIII\Exception\FireflyException; class Date { /** - * @param Carbon $theDate - * @param $repeatFreq - * @param $skip + * @param \Carbon\Carbon $theDate + * @param $repeatFreq + * @param $skip * - * @return Carbon + * @return \Carbon\Carbon * @throws FireflyException */ - public function addPeriod(Carbon $theDate, $repeatFreq, $skip) + public function addPeriod(\Carbon\Carbon $theDate, $repeatFreq, $skip) { $date = clone $theDate; $add = ($skip + 1); @@ -59,13 +58,13 @@ class Date } /** - * @param Carbon $theCurrentEnd - * @param $repeatFreq + * @param \Carbon\Carbon $theCurrentEnd + * @param $repeatFreq * - * @return mixed + * @return \Carbon\Carbon * @throws FireflyException */ - public function endOfPeriod(Carbon $theCurrentEnd, $repeatFreq) + public function endOfPeriod(\Carbon\Carbon $theCurrentEnd, $repeatFreq) { $currentEnd = clone $theCurrentEnd; switch ($repeatFreq) { @@ -100,14 +99,14 @@ class Date } /** - * @param Carbon $theCurrentEnd - * @param $repeatFreq - * @param Carbon $maxDate + * @param \Carbon\Carbon $theCurrentEnd + * @param $repeatFreq + * @param \Carbon\Carbon $maxDate * - * @return mixed + * @return \Carbon\Carbon * @throws FireflyException */ - public function endOfX(Carbon $theCurrentEnd, $repeatFreq, Carbon $maxDate) + public function endOfX(\Carbon\Carbon $theCurrentEnd, $repeatFreq, \Carbon\Carbon $maxDate) { $currentEnd = clone $theCurrentEnd; switch ($repeatFreq) { @@ -149,13 +148,13 @@ class Date } /** - * @param Carbon $date - * @param $repeatFrequency + * @param \Carbon\Carbon $date + * @param $repeatFrequency * * @return string * @throws FireflyException */ - public function periodShow(Carbon $date, $repeatFrequency) + public function periodShow(\Carbon\Carbon $date, $repeatFrequency) { switch ($repeatFrequency) { default: @@ -183,13 +182,13 @@ class Date } /** - * @param Carbon $theDate - * @param $repeatFreq + * @param \Carbon\Carbon $theDate + * @param $repeatFreq * - * @return Carbon + * @return \Carbon\Carbon * @throws FireflyException */ - public function startOfPeriod(Carbon $theDate, $repeatFreq) + public function startOfPeriod(\Carbon\Carbon $theDate, $repeatFreq) { $date = clone $theDate; switch ($repeatFreq) { @@ -228,14 +227,14 @@ class Date } /** - * @param Carbon $theDate - * @param $repeatFreq - * @param int $subtract + * @param \Carbon\Carbon $theDate + * @param $repeatFreq + * @param int $subtract * - * @return Carbon + * @return \Carbon\Carbon * @throws FireflyException */ - public function subtractPeriod(Carbon $theDate, $repeatFreq, $subtract = 1) + public function subtractPeriod(\Carbon\Carbon $theDate, $repeatFreq, $subtract = 1) { $date = clone $theDate; switch ($repeatFreq) { diff --git a/app/routes.php b/app/routes.php index 7288405638..b12d653354 100644 --- a/app/routes.php +++ b/app/routes.php @@ -247,7 +247,8 @@ Route::group( // report controller: Route::get('/reports', ['uses' => 'ReportController@index', 'as' => 'reports.index']); Route::get('/reports/{year}', ['uses' => 'ReportController@year', 'as' => 'reports.year']); - Route::get('/reports/unbalanced/{year}/{month}', ['uses' => 'ReportController@unbalanced', 'as' => 'reports.unbalanced']); + Route::get('/reports/{year}/{month}', ['uses' => 'ReportController@month', 'as' => 'reports.month']); + #Route::get('/reports/unbalanced/{year}/{month}', ['uses' => 'ReportController@unbalanced', 'as' => 'reports.unbalanced']); // reminder controller Route::get('/reminders/{reminder}', ['uses' => 'ReminderController@show', 'as' => 'reminders.show']); diff --git a/app/views/list/journals-small.blade.php b/app/views/list/journals-small.blade.php new file mode 100644 index 0000000000..31af0154ff --- /dev/null +++ b/app/views/list/journals-small.blade.php @@ -0,0 +1,31 @@ +
Piggy bankDate
- {{{$event->piggybank->name}}} + {{{$event->piggyBank->name}}} diff --git a/app/views/partials/menu.blade.php b/app/views/partials/menu.blade.php index 5e34833a5f..c4f7da2aef 100644 --- a/app/views/partials/menu.blade.php +++ b/app/views/partials/menu.blade.php @@ -137,8 +137,8 @@ @@ -146,7 +146,7 @@ Money management
  • - Piggy banks + Piggy banks
  • Recurring transactions diff --git a/app/views/piggybanks/add.blade.php b/app/views/piggy_banks/add.blade.php similarity index 90% rename from app/views/piggybanks/add.blade.php rename to app/views/piggy_banks/add.blade.php index c4f0a9cc3d..7dddbeb4b2 100644 --- a/app/views/piggybanks/add.blade.php +++ b/app/views/piggy_banks/add.blade.php @@ -1,4 +1,4 @@ - + {{Form::token()}}
    diff --git a/app/views/piggybanks/create.blade.php b/app/views/piggy_banks/create.blade.php similarity index 98% rename from app/views/piggybanks/create.blade.php rename to app/views/piggy_banks/create.blade.php index e2214e5e1e..dea0c3573f 100644 --- a/app/views/piggybanks/create.blade.php +++ b/app/views/piggy_banks/create.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} -{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('piggybanks.store')])}} +{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('piggy_banks.store')])}}
    diff --git a/app/views/piggybanks/delete.blade.php b/app/views/piggy_banks/delete.blade.php similarity index 94% rename from app/views/piggybanks/delete.blade.php rename to app/views/piggy_banks/delete.blade.php index 967e8b7bc8..6943692500 100644 --- a/app/views/piggybanks/delete.blade.php +++ b/app/views/piggy_banks/delete.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }} -{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('piggybanks.destroy',$piggyBank->id)])}} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('piggy_banks.destroy',$piggyBank->id)])}}
    diff --git a/app/views/piggybanks/edit.blade.php b/app/views/piggy_banks/edit.blade.php similarity index 98% rename from app/views/piggybanks/edit.blade.php rename to app/views/piggy_banks/edit.blade.php index 9cc580c989..6532a61a27 100644 --- a/app/views/piggybanks/edit.blade.php +++ b/app/views/piggy_banks/edit.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }} -{{Form::model($piggyBank, ['class' => 'form-horizontal','id' => 'update','url' => route('piggybanks.update',$piggyBank->id)])}} +{{Form::model($piggyBank, ['class' => 'form-horizontal','id' => 'update','url' => route('piggy_banks.update',$piggyBank->id)])}}
    diff --git a/app/views/piggybanks/index.blade.php b/app/views/piggy_banks/index.blade.php similarity index 88% rename from app/views/piggybanks/index.blade.php rename to app/views/piggy_banks/index.blade.php index 3bdc4ff6cc..327f87ddb5 100644 --- a/app/views/piggybanks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -6,7 +6,7 @@
    - {{{$piggyBank->name}}} + {{{$piggyBank->name}}}
    @@ -41,8 +41,8 @@
    - - + +
    @@ -63,7 +63,7 @@
    - Create new piggy bank + Create new piggy bank
    @@ -109,5 +109,5 @@ @stop @section('scripts') -{{HTML::script('assets/javascript/firefly/piggybanks.js')}} +{{HTML::script('assets/javascript/firefly/piggy_banks.js')}} @stop \ No newline at end of file diff --git a/app/views/piggybanks/remove.blade.php b/app/views/piggy_banks/remove.blade.php similarity index 95% rename from app/views/piggybanks/remove.blade.php rename to app/views/piggy_banks/remove.blade.php index b0846bff2e..09e3c1f1bb 100644 --- a/app/views/piggybanks/remove.blade.php +++ b/app/views/piggy_banks/remove.blade.php @@ -1,4 +1,4 @@ - + {{Form::token()}}
    diff --git a/app/views/piggybanks/show.blade.php b/app/views/piggy_banks/show.blade.php similarity index 92% rename from app/views/piggybanks/show.blade.php rename to app/views/piggy_banks/show.blade.php index 48f79b9f7d..8bc38c032c 100644 --- a/app/views/piggybanks/show.blade.php +++ b/app/views/piggy_banks/show.blade.php @@ -8,7 +8,7 @@ Events
    -
    +
    @@ -25,8 +25,8 @@
    @@ -106,7 +106,7 @@ Table
    - @include('list.piggybank-events') + @include('list.piggyBank-events')
    @@ -123,5 +123,5 @@ var piggyBankID = {{{$piggyBank->id}}}; {{HTML::script('assets/javascript/firefly/gcharts.options.js')}} {{HTML::script('assets/javascript/firefly/gcharts.js')}} -{{HTML::script('assets/javascript/firefly/piggybanks.js')}} +{{HTML::script('assets/javascript/firefly/piggy_banks.js')}} @stop diff --git a/app/views/reminders/show.blade.php b/app/views/reminders/show.blade.php index 5227d0afa7..a01b3a8882 100644 --- a/app/views/reminders/show.blade.php +++ b/app/views/reminders/show.blade.php @@ -14,7 +14,7 @@

    @if(get_class($reminder->remindersable) == 'Piggybank') Somewhere between {{$reminder->startdate->format('j F Y')}} and {{$reminder->enddate->format('j F Y')}} you - should deposit {{mf($amount)}} in piggy bank {{{$reminder->remindersable->name}}} + should deposit {{mf($amount)}} in piggy bank {{{$reminder->remindersable->name}}} in order to make your goal of saving {{mf($reminder->remindersable->targetamount)}} on {{$reminder->remindersable->targetdate->format('j F Y')}} @endif diff --git a/app/views/transactions/create.blade.php b/app/views/transactions/create.blade.php index 9575d6ac21..5573bc0bce 100644 --- a/app/views/transactions/create.blade.php +++ b/app/views/transactions/create.blade.php @@ -70,7 +70,7 @@ @if($what == 'transfer' && count($piggies) > 0) - {{Form::ffSelect('piggybank_id',$piggies)}} + {{Form::ffSelect('piggy_bank_id',$piggies)}} @endif

    diff --git a/app/views/transactions/delete.blade.php b/app/views/transactions/delete.blade.php index e99253a64c..4a496138c4 100644 --- a/app/views/transactions/delete.blade.php +++ b/app/views/transactions/delete.blade.php @@ -16,7 +16,7 @@ associated data.

    - This action will not destroy categories, piggybanks, accounts, etc. + This action will not destroy categories, piggy banks, accounts, etc.

    Are you sure? diff --git a/app/views/transactions/edit.blade.php b/app/views/transactions/edit.blade.php index d1a268c654..eb9aa0f51c 100644 --- a/app/views/transactions/edit.blade.php +++ b/app/views/transactions/edit.blade.php @@ -68,7 +68,7 @@ @if($what == 'transfer' && count($piggies) > 0) - {{Form::ffSelect('piggybank_id',$piggies,$data['piggybank_id'])}} + {{Form::ffSelect('piggy_bank_id',$piggies,$data['piggy_bank_id'])}} @endif

    diff --git a/app/views/transactions/show.blade.php b/app/views/transactions/show.blade.php index 474ce848fa..dfff23a750 100644 --- a/app/views/transactions/show.blade.php +++ b/app/views/transactions/show.blade.php @@ -48,13 +48,13 @@
    - @if(count($journal->piggybankevents) > 0) + @if(count($journal->piggyBankEvents) > 0)
    Piggy banks
    - @include('list.piggybank-events',['events' => $journal->piggybankevents,'showPiggybank' => true]) + @include('list.piggyBank-events',['events' => $journal->piggyBankEvents,'showPiggyBank' => true])
    @endif diff --git a/bootstrap/start.php b/bootstrap/start.php index 4ebe8c71ae..7395dfd718 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -176,11 +176,6 @@ require $framework . '/Illuminate/Foundation/start.php'; */ // do something with events: -//Event::subscribe('Firefly\Trigger\Limits\EloquentLimitTrigger'); -//Event::subscribe('Firefly\Trigger\Piggybanks\EloquentPiggybankTrigger'); -//Event::subscribe('Firefly\Trigger\Budgets\EloquentBudgetTrigger'); -//Event::subscribe('Firefly\Trigger\Recurring\EloquentRecurringTrigger'); -//Event::subscribe('Firefly\Trigger\Journals\EloquentJournalTrigger'); Event::subscribe('FireflyIII\Event\Account'); Event::subscribe('FireflyIII\Event\Budget'); diff --git a/public/assets/javascript/firefly/piggybanks.js b/public/assets/javascript/firefly/piggy_banks.js similarity index 60% rename from public/assets/javascript/firefly/piggybanks.js rename to public/assets/javascript/firefly/piggy_banks.js index f97c71339f..f336d2d3fd 100644 --- a/public/assets/javascript/firefly/piggybanks.js +++ b/public/assets/javascript/firefly/piggy_banks.js @@ -3,20 +3,20 @@ $(function () { $('.removeMoney').on('click', removeMoney); if (typeof(googleLineChart) == 'function' && typeof(piggyBankID) != 'undefined') { - googleLineChart('chart/piggyhistory/' + piggyBankID, 'piggybank-history'); + googleLineChart('chart/piggy_history/' + piggyBankID, 'piggy-bank-history'); } }); function addMoney(e) { var pigID = parseInt($(e.target).data('id')); - $('#moneyManagementModal').empty().load('piggybanks/add/' + pigID).modal('show'); + $('#moneyManagementModal').empty().load('piggy_banks/add/' + pigID).modal('show'); return false; } function removeMoney(e) { var pigID = parseInt($(e.target).data('id')); - $('#moneyManagementModal').empty().load('piggybanks/remove/' + pigID).modal('show'); + $('#moneyManagementModal').empty().load('piggy_banks/remove/' + pigID).modal('show'); return false; } \ No newline at end of file diff --git a/tests/functional/GoogleChartControllerCest.php b/tests/functional/GoogleChartControllerCest.php index 468ac29683..dbc8e091e1 100644 --- a/tests/functional/GoogleChartControllerCest.php +++ b/tests/functional/GoogleChartControllerCest.php @@ -131,7 +131,7 @@ class GoogleChartControllerCest public function piggyBankHistory(FunctionalTester $I) { $I->wantTo('see the chart for the history of a piggy bank'); - $I->amOnPage('/chart/piggyhistory/1'); + $I->amOnPage('/chart/piggy_history/1'); $I->seeResponseCodeIs(200); } diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index c92cc84f3d..c86b35f53a 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -5,7 +5,7 @@ * @SuppressWarnings("CamelCase") * @SuppressWarnings("short") * - * Class PiggybankControllerCest + * Class PiggyBankControllerCest */ class PiggyBankControllerCest { @@ -30,7 +30,7 @@ class PiggyBankControllerCest public function add(FunctionalTester $I) { $I->wantTo('add money to a piggy bank'); - $I->amOnPage('/piggybanks/add/1'); + $I->amOnPage('/piggy_banks/add/1'); $I->see('Add money to New camera'); } @@ -40,7 +40,7 @@ class PiggyBankControllerCest public function create(FunctionalTester $I) { $I->wantTo('create a piggy bank'); - $I->amOnPage('/piggybanks/create'); + $I->amOnPage('/piggy_banks/create'); $I->see('Create new piggy bank'); } @@ -50,7 +50,7 @@ class PiggyBankControllerCest public function delete(FunctionalTester $I) { $I->wantTo('delete a piggy bank'); - $I->amOnPage('/piggybanks/delete/1'); + $I->amOnPage('/piggy_banks/delete/1'); $I->see('Delete "New camera"'); } @@ -60,7 +60,7 @@ class PiggyBankControllerCest public function destroy(FunctionalTester $I) { $I->wantTo('destroy a piggy bank'); - $I->amOnPage('/piggybanks/delete/1'); + $I->amOnPage('/piggy_banks/delete/1'); $I->see('Delete "New camera"'); $I->submitForm('#destroy', []); $I->see('Piggy bank "New camera" deleted.'); @@ -72,7 +72,7 @@ class PiggyBankControllerCest public function edit(FunctionalTester $I) { $I->wantTo('edit a piggy bank'); - $I->amOnPage('/piggybanks/edit/1'); + $I->amOnPage('/piggy_banks/edit/1'); $I->see('Edit piggy bank "New camera"'); } @@ -82,7 +82,7 @@ class PiggyBankControllerCest public function editWithTargetDate(FunctionalTester $I) { $I->wantTo('edit a piggy bank with a target date'); - $I->amOnPage('/piggybanks/edit/2'); + $I->amOnPage('/piggy_banks/edit/2'); $I->see('Edit piggy bank "New clothes"'); } @@ -92,7 +92,7 @@ class PiggyBankControllerCest public function index(FunctionalTester $I) { $I->wantTo('view all piggy banks'); - $I->amOnPage('/piggybanks'); + $I->amOnPage('/piggy_banks'); $I->see('Piggy banks'); $I->see('New camera'); } @@ -103,7 +103,7 @@ class PiggyBankControllerCest public function postAdd(FunctionalTester $I) { $I->wantTo('process adding money to a piggy bank'); - $I->amOnPage('/piggybanks/add/1'); + $I->amOnPage('/piggy_banks/add/1'); $I->see('Add money to New camera'); $I->submitForm('#add', ['amount' => 100]); $I->see(',00 to "New camera".'); @@ -115,7 +115,7 @@ class PiggyBankControllerCest public function postAddTooMuch(FunctionalTester $I) { $I->wantTo('try to add too much money to a piggy bank'); - $I->amOnPage('/piggybanks/add/1'); + $I->amOnPage('/piggy_banks/add/1'); $I->see('Add money to New camera'); $I->submitForm('#add', ['amount' => 100000]); $I->see(',00 to "New camera".'); @@ -127,11 +127,11 @@ class PiggyBankControllerCest public function postRemove(FunctionalTester $I) { $I->wantTo('process removing money from a piggy bank'); - $I->amOnPage('/piggybanks/add/1'); + $I->amOnPage('/piggy_banks/add/1'); $I->see('Add money to New camera'); $I->submitForm('#add', ['amount' => 100]); $I->see(',00 to "New camera".'); - $I->amOnPage('/piggybanks/remove/1'); + $I->amOnPage('/piggy_banks/remove/1'); $I->see('Remove money from New camera'); $I->submitForm('#remove', ['amount' => 50]); $I->see(',00 from "New camera".'); @@ -143,11 +143,11 @@ class PiggyBankControllerCest public function postRemoveFail(FunctionalTester $I) { $I->wantTo('process removing too much money from a piggy bank'); - $I->amOnPage('/piggybanks/add/1'); + $I->amOnPage('/piggy_banks/add/1'); $I->see('Add money to New camera'); $I->submitForm('#add', ['amount' => 100]); $I->see(',00 to "New camera".'); - $I->amOnPage('/piggybanks/remove/1'); + $I->amOnPage('/piggy_banks/remove/1'); $I->see('Remove money from New camera'); $I->submitForm('#remove', ['amount' => 500]); $I->see(',00 from "New camera".'); @@ -160,7 +160,7 @@ class PiggyBankControllerCest public function remove(FunctionalTester $I) { $I->wantTo('removing money from a piggy bank'); - $I->amOnPage('/piggybanks/remove/1'); + $I->amOnPage('/piggy_banks/remove/1'); $I->see('Remove money from New camera'); } @@ -170,7 +170,7 @@ class PiggyBankControllerCest public function show(FunctionalTester $I) { $I->wantTo('view a piggy bank'); - $I->amOnPage('/piggybanks/show/1'); + $I->amOnPage('/piggy_banks/show/1'); $I->see('New camera'); } @@ -180,7 +180,7 @@ class PiggyBankControllerCest public function store(FunctionalTester $I) { $I->wantTo('store a new piggy bank'); - $I->amOnPage('/piggybanks/create'); + $I->amOnPage('/piggy_banks/create'); $I->see('Create new piggy bank'); $I->submitForm( '#store', ['name' => 'Some new piggy bank', @@ -199,7 +199,7 @@ class PiggyBankControllerCest public function storeAndReturn(FunctionalTester $I) { $I->wantTo('store a new piggy bank and return'); - $I->amOnPage('/piggybanks/create'); + $I->amOnPage('/piggy_banks/create'); $I->see('Create new piggy bank'); $I->submitForm( '#store', ['name' => 'Some new piggy bank', @@ -219,7 +219,7 @@ class PiggyBankControllerCest public function storeFail(FunctionalTester $I) { $I->wantTo('fail storing a new piggy bank'); - $I->amOnPage('/piggybanks/create'); + $I->amOnPage('/piggy_banks/create'); $I->see('Create new piggy bank'); $I->submitForm( '#store', ['name' => null, @@ -238,7 +238,7 @@ class PiggyBankControllerCest public function update(FunctionalTester $I) { $I->wantTo('update a piggy bank'); - $I->amOnPage('/piggybanks/edit/1'); + $I->amOnPage('/piggy_banks/edit/1'); $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ @@ -261,7 +261,7 @@ class PiggyBankControllerCest public function updateAndReturn(FunctionalTester $I) { $I->wantTo('update a piggy bank and return'); - $I->amOnPage('/piggybanks/edit/1'); + $I->amOnPage('/piggy_banks/edit/1'); $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ @@ -284,7 +284,7 @@ class PiggyBankControllerCest public function updateValidateOnly(FunctionalTester $I) { $I->wantTo('validate a piggy bank'); - $I->amOnPage('/piggybanks/edit/1'); + $I->amOnPage('/piggy_banks/edit/1'); $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ @@ -307,7 +307,7 @@ class PiggyBankControllerCest public function updateFail(FunctionalTester $I) { $I->wantTo('update a piggy bank and fail'); - $I->amOnPage('/piggybanks/edit/1'); + $I->amOnPage('/piggy_banks/edit/1'); $I->see('Edit piggy bank "New camera"'); $I->submitForm( '#update', [ @@ -320,7 +320,7 @@ class PiggyBankControllerCest ] ); $I->see('Name is too short'); - $I->seeInDatabase('piggybanks', ['name' => 'New camera']); + $I->seeInDatabase('piggy_banks', ['name' => 'New camera']); } From 62748fa2552e09e2dc72d787b409d7e701756524 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 20:56:05 +0100 Subject: [PATCH 04/84] Migrations for future version 3.2.2 --- .gitignore | 1 + .../2014_12_24_191544_changes_for_v322.php | 43 +++++++++++++++++++ 2 files changed, 44 insertions(+) create mode 100644 app/database/migrations/2014_12_24_191544_changes_for_v322.php diff --git a/.gitignore b/.gitignore index 71d8f61ce0..ccc58cf470 100644 --- a/.gitignore +++ b/.gitignore @@ -23,3 +23,4 @@ tests/unit/UnitTester.php pi.php tests/_data/db.sqlite tests/_data/dump.sql +db.sqlite_snapshot diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php new file mode 100644 index 0000000000..49a66708c8 --- /dev/null +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -0,0 +1,43 @@ +renameColumn('piggybank_id', 'piggy_bank_id'); + } + ); + + Schema::table( + 'piggy_bank_repetitions', function (Blueprint $table) { + $table->renameColumn('piggybank_id', 'piggy_bank_id'); + } + ); + } + +} From e3482011d57fc2dee926d37829d8099998d8397c Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 21:07:20 +0100 Subject: [PATCH 05/84] Updated two views. --- .../{piggybank-events.blade.php => piggy-bank-events.blade.php} | 0 app/views/piggy_banks/show.blade.php | 2 +- app/views/transactions/show.blade.php | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename app/views/list/{piggybank-events.blade.php => piggy-bank-events.blade.php} (100%) diff --git a/app/views/list/piggybank-events.blade.php b/app/views/list/piggy-bank-events.blade.php similarity index 100% rename from app/views/list/piggybank-events.blade.php rename to app/views/list/piggy-bank-events.blade.php diff --git a/app/views/piggy_banks/show.blade.php b/app/views/piggy_banks/show.blade.php index 8bc38c032c..33366e2f2b 100644 --- a/app/views/piggy_banks/show.blade.php +++ b/app/views/piggy_banks/show.blade.php @@ -106,7 +106,7 @@ Table
    - @include('list.piggyBank-events') + @include('list.piggy-bank-events')
    diff --git a/app/views/transactions/show.blade.php b/app/views/transactions/show.blade.php index dfff23a750..5b86bd130a 100644 --- a/app/views/transactions/show.blade.php +++ b/app/views/transactions/show.blade.php @@ -54,7 +54,7 @@ Piggy banks
    - @include('list.piggyBank-events',['events' => $journal->piggyBankEvents,'showPiggyBank' => true]) + @include('list.piggy-bank-events',['events' => $journal->piggyBankEvents,'showPiggyBank' => true])
    @endif From 037452e525fa693f4decd5369c70379f47793572 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 24 Dec 2014 21:20:47 +0100 Subject: [PATCH 06/84] Spelling errors fixed. --- app/controllers/GoogleChartController.php | 2 +- app/controllers/HomeController.php | 2 +- app/controllers/PiggybankController.php | 2 +- app/controllers/PreferencesController.php | 14 +- app/controllers/ReminderController.php | 4 +- .../2014_12_13_190730_changes_for_v321.php | 128 ------------------ .../FireflyIII/Shared/Toolkit/Reminders.php | 4 +- app/models/Transaction.php | 2 +- app/models/User.php | 2 +- app/views/piggy_banks/index.blade.php | 2 +- app/views/preferences/index.blade.php | 6 +- 11 files changed, 20 insertions(+), 148 deletions(-) diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index 634153bf0b..d0be292c29 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -86,7 +86,7 @@ class GoogleChartController extends BaseController /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - $pref = $preferences->get('frontpageAccounts', []); + $pref = $preferences->get('frontPageAccounts', []); /** @var \FireflyIII\Database\Account\Account $acct */ $acct = App::make('FireflyIII\Database\Account\Account'); diff --git a/app/controllers/HomeController.php b/app/controllers/HomeController.php index faea3a7f68..4470615afb 100644 --- a/app/controllers/HomeController.php +++ b/app/controllers/HomeController.php @@ -39,7 +39,7 @@ class HomeController extends BaseController // get the preference for the home accounts to show: - $frontpage = $preferences->get('frontpageAccounts', []); + $frontpage = $preferences->get('frontPageAccounts', []); if ($frontpage->data == []) { $accounts = $acct->getAssetAccounts(); } else { diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 0ba6f9c8ce..3e662323ae 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -155,7 +155,7 @@ class PiggyBankController extends BaseController $accounts[$account->id] = [ 'name' => $account->name, 'balance' => Steam::balance($account), - 'leftForPiggybanks' => $this->_repository->leftOnAccount($account), + 'leftForPiggyBanks' => $this->_repository->leftOnAccount($account), 'sumOfSaved' => $piggyBank->savedSoFar, 'sumOfTargets' => floatval($piggyBank->targetamount), 'leftToSave' => $piggyBank->leftToSave diff --git a/app/controllers/PreferencesController.php b/app/controllers/PreferencesController.php index 1330af52ef..6b2b9a08ff 100644 --- a/app/controllers/PreferencesController.php +++ b/app/controllers/PreferencesController.php @@ -32,11 +32,11 @@ class PreferencesController extends BaseController $accounts = $acct->getAssetAccounts(); $viewRange = $preferences->get('viewRange', '1M'); $viewRangeValue = $viewRange->data; - $frontPage = $preferences->get('frontpageAccounts', []); + $frontPage = $preferences->get('frontPageAccounts', []); $budgetMax = $preferences->get('budgetMaximum', 1000); $budgetMaximum = $budgetMax->data; - return View::make('preferences.index', compact('budgetMaximum'))->with('accounts', $accounts)->with('frontpageAccounts', $frontPage)->with( + return View::make('preferences.index', compact('budgetMaximum'))->with('accounts', $accounts)->with('frontPageAccounts', $frontPage)->with( 'viewRange', $viewRangeValue ); } @@ -49,12 +49,12 @@ class PreferencesController extends BaseController /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - // frontpage accounts - $frontpageAccounts = []; - foreach (Input::get('frontpageAccounts') as $id) { - $frontpageAccounts[] = intval($id); + // front page accounts + $frontPageAccounts = []; + foreach (Input::get('frontPageAccounts') as $id) { + $frontPageAccounts[] = intval($id); } - $preferences->set('frontpageAccounts', $frontpageAccounts); + $preferences->set('frontPageAccounts', $frontPageAccounts); // view range: $preferences->set('viewRange', Input::get('viewRange')); diff --git a/app/controllers/ReminderController.php b/app/controllers/ReminderController.php index 2ef658ec04..873ac2b7eb 100644 --- a/app/controllers/ReminderController.php +++ b/app/controllers/ReminderController.php @@ -31,7 +31,7 @@ class ReminderController extends BaseController throw new FireflyException('Cannot act on reminder for ' . get_class($reminder->remindersable)); break; break; - case 'Piggybank': + case 'PiggyBank': $amount = Reminders::amountForReminder($reminder); $preFilled = [ 'amount' => round($amount, 2), @@ -85,7 +85,7 @@ class ReminderController extends BaseController { $amount = null; - if (get_class($reminder->remindersable) == 'Piggybank') { + if (get_class($reminder->remindersable) == 'PiggyBank') { $amount = Reminders::amountForReminder($reminder); } diff --git a/app/database/migrations/2014_12_13_190730_changes_for_v321.php b/app/database/migrations/2014_12_13_190730_changes_for_v321.php index 40c878e971..10dc2f221d 100644 --- a/app/database/migrations/2014_12_13_190730_changes_for_v321.php +++ b/app/database/migrations/2014_12_13_190730_changes_for_v321.php @@ -503,133 +503,5 @@ class ChangesForV321 extends Migration \DB::update('UPDATE `transaction_currencies` SET `symbol` = "€", `name` = "Euro" WHERE `code` = "EUR";'); } - // - // public function doRenameInLimitRepetitions() - // { - // Schema::table( - // 'limit_repetitions', function (Blueprint $table) { - // $table->renameColumn('limit_id', 'budget_limit_id'); - // } - // ); - // } - // - // public function doBudgetLimits() - // { - // Schema::rename('limits', 'budget_limits'); - // Schema::table( - // 'budget_limits', function (Blueprint $table) { - // $table->integer('budget_id')->unsigned()->after('updated_at'); - // $table->foreign('budget_id', 'bid_foreign')->references('id')->on('budgets')->onDelete('cascade'); - // } - // ); - // } - // - // public function doPiggyBankEvents() - // { - // Schema::rename('piggybank_events', 'piggy_bank_events'); - // - // } - // - // public function doCreateCategoryTables() - // { - // Schema::create( - // 'categories', function (Blueprint $table) { - // $table->increments('id'); - // $table->timestamps(); - // $table->softDeletes(); - // $table->string('name', 50); - // $table->integer('user_id')->unsigned(); - // $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade'); - // $table->unique(['user_id', 'name']); - // } - // ); - // Schema::create( - // 'category_transaction_journal', function (Blueprint $table) { - // $table->increments('id'); - // $table->integer('category_id')->unsigned(); - // $table->integer('transaction_journal_id')->unsigned(); - // $table->foreign('category_id')->references('id')->on('categories')->onDelete('cascade'); - // $table->foreign('transaction_journal_id')->references('id')->on('transaction_journals')->onDelete('cascade'); - // $table->unique(['category_id', 'transaction_journal_id'], 'catid_tjid_unique'); - // } - // ); - // - // } - // - // public function doUpdateTransactionTable() - // { - // Schema::table( - // 'transactions', function (Blueprint $table) { - // $table->dropForeign('transactions_piggybank_id_foreign'); - // #$table->dropIndex('transactions_piggybank_id_foreign'); - // $table->dropColumn('piggybank_id'); - // } - // ); - // } - // - // public function doDropCompRecurTable() - // { - // Schema::drop('component_recurring_transaction'); - // } - // - // public function doDropCompTransTable() - // { - // Schema::drop('component_transaction'); - // } - // - // public function doMoveBudgets() - // { - // Component::where('class', 'Budget')->get()->each( - // function (Component $c) { - // $entry = [ - // 'user_id' => $c->user_id, - // 'name' => $c->name - // - // ]; - // $budget = Budget::firstOrCreate($entry); - // Log::debug('Migrated budget #' . $budget->id . ': ' . $budget->name); - // // create entry in budget_transaction_journal - // $connections = DB::table('component_transaction_journal')->where('component_id', $c->id)->get(); - // foreach ($connections as $connection) { - // DB::table('budget_transaction_journal')->insert( - // [ - // 'budget_id' => $budget->id, - // 'transaction_journal_id' => $connection->transaction_journal_id - // ] - // ); - // } - // } - // ); - // } - // - // public function doMoveCategories() - // { - // Component::where('class', 'Category')->get()->each( - // function (Component $c) { - // $entry = [ - // 'user_id' => $c->user_id, - // 'name' => $c->name - // - // ]; - // $category = Category::firstOrCreate($entry); - // Log::debug('Migrated category #' . $category->id . ': ' . $category->name); - // // create entry in category_transaction_journal - // $connections = DB::table('component_transaction_journal')->where('component_id', $c->id)->get(); - // foreach ($connections as $connection) { - // DB::table('category_transaction_journal')->insert( - // [ - // 'category_id' => $category->id, - // 'transaction_journal_id' => $connection->transaction_journal_id - // ] - // ); - // } - // } - // ); - // } - // - // public function doMoveLimitReferences() - // { - // throw new \FireflyIII\Exception\FireflyException('TODO'); - // } } diff --git a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php index f506f81a98..f545d4fb73 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php @@ -25,7 +25,7 @@ class Reminders switch (get_class($reminder->remindersable)) { - case 'Piggybank': + case 'PiggyBank': $start = new Carbon; $end = !is_null($reminder->remindersable->targetdate) ? clone $reminder->remindersable->targetdate : new Carbon; $reminders = 0; @@ -93,7 +93,7 @@ class Reminders $reminder->active = 1; $reminder->user()->associate(\Auth::getUser()); $reminder->remindersable_id = $piggyBank->id; - $reminder->remindersable_type = 'Piggybank'; + $reminder->remindersable_type = 'PiggyBank'; $reminder->save(); } } diff --git a/app/models/Transaction.php b/app/models/Transaction.php index 136941f0b0..554d130ed3 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -32,7 +32,7 @@ class Transaction extends Eloquent */ public function piggyBank() { - return $this->belongsTo('Piggybank'); + return $this->belongsTo('PiggyBank'); } /** diff --git a/app/models/User.php b/app/models/User.php index e86aa0da0b..938f353bde 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -55,7 +55,7 @@ class User extends Eloquent implements UserInterface, RemindableInterface */ public function piggyBanks() { - return $this->hasManyThrough('Piggybank', 'Account'); + return $this->hasManyThrough('PiggyBank', 'Account'); } /** diff --git a/app/views/piggy_banks/index.blade.php b/app/views/piggy_banks/index.blade.php index 327f87ddb5..6279dcd1d6 100644 --- a/app/views/piggy_banks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -91,7 +91,7 @@
{{{$info['name']}}} {{mf($info['balance'])}}{{mf($info['leftForPiggybanks'])}}{{mf($info['leftForPiggyBanks'])}} {{mf($info['sumOfTargets'])}} {{mf($info['sumOfSaved'])}} {{mf($info['leftToSave'])}}
+ @foreach($journals as $journal) + + + + + + + + @endforeach +
+ {{{$journal->description}}} + + @if($journal->transactiontype->type == 'Withdrawal') + {{mf($journal->transactions[1]->amount,false)}} + @endif + @if($journal->transactiontype->type == 'Deposit') + {{mf($journal->transactions[1]->amount,false)}} + @endif + @if($journal->transactiontype->type == 'Transfer') + {{mf($journal->transactions[1]->amount,false)}} + @endif + + {{$journal->date->format('j F Y')}} + + @if($journal->transactions[1]->account->accounttype->description == 'Cash account') + (cash) + @else + {{{$journal->transactions[1]->account->name}}} + @endif +
\ No newline at end of file diff --git a/app/views/reports/index.blade.php b/app/views/reports/index.blade.php index bf37aa61e3..8a0e83fe81 100644 --- a/app/views/reports/index.blade.php +++ b/app/views/reports/index.blade.php @@ -16,33 +16,20 @@
-
-
-
- Budget reports -
-
- + +
+
+
+ Monthly reports +
+
+ +
-
-
-
-
- Unbalanced transactions -
-
- -
-
-
@stop \ No newline at end of file diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php new file mode 100644 index 0000000000..44ff3e529a --- /dev/null +++ b/app/views/reports/month.blade.php @@ -0,0 +1,70 @@ +@extends('layouts.default') +@section('content') +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +
+
+
+
Income
+ @include('list.journals-small',['journals' => $income]) +
+
+
+
+
Expenses (top 10)
+
Body
+
+
+
+
+
+
+
Budgets
+
Body
+
+
+
+
+
Categories
+
Body
+
+
+
+
+
+
+
Accounts
+
Body
+
+
+
+
+
+
+
Piggy banks
+
Body
+
+
+
+
+
Repeated expenses
+
Body
+
+
+
+
+
+
+
Recurring transactions
+
Body
+
+
+
+
+
+
+
Outside of budgets
+
Body
+
+
+
+@stop \ No newline at end of file From 2d67a3159d7707639b47ffb5ae0d83e5c243284c Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 26 Dec 2014 21:08:44 +0100 Subject: [PATCH 13/84] Expanded reports --- app/controllers/ReportController.php | 20 +- .../2014_12_24_191544_changes_for_v322.php | 37 +- app/lib/FireflyIII/Report/Report.php | 345 +++++++++++++++++- app/lib/FireflyIII/Report/ReportInterface.php | 73 +++- app/views/list/journals-small.blade.php | 11 +- app/views/reports/month.blade.php | 106 +++++- 6 files changed, 557 insertions(+), 35 deletions(-) diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 81e7de76b8..a759ba17cc 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -62,18 +62,20 @@ class ReportController extends BaseController } catch (Exception $e) { View::make('error')->with('message', 'Invalid date'); } - $date = new Carbon($year . '-' . $month . '-01'); + $date = new Carbon($year . '-' . $month . '-01'); $subTitle = 'Report for ' . $date->format('F Y'); $subTitleIcon = 'fa-calendar'; - $income = $this->_repository->getIncomeForMonth($date,false); + $displaySum = true; // to show sums in report. + $income = $this->_repository->getIncomeForMonth($date); + $expenses = $this->_repository->getExpenseGroupedForMonth($date, 10); + $budgets = $this->_repository->getBudgetsForMonth($date); + $categories = $this->_repository->getCategoriesForMonth($date, 10); + $accounts = $this->_repository->getAccountsForMonth($date); -// var_dump($income->toArray()); -// exit; - - - - - return View::make('reports.month', compact('date', 'subTitle', 'subTitleIcon','income')); + return View::make( + 'reports.month', + compact('accounts', 'categories', 'budgets', 'expenses', 'subTitle', 'displaySum', 'subTitleIcon', 'income') + ); } /** diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 143c4fe376..4d400e97b7 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -13,7 +13,29 @@ class ChangesForV322 extends Migration */ public function down() { - // TODO + // rename tables: + Schema::rename('piggy_bank_repetitions', 'piggybank_repetitions'); + Schema::rename('piggy_banks', 'piggybanks'); + + // rename fields + Schema::table( + 'piggy_bank_events', function (Blueprint $table) { + $table->renameColumn('piggy_bank_id', 'piggybank_id'); + } + ); + + Schema::table( + 'piggybank_repetitions', function (Blueprint $table) { + $table->renameColumn('piggy_bank_id', 'piggybank_id'); + } + ); + + // remove soft delete to piggy banks + Schema::table( + 'piggybanks', function (Blueprint $table) { + $table->dropSoftDeletes(); + } + ); } @@ -28,6 +50,19 @@ class ChangesForV322 extends Migration Schema::rename('piggybank_repetitions', 'piggy_bank_repetitions'); Schema::rename('piggybanks', 'piggy_banks'); + // drop an invalid index. + Schema::table( + 'budget_limits', function (Blueprint $table) { + $table->dropIndex('limits_component_id_startdate_repeat_freq_unique'); + } + ); + // recreate it the correct way: + Schema::table( + 'budget_limits', function (Blueprint $table) { + $table->unique(['budget_id', 'startdate', 'repeat_freq'], 'unique_bl_combi'); + } + ); + // rename fields Schema::table( 'piggy_bank_events', function (Blueprint $table) { diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 0b59efcc4c..eb3afeb88b 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -6,7 +6,9 @@ use Carbon\Carbon; use FireflyIII\Database\Account\Account as AccountRepository; use FireflyIII\Database\SwitchUser; use FireflyIII\Database\TransactionJournal\TransactionJournal as JournalRepository; +use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; +use stdClass; // todo add methods to itnerface @@ -80,6 +82,273 @@ class Report implements ReportInterface } + /** + * @param Carbon $date + * + * @return Collection + */ + public function getAccountsForMonth(Carbon $date) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + $list = \Auth::user()->accounts() + ->leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', "accountRole"); + } + ) + ->whereIn('account_types.type', ['Default account', 'Cash account', 'Asset account']) + ->where('active', 1) + ->where( + function ($query) { + $query->where('account_meta.data', '!=', '"sharedExpense"'); + $query->orWhereNull('account_meta.data'); + } + ) + ->get(['accounts.*']); + $list->each( + function (\Account $account) use ($start, $end) { + $account->startBalance = \Steam::balance($account, $start); + $account->endBalance = \Steam::balance($account, $end); + $account->difference = $account->endBalance - $account->startBalance; + } + ); + + return $list; + } + + /** + * @param Carbon $date + * + * @return Collection + */ + public function getBudgetsForMonth(Carbon $date) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + // all budgets + /** @var Collection $budgets */ + $budgets = \Auth::user()->budgets() + ->leftJoin( + 'budget_limits', function (JoinClause $join) use ($date) { + $join->on('budget_limits.budget_id', '=', 'budgets.id')->where('budget_limits.startdate', '=', $date->format('Y-m-d')); + } + ) + ->get(['budgets.*', 'budget_limits.amount as budget_amount']); + $amounts = \Auth::user()->transactionjournals() + ->leftJoin('budget_transaction_journal', 'budget_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id') + ->leftJoin('budgets', 'budget_transaction_journal.budget_id', '=', 'budgets.id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') + ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) + ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->where('transaction_types.type', 'Withdrawal') + ->groupBy('budgets.id') + ->orderBy('name','ASC') + ->get(['budgets.id', 'budgets.name', \DB::Raw('SUM(`transactions`.`amount`) AS `sum`')]); + + + $spentNoBudget = 0; + foreach ($budgets as $budget) { + $budget->spent = 0; + foreach ($amounts as $amount) { + if (intval($budget->id) == intval($amount->id)) { + $budget->spent = floatval($amount->sum) * -1; + } + if (is_null($amount->id)) { + $spentNoBudget = floatval($amount->sum) * -1; + } + } + } + + $noBudget = new stdClass; + $noBudget->id = 0; + $noBudget->name = '(no budget)'; + $noBudget->budget_amount = 0; + $noBudget->spent = $spentNoBudget; + + // also get transfers to expense accounts (which are without a budget, and grouped). + $transfers = $this->getTransfersToSharedAccounts($date); + foreach($transfers as $transfer) { + $noBudget->spent += floatval($transfer->sum) * -1; + } + + + $budgets->push($noBudget); + + return $budgets; + } + + /** + * @param Carbon $date + * @param int $limit + * + * @return Collection + */ + public function getCategoriesForMonth(Carbon $date, $limit = 15) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + // all categories. + $amounts = \Auth::user()->transactionjournals() + ->leftJoin( + 'category_transaction_journal', 'category_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id' + ) + ->leftJoin('categories', 'category_transaction_journal.category_id', '=', 'categories.id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') + ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) + ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->where('transaction_types.type', 'Withdrawal') + ->groupBy('categories.id') + ->orderBy('sum') + ->get(['categories.id', 'categories.name', \DB::Raw('SUM(`transactions`.`amount`) AS `sum`')]); + $spentNoCategory = 0; + foreach ($amounts as $amount) { + if (is_null($amount->id)) { + $spentNoCategory = floatval($amount->sum) * -1; + } + } + $noCategory = new stdClass; + $noCategory->id = 0; + $noCategory->name = '(no category)'; + $noCategory->sum = $spentNoCategory; + $amounts->push($noCategory); + + $return = new Collection; + $bottom = new stdClass(); + $bottom->name = 'Others'; + $bottom->id = 0; + $bottom->sum = 0; + + foreach ($amounts as $index => $entry) { + if ($index < $limit) { + $return->push($entry); + } else { + $bottom->sum += floatval($entry->sum); + } + } + $return->push($bottom); + + return $return; + } + + /** + * @param Carbon $date + * @param int $limit + * + * @return Collection + */ + public function getExpenseGroupedForMonth(Carbon $date, $limit = 15) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + $userId = $this->_accounts->getUser()->id; + + $set = \TransactionJournal:: + leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where( + 'transactions.amount', '>', 0 + ); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'transactions AS otherTransactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'otherTransactions.transaction_journal_id')->where( + 'otherTransactions.amount', '<', 0 + ); + } + ) + ->leftJoin('accounts as otherAccounts', 'otherAccounts.id', '=', 'otherTransactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('otherAccounts.id', '=', 'account_meta.account_id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->where('date', '>=', $start->format('Y-m-d')) + ->where('date', '<=', $end->format('Y-m-d')) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->where('transaction_types.type', 'Withdrawal') + ->whereNull('transaction_journals.deleted_at') + ->where('transaction_journals.user_id', $userId) + ->groupBy('account_id') + ->orderBy('sum', 'ASC') + ->get( + [ + 'transactions.account_id', + 'accounts.name', + \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `sum`') + ] + ); + $transfers = $this->getTransfersToSharedAccounts($date); + // merge $transfers into $set + foreach ($transfers as $transfer) { + if (!is_null($transfer->account_id)) { + $set->push($transfer); + } + } + // sort the list. + $set = $set->sortBy( + function ($entry) { + return floatval($entry->sum); + } + ); + $return = new Collection; + $bottom = new stdClass(); + $bottom->name = 'Others'; + $bottom->account_id = 0; + $bottom->sum = 0; + + $count = 0; + foreach ($set as $entry) { + if ($count < $limit) { + $return->push($entry); + } else { + $bottom->sum += floatval($entry->sum); + } + $count++; + } + + $return->push($bottom); + + return $return; + + } + /** * @param Carbon $date * @param bool $shared @@ -95,15 +364,87 @@ class Report implements ReportInterface $userId = $this->_accounts->getUser()->id; $list = \TransactionJournal::withRelevantData() + ->leftJoin('transactions', 'transaction_journals.id', '=', 'transactions.transaction_journal_id') + ->leftJoin('accounts', 'transactions.account_id', '=', 'accounts.id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) ->transactionTypes(['Deposit']) - ->where('user_id', $userId) - ->orderBy('date','DESC') + ->where('transaction_journals.user_id', $userId) + ->where('transactions.amount', '>', 0) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->orderBy('date', 'ASC') ->before($end)->after($start)->get(['transaction_journals.*']); + // incoming from a shared account: it's profit (income): + $transfers = \TransactionJournal::withRelevantData() + ->leftJoin('transactions', 'transaction_journals.id', '=', 'transactions.transaction_journal_id') + ->leftJoin('accounts', 'transactions.account_id', '=', 'accounts.id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->transactionTypes(['Transfer']) + ->where('transaction_journals.user_id', $userId) + ->where('transactions.amount', '<', 0) + ->where('account_meta.data', '=', '"sharedExpense"') + ->orderBy('date', 'ASC') + ->before($end)->after($start)->get(['transaction_journals.*']); + + $list = $list->merge($transfers); + $list->sort( + function (\TransactionJournal $journal) { + return $journal->date->format('U'); + } + ); return $list; } + /** + * @param Carbon $date + * + * @return Collection + */ + public function getTransfersToSharedAccounts(Carbon $date) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + + return \TransactionJournal:: + leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transactions.transaction_journal_id', '=', 'transaction_journals.id')->where( + 'transactions.amount', '>', 0 + ); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->where('account_meta.data', '"sharedExpense"') + ->where('date', '>=', $start->format('Y-m-d')) + ->where('date', '<=', $end->format('Y-m-d')) + ->where('transaction_types.type', 'Transfer') + ->where('transaction_journals.user_id', \Auth::user()->id) + ->get( + [ + 'transactions.account_id', + 'accounts.name', + \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `sum`') + ] + ); + } + /** * @param Carbon $start * diff --git a/app/lib/FireflyIII/Report/ReportInterface.php b/app/lib/FireflyIII/Report/ReportInterface.php index 7cef787cb4..c3dbc57b03 100644 --- a/app/lib/FireflyIII/Report/ReportInterface.php +++ b/app/lib/FireflyIII/Report/ReportInterface.php @@ -15,21 +15,57 @@ interface ReportInterface /** * @param Carbon $start * @param Carbon $end - * @param int $limit - * - * @return Collection - */ - public function revenueGroupedByAccount(Carbon $start, Carbon $end, $limit = 15); - - /** - * @param Carbon $start - * @param Carbon $end - * @param int $limit + * @param int $limit * * @return Collection */ public function expensesGroupedByAccount(Carbon $start, Carbon $end, $limit = 15); + /** + * @param Carbon $date + * + * @return Collection + */ + public function getBudgetsForMonth(Carbon $date); + + /** + * @param Carbon $date + * + * @return Collection + */ + public function getTransfersToSharedAccounts(Carbon $date); + + /** + * @param Carbon $date + * @param int $limit + * + * @return Collection + */ + public function getCategoriesForMonth(Carbon $date, $limit = 15); + + /** + * @param Carbon $date + * + * @return Collection + */ + public function getAccountsForMonth(Carbon $date); + + /** + * @param Carbon $date + * @param int $limit + * + * @return Collection + */ + public function getExpenseGroupedForMonth(Carbon $date, $limit = 15); + + /** + * @param Carbon $date + * @param bool $shared + * + * @return Collection + */ + public function getIncomeForMonth(Carbon $date, $shared = false); + /** * @param Carbon $start * @@ -44,18 +80,19 @@ interface ReportInterface */ public function listOfYears(Carbon $start); + /** + * @param Carbon $start + * @param Carbon $end + * @param int $limit + * + * @return Collection + */ + public function revenueGroupedByAccount(Carbon $start, Carbon $end, $limit = 15); + /** * @param Carbon $date * * @return array */ public function yearBalanceReport(Carbon $date); - - /** - * @param Carbon $date - * @param bool $shared - * - * @return Collection - */ - public function getIncomeForMonth(Carbon $date, $shared = false); } \ No newline at end of file diff --git a/app/views/list/journals-small.blade.php b/app/views/list/journals-small.blade.php index 31af0154ff..02ea6c7939 100644 --- a/app/views/list/journals-small.blade.php +++ b/app/views/list/journals-small.blade.php @@ -1,10 +1,13 @@ + @foreach($journals as $journal) + - @endforeach + @if(isset($displaySum) && $displaySum === true) + + + + + + @endif
{{{$journal->description}}} + transactions[1]->amount);?> @if($journal->transactiontype->type == 'Withdrawal') {{mf($journal->transactions[1]->amount,false)}} @endif @@ -26,6 +29,12 @@ @endif
Sum{{mf($tableSum)}}
\ No newline at end of file diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 44ff3e529a..796de9cd9c 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -11,7 +11,24 @@
Expenses (top 10)
-
Body
+ + + @foreach($expenses as $expense) + sum);?> + + @if($expense->account_id != 0) + + @else + + @endif + + + @endforeach + + + + +
{{{$expense->name}}}{{{$expense->name}}}{{mf($expense->sum)}}
Sum{{mf($sum)}}
@@ -19,13 +36,69 @@
Budgets
-
Body
+ + + + + + + + + @foreach($budgets as $budget) + spent);?> + + + + + + + @endforeach + + + + +
BudgetEnvelopeSpentLeft
+ @if($budget->id > 0) + {{{$budget->name}}} + @else + {{{$budget->name}}} + @endif + {{mf($budget->budget_amount)}}{{mf($budget->spent,false)}}{{mf(floatval($budget->budget_amount) - floatval($budget->spent))}}
Sum{{mf($sum)}}
+
+ This list does not take in account outgoing transfers to shared accounts. +
Categories
-
Body
+ + + + + + + @foreach($categories as $category) + sum);?> + + + + + @endforeach + + + + +
CategorySpent
+ @if($category->id > 0) + {{{$category->name}}} + @else + {{{$category->name}}} + @endif + {{mf($category->sum,false)}}
Sum{{mf($sum)}}
+
+ This list does not take in account outgoing transfers to shared accounts. +
@@ -33,7 +106,32 @@
Accounts
-
Body
+ + + @foreach($accounts as $account) + startBalance; + $sumEnd += $account->endBalance; + $sumDiff += $account->difference; + ?> + + + + + + + @endforeach + + + + + + +
{{{$account->name}}}{{mf($account->startBalance)}}{{mf($account->endBalance)}}{{mf($account->difference)}}
Sum{{mf($sumStart)}}{{mf($sumEnd)}}{{mf($sumDiff)}}
From 3ba0cf1454695eae2dc9172571fe8e5d8bd5a74d Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 26 Dec 2014 21:14:45 +0100 Subject: [PATCH 14/84] Expanded summary [skip ci] --- app/views/reports/month.blade.php | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 796de9cd9c..ce050cdbed 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -43,9 +43,17 @@ Spent Left - + @foreach($budgets as $budget) - spent);?> + spent); + $sumEnvelope += floatval($budget->budget_amount); + $sumLeft += floatval($budget->budget_amount) - floatval($budget->spent); + ?> @if($budget->id > 0) @@ -60,8 +68,10 @@ @endforeach - Sum - {{mf($sum)}} + Sum + {{mf($sumEnvelope)}} + {{mf($sumSpent)}} + {{mf($sumLeft)}}
From 7a885bfc3c5cb870f7a596e939e03ee008a2945d Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 26 Dec 2014 22:59:13 +0100 Subject: [PATCH 15/84] Fixed various bugs that made tests fail. --- app/lib/FireflyIII/Database/Budget/Budget.php | 11 +++++++---- app/models/Budget.php | 2 +- app/models/BudgetLimit.php | 15 ++++++++------- app/models/Category.php | 2 +- 4 files changed, 17 insertions(+), 13 deletions(-) diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index ad5f8f8ab1..d6df9dbbfc 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -247,9 +247,9 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface { return \LimitRepetition:: leftJoin('budget_limits', 'limit_repetitions.budget_limit_id', '=', 'budget_limits.id') - ->where('limit_repetitions.startdate', $date->format('Y-m-d 00:00:00')) - ->where('budget_limits.budget_id', $budget->id) - ->first(['limit_repetitions.*']); + ->where('limit_repetitions.startdate', $date->format('Y-m-d 00:00:00')) + ->where('budget_limits.budget_id', $budget->id) + ->first(['limit_repetitions.*']); } /** @@ -366,6 +366,9 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface */ public function limitOnStartingOnDate(\Budget $budget, Carbon $date) { - return $budget->budgetLimits()->where('startdate', $date->format('Y-m-d'))->first(); + return $budget->budgetLimits()->where('startdate', $date->format('Y-m-d 00:00:00'))->first(); + + + } } \ No newline at end of file diff --git a/app/models/Budget.php b/app/models/Budget.php index e277b51ca6..f5860dd3cd 100644 --- a/app/models/Budget.php +++ b/app/models/Budget.php @@ -28,7 +28,7 @@ class Budget extends Eloquent */ public function budgetlimits() { - return $this->hasMany('BudgetLimit', 'budget_id'); + return $this->hasMany('BudgetLimit'); } /** diff --git a/app/models/BudgetLimit.php b/app/models/BudgetLimit.php index 684ad1a11e..41887e41ed 100644 --- a/app/models/BudgetLimit.php +++ b/app/models/BudgetLimit.php @@ -1,9 +1,10 @@ 'required|exists:budgets,id', - 'startdate' => 'required|date', - 'amount' => 'numeric|required|min:0.01', - 'repeats' => 'required|boolean', - 'repeat_freq' => 'required|in:daily,weekly,monthly,quarterly,half-year,yearly' + 'budget_id' => 'required|exists:budgets,id', + 'startdate' => 'required|date', + 'amount' => 'numeric|required|min:0.01', + 'repeats' => 'required|boolean', + 'repeat_freq' => 'required|in:daily,weekly,monthly,quarterly,half-year,yearly' ]; @@ -27,7 +28,7 @@ class BudgetLimit extends Eloquent */ public function budget() { - return $this->belongsTo('Budget','budget_id'); + return $this->belongsTo('Budget'); } /** diff --git a/app/models/Category.php b/app/models/Category.php index 782a394585..4c68e41e65 100644 --- a/app/models/Category.php +++ b/app/models/Category.php @@ -36,7 +36,7 @@ class Category extends Eloquent */ public function transactionjournals() { - return $this->belongsToMany('TransactionJournal', 'budget_transaction_journal', 'budget_id'); + return $this->belongsToMany('TransactionJournal', 'category_transaction_journal', 'category_id'); } /** From 84a24f033376118357ad7489725a8b369563b652 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 27 Dec 2014 05:38:33 +0100 Subject: [PATCH 16/84] Something with migrations. --- .../2014_07_17_183717_create_limits_table.php | 22 +++++++++---------- .../2014_12_24_191544_changes_for_v322.php | 13 +++++++++-- 2 files changed, 22 insertions(+), 13 deletions(-) diff --git a/app/database/migrations/2014_07_17_183717_create_limits_table.php b/app/database/migrations/2014_07_17_183717_create_limits_table.php index fced678780..fc39882c7b 100644 --- a/app/database/migrations/2014_07_17_183717_create_limits_table.php +++ b/app/database/migrations/2014_07_17_183717_create_limits_table.php @@ -29,19 +29,19 @@ class CreateLimitsTable extends Migration { Schema::create( 'limits', function (Blueprint $table) { - $table->increments('id'); - $table->timestamps(); - $table->integer('component_id')->unsigned(); - $table->date('startdate'); - $table->decimal('amount', 10, 2); - $table->boolean('repeats'); - $table->enum('repeat_freq', ['daily', 'weekly', 'monthly', 'quarterly', 'half-year', 'yearly']); + $table->increments('id'); + $table->timestamps(); + $table->integer('component_id')->unsigned(); + $table->date('startdate'); + $table->decimal('amount', 10, 2); + $table->boolean('repeats'); + $table->enum('repeat_freq', ['daily', 'weekly', 'monthly', 'quarterly', 'half-year', 'yearly']); - $table->unique(['component_id', 'startdate', 'repeat_freq']); + $table->unique(['component_id', 'startdate', 'repeat_freq'], 'unique_ci_combi'); - // connect component - $table->foreign('component_id')->references('id')->on('components')->onDelete('cascade'); - } + // connect component + $table->foreign('component_id')->references('id')->on('components')->onDelete('cascade'); + } ); } diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 4d400e97b7..5c377f7ec3 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -1,6 +1,7 @@ dropIndex('limits_component_id_startdate_repeat_freq_unique'); + +// try { + //$table->dropUnique('limits_component_id_startdate_repeat_freq_unique'); +// } catch (QueryException $e) { + //$table->dropUnique('unique_ci_combi'); +// } catch (PDOException $e) { +// $table->dropUnique('unique_ci_combi'); +// } + } ); // recreate it the correct way: From 9f23462c42206a50074b5eb05e2b26620f94269a Mon Sep 17 00:00:00 2001 From: James Cole Date: Sat, 27 Dec 2014 17:21:15 +0100 Subject: [PATCH 17/84] Expanded reports. --- app/controllers/ReportController.php | 1 + .../TransactionJournal/TransactionJournal.php | 5 + app/lib/FireflyIII/FF3ServiceProvider.php | 2 + app/lib/FireflyIII/Report/Report.php | 228 +++++++----------- app/lib/FireflyIII/Report/ReportHelper.php | 119 +++++++++ .../Report/ReportHelperInterface.php | 55 +++++ app/lib/FireflyIII/Report/ReportInterface.php | 14 +- app/lib/FireflyIII/Report/ReportQuery.php | 227 +++++++++++++++++ .../Report/ReportQueryInterface.php | 89 +++++++ app/views/reports/month.blade.php | 83 ++++--- 10 files changed, 650 insertions(+), 173 deletions(-) create mode 100644 app/lib/FireflyIII/Report/ReportHelper.php create mode 100644 app/lib/FireflyIII/Report/ReportHelperInterface.php create mode 100644 app/lib/FireflyIII/Report/ReportQuery.php create mode 100644 app/lib/FireflyIII/Report/ReportQueryInterface.php diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index a759ba17cc..86885e978a 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -71,6 +71,7 @@ class ReportController extends BaseController $budgets = $this->_repository->getBudgetsForMonth($date); $categories = $this->_repository->getCategoriesForMonth($date, 10); $accounts = $this->_repository->getAccountsForMonth($date); + $piggyBanks = $this->_repository->getPiggyBanksForMonth($date); return View::make( 'reports.month', diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index f3c8084dae..04da13b06a 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -389,7 +389,12 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData if ($category) { $journal->categories()->sync([$category->id]); } + + return; } + $journal->categories()->sync([]); + + return; } /** diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index b79fcf3053..cf85ed6380 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -96,6 +96,8 @@ class FF3ServiceProvider extends ServiceProvider // reports $this->app->bind('FireflyIII\Report\ReportInterface', 'FireflyIII\Report\Report'); + $this->app->bind('FireflyIII\Report\ReportQueryInterface', 'FireflyIII\Report\ReportQuery'); + $this->app->bind('FireflyIII\Report\ReportHelperInterface', 'FireflyIII\Report\ReportHelper'); // chart $this->app->bind('FireflyIII\Chart\ChartInterface', 'FireflyIII\Chart\Chart'); diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index eb3afeb88b..4dc0986102 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -6,11 +6,12 @@ use Carbon\Carbon; use FireflyIII\Database\Account\Account as AccountRepository; use FireflyIII\Database\SwitchUser; use FireflyIII\Database\TransactionJournal\TransactionJournal as JournalRepository; +use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; use stdClass; -// todo add methods to itnerface +// todo add methods to interface /** * Class Report @@ -25,9 +26,12 @@ class Report implements ReportInterface /** @var AccountRepository */ protected $_accounts; - + /** @var \FireflyIII\Report\ReportHelperInterface */ + protected $_helper; /** @var JournalRepository */ protected $_journals; + /** @var \FireflyIII\Report\ReportQueryInterface */ + protected $_queries; /** * @param AccountRepository $accounts @@ -36,10 +40,15 @@ class Report implements ReportInterface { $this->_accounts = $accounts; $this->_journals = $journals; + $this->_queries = \App::make('FireflyIII\Report\ReportQueryInterface'); + $this->_helper = \App::make('FireflyIII\Report\ReportHelperInterface'); + } /** + * TODO Used in yearly report, so not ready for cleanup. + * * @param Carbon $start * @param Carbon $end * @param int $limit @@ -76,7 +85,7 @@ class Report implements ReportInterface ->where('acm_from.data', '!=', '"sharedExpense"') ->before($end)->after($start) ->where('transaction_journals.user_id', \Auth::user()->id) - ->groupBy('account_id')->orderBy('sum', 'DESC')->limit(15) + ->groupBy('account_id')->orderBy('sum', 'DESC')->limit($limit) ->get(['t_to.account_id as account_id', 'ac_to.name as name', \DB::Raw('SUM(t_to.amount) as `sum`')]); @@ -85,7 +94,7 @@ class Report implements ReportInterface /** * @param Carbon $date * - * @return Collection + * @return array */ public function getAccountsForMonth(Carbon $date) { @@ -93,31 +102,21 @@ class Report implements ReportInterface $start->startOfMonth(); $end = clone $date; $end->endOfMonth(); - $list = \Auth::user()->accounts() - ->leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id') - ->leftJoin( - 'account_meta', function (JoinClause $join) { - $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', "accountRole"); - } - ) - ->whereIn('account_types.type', ['Default account', 'Cash account', 'Asset account']) - ->where('active', 1) - ->where( - function ($query) { - $query->where('account_meta.data', '!=', '"sharedExpense"'); - $query->orWhereNull('account_meta.data'); - } - ) - ->get(['accounts.*']); - $list->each( - function (\Account $account) use ($start, $end) { - $account->startBalance = \Steam::balance($account, $start); - $account->endBalance = \Steam::balance($account, $end); - $account->difference = $account->endBalance - $account->startBalance; - } - ); + $list = $this->_queries->accountList(); + $accounts = []; + /** @var \Account $account */ + foreach ($list as $account) { + $id = intval($account->id); + $accounts[$id] = [ + 'name' => $account->name, + 'startBalance' => \Steam::balance($account, $start), + 'endBalance' => \Steam::balance($account, $end) + ]; - return $list; + $accounts[$id]['difference'] = $accounts[$id]['endBalance'] - $accounts[$id]['startBalance']; + } + + return $accounts; } /** @@ -132,74 +131,29 @@ class Report implements ReportInterface $end = clone $date; $end->endOfMonth(); // all budgets - /** @var Collection $budgets */ - $budgets = \Auth::user()->budgets() - ->leftJoin( - 'budget_limits', function (JoinClause $join) use ($date) { - $join->on('budget_limits.budget_id', '=', 'budgets.id')->where('budget_limits.startdate', '=', $date->format('Y-m-d')); - } - ) - ->get(['budgets.*', 'budget_limits.amount as budget_amount']); - $amounts = \Auth::user()->transactionjournals() - ->leftJoin('budget_transaction_journal', 'budget_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id') - ->leftJoin('budgets', 'budget_transaction_journal.budget_id', '=', 'budgets.id') - ->leftJoin( - 'transactions', function (JoinClause $join) { - $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); - } - ) - ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') - ->leftJoin( - 'account_meta', function (JoinClause $join) { - $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); - } - ) - ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') - ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) - ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) - ->where('account_meta.data', '!=', '"sharedExpense"') - ->where('transaction_types.type', 'Withdrawal') - ->groupBy('budgets.id') - ->orderBy('name','ASC') - ->get(['budgets.id', 'budgets.name', \DB::Raw('SUM(`transactions`.`amount`) AS `sum`')]); + $set = $this->_queries->getAllBudgets($date); + $budgets = $this->_helper->makeArray($set); + $amountSet = $this->_queries->journalsByBudget($start, $end); + $amounts = $this->_helper->makeArray($amountSet); + $combined = $this->_helper->mergeArrays($budgets, $amounts); + $combined[0]['spent'] = isset($combined[0]['spent']) ? $combined[0]['spent'] : 0.0; + $combined[0]['amount'] = isset($combined[0]['amount']) ? $combined[0]['amount'] : 0.0; + $combined[0]['name'] = 'No budget'; - - $spentNoBudget = 0; - foreach ($budgets as $budget) { - $budget->spent = 0; - foreach ($amounts as $amount) { - if (intval($budget->id) == intval($amount->id)) { - $budget->spent = floatval($amount->sum) * -1; - } - if (is_null($amount->id)) { - $spentNoBudget = floatval($amount->sum) * -1; - } - } + // find transactions to shared expense accounts, which are without a budget by default: + $transfers = $this->_queries->sharedExpenses($start, $end); + foreach ($transfers as $transfer) { + $combined[0]['spent'] += floatval($transfer->amount) * -1; } - $noBudget = new stdClass; - $noBudget->id = 0; - $noBudget->name = '(no budget)'; - $noBudget->budget_amount = 0; - $noBudget->spent = $spentNoBudget; - - // also get transfers to expense accounts (which are without a budget, and grouped). - $transfers = $this->getTransfersToSharedAccounts($date); - foreach($transfers as $transfer) { - $noBudget->spent += floatval($transfer->sum) * -1; - } - - - $budgets->push($noBudget); - - return $budgets; + return $combined; } /** * @param Carbon $date * @param int $limit * - * @return Collection + * @return array */ public function getCategoriesForMonth(Carbon $date, $limit = 15) { @@ -208,58 +162,21 @@ class Report implements ReportInterface $end = clone $date; $end->endOfMonth(); // all categories. - $amounts = \Auth::user()->transactionjournals() - ->leftJoin( - 'category_transaction_journal', 'category_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id' - ) - ->leftJoin('categories', 'category_transaction_journal.category_id', '=', 'categories.id') - ->leftJoin( - 'transactions', function (JoinClause $join) { - $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); - } - ) - ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') - ->leftJoin( - 'account_meta', function (JoinClause $join) { - $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); - } - ) - ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') - ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) - ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) - ->where('account_meta.data', '!=', '"sharedExpense"') - ->where('transaction_types.type', 'Withdrawal') - ->groupBy('categories.id') - ->orderBy('sum') - ->get(['categories.id', 'categories.name', \DB::Raw('SUM(`transactions`.`amount`) AS `sum`')]); - $spentNoCategory = 0; - foreach ($amounts as $amount) { - if (is_null($amount->id)) { - $spentNoCategory = floatval($amount->sum) * -1; - } - } - $noCategory = new stdClass; - $noCategory->id = 0; - $noCategory->name = '(no category)'; - $noCategory->sum = $spentNoCategory; - $amounts->push($noCategory); + $result = $this->_queries->journalsByCategory($start, $end); + $categories = $this->_helper->makeArray($result); - $return = new Collection; - $bottom = new stdClass(); - $bottom->name = 'Others'; - $bottom->id = 0; - $bottom->sum = 0; + // all transfers + $result = $this->_queries->sharedExpensesByCategory($start, $end); + $transfers = $this->_helper->makeArray($result); + $merged = $this->_helper->mergeArrays($categories, $transfers); - foreach ($amounts as $index => $entry) { - if ($index < $limit) { - $return->push($entry); - } else { - $bottom->sum += floatval($entry->sum); - } - } - $return->push($bottom); + // sort. + $sorted = $this->_helper->sortNegativeArray($merged); - return $return; + // limit to $limit: + $cut = $this->_helper->limitArray($sorted, $limit); + + return $cut; } /** @@ -314,7 +231,7 @@ class Report implements ReportInterface \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `sum`') ] ); - $transfers = $this->getTransfersToSharedAccounts($date); + $transfers = $this->getTransfersToSharedGroupedByAccounts($date); // merge $transfers into $set foreach ($transfers as $transfer) { if (!is_null($transfer->account_id)) { @@ -409,7 +326,40 @@ class Report implements ReportInterface * * @return Collection */ - public function getTransfersToSharedAccounts(Carbon $date) + public function getPiggyBanksForMonth(Carbon $date) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + + $set = \PiggyBank:: + leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') + ->where('accounts.user_id', \Auth::user()->id) + ->where('repeats', 0) + ->where( + function (Builder $query) use ($start, $end) { + $query->whereNull('piggy_banks.deleted_at'); + $query->orWhere( + function (Builder $query) use ($start, $end) { + $query->whereNotNull('piggy_banks.deleted_at'); + $query->where('piggy_banks.deleted_at', '>=', $start->format('Y-m-d 00:00:00')); + $query->where('piggy_banks.deleted_at', '<=', $end->format('Y-m-d 00:00:00')); + } + ); + } + ) + ->get(['piggy_banks.*']); + + + } + + /** + * @param Carbon $date + * + * @return Collection + */ + public function getTransfersToSharedGroupedByAccounts(Carbon $date) { $start = clone $date; $start->startOfMonth(); @@ -436,6 +386,7 @@ class Report implements ReportInterface ->where('date', '<=', $end->format('Y-m-d')) ->where('transaction_types.type', 'Transfer') ->where('transaction_journals.user_id', \Auth::user()->id) + ->groupBy('accounts.name') ->get( [ 'transactions.account_id', @@ -445,6 +396,7 @@ class Report implements ReportInterface ); } + /** * @param Carbon $start * diff --git a/app/lib/FireflyIII/Report/ReportHelper.php b/app/lib/FireflyIII/Report/ReportHelper.php new file mode 100644 index 0000000000..d6dd6e619f --- /dev/null +++ b/app/lib/FireflyIII/Report/ReportHelper.php @@ -0,0 +1,119 @@ + 'Others', + 'amount' => 0 + ]; + $return = []; + $count = 0; + foreach ($array as $id => $entry) { + if ($count < ($limit - 1)) { + $return[$id] = $entry; + } else { + $others['amount'] += $entry['amount']; + } + + $count++; + } + $return[0] = $others; + + return $return; + + } + + /** + * Turns a collection into an array. Needs the field 'id' for the key, + * and saves only 'name' and 'amount' as a subarray. + * + * @param Collection $collection + * + * @return array + */ + public function makeArray(Collection $collection) + { + $array = []; + foreach ($collection as $entry) { + $entry->spent = isset($entry->spent) ? floatval($entry->spent) : 0.0; + $id = intval($entry->id); + if (isset($array[$id])) { + $array[$id]['amount'] += floatval($entry->amount); + $array[$id]['spent'] += floatval($entry->spent); + } else { + $array[$id] = [ + 'amount' => floatval($entry->amount), + 'spent' => floatval($entry->spent), + 'name' => $entry->name + ]; + } + } + + return $array; + } + + /** + * Merges two of the arrays as defined above. Can't handle more (yet) + * + * @param array $one + * @param array $two + * + * @return array + */ + public function mergeArrays(array $one, array $two) + { + foreach ($two as $id => $value) { + // $otherId also exists in $one: + if (isset($one[$id])) { + $one[$id]['amount'] += $value['amount']; + $one[$id]['spent'] += $value['spent']; + } else { + $one[$id] = $value; + } + } + + return $one; + } + + /** + * Sort an array where all 'amount' keys are negative floats. + * + * @param array $array + * + * @return array + */ + public function sortNegativeArray(array $array) + { + uasort( + $array, function ($left, $right) { + if ($left['amount'] == $right['amount']) { + return 0; + } + + return ($left['amount'] < $right['amount']) ? -1 : 1; + } + ); + + return $array; + } +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportHelperInterface.php b/app/lib/FireflyIII/Report/ReportHelperInterface.php new file mode 100644 index 0000000000..1be77864c7 --- /dev/null +++ b/app/lib/FireflyIII/Report/ReportHelperInterface.php @@ -0,0 +1,55 @@ +accounts() + ->leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', "accountRole"); + } + ) + ->whereIn('account_types.type', ['Default account', 'Cash account', 'Asset account']) + ->where('active', 1) + ->where( + function ($query) { + $query->where('account_meta.data', '!=', '"sharedExpense"'); + $query->orWhereNull('account_meta.data'); + } + ) + ->get(['accounts.*']); + } + + /** + * Gets a list of all budgets and if present, the amount of the current BudgetLimit + * as well + * + * @param Carbon $date + * + * @return Collection + */ + public function getAllBudgets(Carbon $date) + { + return \Auth::user()->budgets() + ->leftJoin( + 'budget_limits', function (JoinClause $join) use ($date) { + $join->on('budget_limits.budget_id', '=', 'budgets.id')->where('budget_limits.startdate', '=', $date->format('Y-m-d')); + } + ) + ->get(['budgets.*', 'budget_limits.amount as amount']); + } + + /** + * Gets a list of expenses grouped by the budget they were filed under. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByBudget(Carbon $start, Carbon $end) + { + return \Auth::user()->transactionjournals() + ->leftJoin('budget_transaction_journal', 'budget_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id') + ->leftJoin('budgets', 'budget_transaction_journal.budget_id', '=', 'budgets.id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') + ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) + ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->where('transaction_types.type', 'Withdrawal') + ->groupBy('budgets.id') + ->orderBy('name', 'ASC') + ->get(['budgets.id', 'budgets.name', \DB::Raw('SUM(`transactions`.`amount`) AS `spent`')]); + } + + /** + * Gets a list of categories and the expenses therein, grouped by the relevant category. + * This result excludes transfers to shared accounts which are expenses, technically. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByCategory(Carbon $start, Carbon $end) + { + return \Auth::user()->transactionjournals() + ->leftJoin( + 'category_transaction_journal', 'category_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id' + ) + ->leftJoin('categories', 'category_transaction_journal.category_id', '=', 'categories.id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '<', 0); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id') + ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) + ->where('transaction_journals.date', '<=', $end->format('Y-m-d')) + ->where('account_meta.data', '!=', '"sharedExpense"') + ->where('transaction_types.type', 'Withdrawal') + ->groupBy('categories.id') + ->orderBy('amount') + ->get(['categories.id', 'categories.name', \DB::Raw('SUM(`transactions`.`amount`) AS `amount`')]); + + } + + /** + * Gets a list of expense accounts and the expenses therein, grouped by that expense account. + * This result excludes transfers to shared accounts which are expenses, technically. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByExpenseAccount(Carbon $start, Carbon $end) + { + } + + /** + * With an equally misleading name, this query returns are transfers to shared accounts. These are considered + * expenses. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function sharedExpenses(Carbon $start, Carbon $end) + { + return \TransactionJournal:: + leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transactions.transaction_journal_id', '=', 'transaction_journals.id')->where( + 'transactions.amount', '>', 0 + ); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->where('account_meta.data', '"sharedExpense"') + ->after($start) + ->before($end) + ->where('transaction_types.type', 'Transfer') + ->where('transaction_journals.user_id', \Auth::user()->id) + ->get( + ['transaction_journals.id', 'transaction_journals.description', 'transactions.account_id', 'accounts.name', + 'transactions.amount'] + ); + + } + + /** + * With a slightly misleading name, this query returns all transfers to shared accounts + * which are technically expenses, since it won't be just your money that gets spend. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function sharedExpensesByCategory(Carbon $start, Carbon $end) + { + return \TransactionJournal:: + leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transactions.transaction_journal_id', '=', 'transaction_journals.id')->where( + 'transactions.amount', '>', 0 + ); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->leftJoin( + 'category_transaction_journal', 'category_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id' + ) + ->leftJoin('categories', 'category_transaction_journal.category_id', '=', 'categories.id') + ->where('account_meta.data', '"sharedExpense"') + ->after($start) + ->before($end) + ->where('transaction_types.type', 'Transfer') + ->where('transaction_journals.user_id', \Auth::user()->id) + ->groupBy('categories.name') + ->get( + [ + 'categories.id', + 'categories.name as name', + \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `amount`') + ] + ); + } +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportQueryInterface.php b/app/lib/FireflyIII/Report/ReportQueryInterface.php new file mode 100644 index 0000000000..fffdb133b4 --- /dev/null +++ b/app/lib/FireflyIII/Report/ReportQueryInterface.php @@ -0,0 +1,89 @@ +getName()) }}
-
+
Income
@include('list.journals-small',['journals' => $income])
-
+
Expenses (top 10)
@@ -31,6 +31,31 @@
+
+
+
Sums
+ transactions[1]->amount); + } + ?> + + + + + + + + + + + + + +
In{{mf($in)}}
Out{{mf($sum)}}
Difference{{mf($sum + $in)}}
+
+
@@ -48,23 +73,23 @@ $sumEnvelope = 0; $sumLeft = 0; ?> - @foreach($budgets as $budget) + @foreach($budgets as $id => $budget) spent); - $sumEnvelope += floatval($budget->budget_amount); - $sumLeft += floatval($budget->budget_amount) - floatval($budget->spent); + $sumSpent += $budget['spent']; + $sumEnvelope += $budget['amount']; + $sumLeft += $budget['amount'] + $budget['spent']; ?> - @if($budget->id > 0) - {{{$budget->name}}} + @if($id > 0) + {{{$budget['name']}}} @else - {{{$budget->name}}} + {{{$budget['name']}}} @endif - {{mf($budget->budget_amount)}} - {{mf($budget->spent,false)}} - {{mf(floatval($budget->budget_amount) - floatval($budget->spent))}} + {{mf($budget['amount'])}} + {{mf($budget['spent'],false)}} + {{mf($budget['amount'] + $budget['spent'])}} @endforeach @@ -74,9 +99,6 @@ {{mf($sumLeft)}} -
- This list does not take in account outgoing transfers to shared accounts. -
@@ -88,17 +110,17 @@ Spent - @foreach($categories as $category) - sum);?> + @foreach($categories as $id => $category) + - @if($category->id > 0) - {{{$category->name}}} + @if($id > 0) + {{{$category['name']}}} @else - {{{$category->name}}} + {{{$category['name']}}} @endif - {{mf($category->sum,false)}} + {{mf($category['amount'],false)}} @endforeach @@ -106,9 +128,6 @@ {{mf($sum)}} -
- This list does not take in account outgoing transfers to shared accounts. -
@@ -122,17 +141,17 @@ $sumEnd = 0; $sumDiff = 0; ?> - @foreach($accounts as $account) + @foreach($accounts as $id => $account) startBalance; - $sumEnd += $account->endBalance; - $sumDiff += $account->difference; + $sumStart += $account['startBalance']; + $sumEnd += $account['endBalance']; + $sumDiff += $account['difference']; ?> - {{{$account->name}}} - {{mf($account->startBalance)}} - {{mf($account->endBalance)}} - {{mf($account->difference)}} + {{{$account['name']}}} + {{mf($account['startBalance'])}} + {{mf($account['endBalance'])}} + {{mf($account['difference'])}} @endforeach From 4944b233b6787cf50a3f912565ac6d9b6d197504 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 28 Dec 2014 08:54:53 +0100 Subject: [PATCH 18/84] Greatly expanded report functionality. --- app/controllers/ReportController.php | 94 +++----- app/lib/FireflyIII/Report/Report.php | 206 ++++++------------ app/lib/FireflyIII/Report/ReportHelper.php | 21 ++ .../Report/ReportHelperInterface.php | 9 + app/lib/FireflyIII/Report/ReportInterface.php | 53 ++--- app/lib/FireflyIII/Report/ReportQuery.php | 178 ++++++++++++++- .../Report/ReportQueryInterface.php | 70 ++++-- app/models/TransactionJournal.php | 4 +- app/routes.php | 1 + app/views/reports/budget.blade.php | 129 +++++++++++ app/views/reports/index.blade.php | 15 ++ app/views/reports/month.blade.php | 14 +- app/views/reports/unbalanced.blade.php | 56 ----- app/views/reports/year.blade.php | 6 +- 14 files changed, 540 insertions(+), 316 deletions(-) create mode 100644 app/views/reports/budget.blade.php delete mode 100644 app/views/reports/unbalanced.blade.php diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 86885e978a..35a5588929 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -1,6 +1,5 @@ _accounts = $accounts; $this->_journals = $journals; $this->_repository = $repository; + /** @var \FireflyIII\Database\Budget\Budget _budgets */ + $this->_budgets = App::make('FireflyIII\Database\Budget\Budget'); + View::share('title', 'Reports'); View::share('mainTitleIcon', 'fa-line-chart'); } + /** + * @param string $year + * @param string $month + * + * @return \Illuminate\View\View + */ + public function budget($year = '2014', $month = '1') + { + try { + new Carbon($year . '-' . $month . '-01'); + } catch (Exception $e) { + View::make('error')->with('message', 'Invalid date'); + } + $date = new Carbon($year . '-' . $month . '-01'); + $dayEarly = clone $date; + $dayEarly = $dayEarly->subDay(); + $accounts = $this->_repository->getAccountListBudgetOverview($date); + $budgets = $this->_repository->getBudgetsForMonth($date); + + return View::make('reports.budget', compact('accounts', 'budgets', 'dayEarly')); + + } + /** * */ @@ -62,7 +83,7 @@ class ReportController extends BaseController } catch (Exception $e) { View::make('error')->with('message', 'Invalid date'); } - $date = new Carbon($year . '-' . $month . '-01'); + $date = new Carbon($year . '-' . $month . '-01'); $subTitle = 'Report for ' . $date->format('F Y'); $subTitleIcon = 'fa-calendar'; $displaySum = true; // to show sums in report. @@ -79,61 +100,6 @@ class ReportController extends BaseController ); } - /** - * @param $year - * @param $month - * - * @return \Illuminate\View\View - */ - public function unbalanced($year, $month) - { - try { - new Carbon($year . '-' . $month . '-01'); - } catch (Exception $e) { - App::abort(500); - } - $start = new Carbon($year . '-' . $month . '-01'); - $end = clone $start; - $title = 'Reports'; - $subTitle = 'Unbalanced transactions in ' . $start->format('F Y'); - $mainTitleIcon = 'fa-line-chart'; - $subTitleIcon = 'fa-bar-chart'; - $end->endOfMonth(); - - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $journalRepository */ - $journalRepository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - $journals = $journalRepository->getInDateRange($start, $end); - - $withdrawals = $journals->filter( - function (TransactionJournal $journal) { - $relations = $journal->transactiongroups()->where('relation', 'balance')->count(); - $budgets = $journal->budgets()->count(); - $type = $journal->transactionType->type; - if ($type == 'Withdrawal' && $budgets == 0 && $relations == 0) { - return $journal; - } - - return null; - } - ); - $deposits = $journals->filter( - function (TransactionJournal $journal) { - $relations = $journal->transactiongroups()->where('relation', 'balance')->count(); - $budgets = $journal->budgets()->count(); - $type = $journal->transactionType->type; - if ($type == 'Deposit' && $budgets == 0 && $relations == 0) { - return $journal; - } - - return null; - } - ); - - $journals = $withdrawals->merge($deposits); - - return View::make('reports.unbalanced', compact('start', 'end', 'title', 'subTitle', 'subTitleIcon', 'mainTitleIcon', 'journals')); - } - /** * @param $year * diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 4dc0986102..f7ef12dfea 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -9,7 +9,6 @@ use FireflyIII\Database\TransactionJournal\TransactionJournal as JournalReposito use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; -use stdClass; // todo add methods to interface @@ -47,8 +46,6 @@ class Report implements ReportInterface } /** - * TODO Used in yearly report, so not ready for cleanup. - * * @param Carbon $start * @param Carbon $end * @param int $limit @@ -57,37 +54,49 @@ class Report implements ReportInterface */ public function expensesGroupedByAccount(Carbon $start, Carbon $end, $limit = 15) { - return \TransactionJournal:: - leftJoin( - 'transactions as t_from', function ($join) { - $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); - } - ) - ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') - ->leftJoin( - 'account_meta as acm_from', function ($join) { - $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); - } - ) - ->leftJoin( - 'transactions as t_to', function ($join) { - $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); - } - ) - ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') - ->leftJoin( - 'account_meta as acm_to', function ($join) { - $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); - } - ) - ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') - ->where('transaction_types.type', 'Withdrawal') - ->where('acm_from.data', '!=', '"sharedExpense"') - ->before($end)->after($start) - ->where('transaction_journals.user_id', \Auth::user()->id) - ->groupBy('account_id')->orderBy('sum', 'DESC')->limit($limit) - ->get(['t_to.account_id as account_id', 'ac_to.name as name', \DB::Raw('SUM(t_to.amount) as `sum`')]); + $result = $this->_queries->journalsByExpenseAccount($start, $end); + $array = $this->_helper->makeArray($result); + $limited = $this->_helper->limitArray($array, $limit); + return $limited; + + } + + /** + * Gets all the users shared and non-shared accounts combined with various meta-data + * to display the amount of money spent that month compared to what's been spend within + * budgets. + * + * @param Carbon $date + * + * @return Collection + */ + public function getAccountListBudgetOverview(Carbon $date) + { + $start = clone $date; + $start->startOfMonth(); + $end = clone $date; + $end->endOfMonth(); + $start->subDay(); + $accounts = $this->_queries->getAllAccounts($start, $end); + + $accounts->each( + function (\Account $account) use ($start, $end) { + $budgets = $this->_queries->getBudgetSummary($account, $start, $end); + $balancedAmount = $this->_queries->balancedTransactionsSum($account, $start, $end); + $array = []; + foreach ($budgets as $budget) { + $id = intval($budget->id); + $data = $budget->toArray(); + $array[$id] = $data; + } + $account->budgetInformation = $array; + $account->balancedAmount = $balancedAmount; + + } + ); + + return $accounts; } @@ -191,78 +200,27 @@ class Report implements ReportInterface $start->startOfMonth(); $end = clone $date; $end->endOfMonth(); - $userId = $this->_accounts->getUser()->id; - $set = \TransactionJournal:: - leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') - ->leftJoin( - 'transactions', function (JoinClause $join) { - $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where( - 'transactions.amount', '>', 0 - ); - } - ) - ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') - ->leftJoin( - 'transactions AS otherTransactions', function (JoinClause $join) { - $join->on('transaction_journals.id', '=', 'otherTransactions.transaction_journal_id')->where( - 'otherTransactions.amount', '<', 0 - ); - } - ) - ->leftJoin('accounts as otherAccounts', 'otherAccounts.id', '=', 'otherTransactions.account_id') - ->leftJoin( - 'account_meta', function (JoinClause $join) { - $join->on('otherAccounts.id', '=', 'account_meta.account_id')->where('account_meta.name', '=', 'accountRole'); - } - ) - ->where('date', '>=', $start->format('Y-m-d')) - ->where('date', '<=', $end->format('Y-m-d')) - ->where('account_meta.data', '!=', '"sharedExpense"') - ->where('transaction_types.type', 'Withdrawal') - ->whereNull('transaction_journals.deleted_at') - ->where('transaction_journals.user_id', $userId) - ->groupBy('account_id') - ->orderBy('sum', 'ASC') - ->get( - [ - 'transactions.account_id', - 'accounts.name', - \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `sum`') - ] - ); - $transfers = $this->getTransfersToSharedGroupedByAccounts($date); - // merge $transfers into $set + $set = $this->_queries->journalsByExpenseAccount($start, $end); + $expenses = $this->_helper->makeArray($set); + + $alt = $this->_queries->sharedExpenses($start, $end); + $transfers = $this->_helper->makeArray($alt); + + $expenses[-1] = [ + 'amount' => 0, + 'name' => 'Transfers to shared', + 'spent' => 0 + ]; + foreach ($transfers as $transfer) { - if (!is_null($transfer->account_id)) { - $set->push($transfer); - } - } - // sort the list. - $set = $set->sortBy( - function ($entry) { - return floatval($entry->sum); - } - ); - $return = new Collection; - $bottom = new stdClass(); - $bottom->name = 'Others'; - $bottom->account_id = 0; - $bottom->sum = 0; - - $count = 0; - foreach ($set as $entry) { - if ($count < $limit) { - $return->push($entry); - } else { - $bottom->sum += floatval($entry->sum); - } - $count++; + $expenses[-1]['amount'] += $transfer['amount']; } - $return->push($bottom); + $expenses = $this->_helper->sortArray($expenses); + $limited = $this->_helper->limitArray($expenses, $limit); - return $return; + return $limited; } @@ -280,8 +238,8 @@ class Report implements ReportInterface $end->endOfMonth(); $userId = $this->_accounts->getUser()->id; - $list = \TransactionJournal::withRelevantData() - ->leftJoin('transactions', 'transaction_journals.id', '=', 'transactions.transaction_journal_id') + + $list = \TransactionJournal::leftJoin('transactions', 'transaction_journals.id', '=', 'transactions.transaction_journal_id') ->leftJoin('accounts', 'transactions.account_id', '=', 'accounts.id') ->leftJoin( 'account_meta', function (JoinClause $join) { @@ -291,6 +249,7 @@ class Report implements ReportInterface ->transactionTypes(['Deposit']) ->where('transaction_journals.user_id', $userId) ->where('transactions.amount', '>', 0) + ->where('transaction_journals.user_id', \Auth::user()->id) ->where('account_meta.data', '!=', '"sharedExpense"') ->orderBy('date', 'ASC') ->before($end)->after($start)->get(['transaction_journals.*']); @@ -354,49 +313,6 @@ class Report implements ReportInterface } - /** - * @param Carbon $date - * - * @return Collection - */ - public function getTransfersToSharedGroupedByAccounts(Carbon $date) - { - $start = clone $date; - $start->startOfMonth(); - $end = clone $date; - $end->endOfMonth(); - - return \TransactionJournal:: - leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') - ->leftJoin( - 'transactions', function (JoinClause $join) { - $join->on('transactions.transaction_journal_id', '=', 'transaction_journals.id')->where( - 'transactions.amount', '>', 0 - ); - } - ) - ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') - ->leftJoin( - 'account_meta', function (JoinClause $join) { - $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); - } - ) - ->where('account_meta.data', '"sharedExpense"') - ->where('date', '>=', $start->format('Y-m-d')) - ->where('date', '<=', $end->format('Y-m-d')) - ->where('transaction_types.type', 'Transfer') - ->where('transaction_journals.user_id', \Auth::user()->id) - ->groupBy('accounts.name') - ->get( - [ - 'transactions.account_id', - 'accounts.name', - \DB::Raw('SUM(`transactions`.`amount`) * -1 AS `sum`') - ] - ); - } - - /** * @param Carbon $start * diff --git a/app/lib/FireflyIII/Report/ReportHelper.php b/app/lib/FireflyIII/Report/ReportHelper.php index d6dd6e619f..6d82ae261a 100644 --- a/app/lib/FireflyIII/Report/ReportHelper.php +++ b/app/lib/FireflyIII/Report/ReportHelper.php @@ -116,4 +116,25 @@ class ReportHelper implements ReportHelperInterface return $array; } + + /** + * Sort an array where all 'amount' keys are positive floats. + * + * @param array $array + * + * @return array + */ + public function sortArray(array $array) { + uasort( + $array, function ($left, $right) { + if ($left['amount'] == $right['amount']) { + return 0; + } + + return ($left['amount'] < $right['amount']) ? 1 : -1; + } + ); + return $array; + + } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportHelperInterface.php b/app/lib/FireflyIII/Report/ReportHelperInterface.php index 1be77864c7..762af0bee6 100644 --- a/app/lib/FireflyIII/Report/ReportHelperInterface.php +++ b/app/lib/FireflyIII/Report/ReportHelperInterface.php @@ -52,4 +52,13 @@ interface ReportHelperInterface */ public function sortNegativeArray(array $array); + /** + * Sort an array where all 'amount' keys are positive floats. + * + * @param array $array + * + * @return array + */ + public function sortArray(array $array); + } \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportInterface.php b/app/lib/FireflyIII/Report/ReportInterface.php index e72cb2948b..73658f652f 100644 --- a/app/lib/FireflyIII/Report/ReportInterface.php +++ b/app/lib/FireflyIII/Report/ReportInterface.php @@ -22,33 +22,15 @@ interface ReportInterface public function expensesGroupedByAccount(Carbon $start, Carbon $end, $limit = 15); /** + * Gets all the users shared and non-shared accounts combined with various meta-data + * to display the amount of money spent that month compared to what's been spend within + * budgets. + * * @param Carbon $date * * @return Collection */ - public function getBudgetsForMonth(Carbon $date); - - /** - * @param Carbon $date - * - * @return Collection - */ - public function getTransfersToSharedGroupedByAccounts(Carbon $date); - - /** - * @param Carbon $date - * - * @return Collection - */ - public function getPiggyBanksForMonth(Carbon $date); - - /** - * @param Carbon $date - * @param int $limit - * - * @return array - */ - public function getCategoriesForMonth(Carbon $date, $limit = 15); + public function getAccountListBudgetOverview(Carbon $date); /** * @param Carbon $date @@ -57,14 +39,28 @@ interface ReportInterface */ public function getAccountsForMonth(Carbon $date); + /** + * @param Carbon $date + * + * @return Collection + */ + public function getBudgetsForMonth(Carbon $date); + + /** + * @param Carbon $date + * @param int $limit + * + * @return array + */ + public function getCategoriesForMonth(Carbon $date, $limit = 15); + /** * @param Carbon $date * @param int $limit * * @return Collection */ - public function getExpenseGroupedForMonth(Carbon $date, $limit = 15); - + public function getExpenseGroupedForMonth(Carbon $date, $limit = 15); /** * @param Carbon $date @@ -74,6 +70,13 @@ interface ReportInterface */ public function getIncomeForMonth(Carbon $date, $shared = false); + /** + * @param Carbon $date + * + * @return Collection + */ + public function getPiggyBanksForMonth(Carbon $date); + /** * @param Carbon $start * diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 6cb7049c41..199827e7bb 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -3,6 +3,7 @@ namespace FireflyIII\Report; use Carbon\Carbon; +use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; @@ -30,7 +31,7 @@ class ReportQuery implements ReportQueryInterface ->whereIn('account_types.type', ['Default account', 'Cash account', 'Asset account']) ->where('active', 1) ->where( - function ($query) { + function (Builder $query) { $query->where('account_meta.data', '!=', '"sharedExpense"'); $query->orWhereNull('account_meta.data'); } @@ -38,6 +39,114 @@ class ReportQuery implements ReportQueryInterface ->get(['accounts.*']); } + /** + * This method will get a list of all expenses in a certain time period that have no budget + * and are balanced by a transfer to make up for it. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function balancedTransactionsList(\Account $account, Carbon $start, Carbon $end) + { + + $set = \TransactionJournal:: + leftJoin('transaction_group_transaction_journal', 'transaction_group_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id') + ->leftJoin( + 'transaction_group_transaction_journal as otherFromGroup', function (JoinClause $join) { + $join->on('otherFromGroup.transaction_group_id', '=', 'transaction_group_transaction_journal.transaction_group_id') + ->on('otherFromGroup.transaction_journal_id', '!=', 'transaction_journals.id'); + } + ) + ->leftJoin('transaction_journals as otherJournals', 'otherJournals.id', '=', 'otherFromGroup.transaction_journal_id') + ->leftJoin('transaction_types', 'transaction_types.id', '=', 'otherJournals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('amount', '>', 0); + } + ) + ->leftJoin('budget_transaction_journal', 'budget_transaction_journal.transaction_journal_id', '=', 'otherJournals.id') + ->before($end) + ->after($start) + ->where('transaction_types.type', 'Withdrawal') + ->where('transaction_journals.user_id', \Auth::user()->id) + ->whereNull('budget_transaction_journal.budget_id') + ->whereNull('transaction_journals.deleted_at') + ->whereNull('otherJournals.deleted_at') + ->where('transactions.account_id', $account->id) + ->whereNotNull('transaction_group_transaction_journal.transaction_group_id') + ->groupBy('transaction_journals.id') + ->get( + [ + 'transaction_journals.id as transferId', + 'transaction_journals.description as transferDescription', + 'transaction_group_transaction_journal.transaction_group_id as groupId', + 'otherFromGroup.transaction_journal_id as expenseId', + 'otherJournals.description as expenseDescription', + 'transactions.amount' + ] + ); + + return $set; + } + + /** + * This method will sum up all expenses in a certain time period that have no budget + * and are balanced by a transfer to make up for it. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return float + */ + public function balancedTransactionsSum(\Account $account, Carbon $start, Carbon $end) + { + $list = $this->balancedTransactionsList($account, $start, $end); + $sum = 0; + foreach ($list as $entry) { + $sum += floatval($entry->amount); + } + + return $sum; + } + + /** + * Get a users accounts combined with various meta-data related to the start and end date. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function getAllAccounts(Carbon $start, Carbon $end) + { + $set = \Auth::user()->accounts() + ->accountTypeIn(['Default account', 'Asset account', 'Cash account']) + ->leftJoin( + 'account_meta', function (JoinClause $join) { + $join->on('account_meta.account_id', '=', 'accounts.id')->where('account_meta.name', '=', 'accountRole'); + } + ) + ->where( + function (Builder $query) { + $query->where('account_meta.data', '!=', '"sharedExpense"'); + $query->orWhereNull('account_meta.data'); + } + ) + ->get(['accounts.*']); + $set->each( + function (\Account $account) use ($start, $end) { + $account->startBalance = \Steam::balance($account, $start); + $account->endBalance = \Steam::balance($account, $end); + } + ); + + return $set; + } + /** * Gets a list of all budgets and if present, the amount of the current BudgetLimit * as well @@ -57,6 +166,41 @@ class ReportQuery implements ReportQueryInterface ->get(['budgets.*', 'budget_limits.amount as amount']); } + /** + * Grabs a summary of all expenses grouped by budget, related to the account. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return mixed + */ + public function getBudgetSummary(\Account $account, Carbon $start, Carbon $end) + { + $set = \TransactionJournal:: + leftJoin('budget_transaction_journal', 'budget_transaction_journal.transaction_journal_id', '=', 'transaction_journals.id') + ->leftJoin('budgets', 'budgets.id', '=', 'budget_transaction_journal.budget_id') + ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transactions.transaction_journal_id', '=', 'transaction_journals.id')->where('transactions.amount', '<', 0); + } + ) + ->leftJoin('accounts', 'accounts.id', '=', 'transactions.account_id') + ->before($end) + ->after($start) + ->where('accounts.id', $account->id) + ->where('transaction_journals.user_id', \Auth::user()->id) + ->where('transaction_types.type', 'Withdrawal') + ->groupBy('budgets.id') + ->orderBy('budgets.id') + ->get(['budgets.id', 'budgets.name', \DB::Raw('SUM(`transactions`.`amount`) as `amount`')]); + + return $set; + + + } + /** * Gets a list of expenses grouped by the budget they were filed under. * @@ -140,6 +284,38 @@ class ReportQuery implements ReportQueryInterface */ public function journalsByExpenseAccount(Carbon $start, Carbon $end) { + return \TransactionJournal:: + leftJoin( + 'transactions as t_from', function ($join) { + $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); + } + ) + ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') + ->leftJoin( + 'account_meta as acm_from', function ($join) { + $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); + } + ) + ->leftJoin( + 'transactions as t_to', function ($join) { + $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); + } + ) + ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') + ->leftJoin( + 'account_meta as acm_to', function ($join) { + $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->where('transaction_types.type', 'Withdrawal') + ->where('acm_from.data', '!=', '"sharedExpense"') + ->before($end) + ->after($start) + ->where('transaction_journals.user_id', \Auth::user()->id) + ->groupBy('t_to.account_id') + ->orderBy('amount', 'DESC') + ->get(['t_to.account_id as id', 'ac_to.name as name', \DB::Raw('SUM(t_to.amount) as `amount`')]); } /** diff --git a/app/lib/FireflyIII/Report/ReportQueryInterface.php b/app/lib/FireflyIII/Report/ReportQueryInterface.php index fffdb133b4..a33d6ee8ad 100644 --- a/app/lib/FireflyIII/Report/ReportQueryInterface.php +++ b/app/lib/FireflyIII/Report/ReportQueryInterface.php @@ -22,14 +22,49 @@ interface ReportQueryInterface public function accountList(); /** - * Gets a list of expenses grouped by the budget they were filed under. + * Get a users accounts combined with various meta-data related to the start and end date. * * @param Carbon $start * @param Carbon $end * * @return Collection */ - public function journalsByBudget(Carbon $start, Carbon $end); + public function getAllAccounts(Carbon $start, Carbon $end); + + /** + * Grabs a summary of all expenses grouped by budget, related to the account. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return mixed + */ + public function getBudgetSummary(\Account $account, Carbon $start, Carbon $end); + + /** + * This method will sum up all expenses in a certain time period that have no budget + * and are balanced by a transfer to make up for it. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return float + */ + public function balancedTransactionsSum(\Account $account, Carbon $start, Carbon $end); + + /** + * This method will get a list of all expenses in a certain time period that have no budget + * and are balanced by a transfer to make up for it. + * + * @param \Account $account + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function balancedTransactionsList(\Account $account, Carbon $start, Carbon $end); /** * Gets a list of all budgets and if present, the amount of the current BudgetLimit @@ -41,6 +76,16 @@ interface ReportQueryInterface */ public function getAllBudgets(Carbon $date); + /** + * Gets a list of expenses grouped by the budget they were filed under. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByBudget(Carbon $start, Carbon $end); + /** * Gets a list of categories and the expenses therein, grouped by the relevant category. * This result excludes transfers to shared accounts which are expenses, technically. @@ -63,6 +108,16 @@ interface ReportQueryInterface */ public function journalsByExpenseAccount(Carbon $start, Carbon $end); + /** + * With an equally misleading name, this query returns are transfers to shared accounts. These are considered + * expenses. + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function sharedExpenses(Carbon $start, Carbon $end); /** * With a slightly misleading name, this query returns all transfers to shared accounts @@ -75,15 +130,4 @@ interface ReportQueryInterface */ public function sharedExpensesByCategory(Carbon $start, Carbon $end); - /** - * With an equally misleading name, this query returns are transfers to shared accounts. These are considered - * expenses. - * - * @param Carbon $start - * @param Carbon $end - * - * @return Collection - */ - public function sharedExpenses(Carbon $start, Carbon $end); - } \ No newline at end of file diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index 2703bb4fe1..ee9cd336c7 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -111,7 +111,7 @@ class TransactionJournal extends Eloquent */ public function scopeAfter($query, Carbon $date) { - return $query->where('date', '>=', $date->format('Y-m-d')); + return $query->where('transaction_journals.date', '>=', $date->format('Y-m-d 00:00:00')); } /** @@ -122,7 +122,7 @@ class TransactionJournal extends Eloquent */ public function scopeBefore($query, Carbon $date) { - return $query->where('date', '<=', $date->format('Y-m-d')); + return $query->where('transaction_journals.date', '<=', $date->format('Y-m-d 00:00:00')); } /** diff --git a/app/routes.php b/app/routes.php index b12d653354..17368d6878 100644 --- a/app/routes.php +++ b/app/routes.php @@ -248,6 +248,7 @@ Route::group( Route::get('/reports', ['uses' => 'ReportController@index', 'as' => 'reports.index']); Route::get('/reports/{year}', ['uses' => 'ReportController@year', 'as' => 'reports.year']); Route::get('/reports/{year}/{month}', ['uses' => 'ReportController@month', 'as' => 'reports.month']); + Route::get('/reports/budget/{year}/{month}', ['uses' => 'ReportController@budget', 'as' => 'reports.budget']); #Route::get('/reports/unbalanced/{year}/{month}', ['uses' => 'ReportController@unbalanced', 'as' => 'reports.unbalanced']); // reminder controller diff --git a/app/views/reports/budget.blade.php b/app/views/reports/budget.blade.php new file mode 100644 index 0000000000..3d37060fd6 --- /dev/null +++ b/app/views/reports/budget.blade.php @@ -0,0 +1,129 @@ +@extends('layouts.default') +@section('content') +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +
+
+ + + + + + + + @foreach($accounts as $account) + + + + + + + @endforeach +
AccountStart of monthCurrent balanceSpent
{{{$account->name}}}{{mf($account->startBalance)}}{{mf($account->endBalance)}}{{mf($account->startBalance - $account->endBalance,false)}}
+
+
+
+
+ + + + + + @foreach($accounts as $account) + + id] = 0; + ?> + @endforeach + + + @foreach($budgets as $id => $budget) + + + + + @foreach($accounts as $account) + @if(isset($account->budgetInformation[$id])) + + budgetInformation[$id]['amount']); + $accountSums[$account->id] += floatval($account->budgetInformation[$id]['amount']); + ?> + @else + + @endif + @endforeach + + + + @endforeach + + + @foreach($accounts as $account) + @if(isset($account->budgetInformation[0])) + + @else + + @endif + @endforeach + + + + + @foreach($accounts as $account) + + @endforeach + + + + + + @foreach($accounts as $account) + id] += $account->balancedAmount; + ?> + @if(isset($account->budgetInformation[0])) + + @else + + @endif + @endforeach + + + + + @foreach($accounts as $account) + + @endforeach + + + + + @foreach($accounts as $account) + + @endforeach + + + +
Budgets{{{$account->name}}} + Left in budget +
{{{$budget['name']}}}{{mf($budget['amount'])}}{{mf($account->budgetInformation[$id]['amount'])}}{{mf(0)}}{{mf($budget['amount'] + $budget['spent'])}}{{mf($budget['amount'] + $spent)}}
Without budget{{mf($account->budgetInformation[0]['amount'])}}{{mf(0)}} 
Balanced by transfers{{mf($account->balancedAmount)}} 
Left unbalanced{{mf($account->budgetInformation[0]['amount'] + $account->balancedAmount)}}{{mf(0)}} 
Sum{{mf($accountSums[$account->id])}} 
Expected balance{{mf($account->startBalance + $accountSums[$account->id])}} 
+
+
+@stop \ No newline at end of file diff --git a/app/views/reports/index.blade.php b/app/views/reports/index.blade.php index 8a0e83fe81..80e6180f36 100644 --- a/app/views/reports/index.blade.php +++ b/app/views/reports/index.blade.php @@ -31,5 +31,20 @@
+ +
+
+
+ Budget reports +
+
+ +
+
+
@stop \ No newline at end of file diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 693e39ac7c..2075b3f6a3 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -13,15 +13,15 @@
Expenses (top 10)
- @foreach($expenses as $expense) - sum);?> + @foreach($expenses as $id => $expense) + - @if($expense->account_id != 0) - + @if($id > 0) + @else - + @endif - + @endforeach @@ -51,7 +51,7 @@ - +
{{{$expense->name}}}{{{$expense['name']}}}{{{$expense->name}}}{{{$expense['name']}}}{{mf($expense->sum)}}{{mf($expense['amount'])}}
Difference{{mf($sum + $in)}}{{mf($in - $sum)}}
diff --git a/app/views/reports/unbalanced.blade.php b/app/views/reports/unbalanced.blade.php deleted file mode 100644 index 74aa64fe41..0000000000 --- a/app/views/reports/unbalanced.blade.php +++ /dev/null @@ -1,56 +0,0 @@ -@extends('layouts.default') -@section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $start) }} -@if(count($journals) == 0) -
-
-

Everything accounted for.

-
-
-@endif -@if(count($journals) > 0) -
-
-

Withdrawals

-
-
- -
- @foreach($journals as $journal) -
-
-
- @if($journal->transactiontype->type == 'Withdrawal') - - @endif - @if($journal->transactiontype->type == 'Deposit') - - @endif - @if($journal->transactiontype->type == 'Transfer') - - @endif - @if($journal->transactiontype->type == 'Opening balance') - - @endif - {{{$journal->description}}} -
-
-

Spent {{mf($journal->getAmount())}}

-

No counter transaction!

-

- Add counter transaction -

-
-
-
- @endforeach -
-@endif -@stop -@section('scripts') - -{{HTML::script('assets/javascript/firefly/reports.js')}} -{{HTML::script('assets/javascript/firefly/related-manager.js')}} -@stop \ No newline at end of file diff --git a/app/views/reports/year.blade.php b/app/views/reports/year.blade.php index 827f988a37..db918e2718 100644 --- a/app/views/reports/year.blade.php +++ b/app/views/reports/year.blade.php @@ -84,10 +84,10 @@ Expenses
- @foreach($groupedExpenses as $expense) + @foreach($groupedExpenses as $id => $expense) - - + + @endforeach
{{{$expense->name}}}{{mf(floatval($expense->sum)*-1)}}{{{$expense['name']}}}{{mf(floatval($expense['amount'])*-1)}}
From 87fbf9c1a57895ddd9785175835942481cf48b92 Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 28 Dec 2014 09:00:22 +0100 Subject: [PATCH 19/84] Added the ability to see cash accounts. [skip ci] --- app/breadcrumbs.php | 3 +++ app/controllers/AccountController.php | 2 ++ app/routes.php | 7 +++++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index c4b3d78c15..78a73fff86 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -31,6 +31,9 @@ Breadcrumbs::register( case 'Asset account': $what = 'asset'; break; + case 'Cash account': + $what = 'cash'; + break; case 'Expense account': case 'Beneficiary account': $what = 'expense'; diff --git a/app/controllers/AccountController.php b/app/controllers/AccountController.php index 190df02a5d..74fbe299ca 100644 --- a/app/controllers/AccountController.php +++ b/app/controllers/AccountController.php @@ -28,6 +28,7 @@ class AccountController extends BaseController 'Expense account' => 'expense', 'Beneficiary account' => 'expense', 'Revenue account' => 'revenue', + 'Cash account' => 'cash', ]; /** @var array */ @@ -36,6 +37,7 @@ class AccountController extends BaseController 'asset' => 'fa-money', 'Asset account' => 'fa-money', 'Default account' => 'fa-money', + 'Cash account' => 'fa-money', 'expense' => 'fa-shopping-cart', 'Expense account' => 'fa-shopping-cart', 'Beneficiary account' => 'fa-shopping-cart', diff --git a/app/routes.php b/app/routes.php index 17368d6878..a519bfa7cb 100644 --- a/app/routes.php +++ b/app/routes.php @@ -6,8 +6,11 @@ Route::bind( function ($value, $route) { if (Auth::check()) { $account = Account:: - leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id')->where('account_types.editable', 1)->where('accounts.id', $value) - ->where('user_id', Auth::user()->id)->first(['accounts.*']); + leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id') + ->where('account_types.editable', 1) + ->where('accounts.id', $value) + ->where('user_id', Auth::user()->id) + ->first(['accounts.*']); if ($account) { return $account; } From 40892ccfa7fec0bee1aa90238a114d6c18a0eb7d Mon Sep 17 00:00:00 2001 From: James Cole Date: Sun, 28 Dec 2014 18:03:35 +0100 Subject: [PATCH 20/84] Some small updates to piggy banks. --- app/breadcrumbs.php | 347 +++++++++--------- app/controllers/ReportController.php | 4 +- .../Database/PiggyBank/PiggyBank.php | 2 +- app/views/piggy_banks/index.blade.php | 94 ++--- app/views/reports/budget.blade.php | 2 +- app/views/reports/month.blade.php | 2 +- 6 files changed, 230 insertions(+), 221 deletions(-) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 78a73fff86..1753d137c5 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -17,350 +17,353 @@ Breadcrumbs::register( // accounts Breadcrumbs::register( 'accounts.index', function (Generator $breadcrumbs, $what) { - $breadcrumbs->parent('home'); - $breadcrumbs->push(ucfirst($what) . ' accounts', route('accounts.index', $what)); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push(ucfirst($what) . ' accounts', route('accounts.index', $what)); +} ); Breadcrumbs::register( 'accounts.show', function (Generator $breadcrumbs, \Account $account) { - switch ($account->accountType->type) { - default: - throw new FireflyException('Cannot handle account type "' . e($account->accountType->type) . '"'); - break; - case 'Default account': - case 'Asset account': - $what = 'asset'; - break; - case 'Cash account': - $what = 'cash'; - break; - case 'Expense account': - case 'Beneficiary account': - $what = 'expense'; - break; - case 'Revenue account': - $what = 'revenue'; - break; - } - $breadcrumbs->parent('accounts.index', $what); - $breadcrumbs->push($account->name, route('accounts.show', $account->id)); + switch ($account->accountType->type) { + default: + throw new FireflyException('Cannot handle account type "' . e($account->accountType->type) . '"'); + break; + case 'Default account': + case 'Asset account': + $what = 'asset'; + break; + case 'Cash account': + $what = 'cash'; + break; + case 'Expense account': + case 'Beneficiary account': + $what = 'expense'; + break; + case 'Revenue account': + $what = 'revenue'; + break; } + $breadcrumbs->parent('accounts.index', $what); + $breadcrumbs->push($account->name, route('accounts.show', $account->id)); +} ); Breadcrumbs::register( 'accounts.delete', function (Generator $breadcrumbs, \Account $account) { - $breadcrumbs->parent('accounts.show', $account); - $breadcrumbs->push('Delete ' . $account->name, route('accounts.delete', $account->id)); - } + $breadcrumbs->parent('accounts.show', $account); + $breadcrumbs->push('Delete ' . $account->name, route('accounts.delete', $account->id)); +} ); Breadcrumbs::register( 'accounts.edit', function (Generator $breadcrumbs, \Account $account) { - $breadcrumbs->parent('accounts.show', $account); - $breadcrumbs->push('Edit ' . $account->name, route('accounts.edit', $account->id)); - } + $breadcrumbs->parent('accounts.show', $account); + $breadcrumbs->push('Edit ' . $account->name, route('accounts.edit', $account->id)); +} ); // budgets. Breadcrumbs::register( 'budgets.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Budgets', route('budgets.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Budgets', route('budgets.index')); +} ); Breadcrumbs::register( 'budgets.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('budgets.index'); - $breadcrumbs->push('Create new budget', route('budgets.create')); - } + $breadcrumbs->parent('budgets.index'); + $breadcrumbs->push('Create new budget', route('budgets.create')); +} ); Breadcrumbs::register( 'budgets.edit', function (Generator $breadcrumbs, Budget $budget) { - $breadcrumbs->parent('budgets.show', $budget); - $breadcrumbs->push('Edit ' . $budget->name, route('budgets.edit', $budget->id)); - } + $breadcrumbs->parent('budgets.show', $budget); + $breadcrumbs->push('Edit ' . $budget->name, route('budgets.edit', $budget->id)); +} ); Breadcrumbs::register( 'budgets.delete', function (Generator $breadcrumbs, Budget $budget) { - $breadcrumbs->parent('budgets.show', $budget); - $breadcrumbs->push('Delete ' . $budget->name, route('budgets.delete', $budget->id)); - } + $breadcrumbs->parent('budgets.show', $budget); + $breadcrumbs->push('Delete ' . $budget->name, route('budgets.delete', $budget->id)); +} ); Breadcrumbs::register( 'budgets.show', function (Generator $breadcrumbs, Budget $budget, LimitRepetition $repetition = null) { - $breadcrumbs->parent('budgets.index'); - $breadcrumbs->push($budget->name, route('budgets.show', $budget->id)); - if (!is_null($repetition)) { - $breadcrumbs->push( - DateKit::periodShow($repetition->startdate, $repetition->budgetlimit->repeat_freq), route('budgets.show', $budget->id, $repetition->id) - ); - } + $breadcrumbs->parent('budgets.index'); + $breadcrumbs->push($budget->name, route('budgets.show', $budget->id)); + if (!is_null($repetition)) { + $breadcrumbs->push( + DateKit::periodShow($repetition->startdate, $repetition->budgetlimit->repeat_freq), route('budgets.show', $budget->id, $repetition->id) + ); } +} ); // categories Breadcrumbs::register( 'categories.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Categories', route('categories.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Categories', route('categories.index')); +} ); Breadcrumbs::register( 'categories.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('categories.index'); - $breadcrumbs->push('Create new category', route('categories.create')); - } + $breadcrumbs->parent('categories.index'); + $breadcrumbs->push('Create new category', route('categories.create')); +} ); Breadcrumbs::register( 'categories.edit', function (Generator $breadcrumbs, Category $category) { - $breadcrumbs->parent('categories.show', $category); - $breadcrumbs->push('Edit ' . $category->name, route('categories.edit', $category->id)); - } + $breadcrumbs->parent('categories.show', $category); + $breadcrumbs->push('Edit ' . $category->name, route('categories.edit', $category->id)); +} ); Breadcrumbs::register( 'categories.delete', function (Generator $breadcrumbs, Category $category) { - $breadcrumbs->parent('categories.show', $category); - $breadcrumbs->push('Delete ' . $category->name, route('categories.delete', $category->id)); - } + $breadcrumbs->parent('categories.show', $category); + $breadcrumbs->push('Delete ' . $category->name, route('categories.delete', $category->id)); +} ); Breadcrumbs::register( 'categories.show', function (Generator $breadcrumbs, Category $category) { - $breadcrumbs->parent('categories.index'); - $breadcrumbs->push($category->name, route('categories.show', $category->id)); + $breadcrumbs->parent('categories.index'); + $breadcrumbs->push($category->name, route('categories.show', $category->id)); - } +} ); // piggy banks Breadcrumbs::register( 'piggyBanks.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Piggy banks', route('piggyBanks.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Piggy banks', route('piggyBanks.index')); +} ); Breadcrumbs::register( 'piggyBanks.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('piggyBanks.index'); - $breadcrumbs->push('Create new piggy bank', route('piggyBanks.create')); - } + $breadcrumbs->parent('piggyBanks.index'); + $breadcrumbs->push('Create new piggy bank', route('piggyBanks.create')); +} ); Breadcrumbs::register( 'piggyBanks.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('piggyBanks.show', $piggyBank); - $breadcrumbs->push('Edit ' . $piggyBank->name, route('piggyBanks.edit', $piggyBank->id)); - } + $breadcrumbs->parent('piggyBanks.show', $piggyBank); + $breadcrumbs->push('Edit ' . $piggyBank->name, route('piggyBanks.edit', $piggyBank->id)); +} ); Breadcrumbs::register( 'piggyBanks.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('piggyBanks.show', $piggyBank); - $breadcrumbs->push('Delete ' . $piggyBank->name, route('piggyBanks.delete', $piggyBank->id)); - } + $breadcrumbs->parent('piggyBanks.show', $piggyBank); + $breadcrumbs->push('Delete ' . $piggyBank->name, route('piggyBanks.delete', $piggyBank->id)); +} ); Breadcrumbs::register( 'piggyBanks.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('piggyBanks.index'); - $breadcrumbs->push($piggyBank->name, route('piggyBanks.show', $piggyBank->id)); + $breadcrumbs->parent('piggyBanks.index'); + $breadcrumbs->push($piggyBank->name, route('piggyBanks.show', $piggyBank->id)); - } +} ); // preferences Breadcrumbs::register( 'preferences', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Preferences', route('preferences')); + $breadcrumbs->parent('home'); + $breadcrumbs->push('Preferences', route('preferences')); - } +} ); // profile Breadcrumbs::register( 'profile', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Profile', route('profile')); + $breadcrumbs->parent('home'); + $breadcrumbs->push('Profile', route('profile')); - } +} ); Breadcrumbs::register( 'change-password', function (Generator $breadcrumbs) { - $breadcrumbs->parent('profile'); - $breadcrumbs->push('Change your password', route('change-password')); + $breadcrumbs->parent('profile'); + $breadcrumbs->push('Change your password', route('change-password')); - } +} ); // recurring transactions Breadcrumbs::register( 'recurring.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Recurring transactions', route('recurring.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Recurring transactions', route('recurring.index')); +} ); Breadcrumbs::register( 'recurring.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('recurring.index'); - $breadcrumbs->push('Create new recurring transaction', route('recurring.create')); - } + $breadcrumbs->parent('recurring.index'); + $breadcrumbs->push('Create new recurring transaction', route('recurring.create')); +} ); Breadcrumbs::register( 'recurring.edit', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.show', $recurring); - $breadcrumbs->push('Edit ' . $recurring->name, route('recurring.edit', $recurring->id)); - } + $breadcrumbs->parent('recurring.show', $recurring); + $breadcrumbs->push('Edit ' . $recurring->name, route('recurring.edit', $recurring->id)); +} ); Breadcrumbs::register( 'recurring.delete', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.show', $recurring); - $breadcrumbs->push('Delete ' . $recurring->name, route('recurring.delete', $recurring->id)); - } + $breadcrumbs->parent('recurring.show', $recurring); + $breadcrumbs->push('Delete ' . $recurring->name, route('recurring.delete', $recurring->id)); +} ); Breadcrumbs::register( 'recurring.show', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.index'); - $breadcrumbs->push($recurring->name, route('recurring.show', $recurring->id)); + $breadcrumbs->parent('recurring.index'); + $breadcrumbs->push($recurring->name, route('recurring.show', $recurring->id)); - } +} ); // reminders Breadcrumbs::register( 'reminders.show', function (Generator $breadcrumbs, Reminder $reminder) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Reminder #' . $reminder->id, route('reminders.show', $reminder->id)); + $breadcrumbs->parent('home'); + $breadcrumbs->push('Reminder #' . $reminder->id, route('reminders.show', $reminder->id)); - } +} ); // repeated expenses Breadcrumbs::register( 'repeated.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Repeated expenses', route('repeated.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Repeated expenses', route('repeated.index')); +} ); Breadcrumbs::register( 'repeated.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('repeated.index'); - $breadcrumbs->push('Create new repeated expense', route('repeated.create')); - } + $breadcrumbs->parent('repeated.index'); + $breadcrumbs->push('Create new repeated expense', route('repeated.create')); +} ); Breadcrumbs::register( 'repeated.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('repeated.show', $piggyBank); - $breadcrumbs->push('Edit ' . $piggyBank->name, route('repeated.edit', $piggyBank->id)); - } + $breadcrumbs->parent('repeated.show', $piggyBank); + $breadcrumbs->push('Edit ' . $piggyBank->name, route('repeated.edit', $piggyBank->id)); +} ); Breadcrumbs::register( 'repeated.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('repeated.show', $piggyBank); - $breadcrumbs->push('Delete ' . $piggyBank->name, route('repeated.delete', $piggyBank->id)); - } + $breadcrumbs->parent('repeated.show', $piggyBank); + $breadcrumbs->push('Delete ' . $piggyBank->name, route('repeated.delete', $piggyBank->id)); +} ); Breadcrumbs::register( 'repeated.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { - $breadcrumbs->parent('repeated.index'); - $breadcrumbs->push($piggyBank->name, route('repeated.show', $piggyBank->id)); + $breadcrumbs->parent('repeated.index'); + $breadcrumbs->push($piggyBank->name, route('repeated.show', $piggyBank->id)); - } +} ); // reports Breadcrumbs::register( 'reports.index', function (Generator $breadcrumbs) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Reports', route('reports.index')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Reports', route('reports.index')); +} ); Breadcrumbs::register( 'reports.year', function (Generator $breadcrumbs, Carbon $date) { - $breadcrumbs->parent('reports.index'); - $breadcrumbs->push($date->format('Y'), route('reports.year', $date->format('Y'))); - } + $breadcrumbs->parent('reports.index'); + $breadcrumbs->push($date->format('Y'), route('reports.year', $date->format('Y'))); +} ); + Breadcrumbs::register( - 'reports.budgets', function (Generator $breadcrumbs, Carbon $date) { - $breadcrumbs->parent('reports.index'); - $breadcrumbs->push('Budgets in ' . $date->format('F Y'), route('reports.budgets', $date->format('Y'))); - } + 'reports.month', function (Generator $breadcrumbs, Carbon $date) { + $breadcrumbs->parent('reports.index'); + $breadcrumbs->push('Monthly report for ' . $date->format('F Y'), route('reports.month', $date)); +} ); + Breadcrumbs::register( - 'reports.unbalanced', function (Generator $breadcrumbs, Carbon $date) { - $breadcrumbs->parent('reports.index'); - $breadcrumbs->push('Unbalanced transactions in ' . $date->format('F Y'), route('reports.unbalanced', $date->format('Y'))); - } + 'reports.budget', function (Generator $breadcrumbs, Carbon $date) { + $breadcrumbs->parent('reports.index'); + $breadcrumbs->push('Budget report for ' . $date->format('F Y'), route('reports.budget', $date)); +} ); + // search Breadcrumbs::register( 'search', function (Generator $breadcrumbs, $query) { - $breadcrumbs->parent('home'); - $breadcrumbs->push('Search for "' . e($query) . '"', route('search')); - } + $breadcrumbs->parent('home'); + $breadcrumbs->push('Search for "' . e($query) . '"', route('search')); +} ); // transactions Breadcrumbs::register( 'transactions.index', function (Generator $breadcrumbs, $what) { - $breadcrumbs->parent('home'); + $breadcrumbs->parent('home'); - switch ($what) { - case 'expenses': - case 'withdrawal': - $subTitle = 'Expenses'; - break; - case 'revenue': - case 'deposit': - $subTitle = 'Revenue, income and deposits'; - break; - case 'transfer': - case 'transfers': - $subTitle = 'Transfers'; - break; - case 'opening balance': - $subTitle = 'Opening balances'; - break; - default: - throw new FireflyException('Cannot handle $what "'.e($what).'" in bread crumbs'); - } - - $breadcrumbs->push($subTitle, route('transactions.index', $what)); + switch ($what) { + case 'expenses': + case 'withdrawal': + $subTitle = 'Expenses'; + break; + case 'revenue': + case 'deposit': + $subTitle = 'Revenue, income and deposits'; + break; + case 'transfer': + case 'transfers': + $subTitle = 'Transfers'; + break; + case 'opening balance': + $subTitle = 'Opening balances'; + break; + default: + throw new FireflyException('Cannot handle $what "' . e($what) . '" in bread crumbs'); } + + $breadcrumbs->push($subTitle, route('transactions.index', $what)); +} ); Breadcrumbs::register( 'transactions.create', function (Generator $breadcrumbs, $what) { - $breadcrumbs->parent('transactions.index', $what); - $breadcrumbs->push('Create new ' . $what, route('transactions.create', $what)); - } + $breadcrumbs->parent('transactions.index', $what); + $breadcrumbs->push('Create new ' . $what, route('transactions.create', $what)); +} ); Breadcrumbs::register( 'transactions.edit', function (Generator $breadcrumbs, TransactionJournal $journal) { - $breadcrumbs->parent('transactions.show', $journal); - $breadcrumbs->push('Edit ' . $journal->description, route('transactions.edit', $journal ->id)); - } + $breadcrumbs->parent('transactions.show', $journal); + $breadcrumbs->push('Edit ' . $journal->description, route('transactions.edit', $journal->id)); +} ); Breadcrumbs::register( 'transactions.delete', function (Generator $breadcrumbs, TransactionJournal $journal) { - $breadcrumbs->parent('transactions.show', $journal); - $breadcrumbs->push('Delete ' . $journal->description, route('transactions.delete', $journal->id)); - } + $breadcrumbs->parent('transactions.show', $journal); + $breadcrumbs->push('Delete ' . $journal->description, route('transactions.delete', $journal->id)); +} ); Breadcrumbs::register( 'transactions.show', function (Generator $breadcrumbs, TransactionJournal $journal) { - $breadcrumbs->parent('transactions.index', strtolower($journal->transactionType->type)); - $breadcrumbs->push($journal->description, route('transactions.show', $journal->id)); + $breadcrumbs->parent('transactions.index', strtolower($journal->transactionType->type)); + $breadcrumbs->push($journal->description, route('transactions.show', $journal->id)); - } +} ); \ No newline at end of file diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 35a5588929..100da8cbce 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -52,7 +52,7 @@ class ReportController extends BaseController $accounts = $this->_repository->getAccountListBudgetOverview($date); $budgets = $this->_repository->getBudgetsForMonth($date); - return View::make('reports.budget', compact('accounts', 'budgets', 'dayEarly')); + return View::make('reports.budget', compact('date', 'accounts', 'budgets', 'dayEarly')); } @@ -96,7 +96,7 @@ class ReportController extends BaseController return View::make( 'reports.month', - compact('accounts', 'categories', 'budgets', 'expenses', 'subTitle', 'displaySum', 'subTitleIcon', 'income') + compact('date', 'accounts', 'categories', 'budgets', 'expenses', 'subTitle', 'displaySum', 'subTitleIcon', 'income') ); } diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index 796aa17272..594e5ad75b 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -206,7 +206,7 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface */ public function get() { - return $this->getUser()->piggyBanks()->where('repeats', 0)->get(); + return $this->getUser()->piggyBanks()->where('repeats', 0)->orderBy('name')->get(); } /** diff --git a/app/views/piggy_banks/index.blade.php b/app/views/piggy_banks/index.blade.php index 6279dcd1d6..79c05a28b4 100644 --- a/app/views/piggy_banks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -1,60 +1,66 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +@foreach($piggyBanks as $piggyBank)
- @foreach($piggyBanks as $piggyBank) -
-
-
- {{{$piggyBank->name}}} -
-
-
-
- {{mf($piggyBank->savedSoFar,true)}} -
-
-
-
percentage == 100) - class="progress-bar progress-bar-success" - @else - class="progress-bar progress-bar-info" - @endif - role="progressbar" aria-valuenow="{{$piggyBank->percentage}}" aria-valuemin="0" aria-valuemax="100" style="min-width: 40px;width: {{$piggyBank->percentage}}%;"> - {{$piggyBank->percentage}}% -
-
-
-
- {{mf($piggyBank->targetamount,true)}} +
+
+
+ {{{$piggyBank->name}}} +
+
+
+ +
+
+ @if($piggyBank->leftToSave > 0) + + @endif +
-
-
-
- @if($piggyBank->leftToSave > 0) - - @endif - -
+ +
+
+ +
-
-
- - -
-
-
- @if($piggyBank->leftToSave > 0) - {{mf($piggyBank->leftToSave)}} +
+ +
+ {{mf($piggyBank->savedSoFar,true)}} +
+ +
+
+
percentage == 100) + class="progress-bar progress-bar-success" + @else + class="progress-bar progress-bar-info" @endif + role="progressbar" aria-valuenow="{{$piggyBank->percentage}}" aria-valuemin="0" aria-valuemax="100" style="min-width: 40px;width: {{$piggyBank->percentage}}%;"> + {{$piggyBank->percentage}}% +
+ +
+ {{mf($piggyBank->targetamount,true)}} +
+ +
+ @if($piggyBank->leftToSave > 0) + {{mf($piggyBank->leftToSave)}} + @endif +
- @endforeach +
+
+@endforeach +
diff --git a/app/views/reports/budget.blade.php b/app/views/reports/budget.blade.php index 3d37060fd6..359eb13628 100644 --- a/app/views/reports/budget.blade.php +++ b/app/views/reports/budget.blade.php @@ -1,6 +1,6 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $date) }}
diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 2075b3f6a3..ec0e3a22ca 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -1,6 +1,6 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $date) }}
From 75f86462e2794a6322e8bc8ef9b4b29959c36e3a Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 29 Dec 2014 20:28:17 +0100 Subject: [PATCH 21/84] All code for issue #38. --- app/breadcrumbs.php | 30 +-- app/controllers/BillController.php | 205 ++++++++++++++++++ app/controllers/GoogleChartController.php | 16 +- app/controllers/RecurringController.php | 205 ------------------ .../2014_12_24_191544_changes_for_v322.php | 102 ++++++++- app/database/seeds/TestContentSeeder.php | 58 ++--- app/lib/FireflyIII/Chart/Chart.php | 12 +- app/lib/FireflyIII/Chart/ChartInterface.php | 2 +- .../Bill.php} | 64 +++--- .../Database/Bill/BillInterface.php | 41 ++++ .../RecurringTransactionInterface.php | 41 ---- .../TransactionJournal/TransactionJournal.php | 4 +- .../FireflyIII/Event/TransactionJournal.php | 14 +- .../{RecurringTransaction.php => Bill.php} | 14 +- app/models/TransactionJournal.php | 6 +- app/models/User.php | 4 +- app/routes.php | 30 +-- .../{recurring => bills}/create.blade.php | 6 +- .../{recurring => bills}/delete.blade.php | 6 +- app/views/{recurring => bills}/edit.blade.php | 10 +- .../{recurring => bills}/index.blade.php | 2 +- app/views/{recurring => bills}/show.blade.php | 28 +-- app/views/index.blade.php | 4 +- .../{recurring.blade.php => bills.blade.php} | 8 +- app/views/list/journals-full.blade.php | 10 +- app/views/partials/menu.blade.php | 10 +- app/views/reports/month.blade.php | 2 +- public/assets/javascript/firefly/bills.js | 7 + public/assets/javascript/firefly/index.js | 2 +- public/assets/javascript/firefly/recurring.js | 14 -- ...trollerCest.php => BillControllerCest.php} | 96 ++++---- .../functional/GoogleChartControllerCest.php | 18 +- 32 files changed, 573 insertions(+), 498 deletions(-) create mode 100644 app/controllers/BillController.php delete mode 100644 app/controllers/RecurringController.php rename app/lib/FireflyIII/Database/{RecurringTransaction/RecurringTransaction.php => Bill/Bill.php} (78%) create mode 100644 app/lib/FireflyIII/Database/Bill/BillInterface.php delete mode 100644 app/lib/FireflyIII/Database/RecurringTransaction/RecurringTransactionInterface.php rename app/models/{RecurringTransaction.php => Bill.php} (88%) rename app/views/{recurring => bills}/create.blade.php (91%) rename app/views/{recurring => bills}/delete.blade.php (83%) rename app/views/{recurring => bills}/edit.blade.php (80%) rename app/views/{recurring => bills}/index.blade.php (91%) rename app/views/{recurring => bills}/show.blade.php (75%) rename app/views/list/{recurring.blade.php => bills.blade.php} (80%) create mode 100644 public/assets/javascript/firefly/bills.js delete mode 100644 public/assets/javascript/firefly/recurring.js rename tests/functional/{RecurringControllerCest.php => BillControllerCest.php} (66%) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 1753d137c5..68d1e10a5f 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -195,37 +195,37 @@ Breadcrumbs::register( } ); -// recurring transactions +// bills Breadcrumbs::register( - 'recurring.index', function (Generator $breadcrumbs) { + 'bills.index', function (Generator $breadcrumbs) { $breadcrumbs->parent('home'); - $breadcrumbs->push('Recurring transactions', route('recurring.index')); + $breadcrumbs->push('Bills', route('bills.index')); } ); Breadcrumbs::register( - 'recurring.create', function (Generator $breadcrumbs) { - $breadcrumbs->parent('recurring.index'); - $breadcrumbs->push('Create new recurring transaction', route('recurring.create')); + 'bills.create', function (Generator $breadcrumbs) { + $breadcrumbs->parent('bills.index'); + $breadcrumbs->push('Create new bill', route('bills.create')); } ); Breadcrumbs::register( - 'recurring.edit', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.show', $recurring); - $breadcrumbs->push('Edit ' . $recurring->name, route('recurring.edit', $recurring->id)); + 'bills.edit', function (Generator $breadcrumbs, Bill $bill) { + $breadcrumbs->parent('bills.show', $bill); + $breadcrumbs->push('Edit ' . $bill->name, route('bills.edit', $bill->id)); } ); Breadcrumbs::register( - 'recurring.delete', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.show', $recurring); - $breadcrumbs->push('Delete ' . $recurring->name, route('recurring.delete', $recurring->id)); + 'bills.delete', function (Generator $breadcrumbs, Bill $bill) { + $breadcrumbs->parent('bills.show', $bill); + $breadcrumbs->push('Delete ' . $bill->name, route('bills.delete', $bill->id)); } ); Breadcrumbs::register( - 'recurring.show', function (Generator $breadcrumbs, RecurringTransaction $recurring) { - $breadcrumbs->parent('recurring.index'); - $breadcrumbs->push($recurring->name, route('recurring.show', $recurring->id)); + 'bills.show', function (Generator $breadcrumbs, Bill $bill) { + $breadcrumbs->parent('bills.index'); + $breadcrumbs->push($bill->name, route('bills.show', $bill->id)); } ); diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php new file mode 100644 index 0000000000..3ea9810eb9 --- /dev/null +++ b/app/controllers/BillController.php @@ -0,0 +1,205 @@ +_repository = $repository; + + View::share('title', 'Bills'); + View::share('mainTitleIcon', 'fa-rotate-right'); + } + + /** + * @return $this + */ + public function create() + { + $periods = \Config::get('firefly.periods_to_text'); + + return View::make('bills.create')->with('periods', $periods)->with('subTitle', 'Create new'); + } + + /** + * @param Bill $bill + * + * @return $this + */ + public function delete(Bill $bill) + { + return View::make('bills.delete')->with('bill', $bill)->with( + 'subTitle', 'Delete "' . $bill->name . '"' + ); + } + + /** + * @param Bill $bill + * + * @return \Illuminate\Http\RedirectResponse + */ + public function destroy(Bill $bill) + { + $this->_repository->destroy($bill); + Session::flash('success', 'The bill was deleted.'); + + return Redirect::route('bills.index'); + + } + + /** + * @param Bill $bill + * + * @return $this + */ + public function edit(Bill $bill) + { + $periods = \Config::get('firefly.periods_to_text'); + + return View::make('bills.edit')->with('periods', $periods)->with('bill', $bill)->with( + 'subTitle', 'Edit "' . $bill->name . '"' + ); + } + + /** + * @return $this + */ + public function index() + { + $bills = $this->_repository->get(); + + return View::make('bills.index', compact('bills')); + } + + /** + * @param Bill $bill + * + * @return mixed + */ + public function rescan(Bill $bill) + { + if (intval($bill->active) == 0) { + Session::flash('warning', 'Inactive bills cannot be scanned.'); + + return Redirect::intended('/'); + } + + $this->_repository->scanEverything($bill); + + Session::flash('success', 'Rescanned everything.'); + + return Redirect::intended('/'); + } + + /** + * @param Bill $bill + * + * @return mixed + */ + public function show(Bill $bill) + { + $journals = $bill->transactionjournals()->withRelevantData()->orderBy('date', 'DESC')->get(); + $hideBill = true; + + + return View::make('bills.show', compact('journals', 'hideBills'))->with('bill', $bill)->with( + 'subTitle', $bill->name + ); + } + + /** + * @return $this + * @throws FireflyException + */ + public function store() + { + $data = Input::all(); + $data['user_id'] = Auth::user()->id; + + + // always validate: + $messages = $this->_repository->validate($data); + + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not store bill: ' . $messages['errors']->first()); + } + + // return to create screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('bills.create')->withInput(); + } + + // store: + $this->_repository->store($data); + Session::flash('success', 'Bill "' . e($data['name']) . '" stored.'); + if ($data['post_submit_action'] == 'store') { + return Redirect::route('bills.index'); + } + + return Redirect::route('bills.create')->withInput(); + + } + + /** + * @param Bill $bill + * + * @return $this + * @throws FireflyException + */ + public function update(Bill $bill) + { + $data = Input::except('_token'); + $data['active'] = isset($data['active']) ? 1 : 0; + $data['automatch'] = isset($data['automatch']) ? 1 : 0; + $data['user_id'] = Auth::user()->id; + + // always validate: + $messages = $this->_repository->validate($data); + + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not update bill: ' . $messages['errors']->first()); + } + + // return to update screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('bills.edit', $bill->id)->withInput(); + } + + // update + $this->_repository->update($bill, $data); + Session::flash('success', 'Bill "' . e($data['name']) . '" updated.'); + + // go back to list + if ($data['post_submit_action'] == 'update') { + return Redirect::route('bills.index'); + } + + // go back to update screen. + return Redirect::route('bills.edit', $bill->id)->withInput(['post_submit_action' => 'return_to_edit']); + + } +} \ No newline at end of file diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index fcb2c8884b..58c3a9dfb7 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -334,11 +334,11 @@ class GoogleChartController extends BaseController } /** - * @param RecurringTransaction $recurring + * @param Bill $bill * * @return \Illuminate\Http\JsonResponse */ - public function recurringOverview(RecurringTransaction $recurring) + public function billOverview(Bill $bill) { $this->_chart->addColumn('Date', 'date'); @@ -347,7 +347,7 @@ class GoogleChartController extends BaseController $this->_chart->addColumn('Current entry', 'number'); // get first transaction or today for start: - $first = $recurring->transactionjournals()->orderBy('date', 'ASC')->first(); + $first = $bill->transactionjournals()->orderBy('date', 'ASC')->first(); if ($first) { $start = $first->date; } else { @@ -355,15 +355,15 @@ class GoogleChartController extends BaseController } $end = new Carbon; while ($start <= $end) { - $result = $recurring->transactionjournals()->before($end)->after($start)->first(); + $result = $bill->transactionjournals()->before($end)->after($start)->first(); if ($result) { $amount = $result->getAmount(); } else { $amount = 0; } unset($result); - $this->_chart->addRow(clone $start, $recurring->amount_max, $recurring->amount_min, $amount); - $start = DateKit::addPeriod($start, $recurring->repeat_freq, 0); + $this->_chart->addRow(clone $start, $bill->amount_max, $bill->amount_min, $amount); + $start = DateKit::addPeriod($start, $bill->repeat_freq, 0); } $this->_chart->generate(); @@ -378,14 +378,14 @@ class GoogleChartController extends BaseController * @return \Illuminate\Http\JsonResponse * @throws \FireflyIII\Exception\FireflyException */ - public function recurringTransactionsOverview() + public function billsOverview() { $paid = ['items' => [], 'amount' => 0]; $unpaid = ['items' => [], 'amount' => 0]; $this->_chart->addColumn('Name', 'string'); $this->_chart->addColumn('Amount', 'number'); - $set = $this->_repository->getRecurringSummary($this->_start, $this->_end); + $set = $this->_repository->getBillsSummary($this->_start, $this->_end); foreach ($set as $entry) { if (intval($entry->journalId) == 0) { diff --git a/app/controllers/RecurringController.php b/app/controllers/RecurringController.php deleted file mode 100644 index 4b7f094dd7..0000000000 --- a/app/controllers/RecurringController.php +++ /dev/null @@ -1,205 +0,0 @@ -_repository = $repository; - - View::share('title', 'Recurring transactions'); - View::share('mainTitleIcon', 'fa-rotate-right'); - } - - /** - * @return $this - */ - public function create() - { - $periods = \Config::get('firefly.periods_to_text'); - - return View::make('recurring.create')->with('periods', $periods)->with('subTitle', 'Create new'); - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return $this - */ - public function delete(RecurringTransaction $recurringTransaction) - { - return View::make('recurring.delete')->with('recurringTransaction', $recurringTransaction)->with( - 'subTitle', 'Delete "' . $recurringTransaction->name . '"' - ); - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return \Illuminate\Http\RedirectResponse - */ - public function destroy(RecurringTransaction $recurringTransaction) - { - $this->_repository->destroy($recurringTransaction); - Session::flash('success', 'The recurring transaction was deleted.'); - - return Redirect::route('recurring.index'); - - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return $this - */ - public function edit(RecurringTransaction $recurringTransaction) - { - $periods = \Config::get('firefly.periods_to_text'); - - return View::make('recurring.edit')->with('periods', $periods)->with('recurringTransaction', $recurringTransaction)->with( - 'subTitle', 'Edit "' . $recurringTransaction->name . '"' - ); - } - - /** - * @return $this - */ - public function index() - { - $recurring = $this->_repository->get(); - - return View::make('recurring.index', compact('recurring')); - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return mixed - */ - public function rescan(RecurringTransaction $recurringTransaction) - { - if (intval($recurringTransaction->active) == 0) { - Session::flash('warning', 'Inactive recurring transactions cannot be scanned.'); - - return Redirect::intended('/'); - } - - $this->_repository->scanEverything($recurringTransaction); - - Session::flash('success', 'Rescanned everything.'); - - return Redirect::intended('/'); - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return mixed - */ - public function show(RecurringTransaction $recurringTransaction) - { - $journals = $recurringTransaction->transactionjournals()->withRelevantData()->orderBy('date', 'DESC')->get(); - $hideRecurring = true; - - - return View::make('recurring.show', compact('journals', 'hideRecurring'))->with('recurring', $recurringTransaction)->with( - 'subTitle', $recurringTransaction->name - ); - } - - /** - * @return $this - * @throws FireflyException - */ - public function store() - { - $data = Input::all(); - $data['user_id'] = Auth::user()->id; - - - // always validate: - $messages = $this->_repository->validate($data); - - // flash messages: - Session::flash('warnings', $messages['warnings']); - Session::flash('successes', $messages['successes']); - Session::flash('errors', $messages['errors']); - if ($messages['errors']->count() > 0) { - Session::flash('error', 'Could not store recurring transaction: ' . $messages['errors']->first()); - } - - // return to create screen: - if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { - return Redirect::route('recurring.create')->withInput(); - } - - // store: - $this->_repository->store($data); - Session::flash('success', 'Recurring transaction "' . e($data['name']) . '" stored.'); - if ($data['post_submit_action'] == 'store') { - return Redirect::route('recurring.index'); - } - - return Redirect::route('recurring.create')->withInput(); - - } - - /** - * @param RecurringTransaction $recurringTransaction - * - * @return $this - * @throws FireflyException - */ - public function update(RecurringTransaction $recurringTransaction) - { - $data = Input::except('_token'); - $data['active'] = isset($data['active']) ? 1 : 0; - $data['automatch'] = isset($data['automatch']) ? 1 : 0; - $data['user_id'] = Auth::user()->id; - - // always validate: - $messages = $this->_repository->validate($data); - - // flash messages: - Session::flash('warnings', $messages['warnings']); - Session::flash('successes', $messages['successes']); - Session::flash('errors', $messages['errors']); - if ($messages['errors']->count() > 0) { - Session::flash('error', 'Could not update recurring transaction: ' . $messages['errors']->first()); - } - - // return to update screen: - if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { - return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput(); - } - - // update - $this->_repository->update($recurringTransaction, $data); - Session::flash('success', 'Recurring transaction "' . e($data['name']) . '" updated.'); - - // go back to list - if ($data['post_submit_action'] == 'update') { - return Redirect::route('recurring.index'); - } - - // go back to update screen. - return Redirect::route('recurring.edit', $recurringTransaction->id)->withInput(['post_submit_action' => 'return_to_edit']); - - } -} \ No newline at end of file diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 5c377f7ec3..54aa328839 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -1,7 +1,6 @@ dropSoftDeletes(); } ); + + // drop keys from bills (foreign bills_uid_for and unique uid_name_unique) + Schema::table( + 'bills', function (Blueprint $table) { + $table->dropForeign('bills_uid_for'); + $table->dropUnique('uid_name_unique'); + } + ); + // drop foreign key from transaction_journals (bill_id_foreign) + Schema::table( + 'transaction_journals', function (Blueprint $table) { + $table->dropForeign('bill_id_foreign'); + + } + ); + + // drop foreign key from budget_limits: + Schema::table( + 'budget_limits', function (Blueprint $table) { + $table->dropForeign('bid_foreign'); + $table->dropUnique('unique_bl_combi'); + } + ); + + // rename bills to recurring_transactions + Schema::rename('bills', 'recurring_transactions'); + // recreate foreign key recurring_transactions_user_id_foreign in recurring_transactions + // recreate unique recurring_transactions_user_id_name_unique in recurring_transactions + Schema::table( + 'recurring_transactions', function (Blueprint $table) { + $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade'); + $table->unique(['user_id', 'name']); + } + ); + + // rename bill_id to recurring_transaction_id + // recreate foreign transaction_journals_recurring_transaction_id_foreign in transaction_journals + Schema::table( + 'transaction_journals', function (Blueprint $table) { + $table->renameColumn('bill_id', 'recurring_transaction_id'); + $table->foreign('recurring_transaction_id')->references('id')->on('recurring_transactions')->onDelete('set null'); + } + ); + + } @@ -55,13 +99,13 @@ class ChangesForV322 extends Migration Schema::table( 'budget_limits', function (Blueprint $table) { -// try { - //$table->dropUnique('limits_component_id_startdate_repeat_freq_unique'); -// } catch (QueryException $e) { - //$table->dropUnique('unique_ci_combi'); -// } catch (PDOException $e) { -// $table->dropUnique('unique_ci_combi'); -// } + // try { + //$table->dropUnique('limits_component_id_startdate_repeat_freq_unique'); + // } catch (QueryException $e) { + //$table->dropUnique('unique_ci_combi'); + // } catch (PDOException $e) { + // $table->dropUnique('unique_ci_combi'); + // } } ); @@ -91,6 +135,48 @@ class ChangesForV322 extends Migration $table->softDeletes(); } ); + + // rename everything related to recurring transactions, aka bills: + Schema::table( + 'transaction_journals', function (Blueprint $table) { + + + // drop relation + $table->dropForeign('transaction_journals_recurring_transaction_id_foreign'); + // rename column + $table->renameColumn('recurring_transaction_id', 'bill_id'); + + } + ); + + Schema::table( + 'recurring_transactions', function (Blueprint $table) { + $table->dropForeign('recurring_transactions_user_id_foreign'); + $table->dropUnique('recurring_transactions_user_id_name_unique'); + } + ); + // rename table: + Schema::rename('recurring_transactions', 'bills'); + + // recreate foreign relation: + Schema::table( + 'transaction_journals', function (Blueprint $table) { + $table->foreign('bill_id', 'bill_id_foreign')->references('id')->on('bills')->onDelete('set null'); + } + ); + + // recreate more foreign relations. + Schema::table( + 'bills', function (Blueprint $table) { + // connect user id to users + $table->foreign('user_id', 'bills_uid_for')->references('id')->on('users')->onDelete('cascade'); + + // for a user, the name must be unique + $table->unique(['user_id', 'name'], 'uid_name_unique'); + } + ); + + } } diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 93e5fee98e..1d43dc075d 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -36,19 +36,19 @@ class TestContentSeeder extends Seeder $deleteBudget = Budget::create(['user_id' => $user->id, 'name' => 'Delete me']); // some limits: - $startDate = Carbon::now()->startOfMonth(); - $endDate = Carbon::now()->endOfMonth(); + $startDate = Carbon::now()->startOfMonth(); + $endDate = Carbon::now()->endOfMonth(); $secondStart = Carbon::now()->subMonth()->startOfMonth(); - $secondEnd = Carbon::now()->subMonth()->endOfMonth(); - $limitOne = BudgetLimit::create( + $secondEnd = Carbon::now()->subMonth()->endOfMonth(); + $limitOne = BudgetLimit::create( ['startdate' => $startDate->format('Y-m-d'), 'amount' => 201, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $groceriesBudget->id] ); - $limitTwo = BudgetLimit::create( + $limitTwo = BudgetLimit::create( ['startdate' => $secondStart->format('Y-m-d'), 'amount' => 202, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $billsBudget->id] ); - $limitThree = BudgetLimit::create( + $limitThree = BudgetLimit::create( ['startdate' => '2014-01-01', 'amount' => 203, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $deleteBudget->id] ); @@ -58,7 +58,8 @@ class TestContentSeeder extends Seeder ['budget_limit_id' => $limitOne->id, 'startdate' => $startDate->format('Y-m-d'), 'enddate' => $endDate->format('Y-m-d'), 'amount' => 201] ); $repTwo = LimitRepetition::create( - ['budget_limit_id' => $limitTwo->id, 'startdate' => $secondStart->format('Y-m-d'), 'enddate' => $secondEnd->format('Y-m-d'), 'amount' => 202] + ['budget_limit_id' => $limitTwo->id, 'startdate' => $secondStart->format('Y-m-d'), 'enddate' => $secondEnd->format('Y-m-d'), + 'amount' => 202] ); $repThree = LimitRepetition::create( ['budget_limit_id' => $limitThree->id, 'startdate' => '2014-01-01', 'enddate' => '2014-01-31', 'amount' => 203] @@ -79,7 +80,7 @@ class TestContentSeeder extends Seeder Component::create(['user_id' => $user->id, 'name' => 'Some Component 7', 'class' => 'Category']); // piggy bank - $piggy = PiggyBank::create( + $piggy = PiggyBank::create( [ 'account_id' => $savings->id, 'name' => 'New camera', @@ -99,7 +100,7 @@ class TestContentSeeder extends Seeder PiggyBankEvent::create(['piggy_bank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); PiggyBankRepetition::create( [ - 'piggy_bank_id' => $piggy->id, + 'piggy_bank_id' => $piggy->id, 'startdate' => Carbon::now()->format('Y-m-d'), 'targetdate' => null, 'currentamount' => 0 @@ -107,7 +108,7 @@ class TestContentSeeder extends Seeder ); // piggy bank - $piggyTargeted = PiggyBank::create( + $piggyTargeted = PiggyBank::create( [ 'account_id' => $savings->id, 'name' => 'New clothes', @@ -128,15 +129,15 @@ class TestContentSeeder extends Seeder PiggyBankEvent::create(['piggy_bank_id' => $piggyTargeted->id, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); PiggyBankRepetition::create( [ - 'piggy_bank_id' => $piggyTargeted->id, + 'piggy_bank_id' => $piggyTargeted->id, 'startdate' => Carbon::now()->format('Y-m-d'), 'targetdate' => Carbon::now()->addMonths(4)->format('Y-m-d'), 'currentamount' => 0 ] ); - // recurring transaction - $recurring = \RecurringTransaction::create( + // bill + $firstBill = \Bill::create( [ 'user_id' => $user->id, 'name' => 'Huur', @@ -151,8 +152,8 @@ class TestContentSeeder extends Seeder ] ); - // recurring transaction - $secondRecurring = \RecurringTransaction::create( + // bill + $secondBill = \Bill::create( [ 'user_id' => $user->id, 'name' => 'Gas licht', @@ -198,7 +199,7 @@ class TestContentSeeder extends Seeder while ($start <= $end) { $this->createTransaction( $checking, $portaal, 500, $withdrawal, 'Huur Portaal for ' . $start->format('F Y'), $start->format('Y-m-') . '01', $billsBudget, $house, - $recurring + $firstBill ); $this->createTransaction( $checking, $vitens, 12, $withdrawal, 'Water for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $billsBudget, $house @@ -261,28 +262,27 @@ class TestContentSeeder extends Seeder * * @param Budget $budget * @param Category $category - * @param RecurringTransaction $recurring + * @param Bill $bill * * @return TransactionJournal */ public function createTransaction( - Account $from, Account $to, $amount, TransactionType $type, $description, $date, Budget $budget = null, Category $category = null, - $recurring = null + Account $from, Account $to, $amount, TransactionType $type, $description, $date, Budget $budget = null, Category $category = null, Bill $bill = null ) { - $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); - $euro = TransactionCurrency::whereCode('EUR')->first(); - $recurringID = is_null($recurring) ? null : $recurring->id; + $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); + $euro = TransactionCurrency::whereCode('EUR')->first(); + $billID = is_null($bill) ? null : $bill->id; /** @var TransactionJournal $journal */ $journal = TransactionJournal::create( [ - 'user_id' => $user->id, - 'transaction_type_id' => $type->id, - 'transaction_currency_id' => $euro->id, - 'recurring_transaction_id' => $recurringID, - 'description' => $description, - 'completed' => 1, - 'date' => $date + 'user_id' => $user->id, + 'transaction_type_id' => $type->id, + 'transaction_currency_id' => $euro->id, + 'bill_id' => $billID, + 'description' => $description, + 'completed' => 1, + 'date' => $date ] ); diff --git a/app/lib/FireflyIII/Chart/Chart.php b/app/lib/FireflyIII/Chart/Chart.php index 302a014c5b..c390105efb 100644 --- a/app/lib/FireflyIII/Chart/Chart.php +++ b/app/lib/FireflyIII/Chart/Chart.php @@ -48,12 +48,12 @@ class Chart implements ChartInterface * * @return Collection */ - public function getRecurringSummary(Carbon $start, Carbon $end) + public function getBillsSummary(Carbon $start, Carbon $end) { - return \RecurringTransaction:: + return \Bill:: leftJoin( 'transaction_journals', function (JoinClause $join) use ($start, $end) { - $join->on('recurring_transactions.id', '=', 'transaction_journals.recurring_transaction_id') + $join->on('bills.id', '=', 'transaction_journals.bill_id') ->where('transaction_journals.date', '>=', $start->format('Y-m-d')) ->where('transaction_journals.date', '<=', $end->format('Y-m-d')); } @@ -64,11 +64,11 @@ class Chart implements ChartInterface } ) ->where('active', 1) - ->groupBy('recurring_transactions.id') + ->groupBy('bills.id') ->get( - ['recurring_transactions.id', 'recurring_transactions.name', 'transaction_journals.description', + ['bills.id', 'bills.name', 'transaction_journals.description', 'transaction_journals.id as journalId', - \DB::Raw('SUM(`recurring_transactions`.`amount_min` + `recurring_transactions`.`amount_max`) / 2 as `averageAmount`'), + \DB::Raw('SUM(`bills`.`amount_min` + `bills`.`amount_max`) / 2 as `averageAmount`'), 'transactions.amount AS actualAmount'] ); } diff --git a/app/lib/FireflyIII/Chart/ChartInterface.php b/app/lib/FireflyIII/Chart/ChartInterface.php index 7b29e3c9e9..5617cf8337 100644 --- a/app/lib/FireflyIII/Chart/ChartInterface.php +++ b/app/lib/FireflyIII/Chart/ChartInterface.php @@ -26,6 +26,6 @@ interface ChartInterface * * @return Collection */ - public function getRecurringSummary(Carbon $start, Carbon $end); + public function getBillsSummary(Carbon $start, Carbon $end); } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/RecurringTransaction/RecurringTransaction.php b/app/lib/FireflyIII/Database/Bill/Bill.php similarity index 78% rename from app/lib/FireflyIII/Database/RecurringTransaction/RecurringTransaction.php rename to app/lib/FireflyIII/Database/Bill/Bill.php index 1a4b424043..bee5256214 100644 --- a/app/lib/FireflyIII/Database/RecurringTransaction/RecurringTransaction.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -1,6 +1,6 @@ user()->associate($this->getUser()); - $recurring->name = $data['name']; - $recurring->match = $data['match']; - $recurring->amount_max = floatval($data['amount_max']); - $recurring->amount_min = floatval($data['amount_min']); + $bill = new \Bill; + $bill->user()->associate($this->getUser()); + $bill->name = $data['name']; + $bill->match = $data['match']; + $bill->amount_max = floatval($data['amount_max']); + $bill->amount_min = floatval($data['amount_min']); $date = new Carbon($data['date']); - $recurring->active = intval($data['active']); - $recurring->automatch = intval($data['automatch']); - $recurring->repeat_freq = $data['repeat_freq']; + $bill->active = intval($data['active']); + $bill->automatch = intval($data['automatch']); + $bill->repeat_freq = $data['repeat_freq']; /* * Jump to the start of the period. */ $date = \DateKit::startOfPeriod($date, $data['repeat_freq']); - $recurring->date = $date; - $recurring->skip = intval($data['skip']); + $bill->date = $date; + $bill->skip = intval($data['skip']); - $recurring->save(); + $bill->save(); - return $recurring; + return $bill; } /** @@ -118,7 +118,7 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac $errors->add('amount_max', 'Maximum amount can not be less than minimum amount.'); $errors->add('amount_min', 'Minimum amount can not be more than maximum amount.'); } - $object = new \RecurringTransaction($model); + $object = new \Bill($model); $object->isValid(); $errors->merge($object->getErrors()); @@ -167,7 +167,7 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac */ public function get() { - return $this->getUser()->recurringtransactions()->get(); + return $this->getUser()->bills()->get(); } /** @@ -189,35 +189,35 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac */ public function getActive() { - return $this->getUser()->recurringtransactions()->where('active', 1)->get(); + return $this->getUser()->bills()->where('active', 1)->get(); } /** - * @param \RecurringTransaction $recurring + * @param \Bill $bill * @param Carbon $start * @param Carbon $end * * @return \TransactionJournal|null */ - public function getJournalForRecurringInRange(\RecurringTransaction $recurring, Carbon $start, Carbon $end) + public function getJournalForBillInRange(\Bill $bill, Carbon $start, Carbon $end) { - return $this->getUser()->transactionjournals()->where('recurring_transaction_id', $recurring->id)->after($start)->before($end)->first(); + return $this->getUser()->transactionjournals()->where('bill_id', $bill->id)->after($start)->before($end)->first(); } /** - * @param \RecurringTransaction $recurring + * @param \Bill $bill * @param \TransactionJournal $journal * * @return bool */ - public function scan(\RecurringTransaction $recurring, \TransactionJournal $journal) + public function scan(\Bill $bill, \TransactionJournal $journal) { /* * Match words. */ $wordMatch = false; - $matches = explode(',', $recurring->match); + $matches = explode(',', $bill->match); $description = strtolower($journal->description); /* @@ -261,8 +261,8 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac if (count($transactions) > 1) { $amount = max(floatval($transactions[0]->amount), floatval($transactions[1]->amount)); - $min = floatval($recurring->amount_min); - $max = floatval($recurring->amount_max); + $min = floatval($bill->amount_min); + $max = floatval($bill->amount_max); if ($amount >= $min && $amount <= $max) { $amountMatch = true; \Log::debug('Amount match is true!'); @@ -273,17 +273,17 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac * If both, update! */ if ($wordMatch && $amountMatch) { - $journal->recurringTransaction()->associate($recurring); + $journal->bill()->associate($bill); $journal->save(); } } /** - * @param \RecurringTransaction $recurring + * @param \Bill $bill * * @return bool */ - public function scanEverything(\RecurringTransaction $recurring) + public function scanEverything(\Bill $bill) { // get all journals that (may) be relevant. // this is usually almost all of them. @@ -291,7 +291,7 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $journalRepository */ $journalRepository = \App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - $set = \DB::table('transactions')->where('amount', '>', 0)->where('amount', '>=', $recurring->amount_min)->where('amount', '<=', $recurring->amount_max) + $set = \DB::table('transactions')->where('amount', '>', 0)->where('amount', '>=', $bill->amount_min)->where('amount', '<=', $bill->amount_max) ->get(['transaction_journal_id']); $ids = []; @@ -303,7 +303,7 @@ class RecurringTransaction implements CUD, CommonDatabaseCalls, RecurringTransac $journals = $journalRepository->getByIds($ids); /** @var \TransactionJournal $journal */ foreach ($journals as $journal) { - $this->scan($recurring, $journal); + $this->scan($bill, $journal); } } diff --git a/app/lib/FireflyIII/Database/Bill/BillInterface.php b/app/lib/FireflyIII/Database/Bill/BillInterface.php new file mode 100644 index 0000000000..7be8a55b73 --- /dev/null +++ b/app/lib/FireflyIII/Database/Bill/BillInterface.php @@ -0,0 +1,41 @@ +add('description', 'Internal error: need to know type of transaction!'); } - if (isset($model['recurring_transaction_id']) && intval($model['recurring_transaction_id']) < 0) { - $errors->add('recurring_transaction_id', 'Recurring transaction is invalid.'); + if (isset($model['bill_id']) && intval($model['bill_id']) < 0) { + $errors->add('bill_id', 'Bill is invalid.'); } if (!isset($model['description'])) { $errors->add('description', 'This field is mandatory.'); diff --git a/app/lib/FireflyIII/Event/TransactionJournal.php b/app/lib/FireflyIII/Event/TransactionJournal.php index ed62684c96..ebb5e344f0 100644 --- a/app/lib/FireflyIII/Event/TransactionJournal.php +++ b/app/lib/FireflyIII/Event/TransactionJournal.php @@ -17,12 +17,12 @@ class TransactionJournal */ public function store(\TransactionJournal $journal) { - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repository */ - $repository = \App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); + /** @var \FireflyIII\Database\Bill\Bill $repository */ + $repository = \App::make('FireflyIII\Database\Bill\Bill'); $set = $repository->get(); - /** @var \RecurringTransaction $entry */ + /** @var \Bill $entry */ foreach ($set as $entry) { $repository->scan($entry, $journal); } @@ -43,13 +43,13 @@ class TransactionJournal */ public function update(\TransactionJournal $journal) { - /** @var \FireflyIII\Database\RecurringTransaction\RecurringTransaction $repository */ - $repository = \App::make('FireflyIII\Database\RecurringTransaction\RecurringTransaction'); + /** @var \FireflyIII\Database\Bill\Bill $repository */ + $repository = \App::make('FireflyIII\Database\Bill\Bill'); $set = $repository->get(); - $journal->recurring_transaction_id = null; + $journal->bill_id = null; $journal->save(); - /** @var \RecurringTransaction $entry */ + /** @var \Bill $entry */ foreach ($set as $entry) { $repository->scan($entry, $journal); } diff --git a/app/models/RecurringTransaction.php b/app/models/Bill.php similarity index 88% rename from app/models/RecurringTransaction.php rename to app/models/Bill.php index f939cff382..a7f0da04a2 100644 --- a/app/models/RecurringTransaction.php +++ b/app/models/Bill.php @@ -3,9 +3,9 @@ use Carbon\Carbon; use Watson\Validating\ValidatingTrait; use \Illuminate\Database\Eloquent\Model as Eloquent; /** - * Class RecurringTransaction + * Class Bill */ -class RecurringTransaction extends Eloquent +class Bill extends Eloquent { use ValidatingTrait; @@ -57,8 +57,7 @@ class RecurringTransaction extends Eloquent /** * TODO remove this method in favour of something in the FireflyIII libraries. * - * Find the next expected match based on the set journals and the date stuff from the recurring - * transaction. + * Find the next expected match based on the set journals and the date stuff from the bill. */ public function nextExpectedMatch() { @@ -78,18 +77,15 @@ class RecurringTransaction extends Eloquent $today = DateKit::addPeriod(new Carbon, $this->repeat_freq, 0); /* - * FF3 loops from the $start of the recurring transaction, and to make sure + * FF3 loops from the $start of the bill, and to make sure * $skip works, it adds one (for modulo). */ $skip = $this->skip + 1; $start = DateKit::startOfPeriod(new Carbon, $this->repeat_freq); /* * go back exactly one month/week/etc because FF3 does not care about 'next' - * recurring transactions if they're too far into the past. + * bills if they're too far into the past. */ - // echo 'Repeat freq is: ' . $recurringTransaction->repeat_freq . '
'; - - // echo 'Start: ' . $start . '
'; $counter = 0; while ($start <= $today) { diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index ee9cd336c7..6bfde9564f 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -85,9 +85,9 @@ class TransactionJournal extends Eloquent /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ - public function recurringTransaction() + public function bill() { - return $this->belongsTo('RecurringTransaction'); + return $this->belongsTo('Bill'); } /** @@ -202,7 +202,7 @@ class TransactionJournal extends Eloquent $query->with( ['transactions' => function ($q) { $q->orderBy('amount', 'ASC'); - }, 'transactiontype', 'budgets','categories', 'transactions.account.accounttype', 'recurringTransaction', 'budgets', 'categories'] + }, 'transactiontype', 'budgets','categories', 'transactions.account.accounttype', 'bill', 'budgets', 'categories'] ); } diff --git a/app/models/User.php b/app/models/User.php index 938f353bde..f41750cda7 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -69,9 +69,9 @@ class User extends Eloquent implements UserInterface, RemindableInterface /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ - public function recurringtransactions() + public function bills() { - return $this->hasMany('RecurringTransaction'); + return $this->hasMany('Bill'); } /** diff --git a/app/routes.php b/app/routes.php index a519bfa7cb..d68c319738 100644 --- a/app/routes.php +++ b/app/routes.php @@ -34,9 +34,9 @@ Route::bind( Route::bind( - 'recurring', function ($value, $route) { + 'bill', function ($value, $route) { if (Auth::check()) { - return RecurringTransaction:: + return Bill:: where('id', $value)->where('user_id', Auth::user()->id)->first(); } @@ -192,11 +192,11 @@ Route::group( Route::get('/chart/home/account', ['uses' => 'GoogleChartController@allAccountsBalanceChart']); Route::get('/chart/home/budgets', ['uses' => 'GoogleChartController@allBudgetsHomeChart']); Route::get('/chart/home/categories', ['uses' => 'GoogleChartController@allCategoriesHomeChart']); - Route::get('/chart/home/recurring', ['uses' => 'GoogleChartController@recurringTransactionsOverview']); + Route::get('/chart/home/bills', ['uses' => 'GoogleChartController@billsOverview']); Route::get('/chart/account/{account}/{view?}', ['uses' => 'GoogleChartController@accountBalanceChart']); Route::get('/chart/reports/income-expenses/{year}', ['uses' => 'GoogleChartController@yearInExp']); Route::get('/chart/reports/income-expenses-sum/{year}', ['uses' => 'GoogleChartController@yearInExpSum']); - Route::get('/chart/recurring/{recurring}', ['uses' => 'GoogleChartController@recurringOverview']); + Route::get('/chart/bills/{bill}', ['uses' => 'GoogleChartController@billOverview']); Route::get('/chart/budget/{budget}/{limitrepetition}', ['uses' => 'GoogleChartController@budgetLimitSpending']); Route::get('/chart/piggy_history/{piggy_bank}', ['uses' => 'GoogleChartController@piggyBankHistory']); @@ -234,13 +234,13 @@ Route::group( Route::get('/profile', ['uses' => 'ProfileController@index', 'as' => 'profile']); Route::get('/profile/change-password', ['uses' => 'ProfileController@changePassword', 'as' => 'change-password']); - // recurring transactions controller - Route::get('/recurring', ['uses' => 'RecurringController@index', 'as' => 'recurring.index']); - Route::get('/recurring/rescan/{recurring}', ['uses' => 'RecurringController@rescan', 'as' => 'recurring.rescan']); # rescan for matching. - Route::get('/recurring/create', ['uses' => 'RecurringController@create', 'as' => 'recurring.create']); - Route::get('/recurring/edit/{recurring}', ['uses' => 'RecurringController@edit', 'as' => 'recurring.edit']); - Route::get('/recurring/delete/{recurring}', ['uses' => 'RecurringController@delete', 'as' => 'recurring.delete']); - Route::get('/recurring/show/{recurring}', ['uses' => 'RecurringController@show', 'as' => 'recurring.show']); + // bills controller + Route::get('/bills', ['uses' => 'BillController@index', 'as' => 'bills.index']); + Route::get('/bills/rescan/{bill}', ['uses' => 'BillController@rescan', 'as' => 'bills.rescan']); # rescan for matching. + Route::get('/bills/create', ['uses' => 'BillController@create', 'as' => 'bills.create']); + Route::get('/bills/edit/{bill}', ['uses' => 'BillController@edit', 'as' => 'bills.edit']); + Route::get('/bills/delete/{bill}', ['uses' => 'BillController@delete', 'as' => 'bills.delete']); + Route::get('/bills/show/{bill}', ['uses' => 'BillController@show', 'as' => 'bills.show']); // repeated expenses controller: Route::get('/repeatedexpenses', ['uses' => 'RepeatedExpenseController@index', 'as' => 'repeated.index']); @@ -328,10 +328,10 @@ Route::group( // profile controller Route::post('/profile/change-password', ['uses' => 'ProfileController@postChangePassword']); - // recurring controller - Route::post('/recurring/store', ['uses' => 'RecurringController@store', 'as' => 'recurring.store']); - Route::post('/recurring/update/{recurring}', ['uses' => 'RecurringController@update', 'as' => 'recurring.update']); - Route::post('/recurring/destroy/{recurring}', ['uses' => 'RecurringController@destroy', 'as' => 'recurring.destroy']); + // bills controller + Route::post('/bills/store', ['uses' => 'BillController@store', 'as' => 'bills.store']); + Route::post('/bills/update/{bill}', ['uses' => 'BillController@update', 'as' => 'bills.update']); + Route::post('/bills/destroy/{bill}', ['uses' => 'BillController@destroy', 'as' => 'bills.destroy']); // transaction controller: Route::post('/transactions/store/{what}', ['uses' => 'TransactionController@store', 'as' => 'transactions.store'])->where( diff --git a/app/views/recurring/create.blade.php b/app/views/bills/create.blade.php similarity index 91% rename from app/views/recurring/create.blade.php rename to app/views/bills/create.blade.php index a14eaf114d..823716451d 100644 --- a/app/views/recurring/create.blade.php +++ b/app/views/bills/create.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} -{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('recurring.store')])}} +{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('bills.store')])}}
@@ -21,7 +21,7 @@

@@ -44,7 +44,7 @@ Options
- {{Form::ffOptionsList('create','recurring transaction')}} + {{Form::ffOptionsList('create','bill')}}
diff --git a/app/views/recurring/delete.blade.php b/app/views/bills/delete.blade.php similarity index 83% rename from app/views/recurring/delete.blade.php rename to app/views/bills/delete.blade.php index 261d505d12..ad312dd11b 100644 --- a/app/views/recurring/delete.blade.php +++ b/app/views/bills/delete.blade.php @@ -1,12 +1,12 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $recurringTransaction) }} -{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('recurring.destroy',$recurringTransaction->id)])}} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $bill) }} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('bills.destroy',$bill->id)])}}
- Delete recurring transaction "{{{$recurringTransaction->name}}}" + Delete bill "{{{$bill->name}}}"

diff --git a/app/views/recurring/edit.blade.php b/app/views/bills/edit.blade.php similarity index 80% rename from app/views/recurring/edit.blade.php rename to app/views/bills/edit.blade.php index 5824b10655..9e55131576 100644 --- a/app/views/recurring/edit.blade.php +++ b/app/views/bills/edit.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $recurringTransaction) }} -{{Form::model($recurringTransaction, ['class' => 'form-horizontal','id' => 'update','url' => route('recurring.update', $recurringTransaction->id)])}} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $bill) }} +{{Form::model($bill, ['class' => 'form-horizontal','id' => 'update','url' => route('bills.update', $bill->id)])}}

@@ -15,14 +15,14 @@ {{Form::ffTags('match')}} {{Form::ffAmount('amount_min')}} {{Form::ffAmount('amount_max')}} - {{Form::ffDate('date',$recurringTransaction->date->format('Y-m-d'))}} + {{Form::ffDate('date',$bill->date->format('Y-m-d'))}} {{Form::ffSelect('repeat_freq',$periods)}}

@@ -44,7 +44,7 @@ Options
- {{Form::ffOptionsList('update','recurring transaction')}} + {{Form::ffOptionsList('update','bill')}}
diff --git a/app/views/recurring/index.blade.php b/app/views/bills/index.blade.php similarity index 91% rename from app/views/recurring/index.blade.php rename to app/views/bills/index.blade.php index ac615b33b8..a408c29344 100644 --- a/app/views/recurring/index.blade.php +++ b/app/views/bills/index.blade.php @@ -9,7 +9,7 @@
- @include('list.recurring') + @include('list.bills')
diff --git a/app/views/recurring/show.blade.php b/app/views/bills/show.blade.php similarity index 75% rename from app/views/recurring/show.blade.php rename to app/views/bills/show.blade.php index b877599d47..366c0ca667 100644 --- a/app/views/recurring/show.blade.php +++ b/app/views/bills/show.blade.php @@ -1,19 +1,19 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $recurring) }} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $bill) }}
- {{{$recurring->name}}} + {{{$bill->name}}} - @if($recurring->active) + @if($bill->active) @else @endif - @if($recurring->automatch) + @if($bill->automatch) @else @@ -27,8 +27,8 @@
@@ -39,17 +39,17 @@
+ between {{mf($bill->amount_min)}} and {{mf($bill->amount_max)}}. + Repeats {{$bill->repeat_freq}}. - @foreach($recurring as $entry) + @foreach($bills as $entry) @endif - @if(!isset($hideRecurring) || (isset($hideRecurring) && $hideRecurring=== false)) - + @if(!isset($hideBill) || (isset($hideBill) && $hideBill=== false)) + @endif @foreach($journals as $journal) @@ -100,10 +100,10 @@ @endif @endif - @if(!isset($hideRecurring) || (isset($hideRecurring) && $hideRecurring=== false)) + @if(!isset($hideBill) || (isset($hideBill) && $hideBill=== false)) @endif diff --git a/app/views/partials/menu.blade.php b/app/views/partials/menu.blade.php index c4f7da2aef..f3172797bb 100644 --- a/app/views/partials/menu.blade.php +++ b/app/views/partials/menu.blade.php @@ -137,9 +137,9 @@
  • @@ -149,7 +149,7 @@ Piggy banks
  • - Recurring transactions + Bills
  • Repeated expenses @@ -162,7 +162,7 @@ $isWithdrawal = $r == 'transactions.create' && isset($what) && $what == 'withdrawal'; $isDeposit = $r == 'transactions.create' && isset($what) && $what == 'deposit'; $isTransfer = $r == 'transactions.create' && isset($what) && $what == 'transfer'; - $isRecurring = $r == 'recurring.create'; + $isBill = $r == 'bills.create'; ?>
  • Create new @@ -177,7 +177,7 @@ Transfer
  • - Recurring transaction + Bills
    • diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index ec0e3a22ca..30366bcee5 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -181,7 +181,7 @@
    -
    Recurring transactions
    +
    Bills
    Body
    diff --git a/public/assets/javascript/firefly/bills.js b/public/assets/javascript/firefly/bills.js new file mode 100644 index 0000000000..01c26984ce --- /dev/null +++ b/public/assets/javascript/firefly/bills.js @@ -0,0 +1,7 @@ +$(document).ready(function () { + + if (typeof(googleComboChart) == 'function' && typeof(billID) != 'undefined') { + googleComboChart('chart/bills/' + billID, 'bill-overview'); + } + } +); \ No newline at end of file diff --git a/public/assets/javascript/firefly/index.js b/public/assets/javascript/firefly/index.js index d776da45b1..3328f23d6f 100644 --- a/public/assets/javascript/firefly/index.js +++ b/public/assets/javascript/firefly/index.js @@ -5,5 +5,5 @@ function drawChart() { googleLineChart('chart/home/account', 'accounts-chart'); googleBarChart('chart/home/budgets','budgets-chart'); googleColumnChart('chart/home/categories','categories-chart'); - googlePieChart('chart/home/recurring','recurring-chart') + googlePieChart('chart/home/bills','bills-chart') } diff --git a/public/assets/javascript/firefly/recurring.js b/public/assets/javascript/firefly/recurring.js deleted file mode 100644 index b0857f6629..0000000000 --- a/public/assets/javascript/firefly/recurring.js +++ /dev/null @@ -1,14 +0,0 @@ -$(document).ready(function () { - - if (typeof(googleTable) == 'function') { - googleTable('table/recurring', 'recurring-table'); - - if (typeof(recurringID) != 'undefined') { - googleTable('table/recurring/' + recurringID + '/transactions', 'transaction-table'); - } - } - if (typeof(googleComboChart) == 'function' && typeof(recurringID) != 'undefined') { - googleComboChart('chart/recurring/' + recurringID, 'recurring-overview'); - } - } -); \ No newline at end of file diff --git a/tests/functional/RecurringControllerCest.php b/tests/functional/BillControllerCest.php similarity index 66% rename from tests/functional/RecurringControllerCest.php rename to tests/functional/BillControllerCest.php index 54a5524dc8..3dcea51f9b 100644 --- a/tests/functional/RecurringControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -1,9 +1,9 @@ wantTo('create a recurring transaction'); - $I->amOnPage('/recurring/create'); + $I->wantTo('create a bill'); + $I->amOnPage('/bills/create'); } /** @@ -35,8 +35,8 @@ class RecurringControllerCest */ public function delete(FunctionalTester $I) { - $I->wantTo('delete a recurring transaction'); - $I->amOnPage('/recurring/delete/1'); + $I->wantTo('delete a bill'); + $I->amOnPage('/bills/delete/1'); $I->see('Delete "Huur"'); } @@ -45,11 +45,11 @@ class RecurringControllerCest */ public function destroy(FunctionalTester $I) { - $I->wantTo('destroy a recurring transaction'); - $I->amOnPage('/recurring/delete/1'); + $I->wantTo('destroy a bill'); + $I->amOnPage('/bills/delete/1'); $I->see('Delete "Huur"'); $I->submitForm('#destroy', []); - $I->see('The recurring transaction was deleted.'); + $I->see('The bill was deleted.'); } @@ -58,8 +58,8 @@ class RecurringControllerCest */ public function edit(FunctionalTester $I) { - $I->wantTo('edit a recurring transaction'); - $I->amOnPage('/recurring/edit/1'); + $I->wantTo('edit a bill'); + $I->amOnPage('/bills/edit/1'); } @@ -69,8 +69,8 @@ class RecurringControllerCest */ public function index(FunctionalTester $I) { - $I->wantTo('see all recurring transactions'); - $I->amOnPage('/recurring'); + $I->wantTo('see all bills'); + $I->amOnPage('/bills'); } /** @@ -78,8 +78,8 @@ class RecurringControllerCest */ public function rescan(FunctionalTester $I) { - $I->wantTo('rescan a recurring transaction'); - $I->amOnPage('/recurring/rescan/1'); + $I->wantTo('rescan a bill'); + $I->amOnPage('/bills/rescan/1'); $I->see('Rescanned everything.'); } @@ -88,9 +88,9 @@ class RecurringControllerCest */ public function rescanInactive(FunctionalTester $I) { - $I->wantTo('rescan an inactive recurring transaction'); - $I->amOnPage('/recurring/rescan/2'); - $I->see('Inactive recurring transactions cannot be scanned.'); + $I->wantTo('rescan an inactive bill'); + $I->amOnPage('/bills/rescan/2'); + $I->see('Inactive bills cannot be scanned.'); } /** @@ -98,8 +98,8 @@ class RecurringControllerCest */ public function show(FunctionalTester $I) { - $I->wantTo('show a recurring transaction'); - $I->amOnPage('/recurring/show/1'); + $I->wantTo('show a bill'); + $I->amOnPage('/bills/show/1'); $I->see('Huur'); } @@ -108,11 +108,11 @@ class RecurringControllerCest */ public function store(FunctionalTester $I) { - $I->wantTo('store a recurring transaction'); - $I->amOnPage('/recurring/create'); + $I->wantTo('store a bill'); + $I->amOnPage('/bills/create'); $I->submitForm( '#store', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => 'one,two', 'amount_min' => 10, 'amount_max' => 20, @@ -122,7 +122,7 @@ class RecurringControllerCest 'skip' => 0 ] ); - $I->see('Recurring transaction "Some recurring" stored.'); + $I->see('Bill "Some bill" stored.'); } /** @@ -130,11 +130,11 @@ class RecurringControllerCest */ public function storeFail(FunctionalTester $I) { - $I->wantTo('store a recurring transaction and fail'); - $I->amOnPage('/recurring/create'); + $I->wantTo('store a bill and fail'); + $I->amOnPage('/bills/create'); $I->submitForm( '#store', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => '', 'amount_min' => 10, 'amount_max' => 20, @@ -143,17 +143,17 @@ class RecurringControllerCest 'skip' => 0 ] ); - $I->dontSeeInDatabase('recurring_transactions', ['name' => 'Some recurring']); - $I->see('Could not store recurring transaction'); + $I->dontSeeInDatabase('bills', ['name' => 'Some bill']); + $I->see('Could not store bill'); } public function storeRecreate(FunctionalTester $I) { - $I->wantTo('validate a recurring transaction and create another one'); - $I->amOnPage('/recurring/create'); + $I->wantTo('validate a bill and create another one'); + $I->amOnPage('/bills/create'); $I->submitForm( '#store', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => 'one,two', 'amount_min' => 10, 'amount_max' => 20, @@ -164,7 +164,7 @@ class RecurringControllerCest ] ); - $I->see('Recurring transaction "Some recurring" stored.'); + $I->see('Bill "Some bill" stored.'); } /** @@ -172,11 +172,11 @@ class RecurringControllerCest */ public function storeValidate(FunctionalTester $I) { - $I->wantTo('validate a recurring transaction'); - $I->amOnPage('/recurring/create'); + $I->wantTo('validate a bill'); + $I->amOnPage('/bills/create'); $I->submitForm( '#store', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => 'one,two', 'amount_min' => 10, 'amount_max' => 20, @@ -195,11 +195,11 @@ class RecurringControllerCest */ public function update(FunctionalTester $I) { - $I->wantTo('update a recurring transaction'); - $I->amOnPage('/recurring/edit/1'); + $I->wantTo('update a bill'); + $I->amOnPage('/bills/edit/1'); $I->submitForm( '#update', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => 'bla,bla', 'amount_min' => 10, 'amount_max' => 20, @@ -208,7 +208,7 @@ class RecurringControllerCest 'skip' => 0 ] ); - $I->see('Recurring transaction "Some recurring" updated.'); + $I->see('Bill "Some bill" updated.'); } /** @@ -216,11 +216,11 @@ class RecurringControllerCest */ public function updateReturn(FunctionalTester $I) { - $I->wantTo('update a recurring transaction and return to edit it'); - $I->amOnPage('/recurring/edit/1'); + $I->wantTo('update a bill and return to edit it'); + $I->amOnPage('/bills/edit/1'); $I->submitForm( '#update', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => 'bla,bla', 'amount_min' => 10, 'amount_max' => 20, @@ -230,7 +230,7 @@ class RecurringControllerCest 'skip' => 0 ] ); - $I->see('Recurring transaction "Some recurring" updated.'); + $I->see('Bill "Some bill" updated.'); } /** @@ -238,11 +238,11 @@ class RecurringControllerCest */ public function updateFail(FunctionalTester $I) { - $I->wantTo('update a recurring transaction and fail'); - $I->amOnPage('/recurring/edit/1'); + $I->wantTo('update a bill and fail'); + $I->amOnPage('/bills/edit/1'); $I->submitForm( '#update', [ - 'name' => 'Some recurring', + 'name' => 'Some bill', 'match' => '', 'amount_min' => 10, 'amount_max' => 20, @@ -251,7 +251,7 @@ class RecurringControllerCest 'skip' => 0 ] ); - $I->see('Could not update recurring transaction'); + $I->see('Could not update bill'); } } \ No newline at end of file diff --git a/tests/functional/GoogleChartControllerCest.php b/tests/functional/GoogleChartControllerCest.php index dbc8e091e1..3cab18f197 100644 --- a/tests/functional/GoogleChartControllerCest.php +++ b/tests/functional/GoogleChartControllerCest.php @@ -138,30 +138,30 @@ class GoogleChartControllerCest /** * @param FunctionalTester $I */ - public function recurringOverview(FunctionalTester $I) + public function billOverview(FunctionalTester $I) { - $I->wantTo('see the chart for the history of a recurring transaction'); - $I->amOnPage('/chart/recurring/1'); + $I->wantTo('see the chart for the history of a bill'); + $I->amOnPage('/chart/bills/1'); $I->seeResponseCodeIs(200); } /** * @param FunctionalTester $I */ - public function emptyRecurringOverview(FunctionalTester $I) + public function emptyBillOverview(FunctionalTester $I) { - $I->wantTo('see the chart for the history of an empty recurring transaction'); - $I->amOnPage('/chart/recurring/2'); + $I->wantTo('see the chart for the history of an empty bill'); + $I->amOnPage('/chart/bills/2'); $I->seeResponseCodeIs(200); } /** * @param FunctionalTester $I */ - public function recurringTransactionsOverview(FunctionalTester $I) + public function billsOverview(FunctionalTester $I) { - $I->wantTo('see the chart for which recurring transactions I have yet to pay'); - $I->amOnPage('/chart/home/recurring'); + $I->wantTo('see the chart for which bills I have yet to pay'); + $I->amOnPage('/chart/home/bills'); $I->seeResponseCodeIs(200); } From 8fc055cad9e582bcd77f9d15e7f5cbf51bc4d0fb Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 29 Dec 2014 20:36:56 +0100 Subject: [PATCH 22/84] Renamed a container [skip ci] #38 --- app/views/index.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/index.blade.php b/app/views/index.blade.php index fa9b896315..9276be766d 100644 --- a/app/views/index.blade.php +++ b/app/views/index.blade.php @@ -70,7 +70,7 @@ Bills
    -
    +
    From 593e799ca15b3e35c6f7c9ca1a04318084dad004 Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 29 Dec 2014 20:39:27 +0100 Subject: [PATCH 23/84] New and matching icon for bills [skip ci] #38 --- app/controllers/BillController.php | 2 +- app/views/index.blade.php | 2 +- app/views/partials/menu.blade.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index 3ea9810eb9..e87b2602fd 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -24,7 +24,7 @@ class BillController extends BaseController $this->_repository = $repository; View::share('title', 'Bills'); - View::share('mainTitleIcon', 'fa-rotate-right'); + View::share('mainTitleIcon', 'fa-calendar-o'); } /** diff --git a/app/views/index.blade.php b/app/views/index.blade.php index 9276be766d..d27739d9bd 100644 --- a/app/views/index.blade.php +++ b/app/views/index.blade.php @@ -67,7 +67,7 @@
    - Bills + Bills
    diff --git a/app/views/partials/menu.blade.php b/app/views/partials/menu.blade.php index f3172797bb..05ed6c3bbd 100644 --- a/app/views/partials/menu.blade.php +++ b/app/views/partials/menu.blade.php @@ -149,7 +149,7 @@ Piggy banks
  • - Bills + Bills
  • Repeated expenses From 89363ecfa3b19d84839c00078fe369bdfb0ba331 Mon Sep 17 00:00:00 2001 From: James Cole Date: Mon, 29 Dec 2014 21:49:43 +0100 Subject: [PATCH 24/84] Tests for reminders. --- app/controllers/ReminderController.php | 31 +++++------ app/database/seeds/TestContentSeeder.php | 56 +++++++++++++++++++ app/lib/FireflyIII/Shared/Toolkit/Date.php | 2 +- app/routes.php | 2 +- app/views/reminders/show.blade.php | 4 +- tests/functional/ReminderControllerCest.php | 60 +++++++++++++++++++++ 6 files changed, 134 insertions(+), 21 deletions(-) create mode 100644 tests/functional/ReminderControllerCest.php diff --git a/app/controllers/ReminderController.php b/app/controllers/ReminderController.php index 873ac2b7eb..9760dedced 100644 --- a/app/controllers/ReminderController.php +++ b/app/controllers/ReminderController.php @@ -26,25 +26,22 @@ class ReminderController extends BaseController public function act(Reminder $reminder) { - switch (get_class($reminder->remindersable)) { - default: - throw new FireflyException('Cannot act on reminder for ' . get_class($reminder->remindersable)); - break; - break; - case 'PiggyBank': - $amount = Reminders::amountForReminder($reminder); - $preFilled = [ - 'amount' => round($amount, 2), - 'description' => 'Money for ' . $reminder->remindersable->name, - 'piggy_bank_id' => $reminder->remindersable_id, - 'account_to_id' => $reminder->remindersable->account_id - ]; - Session::flash('preFilled', $preFilled); + $class = get_class($reminder->remindersable); - return Redirect::route('transactions.create', 'transfer'); - break; + if ($class == 'PiggyBank') { + $amount = Reminders::amountForReminder($reminder); + $preFilled = [ + 'amount' => round($amount, 2), + 'description' => 'Money for ' . $reminder->remindersable->name, + 'piggy_bank_id' => $reminder->remindersable_id, + 'account_to_id' => $reminder->remindersable->account_id + ]; + Session::flash('preFilled', $preFilled); + return Redirect::route('transactions.create', 'transfer'); } + + return View::make('error')->with('message', 'This reminder has an invalid class connected to it.'); } /** @@ -66,7 +63,7 @@ class ReminderController extends BaseController * * @return \Illuminate\Http\RedirectResponse */ - public function notnow(Reminder $reminder) + public function notNow(Reminder $reminder) { $reminder->active = 0; $reminder->notnow = 1; diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 1d43dc075d..bc68264062 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -97,6 +97,8 @@ class TestContentSeeder extends Seeder 'order' => 0, ] ); + + PiggyBankEvent::create(['piggy_bank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); PiggyBankRepetition::create( [ @@ -136,6 +138,59 @@ class TestContentSeeder extends Seeder ] ); + // weekly reminder piggy bank + $weekly = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'Weekly reminder for clothes', + 'targetamount' => 2000, + 'startdate' => Carbon::now()->format('Y-m-d'), + 'targetdate' => Carbon::now()->addYear()->subDay()->format('Y-m-d'), + 'repeats' => 0, + 'rep_length' => null, + 'rep_every' => 0, + 'rep_times' => null, + 'reminder' => 'week', + 'reminder_skip' => 0, + 'remind_me' => 1, + 'order' => 0, + ] + ); + PiggyBankRepetition::create( + [ + 'piggy_bank_id' => $weekly->id, + 'startdate' => Carbon::now()->format('Y-m-d'), + 'targetdate' => Carbon::now()->addYear()->subDay()->format('Y-m-d'), + 'currentamount' => 0 + ] + ); + + // a fake reminder for this piggy bank: + Reminder::create( + [ + 'user_id' => $user->id, + 'startdate' => $startDate->format('Y-m-d'), + 'enddate' => Carbon::now()->addWeek()->format('Y-m-d'), + 'active' => 1, + 'notnow' => 0, + 'remindersable_id' => $weekly->id, + 'remindersable_type' => 'PiggyBank' + ] + ); + + // a fake reminder for this piggy bank: + Reminder::create( + [ + 'user_id' => $user->id, + 'startdate' => $startDate->format('Y-m-d'), + 'enddate' => Carbon::now()->addWeek()->format('Y-m-d'), + 'active' => 1, + 'notnow' => 0, + 'remindersable_id' => 40, + 'remindersable_type' => 'Transaction' + ] + ); + // bill $firstBill = \Bill::create( [ @@ -168,6 +223,7 @@ class TestContentSeeder extends Seeder ] ); + // create some expense accounts. $albert = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Albert Heijn', 'active' => 1]); $plus = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'PLUS', 'active' => 1]); diff --git a/app/lib/FireflyIII/Shared/Toolkit/Date.php b/app/lib/FireflyIII/Shared/Toolkit/Date.php index 5ec5af4148..09ee90cabe 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Date.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Date.php @@ -26,7 +26,7 @@ class Date switch ($repeatFreq) { default: - throw new FireflyException('Cannot do addPeriod for $repeat_freq ' . $repeatFreq); + throw new FireflyException('Cannot do addPeriod for $repeat_freq "' . $repeatFreq . '"'); break; case 'daily': $date->addDays($add); diff --git a/app/routes.php b/app/routes.php index d68c319738..efaf3ee653 100644 --- a/app/routes.php +++ b/app/routes.php @@ -257,7 +257,7 @@ Route::group( // reminder controller Route::get('/reminders/{reminder}', ['uses' => 'ReminderController@show', 'as' => 'reminders.show']); Route::get('/reminders/{reminder}/dismiss', ['uses' => 'ReminderController@dismiss', 'as' => 'reminders.dismiss']); - Route::get('/reminders/{reminder}/notnow', ['uses' => 'ReminderController@notnow', 'as' => 'reminders.notnow']); + Route::get('/reminders/{reminder}/notNow', ['uses' => 'ReminderController@notNow', 'as' => 'reminders.notNow']); Route::get('/reminders/{reminder}/act', ['uses' => 'ReminderController@act', 'as' => 'reminders.act']); // search controller: diff --git a/app/views/reminders/show.blade.php b/app/views/reminders/show.blade.php index a01b3a8882..115c9aaf24 100644 --- a/app/views/reminders/show.blade.php +++ b/app/views/reminders/show.blade.php @@ -6,7 +6,7 @@
    A reminder about - @if(get_class($reminder->remindersable) == 'Piggybank') + @if(get_class($reminder->remindersable) == 'PiggyBank') your piggy bank labelled "{{{$reminder->remindersable->name}}}" @endif
    @@ -22,7 +22,7 @@

    I want to do this I already did this - Not this time + Not this time

    diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php new file mode 100644 index 0000000000..3415dd1ad5 --- /dev/null +++ b/tests/functional/ReminderControllerCest.php @@ -0,0 +1,60 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + public function act(FunctionalTester $I) + { + $I->wantTo('act on a reminder'); + $I->amOnPage('/reminders/1/act'); + $I->see('Money for Weekly reminder for clothes'); + } + + public function dismiss(FunctionalTester $I) + { + $I->wantTo('dismiss a reminder'); + $I->amOnPage('/reminders/1/dismiss'); + $I->see('Reminder dismissed'); + } + + public function notNow(FunctionalTester $I) + { + $I->wantTo('ignore a reminder'); + $I->amOnPage('/reminders/1/notNow'); + $I->see('Reminder dismissed'); + } + + public function show(FunctionalTester $I) + { + $I->wantTo('see a reminder'); + $I->amOnPage('/reminders/1'); + $I->see('A reminder about'); + $I->see('your piggy bank labelled "Weekly reminder for clothes"'); + } + + public function actOnInvalid(FunctionalTester $I) + { + $I->wantTo('act on an invalid reminder'); + $I->amOnPage('/reminders/2/act'); + $I->see('This reminder has an invalid class connected to it.'); + } + +} \ No newline at end of file From c0c37eec7b2602056c6ad737b568ac76b07759f3 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 06:30:20 +0100 Subject: [PATCH 25/84] Most views now show the transaction the current journal/transaction is set in, even if it's not the current default currency. See issue #37 --- app/database/seeds/TestContentSeeder.php | 40 +++-- .../seeds/TransactionCurrencySeeder.php | 1 + app/views/list/journals-full.blade.php | 6 +- app/views/list/journals-small.blade.php | 6 +- app/views/list/journals-tiny.blade.php | 4 +- app/views/transactions/show.blade.php | 4 +- bootstrap/functions.php | 166 ++++++++++++++++++ bootstrap/start.php | 114 +----------- tests/functional/CurrencyControllerCest.php | 10 +- 9 files changed, 208 insertions(+), 143 deletions(-) create mode 100644 bootstrap/functions.php diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index bc68264062..525d6fd4b6 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -22,6 +22,9 @@ class TestContentSeeder extends Seeder $transfer = TransactionType::whereType('Transfer')->first(); $deposit = TransactionType::whereType('Deposit')->first(); + $euro = TransactionCurrency::whereCode('EUR')->first(); + $dollar = TransactionCurrency::whereCode('USD')->first(); + $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); if ($user) { @@ -245,8 +248,8 @@ class TestContentSeeder extends Seeder ['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Savings account initial balance', 'active' => 0] ); - $this->createTransaction($ibChecking, $checking, 4000, $obType, 'Initial Balance for Checking account', '2014-01-01'); - $this->createTransaction($ibSavings, $savings, 10000, $obType, 'Initial Balance for Savings account', '2014-01-01'); + $this->createTransaction($ibChecking, $checking, 4000, $obType, 'Initial Balance for Checking account', '2014-01-01', $euro); + $this->createTransaction($ibSavings, $savings, 10000, $obType, 'Initial Balance for Savings account', '2014-01-01', $euro); // create some expenses and incomes and what-not (for every month): @@ -254,14 +257,16 @@ class TestContentSeeder extends Seeder $end = Carbon::now()->endOfMonth()->addDay(); while ($start <= $end) { $this->createTransaction( - $checking, $portaal, 500, $withdrawal, 'Huur Portaal for ' . $start->format('F Y'), $start->format('Y-m-') . '01', $billsBudget, $house, + $checking, $portaal, 500, $withdrawal, 'Huur Portaal for ' . $start->format('F Y'), $start->format('Y-m-') . '01', $euro, $billsBudget, + $house, $firstBill ); $this->createTransaction( - $checking, $vitens, 12, $withdrawal, 'Water for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $billsBudget, $house + $checking, $vitens, 12, $withdrawal, 'Water for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $euro, $billsBudget, $house ); $this->createTransaction( - $checking, $greenchoice, 110, $withdrawal, 'Power for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $billsBudget, $house + $checking, $greenchoice, 110, $withdrawal, 'Power for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $euro, $billsBudget, + $house ); // spend on groceries @@ -270,22 +275,24 @@ class TestContentSeeder extends Seeder $amt = rand(100, 300) / 10; $lunchAmount = rand(30, 60) / 10; $this->createTransaction( - $checking, $plus, $lunchAmount, $withdrawal, 'Lunch', $groceriesStart->format('Y-m-d'), $groceriesBudget, $lunch + $checking, $plus, $lunchAmount, $withdrawal, 'Lunch', $groceriesStart->format('Y-m-d'), $dollar, $groceriesBudget, $lunch ); $groceriesStart->addDay(); if (intval($groceriesStart->format('d')) % 2 == 0) { $this->createTransaction( - $checking, $albert, $amt, $withdrawal, 'Groceries', $groceriesStart->format('Y-m-d'), $groceriesBudget, $dailyGroceries + $checking, $albert, $amt, $withdrawal, 'Groceries', $groceriesStart->format('Y-m-d'), $euro, $groceriesBudget, $dailyGroceries ); } $groceriesStart->addDay(); } // get income: - $this->createTransaction($employer, $checking, rand(1400, 1600), $deposit, 'Salary', $start->format('Y-m-') . '23'); + $this->createTransaction($employer, $checking, rand(1400, 1600), $deposit, 'Salary', $start->format('Y-m-') . '23', $dollar); // pay taxes: - $this->createTransaction($checking, $taxes, rand(50, 70), $withdrawal, 'Taxes in ' . $start->format('F Y'), $start->format('Y-m-') . '27'); + $this->createTransaction( + $checking, $taxes, rand(50, 70), $withdrawal, 'Taxes in ' . $start->format('F Y'), $start->format('Y-m-') . '27', $euro + ); // some other stuff. @@ -295,8 +302,8 @@ class TestContentSeeder extends Seeder } // create some big expenses, move some money around. - $this->createTransaction($savings, $checking, 1259, $transfer, 'Money for new PC', $end->format('Y-m') . '-11'); - $this->createTransaction($checking, $store, 1259, $withdrawal, 'New PC', $end->format('Y-m') . '-12'); + $this->createTransaction($savings, $checking, 1259, $transfer, 'Money for new PC', $end->format('Y-m') . '-11', $dollar); + $this->createTransaction($checking, $store, 1259, $withdrawal, 'New PC', $end->format('Y-m') . '-12', $euro); // create two budgets @@ -315,6 +322,7 @@ class TestContentSeeder extends Seeder * @param TransactionType $type * @param $description * @param $date + * @param TransactionCurrency $currency * * @param Budget $budget * @param Category $category @@ -323,18 +331,20 @@ class TestContentSeeder extends Seeder * @return TransactionJournal */ public function createTransaction( - Account $from, Account $to, $amount, TransactionType $type, $description, $date, Budget $budget = null, Category $category = null, Bill $bill = null + Account $from, Account $to, $amount, TransactionType $type, $description, $date, TransactionCurrency $currency, Budget $budget = null, + Category $category = null, Bill $bill = null ) { - $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); - $euro = TransactionCurrency::whereCode('EUR')->first(); + $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); + $billID = is_null($bill) ? null : $bill->id; + /** @var TransactionJournal $journal */ $journal = TransactionJournal::create( [ 'user_id' => $user->id, 'transaction_type_id' => $type->id, - 'transaction_currency_id' => $euro->id, + 'transaction_currency_id' => $currency->id, 'bill_id' => $billID, 'description' => $description, 'completed' => 1, diff --git a/app/database/seeds/TransactionCurrencySeeder.php b/app/database/seeds/TransactionCurrencySeeder.php index 20f50e9f60..67ae8faba3 100644 --- a/app/database/seeds/TransactionCurrencySeeder.php +++ b/app/database/seeds/TransactionCurrencySeeder.php @@ -12,6 +12,7 @@ class TransactionCurrencySeeder extends Seeder TransactionCurrency::create(['code' => 'EUR','name' => 'Euro','symbol' => '€']); TransactionCurrency::create(['code' => 'USD','name' => 'US Dollar','symbol' => '$']); + TransactionCurrency::create(['code' => 'HUF','name' => 'Hungarian forint','symbol' => 'Ft']); } } \ No newline at end of file diff --git a/app/views/list/journals-full.blade.php b/app/views/list/journals-full.blade.php index ffbaa2427f..c97a4ca210 100644 --- a/app/views/list/journals-full.blade.php +++ b/app/views/list/journals-full.blade.php @@ -58,13 +58,13 @@
    • - + @endforeach
    Matching on - @foreach(explode(',',$recurring->match) as $word) + @foreach(explode(',',$bill->match) as $word) {{{$word}}} @endforeach - between {{mf($recurring->amount_min)}} and {{mf($recurring->amount_max)}}. - Repeats {{$recurring->repeat_freq}}.
    Next expected match - nextExpectedMatch();?> + nextExpectedMatch();?> @if($nextExpectedMatch) {{$nextExpectedMatch->format('j F Y')}} @else @@ -68,7 +68,7 @@

    - Rescan old transactions + Rescan old transactions

    @@ -82,7 +82,7 @@ Chart
    -
    +
    @@ -105,7 +105,7 @@ @section('scripts') @@ -113,5 +113,5 @@ {{HTML::script('assets/javascript/firefly/gcharts.options.js')}} {{HTML::script('assets/javascript/firefly/gcharts.js')}} -{{HTML::script('assets/javascript/firefly/recurring.js')}} +{{HTML::script('assets/javascript/firefly/bills.js')}} @stop \ No newline at end of file diff --git a/app/views/index.blade.php b/app/views/index.blade.php index 5a90e8ce31..fa9b896315 100644 --- a/app/views/index.blade.php +++ b/app/views/index.blade.php @@ -67,10 +67,10 @@
    - Recurring transactions + Bills
    -
    +
    diff --git a/app/views/list/recurring.blade.php b/app/views/list/bills.blade.php similarity index 80% rename from app/views/list/recurring.blade.php rename to app/views/list/bills.blade.php index cab075f3b0..1e4839a20a 100644 --- a/app/views/list/recurring.blade.php +++ b/app/views/list/bills.blade.php @@ -10,16 +10,16 @@     		Will be automatched Repeats every
    - - + +
    		- {{{$entry->name}}} + {{{$entry->name}}} @foreach(explode(',',$entry->match) as $match) diff --git a/app/views/list/journals-full.blade.php b/app/views/list/journals-full.blade.php index 61929f43d9..ffbaa2427f 100644 --- a/app/views/list/journals-full.blade.php +++ b/app/views/list/journals-full.blade.php @@ -15,8 +15,8 @@ @if(!isset($hideCategory) || (isset($hideCategory) && $hideCategory=== false))
    - @if($journal->recurringTransaction) - {{{$journal->recurringTransaction->name}}} + @if($journal->bill) + {{{$journal->bill->name}}} @endif @if($journal->transactiontype->type == 'Withdrawal') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Deposit') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Transfer') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif diff --git a/app/views/list/journals-small.blade.php b/app/views/list/journals-small.blade.php index 02ea6c7939..5643db3ad0 100644 --- a/app/views/list/journals-small.blade.php +++ b/app/views/list/journals-small.blade.php @@ -9,13 +9,13 @@ transactions[1]->amount);?> @if($journal->transactiontype->type == 'Withdrawal') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Deposit') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Transfer') - {{mf($journal->transactions[1]->amount,false)}} + {{mft($journal->transactions[1],false)}} @endif diff --git a/app/views/list/journals-tiny.blade.php b/app/views/list/journals-tiny.blade.php index 91c2b6f2d3..ff369db70c 100644 --- a/app/views/list/journals-tiny.blade.php +++ b/app/views/list/journals-tiny.blade.php @@ -18,13 +18,13 @@ @if(isset($account)) @foreach($journal->transactions as $index => $t) @if($t->account_id == $account->id) - {{mf($t->amount)}} + {{mft($t)}} @endif @endforeach @else @foreach($journal->transactions as $index => $t) @if($index == 0) - {{mf($t->amount)}} + {{mft($t)}} @endif @endforeach @endif diff --git a/app/views/transactions/show.blade.php b/app/views/transactions/show.blade.php index 5b86bd130a..8443184239 100644 --- a/app/views/transactions/show.blade.php +++ b/app/views/transactions/show.blade.php @@ -74,7 +74,7 @@
    {{{$jrnl->description}}}{{mf($jrnl->getAmount())}}{{mfj($jrnl, $jrnl->getAmount())}}
    @@ -97,7 +97,7 @@ - + diff --git a/bootstrap/functions.php b/bootstrap/functions.php new file mode 100644 index 0000000000..2424d07741 --- /dev/null +++ b/bootstrap/functions.php @@ -0,0 +1,166 @@ +transactionJournal->transactionCurrency->symbol; + $amount = floatval($transaction->amount); + + return mfc($symbol, $amount, $coloured); + + + } +} + +if (!function_exists('mfj')) { + /** + * @param \TransactionJournal $journal + * @param float $amount + * @param bool $coloured + * + * @return string + */ + function mfj(\TransactionJournal $journal, $amount, $coloured = true) + { + $symbol = $journal->transactionCurrency->symbol; + + return mfc($symbol, $amount, $coloured); + + + } +} + +if (!function_exists('mfc')) { + /** + * @param string $symbol + * @param float $amount + * @param bool $coloured + * + * @return string + */ + function mfc($symbol, $amount, $coloured = true) + { + $amount = floatval($amount); + $amount = round($amount, 2); + $string = number_format($amount, 2, ',', '.'); + + if ($coloured === true) { + if ($amount === 0.0) { + return '' . $symbol . ' ' . $string . ''; + } + if ($amount > 0) { + return '' . $symbol . ' ' . $string . ''; + } + + return '' . $symbol . ' ' . $string . ''; + } + + // € + return $symbol . ' ' . $string; + } +} + +if (!function_exists('getCurrencySymbol')) { + /** + * @return string + */ + function getCurrencySymbol() + { + if (defined('FFCURRENCYSYMBOL')) { + return FFCURRENCYSYMBOL; + } + if (Cache::has('FFCURRENCYSYMBOL')) { + define('FFCURRENCYSYMBOL', Cache::get('FFCURRENCYSYMBOL')); + + return FFCURRENCYSYMBOL; + } + + /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ + $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); + + /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ + $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); + + $currencyPreference = $preferences->get('currencyPreference', 'EUR'); + $currency = $currencies->findByCode($currencyPreference->data); + + Cache::forever('FFCURRENCYSYMBOL', $currency->symbol); + + define('FFCURRENCYSYMBOL', $currency->symbol); + + return $currency->symbol; + } +} + +if (!function_exists('getCurrencyCode')) { + /** + * @return string + */ + function getCurrencyCode() + { + if (defined('FFCURRENCYCODE')) { + return FFCURRENCYCODE; + } + if (Cache::has('FFCURRENCYCODE')) { + define('FFCURRENCYCODE', Cache::get('FFCURRENCYCODE')); + + return FFCURRENCYCODE; + } + + /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ + $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); + + /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ + $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); + + $currencyPreference = $preferences->get('currencyPreference', 'EUR'); + $currency = $currencies->findByCode($currencyPreference->data); + + Cache::forever('FFCURRENCYCODE', $currency->code); + + define('FFCURRENCYCODE', $currency->code); + + return $currency->code; + } +} + +if (!function_exists('boolstr')) { + /** + * @param $boolean + * + * @return string + */ + function boolstr($boolean) + { + if (is_bool($boolean) && $boolean === true) { + return 'BOOLEAN TRUE'; + } + if (is_bool($boolean) && $boolean === false) { + return 'BOOLEAN FALSE'; + } + + return 'NO BOOLEAN: ' . $boolean; + } +} \ No newline at end of file diff --git a/bootstrap/start.php b/bootstrap/start.php index 7395dfd718..a45a61456c 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -1,118 +1,6 @@ ' . $currencySymbol . ' ' . $string . ''; - } - if ($amount > 0) { - return '' . $currencySymbol . ' ' . $string . ''; - } - - return '' . $currencySymbol . ' ' . $string . ''; - } - - // € - return $currencySymbol . ' ' . $string; - } -} - -if (!function_exists('getCurrencySymbol')) { - /** - * @return string - */ - function getCurrencySymbol() - { - if (defined('FFCURRENCYSYMBOL')) { - return FFCURRENCYSYMBOL; - } - if (Cache::has('FFCURRENCYSYMBOL')) { - define('FFCURRENCYSYMBOL', Cache::get('FFCURRENCYSYMBOL')); - - return FFCURRENCYSYMBOL; - } - - /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ - $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); - - /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ - $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - - $currencyPreference = $preferences->get('currencyPreference', 'EUR'); - $currency = $currencies->findByCode($currencyPreference->data); - - Cache::forever('FFCURRENCYSYMBOL', $currency->symbol); - - define('FFCURRENCYSYMBOL', $currency->symbol); - - return $currency->symbol; - } -} - -if (!function_exists('getCurrencyCode')) { - /** - * @return string - */ - function getCurrencyCode() - { - if (defined('FFCURRENCYCODE')) { - return FFCURRENCYCODE; - } - if (Cache::has('FFCURRENCYCODE')) { - define('FFCURRENCYCODE', Cache::get('FFCURRENCYCODE')); - - return FFCURRENCYCODE; - } - - /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ - $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); - - /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ - $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - - $currencyPreference = $preferences->get('currencyPreference', 'EUR'); - $currency = $currencies->findByCode($currencyPreference->data); - - Cache::forever('FFCURRENCYCODE', $currency->code); - - define('FFCURRENCYCODE', $currency->code); - - return $currency->code; - } -} - -if (!function_exists('boolstr')) { - /** - * @param $boolean - * - * @return string - */ - function boolstr($boolean) - { - if (is_bool($boolean) && $boolean === true) { - return 'BOOLEAN TRUE'; - } - if (is_bool($boolean) && $boolean === false) { - return 'BOOLEAN FALSE'; - } - - return 'NO BOOLEAN: ' . $boolean; - } -} +include('functions.php'); $app = new Illuminate\Foundation\Application; diff --git a/tests/functional/CurrencyControllerCest.php b/tests/functional/CurrencyControllerCest.php index 0f59b4136f..47f4bf2ec2 100644 --- a/tests/functional/CurrencyControllerCest.php +++ b/tests/functional/CurrencyControllerCest.php @@ -41,8 +41,8 @@ class CurrencyControllerCest public function delete(FunctionalTester $I) { $I->wantTo('delete a currency'); - $I->amOnPage('/currency/delete/2'); - $I->see('Delete currency "US Dollar"'); + $I->amOnPage('/currency/delete/3'); + $I->see('Delete currency "Hungarian forint"'); } /** @@ -51,10 +51,10 @@ class CurrencyControllerCest public function destroy(FunctionalTester $I) { $I->wantTo('destroy a currency'); - $I->amOnPage('/currency/delete/2'); - $I->see('Delete currency "US Dollar"'); + $I->amOnPage('/currency/delete/3'); + $I->see('Delete currency "Hungarian forint"'); $I->submitForm('#destroy', []); - $I->see('Currency "US Dollar" deleted'); + $I->see('Currency "Hungarian forint" deleted'); } /** From b451e207e2b141c80539b05abe7a7003b21375be Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 15:17:01 +0100 Subject: [PATCH 26/84] Finally implemented repeated expenses properly. [skip ci] --- app/controllers/HelpController.php | 5 + app/controllers/RepeatedExpenseController.php | 159 ++++++++++--- .../Database/PiggyBank/PiggyBank.php | 224 +----------------- .../Database/PiggyBank/PiggyBankShared.php | 220 +++++++++++++++++ .../Database/PiggyBank/RepeatedExpense.php | 185 +-------------- app/lib/FireflyIII/Shared/Toolkit/Date.php | 3 + app/models/Piggybank.php | 4 +- app/routes.php | 42 +++- app/views/piggy_banks/index.blade.php | 39 ++- app/views/repeatedexpense/delete.blade.php | 37 +++ app/views/repeatedexpense/edit.blade.php | 97 ++++++++ app/views/repeatedexpense/index.blade.php | 35 ++- app/views/repeatedexpense/show.blade.php | 4 +- app/views/reports/budget.blade.php | 39 ++- public/assets/javascript/firefly/help.js | 3 + .../functional/PreferencesControllerCest.php | 3 + tests/functional/RepeatedExpenseCest.php | 23 ++ 17 files changed, 648 insertions(+), 474 deletions(-) create mode 100644 app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php create mode 100644 app/views/repeatedexpense/delete.blade.php create mode 100644 app/views/repeatedexpense/edit.blade.php create mode 100644 tests/functional/RepeatedExpenseCest.php diff --git a/app/controllers/HelpController.php b/app/controllers/HelpController.php index ee5f57fbfc..ee600767c5 100644 --- a/app/controllers/HelpController.php +++ b/app/controllers/HelpController.php @@ -32,6 +32,11 @@ class HelpController extends BaseController } catch (ErrorException $e) { $content = '

    There is no help for this route.

    '; } + if (strlen($content) == 0) { + $content = '

    There is no help for this route.

    '; + } + \Log::debug('Found help for ' . $route); + \Log::debug('Help text length is ' . strlen($content)); $helpText = \Michelf\Markdown::defaultTransform($content); $helpTitle = $route; diff --git a/app/controllers/RepeatedExpenseController.php b/app/controllers/RepeatedExpenseController.php index 20c73aeee8..a8e3d4dc73 100644 --- a/app/controllers/RepeatedExpenseController.php +++ b/app/controllers/RepeatedExpenseController.php @@ -35,11 +35,68 @@ class RepeatedExpenseController extends BaseController $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); - return View::make('repeatedexpense.create', compact('accounts', 'periods'))->with('subTitle', 'Create new repeated expense')->with( + return View::make('repeatedExpense.create', compact('accounts', 'periods'))->with('subTitle', 'Create new repeated expense')->with( 'subTitleIcon', 'fa-plus' ); } + /** + * @param PiggyBank $repeatedExpense + * + * @return $this + */ + public function delete(PiggyBank $repeatedExpense) + { + $subTitle = 'Delete "' . e($repeatedExpense->name) . '"'; + + return View::make('repeatedExpense.delete', compact('repeatedExpense', 'subTitle')); + } + + /** + * @param PiggyBank $repeatedExpense + * + * @return \Illuminate\Http\RedirectResponse + */ + public function destroy(PiggyBank $repeatedExpense) + { + + Session::flash('success', 'Repeated expense "' . e($repeatedExpense->name) . '" deleted.'); + $this->_repository->destroy($repeatedExpense); + + return Redirect::route('repeated.index'); + } + + /** + * @param PiggyBank $repeatedExpense + * + * @return $this + */ + public function edit(PiggyBank $repeatedExpense) + { + + /** @var \FireflyIII\Database\Account\Account $acct */ + $acct = App::make('FireflyIII\Database\Account\Account'); + + $periods = Config::get('firefly.piggy_bank_periods'); + $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); + $subTitle = 'Edit repeated expense "' . e($repeatedExpense->name) . '"'; + $subTitleIcon = 'fa-pencil'; + + /* + * Flash some data to fill the form. + */ + $preFilled = ['name' => $repeatedExpense->name, + 'account_id' => $repeatedExpense->account_id, + 'targetamount' => $repeatedExpense->targetamount, + 'targetdate' => $repeatedExpense->targetdate->format('Y-m-d'), + 'reminder' => $repeatedExpense->reminder, + 'remind_me' => intval($repeatedExpense->remind_me) == 1 || !is_null($repeatedExpense->reminder) ? true : false + ]; + Session::flash('preFilled', $preFilled); + + return View::make('repeatedExpense.edit', compact('subTitle', 'subTitleIcon', 'repeatedExpense', 'accounts', 'periods', 'preFilled')); + } + /** * @return \Illuminate\View\View */ @@ -48,50 +105,51 @@ class RepeatedExpenseController extends BaseController $subTitle = 'Overview'; - /** @var \FireflyIII\Database\PiggyBank\RepeatedExpense $repository */ - $repository = App::make('FireflyIII\Database\PiggyBank\RepeatedExpense'); - - $expenses = $repository->get(); + $expenses = $this->_repository->get(); $expenses->each( - function (PiggyBank $piggyBank) use ($repository) { + function (PiggyBank $piggyBank) { $piggyBank->currentRelevantRep(); } ); - return View::make('repeatedexpense.index', compact('expenses', 'subTitle')); + return View::make('repeatedExpense.index', compact('expenses', 'subTitle')); } /** - * @param PiggyBank $piggyBank + * @param PiggyBank $repeatedExpense * * @return \Illuminate\View\View */ - public function show(PiggyBank $piggyBank) + public function show(PiggyBank $repeatedExpense) { - $subTitle = $piggyBank->name; + $subTitle = $repeatedExpense->name; $today = Carbon::now(); - /** @var \FireflyIII\Database\PiggyBank\RepeatedExpense $repository */ - $repository = App::make('FireflyIII\Database\PiggyBank\RepeatedExpense'); - - $repetitions = $piggyBank->piggyBankRepetitions()->get(); + $repetitions = $repeatedExpense->piggyBankRepetitions()->get(); $repetitions->each( - function (PiggyBankRepetition $repetition) use ($repository) { - $repetition->bars = $repository->calculateParts($repetition); + function (PiggyBankRepetition $repetition) { + $repetition->bars = $this->_repository->calculateParts($repetition); } ); - return View::make('repeatedexpense.show', compact('repetitions', 'piggyBank', 'today', 'subTitle')); + return View::make('repeatedExpense.show', compact('repetitions', 'repeatedExpense', 'today', 'subTitle')); } /** - * @return $this - * @throws FireflyException + * */ public function store() { - $data = Input::except('_token'); - $data['repeats'] = 1; + $data = Input::all(); + $data['repeats'] = 1; + $data['user_id'] = Auth::user()->id; + $targetDate = new Carbon($data['targetdate']); + $startDate = \DateKit::subtractPeriod($targetDate, $data['rep_length']); + $data['startdate'] = $startDate->format('Y-m-d'); + $data['targetdate'] = $targetDate->format('Y-m-d'); + $data['reminder_skip'] = 0; + $data['remind_me'] = isset($data['remind_me']) ? 1 : 0; + $data['order'] = 0; // always validate: $messages = $this->_repository->validate($data); @@ -101,25 +159,70 @@ class RepeatedExpenseController extends BaseController Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); if ($messages['errors']->count() > 0) { - Session::flash('error', 'Could not validate repeated expense: ' . $messages['errors']->first()); + Session::flash('error', 'Could not store repeated expense: ' . $messages['errors']->first()); } + + // return to create screen: if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { return Redirect::route('repeated.create')->withInput(); } // store: - $this->_repository->store($data); - Session::flash('success', 'Budget "' . e($data['name']) . '" stored.'); + $piggyBank = $this->_repository->store($data); + Event::fire('piggy_bank.store', [$piggyBank]); // new and used. + Session::flash('success', 'Piggy bank "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { return Redirect::route('repeated.index'); } - // create another. - if ($data['post_submit_action'] == 'create_another') { - return Redirect::route('repeated.create')->withInput(); + return Redirect::route('repeated.create')->withInput(); + } + + /** + * @param PiggyBank $repeatedExpense + * + * @return $this + * @throws FireflyException + */ + public function update(PiggyBank $repeatedExpense) + { + + $data = Input::except('_token'); + $data['rep_every'] = 0; + $data['reminder_skip'] = 0; + $data['order'] = 0; + $data['repeats'] = 1; + $data['remind_me'] = isset($data['remind_me']) ? 1 : 0; + $data['user_id'] = Auth::user()->id; + + // always validate: + $messages = $this->_repository->validate($data); + + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not update repeated expense: ' . $messages['errors']->first()); } - return Redirect::route('repeated.index'); + // return to update screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('repeated.edit', $repeatedExpense->id)->withInput(); + } + + // update + $this->_repository->update($repeatedExpense, $data); + Session::flash('success', 'Repeated expense "' . e($data['name']) . '" updated.'); + + // go back to list + if ($data['post_submit_action'] == 'update') { + return Redirect::route('repeated.index'); + } + + // go back to update screen. + return Redirect::route('repeated.edit', $repeatedExpense->id)->withInput(['post_submit_action' => 'return_to_edit']); + } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index 594e5ad75b..a6313626ca 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -4,223 +4,18 @@ namespace FireflyIII\Database\PiggyBank; use Carbon\Carbon; use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; -use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; -use Illuminate\Support\MessageBag; /** * Class PiggyBank * * @package FireflyIII\Database */ -class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface +class PiggyBank extends PiggyBankShared implements CUD, CommonDatabaseCalls, PiggyBankInterface { - use SwitchUser; - - /** - * - */ - public function __construct() - { - $this->setUser(\Auth::user()); - } - - /** - * @param Eloquent $model - * - * @return bool - */ - public function destroy(Eloquent $model) - { - $model->delete(); - - } - - /** - * @param array $data - * - * @return \Eloquent - * @throws FireflyException - */ - public function store(array $data) - { - if (!isset($data['remind_me']) || (isset($data['remind_me']) && $data['remind_me'] == 0)) { - $data['reminder'] = null; - } - $piggyBank = new \PiggyBank($data); - $piggyBank->save(); - - return $piggyBank; - } - - /** - * @param Eloquent $model - * @param array $data - * - * @return bool - */ - public function update(Eloquent $model, array $data) - { - /** @var \PiggyBank $model */ - $model->name = $data['name']; - $model->account_id = intval($data['account_id']); - $model->targetamount = floatval($data['targetamount']); - $model->targetdate = isset($data['targetdate']) && $data['targetdate'] != '' ? $data['targetdate'] : null; - $model->rep_every = intval($data['rep_every']); - $model->reminder_skip = intval($data['reminder_skip']); - $model->order = intval($data['order']); - $model->remind_me = intval($data['remind_me']); - $model->reminder = isset($data['reminder']) ? $data['reminder'] : 'month'; - - if ($model->remind_me == 0) { - $model->reminder = null; - } - - $model->save(); - - return true; - } - - /** - * Validates an array. Returns an array containing MessageBags - * errors/warnings/successes. - * - * Ignore PHPMD rules because Laravel 5.0 will make this method superfluous anyway. - * - * @param array $model - * - * @return array - */ - public function validate(array $model) - { - $warnings = new MessageBag; - $successes = new MessageBag; - $errors = new MessageBag; - - /* - * Name validation: - */ - if (!isset($model['name'])) { - $errors->add('name', 'Name is mandatory'); - } - - if (isset($model['name']) && strlen($model['name']) == 0) { - $errors->add('name', 'Name is too short'); - } - if (isset($model['name']) && strlen($model['name']) > 100) { - $errors->add('name', 'Name is too long'); - } - - if (intval($model['account_id']) == 0) { - $errors->add('account_id', 'Account is mandatory'); - } - if ($model['targetdate'] == '' && isset($model['remind_me']) && intval($model['remind_me']) == 1) { - $errors->add('targetdate', 'Target date is mandatory when setting reminders.'); - } - if ($model['targetdate'] != '') { - try { - new Carbon($model['targetdate']); - } catch (\Exception $e) { - $errors->add('targetdate', 'Invalid date.'); - } - } - if (floatval($model['targetamount']) < 0.01) { - $errors->add('targetamount', 'Amount should be above 0.01.'); - } - if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { - $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); - } - // check period. - if (!$errors->has('reminder') && !$errors->has('targetdate') && isset($model['remind_me']) && intval($model['remind_me']) == 1) { - $today = new Carbon; - $target = new Carbon($model['targetdate']); - switch ($model['reminder']) { - case 'week': - $today->addWeek(); - break; - case 'month': - $today->addMonth(); - break; - case 'year': - $today->addYear(); - break; - } - if ($today > $target) { - $errors->add('reminder', 'Target date is too close to today to set reminders.'); - } - } - - $validator = \Validator::make($model, \PiggyBank::$rules); - if ($validator->invalid()) { - $errors->merge($errors); - } - - // add ok messages. - $list = ['name', 'account_id', 'targetamount', 'targetdate', 'remind_me', 'reminder']; - foreach ($list as $entry) { - if (!$errors->has($entry) && !$warnings->has($entry)) { - $successes->add($entry, 'OK'); - } - } - - return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; - } - - /** - * Returns an object with id $id. - * - * @param int $objectId - * - * @return \Eloquent - */ - public function find($objectId) - { - return \PiggyBank:: - leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')->where('piggy_banks.id', '=', $objectId)->where( - 'accounts.user_id', $this->getUser()->id - ) - ->first(['piggy_banks.*']); - } - - /** - * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. - * - * @param $what - * - * @return \AccountType|null - * @throws NotImplementedException - */ - public function findByWhat($what) - { - // TODO: Implement findByWhat() method. - throw new NotImplementedException; - } - - /** - * Returns all objects. - * - * @return Collection - */ - public function get() - { - return $this->getUser()->piggyBanks()->where('repeats', 0)->orderBy('name')->get(); - } - - /** - * @param array $ids - * - * @return Collection - * @throws NotImplementedException - */ - public function getByIds(array $ids) - { - // TODO: Implement getByIds() method. - throw new NotImplementedException; - } - /** * @param \PiggyBank $piggyBank * @param Carbon $date @@ -257,21 +52,12 @@ class PiggyBank implements CUD, CommonDatabaseCalls, PiggyBankInterface } /** - * @param \Account $account + * Returns all objects. * - * @return float + * @return Collection */ - public function leftOnAccount(\Account $account) + public function get() { - \Log::debug('Now in leftOnAccount() for account #'.$account->id.' ('.$account->name.')'); - $balance = \Steam::balance($account); - \Log::debug('Steam says: ' . $balance); - /** @var \PiggyBank $p */ - foreach ($account->piggyBanks()->get() as $p) { - $balance -= $p->currentRelevantRep()->currentamount; - } - - return $balance; - + return $this->getUser()->piggyBanks()->where('repeats', 0)->orderBy('name')->get(); } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php new file mode 100644 index 0000000000..973617267e --- /dev/null +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -0,0 +1,220 @@ +setUser(\Auth::user()); + } + + /** + * @param Eloquent $model + * + * @return bool + */ + public function destroy(Eloquent $model) + { + $model->delete(); + + } + + /** + * Returns an object with id $id. + * + * @param int $objectId + * + * @return \Eloquent + */ + public function find($objectId) + { + return \PiggyBank:: + leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')->where('piggy_banks.id', '=', $objectId)->where( + 'accounts.user_id', $this->getUser()->id + ) + ->first(['piggy_banks.*']); + } + + /** + * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. + * + * @param $what + * + * @return \AccountType|null + * @throws NotImplementedException + */ + public function findByWhat($what) + { + // TODO: Implement findByWhat() method. + throw new NotImplementedException; + } + + /** + * @param array $ids + * + * @return Collection + * @throws NotImplementedException + */ + public function getByIds(array $ids) + { + return \PiggyBank:: + leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id')->whereIn('piggy_banks.id', [$ids])->where( + 'accounts.user_id', $this->getUser()->id + ) + ->first(['piggy_banks.*']); + } + + /** + * @param \Account $account + * + * @return float + */ + public function leftOnAccount(\Account $account) + { + \Log::debug('Now in leftOnAccount() for account #' . $account->id . ' (' . $account->name . ')'); + $balance = \Steam::balance($account); + \Log::debug('Steam says: ' . $balance); + /** @var \PiggyBank $p */ + foreach ($account->piggyBanks()->get() as $p) { + $balance -= $p->currentRelevantRep()->currentamount; + } + + return $balance; + + } + + /** + * @param array $data + * + * @return \Eloquent + * @throws FireflyException + */ + public function store(array $data) + { + if (!isset($data['remind_me']) || (isset($data['remind_me']) && $data['remind_me'] == 0)) { + $data['reminder'] = null; + } + $piggyBank = new \PiggyBank($data); + $piggyBank->save(); + + return $piggyBank; + } + + + /** + * @param Eloquent $model + * @param array $data + * + * @return bool + */ + public function update(Eloquent $model, array $data) + { + /** @var \PiggyBank $model */ + $model->name = $data['name']; + $model->account_id = intval($data['account_id']); + $model->targetamount = floatval($data['targetamount']); + $model->targetdate = isset($data['targetdate']) && $data['targetdate'] != '' ? $data['targetdate'] : null; + $model->rep_every = intval($data['rep_every']); + $model->reminder_skip = intval($data['reminder_skip']); + $model->order = intval($data['order']); + $model->remind_me = intval($data['remind_me']); + $model->reminder = isset($data['reminder']) ? $data['reminder'] : 'month'; + + if ($model->remind_me == 0) { + $model->reminder = null; + } + + $model->save(); + + return true; + } + + /** + * Validates an array. Returns an array containing MessageBags + * errors/warnings/successes. + * + * Ignore PHPMD rules because Laravel 5.0 will make this method superfluous anyway. + * + * @param array $model + * + * @return array + */ + public function validate(array $model) + { + $warnings = new MessageBag; + $successes = new MessageBag; + $model = new \PiggyBank($model); + $model->isValid(); + $errors = $model->getErrors(); + + // add ok messages. + $list = ['name', 'account_id', 'targetamount', 'targetdate', 'remind_me', 'reminder']; + foreach ($list as $entry) { + if (!$errors->has($entry) && !$warnings->has($entry)) { + $successes->add($entry, 'OK'); + } + } + + + return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; + + exit; + + if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { + $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); + } + // check period. + if (!$errors->has('reminder') && !$errors->has('targetdate') && isset($model['remind_me']) && intval($model['remind_me']) == 1) { + $today = new Carbon; + $target = new Carbon($model['targetdate']); + switch ($model['reminder']) { + case 'week': + $today->addWeek(); + break; + case 'month': + $today->addMonth(); + break; + case 'year': + $today->addYear(); + break; + } + if ($today > $target) { + $errors->add('reminder', 'Target date is too close to today to set reminders.'); + } + } + + $validator = \Validator::make($model, \PiggyBank::$rules); + if ($validator->invalid()) { + $errors->merge($errors); + } + + // add ok messages. + $list = ['name', 'account_id', 'targetamount', 'targetdate', 'remind_me', 'reminder']; + foreach ($list as $entry) { + if (!$errors->has($entry) && !$warnings->has($entry)) { + $successes->add($entry, 'OK'); + } + } + + return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; + } + +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index d0d35947b3..f6edef18d2 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -3,7 +3,6 @@ namespace FireflyIII\Database\PiggyBank; -use Carbon\Carbon; use FireflyIII\Collection\PiggyBankPart; use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; @@ -11,24 +10,14 @@ use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; -use Illuminate\Support\MessageBag; /** * Class RepeatedExpense * * @package FireflyIII\Database */ -class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface +class RepeatedExpense extends PiggyBankShared implements CUD, CommonDatabaseCalls, PiggyBankInterface { - use SwitchUser; - - /** - * - */ - public function __construct() - { - $this->setUser(\Auth::user()); - } /** * Based on the piggy bank, the reminder-setting and @@ -97,17 +86,6 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface return $part; } - /** - * @param Eloquent $model - * - * @return bool - * @throws NotImplementedException - */ - public function destroy(Eloquent $model) - { - // TODO: Implement destroy() method. - throw new NotImplementedException; - } /** * @param array $data @@ -134,144 +112,6 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface return $repeated; } - /** - * @param Eloquent $model - * @param array $data - * - * @return bool - * @throws NotImplementedException - */ - public function update(Eloquent $model, array $data) - { - // TODO: Implement update() method. - throw new NotImplementedException; - } - - /** - * Validates an array. Returns an array containing MessageBags - * errors/warnings/successes. - * - * - * ignored because this method will be gone soon. - * - * @param array $model - * - * @return array - */ - public function validate(array $model) - { - $warnings = new MessageBag; - $successes = new MessageBag; - $errors = new MessageBag; - - /* - * Name validation: - */ - if (!isset($model['name'])) { - $errors->add('name', 'Name is mandatory'); - } - - if (isset($model['name']) && strlen($model['name']) == 0) { - $errors->add('name', 'Name is too short'); - } - if (isset($model['name']) && strlen($model['name']) > 100) { - $errors->add('name', 'Name is too long'); - } - - if (intval($model['account_id']) == 0) { - $errors->add('account_id', 'Account is mandatory'); - } - if ($model['targetdate'] == '' && isset($model['remind_me']) && intval($model['remind_me']) == 1) { - $errors->add('targetdate', 'Target date is mandatory when setting reminders.'); - } - if ($model['targetdate'] != '') { - try { - new Carbon($model['targetdate']); - } catch (\Exception $e) { - $errors->add('targetdate', 'Invalid date.'); - } - $diff = Carbon::now()->diff(new Carbon($model['targetdate'])); - if ($diff->days > 365) { - $errors->add('targetdate', 'First target date should a a year or less from now.'); - } - } else { - $errors->add('targetdate', 'Invalid target date.'); - } - if (floatval($model['targetamount']) < 0.01) { - $errors->add('targetamount', 'Amount should be above 0.01.'); - } - if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { - $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); - } - - if (!in_array(ucfirst($model['rep_length']), \Config::get('firefly.piggy_bank_periods'))) { - $errors->add('rep_length', 'Invalid repeat period (' . $model['rep_length'] . ')'); - } - - // check period. - if (!$errors->has('reminder') && !$errors->has('targetdate') && isset($model['remind_me']) && intval($model['remind_me']) == 1) { - $today = new Carbon; - $target = new Carbon($model['targetdate']); - switch ($model['reminder']) { - case 'week': - $today->addWeek(); - break; - case 'month': - $today->addMonth(); - break; - case 'year': - $today->addYear(); - break; - } - if ($today > $target) { - $errors->add('reminder', 'Target date is too close to today to set reminders.'); - } - } - - $validator = \Validator::make($model, \PiggyBank::$rules); - if ($validator->invalid()) { - $errors->merge($errors); - } - - // add ok messages. - $list = ['name', 'account_id', 'rep_every', 'rep_times', 'rep_length', 'targetamount', 'targetdate', 'remind_me', 'reminder']; - foreach ($list as $entry) { - if (!$errors->has($entry) && !$warnings->has($entry)) { - $successes->add($entry, 'OK'); - } - } - - return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; - } - - /** - * Returns an object with id $id. - * - * @param int $objectId - * - * @return \Eloquent - * @throws NotImplementedException - */ - public function find($objectId) - { - // TODO: Implement find() method. - throw new NotImplementedException; - } - - /** - * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. - * - * @param $what - * - * @return \AccountType|null - * @throws NotImplementedException - */ - public function findByWhat($what) - { - // TODO: Implement findByWhat() method. - throw new NotImplementedException; - } - /** * Returns all objects. * @@ -282,27 +122,4 @@ class RepeatedExpense implements CUD, CommonDatabaseCalls, PiggyBankInterface return $this->getUser()->piggyBanks()->where('repeats', 1)->get(); } - /** - * @param array $ids - * - * @return Collection - * @throws NotImplementedException - */ - public function getByIds(array $ids) - { - // TODO: Implement getByIds() method. - throw new NotImplementedException; - } - - /** - * @param \Account $account - * - * @return float - * @throws NotImplementedException - */ - public function leftOnAccount(\Account $account) - { - // TODO: Implement leftOnAccount() method. - throw new NotImplementedException; - } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Shared/Toolkit/Date.php b/app/lib/FireflyIII/Shared/Toolkit/Date.php index 09ee90cabe..9f563d3706 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Date.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Date.php @@ -241,12 +241,15 @@ class Date default: throw new FireflyException('Cannot do subtractPeriod for $repeat_freq ' . $repeatFreq); break; + case 'day': case 'daily': $date->subDays($subtract); break; + case 'week': case 'weekly': $date->subWeeks($subtract); break; + case 'month': case 'monthly': $date->subMonths($subtract); break; diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 75880a15bc..9f5b6a942f 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -9,10 +9,10 @@ use Watson\Validating\ValidatingTrait; class PiggyBank extends Eloquent { use ValidatingTrait; - public static $rules + protected $rules = ['account_id' => 'required|exists:accounts,id', // link to Account 'name' => 'required|between:1,255', // name - 'targetamount' => 'required|min:0', // amount you want to save + 'targetamount' => 'required|min:0.01|numeric', // amount you want to save 'startdate' => 'date', // when you started 'targetdate' => 'date', // when its due 'repeats' => 'required|boolean', // does it repeat? diff --git a/app/routes.php b/app/routes.php index efaf3ee653..bb410221aa 100644 --- a/app/routes.php +++ b/app/routes.php @@ -119,7 +119,7 @@ Route::bind( ); Route::bind( - 'piggy_bank', function ($value, $route) { + 'piggyBank', function ($value, $route) { if (Auth::check()) { return PiggyBank:: where('piggy_banks.id', $value) @@ -132,6 +132,20 @@ Route::bind( } ); +Route::bind( + 'repeatedExpense', function ($value, $route) { + if (Auth::check()) { + return PiggyBank:: + where('piggy_banks.id', $value) + ->leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') + ->where('accounts.user_id', Auth::user()->id) + ->where('repeats', 1)->first(['piggy_banks.*']); + } + + return null; +} +); + Route::bind( 'repeated', function ($value, $route) { if (Auth::check()) { @@ -198,7 +212,7 @@ Route::group( Route::get('/chart/reports/income-expenses-sum/{year}', ['uses' => 'GoogleChartController@yearInExpSum']); Route::get('/chart/bills/{bill}', ['uses' => 'GoogleChartController@billOverview']); Route::get('/chart/budget/{budget}/{limitrepetition}', ['uses' => 'GoogleChartController@budgetLimitSpending']); - Route::get('/chart/piggy_history/{piggy_bank}', ['uses' => 'GoogleChartController@piggyBankHistory']); + Route::get('/chart/piggy_history/{piggyBank}', ['uses' => 'GoogleChartController@piggyBankHistory']); // google chart for components (categories + budgets combined) Route::get('/chart/budget/{budget}/spending/{year}', ['uses' => 'GoogleChartController@budgetsAndSpending']); @@ -219,13 +233,13 @@ Route::group( // piggy bank controller Route::get('/piggy_banks', ['uses' => 'PiggyBankController@index', 'as' => 'piggy_banks.index']); - Route::get('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggyBankController@add']); # add money - Route::get('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggyBankController@remove']); #remove money + Route::get('/piggy_banks/add/{piggyBank}', ['uses' => 'PiggyBankController@add']); # add money + Route::get('/piggy_banks/remove/{piggyBank}', ['uses' => 'PiggyBankController@remove']); #remove money Route::get('/piggy_banks/create', ['uses' => 'PiggyBankController@create', 'as' => 'piggy_banks.create']); - Route::get('/piggy_banks/edit/{piggy_bank}', ['uses' => 'PiggyBankController@edit', 'as' => 'piggy_banks.edit']); - Route::get('/piggy_banks/delete/{piggy_bank}', ['uses' => 'PiggyBankController@delete', 'as' => 'piggy_banks.delete']); - Route::get('/piggy_banks/show/{piggy_bank}', ['uses' => 'PiggyBankController@show', 'as' => 'piggy_banks.show']); + Route::get('/piggy_banks/edit/{piggyBank}', ['uses' => 'PiggyBankController@edit', 'as' => 'piggy_banks.edit']); + Route::get('/piggy_banks/delete/{piggyBank}', ['uses' => 'PiggyBankController@delete', 'as' => 'piggy_banks.delete']); + Route::get('/piggy_banks/show/{piggyBank}', ['uses' => 'PiggyBankController@show', 'as' => 'piggy_banks.show']); // preferences controller Route::get('/preferences', ['uses' => 'PreferencesController@index', 'as' => 'preferences']); @@ -245,7 +259,9 @@ Route::group( // repeated expenses controller: Route::get('/repeatedexpenses', ['uses' => 'RepeatedExpenseController@index', 'as' => 'repeated.index']); Route::get('/repeatedexpenses/create', ['uses' => 'RepeatedExpenseController@create', 'as' => 'repeated.create']); - Route::get('/repeatedexpenses/show/{repeated}', ['uses' => 'RepeatedExpenseController@show', 'as' => 'repeated.show']); + Route::get('/repeatedexpenses/edit/{repeatedExpense}', ['uses' => 'RepeatedExpenseController@edit', 'as' => 'repeated.edit']); + Route::get('/repeatedexpenses/delete/{repeatedExpense}', ['uses' => 'RepeatedExpenseController@delete', 'as' => 'repeated.delete']); + Route::get('/repeatedexpenses/show/{repeatedExpense}', ['uses' => 'RepeatedExpenseController@show', 'as' => 'repeated.show']); // report controller: Route::get('/reports', ['uses' => 'ReportController@index', 'as' => 'reports.index']); @@ -314,13 +330,15 @@ Route::group( // piggy bank controller Route::post('/piggy_banks/store', ['uses' => 'PiggyBankController@store', 'as' => 'piggy_banks.store']); - Route::post('/piggy_banks/update/{piggy_bank}', ['uses' => 'PiggyBankController@update', 'as' => 'piggy_banks.update']); - Route::post('/piggy_banks/destroy/{piggy_bank}', ['uses' => 'PiggyBankController@destroy', 'as' => 'piggy_banks.destroy']); - Route::post('/piggy_banks/add/{piggy_bank}', ['uses' => 'PiggyBankController@postAdd', 'as' => 'piggy_banks.add']); # add money - Route::post('/piggy_banks/remove/{piggy_bank}', ['uses' => 'PiggyBankController@postRemove', 'as' => 'piggy_banks.remove']); # remove money. + Route::post('/piggy_banks/update/{piggyBank}', ['uses' => 'PiggyBankController@update', 'as' => 'piggy_banks.update']); + Route::post('/piggy_banks/destroy/{piggyBank}', ['uses' => 'PiggyBankController@destroy', 'as' => 'piggy_banks.destroy']); + Route::post('/piggy_banks/add/{piggyBank}', ['uses' => 'PiggyBankController@postAdd', 'as' => 'piggy_banks.add']); # add money + Route::post('/piggy_banks/remove/{piggyBank}', ['uses' => 'PiggyBankController@postRemove', 'as' => 'piggy_banks.remove']); # remove money. // repeated expense controller Route::post('/repeatedexpense/store', ['uses' => 'RepeatedExpenseController@store', 'as' => 'repeated.store']); + Route::post('/repeatedexpense/update/{repeatedExpense}', ['uses' => 'RepeatedExpenseController@update', 'as' => 'repeated.update']); + Route::post('/repeatedexpense/destroy/{repeatedExpense}', ['uses' => 'RepeatedExpenseController@destroy', 'as' => 'repeated.destroy']); // preferences controller Route::post('/preferences', ['uses' => 'PreferencesController@postIndex']); diff --git a/app/views/piggy_banks/index.blade.php b/app/views/piggy_banks/index.blade.php index 79c05a28b4..5c99d9951e 100644 --- a/app/views/piggy_banks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -1,12 +1,34 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} +
    +
    +

    + Create new piggy bank +

    +
    +
    @foreach($piggyBanks as $piggyBank)
    {{{$piggyBank->name}}} + + +
    +
    + + +
    +
    +
    @@ -61,19 +83,10 @@
    @endforeach
    -
    -
    -
    - Create piggy bank -
    -
    -
    -
    - Create new piggy bank -
    -
    -
    -
    +
    +

    + Create new piggy bank +

    diff --git a/app/views/repeatedexpense/delete.blade.php b/app/views/repeatedexpense/delete.blade.php new file mode 100644 index 0000000000..0c1e15277b --- /dev/null +++ b/app/views/repeatedexpense/delete.blade.php @@ -0,0 +1,37 @@ +@extends('layouts.default') +@section('content') +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $repeatedExpense) }} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('repeated.destroy',$repeatedExpense->id)])}} +
    +
    +
    +
    + Delete repeated expense "{{{$repeatedExpense->name}}}" +
    +
    +

    + Are you sure? +

    + +

    + + Cancel +

    +
    +
    +
    +
    + +
    +
    +
    +
    + +
    +
    +
    +
    + + +{{Form::close()}} +@stop \ No newline at end of file diff --git a/app/views/repeatedexpense/edit.blade.php b/app/views/repeatedexpense/edit.blade.php new file mode 100644 index 0000000000..8464cf0866 --- /dev/null +++ b/app/views/repeatedexpense/edit.blade.php @@ -0,0 +1,97 @@ +@extends('layouts.default') +@section('content') +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $repeatedExpense) }} +{{Form::model($repeatedExpense, ['class' => 'form-horizontal','id' => 'update','url' => route('repeated.update',$repeatedExpense->id)])}} + +
    +
    +
    +
    + Mandatory fields +
    +
    + {{Form::ffText('name')}} + {{Form::ffSelect('account_id',$accounts,null,['label' => 'Save on account'])}} + {{Form::ffAmount('targetamount')}} + {{Form::ffDate('targetdate',null,['label' => 'First target date'])}} + {{Form::ffSelect('rep_length',$periods,null,['label' => 'Repeats every'])}} + {{Form::ffInteger('rep_every',null,['label' => 'Skip period'])}} + {{Form::ffInteger('rep_times',null,['label' => 'Repeat times'])}} + +
    +
    +

    + +

    +
    +
    + +
    +
    + Optional fields +
    +
    + {{Form::ffCheckbox('remind_me','1',$preFilled['remind_me'],['label' => 'Remind me'])}} + {{Form::ffSelect('reminder',$periods,$preFilled['reminder'],['label' => 'Remind every'])}} +
    +
    + + +
    +
    + Options +
    +
    + {{Form::ffOptionsList('update','piggy bank')}} +
    +
    + +
    +
    +{{-- + +

    Mandatory fields

    + +

    Optional fields

    + + +
    + {{ Form::label('reminder', 'Remind you every', ['class' => 'col-sm-4 control-label'])}} +
    + + + + @if($errors->has('reminder')) +

    {{$errors->first('reminder')}}

    + @else + Enter a number and a period and Firefly will remind you to add money + to this piggy bank every now and then. + @endif +
    +
    + + +
    +
    + +
    +
    + +
    +
    + +
    +
    +
    +
    +--}} + +{{Form::close()}} +@stop diff --git a/app/views/repeatedexpense/index.blade.php b/app/views/repeatedexpense/index.blade.php index 6e002dc25a..496107e0bf 100644 --- a/app/views/repeatedexpense/index.blade.php +++ b/app/views/repeatedexpense/index.blade.php @@ -4,24 +4,34 @@

    - Create new repeated expense + Create new repeated expense

    + + +@foreach($expenses as $entry)
    - -
    -
    - -
    -@foreach($expenses as $entry) -
    {{{$entry->name}}} ({{mf($entry->targetamount)}}) + + +
    +
    + + +
    +
    @@ -40,7 +50,16 @@
    +
    @endforeach + +
    +
    +

    + Create new repeated expense +

    + +
    diff --git a/app/views/repeatedexpense/show.blade.php b/app/views/repeatedexpense/show.blade.php index 71f0077d59..bce4474181 100644 --- a/app/views/repeatedexpense/show.blade.php +++ b/app/views/repeatedexpense/show.blade.php @@ -1,6 +1,6 @@ @extends('layouts.default') @section('content') -{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $piggyBank) }} +{{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $repeatedExpense) }}
    @foreach($repetitions as $rep) @@ -21,7 +21,7 @@

    - Target amount: {{mf($piggyBank->targetamount)}}. Currently saved: {{mf($rep->currentamount)}}. + Target amount: {{mf($repeatedExpense->targetamount)}}. Currently saved: {{mf($rep->currentamount)}}.

    @foreach($rep->bars as $bar) diff --git a/app/views/reports/budget.blade.php b/app/views/reports/budget.blade.php index 359eb13628..86b15e7123 100644 --- a/app/views/reports/budget.blade.php +++ b/app/views/reports/budget.blade.php @@ -42,12 +42,22 @@
    @foreach($budgets as $id => $budget) - + @foreach($accounts as $account) @if(isset($account->budgetInformation[$id])) - + budgetInformation[$id]['amount']); $accountSums[$account->id] += floatval($account->budgetInformation[$id]['amount']); @@ -61,10 +71,14 @@ @endforeach - + @foreach($accounts as $account) @if(isset($account->budgetInformation[0])) - + @else @endif @@ -74,7 +88,9 @@ @foreach($accounts as $account) - + @endforeach @@ -101,7 +117,9 @@ $accountSums[$account->id] += $account->balancedAmount; ?> @if(isset($account->budgetInformation[0])) - + @else @endif @@ -126,4 +144,13 @@
    Amount{{mf($t->amount)}}{{mft($t)}}
    New balance
    {{{$budget['name']}}}{{{$budget['name']}}} + @if($id == 0) + + @endif + {{mf($budget['amount'])}} {{mf($account->budgetInformation[$id]['amount'])}} + @if($id == 0) + {{mf($account->budgetInformation[$id]['amount'])}} + @else + {{mf($account->budgetInformation[$id]['amount'])}} + @endif +
    Without budgetWithout budget + + {{mf($account->budgetInformation[0]['amount'])}} + {{mf($account->budgetInformation[0]['amount'])}} + {{mf(0)}}
    Balanced by transfers{{mf($account->balancedAmount)}} + {{mf($account->balancedAmount)}} +  
    {{mf($account->budgetInformation[0]['amount'] + $account->balancedAmount)}} + {{mf($account->budgetInformation[0]['amount'] + $account->balancedAmount)}} + {{mf(0)}}
    + + + + +@stop +@section('scripts') +{{HTML::script('assets/javascript/firefly/reports.js')}} @stop \ No newline at end of file diff --git a/public/assets/javascript/firefly/help.js b/public/assets/javascript/firefly/help.js index b40c59479c..cfe25448b4 100644 --- a/public/assets/javascript/firefly/help.js +++ b/public/assets/javascript/firefly/help.js @@ -1,5 +1,8 @@ $(function () { $('#help').click(showHelp); + $(function () { + $('[data-toggle="tooltip"]').tooltip() + }) }); function showHelp(e) { diff --git a/tests/functional/PreferencesControllerCest.php b/tests/functional/PreferencesControllerCest.php index 680ca70a49..6a07d47d3f 100644 --- a/tests/functional/PreferencesControllerCest.php +++ b/tests/functional/PreferencesControllerCest.php @@ -1,5 +1,8 @@ amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + +} \ No newline at end of file From eedf27f8a509b62583d38ef15d36e3f5813c7488 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 15:24:10 +0100 Subject: [PATCH 27/84] Fixed the tests [skip ci] --- app/controllers/PiggybankController.php | 1 + tests/functional/PiggyBankControllerCest.php | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index e08cef2f62..d032c4fcfe 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -321,6 +321,7 @@ class PiggyBankController extends BaseController $data['order'] = 0; $data['remind_me'] = isset($data['remind_me']) ? 1 : 0; $data['user_id'] = Auth::user()->id; + $data['repeats'] = 0; // always validate: $messages = $this->_repository->validate($data); diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index b657ff6f14..00c2d906a0 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -234,7 +234,7 @@ class PiggyBankControllerCest 'post_submit_action' => 'store', 'targetamount' => 1000] ); - $I->see('Name is too short'); + $I->see('The name field is required.'); } /** @@ -324,7 +324,7 @@ class PiggyBankControllerCest 'post_submit_action' => 'update', ] ); - $I->see('Name is too short'); + $I->see('The name field is required.'); $I->seeInDatabase('piggy_banks', ['name' => 'New camera']); } From 0acd75a24fdbe3b9c6f239dddad2a7d7d420bbaf Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 15:55:21 +0100 Subject: [PATCH 28/84] Updated tests for help controller. --- app/controllers/HelpController.php | 15 ++++++++++----- tests/functional/HelpControllerCest.php | 13 +++++++++++++ 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/app/controllers/HelpController.php b/app/controllers/HelpController.php index ee600767c5..2ff4296b30 100644 --- a/app/controllers/HelpController.php +++ b/app/controllers/HelpController.php @@ -15,6 +15,7 @@ class HelpController extends BaseController $helpText = '

    There is no help for this route!

    '; $helpTitle = 'Help'; if (!Route::has($route)) { + \Log::error('No such route: ' . $route); return Response::json(['title' => $helpTitle, 'text' => $helpText]); } @@ -27,16 +28,20 @@ class HelpController extends BaseController } $uri = 'https://raw.githubusercontent.com/JC5/firefly-iii-help/master/' . e($route) . '.md'; + \Log::debug('URL is: ' . $uri); try { $content = file_get_contents($uri); } catch (ErrorException $e) { - $content = '

    There is no help for this route.

    '; - } - if (strlen($content) == 0) { - $content = '

    There is no help for this route.

    '; + $content = '

    There is no help for this route!

    '; + \Log::error(trim($e->getMessage())); } \Log::debug('Found help for ' . $route); - \Log::debug('Help text length is ' . strlen($content)); + \Log::debug('Help text length for route ' . $route . ' is ' . strlen($content)); + \Log::debug('Help text IS: "' . $content . '".'); + if (strlen(trim($content)) == 0) { + $content = '

    There is no help for this route.

    '; + } + $helpText = \Michelf\Markdown::defaultTransform($content); $helpTitle = $route; diff --git a/tests/functional/HelpControllerCest.php b/tests/functional/HelpControllerCest.php index b728147027..8f4cbac78c 100644 --- a/tests/functional/HelpControllerCest.php +++ b/tests/functional/HelpControllerCest.php @@ -49,6 +49,18 @@ class HelpControllerCest } + /** + * @param FunctionalTester $I + */ + public function showHelpEmptyHelpFile(FunctionalTester $I) + { + $I->wantTo('show help for a route with no text.'); + $I->amOnPage('/help/transactions.doRelate'); + $I->canSeeResponseCodeIs(200); + $I->see('There is no help for this route'); + + } + /** * @param FunctionalTester $I */ @@ -60,6 +72,7 @@ class HelpControllerCest $I->see('There is no help for this route'); } + // /** * @param FunctionalTester $I From 1f0e692ee23af8739b68767fd7631100c0b94175 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 17:27:31 +0100 Subject: [PATCH 29/84] New tests for the repeated expenses. --- app/database/seeds/TestContentSeeder.php | 35 ++++ app/models/Piggybank.php | 22 +-- app/views/repeatedexpense/create.blade.php | 2 +- tests/functional/RepeatedExpenseCest.php | 23 --- .../RepeatedExpenseControllerCest.php | 151 ++++++++++++++++++ 5 files changed, 198 insertions(+), 35 deletions(-) delete mode 100644 tests/functional/RepeatedExpenseCest.php create mode 100644 tests/functional/RepeatedExpenseControllerCest.php diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 525d6fd4b6..111ca5bb5f 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -194,6 +194,41 @@ class TestContentSeeder extends Seeder ] ); + // recurring transaction + $recurring = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'Nieuwe kleding', + 'targetamount' => 1000, + 'startdate' => Carbon::now()->subMonth()->format('Y-m-d'), + 'targetdate' => Carbon::now()->format('Y-m-d'), + 'repeats' => 1, + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'reminder' => 'month', + 'reminder_skip' => 0, + 'remind_me' => 1, + 'order' => 0, + ] + ); + PiggyBankRepetition::create( + [ + 'piggy_bank_id' => $recurring->id, + 'startdate' => Carbon::now()->format('Y-m-d'), + 'targetdate' => Carbon::now()->addMonth()->format('Y-m-d'), + 'currentamount' => 0 + ] + ); + PiggyBankRepetition::create( + [ + 'piggy_bank_id' => $recurring->id, + 'startdate' => Carbon::now()->subMonth()->format('Y-m-d'), + 'targetdate' => Carbon::now()->format('Y-m-d'), + 'currentamount' => 0 + ] + ); + // bill $firstBill = \Bill::create( [ diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 9f5b6a942f..57f497fdac 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -9,6 +9,9 @@ use Watson\Validating\ValidatingTrait; class PiggyBank extends Eloquent { use ValidatingTrait; + public $fillable + = ['account_id', 'name', 'targetamount', 'startdate', 'targetdate', 'repeats', 'rep_length', 'rep_every', 'rep_times', 'reminder', 'reminder_skip', + 'remind_me', 'order']; protected $rules = ['account_id' => 'required|exists:accounts,id', // link to Account 'name' => 'required|between:1,255', // name @@ -23,9 +26,6 @@ class PiggyBank extends Eloquent 'reminder_skip' => 'required|min:0|max:100', // every week? every 2 months? 'remind_me' => 'required|boolean', 'order' => 'required:min:1', // not yet used. ]; - public $fillable - = ['account_id', 'name', 'targetamount', 'startdate', 'targetdate', 'repeats', 'rep_length', 'rep_every', 'rep_times', 'reminder', 'reminder_skip', - 'remind_me', 'order']; /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo @@ -95,7 +95,7 @@ class PiggyBank extends Eloquent return $rep; } else { - $query = $this->piggyBankRepetitions()->where( + $query = $this->piggyBankRepetitions()->where( function ($q) { $q->where( @@ -105,28 +105,28 @@ class PiggyBank extends Eloquent function ($q) { $today = new Carbon; $q->whereNull('startdate'); - $q->orWhere('startdate', '<=', $today->format('Y-m-d')); + $q->orWhere('startdate', '<=', $today->format('Y-m-d 00:00:00')); } )->where( function ($q) { $today = new Carbon; $q->whereNull('targetdate'); - $q->orWhere('targetdate', '>=', $today->format('Y-m-d')); + $q->orWhere('targetdate', '>=', $today->format('Y-m-d 00:00:00')); } ); } )->orWhere( function ($q) { $today = new Carbon; - $q->where('startdate', '>=', $today->format('Y-m-d')); - $q->where('targetdate', '>=', $today->format('Y-m-d')); + $q->where('startdate', '>=', $today->format('Y-m-d 00:00:00')); + $q->where('targetdate', '>=', $today->format('Y-m-d 00:00:00')); } ); } - ) - ->orderBy('startdate', 'ASC'); - $result = $query->first(['piggy_bank_repetitions.*']); + )->orderBy('startdate', 'ASC'); + $result = $query->first(['piggy_bank_repetitions.*']); + \Log::debug('Result is null: ' . boolstr(is_null($result))); $this->currentRep = $result; \Log::debug('Found relevant rep in currentRelevantRep(): ' . $result->id); diff --git a/app/views/repeatedexpense/create.blade.php b/app/views/repeatedexpense/create.blade.php index 3a051bb0c4..374579360d 100644 --- a/app/views/repeatedexpense/create.blade.php +++ b/app/views/repeatedexpense/create.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName()) }} -{{Form::open(['class' => 'form-horizontal','url' => route('repeated.store')])}} +{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('repeated.store')])}}
    diff --git a/tests/functional/RepeatedExpenseCest.php b/tests/functional/RepeatedExpenseCest.php deleted file mode 100644 index a24bcf14f8..0000000000 --- a/tests/functional/RepeatedExpenseCest.php +++ /dev/null @@ -1,23 +0,0 @@ -amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); - } - - -} \ No newline at end of file diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php new file mode 100644 index 0000000000..75a44f5a85 --- /dev/null +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -0,0 +1,151 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + public function create(FunctionalTester $I) + { + $I->wantTo('create a recurring transaction'); + $I->amOnPage('/repeatedexpenses/create'); + $I->see('Create new repeated expense'); + } + + public function delete(FunctionalTester $I) + { + $I->wantTo('delete a recurring transaction'); + $I->amOnPage('/repeatedexpenses/delete/4'); + $I->see('Delete "Nieuwe kleding"'); + } + + public function destroy(FunctionalTester $I) + { + $I->wantTo('destroy a recurring transaction'); + $I->amOnPage('/repeatedexpenses/delete/4'); + $I->submitForm('#destroy', []); + $I->dontSeeInDatabase('piggy_banks', ['id' => 5]); + } + + public function edit(FunctionalTester $I) + { + $I->wantTo('edit a recurring transaction'); + $I->amOnPage('/repeatedexpenses/edit/4'); + $I->see('Edit repeated expense "Nieuwe kleding"'); + + } + + public function index(FunctionalTester $I) + { + $I->wantTo('see all recurring transactions'); + $I->amOnPage('/repeatedexpenses'); + $I->see('Overview'); + $I->see('Nieuwe kleding'); + } + + public function show(FunctionalTester $I) + { + $I->wantTo('view a recurring transaction'); + $I->amOnPage('/repeatedexpenses/show/4'); + $I->see('Nieuwe kleding'); + } + + public function store(FunctionalTester $I) + { + $I->wantTo('store a recurring transaction'); + $I->amOnPage('/repeatedexpenses/create'); + $I->submitForm( + '#store', [ + 'name' => 'TestRepeatedExpense', + 'account_id' => 1, + 'targetamount' => 1000, + 'targetdate' => '2014-05-01', + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'store', + ] + ); + $I->see('Piggy bank "TestRepeatedExpense" stored.'); + } + + public function update(FunctionalTester $I) + { + $I->wantTo('update a recurring transaction'); + $I->amOnPage('/repeatedexpenses/edit/4'); + $I->submitForm( + '#update', [ + 'name' => 'Nieuwe kleding!', + 'account_id' => 2, + 'targetamount' => 1000.00, + 'targetdate' => '2014-12-30', + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'update', + ] + ); + $I->see('Repeated expense "Nieuwe kleding!" updated.'); + } + + public function updateAndReturnToEdit(FunctionalTester $I) + { + $I->wantTo('update a recurring transaction and return to edit screen'); + $I->amOnPage('/repeatedexpenses/edit/4'); + $I->submitForm( + '#update', [ + 'name' => 'Nieuwe kleding!', + 'account_id' => 2, + 'targetamount' => 1000.00, + 'targetdate' => '2014-12-30', + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'return_to_edit', + ] + ); + $I->see('Repeated expense "Nieuwe kleding!" updated.'); + } + + public function updateFail(FunctionalTester $I) + { + $I->wantTo('try to update a recurring transaction and fail'); + $I->amOnPage('/repeatedexpenses/edit/4'); + $I->submitForm( + '#update', [ + 'name' => '', + 'account_id' => 2, + 'targetamount' => 1000.00, + 'targetdate' => '2014-12-30', + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'update', + ] + ); + $I->see('The name field is required.'); + } +} \ No newline at end of file From 9f92e1b7bd7f137a52fde8f67e8595169902ff7c Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 17:55:46 +0100 Subject: [PATCH 30/84] Some tests and a rename. --- app/controllers/ReportController.php | 6 +- .../Database/PiggyBank/PiggyBankShared.php | 40 ---------- app/lib/FireflyIII/Report/Report.php | 2 +- app/lib/FireflyIII/Report/ReportQuery.php | 2 +- .../create.blade.php | 0 .../delete.blade.php | 0 .../edit.blade.php | 0 .../index.blade.php | 0 .../show.blade.php | 0 tests/functional/BillControllerCest.php | 6 ++ .../functional/PreferencesControllerCest.php | 4 + tests/functional/ProfileControllerCest.php | 3 + tests/functional/ReminderControllerCest.php | 18 +++++ .../RepeatedExpenseControllerCest.php | 35 ++++++++ tests/functional/ReportControllerCest.php | 79 +++++++++++++++++++ 15 files changed, 150 insertions(+), 45 deletions(-) rename app/views/{repeatedexpense => repeatedExpense}/create.blade.php (100%) rename app/views/{repeatedexpense => repeatedExpense}/delete.blade.php (100%) rename app/views/{repeatedexpense => repeatedExpense}/edit.blade.php (100%) rename app/views/{repeatedexpense => repeatedExpense}/index.blade.php (100%) rename app/views/{repeatedexpense => repeatedExpense}/show.blade.php (100%) create mode 100644 tests/functional/ReportControllerCest.php diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 100da8cbce..9dc5a15f6f 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -44,7 +44,7 @@ class ReportController extends BaseController try { new Carbon($year . '-' . $month . '-01'); } catch (Exception $e) { - View::make('error')->with('message', 'Invalid date'); + return View::make('error')->with('message', 'Invalid date'); } $date = new Carbon($year . '-' . $month . '-01'); $dayEarly = clone $date; @@ -81,7 +81,7 @@ class ReportController extends BaseController try { new Carbon($year . '-' . $month . '-01'); } catch (Exception $e) { - View::make('error')->with('message', 'Invalid date'); + return View::make('error')->with('message', 'Invalid date.'); } $date = new Carbon($year . '-' . $month . '-01'); $subTitle = 'Report for ' . $date->format('F Y'); @@ -110,7 +110,7 @@ class ReportController extends BaseController try { new Carbon('01-01-' . $year); } catch (Exception $e) { - App::abort(500); + return View::make('error')->with('message', 'Invalid date.'); } $date = new Carbon('01-01-' . $year); $end = clone $date; diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index 973617267e..eb762b6395 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -174,46 +174,6 @@ class PiggyBankShared } - return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; - - exit; - - if (!in_array(ucfirst($model['reminder']), \Config::get('firefly.piggy_bank_periods'))) { - $errors->add('reminder', 'Invalid reminder period (' . $model['reminder'] . ')'); - } - // check period. - if (!$errors->has('reminder') && !$errors->has('targetdate') && isset($model['remind_me']) && intval($model['remind_me']) == 1) { - $today = new Carbon; - $target = new Carbon($model['targetdate']); - switch ($model['reminder']) { - case 'week': - $today->addWeek(); - break; - case 'month': - $today->addMonth(); - break; - case 'year': - $today->addYear(); - break; - } - if ($today > $target) { - $errors->add('reminder', 'Target date is too close to today to set reminders.'); - } - } - - $validator = \Validator::make($model, \PiggyBank::$rules); - if ($validator->invalid()) { - $errors->merge($errors); - } - - // add ok messages. - $list = ['name', 'account_id', 'targetamount', 'targetdate', 'remind_me', 'reminder']; - foreach ($list as $entry) { - if (!$errors->has($entry) && !$warnings->has($entry)) { - $successes->add($entry, 'OK'); - } - } - return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; } diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index f7ef12dfea..f6fe78c975 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -388,7 +388,7 @@ class Report implements ReportInterface ->where('acm_to.data', '!=', '"sharedExpense"') ->before($end)->after($start) ->where('transaction_journals.user_id', \Auth::user()->id) - ->groupBy('account_id')->orderBy('sum')->limit(15) + ->groupBy('t_from.account_id')->orderBy('sum')->limit(15) ->get(['t_from.account_id as account_id', 'ac_from.name as name', \DB::Raw('SUM(t_from.amount) as `sum`')]); diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 199827e7bb..75728b597c 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -231,7 +231,7 @@ class ReportQuery implements ReportQueryInterface ->where('account_meta.data', '!=', '"sharedExpense"') ->where('transaction_types.type', 'Withdrawal') ->groupBy('budgets.id') - ->orderBy('name', 'ASC') + ->orderBy('budgets.name', 'ASC') ->get(['budgets.id', 'budgets.name', \DB::Raw('SUM(`transactions`.`amount`) AS `spent`')]); } diff --git a/app/views/repeatedexpense/create.blade.php b/app/views/repeatedExpense/create.blade.php similarity index 100% rename from app/views/repeatedexpense/create.blade.php rename to app/views/repeatedExpense/create.blade.php diff --git a/app/views/repeatedexpense/delete.blade.php b/app/views/repeatedExpense/delete.blade.php similarity index 100% rename from app/views/repeatedexpense/delete.blade.php rename to app/views/repeatedExpense/delete.blade.php diff --git a/app/views/repeatedexpense/edit.blade.php b/app/views/repeatedExpense/edit.blade.php similarity index 100% rename from app/views/repeatedexpense/edit.blade.php rename to app/views/repeatedExpense/edit.blade.php diff --git a/app/views/repeatedexpense/index.blade.php b/app/views/repeatedExpense/index.blade.php similarity index 100% rename from app/views/repeatedexpense/index.blade.php rename to app/views/repeatedExpense/index.blade.php diff --git a/app/views/repeatedexpense/show.blade.php b/app/views/repeatedExpense/show.blade.php similarity index 100% rename from app/views/repeatedexpense/show.blade.php rename to app/views/repeatedExpense/show.blade.php diff --git a/tests/functional/BillControllerCest.php b/tests/functional/BillControllerCest.php index 3dcea51f9b..188bc52f2e 100644 --- a/tests/functional/BillControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -2,6 +2,9 @@ /** * Class BillControllerCest + * + * @SuppressWarnings("CamelCase") + * @SuppressWarnings("short") */ class BillControllerCest { @@ -147,6 +150,9 @@ class BillControllerCest $I->see('Could not store bill'); } + /** + * @param FunctionalTester $I + */ public function storeRecreate(FunctionalTester $I) { $I->wantTo('validate a bill and create another one'); diff --git a/tests/functional/PreferencesControllerCest.php b/tests/functional/PreferencesControllerCest.php index 6a07d47d3f..8149780db8 100644 --- a/tests/functional/PreferencesControllerCest.php +++ b/tests/functional/PreferencesControllerCest.php @@ -2,6 +2,10 @@ /** * Class PreferencesControllerCest + * + * @SuppressWarnings("CamelCase") + * @SuppressWarnings("short") + * */ class PreferencesControllerCest { diff --git a/tests/functional/ProfileControllerCest.php b/tests/functional/ProfileControllerCest.php index fd7e1a53a6..9a83e7ae5f 100644 --- a/tests/functional/ProfileControllerCest.php +++ b/tests/functional/ProfileControllerCest.php @@ -2,6 +2,9 @@ /** * Class ProfileControllerCest + * + * @SuppressWarnings("CamelCase") + * @SuppressWarnings("short") */ class ProfileControllerCest { diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php index 3415dd1ad5..fe5d0e738a 100644 --- a/tests/functional/ReminderControllerCest.php +++ b/tests/functional/ReminderControllerCest.php @@ -2,6 +2,9 @@ /** * Class ReminderControllerCest + * + * @SuppressWarnings("CamelCase") + * @SuppressWarnings("short") */ class ReminderControllerCest { @@ -21,6 +24,9 @@ class ReminderControllerCest $I->amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); } + /** + * @param FunctionalTester $I + */ public function act(FunctionalTester $I) { $I->wantTo('act on a reminder'); @@ -28,6 +34,9 @@ class ReminderControllerCest $I->see('Money for Weekly reminder for clothes'); } + /** + * @param FunctionalTester $I + */ public function dismiss(FunctionalTester $I) { $I->wantTo('dismiss a reminder'); @@ -35,6 +44,9 @@ class ReminderControllerCest $I->see('Reminder dismissed'); } + /** + * @param FunctionalTester $I + */ public function notNow(FunctionalTester $I) { $I->wantTo('ignore a reminder'); @@ -42,6 +54,9 @@ class ReminderControllerCest $I->see('Reminder dismissed'); } + /** + * @param FunctionalTester $I + */ public function show(FunctionalTester $I) { $I->wantTo('see a reminder'); @@ -50,6 +65,9 @@ class ReminderControllerCest $I->see('your piggy bank labelled "Weekly reminder for clothes"'); } + /** + * @param FunctionalTester $I + */ public function actOnInvalid(FunctionalTester $I) { $I->wantTo('act on an invalid reminder'); diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index 75a44f5a85..073a99d9f3 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -2,7 +2,12 @@ /** * Class RepeatedExpenseControllerCest + * + * @SuppressWarnings("CamelCase") + * @SuppressWarnings("short") */ + + class RepeatedExpenseControllerCest { /** @@ -20,6 +25,9 @@ class RepeatedExpenseControllerCest $I->amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); } + /** + * @param FunctionalTester $I + */ public function create(FunctionalTester $I) { $I->wantTo('create a recurring transaction'); @@ -27,6 +35,9 @@ class RepeatedExpenseControllerCest $I->see('Create new repeated expense'); } + /** + * @param FunctionalTester $I + */ public function delete(FunctionalTester $I) { $I->wantTo('delete a recurring transaction'); @@ -34,6 +45,9 @@ class RepeatedExpenseControllerCest $I->see('Delete "Nieuwe kleding"'); } + /** + * @param FunctionalTester $I + */ public function destroy(FunctionalTester $I) { $I->wantTo('destroy a recurring transaction'); @@ -42,6 +56,9 @@ class RepeatedExpenseControllerCest $I->dontSeeInDatabase('piggy_banks', ['id' => 5]); } + /** + * @param FunctionalTester $I + */ public function edit(FunctionalTester $I) { $I->wantTo('edit a recurring transaction'); @@ -50,6 +67,9 @@ class RepeatedExpenseControllerCest } + /** + * @param FunctionalTester $I + */ public function index(FunctionalTester $I) { $I->wantTo('see all recurring transactions'); @@ -58,6 +78,9 @@ class RepeatedExpenseControllerCest $I->see('Nieuwe kleding'); } + /** + * @param FunctionalTester $I + */ public function show(FunctionalTester $I) { $I->wantTo('view a recurring transaction'); @@ -65,6 +88,9 @@ class RepeatedExpenseControllerCest $I->see('Nieuwe kleding'); } + /** + * @param FunctionalTester $I + */ public function store(FunctionalTester $I) { $I->wantTo('store a recurring transaction'); @@ -86,6 +112,9 @@ class RepeatedExpenseControllerCest $I->see('Piggy bank "TestRepeatedExpense" stored.'); } + /** + * @param FunctionalTester $I + */ public function update(FunctionalTester $I) { $I->wantTo('update a recurring transaction'); @@ -107,6 +136,9 @@ class RepeatedExpenseControllerCest $I->see('Repeated expense "Nieuwe kleding!" updated.'); } + /** + * @param FunctionalTester $I + */ public function updateAndReturnToEdit(FunctionalTester $I) { $I->wantTo('update a recurring transaction and return to edit screen'); @@ -128,6 +160,9 @@ class RepeatedExpenseControllerCest $I->see('Repeated expense "Nieuwe kleding!" updated.'); } + /** + * @param FunctionalTester $I + */ public function updateFail(FunctionalTester $I) { $I->wantTo('try to update a recurring transaction and fail'); diff --git a/tests/functional/ReportControllerCest.php b/tests/functional/ReportControllerCest.php new file mode 100644 index 0000000000..6d2ff144b0 --- /dev/null +++ b/tests/functional/ReportControllerCest.php @@ -0,0 +1,79 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + public function budget(FunctionalTester $I) + { + $I->wantTo('see a budget report'); + $I->amOnPage('/reports/budget/2014/9'); + $I->see('Budget report for September 2014'); + } + + public function budgetInvalidDate(FunctionalTester $I) + { + $I->wantTo('see a budget report for an invalid date'); + $I->amOnPage('/reports/budget/XXXX/XX'); + $I->see('Invalid date'); + } + + public function index(FunctionalTester $I) + { + $I->wantTo('see all possible reports'); + $I->amOnPage('/reports'); + $I->see('Reports'); + $I->see('Monthly reports'); + $I->see('Budget reports'); + } + + public function month(FunctionalTester $I) + { + $I->wantTo('see a monthly report'); + $I->amOnPage('/reports/2014/9'); + $I->see('Report for September 2014'); + } + + public function monthInvalidDate(FunctionalTester $I) + { + $I->wantTo('see a monthly report for an invalid month'); + $I->amOnPage('/reports/XXXX/XX'); + $I->see('Invalid date'); + } + + public function year(FunctionalTester $I) + { + $I->wantTo('see a yearly report'); + $I->amOnPage('/reports/2014'); + $I->see('Income vs. expenses'); + $I->see('Account balance'); + } + + public function yearInvalidDate(FunctionalTester $I) + { + $I->wantTo('see a yearly report for an invalid year'); + $I->amOnPage('/reports/XXXX'); + $I->see('Invalid date'); + } + +} \ No newline at end of file From ba7c01c6bccc4c30ec78ba2bccb5ab0d07755bbf Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 18:25:38 +0100 Subject: [PATCH 31/84] Fixed the tests. --- app/lib/FireflyIII/Event/Piggybank.php | 14 ++++----- .../RepeatedExpenseControllerCest.php | 29 ++++++++++--------- 2 files changed, 21 insertions(+), 22 deletions(-) diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index 3de0e84d00..dedfa0f2e8 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -96,14 +96,12 @@ class PiggyBank */ public function storePiggyBank(\PiggyBank $piggyBank) { - if (intval($piggyBank->repeats) == 0) { - $repetition = new \PiggyBankRepetition; - $repetition->piggyBank()->associate($piggyBank); - $repetition->startdate = $piggyBank->startdate; - $repetition->targetdate = $piggyBank->targetdate; - $repetition->currentamount = 0; - $repetition->save(); - } + $repetition = new \PiggyBankRepetition; + $repetition->piggyBank()->associate($piggyBank); + $repetition->startdate = $piggyBank->startdate; + $repetition->targetdate = $piggyBank->targetdate; + $repetition->currentamount = 0; + $repetition->save(); } /* diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index 073a99d9f3..eb71aa5963 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -1,4 +1,5 @@ wantTo('create a recurring transaction'); + $I->wantTo('create a repeated expense'); $I->amOnPage('/repeatedexpenses/create'); $I->see('Create new repeated expense'); } @@ -40,7 +39,7 @@ class RepeatedExpenseControllerCest */ public function delete(FunctionalTester $I) { - $I->wantTo('delete a recurring transaction'); + $I->wantTo('delete a repeated expense'); $I->amOnPage('/repeatedexpenses/delete/4'); $I->see('Delete "Nieuwe kleding"'); } @@ -50,7 +49,7 @@ class RepeatedExpenseControllerCest */ public function destroy(FunctionalTester $I) { - $I->wantTo('destroy a recurring transaction'); + $I->wantTo('destroy a repeated expense'); $I->amOnPage('/repeatedexpenses/delete/4'); $I->submitForm('#destroy', []); $I->dontSeeInDatabase('piggy_banks', ['id' => 5]); @@ -61,7 +60,7 @@ class RepeatedExpenseControllerCest */ public function edit(FunctionalTester $I) { - $I->wantTo('edit a recurring transaction'); + $I->wantTo('edit a repeated expense'); $I->amOnPage('/repeatedexpenses/edit/4'); $I->see('Edit repeated expense "Nieuwe kleding"'); @@ -72,7 +71,7 @@ class RepeatedExpenseControllerCest */ public function index(FunctionalTester $I) { - $I->wantTo('see all recurring transactions'); + $I->wantTo('see all repeated expenses'); $I->amOnPage('/repeatedexpenses'); $I->see('Overview'); $I->see('Nieuwe kleding'); @@ -83,7 +82,7 @@ class RepeatedExpenseControllerCest */ public function show(FunctionalTester $I) { - $I->wantTo('view a recurring transaction'); + $I->wantTo('view a repeated expense'); $I->amOnPage('/repeatedexpenses/show/4'); $I->see('Nieuwe kleding'); } @@ -93,14 +92,14 @@ class RepeatedExpenseControllerCest */ public function store(FunctionalTester $I) { - $I->wantTo('store a recurring transaction'); + $I->wantTo('store a repeated expense'); $I->amOnPage('/repeatedexpenses/create'); $I->submitForm( '#store', [ 'name' => 'TestRepeatedExpense', 'account_id' => 1, 'targetamount' => 1000, - 'targetdate' => '2014-05-01', + 'targetdate' => Carbon::now()->format('Y-m-d'), 'rep_length' => 'month', 'rep_every' => 0, 'rep_times' => 0, @@ -109,7 +108,9 @@ class RepeatedExpenseControllerCest 'post_submit_action' => 'store', ] ); - $I->see('Piggy bank "TestRepeatedExpense" stored.'); + +// $I->seeInDatabase('piggy_banks', ['name' => 'TestRepeatedExpense']); + $I->see('Piggy bank "TestRepeatedExpense" stored.'); } /** @@ -117,7 +118,7 @@ class RepeatedExpenseControllerCest */ public function update(FunctionalTester $I) { - $I->wantTo('update a recurring transaction'); + $I->wantTo('update a repeated expense'); $I->amOnPage('/repeatedexpenses/edit/4'); $I->submitForm( '#update', [ @@ -141,7 +142,7 @@ class RepeatedExpenseControllerCest */ public function updateAndReturnToEdit(FunctionalTester $I) { - $I->wantTo('update a recurring transaction and return to edit screen'); + $I->wantTo('update a repeated expense and return to edit screen'); $I->amOnPage('/repeatedexpenses/edit/4'); $I->submitForm( '#update', [ @@ -165,7 +166,7 @@ class RepeatedExpenseControllerCest */ public function updateFail(FunctionalTester $I) { - $I->wantTo('try to update a recurring transaction and fail'); + $I->wantTo('try to update a repeated expense and fail'); $I->amOnPage('/repeatedexpenses/edit/4'); $I->submitForm( '#update', [ From 94fcfacec4f477f5a747dbe92afbaec637d4aaeb Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 18:44:49 +0100 Subject: [PATCH 32/84] Tests for search [skip ci] --- app/controllers/SearchController.php | 2 +- tests/functional/SearchControllerCest.php | 39 +++++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) create mode 100644 tests/functional/SearchControllerCest.php diff --git a/app/controllers/SearchController.php b/app/controllers/SearchController.php index e1588d8e3b..978200c8c4 100644 --- a/app/controllers/SearchController.php +++ b/app/controllers/SearchController.php @@ -17,7 +17,7 @@ class SearchController extends BaseController $subTitle = null; $rawQuery = null; $result = []; - if (!is_null(Input::get('q'))) { + if (!is_null(Input::get('q')) && strlen(Input::get('q')) > 0) { $rawQuery = trim(Input::get('q')); $words = explode(' ', $rawQuery); $subTitle = 'Results for "' . e($rawQuery) . '"'; diff --git a/tests/functional/SearchControllerCest.php b/tests/functional/SearchControllerCest.php new file mode 100644 index 0000000000..973b2c54ab --- /dev/null +++ b/tests/functional/SearchControllerCest.php @@ -0,0 +1,39 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + public function index(FunctionalTester $I) + { + $I->wantTo('search for "salary"'); + $I->amOnPage('/search?q=salary'); + $I->see('Transactions'); + $I->see('Results for "salary"'); + + } + + public function indexNoQuery(FunctionalTester $I) + { + $I->wantTo('Search for empty string'); + $I->amOnPage('/search?q='); + $I->see('Search for ""'); + + } +} \ No newline at end of file From 8c3ae40de10b71141da2b66373f75aa5dbf84609 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 18:44:58 +0100 Subject: [PATCH 33/84] Some refactoring. --- app/lib/FireflyIII/Chart/Chart.php | 26 +++--- app/lib/FireflyIII/Database/Bill/Bill.php | 12 +-- app/lib/FireflyIII/Database/Budget/Budget.php | 2 +- .../Database/PiggyBank/PiggyBank.php | 1 - .../Database/PiggyBank/PiggyBankShared.php | 1 - .../Database/PiggyBank/RepeatedExpense.php | 3 - .../FireflyIII/Event/TransactionJournal.php | 4 +- app/lib/FireflyIII/Form/Form.php | 2 +- app/lib/FireflyIII/Report/ReportHelper.php | 44 +++++----- .../Report/ReportHelperInterface.php | 18 ++-- app/lib/FireflyIII/Report/ReportQuery.php | 8 +- .../Report/ReportQueryInterface.php | 8 +- .../Shared/Preferences/Preferences.php | 1 + .../FireflyIII/Shared/Toolkit/Navigation.php | 1 + app/lib/FireflyIII/Shared/Toolkit/Steam.php | 4 +- app/views/search/index.blade.php | 2 +- tests/functional/AccountControllerCest.php | 86 +++++++++---------- tests/functional/BillControllerCest.php | 44 +++++----- tests/functional/BudgetControllerCest.php | 83 +++++++++--------- tests/functional/CategoryControllerCest.php | 67 ++++++++------- tests/functional/CurrencyControllerCest.php | 58 ++++++------- .../functional/GoogleChartControllerCest.php | 58 ++++++------- tests/functional/PiggyBankControllerCest.php | 62 ++++++------- tests/functional/ProfileControllerCest.php | 40 ++++----- tests/functional/ReminderControllerCest.php | 20 ++--- .../RepeatedExpenseControllerCest.php | 1 - 26 files changed, 327 insertions(+), 329 deletions(-) diff --git a/app/lib/FireflyIII/Chart/Chart.php b/app/lib/FireflyIII/Chart/Chart.php index c390105efb..3b97eabbc3 100644 --- a/app/lib/FireflyIII/Chart/Chart.php +++ b/app/lib/FireflyIII/Chart/Chart.php @@ -58,18 +58,18 @@ class Chart implements ChartInterface ->where('transaction_journals.date', '<=', $end->format('Y-m-d')); } ) - ->leftJoin( - 'transactions', function (JoinClause $join) { - $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '>', 0); - } - ) - ->where('active', 1) - ->groupBy('bills.id') - ->get( - ['bills.id', 'bills.name', 'transaction_journals.description', - 'transaction_journals.id as journalId', - \DB::Raw('SUM(`bills`.`amount_min` + `bills`.`amount_max`) / 2 as `averageAmount`'), - 'transactions.amount AS actualAmount'] - ); + ->leftJoin( + 'transactions', function (JoinClause $join) { + $join->on('transaction_journals.id', '=', 'transactions.transaction_journal_id')->where('transactions.amount', '>', 0); + } + ) + ->where('active', 1) + ->groupBy('bills.id') + ->get( + ['bills.id', 'bills.name', 'transaction_journals.description', + 'transaction_journals.id as journalId', + \DB::Raw('SUM(`bills`.`amount_min` + `bills`.`amount_max`) / 2 as `averageAmount`'), + 'transactions.amount AS actualAmount'] + ); } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index bee5256214..6cb839c653 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -65,7 +65,7 @@ class Bill implements CUD, CommonDatabaseCalls, BillInterface /* * Jump to the start of the period. */ - $date = \DateKit::startOfPeriod($date, $data['repeat_freq']); + $date = \DateKit::startOfPeriod($date, $data['repeat_freq']); $bill->date = $date; $bill->skip = intval($data['skip']); @@ -193,9 +193,9 @@ class Bill implements CUD, CommonDatabaseCalls, BillInterface } /** - * @param \Bill $bill - * @param Carbon $start - * @param Carbon $end + * @param \Bill $bill + * @param Carbon $start + * @param Carbon $end * * @return \TransactionJournal|null */ @@ -206,8 +206,8 @@ class Bill implements CUD, CommonDatabaseCalls, BillInterface } /** - * @param \Bill $bill - * @param \TransactionJournal $journal + * @param \Bill $bill + * @param \TransactionJournal $journal * * @return bool */ diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index d6df9dbbfc..5dfe0d862d 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -238,6 +238,7 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface /** * This method includes the time because otherwise, SQLite doesn't understand it. + * * @param \Budget $budget * @param Carbon $date * @@ -369,6 +370,5 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface return $budget->budgetLimits()->where('startdate', $date->format('Y-m-d 00:00:00'))->first(); - } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index a6313626ca..bfcdaf66a5 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -6,7 +6,6 @@ use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; -use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; /** diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index eb762b6395..fe012fb50c 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -2,7 +2,6 @@ namespace FireflyIII\Database\PiggyBank; -use Carbon\Carbon; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index f6edef18d2..2c11ff2d2f 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -6,9 +6,6 @@ namespace FireflyIII\Database\PiggyBank; use FireflyIII\Collection\PiggyBankPart; use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; -use FireflyIII\Database\SwitchUser; -use FireflyIII\Exception\NotImplementedException; -use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; /** diff --git a/app/lib/FireflyIII/Event/TransactionJournal.php b/app/lib/FireflyIII/Event/TransactionJournal.php index ebb5e344f0..d58aba6bd0 100644 --- a/app/lib/FireflyIII/Event/TransactionJournal.php +++ b/app/lib/FireflyIII/Event/TransactionJournal.php @@ -44,8 +44,8 @@ class TransactionJournal public function update(\TransactionJournal $journal) { /** @var \FireflyIII\Database\Bill\Bill $repository */ - $repository = \App::make('FireflyIII\Database\Bill\Bill'); - $set = $repository->get(); + $repository = \App::make('FireflyIII\Database\Bill\Bill'); + $set = $repository->get(); $journal->bill_id = null; $journal->save(); diff --git a/app/lib/FireflyIII/Form/Form.php b/app/lib/FireflyIII/Form/Form.php index 13bf163944..55e20004fa 100644 --- a/app/lib/FireflyIII/Form/Form.php +++ b/app/lib/FireflyIII/Form/Form.php @@ -123,7 +123,7 @@ class Form $html .= \Form::input('text', $name, $value, $options); break; case 'amount': - $html .= '
    '.getCurrencySymbol().'
    '; + $html .= '
    ' . getCurrencySymbol() . '
    '; $html .= \Form::input('number', $name, $value, $options); $html .= '
    '; break; diff --git a/app/lib/FireflyIII/Report/ReportHelper.php b/app/lib/FireflyIII/Report/ReportHelper.php index 6d82ae261a..354cf4c174 100644 --- a/app/lib/FireflyIII/Report/ReportHelper.php +++ b/app/lib/FireflyIII/Report/ReportHelper.php @@ -95,6 +95,29 @@ class ReportHelper implements ReportHelperInterface return $one; } + /** + * Sort an array where all 'amount' keys are positive floats. + * + * @param array $array + * + * @return array + */ + public function sortArray(array $array) + { + uasort( + $array, function ($left, $right) { + if ($left['amount'] == $right['amount']) { + return 0; + } + + return ($left['amount'] < $right['amount']) ? 1 : -1; + } + ); + + return $array; + + } + /** * Sort an array where all 'amount' keys are negative floats. * @@ -116,25 +139,4 @@ class ReportHelper implements ReportHelperInterface return $array; } - - /** - * Sort an array where all 'amount' keys are positive floats. - * - * @param array $array - * - * @return array - */ - public function sortArray(array $array) { - uasort( - $array, function ($left, $right) { - if ($left['amount'] == $right['amount']) { - return 0; - } - - return ($left['amount'] < $right['amount']) ? 1 : -1; - } - ); - return $array; - - } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportHelperInterface.php b/app/lib/FireflyIII/Report/ReportHelperInterface.php index 762af0bee6..111d1ac348 100644 --- a/app/lib/FireflyIII/Report/ReportHelperInterface.php +++ b/app/lib/FireflyIII/Report/ReportHelperInterface.php @@ -43,15 +43,6 @@ interface ReportHelperInterface */ public function mergeArrays(array $one, array $two); - /** - * Sort an array where all 'amount' keys are negative floats. - * - * @param array $array - * - * @return array - */ - public function sortNegativeArray(array $array); - /** * Sort an array where all 'amount' keys are positive floats. * @@ -61,4 +52,13 @@ interface ReportHelperInterface */ public function sortArray(array $array); + /** + * Sort an array where all 'amount' keys are negative floats. + * + * @param array $array + * + * @return array + */ + public function sortNegativeArray(array $array); + } \ No newline at end of file diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 75728b597c..355568bd1a 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -44,8 +44,8 @@ class ReportQuery implements ReportQueryInterface * and are balanced by a transfer to make up for it. * * @param \Account $account - * @param Carbon $start - * @param Carbon $end + * @param Carbon $start + * @param Carbon $end * * @return Collection */ @@ -97,8 +97,8 @@ class ReportQuery implements ReportQueryInterface * and are balanced by a transfer to make up for it. * * @param \Account $account - * @param Carbon $start - * @param Carbon $end + * @param Carbon $start + * @param Carbon $end * * @return float */ diff --git a/app/lib/FireflyIII/Report/ReportQueryInterface.php b/app/lib/FireflyIII/Report/ReportQueryInterface.php index a33d6ee8ad..bed6501e71 100644 --- a/app/lib/FireflyIII/Report/ReportQueryInterface.php +++ b/app/lib/FireflyIII/Report/ReportQueryInterface.php @@ -47,8 +47,8 @@ interface ReportQueryInterface * and are balanced by a transfer to make up for it. * * @param \Account $account - * @param Carbon $start - * @param Carbon $end + * @param Carbon $start + * @param Carbon $end * * @return float */ @@ -59,8 +59,8 @@ interface ReportQueryInterface * and are balanced by a transfer to make up for it. * * @param \Account $account - * @param Carbon $start - * @param Carbon $end + * @param Carbon $start + * @param Carbon $end * * @return Collection */ diff --git a/app/lib/FireflyIII/Shared/Preferences/Preferences.php b/app/lib/FireflyIII/Shared/Preferences/Preferences.php index d7d335dcd7..40c4ec35f7 100644 --- a/app/lib/FireflyIII/Shared/Preferences/Preferences.php +++ b/app/lib/FireflyIII/Shared/Preferences/Preferences.php @@ -24,6 +24,7 @@ class Preferences implements PreferencesInterface if (!is_null($pref)) { return $pref; } + return $this->set($name, $default); } diff --git a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php index 4800201f30..003735942f 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php @@ -1,6 +1,7 @@ id.' ('.$account->name.')'); + \Log::debug('Now in Steam::balance() for account #' . $account->id . ' (' . $account->name . ')'); if (is_null($date)) { $key = 'account.' . $account->id . '.latestBalance'; } else { @@ -33,7 +33,7 @@ class Steam // TODO find a way to reliably remove cache entries for accounts. #return \Cache::get($key); } - $date = is_null($date) ? Carbon::now() : $date; + $date = is_null($date) ? Carbon::now() : $date; \Log::debug('Now reached the moment we fire the query.'); $balance = floatval( $account->transactions()->leftJoin( diff --git a/app/views/search/index.blade.php b/app/views/search/index.blade.php index d5f9e43e46..d1431ebe73 100644 --- a/app/views/search/index.blade.php +++ b/app/views/search/index.blade.php @@ -10,7 +10,7 @@ Transactions ({{$result['transactions']->count()}})
    - @include('...lists.old.journals-small-noaccount',['transactions' => $result['transactions']]) + @include('list.journals-small',['journals' => $result['transactions']])
    diff --git a/tests/functional/AccountControllerCest.php b/tests/functional/AccountControllerCest.php index 6f63f66031..103dd6c9b2 100644 --- a/tests/functional/AccountControllerCest.php +++ b/tests/functional/AccountControllerCest.php @@ -68,6 +68,19 @@ class AccountControllerCest $I->see('Edit asset account "Delete me"'); } + /** + * @param FunctionalTester $I + */ + public function failUpdate(FunctionalTester $I) + { + $I->wantTo('update an asset account and fail'); + $I->amOnPage('/accounts/edit/3'); + $I->see('Edit asset account "Delete me"'); + $I->submitForm('#update', ['name' => '', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'update']); + $I->seeRecord('accounts', ['name' => 'Delete me']); + + } + /** * @param FunctionalTester $I */ @@ -103,21 +116,6 @@ class AccountControllerCest resetToClean::clean(); } - /** - * @param FunctionalTester $I - */ - public function storeValidateOnly(FunctionalTester $I) - { - $I->amOnPage('/accounts/create/asset'); - $I->wantTo('validate a new asset account'); - $I->see('Create a new asset account'); - $I->submitForm( - '#store', ['name' => 'New through tests.', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only'] - ); - $I->dontSeeRecord('accounts', ['name' => 'New through tests.']); - resetToClean::clean(); - } - /** * @param FunctionalTester $I */ @@ -146,6 +144,21 @@ class AccountControllerCest resetToClean::clean(); } + /** + * @param FunctionalTester $I + */ + public function storeValidateOnly(FunctionalTester $I) + { + $I->amOnPage('/accounts/create/asset'); + $I->wantTo('validate a new asset account'); + $I->see('Create a new asset account'); + $I->submitForm( + '#store', ['name' => 'New through tests.', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only'] + ); + $I->dontSeeRecord('accounts', ['name' => 'New through tests.']); + resetToClean::clean(); + } + /** * @param FunctionalTester $I */ @@ -160,34 +173,6 @@ class AccountControllerCest } - /** - * @param FunctionalTester $I - */ - public function failUpdate(FunctionalTester $I) - { - $I->wantTo('update an asset account and fail'); - $I->amOnPage('/accounts/edit/3'); - $I->see('Edit asset account "Delete me"'); - $I->submitForm('#update', ['name' => '', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'update']); - $I->seeRecord('accounts', ['name' => 'Delete me']); - - } - - /** - * @param FunctionalTester $I - */ - public function validateUpdateOnly(FunctionalTester $I) - { - $I->wantTo('update an asset account and validate only'); - $I->amOnPage('/accounts/edit/2'); - $I->see('Edit asset account "Savings account"'); - $I->submitForm( - '#update', ['name' => 'Savings accountXX', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only'] - ); - $I->dontSeeRecord('accounts', ['name' => 'Savings accountXX']); - - } - /** * @param FunctionalTester $I */ @@ -204,4 +189,19 @@ class AccountControllerCest } + /** + * @param FunctionalTester $I + */ + public function validateUpdateOnly(FunctionalTester $I) + { + $I->wantTo('update an asset account and validate only'); + $I->amOnPage('/accounts/edit/2'); + $I->see('Edit asset account "Savings account"'); + $I->submitForm( + '#update', ['name' => 'Savings accountXX', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only'] + ); + $I->dontSeeRecord('accounts', ['name' => 'Savings accountXX']); + + } + } \ No newline at end of file diff --git a/tests/functional/BillControllerCest.php b/tests/functional/BillControllerCest.php index 188bc52f2e..1b93ca5f97 100644 --- a/tests/functional/BillControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -217,28 +217,6 @@ class BillControllerCest $I->see('Bill "Some bill" updated.'); } - /** - * @param FunctionalTester $I - */ - public function updateReturn(FunctionalTester $I) - { - $I->wantTo('update a bill and return to edit it'); - $I->amOnPage('/bills/edit/1'); - $I->submitForm( - '#update', [ - 'name' => 'Some bill', - 'match' => 'bla,bla', - 'amount_min' => 10, - 'amount_max' => 20, - 'post_submit_action' => 'return_to_edit', - 'date' => date('Y-m-d'), - 'repeat_freq' => 'monthly', - 'skip' => 0 - ] - ); - $I->see('Bill "Some bill" updated.'); - } - /** * @param FunctionalTester $I */ @@ -260,4 +238,26 @@ class BillControllerCest $I->see('Could not update bill'); } + /** + * @param FunctionalTester $I + */ + public function updateReturn(FunctionalTester $I) + { + $I->wantTo('update a bill and return to edit it'); + $I->amOnPage('/bills/edit/1'); + $I->submitForm( + '#update', [ + 'name' => 'Some bill', + 'match' => 'bla,bla', + 'amount_min' => 10, + 'amount_max' => 20, + 'post_submit_action' => 'return_to_edit', + 'date' => date('Y-m-d'), + 'repeat_freq' => 'monthly', + 'skip' => 0 + ] + ); + $I->see('Bill "Some bill" updated.'); + } + } \ No newline at end of file diff --git a/tests/functional/BudgetControllerCest.php b/tests/functional/BudgetControllerCest.php index 2789345917..3e9d2ec79e 100644 --- a/tests/functional/BudgetControllerCest.php +++ b/tests/functional/BudgetControllerCest.php @@ -82,6 +82,19 @@ class BudgetControllerCest $I->see('Edit budget "Delete me"'); } + /** + * @param FunctionalTester $I + */ + public function failUpdate(FunctionalTester $I) + { + $I->wantTo('update a budget and fail'); + $I->amOnPage('/budgets/edit/3'); + $I->see('Edit budget "Delete me"'); + $I->submitForm('#update', ['name' => '', 'post_submit_action' => 'update']); + $I->seeRecord('budgets', ['name' => 'Delete me']); + + } + /** * @param FunctionalTester $I */ @@ -138,18 +151,6 @@ class BudgetControllerCest resetToClean::clean(); } - /** - * @param FunctionalTester $I - */ - public function storeValidateOnly(FunctionalTester $I) - { - $I->amOnPage('/budgets/create'); - $I->wantTo('validate a new budget'); - $I->see('Create a new budget'); - $I->submitForm('#store', ['name' => 'New budget.', 'post_submit_action' => 'validate_only']); - $I->dontSeeRecord('budgets', ['name' => 'New budget.']); - } - /** * @param FunctionalTester $I */ @@ -170,10 +171,21 @@ class BudgetControllerCest $I->amOnPage('/budgets/create'); $I->wantTo('make storing a new budget fail.'); $I->see('Create a new budget'); - $I->submitForm('#store', ['name' => null, 'post_submit_action' => 'store']); + $I->submitForm('#store', ['name' => null, 'post_submit_action' => 'store']); $I->dontSeeRecord('budgets', ['name' => 'New budget.']); } + /** + * @param FunctionalTester $I + */ + public function storeValidateOnly(FunctionalTester $I) + { + $I->amOnPage('/budgets/create'); + $I->wantTo('validate a new budget'); + $I->see('Create a new budget'); + $I->submitForm('#store', ['name' => 'New budget.', 'post_submit_action' => 'validate_only']); + $I->dontSeeRecord('budgets', ['name' => 'New budget.']); + } /** * @param FunctionalTester $I @@ -192,16 +204,28 @@ class BudgetControllerCest /** * @param FunctionalTester $I */ - public function failUpdate(FunctionalTester $I) + public function updateAndReturn(FunctionalTester $I) { - $I->wantTo('update a budget and fail'); + $I->wantTo('update a budget and return to form'); $I->amOnPage('/budgets/edit/3'); $I->see('Edit budget "Delete me"'); - $I->submitForm('#update', ['name' => '', 'post_submit_action' => 'update']); - $I->seeRecord('budgets', ['name' => 'Delete me']); + $I->submitForm( + '#update', ['name' => 'Savings accountXX', 'post_submit_action' => 'return_to_edit'] + ); + $I->seeRecord('budgets', ['name' => 'Savings accountXX']); } + /** + * @param FunctionalTester $I + */ + public function updateIncome(FunctionalTester $I) + { + $I->amOnPage('/budgets/income'); + $I->wantTo('update my monthly income'); + $I->see('Update (expected) income for '); + } + /** * @param FunctionalTester $I */ @@ -217,29 +241,4 @@ class BudgetControllerCest $I->seeRecord('budgets', ['name' => 'Delete me']); } - - /** - * @param FunctionalTester $I - */ - public function updateAndReturn(FunctionalTester $I) - { - $I->wantTo('update a budget and return to form'); - $I->amOnPage('/budgets/edit/3'); - $I->see('Edit budget "Delete me"'); - $I->submitForm( - '#update', ['name' => 'Savings accountXX', 'post_submit_action' => 'return_to_edit'] - ); - $I->seeRecord('budgets', ['name' => 'Savings accountXX']); - - } - - /** - * @param FunctionalTester $I - */ - public function updateIncome(FunctionalTester $I) - { - $I->amOnPage('/budgets/income'); - $I->wantTo('update my monthly income'); - $I->see('Update (expected) income for '); - } } \ No newline at end of file diff --git a/tests/functional/CategoryControllerCest.php b/tests/functional/CategoryControllerCest.php index 85db3e03f3..8c688fcabb 100644 --- a/tests/functional/CategoryControllerCest.php +++ b/tests/functional/CategoryControllerCest.php @@ -65,6 +65,19 @@ class CategoryControllerCest $I->see('Edit category "Delete me"'); } + /** + * @param FunctionalTester $I + */ + public function failUpdate(FunctionalTester $I) + { + $I->wantTo('update a category and fail'); + $I->amOnPage('/categories/edit/4'); + $I->see('Edit category "Delete me"'); + $I->submitForm('#update', ['name' => '', 'post_submit_action' => 'update']); + $I->seeRecord('categories', ['name' => 'Delete me']); + + } + /** * @param FunctionalTester $I */ @@ -97,19 +110,6 @@ class CategoryControllerCest resetToClean::clean(); } - /** - * @param FunctionalTester $I - */ - public function storeValidateOnly(FunctionalTester $I) - { - $I->amOnPage('/categories/create'); - $I->wantTo('validate a new category'); - $I->see('Create a new category'); - $I->submitForm('#store', ['name' => 'New category.', 'post_submit_action' => 'validate_only']); - $I->dontSeeRecord('categories', ['name' => 'New category.']); - resetToClean::clean(); - } - /** * @param FunctionalTester $I */ @@ -131,10 +131,24 @@ class CategoryControllerCest $I->amOnPage('/categories/create'); $I->wantTo('make storing a new category fail.'); $I->see('Create a new category'); - $I->submitForm('#store', ['name' => null, 'post_submit_action' => 'validate_only']); + $I->submitForm('#store', ['name' => null, 'post_submit_action' => 'validate_only']); $I->dontSeeRecord('categories', ['name' => 'New category.']); resetToClean::clean(); } + + /** + * @param FunctionalTester $I + */ + public function storeValidateOnly(FunctionalTester $I) + { + $I->amOnPage('/categories/create'); + $I->wantTo('validate a new category'); + $I->see('Create a new category'); + $I->submitForm('#store', ['name' => 'New category.', 'post_submit_action' => 'validate_only']); + $I->dontSeeRecord('categories', ['name' => 'New category.']); + resetToClean::clean(); + } + /** * @param FunctionalTester $I */ @@ -152,13 +166,15 @@ class CategoryControllerCest /** * @param FunctionalTester $I */ - public function failUpdate(FunctionalTester $I) + public function updateAndReturn(FunctionalTester $I) { - $I->wantTo('update a category and fail'); + $I->wantTo('update a category and return to form'); $I->amOnPage('/categories/edit/4'); $I->see('Edit category "Delete me"'); - $I->submitForm('#update', ['name' => '', 'post_submit_action' => 'update']); - $I->seeRecord('categories', ['name' => 'Delete me']); + $I->submitForm( + '#update', ['name' => 'Savings accountXX', 'post_submit_action' => 'return_to_edit'] + ); + $I->seeRecord('categories', ['name' => 'Savings accountXX']); } @@ -178,19 +194,4 @@ class CategoryControllerCest } - /** - * @param FunctionalTester $I - */ - public function updateAndReturn(FunctionalTester $I) - { - $I->wantTo('update a category and return to form'); - $I->amOnPage('/categories/edit/4'); - $I->see('Edit category "Delete me"'); - $I->submitForm( - '#update', ['name' => 'Savings accountXX', 'post_submit_action' => 'return_to_edit'] - ); - $I->seeRecord('categories', ['name' => 'Savings accountXX']); - - } - } \ No newline at end of file diff --git a/tests/functional/CurrencyControllerCest.php b/tests/functional/CurrencyControllerCest.php index 47f4bf2ec2..a5e6726a59 100644 --- a/tests/functional/CurrencyControllerCest.php +++ b/tests/functional/CurrencyControllerCest.php @@ -35,6 +35,16 @@ class CurrencyControllerCest $I->see('Create a new currency'); } + /** + * @param FunctionalTester $I + */ + public function defaultCurrency(FunctionalTester $I) + { + $I->wantTo('make US Dollar the default currency'); + $I->amOnPage('/currency/default/2'); + $I->see('US Dollar is now the default currency.'); + } + /** * @param FunctionalTester $I */ @@ -57,16 +67,6 @@ class CurrencyControllerCest $I->see('Currency "Hungarian forint" deleted'); } - /** - * @param FunctionalTester $I - */ - public function defaultCurrency(FunctionalTester $I) - { - $I->wantTo('make US Dollar the default currency'); - $I->amOnPage('/currency/default/2'); - $I->see('US Dollar is now the default currency.'); - } - /** * @param FunctionalTester $I */ @@ -87,6 +87,19 @@ class CurrencyControllerCest $I->see('Edit currency "US Dollar"'); } + /** + * @param FunctionalTester $I + */ + public function failUpdate(FunctionalTester $I) + { + $I->wantTo('update a currency and fail'); + $I->amOnPage('/currency/edit/2'); + $I->see('Edit currency "US Dollar"'); + $I->submitForm('#update', ['name' => 'Failed update', 'code' => '123', 'post_submit_action' => 'update']); + $I->dontSeeRecord('transaction_currencies', ['name' => 'Failed update']); + + } + /** * @param FunctionalTester $I */ @@ -162,13 +175,15 @@ class CurrencyControllerCest /** * @param FunctionalTester $I */ - public function failUpdate(FunctionalTester $I) + public function updateAndReturn(FunctionalTester $I) { - $I->wantTo('update a currency and fail'); + $I->wantTo('update a currency and return to form'); $I->amOnPage('/currency/edit/2'); $I->see('Edit currency "US Dollar"'); - $I->submitForm('#update', ['name' => 'Failed update', 'code' => '123', 'post_submit_action' => 'update']); - $I->dontSeeRecord('transaction_currencies', ['name' => 'Failed update']); + $I->submitForm( + '#update', ['name' => 'US DollarXXX', 'symbol' => '$', 'code' => 'USD', 'post_submit_action' => 'return_to_edit'] + ); + $I->seeRecord('transaction_currencies', ['name' => 'US DollarXXX']); } @@ -185,19 +200,4 @@ class CurrencyControllerCest $I->seeRecord('transaction_currencies', ['name' => 'US Dollar']); } - - /** - * @param FunctionalTester $I - */ - public function updateAndReturn(FunctionalTester $I) - { - $I->wantTo('update a currency and return to form'); - $I->amOnPage('/currency/edit/2'); - $I->see('Edit currency "US Dollar"'); - $I->submitForm( - '#update', ['name' => 'US DollarXXX', 'symbol' => '$', 'code' => 'USD', 'post_submit_action' => 'return_to_edit'] - ); - $I->seeRecord('transaction_currencies', ['name' => 'US DollarXXX']); - - } } \ No newline at end of file diff --git a/tests/functional/GoogleChartControllerCest.php b/tests/functional/GoogleChartControllerCest.php index 3cab18f197..b0697dcc42 100644 --- a/tests/functional/GoogleChartControllerCest.php +++ b/tests/functional/GoogleChartControllerCest.php @@ -26,20 +26,20 @@ class GoogleChartControllerCest /** * @param FunctionalTester $I */ - public function accountBalanceChart(FunctionalTester $I) + public function accountAllBalanceChart(FunctionalTester $I) { - $I->wantTo('see the session balance chart of an account.'); - $I->amOnPage('chart/account/1/session'); + $I->wantTo('see the complete balance chart of an account.'); + $I->amOnPage('chart/account/1/all'); $I->seeResponseCodeIs(200); } /** * @param FunctionalTester $I */ - public function accountAllBalanceChart(FunctionalTester $I) + public function accountBalanceChart(FunctionalTester $I) { - $I->wantTo('see the complete balance chart of an account.'); - $I->amOnPage('chart/account/1/all'); + $I->wantTo('see the session balance chart of an account.'); + $I->amOnPage('chart/account/1/session'); $I->seeResponseCodeIs(200); } @@ -73,6 +73,26 @@ class GoogleChartControllerCest $I->seeResponseCodeIs(200); } + /** + * @param FunctionalTester $I + */ + public function billOverview(FunctionalTester $I) + { + $I->wantTo('see the chart for the history of a bill'); + $I->amOnPage('/chart/bills/1'); + $I->seeResponseCodeIs(200); + } + + /** + * @param FunctionalTester $I + */ + public function billsOverview(FunctionalTester $I) + { + $I->wantTo('see the chart for which bills I have yet to pay'); + $I->amOnPage('/chart/home/bills'); + $I->seeResponseCodeIs(200); + } + /** * @param FunctionalTester $I */ @@ -125,26 +145,6 @@ class GoogleChartControllerCest $I->see('Invalid year'); } - /** - * @param FunctionalTester $I - */ - public function piggyBankHistory(FunctionalTester $I) - { - $I->wantTo('see the chart for the history of a piggy bank'); - $I->amOnPage('/chart/piggy_history/1'); - $I->seeResponseCodeIs(200); - } - - /** - * @param FunctionalTester $I - */ - public function billOverview(FunctionalTester $I) - { - $I->wantTo('see the chart for the history of a bill'); - $I->amOnPage('/chart/bills/1'); - $I->seeResponseCodeIs(200); - } - /** * @param FunctionalTester $I */ @@ -158,10 +158,10 @@ class GoogleChartControllerCest /** * @param FunctionalTester $I */ - public function billsOverview(FunctionalTester $I) + public function piggyBankHistory(FunctionalTester $I) { - $I->wantTo('see the chart for which bills I have yet to pay'); - $I->amOnPage('/chart/home/bills'); + $I->wantTo('see the chart for the history of a piggy bank'); + $I->amOnPage('/chart/piggy_history/1'); $I->seeResponseCodeIs(200); } diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index 00c2d906a0..0b717f639b 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -211,7 +211,7 @@ class PiggyBankControllerCest 'remind_me' => 0, 'order' => 3, 'account_id' => 1, - 'targetamount' => 1000] + 'targetamount' => 1000] ); $I->see('Piggy bank "Some new piggy bank" stored.'); } @@ -225,14 +225,14 @@ class PiggyBankControllerCest $I->amOnPage('/piggy_banks/create'); $I->see('Create new piggy bank'); $I->submitForm( - '#store', ['name' => null, - 'rep_every' => 0, - 'reminder_skip' => 0, - 'remind_me' => 0, - 'order' => 3, - 'account_id' => 1, + '#store', ['name' => null, + 'rep_every' => 0, + 'reminder_skip' => 0, + 'remind_me' => 0, + 'order' => 3, + 'account_id' => 1, 'post_submit_action' => 'store', - 'targetamount' => 1000] + 'targetamount' => 1000] ); $I->see('The name field is required.'); } @@ -281,29 +281,6 @@ class PiggyBankControllerCest $I->see('Piggy bank "Updated camera" updated.'); - } - - /** - * @param FunctionalTester $I - */ - public function updateValidateOnly(FunctionalTester $I) - { - $I->wantTo('validate a piggy bank'); - $I->amOnPage('/piggy_banks/edit/1'); - $I->see('Edit piggy bank "New camera"'); - $I->submitForm( - '#update', [ - 'name' => 'Updated camera', - 'account_id' => 2, - 'targetamount' => 2000, - 'targetdate' => '', - 'reminder' => 'week', - 'post_submit_action' => 'validate_only', - ] - ); - $I->see('Updated camera'); - - } /** @@ -329,4 +306,27 @@ class PiggyBankControllerCest } + /** + * @param FunctionalTester $I + */ + public function updateValidateOnly(FunctionalTester $I) + { + $I->wantTo('validate a piggy bank'); + $I->amOnPage('/piggy_banks/edit/1'); + $I->see('Edit piggy bank "New camera"'); + $I->submitForm( + '#update', [ + 'name' => 'Updated camera', + 'account_id' => 2, + 'targetamount' => 2000, + 'targetdate' => '', + 'reminder' => 'week', + 'post_submit_action' => 'validate_only', + ] + ); + $I->see('Updated camera'); + + + } + } \ No newline at end of file diff --git a/tests/functional/ProfileControllerCest.php b/tests/functional/ProfileControllerCest.php index 9a83e7ae5f..cb79784cbc 100644 --- a/tests/functional/ProfileControllerCest.php +++ b/tests/functional/ProfileControllerCest.php @@ -85,6 +85,26 @@ class ProfileControllerCest $I->see('Invalid current password!'); } + /** + * @param FunctionalTester $I + */ + public function postChangePasswordNoMatch(FunctionalTester $I) + { + $I->wantTo('submit a new password but make a mistake in filling it in twice.'); + $I->amOnPage('/profile/change-password'); + $I->see('thegrumpydictator@gmail.com'); + $I->see('Change your password'); + + $I->submitForm( + '#change-password', [ + 'old' => 'james', + 'new1' => 'blabla', + 'new2' => 'bla' + ] + ); + $I->see('New passwords do not match!'); + } + /** * @param FunctionalTester $I */ @@ -126,25 +146,5 @@ class ProfileControllerCest $I->see('The idea is to change your password.'); } - /** - * @param FunctionalTester $I - */ - public function postChangePasswordNoMatch(FunctionalTester $I) - { - $I->wantTo('submit a new password but make a mistake in filling it in twice.'); - $I->amOnPage('/profile/change-password'); - $I->see('thegrumpydictator@gmail.com'); - $I->see('Change your password'); - - $I->submitForm( - '#change-password', [ - 'old' => 'james', - 'new1' => 'blabla', - 'new2' => 'bla' - ] - ); - $I->see('New passwords do not match!'); - } - } \ No newline at end of file diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php index fe5d0e738a..5677e44d07 100644 --- a/tests/functional/ReminderControllerCest.php +++ b/tests/functional/ReminderControllerCest.php @@ -34,6 +34,16 @@ class ReminderControllerCest $I->see('Money for Weekly reminder for clothes'); } + /** + * @param FunctionalTester $I + */ + public function actOnInvalid(FunctionalTester $I) + { + $I->wantTo('act on an invalid reminder'); + $I->amOnPage('/reminders/2/act'); + $I->see('This reminder has an invalid class connected to it.'); + } + /** * @param FunctionalTester $I */ @@ -65,14 +75,4 @@ class ReminderControllerCest $I->see('your piggy bank labelled "Weekly reminder for clothes"'); } - /** - * @param FunctionalTester $I - */ - public function actOnInvalid(FunctionalTester $I) - { - $I->wantTo('act on an invalid reminder'); - $I->amOnPage('/reminders/2/act'); - $I->see('This reminder has an invalid class connected to it.'); - } - } \ No newline at end of file diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index eb71aa5963..3432bec715 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -109,7 +109,6 @@ class RepeatedExpenseControllerCest ] ); -// $I->seeInDatabase('piggy_banks', ['name' => 'TestRepeatedExpense']); $I->see('Piggy bank "TestRepeatedExpense" stored.'); } From 1ef96c0b4d139661618e4d422ce7b347c408dc01 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 21:03:42 +0100 Subject: [PATCH 34/84] Finally updated the transaction controller to have some more sensible code. --- app/controllers/TransactionController.php | 419 +++++++----------- .../TransactionJournal/TransactionJournal.php | 2 +- app/lib/FireflyIII/FF3ServiceProvider.php | 1 + .../Helper/TransactionJournal/Helper.php | 83 ++++ .../TransactionJournal/HelperInterface.php | 45 ++ 5 files changed, 281 insertions(+), 269 deletions(-) create mode 100644 app/lib/FireflyIII/Helper/TransactionJournal/Helper.php create mode 100644 app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index ba2035f3ad..3a8ccf0fe4 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -1,9 +1,10 @@ _repository = $repository; + $this->_helper = $helper; View::share('title', 'Transactions'); View::share('mainTitleIcon', 'fa-repeat'); } @@ -37,19 +47,17 @@ class TransactionController extends BaseController $ids = []; /** @var TransactionGroup $group */ foreach ($journal->transactiongroups()->get() as $group) { - /** @var TransactionJournal $jrnl */ - foreach ($group->transactionjournals()->get() as $jrnl) { - if ($jrnl->id != $journal->id) { - $ids[] = $jrnl->id; + /** @var TransactionJournal $loopJournal */ + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id != $journal->id) { + $ids[] = $loopJournal->id; } } } $unique = array_unique($ids); if (count($unique) > 0) { - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - $set = $repository->getByIds($unique); + $set = $this->_repository->getByIds($unique); $set->each( function (TransactionJournal $journal) { $journal->amount = mf($journal->getAmount()); @@ -71,33 +79,18 @@ class TransactionController extends BaseController */ public function create($what = 'deposit') { - /** @var \FireflyIII\Database\Account\Account $accountRepository */ - $accountRepository = App::make('FireflyIII\Database\Account\Account'); + $accounts = FFForm::makeSelectList($this->_helper->getAssetAccounts()); + $budgets = FFForm::makeSelectList($this->_helper->getBudgets()); + $budgets[0] = '(no budget)'; + $piggyBanks = $this->_helper->getPiggyBanks(); + $repeatedExpenses = $this->_helper->getRepeatedExpenses(); + $list = $piggyBanks->merge($repeatedExpenses); + $piggies = FFForm::makeSelectList($list); + $piggies[0] = '(no piggy bank)'; + $preFilled = Session::has('preFilled') ? Session::get('preFilled') : []; + $respondTo = ['account_id', 'account_from_id']; + $subTitle = 'Add a new ' . $what; - /** @var \FireflyIII\Database\Budget\Budget $budgetRepository */ - $budgetRepository = App::make('FireflyIII\Database\Budget\Budget'); - - /** @var \FireflyIII\Database\PiggyBank\PiggyBank $piggyRepository */ - $piggyRepository = App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - - /** @var \FireflyIII\Database\PiggyBank\RepeatedExpense $repRepository */ - $repRepository = App::make('FireflyIII\Database\PiggyBank\RepeatedExpense'); - - // get asset accounts with names and id's . - $assetAccounts = FFForm::makeSelectList($accountRepository->getAssetAccounts()); - - // get budgets as a select list. - $budgets = FFForm::makeSelectList($budgetRepository->get()); - $budgets[0] = '(no budget)'; - - // get the piggy banks. - $list = $piggyRepository->get()->merge($repRepository->get()); - $piggies = FFForm::makeSelectList($list); - $piggies[0] = '(no piggy bank)'; - asort($piggies); - - $preFilled = Session::has('preFilled') ? Session::get('preFilled') : []; - $respondTo = ['account_id', 'account_from_id']; foreach ($respondTo as $r) { if (!is_null(Input::get($r))) { $preFilled[$r] = Input::get($r); @@ -105,24 +98,25 @@ class TransactionController extends BaseController } Session::put('preFilled', $preFilled); - return View::make('transactions.create')->with('accounts', $assetAccounts)->with('budgets', $budgets)->with('what', $what)->with('piggies', $piggies) - ->with('subTitle', 'Add a new ' . $what); + asort($piggies); + + + return View::make('transactions.create', compact('accounts', 'budgets', 'what', 'piggies', 'subTitle')); } /** * Shows the form that allows a user to delete a transaction journal. * - * @param TransactionJournal $transactionJournal + * @param TransactionJournal $journal * * @return $this */ - public function delete(TransactionJournal $transactionJournal) + public function delete(TransactionJournal $journal) { - $type = strtolower($transactionJournal->transactionType->type); + $type = strtolower($journal->transactionType->type); + $subTitle = 'Delete ' . $type . ' "' . $journal->description . '"'; - return View::make('transactions.delete')->with('journal', $transactionJournal)->with( - 'subTitle', 'Delete ' . $type . ' "' . $transactionJournal->description . '"' - ); + return View::make('transactions.delete', compact('journal', 'subTitle')); } @@ -134,13 +128,9 @@ class TransactionController extends BaseController */ public function destroy(TransactionJournal $transactionJournal) { - $type = $transactionJournal->transactionType->type; - - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - $repository->destroy($transactionJournal); - + $type = $transactionJournal->transactionType->type; $return = 'withdrawal'; + $this->_repository->destroy($transactionJournal); switch ($type) { @@ -165,16 +155,13 @@ class TransactionController extends BaseController $id = intval(Input::get('id')); $sister = intval(Input::get('relateTo')); - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - - $journal = $repository->find($id); - $sis = $repository->find($sister); + $journal = $this->_repository->find($id); + $sis = $this->_repository->find($sister); if ($journal && $sis) { $group = new TransactionGroup; $group->relation = 'balance'; - $group->user_id = $repository->getUser()->id; + $group->user_id = $this->_repository->getUser()->id; $group->save(); $group->transactionjournals()->save($journal); $group->transactionjournals()->save($sis); @@ -196,114 +183,42 @@ class TransactionController extends BaseController */ public function edit(TransactionJournal $journal) { - /* - * All the repositories we need: - */ - - /** @var \FireflyIII\Database\Account\Account $accountRepository */ - $accountRepository = App::make('FireflyIII\Database\Account\Account'); - - /** @var \FireflyIII\Database\Budget\Budget $budgetRepository */ - $budgetRepository = App::make('FireflyIII\Database\Budget\Budget'); - - /** @var \FireflyIII\Database\PiggyBank\PiggyBank $piggyRepository */ - $piggyRepository = App::make('FireflyIII\Database\PiggyBank\PiggyBank'); - - - // type is useful for display: - $what = strtolower($journal->transactiontype->type); - - // get asset accounts with names and id's. - - $budgets = FFForm::makeSelectList($budgetRepository->get(), true); - $accounts = FFForm::makeSelectList($accountRepository->getAssetAccounts()); - $piggies = FFForm::makeSelectList($piggyRepository->get(), true); - - - /* - * Data to properly display the edit form. - */ - $preFilled = [ - 'date' => $journal->date->format('Y-m-d'), - 'category' => '', - 'budget_id' => 0, + $what = strtolower($journal->transactiontype->type); + $subTitle = 'Edit ' . $what . ' "' . $journal->description . '"'; + $budgets = FFForm::makeSelectList($this->_helper->getBudgets(), true); + $accounts = FFForm::makeSelectList($this->_helper->getAssetAccounts()); + $piggies = FFForm::makeSelectList($this->_helper->getPiggyBanks(), true); + $transactions = $journal->transactions()->orderBy('amount', 'DESC')->get(); + $preFilled = [ + 'date' => $journal->date->format('Y-m-d'), + 'category' => '', + 'budget_id' => 0, 'piggy_bank_id' => 0 ]; - /* - * Fill in the category. - */ $category = $journal->categories()->first(); if (!is_null($category)) { $preFilled['category'] = $category->name; } - /* - * Switch on the type of transaction edited by the user and fill in other - * relevant fields: - */ - switch ($what) { - case 'withdrawal': - if (floatval($journal->transactions[0]->amount) < 0) { - // transactions[0] is the asset account that paid for the withdrawal. - $preFilled['account_id'] = $journal->transactions[0]->account->id; - $preFilled['expense_account'] = $journal->transactions[1]->account->name; - $preFilled['amount'] = floatval($journal->transactions[1]->amount); - } else { - // transactions[1] is the asset account that paid for the withdrawal. - $preFilled['account_id'] = $journal->transactions[1]->account->id; - $preFilled['expense_account'] = $journal->transactions[0]->account->name; - $preFilled['amount'] = floatval($journal->transactions[0]->amount); - } - - - $budget = $journal->budgets()->first(); - if (!is_null($budget)) { - $preFilled['budget_id'] = $budget->id; - } - break; - case 'deposit': - if (floatval($journal->transactions[0]->amount) < 0) { - // transactions[0] contains the account the money came from. - $preFilled['account_id'] = $journal->transactions[1]->account->id; - $preFilled['revenue_account'] = $journal->transactions[0]->account->name; - $preFilled['amount'] = floatval($journal->transactions[1]->amount); - } else { - // transactions[1] contains the account the money came from. - $preFilled['account_id'] = $journal->transactions[0]->account->id; - $preFilled['revenue_account'] = $journal->transactions[1]->account->name; - $preFilled['amount'] = floatval($journal->transactions[0]->amount); - - } - - break; - case 'transfer': - if (floatval($journal->transactions[0]->amount) < 0) { - // zero = from account. - $preFilled['account_from_id'] = $journal->transactions[0]->account->id; - $preFilled['account_to_id'] = $journal->transactions[1]->account->id; - $preFilled['amount'] = floatval($journal->transactions[1]->amount); - } else { - // one = from account - $preFilled['account_from_id'] = $journal->transactions[1]->account->id; - $preFilled['account_to_id'] = $journal->transactions[0]->account->id; - $preFilled['amount'] = floatval($journal->transactions[0]->amount); - } - if ($journal->piggyBankEvents()->count() > 0) { - $preFilled['piggy_bank_id'] = $journal->piggyBankEvents()->first()->piggy_bank_id; - } - break; + $budget = $journal->budgets()->first(); + if (!is_null($budget)) { + $preFilled['budget_id'] = $budget->id; } - /* - * Show the view. - */ + if ($journal->piggyBankEvents()->count() > 0) { + $preFilled['piggy_bank_id'] = $journal->piggyBankEvents()->first()->piggy_bank_id; + } - return View::make('transactions.edit')->with('journal', $journal)->with('accounts', $accounts)->with( - 'what', $what - )->with('budgets', $budgets)->with('data', $preFilled)->with('piggies', $piggies)->with( - 'subTitle', 'Edit ' . $what . ' "' . $journal->description . '"' - ); + $preFilled['amount'] = $journal->getAmount(); + $preFilled['account_id'] = $this->_helper->getAssetAccount($what, $transactions); + $preFilled['expense_account'] = $transactions[0]->account->name; + $preFilled['revenue_account'] = $transactions[1]->account->name; + $preFilled['account_from_id'] = $transactions[1]->account->id; + $preFilled['account_to_id'] = $transactions[0]->account->id; + + + return View::make('transactions.edit', compact('journal', 'accounts', 'what', 'budgets', 'piggies', 'subTitle'))->with('data', $preFilled); } /** @@ -313,28 +228,24 @@ class TransactionController extends BaseController */ public function index($what) { - - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - switch ($what) { case 'expenses': case 'withdrawal': $subTitleIcon = 'fa-long-arrow-left'; $subTitle = 'Expenses'; - $journals = $repository->getWithdrawalsPaginated(50); + $journals = $this->_repository->getWithdrawalsPaginated(50); break; case 'revenue': case 'deposit': $subTitleIcon = 'fa-long-arrow-right'; $subTitle = 'Revenue, income and deposits'; - $journals = $repository->getDepositsPaginated(50); + $journals = $this->_repository->getDepositsPaginated(50); break; case 'transfer': case 'transfers': $subTitleIcon = 'fa-arrows-h'; $subTitle = 'Transfers'; - $journals = $repository->getTransfersPaginated(50); + $journals = $this->_repository->getTransfersPaginated(50); break; } @@ -343,6 +254,8 @@ class TransactionController extends BaseController } /** + * TODO refactor relate stuff into another controller. + * * @param TransactionJournal $journal * * @return \Illuminate\View\View @@ -353,10 +266,10 @@ class TransactionController extends BaseController $members = new Collection; /** @var TransactionGroup $group */ foreach ($groups as $group) { - /** @var TransactionJournal $jrnl */ - foreach ($group->transactionjournals()->get() as $jrnl) { - if ($jrnl->id != $journal->id) { - $members->push($jrnl); + /** @var TransactionJournal $loopJournal */ + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id != $journal->id) { + $members->push($loopJournal); } } } @@ -375,10 +288,7 @@ class TransactionController extends BaseController { $search = e(trim(Input::get('searchValue'))); - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - - $result = $repository->searchRelated($search, $journal); + $result = $this->_repository->searchRelated($search, $journal); $result->each( function (TransactionJournal $j) { $j->amount = mf($j->getAmount()); @@ -410,10 +320,10 @@ class TransactionController extends BaseController $members = new Collection; /** @var TransactionGroup $group */ foreach ($journal->transactiongroups()->get() as $group) { - /** @var TransactionJournal $jrnl */ - foreach ($group->transactionjournals()->get() as $jrnl) { - if ($jrnl->id != $journal->id) { - $members->push($jrnl); + /** @var TransactionJournal $loopJournal */ + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id != $journal->id) { + $members->push($loopJournal); } } } @@ -433,58 +343,41 @@ class TransactionController extends BaseController { $data = Input::except('_token'); $data['what'] = $what; - $data['currency'] = 'EUR'; + $data['currency'] = 'EUR'; // TODO allow custom currency - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ - $repository = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); + // always validate: + $messages = $this->_repository->validate($data); - switch ($data['post_submit_action']) { - default: - throw new FireflyException('Cannot handle post_submit_action "' . e($data['post_submit_action']) . '"'); - break; - case 'create_another': - case 'store': - $messages = $repository->validate($data); - /** @var MessageBag $messages ['errors'] */ - if ($messages['errors']->count() > 0) { - Session::flash('warnings', $messages['warnings']); - Session::flash('successes', $messages['successes']); - Session::flash('error', 'Could not save transaction: ' . $messages['errors']->first()); - - return Redirect::route('transactions.create', $what)->withInput()->withErrors($messages['errors']); - } - // store! - $journal = $repository->store($data); - Session::flash('success', 'New transaction stored!'); - - /* - * Trigger a search for the related (if selected) - * piggy bank and store an event. - */ - Event::fire('transactionJournal.store', [$journal, Input::get('piggy_bank_id')]); // new and used. - /* - * Also trigger on both transactions. - */ - /** @var Transaction $transaction */ - foreach ($journal->transactions as $transaction) { - Event::fire('transaction.store', [$transaction]); - } - - if ($data['post_submit_action'] == 'create_another') { - return Redirect::route('transactions.create', $what)->withInput(); - } else { - return Redirect::route('transactions.index', $what); - } - break; - case 'validate_only': - $messageBags = $repository->validate($data); - Session::flash('warnings', $messageBags['warnings']); - Session::flash('successes', $messageBags['successes']); - Session::flash('errors', $messageBags['errors']); - - return Redirect::route('transactions.create', $what)->withInput(); - break; + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not store transaction: ' . $messages['errors']->first()); } + + // return to create screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('transactions.create', $data['what'])->withInput(); + } + + // store: + $journal = $this->_repository->store($data); + Event::fire('transactionJournal.store', [$journal, Input::get('piggy_bank_id')]); // new and used. + /* + * Also trigger on both transactions. + */ + /** @var Transaction $transaction */ + foreach ($journal->transactions as $transaction) { + Event::fire('transaction.store', [$transaction]); + } + + Session::flash('success', 'Transaction "' . e($data['description']) . '" stored.'); + if ($data['post_submit_action'] == 'store') { + return Redirect::route('transactions.index', $data['what']); + } + + return Redirect::route('transactions.create', $data['what'])->withInput(); } /** @@ -501,8 +394,8 @@ class TransactionController extends BaseController $relatedTo = intval(Input::get('relation')); /** @var TransactionGroup $group */ foreach ($groups as $group) { - foreach ($group->transactionjournals()->get() as $jrnl) { - if ($jrnl->id == $relatedTo) { + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id == $relatedTo) { // remove from group: $group->transactionjournals()->detach($relatedTo); } @@ -524,60 +417,50 @@ class TransactionController extends BaseController */ public function update(TransactionJournal $journal) { - /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repos */ - $repos = App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); - $data = Input::except('_token'); $data['currency'] = 'EUR'; $data['what'] = strtolower($journal->transactionType->type); + // always validate: + $messages = $this->_repository->validate($data); - switch (Input::get('post_submit_action')) { - case 'update': - case 'return_to_edit': - $messageBag = $repos->update($journal, $data); - if ($messageBag->count() == 0) { - // has been saved, return to index: - Session::flash('success', 'Transaction updated!'); - Event::fire('transactionJournal.update', [$journal]); // new and used. - - /* - * Also trigger on both transactions. - */ - /** @var Transaction $transaction */ - foreach ($journal->transactions as $transaction) { - Event::fire('transaction.update', [$transaction]); - } - - if (Input::get('post_submit_action') == 'return_to_edit') { - return Redirect::route('transactions.edit', $journal->id)->withInput(); - } else { - return Redirect::route('transactions.index', $data['what']); - } - } else { - Session::flash('error', 'Could not update transaction: ' . $journal->getErrors()->first()); - - return Redirect::route('transactions.edit', $journal->id)->withInput()->withErrors( - $journal->getErrors() - ); - } - - break; - case 'validate_only': - $messageBags = $repos->validate($data); - - Session::flash('warnings', $messageBags['warnings']); - Session::flash('successes', $messageBags['successes']); - Session::flash('errors', $messageBags['errors']); - - return Redirect::route('transactions.edit', $journal->id)->withInput(); - break; - default: - throw new FireflyException('Method ' . Input::get('post_submit_action') . ' not implemented yet.'); - break; + // flash messages: + Session::flash('warnings', $messages['warnings']); + Session::flash('successes', $messages['successes']); + Session::flash('errors', $messages['errors']); + if ($messages['errors']->count() > 0) { + Session::flash('error', 'Could not update transaction: ' . $messages['errors']->first()); } + // return to update screen: + if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { + return Redirect::route('transactions.edit', $journal->id)->withInput(); + } + + // update + $this->_repository->update($journal, $data); + Session::flash('success', 'Transaction "' . e($data['description']) . '" updated.'); + + Event::fire('transactionJournal.update', [$journal]); // new and used. + + /* + * Also trigger on both transactions. + */ + /** @var Transaction $transaction */ + foreach ($journal->transactions()->get() as $transaction) { + Event::fire('transaction.update', [$transaction]); + } + + // go back to list + if ($data['post_submit_action'] == 'update') { + return Redirect::route('transactions.index', $data['what']); + } + + // go back to update screen. + return Redirect::route('transactions.edit', $journal->id)->withInput(['post_submit_action' => 'return_to_edit']); + + } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 1c160059e2..8a6641d93f 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -128,7 +128,7 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData $transaction->save(); } - return new MessageBag; + return true; } /** diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index cf85ed6380..37daab3d37 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -98,6 +98,7 @@ class FF3ServiceProvider extends ServiceProvider $this->app->bind('FireflyIII\Report\ReportInterface', 'FireflyIII\Report\Report'); $this->app->bind('FireflyIII\Report\ReportQueryInterface', 'FireflyIII\Report\ReportQuery'); $this->app->bind('FireflyIII\Report\ReportHelperInterface', 'FireflyIII\Report\ReportHelper'); + $this->app->bind('FireflyIII\Helper\TransactionJournal\HelperInterface', 'FireflyIII\Helper\TransactionJournal\Helper'); // chart $this->app->bind('FireflyIII\Chart\ChartInterface', 'FireflyIII\Chart\Chart'); diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php new file mode 100644 index 0000000000..8b909c7493 --- /dev/null +++ b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php @@ -0,0 +1,83 @@ +account->id); + } + + // otherwise (its a deposit), it's been paid into account #0. + return intval($transactions[0]->account->id); + } + + /** + * @return Collection + */ + public function getAssetAccounts() + { + /** @var \FireflyIII\Database\Account\Account $accountRepository */ + $accountRepository = \App::make('FireflyIII\Database\Account\Account'); + + return $accountRepository->getAssetAccounts(); + } + + /** + * @return Collection + */ + public function getBudgets() + { + /** @var \FireflyIII\Database\Budget\Budget $budgetRepository */ + $budgetRepository = \App::make('FireflyIII\Database\Budget\Budget'); + + return $budgetRepository->get(); + + } + + /** + * @return Collection + */ + public function getPiggyBanks() + { + /** @var \FireflyIII\Database\PiggyBank\PiggyBank $piggyRepository */ + $piggyRepository = \App::make('FireflyIII\Database\PiggyBank\PiggyBank'); + + return $piggyRepository->get(); + + + } + + /** + * @return Collection + */ + public function getRepeatedExpenses() + { + /** @var \FireflyIII\Database\PiggyBank\RepeatedExpense $repRepository */ + $repRepository = \App::make('FireflyIII\Database\PiggyBank\RepeatedExpense'); + + return $repRepository->get(); + + + } + +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php new file mode 100644 index 0000000000..dc5703dc22 --- /dev/null +++ b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php @@ -0,0 +1,45 @@ + Date: Tue, 30 Dec 2014 21:04:01 +0100 Subject: [PATCH 35/84] Updated composer.lock [skip ci] --- composer.lock | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/composer.lock b/composer.lock index 07850e0b5c..0007ba9fae 100644 --- a/composer.lock +++ b/composer.lock @@ -490,16 +490,16 @@ }, { "name": "monolog/monolog", - "version": "1.11.0", + "version": "1.12.0", "source": { "type": "git", "url": "https://github.com/Seldaek/monolog.git", - "reference": "ec3961874c43840e96da3a8a1ed20d8c73d7e5aa" + "reference": "1fbe8c2641f2b163addf49cc5e18f144bec6b19f" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/Seldaek/monolog/zipball/ec3961874c43840e96da3a8a1ed20d8c73d7e5aa", - "reference": "ec3961874c43840e96da3a8a1ed20d8c73d7e5aa", + "url": "https://api.github.com/repos/Seldaek/monolog/zipball/1fbe8c2641f2b163addf49cc5e18f144bec6b19f", + "reference": "1fbe8c2641f2b163addf49cc5e18f144bec6b19f", "shasum": "" }, "require": { @@ -513,7 +513,7 @@ "aws/aws-sdk-php": "~2.4, >2.4.8", "doctrine/couchdb": "~1.0@dev", "graylog2/gelf-php": "~1.0", - "phpunit/phpunit": "~3.7.0", + "phpunit/phpunit": "~4.0", "raven/raven": "~0.5", "ruflin/elastica": "0.90.*", "videlalvaro/php-amqplib": "~2.4" @@ -532,7 +532,7 @@ "type": "library", "extra": { "branch-alias": { - "dev-master": "1.11.x-dev" + "dev-master": "1.12.x-dev" } }, "autoload": { @@ -558,7 +558,7 @@ "logging", "psr-3" ], - "time": "2014-09-30 13:30:58" + "time": "2014-12-29 21:29:35" }, { "name": "nesbot/carbon", @@ -3204,16 +3204,16 @@ }, { "name": "phpunit/php-code-coverage", - "version": "2.0.13", + "version": "2.0.14", "source": { "type": "git", "url": "https://github.com/sebastianbergmann/php-code-coverage.git", - "reference": "0e7d2eec5554f869fa7a4ec2d21e4b37af943ea5" + "reference": "ca158276c1200cc27f5409a5e338486bc0b4fc94" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/0e7d2eec5554f869fa7a4ec2d21e4b37af943ea5", - "reference": "0e7d2eec5554f869fa7a4ec2d21e4b37af943ea5", + "url": "https://api.github.com/repos/sebastianbergmann/php-code-coverage/zipball/ca158276c1200cc27f5409a5e338486bc0b4fc94", + "reference": "ca158276c1200cc27f5409a5e338486bc0b4fc94", "shasum": "" }, "require": { @@ -3265,7 +3265,7 @@ "testing", "xunit" ], - "time": "2014-12-03 06:41:44" + "time": "2014-12-26 13:28:33" }, { "name": "phpunit/php-file-iterator", @@ -3451,16 +3451,16 @@ }, { "name": "phpunit/phpunit", - "version": "4.4.0", + "version": "4.4.1", "source": { "type": "git", "url": "https://github.com/sebastianbergmann/phpunit.git", - "reference": "bbe7bcb83b6ec1a9eaabbe1b70d4795027c53ee0" + "reference": "6a5e49a86ce5e33b8d0657abe145057fc513543a" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/bbe7bcb83b6ec1a9eaabbe1b70d4795027c53ee0", - "reference": "bbe7bcb83b6ec1a9eaabbe1b70d4795027c53ee0", + "url": "https://api.github.com/repos/sebastianbergmann/phpunit/zipball/6a5e49a86ce5e33b8d0657abe145057fc513543a", + "reference": "6a5e49a86ce5e33b8d0657abe145057fc513543a", "shasum": "" }, "require": { @@ -3518,7 +3518,7 @@ "testing", "xunit" ], - "time": "2014-12-05 06:49:03" + "time": "2014-12-28 07:57:05" }, { "name": "phpunit/phpunit-mock-objects", @@ -3577,16 +3577,16 @@ }, { "name": "react/promise", - "version": "v2.1.0", + "version": "v2.2.0", "source": { "type": "git", "url": "https://github.com/reactphp/promise.git", - "reference": "937b04f1b0ee8f6d180e75a0830aac778ca4bcd6" + "reference": "365fcee430dfa4ace1fbc75737ca60ceea7eeeef" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/reactphp/promise/zipball/937b04f1b0ee8f6d180e75a0830aac778ca4bcd6", - "reference": "937b04f1b0ee8f6d180e75a0830aac778ca4bcd6", + "url": "https://api.github.com/repos/reactphp/promise/zipball/365fcee430dfa4ace1fbc75737ca60ceea7eeeef", + "reference": "365fcee430dfa4ace1fbc75737ca60ceea7eeeef", "shasum": "" }, "require": { @@ -3603,7 +3603,7 @@ "React\\Promise\\": "src/" }, "files": [ - "src/functions.php" + "src/functions_include.php" ] }, "notification-url": "https://packagist.org/downloads/", @@ -3617,7 +3617,7 @@ } ], "description": "A lightweight implementation of CommonJS Promises/A for PHP", - "time": "2014-10-15 20:05:57" + "time": "2014-12-30 13:32:42" }, { "name": "satooshi/php-coveralls", From ee5afaa6bc75d03dc5e73ad097796b87d51af042 Mon Sep 17 00:00:00 2001 From: James Cole Date: Tue, 30 Dec 2014 22:25:30 +0100 Subject: [PATCH 36/84] First tests for transaction controller. --- app/controllers/TransactionController.php | 30 ++--- app/database/seeds/TestContentSeeder.php | 35 ++++- app/views/transactions/create.blade.php | 2 +- app/views/transactions/delete.blade.php | 2 +- app/views/transactions/edit.blade.php | 2 +- .../functional/TransactionControllerCest.php | 127 ++++++++++++++++++ 6 files changed, 174 insertions(+), 24 deletions(-) create mode 100644 tests/functional/TransactionControllerCest.php diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 3a8ccf0fe4..cd92e640a0 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -39,6 +39,8 @@ class TransactionController extends BaseController * * @param TransactionJournal $journal * + * @codeCoverageIgnore + * * @return array|\Illuminate\Http\JsonResponse */ public function alreadyRelated(TransactionJournal $journal) @@ -130,8 +132,10 @@ class TransactionController extends BaseController { $type = $transactionJournal->transactionType->type; $return = 'withdrawal'; - $this->_repository->destroy($transactionJournal); + Session::flash('success', 'Transaction "' . e($transactionJournal->description) . '" destroyed.'); + + $this->_repository->destroy($transactionJournal); switch ($type) { case 'Deposit': @@ -149,6 +153,8 @@ class TransactionController extends BaseController * TODO this needs cleaning up and thinking over. * * @return \Illuminate\Http\JsonResponse + * @codeCoverageIgnore + * */ public function doRelate() { @@ -259,6 +265,8 @@ class TransactionController extends BaseController * @param TransactionJournal $journal * * @return \Illuminate\View\View + * @codeCoverageIgnore + * */ public function relate(TransactionJournal $journal) { @@ -282,6 +290,8 @@ class TransactionController extends BaseController * * @param TransactionJournal $journal * + * @codeCoverageIgnore + * * @return \Illuminate\Http\JsonResponse */ public function relatedSearch(TransactionJournal $journal) @@ -385,6 +395,7 @@ class TransactionController extends BaseController * * @param TransactionJournal $journal * + * @codeCoverageIgnore * @return \Illuminate\Http\JsonResponse * @throws Exception */ @@ -420,39 +431,24 @@ class TransactionController extends BaseController $data = Input::except('_token'); $data['currency'] = 'EUR'; $data['what'] = strtolower($journal->transactionType->type); + $messages = $this->_repository->validate($data); - // always validate: - $messages = $this->_repository->validate($data); - - // flash messages: Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); if ($messages['errors']->count() > 0) { Session::flash('error', 'Could not update transaction: ' . $messages['errors']->first()); } - - - // return to update screen: if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { return Redirect::route('transactions.edit', $journal->id)->withInput(); } - - // update $this->_repository->update($journal, $data); Session::flash('success', 'Transaction "' . e($data['description']) . '" updated.'); - Event::fire('transactionJournal.update', [$journal]); // new and used. - - /* - * Also trigger on both transactions. - */ /** @var Transaction $transaction */ foreach ($journal->transactions()->get() as $transaction) { Event::fire('transaction.update', [$transaction]); } - - // go back to list if ($data['post_submit_action'] == 'update') { return Redirect::route('transactions.index', $data['what']); } diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 111ca5bb5f..559887e47a 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -102,13 +102,15 @@ class TestContentSeeder extends Seeder ); + + PiggyBankEvent::create(['piggy_bank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); PiggyBankRepetition::create( [ 'piggy_bank_id' => $piggy->id, 'startdate' => Carbon::now()->format('Y-m-d'), 'targetdate' => null, - 'currentamount' => 0 + 'currentamount' => 100 ] ); @@ -337,10 +339,35 @@ class TestContentSeeder extends Seeder } // create some big expenses, move some money around. - $this->createTransaction($savings, $checking, 1259, $transfer, 'Money for new PC', $end->format('Y-m') . '-11', $dollar); - $this->createTransaction($checking, $store, 1259, $withdrawal, 'New PC', $end->format('Y-m') . '-12', $euro); + $one = $this->createTransaction($savings, $checking, 1259, $transfer, 'Money for new PC', $end->format('Y-m') . '-11', $dollar); + $two = $this->createTransaction($checking, $store, 1259, $withdrawal, 'New PC', $end->format('Y-m') . '-12', $euro); - // create two budgets + // create a group for these two: + $group = TransactionGroup::create( + [ + 'user_id' => $user->id, + 'relation' => 'balance' + ] + ); + $group->transactionjournals()->save($one); + $group->transactionjournals()->save($two); + + + // piggy bank event + // add money to this piggy bank + // create a piggy bank event to match: + $intoPiggy = $this->createTransaction( + $checking, $savings, 100, $transfer, 'Money for piggy', + Carbon::now()->addDay()->format('Y-m-d'), $euro, $groceriesBudget, $house + ); + $event = PiggyBankEvent::create( + [ + 'piggy_bank_id' => $piggy->id, + 'transaction_journal_id' => $intoPiggy->id, + 'date' => Carbon::now()->addDay()->format('Y-m-d'), + 'amount' => 100 + ] + ); // create two categories diff --git a/app/views/transactions/create.blade.php b/app/views/transactions/create.blade.php index 5573bc0bce..5cb557e1fa 100644 --- a/app/views/transactions/create.blade.php +++ b/app/views/transactions/create.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $what) }} -{{Form::open(['class' => 'form-horizontal','url' => route('transactions.store',$what)])}} +{{Form::open(['class' => 'form-horizontal','id' => 'store','url' => route('transactions.store',$what)])}} {{Form::hidden('reminder',Input::get('reminder_id'))}}
    diff --git a/app/views/transactions/delete.blade.php b/app/views/transactions/delete.blade.php index 4a496138c4..aef2335fc8 100644 --- a/app/views/transactions/delete.blade.php +++ b/app/views/transactions/delete.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $journal) }} -{{Form::open(['class' => 'form-horizontal','url' => route('transactions.destroy',$journal->id)])}} +{{Form::open(['class' => 'form-horizontal','id' => 'destroy','url' => route('transactions.destroy',$journal->id)])}}
    diff --git a/app/views/transactions/edit.blade.php b/app/views/transactions/edit.blade.php index eb9aa0f51c..03f79385e7 100644 --- a/app/views/transactions/edit.blade.php +++ b/app/views/transactions/edit.blade.php @@ -1,7 +1,7 @@ @extends('layouts.default') @section('content') {{ Breadcrumbs::renderIfExists(Route::getCurrentRoute()->getName(), $journal) }} -{{Form::open(['class' => 'form-horizontal','url' => route('transactions.update',$journal->id)])}} +{{Form::open(['class' => 'form-horizontal','id' => 'update','url' => route('transactions.update',$journal->id)])}}
    diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php new file mode 100644 index 0000000000..f253f34f95 --- /dev/null +++ b/tests/functional/TransactionControllerCest.php @@ -0,0 +1,127 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + } + + public function create(FunctionalTester $I) + { + $I->wantTo('create a transaction'); + $I->amOnPage('/transactions/create/withdrawal?account_id=1'); + $I->see('Add a new withdrawal'); + } + + public function delete(FunctionalTester $I) + { + $I->wantTo('delete a transaction'); + $I->amOnPage('/transaction/delete/3'); + $I->see('Delete withdrawal "Huur Portaal for January 2014"'); + } + + public function destroyWithdrawal(FunctionalTester $I) + { + $I->wantTo('destroy a withdrawal'); + $I->amOnPage('/transaction/delete/3'); + $I->submitForm('#destroy', []); + $I->see('Transaction "Huur Portaal for January 2014" destroyed.'); + + } + + public function destroyDeposit(FunctionalTester $I) + { + $I->wantTo('destroy a deposit'); + $I->amOnPage('/transaction/delete/32'); + $I->submitForm('#destroy', []); + $I->see('Transaction "Salary" destroyed.'); + + } + + public function destroyTransfer(FunctionalTester $I) + { + $I->wantTo('destroy a transfer'); + $I->amOnPage('/transaction/delete/406'); + $I->submitForm('#destroy', []); + $I->see('Transaction "Money for new PC" destroyed.'); + + } + + public function edit(FunctionalTester $I) + { + $I->wantTo('edit a transaction'); + $I->amOnPage('/transaction/edit/408'); + $I->see('Edit transfer "Money for piggy"'); + } + + public function index(FunctionalTester $I) + { + $I->wantTo('see all withdrawals'); + $I->amOnPage('/transactions/withdrawal'); + $I->see('Expenses'); + } + + public function indexExpenses(FunctionalTester $I) + { + $I->wantTo('see all expenses'); + $I->amOnPage('/transactions/deposit'); + $I->see('Revenue, income and deposits'); + } + + public function indexTransfers(FunctionalTester $I) + { + $I->wantTo('see all transfers'); + $I->amOnPage('/transactions/transfers'); + $I->see('Transfers'); + } + + public function show(FunctionalTester $I) + { + $I->wantTo('see a transaction'); + $I->amOnPage('/transaction/show/406'); + $I->see('Transfer "Money for new PC"'); + $I->see('1.259'); + } + + public function store(FunctionalTester $I) + { + $I->wantTo('store a transaction'); + $I->amOnPage('/transactions/create/withdrawal'); + } + + public function update(FunctionalTester $I) + { + $I->wantTo('update a transaction'); + $I->amOnPage('/transaction/edit/3'); + $I->see('Huur Portaal for January 2014'); + $I->submitForm( + '#update', [ + 'description' => 'Huur Portaal for January 2014!', + 'account_id' => 1, + 'expense_account' => 'Portaal', + 'amount' => 500, + 'date' => '2014-01-01', + 'budget_id' => 2, + 'category' => 'House', + 'post_submit_action' => 'update' + ] + ); + $I->see('Huur Portaal for January 2014!'); + } + + +} \ No newline at end of file From 578298580edb0a7337f2b82cb8420fee536b8d70 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 00:25:17 +0100 Subject: [PATCH 37/84] Last tests for transaction controller. --- .../functional/TransactionControllerCest.php | 113 ++++++++++++++++-- 1 file changed, 104 insertions(+), 9 deletions(-) diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php index f253f34f95..ab85e29be6 100644 --- a/tests/functional/TransactionControllerCest.php +++ b/tests/functional/TransactionControllerCest.php @@ -34,15 +34,6 @@ class TransactionControllerCest $I->see('Delete withdrawal "Huur Portaal for January 2014"'); } - public function destroyWithdrawal(FunctionalTester $I) - { - $I->wantTo('destroy a withdrawal'); - $I->amOnPage('/transaction/delete/3'); - $I->submitForm('#destroy', []); - $I->see('Transaction "Huur Portaal for January 2014" destroyed.'); - - } - public function destroyDeposit(FunctionalTester $I) { $I->wantTo('destroy a deposit'); @@ -61,6 +52,15 @@ class TransactionControllerCest } + public function destroyWithdrawal(FunctionalTester $I) + { + $I->wantTo('destroy a withdrawal'); + $I->amOnPage('/transaction/delete/3'); + $I->submitForm('#destroy', []); + $I->see('Transaction "Huur Portaal for January 2014" destroyed.'); + + } + public function edit(FunctionalTester $I) { $I->wantTo('edit a transaction'); @@ -101,6 +101,61 @@ class TransactionControllerCest { $I->wantTo('store a transaction'); $I->amOnPage('/transactions/create/withdrawal'); + $I->submitForm( + '#store', [ + 'reminder' => '', + 'description' => 'Test', + 'account_id' => 1, + 'expense_account' => 'Zomaar', + 'amount' => 100, + 'date' => '2014-12-30', + 'budget_id' => 3, + 'category' => 'Categorrr', + 'post_submit_action' => 'store' + ] + ); + $I->see('Transaction "Test" stored.'); + } + + public function storeAndReturn(FunctionalTester $I) + { + $I->wantTo('store a transaction'); + $I->amOnPage('/transactions/create/withdrawal'); + $I->submitForm( + '#store', [ + 'reminder' => '', + 'description' => 'Test', + 'account_id' => 1, + 'expense_account' => 'Zomaar', + 'amount' => 100, + 'date' => '2014-12-30', + 'budget_id' => 3, + 'category' => 'Categorrr', + 'post_submit_action' => 'create_another' + ] + ); + $I->see('Transaction "Test" stored.'); + } + + + public function storeAndFail(FunctionalTester $I) + { + $I->wantTo('store a transaction and fail'); + $I->amOnPage('/transactions/create/withdrawal'); + $I->submitForm( + '#store', [ + 'reminder' => '', + 'description' => '', + 'account_id' => 1, + 'expense_account' => 'Zomaar', + 'amount' => 100, + 'date' => '2014-12-30', + 'budget_id' => 3, + 'category' => 'Categorrr', + 'post_submit_action' => 'store' + ] + ); + $I->see('Could not store transaction: This field is mandatory.'); } public function update(FunctionalTester $I) @@ -123,5 +178,45 @@ class TransactionControllerCest $I->see('Huur Portaal for January 2014!'); } + public function updateAndFail(FunctionalTester $I) + { + $I->wantTo('update a transaction and fail'); + $I->amOnPage('/transaction/edit/3'); + $I->see('Huur Portaal for January 2014'); + $I->submitForm( + '#update', [ + 'description' => '', + 'account_id' => 1, + 'expense_account' => 'Portaal', + 'amount' => 500, + 'date' => '2014-01-01', + 'budget_id' => 2, + 'category' => 'House', + 'post_submit_action' => 'update' + ] + ); + $I->see('Could not update transaction: This field is mandatory.'); + } + + public function updateAndReturn(FunctionalTester $I) + { + $I->wantTo('update a transaction and return to the edit screen'); + $I->amOnPage('/transaction/edit/3'); + $I->see('Huur Portaal for January 2014'); + $I->submitForm( + '#update', [ + 'description' => 'Huur Portaal for January 2014!', + 'account_id' => 1, + 'expense_account' => 'Portaal', + 'amount' => 500, + 'date' => '2014-01-01', + 'budget_id' => 2, + 'category' => 'House', + 'post_submit_action' => 'return_to_edit' + ] + ); + $I->see('Huur Portaal for January 2014!'); + } + } \ No newline at end of file From 7e96054dc2f4444a991a5213b4663ac660e2107b Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 00:57:12 +0100 Subject: [PATCH 38/84] Covered everything in the user controller except configuration controlled statements. --- app/controllers/UserController.php | 8 +-- app/database/seeds/DefaultUserSeeder.php | 2 + app/filters.php | 8 +++ app/lib/FireflyIII/Database/User/User.php | 3 +- .../FireflyIII/Shared/Mail/Registration.php | 22 ++++--- app/models/User.php | 2 +- app/routes.php | 4 +- app/views/user/remindme.blade.php | 2 +- tests/functional/UserControllerCest.php | 59 ++++++++++++++----- 9 files changed, 74 insertions(+), 36 deletions(-) diff --git a/app/controllers/UserController.php b/app/controllers/UserController.php index 4cf00ce1a1..00840fb375 100644 --- a/app/controllers/UserController.php +++ b/app/controllers/UserController.php @@ -33,7 +33,7 @@ class UserController extends BaseController Auth::logout(); Session::flush(); - return Redirect::route('index'); + return Redirect::route('login'); } /** @@ -67,9 +67,6 @@ class UserController extends BaseController */ public function postRegister() { - if (Config::get('auth.allow_register') !== true) { - return View::make('error')->with('message', 'Not possible'); - } /** @var \FireflyIII\Database\User\User $repository */ $repository = App::make('FireflyIII\Database\User\User'); @@ -136,9 +133,6 @@ class UserController extends BaseController */ public function register() { - if (Config::get('auth.allow_register') !== true) { - return View::make('error')->with('message', 'Not possible'); - } return View::make('user.register'); } diff --git a/app/database/seeds/DefaultUserSeeder.php b/app/database/seeds/DefaultUserSeeder.php index 4198ae4134..237d32e17c 100644 --- a/app/database/seeds/DefaultUserSeeder.php +++ b/app/database/seeds/DefaultUserSeeder.php @@ -13,6 +13,8 @@ class DefaultUserSeeder extends Seeder User::create(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james', 'reset' => null, 'remember_token' => null]); User::create(['email' => 'acceptance@example.com', 'password' => 'acceptance', 'reset' => null, 'remember_token' => null]); User::create(['email' => 'functional@example.com', 'password' => 'functional', 'reset' => null, 'remember_token' => null]); + User::create(['email' => 'reset@example.com', 'password' => 'functional', 'reset' => 'okokokokokokokokokokokokokokokok', 'remember_token' => null]); + } } diff --git a/app/filters.php b/app/filters.php index 8a73c6b6da..27e9264440 100644 --- a/app/filters.php +++ b/app/filters.php @@ -94,3 +94,11 @@ Route::filter( } } ); + +Route::filter( + 'allow-register', function () { + if (Config::get('auth.allow_register') !== true) { + return View::make('error')->with('message', 'Not possible'); + } +} +); diff --git a/app/lib/FireflyIII/Database/User/User.php b/app/lib/FireflyIII/Database/User/User.php index e63bd8d57d..698eb6033b 100644 --- a/app/lib/FireflyIII/Database/User/User.php +++ b/app/lib/FireflyIII/Database/User/User.php @@ -43,7 +43,8 @@ class User $user->reset = \Str::random(32); $user->password = \Hash::make(\Str::random(12)); - if (!$user->save()) { + // validate user: + if (!$user->isValid()) { \Log::error('Invalid user with data: ' . isset($data['email']) ? $data['email'] : '(no email!)'); \Session::flash('error', 'Input invalid, please try again: ' . $user->getErrors()->first()); diff --git a/app/lib/FireflyIII/Shared/Mail/Registration.php b/app/lib/FireflyIII/Shared/Mail/Registration.php index 774deaf203..52747d561c 100644 --- a/app/lib/FireflyIII/Shared/Mail/Registration.php +++ b/app/lib/FireflyIII/Shared/Mail/Registration.php @@ -49,11 +49,14 @@ class Registration implements RegistrationInterface $email = $user->email; $data = ['reset' => $reset]; - \Mail::send( - ['emails.user.remindme-html', 'emails.user.remindme-text'], $data, function ($message) use ($email) { - $message->to($email, $email)->subject('Forgot your password?'); + try { + \Mail::send( + ['emails.user.remindme-html', 'emails.user.remindme-text'], $data, function ($message) use ($email) { + $message->to($email, $email)->subject('Forgot your password?'); + } + ); + } catch (Swift_RfcComplianceException $e) { } - ); } @@ -72,11 +75,14 @@ class Registration implements RegistrationInterface $email = $user->email; $data = ['reset' => $reset]; - \Mail::send( - ['emails.user.verify-html', 'emails.user.verify-text'], $data, function ($message) use ($email) { - $message->to($email, $email)->subject('Verify your e-mail address.'); + try { + \Mail::send( + ['emails.user.verify-html', 'emails.user.verify-text'], $data, function ($message) use ($email) { + $message->to($email, $email)->subject('Verify your e-mail address.'); + } + ); + } catch (Swift_RfcComplianceException $e) { } - ); } } \ No newline at end of file diff --git a/app/models/User.php b/app/models/User.php index f41750cda7..6bfaf45255 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -16,7 +16,7 @@ class User extends Eloquent implements UserInterface, RemindableInterface use UserTrait, RemindableTrait, ValidatingTrait; - public static $rules + protected $rules = [ 'email' => 'required|email|unique:users,email', 'password' => 'required|between:60,60', diff --git a/app/routes.php b/app/routes.php index bb410221aa..5542d28aa1 100644 --- a/app/routes.php +++ b/app/routes.php @@ -366,7 +366,7 @@ Route::group( ['before' => 'guest'], function () { // user controller Route::get('/login', ['uses' => 'UserController@login', 'as' => 'login']); - Route::get('/register', ['uses' => 'UserController@register', 'as' => 'register']); + Route::get('/register', ['uses' => 'UserController@register', 'as' => 'register','before' => 'allow-register']); Route::get('/reset/{reset}', ['uses' => 'UserController@reset', 'as' => 'reset']); Route::get('/remindme', ['uses' => 'UserController@remindme', 'as' => 'remindme']); @@ -380,7 +380,7 @@ Route::group( // user controller Route::post('/login', ['uses' => 'UserController@postLogin', 'as' => 'login.post']); - Route::post('/register', ['uses' => 'UserController@postRegister', 'as' => 'register.post']); + Route::post('/register', ['uses' => 'UserController@postRegister', 'as' => 'register.post','before' => 'allow-register']); Route::post('/remindme', ['uses' => 'UserController@postRemindme', 'as' => 'remindme.post']); } ); \ No newline at end of file diff --git a/app/views/user/remindme.blade.php b/app/views/user/remindme.blade.php index 5ee87b70e7..252a765351 100644 --- a/app/views/user/remindme.blade.php +++ b/app/views/user/remindme.blade.php @@ -7,7 +7,7 @@

    Firefly III — Reset your password

    - {{Form::open()}} + {{Form::open(['id' => 'remindme'])}}
    diff --git a/tests/functional/UserControllerCest.php b/tests/functional/UserControllerCest.php index 06050c1bb6..62d58c9833 100644 --- a/tests/functional/UserControllerCest.php +++ b/tests/functional/UserControllerCest.php @@ -53,18 +53,11 @@ class UserControllerCest */ public function logout(FunctionalTester $I) { + $I->amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); $I->wantTo('logout'); - #$I->amOnPage('/logout'); - #$I->am - } - - /** - * @param FunctionalTester $I - */ - public function postLogin(FunctionalTester $I) - { - $I->wantTo('post login'); - $I->amOnRoute('login'); + $I->amOnPage('/'); + $I->click('Logout'); + $I->see('Firefly III — Sign In'); } /** @@ -72,14 +65,23 @@ class UserControllerCest */ public function postRegister(FunctionalTester $I) { - // @codingStandardsIgnoreStart $I->wantTo('post-register a new account'); $I->amOnPage('/register'); - $token = $I->grabValueFrom('input[name=_token]'); - $I->submitForm('#register', ['email' => 'noreply@gmail.com', '_token' => $token]); + $I->submitForm('#register', ['email' => 'noreply@gmail.com']); $I->see('Password sent!'); $I->seeRecord('users', ['email' => 'noreply@gmail.com']); - // @codingStandardsIgnoreEnd + } + + /** + * @param FunctionalTester $I + */ + public function postRegisterFail(FunctionalTester $I) + { + $I->wantTo('post-register a new account and fail'); + $I->amOnPage('/register'); + $I->submitForm('#register', ['email' => 'XXxxxxx']); + $I->see('Input invalid, please try again: The email must be a valid email address.'); + $I->dontseeRecord('users', ['email' => 'XXxxxxx']); } /** @@ -89,6 +91,19 @@ class UserControllerCest { $I->wantTo('get a password reminder'); $I->amOnRoute('remindme'); + $I->submitForm('#remindme', ['email' => 'functional@example.com']); + $I->see('You\'re about to get an e-mail.'); + } + + /** + * @param FunctionalTester $I + */ + public function postRemindmeFail(FunctionalTester $I) + { + $I->wantTo('get a password reminder and fail'); + $I->amOnRoute('remindme'); + $I->submitForm('#remindme', ['email' => 'abcdee']); + $I->see('No good!'); } /** @@ -109,6 +124,17 @@ class UserControllerCest { $I->wantTo('reminded of my password'); $I->amOnRoute('remindme'); + $I->see('Firefly III — Reset your password'); + } + + /** + * @param FunctionalTester $I + */ + public function resetFail(FunctionalTester $I) + { + $I->wantTo('reset my password and fail'); + $I->amOnPage('/reset/123'); + $I->see('Yo no hablo reset code!'); } /** @@ -117,7 +143,8 @@ class UserControllerCest public function reset(FunctionalTester $I) { $I->wantTo('reset my password'); - $I->amOnRoute('reset'); + $I->amOnPage('/reset/okokokokokokokokokokokokokokokok'); + $I->see('You\'re about to get an e-mail.'); } } \ No newline at end of file From 0cbb50ae9d7cffe13bfa5d3bbb15d4a57c3ed331 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 07:17:33 +0100 Subject: [PATCH 39/84] Full coverage for user controller. --- app/controllers/UserController.php | 18 ++++-------------- tests/functional/UserControllerCest.php | 2 +- 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/app/controllers/UserController.php b/app/controllers/UserController.php index 00840fb375..e1d3c29311 100644 --- a/app/controllers/UserController.php +++ b/app/controllers/UserController.php @@ -79,14 +79,9 @@ class UserController extends BaseController //$user = $this->user->register(Input::all()); if ($user) { - if (Config::get('auth.verify_mail') === true) { - $email->sendVerificationMail($user); + $email->sendVerificationMail($user); - return View::make('user.verification-pending'); - } - $email->sendPasswordMail($user); - - return View::make('user.registered'); + return View::make('user.verification-pending'); } @@ -115,14 +110,9 @@ class UserController extends BaseController return View::make('user.remindme'); } - if (Config::get('auth.verify_reset') === true) { - $email->sendResetVerification($user); + $email->sendResetVerification($user); - return View::make('user.verification-pending'); - } - $email->sendPasswordMail($user); - - return View::make('user.registered'); + return View::make('user.verification-pending'); } diff --git a/tests/functional/UserControllerCest.php b/tests/functional/UserControllerCest.php index 62d58c9833..53281b5536 100644 --- a/tests/functional/UserControllerCest.php +++ b/tests/functional/UserControllerCest.php @@ -68,7 +68,7 @@ class UserControllerCest $I->wantTo('post-register a new account'); $I->amOnPage('/register'); $I->submitForm('#register', ['email' => 'noreply@gmail.com']); - $I->see('Password sent!'); + $I->see('You\'re about to get an e-mail. Please follow its instructions.'); $I->seeRecord('users', ['email' => 'noreply@gmail.com']); } From 64311da4b40e20587ba58df6d33fa6a02bd91fa1 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 07:43:33 +0100 Subject: [PATCH 40/84] Full coverage for home controller --- app/models/Preference.php | 8 +++++--- app/models/User.php | 24 ++++++++++++------------ tests/functional/HomeControllerCest.php | 19 +++++++++++++++++++ 3 files changed, 36 insertions(+), 15 deletions(-) diff --git a/app/models/Preference.php b/app/models/Preference.php index 67df6c44f0..d56e0304e3 100644 --- a/app/models/Preference.php +++ b/app/models/Preference.php @@ -1,14 +1,16 @@ 'required|exists:users,id', 'name' => 'required|between:1,255', 'data' => 'required']; + protected $fillable = ['name', 'data', 'user_id']; + protected $rules + = ['user_id' => 'required|exists:users,id', 'name' => 'required|between:1,255', 'data' => 'required']; /** * @param $value diff --git a/app/models/User.php b/app/models/User.php index 6bfaf45255..6984098fa6 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -4,8 +4,8 @@ use Illuminate\Auth\Reminders\RemindableInterface; use Illuminate\Auth\Reminders\RemindableTrait; use Illuminate\Auth\UserInterface; use Illuminate\Auth\UserTrait; +use Illuminate\Database\Eloquent\Model as Eloquent; use Watson\Validating\ValidatingTrait; -use \Illuminate\Database\Eloquent\Model as Eloquent; /** * Class User @@ -16,14 +16,14 @@ class User extends Eloquent implements UserInterface, RemindableInterface use UserTrait, RemindableTrait, ValidatingTrait; + protected $fillable = ['email']; + protected $hidden = ['remember_token']; protected $rules - = [ + = [ 'email' => 'required|email|unique:users,email', 'password' => 'required|between:60,60', 'reset' => 'between:32,32', ]; - protected $fillable = ['email']; - protected $hidden = ['remember_token']; protected $table = 'users'; /** @@ -34,6 +34,14 @@ class User extends Eloquent implements UserInterface, RemindableInterface return $this->hasMany('Account'); } + /** + * @return \Illuminate\Database\Eloquent\Relations\HasMany + */ + public function bills() + { + return $this->hasMany('Bill'); + } + /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ @@ -66,14 +74,6 @@ class User extends Eloquent implements UserInterface, RemindableInterface return $this->hasMany('Preference'); } - /** - * @return \Illuminate\Database\Eloquent\Relations\HasMany - */ - public function bills() - { - return $this->hasMany('Bill'); - } - /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ diff --git a/tests/functional/HomeControllerCest.php b/tests/functional/HomeControllerCest.php index c48de4a0e4..43e43b04c6 100644 --- a/tests/functional/HomeControllerCest.php +++ b/tests/functional/HomeControllerCest.php @@ -45,6 +45,25 @@ class HomeControllerCest $I->see('Firefly'); } + /** + * @param FunctionalTester $I + */ + public function indexWithPrefs(FunctionalTester $I) + { + $I->wantTo('see the home page of Firefly using pre-set accounts'); + \Preference::whereName('frontPageAccounts')->delete(); + \Preference::create( + [ + 'user_id' => 1, + 'name' => 'frontPageAccounts', + 'data' => '[1,2]' + ] + ); + $I->amOnPage('/'); + $I->canSeeResponseCodeIs(200); + $I->see('Firefly'); + } + /** * @param FunctionalTester $I */ From 6d03ddadcc2fb1dce0c7bb55a5d99efe08ef8e16 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 08:11:00 +0100 Subject: [PATCH 41/84] Covered the final lines. --- app/database/seeds/TestContentSeeder.php | 6 +-- tests/functional/HomeControllerCest.php | 4 +- .../RepeatedExpenseControllerCest.php | 50 +++++++++++++++++++ 3 files changed, 55 insertions(+), 5 deletions(-) diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 559887e47a..98c41a1a9f 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -239,7 +239,7 @@ class TestContentSeeder extends Seeder 'match' => 'huur,portaal', 'amount_min' => 500, 'amount_max' => 700, - 'date' => '2014-01-12', + 'date' => '2014-01-01', 'active' => 1, 'automatch' => 1, 'repeat_freq' => 'monthly', @@ -255,8 +255,8 @@ class TestContentSeeder extends Seeder 'match' => 'no,match', 'amount_min' => 500, 'amount_max' => 700, - 'date' => '2014-01-12', - 'active' => 0, + 'date' => '2014-01-01', + 'active' => 1, 'automatch' => 1, 'repeat_freq' => 'monthly', 'skip' => 0, diff --git a/tests/functional/HomeControllerCest.php b/tests/functional/HomeControllerCest.php index 43e43b04c6..4b138831de 100644 --- a/tests/functional/HomeControllerCest.php +++ b/tests/functional/HomeControllerCest.php @@ -50,15 +50,15 @@ class HomeControllerCest */ public function indexWithPrefs(FunctionalTester $I) { - $I->wantTo('see the home page of Firefly using pre-set accounts'); \Preference::whereName('frontPageAccounts')->delete(); \Preference::create( [ 'user_id' => 1, 'name' => 'frontPageAccounts', - 'data' => '[1,2]' + 'data' => [1,2] ] ); + $I->wantTo('see the home page of Firefly using pre-set accounts'); $I->amOnPage('/'); $I->canSeeResponseCodeIs(200); $I->see('Firefly'); diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index 3432bec715..29b9da0f24 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -112,6 +112,56 @@ class RepeatedExpenseControllerCest $I->see('Piggy bank "TestRepeatedExpense" stored.'); } + /** + * @param FunctionalTester $I + */ + public function storeFail(FunctionalTester $I) + { + $I->wantTo('store a repeated expense and fail'); + $I->amOnPage('/repeatedexpenses/create'); + $I->submitForm( + '#store', [ + 'name' => '', + 'account_id' => 1, + 'targetamount' => 1000, + 'targetdate' => Carbon::now()->format('Y-m-d'), + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'store', + ] + ); + + $I->see('Could not store repeated expense: The name field is required.'); + } + + /** + * @param FunctionalTester $I + */ + public function storeAndReturn(FunctionalTester $I) + { + $I->wantTo('store a repeated expense and return'); + $I->amOnPage('/repeatedexpenses/create'); + $I->submitForm( + '#store', [ + 'name' => 'TestRepeatedExpense', + 'account_id' => 1, + 'targetamount' => 1000, + 'targetdate' => Carbon::now()->format('Y-m-d'), + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'create_another', + ] + ); + + $I->see('Piggy bank "TestRepeatedExpense" stored.'); + } + /** * @param FunctionalTester $I */ From 4c2938c5cdb73472daf6f48b0389c21a346b17f4 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 08:31:18 +0100 Subject: [PATCH 42/84] New content and a fix for the bill controller. --- app/database/seeds/TestContentSeeder.php | 16 ++++++++++++++++ tests/functional/BillControllerCest.php | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 98c41a1a9f..67571e2b07 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -263,6 +263,22 @@ class TestContentSeeder extends Seeder ] ); + // bill + $thirdBill = \Bill::create( + [ + 'user_id' => $user->id, + 'name' => 'Something something', + 'match' => 'mumble,mumble', + 'amount_min' => 500, + 'amount_max' => 700, + 'date' => '2014-01-01', + 'active' => 0, + 'automatch' => 1, + 'repeat_freq' => 'monthly', + 'skip' => 0, + ] + ); + // create some expense accounts. $albert = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Albert Heijn', 'active' => 1]); diff --git a/tests/functional/BillControllerCest.php b/tests/functional/BillControllerCest.php index 1b93ca5f97..88a8b571b9 100644 --- a/tests/functional/BillControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -92,7 +92,7 @@ class BillControllerCest public function rescanInactive(FunctionalTester $I) { $I->wantTo('rescan an inactive bill'); - $I->amOnPage('/bills/rescan/2'); + $I->amOnPage('/bills/rescan/3'); $I->see('Inactive bills cannot be scanned.'); } From cddc12353903b049a273a69ee190d6bbe3d97f7f Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 09:02:36 +0100 Subject: [PATCH 43/84] Removed dead code. --- app/models/BudgetLimit.php | 66 ------------------------------ app/models/LimitRepetition.php | 52 +---------------------- app/models/Piggybank.php | 56 ------------------------- app/models/PiggybankRepetition.php | 17 -------- 4 files changed, 1 insertion(+), 190 deletions(-) diff --git a/app/models/BudgetLimit.php b/app/models/BudgetLimit.php index 41887e41ed..93f4665d5d 100644 --- a/app/models/BudgetLimit.php +++ b/app/models/BudgetLimit.php @@ -31,72 +31,6 @@ class BudgetLimit extends Eloquent return $this->belongsTo('Budget'); } - /** - * TODO see if this method is still used. - * Create a new repetition for this limit, starting on - * the given date. - * - * @param Carbon $start - */ - public function createRepetition(Carbon $start) - { - - $end = clone $start; - // go to end: - switch ($this->repeat_freq) { - case 'daily': - $end->addDay(); - break; - case 'weekly': - $end->addWeek(); - break; - case 'monthly': - $end->addMonth(); - break; - case 'quarterly': - $end->addMonths(3); - break; - case 'half-year': - $end->addMonths(6); - break; - case 'yearly': - $end->addYear(); - break; - } - $end->subDay(); - $count = $this->limitrepetitions()->where('startdate', $start->format('Y-m-d'))->where('enddate', $end->format('Y-m-d'))->count(); - - if ($count == 0) { - - $repetition = new \LimitRepetition(); - $repetition->startdate = $start; - $repetition->enddate = $end; - $repetition->amount = $this->amount; - $repetition->budgetLimit()->associate($this); - - try { - $repetition->save(); - \Log::debug('Created new repetition with id #' . $repetition->id); - } catch (QueryException $e) { - // do nothing - - \Log::error('Trying to save new Limitrepetition failed!'); - \Log::error($e->getMessage()); - } - if (isset($repetition->id)) { - \Event::fire('limits.repetition', [$repetition]); // not used, I guess? - } - } else { - if ($count == 1) { - // update this one: - $repetition = $this->limitrepetitions()->where('startdate', $start->format('Y-m-d'))->where('enddate', $end->format('Y-m-d'))->first(); - $repetition->amount = $this->amount; - $repetition->save(); - - } - } - } - /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ diff --git a/app/models/LimitRepetition.php b/app/models/LimitRepetition.php index e36348f849..9faa85968d 100644 --- a/app/models/LimitRepetition.php +++ b/app/models/LimitRepetition.php @@ -33,17 +33,6 @@ class LimitRepetition extends Eloquent return ['created_at', 'updated_at', 'startdate', 'enddate']; } - /** - * TODO see if this scope is still used. - * - * How much money is left in this? - */ - public function leftInRepetition() - { - return floatval($this->amount - $this->spentInRepetition()); - - } - /** * TODO remove this method in favour of something in the FireflyIII libraries. * @@ -64,43 +53,4 @@ class LimitRepetition extends Eloquent return floatval($sum); } - - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * Returns a string used to sort this particular repetition - * based on the date and period it falls into. Ie. the limit - * repeats monthly and the start date is 12 dec 2012, this will - * return 2012-12. - */ - public function periodOrder() - { - if (is_null($this->repeat_freq)) { - $this->repeat_freq = $this->limit->repeat_freq; - } - switch ($this->repeat_freq) { - default: - throw new FireflyException('No date formats for frequency "' . $this->repeat_freq . '"!'); - break; - case 'daily': - return $this->startdate->format('Ymd') . '-5'; - break; - case 'weekly': - return $this->startdate->format('Ymd') . '-4'; - break; - case 'monthly': - return $this->startdate->format('Ymd') . '-3'; - break; - case 'quarterly': - return $this->startdate->format('Ymd') . '-2'; - break; - case 'half-year': - return $this->startdate->format('Ymd') . '-1'; - break; - case 'yearly': - return $this->startdate->format('Ymd') . '-0'; - break; - } - } - -} \ No newline at end of file +} \ No newline at end of file diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 57f497fdac..1af7da7e37 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -56,26 +56,6 @@ class PiggyBank extends Eloquent return 0; } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * @param Carbon $start - * @param Carbon $target - * - * @return PiggyBankRepetition - */ - public function createRepetition(Carbon $start = null, Carbon $target = null) - { - $rep = new \PiggyBankRepetition; - $rep->piggyBank()->associate($this); - $rep->startdate = $start; - $rep->targetdate = $target; - $rep->currentamount = 0; - $rep->save(); - - return $rep; - } - /** * TODO remove this method in favour of something in the FireflyIII libraries. * @@ -168,42 +148,6 @@ class PiggyBank extends Eloquent return $this->morphMany('Reminder', 'remindersable'); } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * Same but for specific date. - * - * @param Carbon $date - * - * @returns \PiggyBankRepetition - */ - public function repetitionForDate(Carbon $date) - { - $query = $this->piggyBankRepetitions()->where( - function ($q) use ($date) { - - $q->where( - function ($q) use ($date) { - $q->whereNull('startdate'); - $q->orWhere('startdate', '<=', $date->format('Y-m-d')); - } - )->where( - function ($q) use ($date) { - $q->whereNull('targetdate'); - $q->orWhere('targetdate', '>=', $date->format('Y-m-d')); - } - ); - } - )->orWhere( - function ($q) use ($date) { - $q->where('startdate', '>=', $date->format('Y-m-d')); - $q->where('targetdate', '>=', $date->format('Y-m-d')); - } - )->orderBy('startdate', 'ASC'); - $result = $query->first(); - - return $result; - } /** * @return \Illuminate\Database\Eloquent\Relations\HasMany diff --git a/app/models/PiggybankRepetition.php b/app/models/PiggybankRepetition.php index 1b9ca645b0..87caff4452 100644 --- a/app/models/PiggybankRepetition.php +++ b/app/models/PiggybankRepetition.php @@ -24,23 +24,6 @@ class PiggyBankRepetition extends Eloquent return ['created_at', 'updated_at', 'targetdate', 'startdate']; } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * @return float|int - */ - public function pct() - { - $total = $this->piggyBank->targetamount; - $saved = $this->currentamount; - if ($total == 0) { - return 0; - } - $pct = round(($saved / $total) * 100, 1); - - return $pct; - } - /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo */ From 8ec804204553ac415ff411c3348374825e4cea10 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 16:17:43 +0100 Subject: [PATCH 44/84] Some spell checking [skip ci] --- app/controllers/BillController.php | 2 +- app/controllers/HelpController.php | 18 +++++++++--------- app/controllers/PiggybankController.php | 3 ++- app/controllers/RepeatedExpenseController.php | 19 +++++++++---------- app/controllers/ReportController.php | 4 +++- app/controllers/TransactionController.php | 12 +++++++++--- app/controllers/UserController.php | 10 +++++----- .../FireflyIII/Collection/PiggybankPart.php | 2 +- .../FireflyIII/Shared/Mail/Registration.php | 2 +- app/routes.php | 4 ++-- app/views/user/login.blade.php | 2 +- app/views/user/register.blade.php | 2 +- .../remindMe-html.blade.php} | 0 .../remindMe-text.blade.php} | 0 ...{remindme.blade.php => remindMe.blade.php} | 2 +- tests/functional/UserControllerCest.php | 12 ++++++------ 16 files changed, 51 insertions(+), 43 deletions(-) rename app/views/{emails/user/remindme-html.blade.php => user/remindMe-html.blade.php} (100%) rename app/views/{emails/user/remindme-text.blade.php => user/remindMe-text.blade.php} (100%) rename app/views/user/{remindme.blade.php => remindMe.blade.php} (95%) diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index e87b2602fd..de7e0f3545 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -118,7 +118,7 @@ class BillController extends BaseController $hideBill = true; - return View::make('bills.show', compact('journals', 'hideBills'))->with('bill', $bill)->with( + return View::make('bills.show', compact('journals', 'hideBill', 'bill'))->with( 'subTitle', $bill->name ); } diff --git a/app/controllers/HelpController.php b/app/controllers/HelpController.php index 2ff4296b30..8d5f57155f 100644 --- a/app/controllers/HelpController.php +++ b/app/controllers/HelpController.php @@ -1,6 +1,8 @@ $helpTitle, 'text' => $helpText]); } - - // content in cache if (Cache::has('help.' . $route . '.title') && Cache::has('help.' . $route . '.text')) { $helpText = Cache::get('help.' . $route . '.text'); $helpTitle = Cache::get('help.' . $route . '.title'); @@ -30,19 +31,18 @@ class HelpController extends BaseController $uri = 'https://raw.githubusercontent.com/JC5/firefly-iii-help/master/' . e($route) . '.md'; \Log::debug('URL is: ' . $uri); try { - $content = file_get_contents($uri); + $helpText = file_get_contents($uri); } catch (ErrorException $e) { - $content = '

    There is no help for this route!

    '; \Log::error(trim($e->getMessage())); } \Log::debug('Found help for ' . $route); - \Log::debug('Help text length for route ' . $route . ' is ' . strlen($content)); - \Log::debug('Help text IS: "' . $content . '".'); - if (strlen(trim($content)) == 0) { - $content = '

    There is no help for this route.

    '; + \Log::debug('Help text length for route ' . $route . ' is ' . strlen($helpText)); + \Log::debug('Help text IS: "' . $helpText . '".'); + if (strlen(trim($helpText)) == 0) { + $helpText = '

    There is no help for this route.

    '; } - $helpText = \Michelf\Markdown::defaultTransform($content); + $helpText = \Michelf\Markdown::defaultTransform($helpText); $helpTitle = $route; Cache::put('help.' . $route . '.text', $helpText, 10080); // a week. diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index d032c4fcfe..64e5917d41 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -239,6 +239,8 @@ class PiggyBankController extends BaseController /** * @param PiggyBank $piggyBank * + * @SuppressWarnings("Unused") + * * @return \Illuminate\View\View */ public function remove(PiggyBank $piggyBank) @@ -326,7 +328,6 @@ class PiggyBankController extends BaseController // always validate: $messages = $this->_repository->validate($data); - // flash messages: Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); diff --git a/app/controllers/RepeatedExpenseController.php b/app/controllers/RepeatedExpenseController.php index a8e3d4dc73..695b5dbd7b 100644 --- a/app/controllers/RepeatedExpenseController.php +++ b/app/controllers/RepeatedExpenseController.php @@ -5,6 +5,10 @@ use FireflyIII\Database\PiggyBank\RepeatedExpense as Repository; use FireflyIII\Exception\FireflyException; /** + * @SuppressWarnings("CamelCase") // I'm fine with this. + * @SuppressWarnings("CyclomaticComplexity") // It's all 5. So ok. + * @SuppressWarnings("CouplingBetweenObjects") // There's only so much I can remove. + * * Class RepeatedExpenseController */ class RepeatedExpenseController extends BaseController @@ -28,11 +32,8 @@ class RepeatedExpenseController extends BaseController public function create() { /** @var \FireflyIII\Database\Account\Account $acct */ - $acct = App::make('FireflyIII\Database\Account\Account'); - - $periods = Config::get('firefly.piggy_bank_periods'); - - + $acct = App::make('FireflyIII\Database\Account\Account'); + $periods = Config::get('firefly.piggy_bank_periods'); $accounts = FFForm::makeSelectList($acct->getAssetAccounts()); return View::make('repeatedExpense.create', compact('accounts', 'periods'))->with('subTitle', 'Create new repeated expense')->with( @@ -122,10 +123,10 @@ class RepeatedExpenseController extends BaseController */ public function show(PiggyBank $repeatedExpense) { - $subTitle = $repeatedExpense->name; - $today = Carbon::now(); - + $subTitle = $repeatedExpense->name; + $today = Carbon::now(); $repetitions = $repeatedExpense->piggyBankRepetitions()->get(); + $repetitions->each( function (PiggyBankRepetition $repetition) { $repetition->bars = $this->_repository->calculateParts($repetition); @@ -154,7 +155,6 @@ class RepeatedExpenseController extends BaseController // always validate: $messages = $this->_repository->validate($data); - // flash messages: Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); @@ -199,7 +199,6 @@ class RepeatedExpenseController extends BaseController // always validate: $messages = $this->_repository->validate($data); - // flash messages: Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 9dc5a15f6f..037b5e2627 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -4,6 +4,8 @@ use FireflyIII\Database\TransactionJournal\TransactionJournal as TransactionJour use FireflyIII\Report\ReportInterface as Report; /** + * + * @SuppressWarnings("CamelCase") // I'm fine with this. * * Class ReportController */ @@ -92,7 +94,7 @@ class ReportController extends BaseController $budgets = $this->_repository->getBudgetsForMonth($date); $categories = $this->_repository->getCategoriesForMonth($date, 10); $accounts = $this->_repository->getAccountsForMonth($date); - $piggyBanks = $this->_repository->getPiggyBanksForMonth($date); + //$piggyBanks = $this->_repository->getPiggyBanksForMonth($date); return View::make( 'reports.month', diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index cd92e640a0..84da0e1cd7 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -7,6 +7,13 @@ use FireflyIII\Helper\TransactionJournal\HelperInterface as Helper; use Illuminate\Support\Collection; /** + * + * @SuppressWarnings("CamelCase") // I'm fine with this. + * @SuppressWarnings("CyclomaticComplexity") // It's all 5. So ok. + * @SuppressWarnings("CouplingBetweenObjects") // There's only so much I can remove. + * @SuppressWarnings("TooManyMethods") // I'm also fine with this. + * @SuppressWarnings("ExcessiveClassComplexity") + * * Class TransactionController * */ @@ -158,10 +165,10 @@ class TransactionController extends BaseController */ public function doRelate() { - $id = intval(Input::get('id')); + $brother = intval(Input::get('id')); $sister = intval(Input::get('relateTo')); - $journal = $this->_repository->find($id); + $journal = $this->_repository->find($brother); $sis = $this->_repository->find($sister); if ($journal && $sis) { @@ -358,7 +365,6 @@ class TransactionController extends BaseController // always validate: $messages = $this->_repository->validate($data); - // flash messages: Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); Session::flash('errors', $messages['errors']); diff --git a/app/controllers/UserController.php b/app/controllers/UserController.php index e1d3c29311..12d35e5d67 100644 --- a/app/controllers/UserController.php +++ b/app/controllers/UserController.php @@ -94,7 +94,7 @@ class UserController extends BaseController * * @return \Illuminate\View\View */ - public function postRemindme() + public function postRemindMe() { /** @var \FireflyIII\Database\User\User $repository */ @@ -108,7 +108,7 @@ class UserController extends BaseController if (!$user) { Session::flash('error', 'No good!'); - return View::make('user.remindme'); + return View::make('user.remindMe'); } $email->sendResetVerification($user); @@ -132,9 +132,9 @@ class UserController extends BaseController * * @return \Illuminate\View\View */ - public function remindme() + public function remindMe() { - return View::make('user.remindme'); + return View::make('user.remindMe'); } /** @@ -160,7 +160,7 @@ class UserController extends BaseController return View::make('user.registered'); } - return View::make('error')->with('message', 'Yo no hablo reset code!'); + return View::make('error')->with('message', 'No reset code found!'); } } \ No newline at end of file diff --git a/app/lib/FireflyIII/Collection/PiggybankPart.php b/app/lib/FireflyIII/Collection/PiggybankPart.php index 17193d597b..906f4f21d8 100644 --- a/app/lib/FireflyIII/Collection/PiggybankPart.php +++ b/app/lib/FireflyIII/Collection/PiggybankPart.php @@ -115,7 +115,7 @@ class PiggyBankPart { if ($this->getCurrentamount() < $this->getCumulativeAmount()) { $pct = 0; - // calculate halway point? + // calculate halfway point? if ($this->getCumulativeAmount() - $this->getCurrentamount() < $this->getAmountPerBar()) { $left = $this->getCurrentamount() % $this->getAmountPerBar(); $pct = round($left / $this->getAmountPerBar() * 100); diff --git a/app/lib/FireflyIII/Shared/Mail/Registration.php b/app/lib/FireflyIII/Shared/Mail/Registration.php index 52747d561c..af771ff265 100644 --- a/app/lib/FireflyIII/Shared/Mail/Registration.php +++ b/app/lib/FireflyIII/Shared/Mail/Registration.php @@ -51,7 +51,7 @@ class Registration implements RegistrationInterface $data = ['reset' => $reset]; try { \Mail::send( - ['emails.user.remindme-html', 'emails.user.remindme-text'], $data, function ($message) use ($email) { + ['emails.user.remindMe-html', 'emails.user.remindMe-text'], $data, function ($message) use ($email) { $message->to($email, $email)->subject('Forgot your password?'); } ); diff --git a/app/routes.php b/app/routes.php index 5542d28aa1..ae34c5cb0a 100644 --- a/app/routes.php +++ b/app/routes.php @@ -368,7 +368,7 @@ Route::group( Route::get('/login', ['uses' => 'UserController@login', 'as' => 'login']); Route::get('/register', ['uses' => 'UserController@register', 'as' => 'register','before' => 'allow-register']); Route::get('/reset/{reset}', ['uses' => 'UserController@reset', 'as' => 'reset']); - Route::get('/remindme', ['uses' => 'UserController@remindme', 'as' => 'remindme']); + Route::get('/remindMe', ['uses' => 'UserController@remindMe', 'as' => 'remindMe']); } @@ -381,6 +381,6 @@ Route::group( // user controller Route::post('/login', ['uses' => 'UserController@postLogin', 'as' => 'login.post']); Route::post('/register', ['uses' => 'UserController@postRegister', 'as' => 'register.post','before' => 'allow-register']); - Route::post('/remindme', ['uses' => 'UserController@postRemindme', 'as' => 'remindme.post']); + Route::post('/remindMe', ['uses' => 'UserController@postRemindMe', 'as' => 'remindMe.post']); } ); \ No newline at end of file diff --git a/app/views/user/login.blade.php b/app/views/user/login.blade.php index c3b6efe898..4f7e8a678e 100644 --- a/app/views/user/login.blade.php +++ b/app/views/user/login.blade.php @@ -29,7 +29,7 @@ @if(Config::get('auth.allow_register') === true) Register @endif - Forgot your password? + Forgot your password?
    {{Form::close()}}
    diff --git a/app/views/user/register.blade.php b/app/views/user/register.blade.php index c4cb0fb74a..6fbc49a849 100644 --- a/app/views/user/register.blade.php +++ b/app/views/user/register.blade.php @@ -23,7 +23,7 @@
    Back to the login form - Forgot your password? + Forgot your password?
    diff --git a/app/views/emails/user/remindme-html.blade.php b/app/views/user/remindMe-html.blade.php similarity index 100% rename from app/views/emails/user/remindme-html.blade.php rename to app/views/user/remindMe-html.blade.php diff --git a/app/views/emails/user/remindme-text.blade.php b/app/views/user/remindMe-text.blade.php similarity index 100% rename from app/views/emails/user/remindme-text.blade.php rename to app/views/user/remindMe-text.blade.php diff --git a/app/views/user/remindme.blade.php b/app/views/user/remindMe.blade.php similarity index 95% rename from app/views/user/remindme.blade.php rename to app/views/user/remindMe.blade.php index 252a765351..fcf0f179a3 100644 --- a/app/views/user/remindme.blade.php +++ b/app/views/user/remindMe.blade.php @@ -7,7 +7,7 @@

    Firefly III — Reset your password

    - {{Form::open(['id' => 'remindme'])}} + {{Form::open(['id' => 'remindMe'])}}
    diff --git a/tests/functional/UserControllerCest.php b/tests/functional/UserControllerCest.php index 53281b5536..7ee760c943 100644 --- a/tests/functional/UserControllerCest.php +++ b/tests/functional/UserControllerCest.php @@ -90,8 +90,8 @@ class UserControllerCest public function postRemindme(FunctionalTester $I) { $I->wantTo('get a password reminder'); - $I->amOnRoute('remindme'); - $I->submitForm('#remindme', ['email' => 'functional@example.com']); + $I->amOnRoute('remindMe'); + $I->submitForm('#remindMe', ['email' => 'functional@example.com']); $I->see('You\'re about to get an e-mail.'); } @@ -101,8 +101,8 @@ class UserControllerCest public function postRemindmeFail(FunctionalTester $I) { $I->wantTo('get a password reminder and fail'); - $I->amOnRoute('remindme'); - $I->submitForm('#remindme', ['email' => 'abcdee']); + $I->amOnRoute('remindMe'); + $I->submitForm('#remindMe', ['email' => 'abcdee']); $I->see('No good!'); } @@ -120,10 +120,10 @@ class UserControllerCest /** * @param FunctionalTester $I */ - public function remindme(FunctionalTester $I) + public function remindMe(FunctionalTester $I) { $I->wantTo('reminded of my password'); - $I->amOnRoute('remindme'); + $I->amOnRoute('remindMe'); $I->see('Firefly III — Reset your password'); } From 6fa73ee28d87cc03e7e1648ed10eb5d3b6b33479 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 16:45:12 +0100 Subject: [PATCH 45/84] Complexity cleanup [skip ci] --- app/controllers/TransactionController.php | 26 ++++--- .../TransactionJournal/TransactionJournal.php | 76 ++++++------------- .../TransactionType/TransactionType.php | 27 +++---- .../Helper/TransactionJournal/Helper.php | 10 +++ .../TransactionJournal/HelperInterface.php | 7 ++ app/lib/FireflyIII/Shared/Toolkit/Date.php | 35 ++++----- app/lib/FireflyIII/Shared/Toolkit/Form.php | 7 +- app/models/TransactionJournal.php | 2 +- .../functional/TransactionControllerCest.php | 4 +- tests/functional/UserControllerCest.php | 2 +- 10 files changed, 92 insertions(+), 104 deletions(-) diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 84da0e1cd7..dc0648ba89 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -165,8 +165,8 @@ class TransactionController extends BaseController */ public function doRelate() { - $brother = intval(Input::get('id')); - $sister = intval(Input::get('relateTo')); + $brother = intval(Input::get('id')); + $sister = intval(Input::get('relateTo')); $journal = $this->_repository->find($brother); $sis = $this->_repository->find($sister); @@ -358,9 +358,14 @@ class TransactionController extends BaseController */ public function store($what) { - $data = Input::except('_token'); - $data['what'] = $what; - $data['currency'] = 'EUR'; // TODO allow custom currency + $data = Input::except('_token'); + $transactionType = $this->_repository->getJournalType($what); + $transactionCurrency = $this->_repository->getJournalCurrency('EUR'); + $data['transaction_type_id'] = $transactionType->id; + $data['transaction_currency_id'] = $transactionCurrency->id; + $data['completed'] = 0; + $data['what'] = $what; + $data['currency'] = 'EUR'; // TODO allow custom currency // always validate: $messages = $this->_repository->validate($data); @@ -434,10 +439,13 @@ class TransactionController extends BaseController */ public function update(TransactionJournal $journal) { - $data = Input::except('_token'); - $data['currency'] = 'EUR'; - $data['what'] = strtolower($journal->transactionType->type); - $messages = $this->_repository->validate($data); + $data = Input::except('_token'); + $data['currency'] = 'EUR'; + $data['what'] = strtolower($journal->transactionType->type); + $data['transaction_type_id'] = $journal->transaction_type_id; + $data['transaction_currency_id'] = $journal->transaction_currency_id; + $data['completed'] = 1; + $messages = $this->_repository->validate($data); Session::flash('warnings', $messages['warnings']); Session::flash('successes', $messages['successes']); diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 8a6641d93f..0daa0aa27b 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -63,11 +63,12 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData */ public function store(array $data) { - $journalType = $this->getJournalType($data['what']); - $currency = $this->getJournalCurrency($data['currency']); - $journal = new \TransactionJournal( - ['transaction_type_id' => $journalType->id, 'transaction_currency_id' => $currency->id, 'user_id' => $this->getUser()->id, - 'description' => $data['description'], 'date' => $data['date'], 'completed' => 0] + $currency = $this->getJournalCurrency($data['currency']); + $journal = new \TransactionJournal( + [ + 'transaction_type_id' => $data['transaction_type_id'], + 'transaction_currency_id' => $currency->id, 'user_id' => $this->getUser()->id, + 'description' => $data['description'], 'date' => $data['date'], 'completed' => 0] ); $journal->save(); @@ -147,39 +148,14 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData $warnings = new MessageBag; $successes = new MessageBag; - $errors = new MessageBag; + $journal = new \TransactionJournal($model); + $journal->isValid(); + $errors = $journal->getErrors(); if (!isset($model['what'])) { $errors->add('description', 'Internal error: need to know type of transaction!'); } - if (isset($model['bill_id']) && intval($model['bill_id']) < 0) { - $errors->add('bill_id', 'Bill is invalid.'); - } - if (!isset($model['description'])) { - $errors->add('description', 'This field is mandatory.'); - } - if (isset($model['description']) && strlen($model['description']) == 0) { - $errors->add('description', 'This field is mandatory.'); - } - if (isset($model['description']) && strlen($model['description']) > 255) { - $errors->add('description', 'Description is too long.'); - } - - if (!isset($model['currency'])) { - $errors->add('description', 'Internal error: currency is mandatory!'); - } - if (isset($model['date']) && !($model['date'] instanceof Carbon) && strlen($model['date']) > 0) { - try { - new Carbon($model['date']); - } catch (\Exception $e) { - $errors->add('date', 'This date is invalid.'); - } - } - if (!isset($model['date'])) { - $errors->add('date', 'This date is invalid.'); - } - /* * Amount: */ @@ -254,12 +230,6 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData } - $validator = \Validator::make([$model], \TransactionJournal::$rules); - if ($validator->invalid()) { - $errors->merge($errors); - } - - /* * Add "OK" */ @@ -275,20 +245,6 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData } - /** - * @param $type - * - * @return \AccountType|null - * @throws FireflyException - */ - public function getJournalType($type) - { - /** @var \FireflyIII\Database\TransactionType\TransactionType $typeRepository */ - $typeRepository = \App::make('FireflyIII\Database\TransactionType\TransactionType'); - - return $typeRepository->findByWhat($type); - } - /** * @param $currency * @@ -397,6 +353,20 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData return; } + /** + * @param $type + * + * @return \TransactionType|null + * @throws FireflyException + */ + public function getJournalType($type) + { + /** @var \FireflyIII\Database\TransactionType\TransactionType $typeRepository */ + $typeRepository = \App::make('FireflyIII\Database\TransactionType\TransactionType'); + + return $typeRepository->findByWhat($type); + } + /** * Returns an object with id $id. * diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index d5bf703404..e2bb47c1ab 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -95,25 +95,16 @@ class TransactionType implements CUD, CommonDatabaseCalls */ public function findByWhat($what) { - switch ($what) { - case 'opening': - return \TransactionType::whereType('Opening balance')->first(); - break; - case 'transfer': - return \TransactionType::whereType('Transfer')->first(); - break; - case 'withdrawal': - return \TransactionType::whereType('Withdrawal')->first(); - break; - case 'deposit': - return \TransactionType::whereType('Deposit')->first(); - break; - default: - throw new FireflyException('Cannot find transaction type described as "' . e($what) . '".'); - break; - - + $translation = [ + 'opening' => 'Opening balance', + 'transfer' => 'Transfer', + 'withdrawal' => 'Withdrawal', + 'deposit' => 'Deposit', + ]; + if(!isset($translation[$what])) { + throw new FireflyException('Cannot find transaction type described as "' . e($what) . '".'); } + return \TransactionType::whereType($translation[$what])->first(); } /** diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php index 8b909c7493..b0a9496cdf 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php @@ -11,6 +11,16 @@ use Illuminate\Support\Collection; */ class Helper implements HelperInterface { + + /** + * @param $what + * + * @return int + */ + public function getTransactionTypeIdByWhat($what) { + + } + /** * * Get the account_id, which is the asset account that paid for the transaction. diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php index dc5703dc22..b500d206a1 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php @@ -22,6 +22,13 @@ interface HelperInterface */ public function getAssetAccount($what, Collection $transactions); + /** + * @param $what + * + * @return int + */ + public function getTransactionTypeIdByWhat($what); + /** * @return Collection */ diff --git a/app/lib/FireflyIII/Shared/Toolkit/Date.php b/app/lib/FireflyIII/Shared/Toolkit/Date.php index 9f563d3706..3f7b321216 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Date.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Date.php @@ -2,6 +2,7 @@ namespace FireflyIII\Shared\Toolkit; +use Carbon\Carbon; use FireflyIII\Exception\FireflyException; /** @@ -12,14 +13,14 @@ use FireflyIII\Exception\FireflyException; class Date { /** - * @param \Carbon\Carbon $theDate + * @param Carbon $theDate * @param $repeatFreq * @param $skip * * @return \Carbon\Carbon * @throws FireflyException */ - public function addPeriod(\Carbon\Carbon $theDate, $repeatFreq, $skip) + public function addPeriod(Carbon $theDate, $repeatFreq, $skip) { $date = clone $theDate; $add = ($skip + 1); @@ -58,13 +59,13 @@ class Date } /** - * @param \Carbon\Carbon $theCurrentEnd + * @param Carbon $theCurrentEnd * @param $repeatFreq * - * @return \Carbon\Carbon + * @return Carbon * @throws FireflyException */ - public function endOfPeriod(\Carbon\Carbon $theCurrentEnd, $repeatFreq) + public function endOfPeriod(Carbon $theCurrentEnd, $repeatFreq) { $currentEnd = clone $theCurrentEnd; switch ($repeatFreq) { @@ -99,14 +100,14 @@ class Date } /** - * @param \Carbon\Carbon $theCurrentEnd + * @param Carbon $theCurrentEnd * @param $repeatFreq - * @param \Carbon\Carbon $maxDate + * @param Carbon $maxDate * - * @return \Carbon\Carbon + * @return Carbon * @throws FireflyException */ - public function endOfX(\Carbon\Carbon $theCurrentEnd, $repeatFreq, \Carbon\Carbon $maxDate) + public function endOfX(Carbon $theCurrentEnd, $repeatFreq, Carbon $maxDate) { $currentEnd = clone $theCurrentEnd; switch ($repeatFreq) { @@ -148,13 +149,13 @@ class Date } /** - * @param \Carbon\Carbon $date + * @param Carbon $date * @param $repeatFrequency * * @return string * @throws FireflyException */ - public function periodShow(\Carbon\Carbon $date, $repeatFrequency) + public function periodShow(Carbon $date, $repeatFrequency) { switch ($repeatFrequency) { default: @@ -182,13 +183,13 @@ class Date } /** - * @param \Carbon\Carbon $theDate + * @param Carbon $theDate * @param $repeatFreq * - * @return \Carbon\Carbon + * @return Carbon * @throws FireflyException */ - public function startOfPeriod(\Carbon\Carbon $theDate, $repeatFreq) + public function startOfPeriod(Carbon $theDate, $repeatFreq) { $date = clone $theDate; switch ($repeatFreq) { @@ -227,14 +228,14 @@ class Date } /** - * @param \Carbon\Carbon $theDate + * @param Carbon $theDate * @param $repeatFreq * @param int $subtract * - * @return \Carbon\Carbon + * @return Carbon * @throws FireflyException */ - public function subtractPeriod(\Carbon\Carbon $theDate, $repeatFreq, $subtract = 1) + public function subtractPeriod(Carbon $theDate, $repeatFreq, $subtract = 1) { $date = clone $theDate; switch ($repeatFreq) { diff --git a/app/lib/FireflyIII/Shared/Toolkit/Form.php b/app/lib/FireflyIII/Shared/Toolkit/Form.php index 42d6270009..65310b1be4 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Form.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Form.php @@ -1,6 +1,7 @@ 'required|exists:transaction_types,id', 'transaction_currency_id' => 'required|exists:transaction_currencies,id', 'description' => 'required|between:1,255', diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php index ab85e29be6..dcaf3727fd 100644 --- a/tests/functional/TransactionControllerCest.php +++ b/tests/functional/TransactionControllerCest.php @@ -155,7 +155,7 @@ class TransactionControllerCest 'post_submit_action' => 'store' ] ); - $I->see('Could not store transaction: This field is mandatory.'); + $I->see('Could not store transaction: The description field is required.'); } public function update(FunctionalTester $I) @@ -195,7 +195,7 @@ class TransactionControllerCest 'post_submit_action' => 'update' ] ); - $I->see('Could not update transaction: This field is mandatory.'); + $I->see('Could not update transaction: The description field is required.'); } public function updateAndReturn(FunctionalTester $I) diff --git a/tests/functional/UserControllerCest.php b/tests/functional/UserControllerCest.php index 7ee760c943..d04dfcccd1 100644 --- a/tests/functional/UserControllerCest.php +++ b/tests/functional/UserControllerCest.php @@ -134,7 +134,7 @@ class UserControllerCest { $I->wantTo('reset my password and fail'); $I->amOnPage('/reset/123'); - $I->see('Yo no hablo reset code!'); + $I->see('No reset code found!'); } /** From 3386c8b455e9b5b2fd517b55ff7950b1df75e0a3 Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 31 Dec 2014 17:15:59 +0100 Subject: [PATCH 46/84] More spelling checks and small clean ups. --- app/lib/FireflyIII/Database/Account/Account.php | 14 +++++++------- app/lib/FireflyIII/Database/Budget/Budget.php | 2 +- .../TransactionCurrency/TransactionCurrency.php | 3 +++ .../TransactionJournal/TransactionJournal.php | 4 ++-- app/lib/FireflyIII/Event/Piggybank.php | 2 +- app/lib/FireflyIII/Report/Report.php | 1 + app/lib/FireflyIII/Report/ReportHelper.php | 2 +- .../FireflyIII/Report/ReportHelperInterface.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Navigation.php | 2 +- app/models/Piggybank.php | 3 ++- 10 files changed, 20 insertions(+), 15 deletions(-) diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index 1318bc040d..e4facd4374 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -514,14 +514,14 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface */ public function firstExpenseAccountOrCreate($name) { - /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepos */ - $accountTypeRepos = \App::make('FireflyIII\Database\AccountType\AccountType'); + /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepository */ + $accountTypeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); - $accountType = $accountTypeRepos->findByWhat('expense'); + $accountType = $accountTypeRepository->findByWhat('expense'); // if name is "", find cash account: if (strlen($name) == 0) { - $cashAccountType = $accountTypeRepos->findByWhat('cash'); + $cashAccountType = $accountTypeRepository->findByWhat('cash'); // find or create cash account: return \Account::firstOrCreate( @@ -543,10 +543,10 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface */ public function firstRevenueAccountOrCreate($name) { - /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepos */ - $accountTypeRepos = \App::make('FireflyIII\Database\AccountType\AccountType'); + /** @var \FireflyIII\Database\AccountType\AccountType $accountTypeRepository */ + $accountTypeRepository = \App::make('FireflyIII\Database\AccountType\AccountType'); - $accountType = $accountTypeRepos->findByWhat('revenue'); + $accountType = $accountTypeRepository->findByWhat('revenue'); $data = ['user_id' => $this->getUser()->id, 'account_type_id' => $accountType->id, 'name' => $name, 'active' => 1]; diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 5dfe0d862d..86f9a9c96c 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -237,7 +237,7 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface } /** - * This method includes the time because otherwise, SQLite doesn't understand it. + * This method includes the time because otherwise, SQLite does not understand it. * * @param \Budget $budget * @param Carbon $date diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index 887f792656..0c1360aa97 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -94,6 +94,7 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas * Returns an object with id $id. * * @param int $objectId + * @throws NotImplementedException * * @return \Eloquent */ @@ -107,6 +108,7 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas * Finds an account type using one of the "$what"'s: expense, asset, revenue, opening, etc. * * @param $what + * @throws NotImplementedException * * @return \AccountType|null */ @@ -128,6 +130,7 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas /** * @param array $objectIds + * @throws NotImplementedException * * @return Collection */ diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 0daa0aa27b..ab476a09b6 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -590,8 +590,8 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData // get already related transactions: $exclude = [$journal->id]; foreach ($journal->transactiongroups()->get() as $group) { - foreach ($group->transactionjournals() as $jrnl) { - $exclude[] = $jrnl->id; + foreach ($group->transactionjournals() as $current) { + $exclude[] = $current->id; } } $exclude = array_unique($exclude); diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index dedfa0f2e8..52ca7e727b 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -203,7 +203,7 @@ class PiggyBank $repetition->currentamount = 0; $repetition->save(); } - // then continue and do something in the current relevant timeframe. + // then continue and do something in the current relevant time frame. $currentTarget = clone $target; $currentStart = null; diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index f6fe78c975..708a84a47e 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -34,6 +34,7 @@ class Report implements ReportInterface /** * @param AccountRepository $accounts + * @param JournalRepository $journals */ public function __construct(AccountRepository $accounts, JournalRepository $journals) { diff --git a/app/lib/FireflyIII/Report/ReportHelper.php b/app/lib/FireflyIII/Report/ReportHelper.php index 354cf4c174..feea4ad0fb 100644 --- a/app/lib/FireflyIII/Report/ReportHelper.php +++ b/app/lib/FireflyIII/Report/ReportHelper.php @@ -45,7 +45,7 @@ class ReportHelper implements ReportHelperInterface /** * Turns a collection into an array. Needs the field 'id' for the key, - * and saves only 'name' and 'amount' as a subarray. + * and saves only 'name' and 'amount' as a sub array. * * @param Collection $collection * diff --git a/app/lib/FireflyIII/Report/ReportHelperInterface.php b/app/lib/FireflyIII/Report/ReportHelperInterface.php index 111d1ac348..80dcd648e6 100644 --- a/app/lib/FireflyIII/Report/ReportHelperInterface.php +++ b/app/lib/FireflyIII/Report/ReportHelperInterface.php @@ -25,7 +25,7 @@ interface ReportHelperInterface /** * Turns a collection into an array. Needs the field 'id' for the key, - * and saves 'name', 'amount','spent' (if present) as a subarray. + * and saves 'name', 'amount','spent' (if present) as a sub array. * * @param Collection $collection * diff --git a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php index 003735942f..b9c7db5bde 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php @@ -55,7 +55,7 @@ class Navigation $start = \Session::get('start', Carbon::now()->startOfMonth()); /* - * Substract some period to $start. + * Subtract some period to $start. */ $prev = $filter->previous($range, clone $start); diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 1af7da7e37..e2831b0189 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -1,6 +1,7 @@ Date: Thu, 1 Jan 2015 12:06:42 +0100 Subject: [PATCH 47/84] New unit tests to cover missed methods. --- app/controllers/GoogleChartController.php | 1 + .../2014_12_24_191544_changes_for_v322.php | 18 ++- app/lib/FireflyIII/Report/Report.php | 4 +- app/tests/TestCase.php | 29 +--- app/tests/factories/Account.php | 10 ++ app/tests/factories/AccountMeta.php | 9 ++ app/tests/factories/AccountType.php | 8 ++ codeception.yml | 7 - composer.json | 6 +- composer.lock | 125 +++++++++++++++++- tests/_bootstrap.php | 26 +--- tests/functional.suite.yml | 4 + tests/functional/AccountControllerCest.php | 7 - tests/functional/BudgetControllerCest.php | 2 - tests/functional/CategoryControllerCest.php | 5 - tests/functional/CurrencyControllerCest.php | 1 - .../functional/TransactionControllerCest.php | 53 ++++---- tests/functional/_bootstrap.php | 8 +- tests/unit/AccountTest.php | 40 ++++++ tests/unit/ExamplATest.php | 18 +++ 20 files changed, 276 insertions(+), 105 deletions(-) create mode 100644 app/tests/factories/Account.php create mode 100644 app/tests/factories/AccountMeta.php create mode 100644 app/tests/factories/AccountType.php create mode 100644 tests/unit/AccountTest.php create mode 100644 tests/unit/ExamplATest.php diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index 58c3a9dfb7..d9760aab5c 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -97,6 +97,7 @@ class GoogleChartController extends BaseController $this->_chart->addColumn('Balance for ' . $account->name, 'number'); } $current = clone $this->_start; + $current->subDay(); while ($this->_end >= $current) { $row = [clone $current]; diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 54aa328839..5fa0ed91fa 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -1,6 +1,7 @@ dropUnique('limits_component_id_startdate_repeat_freq_unique'); - // } catch (QueryException $e) { - //$table->dropUnique('unique_ci_combi'); - // } catch (PDOException $e) { - // $table->dropUnique('unique_ci_combi'); - // } +// try { +// //$table->dropUnique('unique_ci_combi'); +// } catch (QueryException $e) { +// echo 'Could not delete unique_ci_combi'; +// +// } catch (PDOException $e) { +// echo 'Could not delete unique_ci_combi'; +// } catch (Exception $e) { +// echo 'Could not delete unique_ci_combi'; +// } } ); diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 708a84a47e..6bf0f7ed43 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -109,7 +109,7 @@ class Report implements ReportInterface public function getAccountsForMonth(Carbon $date) { $start = clone $date; - $start->startOfMonth(); + $start->startOfMonth()->subDay(); $end = clone $date; $end->endOfMonth(); $list = $this->_queries->accountList(); @@ -425,7 +425,7 @@ class Report implements ReportInterface } ); $report = []; - $start->startOfYear(); + $start->startOfYear()->subDay(); $end->endOfYear(); foreach ($accounts as $account) { diff --git a/app/tests/TestCase.php b/app/tests/TestCase.php index e3ce3bcc0d..7b3950fc48 100644 --- a/app/tests/TestCase.php +++ b/app/tests/TestCase.php @@ -1,5 +1,7 @@ seed(); - - - //$this-> - } - - /** - * @param $class - * - * @return m\MockInterface - */ - public function mock($class) - { - $mock = Mockery::mock($class); - - $this->app->instance($class, $mock); - - return $mock; } static public function setupBeforeClass() { - League\FactoryMuffin\Facade::loadFactories(__DIR__ . '/factories'); + //League\FactoryMuffin\Facade::loadFactories(__DIR__ . '/factories'); + f::loadFactories(__DIR__ . '/factories'); } public function tearDown() { - m::close(); + //m::close(); } } \ No newline at end of file diff --git a/app/tests/factories/Account.php b/app/tests/factories/Account.php new file mode 100644 index 0000000000..3d4032b4d1 --- /dev/null +++ b/app/tests/factories/Account.php @@ -0,0 +1,10 @@ + 'factory|User', + 'account_type_id' => 'factory|AccountType', + 'name' => 'word', + 'active' => 'boolean', + ] +); diff --git a/app/tests/factories/AccountMeta.php b/app/tests/factories/AccountMeta.php new file mode 100644 index 0000000000..a282aa9748 --- /dev/null +++ b/app/tests/factories/AccountMeta.php @@ -0,0 +1,9 @@ + 'factory|Account', + 'name' => 'word', + 'data' => 'text' + ] +); diff --git a/app/tests/factories/AccountType.php b/app/tests/factories/AccountType.php new file mode 100644 index 0000000000..e893ea89af --- /dev/null +++ b/app/tests/factories/AccountType.php @@ -0,0 +1,8 @@ + 'word', + 'editable' => 'boolean' + ] +); diff --git a/codeception.yml b/codeception.yml index f552c34999..c8dc7c62e3 100644 --- a/codeception.yml +++ b/codeception.yml @@ -10,13 +10,6 @@ settings: memory_limit: 1024M modules: config: - Db: - dsn: 'sqlite:tests/_data/db.sqlite' - user: '' - password: '' - dump: tests/_data/dump.sql - cleanup: true - populate: true coverage: enabled: true remote: false diff --git a/composer.json b/composer.json index 005a9d3189..a1d3a88366 100644 --- a/composer.json +++ b/composer.json @@ -33,12 +33,14 @@ "doctrine/dbal": "~2.3", "satooshi/php-coveralls": "dev-master", "mockery/mockery": "@stable", - "league/factory-muffin": "~2.0", + "league/factory-muffin": "~2.1", "codeception/codeception": "*", "codeception/c3": "2.*", "sebastian/phpcpd": "*", "sebastian/phpdcd": "*", - "codeception/phpbuiltinserver": "*" + "codeception/phpbuiltinserver": "*", + "codeception/specify": "*", + "codeception/verify": "*" }, "autoload": { diff --git a/composer.lock b/composer.lock index 0007ba9fae..084857beb1 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", "This file is @generated automatically" ], - "hash": "9c8cafd9d3f40fa1e56b3a7cee419da5", + "hash": "66a93b738537ed20455648f477585c88", "packages": [ { "name": "classpreloader/classpreloader", @@ -2104,6 +2104,77 @@ ], "time": "2014-09-19 10:14:07" }, + { + "name": "codeception/specify", + "version": "0.4.1", + "source": { + "type": "git", + "url": "https://github.com/Codeception/Specify.git", + "reference": "0c0ae07adfc231115b3b72ade22f44c23c199ded" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/Codeception/Specify/zipball/0c0ae07adfc231115b3b72ade22f44c23c199ded", + "reference": "0c0ae07adfc231115b3b72ade22f44c23c199ded", + "shasum": "" + }, + "require": { + "myclabs/deep-copy": "~1.1", + "php": ">=5.4.0" + }, + "require-dev": { + "phpunit/phpunit": "~4.0" + }, + "type": "library", + "autoload": { + "psr-0": { + "Codeception\\": "src/" + } + }, + "notification-url": "https://packagist.org/downloads/", + "authors": [ + { + "name": "Michael Bodnarchuk", + "email": "davert.php@mailican.com" + } + ], + "description": "BDD code blocks for PHPUnit and Codeception", + "time": "2014-10-17 00:06:51" + }, + { + "name": "codeception/verify", + "version": "0.2.7", + "source": { + "type": "git", + "url": "https://github.com/Codeception/Verify.git", + "reference": "66e5074905f4d9590ddb805d123fe632f4baa488" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/Codeception/Verify/zipball/66e5074905f4d9590ddb805d123fe632f4baa488", + "reference": "66e5074905f4d9590ddb805d123fe632f4baa488", + "shasum": "" + }, + "require-dev": { + "phpunit/phpunit": "3.7.*" + }, + "type": "library", + "autoload": { + "files": [ + "src/Codeception/function.php" + ] + }, + "notification-url": "https://packagist.org/downloads/", + "authors": [ + { + "name": "Michael Bodnarchuk", + "email": "davert.php@mailican.com", + "homepage": "http://codeception.com" + } + ], + "description": "BDD assertion library for PHPUnit", + "time": "2014-01-22 14:40:33" + }, { "name": "doctrine/annotations", "version": "v1.2.3", @@ -3153,6 +3224,48 @@ ], "time": "2014-12-22 10:06:19" }, + { + "name": "myclabs/deep-copy", + "version": "1.2.1", + "source": { + "type": "git", + "url": "https://github.com/myclabs/DeepCopy.git", + "reference": "d93c485e71bcd22df0a994e9e3e03a3ef3a3e3f3" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/myclabs/DeepCopy/zipball/d93c485e71bcd22df0a994e9e3e03a3ef3a3e3f3", + "reference": "d93c485e71bcd22df0a994e9e3e03a3ef3a3e3f3", + "shasum": "" + }, + "require": { + "php": ">=5.4.0" + }, + "require-dev": { + "doctrine/collections": "1.*", + "phpunit/phpunit": "~4.1" + }, + "type": "library", + "autoload": { + "psr-4": { + "DeepCopy\\": "src/DeepCopy/" + } + }, + "notification-url": "https://packagist.org/downloads/", + "license": [ + "MIT" + ], + "description": "Create deep copies (clones) of your objects", + "homepage": "https://github.com/myclabs/DeepCopy", + "keywords": [ + "clone", + "copy", + "duplicate", + "object", + "object graph" + ], + "time": "2014-11-20 05:11:17" + }, { "name": "phpdocumentor/reflection-docblock", "version": "2.0.3", @@ -4122,16 +4235,16 @@ }, { "name": "sebastian/version", - "version": "1.0.3", + "version": "1.0.4", "source": { "type": "git", "url": "https://github.com/sebastianbergmann/version.git", - "reference": "b6e1f0cf6b9e1ec409a0d3e2f2a5fb0998e36b43" + "reference": "a77d9123f8e809db3fbdea15038c27a95da4058b" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/sebastianbergmann/version/zipball/b6e1f0cf6b9e1ec409a0d3e2f2a5fb0998e36b43", - "reference": "b6e1f0cf6b9e1ec409a0d3e2f2a5fb0998e36b43", + "url": "https://api.github.com/repos/sebastianbergmann/version/zipball/a77d9123f8e809db3fbdea15038c27a95da4058b", + "reference": "a77d9123f8e809db3fbdea15038c27a95da4058b", "shasum": "" }, "type": "library", @@ -4153,7 +4266,7 @@ ], "description": "Library that helps with managing the version number of Git-hosted PHP projects", "homepage": "https://github.com/sebastianbergmann/version", - "time": "2014-03-07 15:35:33" + "time": "2014-12-15 14:25:24" }, { "name": "symfony/class-loader", diff --git a/tests/_bootstrap.php b/tests/_bootstrap.php index bc088a8f9e..2a9ae24d6c 100644 --- a/tests/_bootstrap.php +++ b/tests/_bootstrap.php @@ -1,21 +1,9 @@ tests/_data/dump.sql'); +$db = realpath(__DIR__ . '/_data') . '/db.sqlite'; +$dump = realpath(__DIR__ . '/_data') . '/dump.sql'; +if (!file_exists($db)) { + $out = []; + exec('touch ' . $db); + exec('php artisan migrate --seed --env=testing', $out); + exec('sqlite3 tests/_data/db.sqlite .dump > tests/_data/dump.sql', $out); } - -/** - * Class resetToClean - */ -class resetToClean -{ - /** - * - */ - static public function clean() - { - //exec('cp ' . realpath(__DIR__ . '/_data') . '/clean.sqlite ' . realpath(__DIR__ . '/_data') . '/testing.sqlite'); - } -} \ No newline at end of file diff --git a/tests/functional.suite.yml b/tests/functional.suite.yml index 4d61ccdd3f..db06c29796 100644 --- a/tests/functional.suite.yml +++ b/tests/functional.suite.yml @@ -11,6 +11,10 @@ modules: Db: populate: false cleanup: true + dsn: 'sqlite:tests/_data/db.sqlite' + user: '' + password: '' + dump: tests/_data/dump.sql Laravel4: environment: 'testing' filters: false \ No newline at end of file diff --git a/tests/functional/AccountControllerCest.php b/tests/functional/AccountControllerCest.php index 103dd6c9b2..6577b9ef6d 100644 --- a/tests/functional/AccountControllerCest.php +++ b/tests/functional/AccountControllerCest.php @@ -55,7 +55,6 @@ class AccountControllerCest $I->see('Delete account "Delete me"'); $I->submitForm('#destroy', []); $I->dontSeeRecord('accounts', ['id' => 3, 'deleted_at' => null]); - resetToClean::clean(); } /** @@ -113,7 +112,6 @@ class AccountControllerCest $I->see('Create a new asset account'); $I->submitForm('#store', ['name' => 'New through tests.', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'store']); $I->seeRecord('accounts', ['name' => 'New through tests.']); - resetToClean::clean(); } /** @@ -128,7 +126,6 @@ class AccountControllerCest '#store', ['name' => 'New through tests.', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'create_another'] ); $I->seeRecord('accounts', ['name' => 'New through tests.']); - resetToClean::clean(); } /** @@ -141,7 +138,6 @@ class AccountControllerCest $I->see('Create a new asset account'); $I->submitForm('#store', ['name' => null, 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only']); $I->dontSeeRecord('accounts', ['name' => 'New through tests.']); - resetToClean::clean(); } /** @@ -156,7 +152,6 @@ class AccountControllerCest '#store', ['name' => 'New through tests.', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'validate_only'] ); $I->dontSeeRecord('accounts', ['name' => 'New through tests.']); - resetToClean::clean(); } /** @@ -169,7 +164,6 @@ class AccountControllerCest $I->see('Edit asset account "Delete me"'); $I->submitForm('#update', ['name' => 'Update me', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'update']); $I->seeRecord('accounts', ['name' => 'Update me']); - resetToClean::clean(); } @@ -185,7 +179,6 @@ class AccountControllerCest '#update', ['name' => 'Savings accountXX', 'what' => 'asset', 'account_role' => 'defaultExpense', 'post_submit_action' => 'return_to_edit'] ); $I->seeRecord('accounts', ['name' => 'Savings accountXX']); - resetToClean::clean(); } diff --git a/tests/functional/BudgetControllerCest.php b/tests/functional/BudgetControllerCest.php index 3e9d2ec79e..79400e7f9a 100644 --- a/tests/functional/BudgetControllerCest.php +++ b/tests/functional/BudgetControllerCest.php @@ -148,7 +148,6 @@ class BudgetControllerCest $I->see('Create a new budget'); $I->submitForm('#store', ['name' => 'New budget.', 'post_submit_action' => 'store']); $I->seeRecord('budgets', ['name' => 'New budget.']); - resetToClean::clean(); } /** @@ -197,7 +196,6 @@ class BudgetControllerCest $I->see('Edit budget "Delete me"'); $I->submitForm('#update', ['name' => 'Update me', 'post_submit_action' => 'update']); $I->seeRecord('budgets', ['name' => 'Update me']); - resetToClean::clean(); } diff --git a/tests/functional/CategoryControllerCest.php b/tests/functional/CategoryControllerCest.php index 8c688fcabb..d3452276a0 100644 --- a/tests/functional/CategoryControllerCest.php +++ b/tests/functional/CategoryControllerCest.php @@ -107,7 +107,6 @@ class CategoryControllerCest $I->see('Create a new category'); $I->submitForm('#store', ['name' => 'New category.', 'post_submit_action' => 'store']); $I->seeRecord('categories', ['name' => 'New category.']); - resetToClean::clean(); } /** @@ -120,7 +119,6 @@ class CategoryControllerCest $I->see('Create a new category'); $I->submitForm('#store', ['name' => 'New category.', 'post_submit_action' => 'create_another']); $I->seeRecord('categories', ['name' => 'New category.']); - resetToClean::clean(); } /** @@ -133,7 +131,6 @@ class CategoryControllerCest $I->see('Create a new category'); $I->submitForm('#store', ['name' => null, 'post_submit_action' => 'validate_only']); $I->dontSeeRecord('categories', ['name' => 'New category.']); - resetToClean::clean(); } /** @@ -146,7 +143,6 @@ class CategoryControllerCest $I->see('Create a new category'); $I->submitForm('#store', ['name' => 'New category.', 'post_submit_action' => 'validate_only']); $I->dontSeeRecord('categories', ['name' => 'New category.']); - resetToClean::clean(); } /** @@ -159,7 +155,6 @@ class CategoryControllerCest $I->see('Edit category "Delete me"'); $I->submitForm('#update', ['name' => 'Update me', 'post_submit_action' => 'update']); $I->seeRecord('categories', ['name' => 'Update me']); - resetToClean::clean(); } diff --git a/tests/functional/CurrencyControllerCest.php b/tests/functional/CurrencyControllerCest.php index a5e6726a59..b8b9ed7845 100644 --- a/tests/functional/CurrencyControllerCest.php +++ b/tests/functional/CurrencyControllerCest.php @@ -168,7 +168,6 @@ class CurrencyControllerCest $I->see('Edit currency "US Dollar"'); $I->submitForm('#update', ['name' => 'Successful update', 'symbol' => '$', 'code' => 'USD', 'post_submit_action' => 'update']); $I->seeRecord('transaction_currencies', ['name' => 'Successful update']); - resetToClean::clean(); } diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php index dcaf3727fd..30456cc9d6 100644 --- a/tests/functional/TransactionControllerCest.php +++ b/tests/functional/TransactionControllerCest.php @@ -46,7 +46,10 @@ class TransactionControllerCest public function destroyTransfer(FunctionalTester $I) { $I->wantTo('destroy a transfer'); - $I->amOnPage('/transaction/delete/406'); + + $journal = TransactionJournal::whereDescription('Money for new PC')->first(); + + $I->amOnPage('/transaction/delete/' . $journal->id); $I->submitForm('#destroy', []); $I->see('Transaction "Money for new PC" destroyed.'); @@ -63,8 +66,9 @@ class TransactionControllerCest public function edit(FunctionalTester $I) { + $journal = TransactionJournal::whereDescription('Money for piggy')->first(); $I->wantTo('edit a transaction'); - $I->amOnPage('/transaction/edit/408'); + $I->amOnPage('/transaction/edit/' . $journal->id); $I->see('Edit transfer "Money for piggy"'); } @@ -91,8 +95,10 @@ class TransactionControllerCest public function show(FunctionalTester $I) { + $journal = TransactionJournal::whereDescription('Money for new PC')->first(); + $I->wantTo('see a transaction'); - $I->amOnPage('/transaction/show/406'); + $I->amOnPage('/transaction/show/' . $journal->id); $I->see('Transfer "Money for new PC"'); $I->see('1.259'); } @@ -117,27 +123,6 @@ class TransactionControllerCest $I->see('Transaction "Test" stored.'); } - public function storeAndReturn(FunctionalTester $I) - { - $I->wantTo('store a transaction'); - $I->amOnPage('/transactions/create/withdrawal'); - $I->submitForm( - '#store', [ - 'reminder' => '', - 'description' => 'Test', - 'account_id' => 1, - 'expense_account' => 'Zomaar', - 'amount' => 100, - 'date' => '2014-12-30', - 'budget_id' => 3, - 'category' => 'Categorrr', - 'post_submit_action' => 'create_another' - ] - ); - $I->see('Transaction "Test" stored.'); - } - - public function storeAndFail(FunctionalTester $I) { $I->wantTo('store a transaction and fail'); @@ -158,6 +143,26 @@ class TransactionControllerCest $I->see('Could not store transaction: The description field is required.'); } + public function storeAndReturn(FunctionalTester $I) + { + $I->wantTo('store a transaction'); + $I->amOnPage('/transactions/create/withdrawal'); + $I->submitForm( + '#store', [ + 'reminder' => '', + 'description' => 'Test', + 'account_id' => 1, + 'expense_account' => 'Zomaar', + 'amount' => 100, + 'date' => '2014-12-30', + 'budget_id' => 3, + 'category' => 'Categorrr', + 'post_submit_action' => 'create_another' + ] + ); + $I->see('Transaction "Test" stored.'); + } + public function update(FunctionalTester $I) { $I->wantTo('update a transaction'); diff --git a/tests/functional/_bootstrap.php b/tests/functional/_bootstrap.php index 8a88555806..c25406adad 100644 --- a/tests/functional/_bootstrap.php +++ b/tests/functional/_bootstrap.php @@ -1,2 +1,8 @@ tests/_data/dump.sql', $out); +} \ No newline at end of file diff --git a/tests/unit/AccountTest.php b/tests/unit/AccountTest.php new file mode 100644 index 0000000000..5ffff946c7 --- /dev/null +++ b/tests/unit/AccountTest.php @@ -0,0 +1,40 @@ +updateMeta('field', 'value'); + $this->assertInstanceOf('AccountMeta', $newMeta); + $secondMeta = $account->updateMeta('field', 'newValue'); + $this->assertEquals($newMeta->id, $secondMeta->id); + $this->assertEquals($newMeta->data, 'value'); + $this->assertEquals($secondMeta->data, 'newValue'); + } + + public function testAccountUser() + { + $account = f::create('Account'); + $this->assertInstanceOf('Account', $account); + $this->assertInstanceOf('User', $account->user); + } + +} \ No newline at end of file diff --git a/tests/unit/ExamplATest.php b/tests/unit/ExamplATest.php new file mode 100644 index 0000000000..40e171dbf2 --- /dev/null +++ b/tests/unit/ExamplATest.php @@ -0,0 +1,18 @@ + Date: Thu, 1 Jan 2015 12:33:07 +0100 Subject: [PATCH 48/84] New tests and new configuration for tests. --- app/config/testingInMemory/app.php | 2 ++ app/config/testingInMemory/auth.php | 8 ++++++++ app/config/testingInMemory/cache.php | 3 +++ app/config/testingInMemory/database.php | 12 +++++++++++ app/config/testingInMemory/mail.php | 13 ++++++++++++ app/config/testingInMemory/session.php | 3 +++ app/tests/TestCase.php | 17 +++++++++++++++- app/tests/factories/Budget.php | 8 ++++++++ tests/unit/AccountTypeTest.php | 27 +++++++++++++++++++++++++ tests/unit/BudgetTest.php | 26 ++++++++++++++++++++++++ tests/unit/ExamplATest.php | 18 ----------------- 11 files changed, 118 insertions(+), 19 deletions(-) create mode 100644 app/config/testingInMemory/app.php create mode 100644 app/config/testingInMemory/auth.php create mode 100644 app/config/testingInMemory/cache.php create mode 100644 app/config/testingInMemory/database.php create mode 100644 app/config/testingInMemory/mail.php create mode 100644 app/config/testingInMemory/session.php create mode 100644 app/tests/factories/Budget.php create mode 100644 tests/unit/AccountTypeTest.php create mode 100644 tests/unit/BudgetTest.php delete mode 100644 tests/unit/ExamplATest.php diff --git a/app/config/testingInMemory/app.php b/app/config/testingInMemory/app.php new file mode 100644 index 0000000000..e729eb5ab7 --- /dev/null +++ b/app/config/testingInMemory/app.php @@ -0,0 +1,2 @@ + 'debug',]; \ No newline at end of file diff --git a/app/config/testingInMemory/auth.php b/app/config/testingInMemory/auth.php new file mode 100644 index 0000000000..0fe9e0172d --- /dev/null +++ b/app/config/testingInMemory/auth.php @@ -0,0 +1,8 @@ + false, + 'verify_reset' => true, + 'allow_register' => true + +]; diff --git a/app/config/testingInMemory/cache.php b/app/config/testingInMemory/cache.php new file mode 100644 index 0000000000..fef1e78b52 --- /dev/null +++ b/app/config/testingInMemory/cache.php @@ -0,0 +1,3 @@ + 'array',]; diff --git a/app/config/testingInMemory/database.php b/app/config/testingInMemory/database.php new file mode 100644 index 0000000000..0472797a15 --- /dev/null +++ b/app/config/testingInMemory/database.php @@ -0,0 +1,12 @@ + 'sqlite', + 'connections' => [ + 'sqlite' => [ + 'driver' => 'sqlite', + 'database' => ':memory:', + 'prefix' => '' + ] + + ] +]; \ No newline at end of file diff --git a/app/config/testingInMemory/mail.php b/app/config/testingInMemory/mail.php new file mode 100644 index 0000000000..d2df78f4cd --- /dev/null +++ b/app/config/testingInMemory/mail.php @@ -0,0 +1,13 @@ + 'smtp', + 'host' => '', + 'port' => 587, + 'from' => ['address' => '', 'name' => 'Firefly III'], + 'encryption' => 'tls', + 'username' => '', + 'password' => '', + 'sendmail' => '/usr/sbin/sendmail -bs', + 'pretend' => true, +]; diff --git a/app/config/testingInMemory/session.php b/app/config/testingInMemory/session.php new file mode 100644 index 0000000000..fef1e78b52 --- /dev/null +++ b/app/config/testingInMemory/session.php @@ -0,0 +1,3 @@ + 'array',]; diff --git a/app/tests/TestCase.php b/app/tests/TestCase.php index 7b3950fc48..295da78ad4 100644 --- a/app/tests/TestCase.php +++ b/app/tests/TestCase.php @@ -16,7 +16,8 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase public function createApplication() { $unitTesting = true; - $testEnvironment = 'testing'; + $testEnvironment = 'testingInMemory'; + return require __DIR__ . '/../../bootstrap/start.php'; @@ -25,6 +26,9 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase public function setUp() { parent::setUp(); + // reset database? + $this->prepareForTests(); + } static public function setupBeforeClass() @@ -37,4 +41,15 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase { //m::close(); } + + /** + * Migrates the database and set the mailer to 'pretend'. + * This will cause the tests to run quickly. + * + */ + private function prepareForTests() + { + Artisan::call('migrate'); + Mail::pretend(true); + } } \ No newline at end of file diff --git a/app/tests/factories/Budget.php b/app/tests/factories/Budget.php new file mode 100644 index 0000000000..1975cf53b0 --- /dev/null +++ b/app/tests/factories/Budget.php @@ -0,0 +1,8 @@ + 'word', + 'user_id' => 'factory|User' + ] +); diff --git a/tests/unit/AccountTypeTest.php b/tests/unit/AccountTypeTest.php new file mode 100644 index 0000000000..c0d29759ed --- /dev/null +++ b/tests/unit/AccountTypeTest.php @@ -0,0 +1,27 @@ +assertCount(1, $account->accountType()->first()->accounts()->get()); + } + +} \ No newline at end of file diff --git a/tests/unit/BudgetTest.php b/tests/unit/BudgetTest.php new file mode 100644 index 0000000000..9ee9b4aaad --- /dev/null +++ b/tests/unit/BudgetTest.php @@ -0,0 +1,26 @@ +assertInstanceOf('User', $budget->user); + + } +} \ No newline at end of file diff --git a/tests/unit/ExamplATest.php b/tests/unit/ExamplATest.php deleted file mode 100644 index 40e171dbf2..0000000000 --- a/tests/unit/ExamplATest.php +++ /dev/null @@ -1,18 +0,0 @@ - Date: Thu, 1 Jan 2015 13:12:05 +0100 Subject: [PATCH 49/84] More unit tests. --- app/models/Piggybank.php | 12 +------ app/models/PiggybankRepetition.php | 4 +-- app/models/Reminder.php | 20 +---------- app/models/Transaction.php | 9 ----- app/tests/TestCase.php | 2 -- app/tests/factories/PiggyBank.php | 28 +++++++++++++++ app/tests/factories/PiggyBankRepetition.php | 11 ++++++ app/tests/factories/Reminder.php | 13 +++++++ tests/unit/BudgetTest.php | 2 +- tests/unit/PiggyBankRepetitionTest.php | 29 ++++++++++++++++ tests/unit/PiggyBankTest.php | 27 +++++++++++++++ tests/unit/ReminderTest.php | 38 +++++++++++++++++++++ 12 files changed, 151 insertions(+), 44 deletions(-) create mode 100644 app/tests/factories/PiggyBank.php create mode 100644 app/tests/factories/PiggyBankRepetition.php create mode 100644 app/tests/factories/Reminder.php create mode 100644 tests/unit/PiggyBankRepetitionTest.php create mode 100644 tests/unit/PiggyBankTest.php create mode 100644 tests/unit/ReminderTest.php diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index e2831b0189..8740e6c61c 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -148,14 +148,4 @@ class PiggyBank extends Eloquent { return $this->morphMany('Reminder', 'remindersable'); } - - - /** - * @return \Illuminate\Database\Eloquent\Relations\HasMany - */ - public function transactions() - { - return $this->hasMany('Transaction'); - } - -} \ No newline at end of file +} \ No newline at end of file diff --git a/app/models/PiggybankRepetition.php b/app/models/PiggybankRepetition.php index 87caff4452..c3ca79f0e7 100644 --- a/app/models/PiggybankRepetition.php +++ b/app/models/PiggybankRepetition.php @@ -38,7 +38,7 @@ class PiggyBankRepetition extends Eloquent */ public function scopeStarts(Builder $query, Carbon $date) { - $query->where('startdate', $date->format('Y-m-d')); + $query->where('startdate', $date->format('Y-m-d 00:00:00')); } /** @@ -47,7 +47,7 @@ class PiggyBankRepetition extends Eloquent */ public function scopeTargets(Builder $query, Carbon $date) { - $query->where('targetdate', $date->format('Y-m-d')); + $query->where('targetdate', $date->format('Y-m-d 00:00:00')); } diff --git a/app/models/Reminder.php b/app/models/Reminder.php index b5002501b3..372ba5d058 100644 --- a/app/models/Reminder.php +++ b/app/models/Reminder.php @@ -12,16 +12,6 @@ class Reminder extends Eloquent protected $table = 'reminders'; - /** - * @param $value - * - * @return mixed - */ - public function getDataAttribute($value) - { - return json_decode($value); - } - /** * @return array */ @@ -49,15 +39,7 @@ class Reminder extends Eloquent */ public function scopeDateIs($query, Carbon $start, Carbon $end) { - return $query->where('startdate', $start->format('Y-m-d'))->where('enddate', $end->format('Y-m-d')); - } - - /** - * @param $value - */ - public function setDataAttribute($value) - { - $this->attributes['data'] = json_encode($value); + return $query->where('startdate', $start->format('Y-m-d 00:00:00'))->where('enddate', $end->format('Y-m-d 00:00:00')); } /** diff --git a/app/models/Transaction.php b/app/models/Transaction.php index 554d130ed3..7504215ea6 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -26,15 +26,6 @@ class Transaction extends Eloquent return $this->belongsTo('Account'); } - - /** - * @return \Illuminate\Database\Eloquent\Relations\BelongsTo - */ - public function piggyBank() - { - return $this->belongsTo('PiggyBank'); - } - /** * @param Builder $query * @param Account $account diff --git a/app/tests/TestCase.php b/app/tests/TestCase.php index 295da78ad4..59b145082c 100644 --- a/app/tests/TestCase.php +++ b/app/tests/TestCase.php @@ -26,14 +26,12 @@ class TestCase extends Illuminate\Foundation\Testing\TestCase public function setUp() { parent::setUp(); - // reset database? $this->prepareForTests(); } static public function setupBeforeClass() { - //League\FactoryMuffin\Facade::loadFactories(__DIR__ . '/factories'); f::loadFactories(__DIR__ . '/factories'); } diff --git a/app/tests/factories/PiggyBank.php b/app/tests/factories/PiggyBank.php new file mode 100644 index 0000000000..18a18fc984 --- /dev/null +++ b/app/tests/factories/PiggyBank.php @@ -0,0 +1,28 @@ + 'factory|Account', + 'name' => 'word', + 'targetamount' => 'numberBetween|10;400', + 'startdate' => 'date|Y-m-d', + 'targetdate' => 'date|Y-m-d', + 'repeats' => 'boolean', + 'rep_length' => function () { + $set = ['day', 'week', 'quarter', 'month', 'year']; + + return $set[rand(0, count($set) - 1)]; + }, + 'rep_every' => 'numberBetween:0,3', + 'rep_times' => 'numberBetween:0,3', + 'reminder' => function () { + $set = ['day', 'week', 'quarter', 'month', 'year']; + + return $set[rand(0, count($set) - 1)]; + }, + 'reminder_skip' => 'numberBetween:0,3', + 'remind_me' => 'boolean', + 'order' => 'numberBetween:0,10', + + ] +); diff --git a/app/tests/factories/PiggyBankRepetition.php b/app/tests/factories/PiggyBankRepetition.php new file mode 100644 index 0000000000..dd1bbbaf76 --- /dev/null +++ b/app/tests/factories/PiggyBankRepetition.php @@ -0,0 +1,11 @@ + 'factory|PiggyBank', + 'startdate' => 'date|Y-m-d', + 'targetdate' => 'date|Y-m-d', + 'currentamount' => 'numberBetween:0,100', + + ] +); diff --git a/app/tests/factories/Reminder.php b/app/tests/factories/Reminder.php new file mode 100644 index 0000000000..62f2a3d513 --- /dev/null +++ b/app/tests/factories/Reminder.php @@ -0,0 +1,13 @@ + 'factory|User', + 'startdate' => 'date|Y-m-d', + 'enddate' => 'date|Y-m-d', + 'active' => 'boolean', + 'notnow' => 'boolean', + 'remindersable_id' => 0, + 'remindersable_type' => '', + ] +); diff --git a/tests/unit/BudgetTest.php b/tests/unit/BudgetTest.php index 9ee9b4aaad..bbe67da42c 100644 --- a/tests/unit/BudgetTest.php +++ b/tests/unit/BudgetTest.php @@ -2,7 +2,7 @@ use League\FactoryMuffin\Facade as f; /** - * Class AccountTypeTest + * Class BudgetTest */ class BudgetTest extends TestCase { diff --git a/tests/unit/PiggyBankRepetitionTest.php b/tests/unit/PiggyBankRepetitionTest.php new file mode 100644 index 0000000000..0d889aad31 --- /dev/null +++ b/tests/unit/PiggyBankRepetitionTest.php @@ -0,0 +1,29 @@ +startdate; + $target = clone $repetition->targetdate; + + $this->assertCount(1, PiggyBankRepetition::starts($start)->get()); + $this->assertCount(1, PiggyBankRepetition::targets($target)->get()); + } +} \ No newline at end of file diff --git a/tests/unit/PiggyBankTest.php b/tests/unit/PiggyBankTest.php new file mode 100644 index 0000000000..4b9a4f617d --- /dev/null +++ b/tests/unit/PiggyBankTest.php @@ -0,0 +1,27 @@ +reminders()->save($reminder); + $this->assertCount(1, $piggyBank->reminders()->get()); + } +} \ No newline at end of file diff --git a/tests/unit/ReminderTest.php b/tests/unit/ReminderTest.php new file mode 100644 index 0000000000..3801b4aebe --- /dev/null +++ b/tests/unit/ReminderTest.php @@ -0,0 +1,38 @@ +startdate; + $end = clone $reminder->enddate; + $this->assertCount(1, Reminder::dateIs($start, $end)->get()); + + } + + public function testUser() + { + $user = f::create('User'); + $reminder = f::create('Reminder'); + $reminder->user_id = $user->id; + $reminder->save(); + + $this->assertEquals($reminder->user->id, $user->id); + } +} \ No newline at end of file From 402e8588cf94f1ec05d9748c63630e5ce97200cf Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 13:32:31 +0100 Subject: [PATCH 50/84] Even more tests! --- app/models/TransactionJournal.php | 8 --- app/tests/factories/Transaction.php | 10 +++ app/tests/factories/TransactionCurrency.php | 13 +++- app/tests/factories/TransactionGroup.php | 8 +++ tests/unit/TransactionGroupTest.php | 25 ++++++++ tests/unit/TransactionJournalTest.php | 33 ++++++++++ tests/unit/TransactionTest.php | 68 +++++++++++++++++++++ 7 files changed, 155 insertions(+), 10 deletions(-) create mode 100644 app/tests/factories/Transaction.php create mode 100644 app/tests/factories/TransactionGroup.php create mode 100644 tests/unit/TransactionGroupTest.php create mode 100644 tests/unit/TransactionJournalTest.php create mode 100644 tests/unit/TransactionTest.php diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index 99bbe53ad7..ed2d3d2158 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -125,14 +125,6 @@ class TransactionJournal extends Eloquent return $query->where('transaction_journals.date', '<=', $date->format('Y-m-d 00:00:00')); } - /** - * @param Builder $query - */ - public function scopeDefaultSorting(Builder $query) - { - $query->orderBy('date', 'DESC')->orderBy('transaction_journals.id', 'DESC'); - } - /** * @param Builder $query * @param $amount diff --git a/app/tests/factories/Transaction.php b/app/tests/factories/Transaction.php new file mode 100644 index 0000000000..42b056a423 --- /dev/null +++ b/app/tests/factories/Transaction.php @@ -0,0 +1,10 @@ + 'factory|Account', + 'transaction_journal_id' => 'factory|TransactionJournal', + 'description' => 'sentence', + 'amount' => 'numberBetween:1,100', + ] +); diff --git a/app/tests/factories/TransactionCurrency.php b/app/tests/factories/TransactionCurrency.php index 9804dd56c2..cad7372767 100644 --- a/app/tests/factories/TransactionCurrency.php +++ b/app/tests/factories/TransactionCurrency.php @@ -2,6 +2,15 @@ League\FactoryMuffin\Facade::define( 'TransactionCurrency', [ - 'code' => 'word', - ] + 'code' => function () { + $code = ''; + for ($i = 0; $i < 3; $i++) { + $code .= chr(rand(65, 90)); + } + + return $code; + }, + 'name' => 'word', + 'symbol' => '$' + ] ); diff --git a/app/tests/factories/TransactionGroup.php b/app/tests/factories/TransactionGroup.php new file mode 100644 index 0000000000..74e917a8ae --- /dev/null +++ b/app/tests/factories/TransactionGroup.php @@ -0,0 +1,8 @@ + 'factory|User', + 'relation' => 'balance', + ] +); diff --git a/tests/unit/TransactionGroupTest.php b/tests/unit/TransactionGroupTest.php new file mode 100644 index 0000000000..f6439a7638 --- /dev/null +++ b/tests/unit/TransactionGroupTest.php @@ -0,0 +1,25 @@ +assertEquals($group->user_id, $group->user->id); + } +} \ No newline at end of file diff --git a/tests/unit/TransactionJournalTest.php b/tests/unit/TransactionJournalTest.php new file mode 100644 index 0000000000..8b9e11946f --- /dev/null +++ b/tests/unit/TransactionJournalTest.php @@ -0,0 +1,33 @@ +transactions()->save($transaction); + $journal->transactions()->save($other); + + $amount = floatval($transaction->amount); + $amount++; + + $this->assertCount(1, TransactionJournal::moreThan($amount)->get()); + } +} \ No newline at end of file diff --git a/tests/unit/TransactionTest.php b/tests/unit/TransactionTest.php new file mode 100644 index 0000000000..3d89e735c5 --- /dev/null +++ b/tests/unit/TransactionTest.php @@ -0,0 +1,68 @@ +assertCount(1, Transaction::accountIs($transaction->account)->get()); + } + + public function testDateAfter() + { + $transaction = f::create('Transaction'); + $date = clone $transaction->transactionJournal->date; + $date->subDay(); + + $this->assertCount(1, Transaction::after($date)->get()); + } + + public function testDateBefore() + { + $transaction = f::create('Transaction'); + $date = clone $transaction->transactionJournal->date; + $date->addDay(); + + $this->assertCount(1, Transaction::before($date)->get()); + } + + public function testLessThan() + { + $transaction = f::create('Transaction'); + $amount = floatval($transaction->amount); + $amount--; + $this->assertCount(1, Transaction::moreThan($amount)->get()); + } + + public function testMoreThan() + { + $transaction = f::create('Transaction'); + $amount = floatval($transaction->amount); + $amount++; + + $this->assertCount(1, Transaction::moreThan($amount)->get()); + } + + public function testTransactionTypes() + { + $transaction = f::create('Transaction'); + $type = $transaction->transactionJournal->transactionType->type; + $this->assertCount(1, Transaction::transactionTypes([$type])->get()); + } +} \ No newline at end of file From 74c9feb53f049bad292349c1c3870daf8715f68c Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 13:43:34 +0100 Subject: [PATCH 51/84] More tests! --- app/models/User.php | 7 ----- app/tests/factories/Preference.php | 9 ++++++ app/tests/factories/TransactionCurrency.php | 18 +++++++++-- tests/unit/TransactionTypeTest.php | 30 ++++++++++++++++++ tests/unit/UserTest.php | 34 +++++++++++++++++++++ 5 files changed, 89 insertions(+), 9 deletions(-) create mode 100644 app/tests/factories/Preference.php create mode 100644 tests/unit/TransactionTypeTest.php create mode 100644 tests/unit/UserTest.php diff --git a/app/models/User.php b/app/models/User.php index 6984098fa6..810ac6c25c 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -98,12 +98,5 @@ class User extends Eloquent implements UserInterface, RemindableInterface return $this->hasMany('TransactionJournal'); } - /** - * @return \Illuminate\Database\Eloquent\Relations\HasManyThrough - */ - public function transactions() - { - return $this->hasManyThrough('TransactionJournal', 'Transaction'); - } } \ No newline at end of file diff --git a/app/tests/factories/Preference.php b/app/tests/factories/Preference.php new file mode 100644 index 0000000000..89a26f5812 --- /dev/null +++ b/app/tests/factories/Preference.php @@ -0,0 +1,9 @@ + 'factory|User', + 'name' => 'word', + 'data' => 'sentence', + ] +); diff --git a/app/tests/factories/TransactionCurrency.php b/app/tests/factories/TransactionCurrency.php index cad7372767..cfb3b685b0 100644 --- a/app/tests/factories/TransactionCurrency.php +++ b/app/tests/factories/TransactionCurrency.php @@ -10,7 +10,21 @@ League\FactoryMuffin\Facade::define( return $code; }, - 'name' => 'word', - 'symbol' => '$' + 'name' => function () { + $code = ''; + for ($i = 0; $i < 8; $i++) { + $code .= chr(rand(65, 90)); + } + + return $code; + }, + 'symbol' => function () { + $code = ''; + for ($i = 0; $i < 2; $i++) { + $code .= chr(rand(65, 90)); + } + + return $code; + } ] ); diff --git a/tests/unit/TransactionTypeTest.php b/tests/unit/TransactionTypeTest.php new file mode 100644 index 0000000000..c0feba77b5 --- /dev/null +++ b/tests/unit/TransactionTypeTest.php @@ -0,0 +1,30 @@ +transactionType; + $this->assertCount(1, $type->transactionJournals()->get()); + } + + +} \ No newline at end of file diff --git a/tests/unit/UserTest.php b/tests/unit/UserTest.php new file mode 100644 index 0000000000..86ad425bd6 --- /dev/null +++ b/tests/unit/UserTest.php @@ -0,0 +1,34 @@ +assertEquals($pref->user_id, $pref->user->id); + } + + public function testReminder() + { + $reminder = f::create('Reminder'); + $this->assertEquals($reminder->user_id, $reminder->user->id); + } + +} \ No newline at end of file From 6e362663b5dc7d2d81c32f52f19246cb4647e307 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 19:35:10 +0100 Subject: [PATCH 52/84] Clean up content seeder and tests. --- app/database/seeds/TestContentSeeder.php | 860 ++++++++++-------- app/models/TransactionJournal.php | 4 +- tests/functional/ReminderControllerCest.php | 18 +- .../functional/TransactionControllerCest.php | 64 +- 4 files changed, 528 insertions(+), 418 deletions(-) diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 67571e2b07..3f5468e7ec 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -3,396 +3,177 @@ use Carbon\Carbon; /** + * + * @SuppressWarnings("CamelCase") // I'm fine with this. + * * Class TestContentSeeder */ class TestContentSeeder extends Seeder { + /** @var string */ + public $eom; + /** @var string */ + public $neom; + /** @var string */ + public $nsom; + /** @var string */ + public $som; + /** @var string */ + public $today; + /** @var string */ + public $yaeom; + /** @var string */ + public $yasom; + /** @var Carbon */ + protected $_endOfMonth; + /** @var Carbon */ + protected $_nextEndOfMonth; + /** @var Carbon */ + protected $_nextStartOfMonth; + /** @var Carbon */ + protected $_startOfMonth; + /** @var Carbon */ + protected $_today; + /** @var Carbon */ + protected $_yearAgoEndOfMonth; + /** @var Carbon */ + protected $_yearAgoStartOfMonth; + /** + * + */ + public function __construct() + { + $this->_startOfMonth = Carbon::now()->startOfMonth(); + $this->som = $this->_startOfMonth->format('Y-m-d'); + + $this->_endOfMonth = Carbon::now()->endOfMonth(); + $this->eom = $this->_endOfMonth->format('Y-m-d'); + + $this->_nextStartOfMonth = Carbon::now()->addMonth()->startOfMonth(); + $this->nsom = $this->_nextStartOfMonth->format('Y-m-d'); + + $this->_nextEndOfMonth = Carbon::now()->addMonth()->endOfMonth(); + $this->neom = $this->_nextEndOfMonth->format('Y-m-d'); + + $this->_yearAgoStartOfMonth = Carbon::now()->subYear()->startOfMonth(); + $this->yasom = $this->_yearAgoStartOfMonth->format('Y-m-d'); + + $this->_yearAgoEndOfMonth = Carbon::now()->subYear()->startOfMonth(); + $this->yaeom = $this->_yearAgoEndOfMonth->format('Y-m-d'); + + + $this->_today = Carbon::now(); + $this->today = $this->_today->format('Y-m-d'); + } + + /** + * Dates are always this month, the start of this month or earlier. + */ public function run() { if (App::environment() == 'testing' || App::environment() == 'homestead') { - $assetType = AccountType::whereType('Asset account')->first(); - $expenseType = AccountType::whereType('Expense account')->first(); - $revenueType = AccountType::whereType('Revenue account')->first(); - $ibType = AccountType::whereType('Initial balance account')->first(); - - $obType = TransactionType::whereType('Opening balance')->first(); - $withdrawal = TransactionType::whereType('Withdrawal')->first(); - $transfer = TransactionType::whereType('Transfer')->first(); - $deposit = TransactionType::whereType('Deposit')->first(); - - $euro = TransactionCurrency::whereCode('EUR')->first(); - $dollar = TransactionCurrency::whereCode('USD')->first(); - $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); - if ($user) { - // create two asset accounts. - $checking = Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Checking account', 'active' => 1]); - $savings = Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Savings account', 'active' => 1]); - Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Delete me', 'active' => 1]); + // create initial accounts and various other stuff: + $this->createAssetAccounts($user); + $this->createBudgets($user); + $this->createCategories($user); + $this->createPiggyBanks($user); + $this->createReminders($user); + $this->createRecurringTransactions($user); + $this->createBills($user); + $this->createExpenseAccounts($user); + $this->createRevenueAccounts($user); - // create two budgets: - $groceriesBudget = Budget::create(['user_id' => $user->id, 'name' => 'Groceries']); - $billsBudget = Budget::create(['user_id' => $user->id, 'name' => 'Bills']); - $deleteBudget = Budget::create(['user_id' => $user->id, 'name' => 'Delete me']); - - // some limits: - $startDate = Carbon::now()->startOfMonth(); - $endDate = Carbon::now()->endOfMonth(); - $secondStart = Carbon::now()->subMonth()->startOfMonth(); - $secondEnd = Carbon::now()->subMonth()->endOfMonth(); - $limitOne = BudgetLimit::create( - ['startdate' => $startDate->format('Y-m-d'), 'amount' => 201, 'repeats' => 0, 'repeat_freq' => 'monthly', - 'budget_id' => $groceriesBudget->id] - ); - $limitTwo = BudgetLimit::create( - ['startdate' => $secondStart->format('Y-m-d'), 'amount' => 202, 'repeats' => 0, 'repeat_freq' => 'monthly', - 'budget_id' => $billsBudget->id] - ); - $limitThree = BudgetLimit::create( - ['startdate' => '2014-01-01', 'amount' => 203, 'repeats' => 0, 'repeat_freq' => 'monthly', - 'budget_id' => $deleteBudget->id] - ); - - // and because we have no filters, some repetitions: - $repOne = LimitRepetition::create( - ['budget_limit_id' => $limitOne->id, 'startdate' => $startDate->format('Y-m-d'), 'enddate' => $endDate->format('Y-m-d'), 'amount' => 201] - ); - $repTwo = LimitRepetition::create( - ['budget_limit_id' => $limitTwo->id, 'startdate' => $secondStart->format('Y-m-d'), 'enddate' => $secondEnd->format('Y-m-d'), - 'amount' => 202] - ); - $repThree = LimitRepetition::create( - ['budget_limit_id' => $limitThree->id, 'startdate' => '2014-01-01', 'enddate' => '2014-01-31', 'amount' => 203] - ); - - // create two categories: - $dailyGroceries = Category::create(['user_id' => $user->id, 'name' => 'DailyGroceries']); - $lunch = Category::create(['user_id' => $user->id, 'name' => 'Lunch']); - $house = Category::create(['user_id' => $user->id, 'name' => 'House']); - $deleteMe = Category::create(['user_id' => $user->id, 'name' => 'Delete me']); - - Component::create(['user_id' => $user->id, 'name' => 'Some Component 1', 'class' => 'Budget']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 2', 'class' => 'Budget']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 3', 'class' => 'Budget']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 4', 'class' => 'Category']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 5', 'class' => 'Category']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 6', 'class' => 'Category']); - Component::create(['user_id' => $user->id, 'name' => 'Some Component 7', 'class' => 'Category']); - - // piggy bank - $piggy = PiggyBank::create( - [ - 'account_id' => $savings->id, - 'name' => 'New camera', - 'targetamount' => 2000, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => null, - 'repeats' => 0, - 'rep_length' => null, - 'rep_every' => 0, - 'rep_times' => null, - 'reminder' => null, - 'reminder_skip' => 0, - 'remind_me' => 0, - 'order' => 0, - ] - ); + // get some objects from the database: + $checking = Account::whereName('Checking account')->orderBy('id', 'DESC')->first(); + $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); + $landLord = Account::whereName('Land lord')->orderBy('id', 'DESC')->first(); + $utilities = Account::whereName('Utilities company')->orderBy('id', 'DESC')->first(); + $television = Account::whereName('TV company')->orderBy('id', 'DESC')->first(); + $phone = Account::whereName('Phone agency')->orderBy('id', 'DESC')->first(); + $employer = Account::whereName('Employer')->orderBy('id', 'DESC')->first(); + $bills = Budget::whereName('Bills')->orderBy('id', 'DESC')->first(); + $groceries = Budget::whereName('Groceries')->orderBy('id', 'DESC')->first(); + + $house = Category::whereName('House')->orderBy('id', 'DESC')->first(); - PiggyBankEvent::create(['piggy_bank_id' => 1, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); - PiggyBankRepetition::create( - [ - 'piggy_bank_id' => $piggy->id, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => null, - 'currentamount' => 100 - ] - ); + $withdrawal = TransactionType::whereType('Withdrawal')->first(); + $deposit = TransactionType::whereType('Deposit')->first(); + $transfer = TransactionType::whereType('Transfer')->first(); - // piggy bank - $piggyTargeted = PiggyBank::create( - [ - 'account_id' => $savings->id, - 'name' => 'New clothes', - 'targetamount' => 2000, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => Carbon::now()->addMonths(4)->format('Y-m-d'), - 'repeats' => 0, - 'rep_length' => null, - 'rep_every' => 0, - 'rep_times' => null, - 'reminder' => null, - 'reminder_skip' => 0, - 'remind_me' => 0, - 'order' => 0, - ] - ); - - PiggyBankEvent::create(['piggy_bank_id' => $piggyTargeted->id, 'date' => $startDate->format('Y-m-d'), 'amount' => 100]); - PiggyBankRepetition::create( - [ - 'piggy_bank_id' => $piggyTargeted->id, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => Carbon::now()->addMonths(4)->format('Y-m-d'), - 'currentamount' => 0 - ] - ); - - // weekly reminder piggy bank - $weekly = PiggyBank::create( - [ - 'account_id' => $savings->id, - 'name' => 'Weekly reminder for clothes', - 'targetamount' => 2000, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => Carbon::now()->addYear()->subDay()->format('Y-m-d'), - 'repeats' => 0, - 'rep_length' => null, - 'rep_every' => 0, - 'rep_times' => null, - 'reminder' => 'week', - 'reminder_skip' => 0, - 'remind_me' => 1, - 'order' => 0, - ] - ); - PiggyBankRepetition::create( - [ - 'piggy_bank_id' => $weekly->id, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => Carbon::now()->addYear()->subDay()->format('Y-m-d'), - 'currentamount' => 0 - ] - ); - - // a fake reminder for this piggy bank: - Reminder::create( - [ - 'user_id' => $user->id, - 'startdate' => $startDate->format('Y-m-d'), - 'enddate' => Carbon::now()->addWeek()->format('Y-m-d'), - 'active' => 1, - 'notnow' => 0, - 'remindersable_id' => $weekly->id, - 'remindersable_type' => 'PiggyBank' - ] - ); - - // a fake reminder for this piggy bank: - Reminder::create( - [ - 'user_id' => $user->id, - 'startdate' => $startDate->format('Y-m-d'), - 'enddate' => Carbon::now()->addWeek()->format('Y-m-d'), - 'active' => 1, - 'notnow' => 0, - 'remindersable_id' => 40, - 'remindersable_type' => 'Transaction' - ] - ); - - // recurring transaction - $recurring = PiggyBank::create( - [ - 'account_id' => $savings->id, - 'name' => 'Nieuwe kleding', - 'targetamount' => 1000, - 'startdate' => Carbon::now()->subMonth()->format('Y-m-d'), - 'targetdate' => Carbon::now()->format('Y-m-d'), - 'repeats' => 1, - 'rep_length' => 'month', - 'rep_every' => 0, - 'rep_times' => 0, - 'reminder' => 'month', - 'reminder_skip' => 0, - 'remind_me' => 1, - 'order' => 0, - ] - ); - PiggyBankRepetition::create( - [ - 'piggy_bank_id' => $recurring->id, - 'startdate' => Carbon::now()->format('Y-m-d'), - 'targetdate' => Carbon::now()->addMonth()->format('Y-m-d'), - 'currentamount' => 0 - ] - ); - PiggyBankRepetition::create( - [ - 'piggy_bank_id' => $recurring->id, - 'startdate' => Carbon::now()->subMonth()->format('Y-m-d'), - 'targetdate' => Carbon::now()->format('Y-m-d'), - 'currentamount' => 0 - ] - ); - - // bill - $firstBill = \Bill::create( - [ - 'user_id' => $user->id, - 'name' => 'Huur', - 'match' => 'huur,portaal', - 'amount_min' => 500, - 'amount_max' => 700, - 'date' => '2014-01-01', - 'active' => 1, - 'automatch' => 1, - 'repeat_freq' => 'monthly', - 'skip' => 0, - ] - ); - - // bill - $secondBill = \Bill::create( - [ - 'user_id' => $user->id, - 'name' => 'Gas licht', - 'match' => 'no,match', - 'amount_min' => 500, - 'amount_max' => 700, - 'date' => '2014-01-01', - 'active' => 1, - 'automatch' => 1, - 'repeat_freq' => 'monthly', - 'skip' => 0, - ] - ); - - // bill - $thirdBill = \Bill::create( - [ - 'user_id' => $user->id, - 'name' => 'Something something', - 'match' => 'mumble,mumble', - 'amount_min' => 500, - 'amount_max' => 700, - 'date' => '2014-01-01', - 'active' => 0, - 'automatch' => 1, - 'repeat_freq' => 'monthly', - 'skip' => 0, - ] - ); + $euro = TransactionCurrency::whereCode('EUR')->first(); - // create some expense accounts. - $albert = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Albert Heijn', 'active' => 1]); - $plus = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'PLUS', 'active' => 1]); - $vitens = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Vitens', 'active' => 1]); - $greenchoice = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Greenchoice', 'active' => 1]); - $portaal = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Portaal', 'active' => 1]); - $store = Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Buy More', 'active' => 1]); + $current = clone $this->_yearAgoStartOfMonth; + while ($current < $this->_startOfMonth) { + $cur = $current->format('Y-m-d'); + $formatted = $current->format('F Y'); - // create three revenue accounts. - $employer = Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'Employer', 'active' => 1]); - $taxes = Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'IRS', 'active' => 1]); - Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'Job', 'active' => 1]); + // create expenses for rent, utilities, TV, phone on the 1st of the month. + $this->createTransaction($checking, $landLord, 800, $withdrawal, 'Rent for ' . $formatted, $cur, $euro, $bills, $house); + $this->createTransaction($checking, $utilities, 150, $withdrawal, 'Utilities for ' . $formatted, $cur, $euro, $bills, $house); + $this->createTransaction($checking, $television, 50, $withdrawal, 'TV for ' . $formatted, $cur, $euro, $bills, $house); + $this->createTransaction($checking, $phone, 50, $withdrawal, 'Phone bill for ' . $formatted, $cur, $euro, $bills, $house); - // put money in the two accounts (initial balance) - $ibChecking = Account::create( - ['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Checking account initial balance', 'active' => 0] - ); - $ibSavings = Account::create( - ['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Savings account initial balance', 'active' => 0] - ); + // income from job: + $this->createTransaction($employer, $checking, rand(3500, 4000), $deposit, 'Salary for ' . $formatted, $cur, $euro); + $this->createTransaction($checking, $savings, 2000, $transfer, 'Salary to savings account in ' . $formatted, $cur, $euro); - $this->createTransaction($ibChecking, $checking, 4000, $obType, 'Initial Balance for Checking account', '2014-01-01', $euro); - $this->createTransaction($ibSavings, $savings, 10000, $obType, 'Initial Balance for Savings account', '2014-01-01', $euro); + $this->createGroceries($current); + $this->createBigExpense(clone $current); - - // create some expenses and incomes and what-not (for every month): - $start = new Carbon('2014-01-01'); - $end = Carbon::now()->endOfMonth()->addDay(); - while ($start <= $end) { - $this->createTransaction( - $checking, $portaal, 500, $withdrawal, 'Huur Portaal for ' . $start->format('F Y'), $start->format('Y-m-') . '01', $euro, $billsBudget, - $house, - $firstBill - ); - $this->createTransaction( - $checking, $vitens, 12, $withdrawal, 'Water for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $euro, $billsBudget, $house - ); - $this->createTransaction( - $checking, $greenchoice, 110, $withdrawal, 'Power for ' . $start->format('F Y'), $start->format('Y-m-') . '02', $euro, $billsBudget, - $house - ); - - // spend on groceries - $groceriesStart = clone $start; - for ($i = 0; $i < 13; $i++) { - $amt = rand(100, 300) / 10; - $lunchAmount = rand(30, 60) / 10; - $this->createTransaction( - $checking, $plus, $lunchAmount, $withdrawal, 'Lunch', $groceriesStart->format('Y-m-d'), $dollar, $groceriesBudget, $lunch - ); - $groceriesStart->addDay(); - if (intval($groceriesStart->format('d')) % 2 == 0) { - $this->createTransaction( - $checking, $albert, $amt, $withdrawal, 'Groceries', $groceriesStart->format('Y-m-d'), $euro, $groceriesBudget, $dailyGroceries - ); - } - $groceriesStart->addDay(); - } - - // get income: - $this->createTransaction($employer, $checking, rand(1400, 1600), $deposit, 'Salary', $start->format('Y-m-') . '23', $dollar); - - // pay taxes: - $this->createTransaction( - $checking, $taxes, rand(50, 70), $withdrawal, 'Taxes in ' . $start->format('F Y'), $start->format('Y-m-') . '27', $euro - ); - - // some other stuff. - - - $start->addMonth(); - - } - - // create some big expenses, move some money around. - $one = $this->createTransaction($savings, $checking, 1259, $transfer, 'Money for new PC', $end->format('Y-m') . '-11', $dollar); - $two = $this->createTransaction($checking, $store, 1259, $withdrawal, 'New PC', $end->format('Y-m') . '-12', $euro); - - // create a group for these two: - $group = TransactionGroup::create( - [ - 'user_id' => $user->id, - 'relation' => 'balance' - ] - ); - $group->transactionjournals()->save($one); - $group->transactionjournals()->save($two); - - - // piggy bank event - // add money to this piggy bank - // create a piggy bank event to match: - $intoPiggy = $this->createTransaction( - $checking, $savings, 100, $transfer, 'Money for piggy', - Carbon::now()->addDay()->format('Y-m-d'), $euro, $groceriesBudget, $house - ); - $event = PiggyBankEvent::create( - [ - 'piggy_bank_id' => $piggy->id, - 'transaction_journal_id' => $intoPiggy->id, - 'date' => Carbon::now()->addDay()->format('Y-m-d'), - 'amount' => 100 - ] - ); - - // create two categories - - // create + echo 'Created test-content for ' . $current->format('F Y') . "\n"; + $current->addMonth(); } + + // piggy bank event + // add money to this piggy bank + // create a piggy bank event to match: + $piggyBank = PiggyBank::whereName('New camera')->orderBy('id', 'DESC')->first(); + $intoPiggy = $this->createTransaction($checking, $savings, 100, $transfer, 'Money for piggy', $this->yaeom, $euro, $groceries, $house); + PiggyBankEvent::create( + [ + 'piggy_bank_id' => $piggyBank->id, + 'transaction_journal_id' => $intoPiggy->id, + 'date' => $this->yaeom, + 'amount' => 100 + ] + ); } } + /** + * @param User $user + */ + public function createAssetAccounts(User $user) + { + $assetType = AccountType::whereType('Asset account')->first(); + $ibType = AccountType::whereType('Initial balance account')->first(); + $obType = TransactionType::whereType('Opening balance')->first(); + $euro = TransactionCurrency::whereCode('EUR')->first(); + + + $acc_a = Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Checking account', 'active' => 1]); + $acc_b = Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Savings account', 'active' => 1]); + $acc_c = Account::create(['user_id' => $user->id, 'account_type_id' => $assetType->id, 'name' => 'Delete me', 'active' => 1]); + + $acc_d = Account::create(['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Checking account initial balance', 'active' => 0]); + $acc_e = Account::create(['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Savings account initial balance', 'active' => 0]); + $acc_f = Account::create(['user_id' => $user->id, 'account_type_id' => $ibType->id, 'name' => 'Delete me initial balance', 'active' => 0]); + + + $this->createTransaction($acc_d, $acc_a, 4000, $obType, 'Initial Balance for Checking account', $this->yasom, $euro); + $this->createTransaction($acc_e, $acc_b, 10000, $obType, 'Initial Balance for Savings account', $this->yasom, $euro); + $this->createTransaction($acc_f, $acc_c, 100, $obType, 'Initial Balance for Delete me', $this->yasom, $euro); + } + /** * @param Account $from * @param Account $to @@ -420,30 +201,14 @@ class TestContentSeeder extends Seeder /** @var TransactionJournal $journal */ $journal = TransactionJournal::create( [ - 'user_id' => $user->id, - 'transaction_type_id' => $type->id, - 'transaction_currency_id' => $currency->id, - 'bill_id' => $billID, - 'description' => $description, - 'completed' => 1, - 'date' => $date + 'user_id' => $user->id, 'transaction_type_id' => $type->id, 'transaction_currency_id' => $currency->id, 'bill_id' => $billID, + 'description' => $description, 'completed' => 1, 'date' => $date ] ); - Transaction::create( - [ - 'account_id' => $from->id, - 'transaction_journal_id' => $journal->id, - 'amount' => $amount * -1 - ] - ); - Transaction::create( - [ - 'account_id' => $to->id, - 'transaction_journal_id' => $journal->id, - 'amount' => $amount - ] - ); + Transaction::create(['account_id' => $from->id, 'transaction_journal_id' => $journal->id, 'amount' => $amount * -1]); + Transaction::create(['account_id' => $to->id, 'transaction_journal_id' => $journal->id, 'amount' => $amount]); + if (!is_null($budget)) { $journal->budgets()->save($budget); } @@ -453,4 +218,333 @@ class TestContentSeeder extends Seeder return $journal; } + + /** + * @param User $user + */ + public function createBudgets(User $user) + { + + $groceries = Budget::create(['user_id' => $user->id, 'name' => 'Groceries']); + $bills = Budget::create(['user_id' => $user->id, 'name' => 'Bills']); + $deleteMe = Budget::create(['user_id' => $user->id, 'name' => 'Delete me']); + $groceriesLimit = BudgetLimit::create( + ['startdate' => $this->som, 'amount' => 201, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $groceries->id] + ); + $billsLimit = BudgetLimit::create( + ['startdate' => $this->som, 'amount' => 202, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $bills->id] + ); + $deleteMeLimit = BudgetLimit::create( + ['startdate' => $this->som, 'amount' => 203, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $deleteMe->id] + ); + + // and because we have no filters, some repetitions: + LimitRepetition::create(['budget_limit_id' => $groceriesLimit->id, 'startdate' => $this->som, 'enddate' => $this->eom, 'amount' => 201]); + LimitRepetition::create(['budget_limit_id' => $billsLimit->id, 'startdate' => $this->som, 'enddate' => $this->eom, 'amount' => 202]); + LimitRepetition::create(['budget_limit_id' => $deleteMeLimit->id, 'startdate' => $this->som, 'enddate' => $this->eom, 'amount' => 203]); + } + + /** + * @param User $user + */ + public function createCategories(User $user) + { + Category::create(['user_id' => $user->id, 'name' => 'DailyGroceries']); + Category::create(['user_id' => $user->id, 'name' => 'Lunch']); + Category::create(['user_id' => $user->id, 'name' => 'House']); + Category::create(['user_id' => $user->id, 'name' => 'Delete me']); + + } + + /** + * @param User $user + */ + public function createPiggyBanks(User $user) + { + // account: + $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); + + // some dates: + $endDate = clone $this->_startOfMonth; + $nextYear = clone $this->_startOfMonth; + + $endDate->addMonths(4); + $nextYear->addYear()->subDay(); + + $next = $nextYear->format('Y-m-d'); + $end = $endDate->format('Y-m-d'); + + // piggy bank + $newCamera = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'New camera', + 'targetamount' => 2000, + 'startdate' => $this->som, + 'targetdate' => null, + 'repeats' => 0, + 'rep_length' => null, + 'rep_every' => 0, + 'rep_times' => null, + 'reminder' => null, + 'reminder_skip' => 0, + 'remind_me' => 0, + 'order' => 0, + ] + ); + // and some events! + PiggyBankEvent::create(['piggy_bank_id' => $newCamera->id, 'date' => $this->som, 'amount' => 100]); + PiggyBankRepetition::create(['piggy_bank_id' => $newCamera->id, 'startdate' => $this->som, 'targetdate' => null, 'currentamount' => 100]); + + + $newClothes = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'New clothes', + 'targetamount' => 2000, + 'startdate' => $this->som, + 'targetdate' => $end, + 'repeats' => 0, + 'rep_length' => null, + 'rep_every' => 0, + 'rep_times' => null, + 'reminder' => null, + 'reminder_skip' => 0, + 'remind_me' => 0, + 'order' => 0, + ] + ); + + PiggyBankEvent::create(['piggy_bank_id' => $newClothes->id, 'date' => $this->som, 'amount' => 100]); + PiggyBankRepetition::create(['piggy_bank_id' => $newClothes->id, 'startdate' => $this->som, 'targetdate' => $end, 'currentamount' => 100]); + + // weekly reminder piggy bank + $weekly = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'Weekly reminder for clothes', + 'targetamount' => 2000, + 'startdate' => $this->som, + 'targetdate' => $next, + 'repeats' => 0, + 'rep_length' => null, + 'rep_every' => 0, + 'rep_times' => null, + 'reminder' => 'week', + 'reminder_skip' => 0, + 'remind_me' => 1, + 'order' => 0, + ] + ); + PiggyBankRepetition::create(['piggy_bank_id' => $weekly->id, 'startdate' => $this->som, 'targetdate' => $next, 'currentamount' => 0]); + } + + /** + * @param User $user + */ + public function createReminders(User $user) + { + // for weekly piggy bank (clothes) + $nextWeek = clone $this->_startOfMonth; + $piggyBank = PiggyBank::whereName('New clothes')->orderBy('id', 'DESC')->first(); + $nextWeek->addWeek(); + $week = $nextWeek->format('Y-m-d'); + + Reminder::create( + ['user_id' => $user->id, 'startdate' => $this->som, 'enddate' => $week, 'active' => 1, 'notnow' => 0, + 'remindersable_id' => $piggyBank->id, 'remindersable_type' => 'PiggyBank'] + ); + + // a fake reminder:: + Reminder::create( + ['user_id' => $user->id, 'startdate' => $this->som, 'enddate' => $week, 'active' => 0, 'notnow' => 0, 'remindersable_id' => 40, + 'remindersable_type' => 'Transaction'] + ); + } + + /** + * @param User $user + */ + public function createRecurringTransactions(User $user) + { + // account: + $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); + + $recurring = PiggyBank::create( + [ + 'account_id' => $savings->id, + 'name' => 'Nieuwe spullen', + 'targetamount' => 1000, + 'startdate' => $this->som, + 'targetdate' => $this->eom, + 'repeats' => 1, + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'reminder' => 'month', + 'reminder_skip' => 0, + 'remind_me' => 1, + 'order' => 0, + ] + ); + PiggyBankRepetition::create(['piggy_bank_id' => $recurring->id, 'startdate' => $this->som, 'targetdate' => $this->eom, 'currentamount' => 0]); + PiggyBankRepetition::create( + ['piggy_bank_id' => $recurring->id, 'startdate' => $this->nsom, 'targetdate' => $this->neom, 'currentamount' => 0] + ); + Reminder::create( + ['user_id' => $user->id, 'startdate' => $this->som, 'enddate' => $this->neom, 'active' => 1, 'notnow' => 0, + 'remindersable_id' => $recurring->id, 'remindersable_type' => 'PiggyBank'] + ); + } + + /** + * @param $user + */ + public function createBills($user) + { + // bill + Bill::create( + [ + 'user_id' => $user->id, 'name' => 'Huur', 'match' => 'huur,portaal', 'amount_min' => 500, + 'amount_max' => 700, + 'date' => $this->som, + 'active' => 1, + 'automatch' => 1, + 'repeat_freq' => 'monthly', + 'skip' => 0, + ] + ); + + // bill + Bill::create( + [ + 'user_id' => $user->id, + 'name' => 'Gas licht', + 'match' => 'no,match', + 'amount_min' => 500, + 'amount_max' => 700, + 'date' => $this->som, + 'active' => 1, + 'automatch' => 1, + 'repeat_freq' => 'monthly', + 'skip' => 0, + ] + ); + + // bill + Bill::create( + [ + 'user_id' => $user->id, + 'name' => 'Something something', + 'match' => 'mumble,mumble', + 'amount_min' => 500, + 'amount_max' => 700, + 'date' => $this->som, + 'active' => 0, + 'automatch' => 1, + 'repeat_freq' => 'monthly', + 'skip' => 0, + ] + ); + + } + + /** + * @param $user + */ + public function createExpenseAccounts($user) + { + //// create expenses for rent, utilities, water, TV, phone on the 1st of the month. + $expenseType = AccountType::whereType('Expense account')->first(); + + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Land lord', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Utilities company', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Water company', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'TV company', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Phone agency', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Super savers', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Groceries House', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Lunch House', 'active' => 1]); + + + Account::create(['user_id' => $user->id, 'account_type_id' => $expenseType->id, 'name' => 'Buy More', 'active' => 1]); + + } + + /** + * @param $user + */ + public function createRevenueAccounts($user) + { + $revenueType = AccountType::whereType('Revenue account')->first(); + + Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'Employer', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'IRS', 'active' => 1]); + Account::create(['user_id' => $user->id, 'account_type_id' => $revenueType->id, 'name' => 'Second job employer', 'active' => 1]); + + } + + /** + * @param Carbon $date + */ + public function createGroceries(Carbon $date) + { + // variables we need: + $checking = Account::whereName('Checking account')->orderBy('id', 'DESC')->first(); + $shopOne = Account::whereName('Groceries House')->orderBy('id', 'DESC')->first(); + $shopTwo = Account::whereName('Super savers')->orderBy('id', 'DESC')->first(); + $lunchHouse = Account::whereName('Lunch House')->orderBy('id', 'DESC')->first(); + $lunch = Category::whereName('Lunch')->orderBy('id', 'DESC')->first(); + $daily = Category::whereName('DailyGroceries')->orderBy('id', 'DESC')->first(); + $euro = TransactionCurrency::whereCode('EUR')->first(); + $withdrawal = TransactionType::whereType('Withdrawal')->first(); + $groceries = Budget::whereName('Groceries')->orderBy('id', 'DESC')->first(); + + + $shops = [$shopOne, $shopTwo]; + + // create groceries and lunch (daily, between 5 and 10 euro). + $mStart = clone $date; + $mEnd = clone $date; + $mEnd->endOfMonth(); + while ($mStart <= $mEnd) { + $mFormat = $mStart->format('Y-m-d'); + $shop = $shops[rand(0, 1)]; + + $this->createTransaction($checking, $shop, (rand(500, 1000) / 100), $withdrawal, 'Groceries', $mFormat, $euro, $groceries, $daily); + $this->createTransaction($checking, $lunchHouse, (rand(200, 600) / 100), $withdrawal, 'Lunch', $mFormat, $euro, $groceries, $lunch); + + $mStart->addDay(); + } + } + + public function createBigExpense($date) + { + $date->addDays(12); + $dollar = TransactionCurrency::whereCode('USD')->first(); + $checking = Account::whereName('Checking account')->orderBy('id', 'DESC')->first(); + $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); + $buyMore = Account::whereName('Buy More')->orderBy('id', 'DESC')->first(); + $withdrawal = TransactionType::whereType('Withdrawal')->first(); + $transfer = TransactionType::whereType('Transfer')->first(); + $user = User::whereEmail('thegrumpydictator@gmail.com')->first(); + + + // create some big expenses, move some money around. + $amount = rand(500, 2000); + $one = $this->createTransaction( + $savings, $checking, $amount, $transfer, 'Money for big expense in ' . $date->format('F Y'), $date->format('Y-m-d'), $dollar + ); + $two = $this->createTransaction( + $checking, $buyMore, $amount, $withdrawal, 'Big expense in ' . $date->format('F Y'), $date->format('Y-m-d'), $dollar + ); + $group = TransactionGroup::create( + [ + 'user_id' => $user->id, + 'relation' => 'balance' + ] + ); + $group->transactionjournals()->save($one); + $group->transactionjournals()->save($two); + } } \ No newline at end of file diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index ed2d3d2158..c6b7a0415b 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -29,7 +29,7 @@ class TransactionJournal extends Eloquent public function budgets() { return $this->belongsToMany( - 'Budget', 'budget_transaction_journal', 'transaction_journal_id', 'budget_id' + 'Budget' ); } @@ -39,7 +39,7 @@ class TransactionJournal extends Eloquent public function categories() { return $this->belongsToMany( - 'Category', 'category_transaction_journal', 'transaction_journal_id', 'category_id' + 'Category' ); } diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php index 5677e44d07..41d2bac3c6 100644 --- a/tests/functional/ReminderControllerCest.php +++ b/tests/functional/ReminderControllerCest.php @@ -29,9 +29,13 @@ class ReminderControllerCest */ public function act(FunctionalTester $I) { - $I->wantTo('act on a reminder'); - $I->amOnPage('/reminders/1/act'); - $I->see('Money for Weekly reminder for clothes'); + $reminder = Reminder::leftJoin('piggy_banks', 'piggy_banks.id', '=', 'reminders.remindersable_id')->where('piggy_banks.reminder','!=','')->first( + ['reminders.*'] + ); + + $I->wantTo('act on reminder ' . boolstr(is_null($reminder))); + $I->amOnPage('/reminders/' . $reminder->id . '/act'); + $I->see('Money for Nieuwe spullen'); } /** @@ -69,10 +73,14 @@ class ReminderControllerCest */ public function show(FunctionalTester $I) { + $reminder = Reminder::leftJoin('piggy_banks', 'piggy_banks.id', '=', 'reminders.remindersable_id')->where('piggy_banks.reminder','!=','')->first( + ['reminders.*'] + ); + $I->wantTo('see a reminder'); - $I->amOnPage('/reminders/1'); + $I->amOnPage('/reminders/'.$reminder->id); $I->see('A reminder about'); - $I->see('your piggy bank labelled "Weekly reminder for clothes"'); + $I->see('your piggy bank labelled "Nieuwe spullen"'); } } \ No newline at end of file diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php index 30456cc9d6..7049228904 100644 --- a/tests/functional/TransactionControllerCest.php +++ b/tests/functional/TransactionControllerCest.php @@ -27,19 +27,21 @@ class TransactionControllerCest $I->see('Add a new withdrawal'); } - public function delete(FunctionalTester $I) + public function deleteWithdrawal(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Rent for %')->first(); $I->wantTo('delete a transaction'); - $I->amOnPage('/transaction/delete/3'); - $I->see('Delete withdrawal "Huur Portaal for January 2014"'); + $I->amOnPage('/transaction/delete/' . $journal->id); + $I->see('Delete withdrawal "' . $journal->description . '"'); } public function destroyDeposit(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Salary for %')->first(); $I->wantTo('destroy a deposit'); - $I->amOnPage('/transaction/delete/32'); + $I->amOnPage('/transaction/delete/' . $journal->id); $I->submitForm('#destroy', []); - $I->see('Transaction "Salary" destroyed.'); + $I->see('Transaction "' . $journal->description . '" destroyed.'); } @@ -47,20 +49,21 @@ class TransactionControllerCest { $I->wantTo('destroy a transfer'); - $journal = TransactionJournal::whereDescription('Money for new PC')->first(); + $journal = TransactionJournal::where('description', 'LIKE', '%Money for big expense in%')->first(); $I->amOnPage('/transaction/delete/' . $journal->id); $I->submitForm('#destroy', []); - $I->see('Transaction "Money for new PC" destroyed.'); + $I->see('Transaction "' . $journal->description . '" destroyed.'); } public function destroyWithdrawal(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Rent for %')->first(); $I->wantTo('destroy a withdrawal'); - $I->amOnPage('/transaction/delete/3'); + $I->amOnPage('/transaction/delete/' . $journal->id); $I->submitForm('#destroy', []); - $I->see('Transaction "Huur Portaal for January 2014" destroyed.'); + $I->see('Transaction "' . $journal->description . '" destroyed.'); } @@ -95,12 +98,12 @@ class TransactionControllerCest public function show(FunctionalTester $I) { - $journal = TransactionJournal::whereDescription('Money for new PC')->first(); + $journal = TransactionJournal::where('description', 'LIKE', '%Rent for %')->first(); $I->wantTo('see a transaction'); $I->amOnPage('/transaction/show/' . $journal->id); - $I->see('Transfer "Money for new PC"'); - $I->see('1.259'); + $I->see($journal->description); + $I->see(intval($journal->getAmount())); } public function store(FunctionalTester $I) @@ -165,29 +168,33 @@ class TransactionControllerCest public function update(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Salary for %')->first(); + $I->wantTo('update a transaction'); - $I->amOnPage('/transaction/edit/3'); - $I->see('Huur Portaal for January 2014'); + $I->amOnPage('/transaction/edit/' . $journal->id); + $I->see($journal->description); $I->submitForm( '#update', [ - 'description' => 'Huur Portaal for January 2014!', + 'description' => $journal->description . '!', 'account_id' => 1, 'expense_account' => 'Portaal', 'amount' => 500, - 'date' => '2014-01-01', - 'budget_id' => 2, - 'category' => 'House', + 'date' => $journal->date->format('Y-m-d'), + 'budget_id' => is_null($journal->budgets()->first()) ? 0 : $journal->budgets()->first()->id, + 'category' => is_null($journal->categories()->first()) ? '' : $journal->categories()->first()->id, 'post_submit_action' => 'update' ] ); - $I->see('Huur Portaal for January 2014!'); + $I->see($journal->description . '!'); } public function updateAndFail(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Salary for %')->first(); + $I->wantTo('update a transaction and fail'); - $I->amOnPage('/transaction/edit/3'); - $I->see('Huur Portaal for January 2014'); + $I->amOnPage('/transaction/edit/' . $journal->id); + $I->see($journal->description); $I->submitForm( '#update', [ 'description' => '', @@ -205,22 +212,23 @@ class TransactionControllerCest public function updateAndReturn(FunctionalTester $I) { + $journal = TransactionJournal::where('description', 'LIKE', '%Salary for %')->first(); $I->wantTo('update a transaction and return to the edit screen'); - $I->amOnPage('/transaction/edit/3'); - $I->see('Huur Portaal for January 2014'); + $I->amOnPage('/transaction/edit/' . $journal->id); + $I->see($journal->description); $I->submitForm( '#update', [ - 'description' => 'Huur Portaal for January 2014!', + 'description' => $journal->description . '!', 'account_id' => 1, 'expense_account' => 'Portaal', 'amount' => 500, - 'date' => '2014-01-01', - 'budget_id' => 2, - 'category' => 'House', + 'date' => $journal->date->format('Y-m-d'), + 'budget_id' => is_null($journal->budgets()->first()) ? 0 : $journal->budgets()->first()->id, + 'category' => is_null($journal->categories()->first()) ? '' : $journal->categories()->first()->id, 'post_submit_action' => 'return_to_edit' ] ); - $I->see('Huur Portaal for January 2014!'); + $I->see($journal->description . '!'); } From 50c6109be71c3f8337543a074979095358efd63a Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 19:50:36 +0100 Subject: [PATCH 53/84] Fixed broken tests. --- .../Database/PiggyBank/PiggyBankShared.php | 5 + .../RepeatedExpenseControllerCest.php | 94 ++++++++++--------- 2 files changed, 56 insertions(+), 43 deletions(-) diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index fe012fb50c..c0e552b441 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -32,6 +32,11 @@ class PiggyBankShared */ public function destroy(Eloquent $model) { + $reminders = \Reminder::where('remindersable_id', $model->id)->get(); + /** @var \Reminder $reminder */ + foreach ($reminders as $reminder) { + $reminder->delete(); + } $model->delete(); } diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index 29b9da0f24..38069520cc 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -39,9 +39,10 @@ class RepeatedExpenseControllerCest */ public function delete(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('delete a repeated expense'); - $I->amOnPage('/repeatedexpenses/delete/4'); - $I->see('Delete "Nieuwe kleding"'); + $I->amOnPage('/repeatedexpenses/delete/' . $repeatedExpense->id); + $I->see('Delete "' . $repeatedExpense->name . '"'); } /** @@ -49,10 +50,11 @@ class RepeatedExpenseControllerCest */ public function destroy(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('destroy a repeated expense'); - $I->amOnPage('/repeatedexpenses/delete/4'); + $I->amOnPage('/repeatedexpenses/delete/' . $repeatedExpense->id); $I->submitForm('#destroy', []); - $I->dontSeeInDatabase('piggy_banks', ['id' => 5]); + $I->see('Repeated expense "' . $repeatedExpense->name . '" deleted.'); } /** @@ -60,9 +62,10 @@ class RepeatedExpenseControllerCest */ public function edit(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('edit a repeated expense'); - $I->amOnPage('/repeatedexpenses/edit/4'); - $I->see('Edit repeated expense "Nieuwe kleding"'); + $I->amOnPage('/repeatedexpenses/edit/' . $repeatedExpense->id); + $I->see('Edit repeated expense "' . $repeatedExpense->name . '"'); } @@ -71,10 +74,11 @@ class RepeatedExpenseControllerCest */ public function index(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('see all repeated expenses'); $I->amOnPage('/repeatedexpenses'); $I->see('Overview'); - $I->see('Nieuwe kleding'); + $I->see($repeatedExpense->name); } /** @@ -82,9 +86,10 @@ class RepeatedExpenseControllerCest */ public function show(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('view a repeated expense'); - $I->amOnPage('/repeatedexpenses/show/4'); - $I->see('Nieuwe kleding'); + $I->amOnPage('/repeatedexpenses/show/' . $repeatedExpense->id); + $I->see($repeatedExpense->name); } /** @@ -112,6 +117,31 @@ class RepeatedExpenseControllerCest $I->see('Piggy bank "TestRepeatedExpense" stored.'); } + /** + * @param FunctionalTester $I + */ + public function storeAndReturn(FunctionalTester $I) + { + $I->wantTo('store a repeated expense and return'); + $I->amOnPage('/repeatedexpenses/create'); + $I->submitForm( + '#store', [ + 'name' => 'TestRepeatedExpense', + 'account_id' => 1, + 'targetamount' => 1000, + 'targetdate' => Carbon::now()->format('Y-m-d'), + 'rep_length' => 'month', + 'rep_every' => 0, + 'rep_times' => 0, + 'remind_me' => 1, + 'reminder' => 'month', + 'post_submit_action' => 'create_another', + ] + ); + + $I->see('Piggy bank "TestRepeatedExpense" stored.'); + } + /** * @param FunctionalTester $I */ @@ -137,44 +167,20 @@ class RepeatedExpenseControllerCest $I->see('Could not store repeated expense: The name field is required.'); } - /** - * @param FunctionalTester $I - */ - public function storeAndReturn(FunctionalTester $I) - { - $I->wantTo('store a repeated expense and return'); - $I->amOnPage('/repeatedexpenses/create'); - $I->submitForm( - '#store', [ - 'name' => 'TestRepeatedExpense', - 'account_id' => 1, - 'targetamount' => 1000, - 'targetdate' => Carbon::now()->format('Y-m-d'), - 'rep_length' => 'month', - 'rep_every' => 0, - 'rep_times' => 0, - 'remind_me' => 1, - 'reminder' => 'month', - 'post_submit_action' => 'create_another', - ] - ); - - $I->see('Piggy bank "TestRepeatedExpense" stored.'); - } - /** * @param FunctionalTester $I */ public function update(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('update a repeated expense'); - $I->amOnPage('/repeatedexpenses/edit/4'); + $I->amOnPage('/repeatedexpenses/edit/' . $repeatedExpense->id); $I->submitForm( '#update', [ - 'name' => 'Nieuwe kleding!', + 'name' => $repeatedExpense->name . '!', 'account_id' => 2, 'targetamount' => 1000.00, - 'targetdate' => '2014-12-30', + 'targetdate' => $repeatedExpense->targetdate->format('Y-m-d'), 'rep_length' => 'month', 'rep_every' => 0, 'rep_times' => 0, @@ -183,7 +189,7 @@ class RepeatedExpenseControllerCest 'post_submit_action' => 'update', ] ); - $I->see('Repeated expense "Nieuwe kleding!" updated.'); + $I->see('Repeated expense "' . $repeatedExpense->name . '!" updated.'); } /** @@ -191,14 +197,15 @@ class RepeatedExpenseControllerCest */ public function updateAndReturnToEdit(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('update a repeated expense and return to edit screen'); - $I->amOnPage('/repeatedexpenses/edit/4'); + $I->amOnPage('/repeatedexpenses/edit/' . $repeatedExpense->id); $I->submitForm( '#update', [ - 'name' => 'Nieuwe kleding!', + 'name' => $repeatedExpense->name . '!', 'account_id' => 2, 'targetamount' => 1000.00, - 'targetdate' => '2014-12-30', + 'targetdate' => $repeatedExpense->targetdate->format('Y-m-d'), 'rep_length' => 'month', 'rep_every' => 0, 'rep_times' => 0, @@ -207,7 +214,7 @@ class RepeatedExpenseControllerCest 'post_submit_action' => 'return_to_edit', ] ); - $I->see('Repeated expense "Nieuwe kleding!" updated.'); + $I->see('Repeated expense "' . $repeatedExpense->name . '!" updated.'); } /** @@ -215,8 +222,9 @@ class RepeatedExpenseControllerCest */ public function updateFail(FunctionalTester $I) { + $repeatedExpense = PiggyBank::where('repeats', 1)->first(); $I->wantTo('try to update a repeated expense and fail'); - $I->amOnPage('/repeatedexpenses/edit/4'); + $I->amOnPage('/repeatedexpenses/edit/' . $repeatedExpense->id); $I->submitForm( '#update', [ 'name' => '', From 8c439a2852eaf965ae9f8f3fdce37bfd84dfbc77 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 20:02:02 +0100 Subject: [PATCH 54/84] Added debug information [skip ci] --- app/lib/FireflyIII/Report/Report.php | 1 + 1 file changed, 1 insertion(+) diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 6bf0f7ed43..e12567a9a1 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -112,6 +112,7 @@ class Report implements ReportInterface $start->startOfMonth()->subDay(); $end = clone $date; $end->endOfMonth(); + \Log::debug('Monthly report account dates: start:[' . $start->format('Y-m-d') . '] and end:[' . $end->format('Y-m-d') . ']'); $list = $this->_queries->accountList(); $accounts = []; /** @var \Account $account */ From 98c1fcc68fb4dc519bf841ebedabbe7d26215682 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 20:53:36 +0100 Subject: [PATCH 55/84] New content and tests ensure the coverage of all code. --- app/controllers/GoogleChartController.php | 158 +++++++++--------- app/database/seeds/TestContentSeeder.php | 22 ++- .../functional/GoogleChartControllerCest.php | 6 +- 3 files changed, 100 insertions(+), 86 deletions(-) diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index d9760aab5c..eb6bfab8e8 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -132,18 +132,18 @@ class GoogleChartController extends BaseController /** @var Budget $budget */ foreach ($budgets as $budget) { - Log::debug('Now working budget #'.$budget->id.', '.$budget->name); + Log::debug('Now working budget #' . $budget->id . ', ' . $budget->name); /** @var \LimitRepetition $repetition */ $repetition = $bdt->repetitionOnStartingOnDate($budget, $this->_start); if (is_null($repetition)) { - \Log::debug('Budget #'.$budget->id.' has no repetition on ' . $this->_start->format('Y-m-d')); + \Log::debug('Budget #' . $budget->id . ' has no repetition on ' . $this->_start->format('Y-m-d')); // use the session start and end for our search query $searchStart = $this->_start; $searchEnd = $this->_end; $limit = 0; // the limit is zero: } else { - \Log::debug('Budget #'.$budget->id.' has a repetition on ' . $this->_start->format('Y-m-d').'!'); + \Log::debug('Budget #' . $budget->id . ' has a repetition on ' . $this->_start->format('Y-m-d') . '!'); // use the limit's start and end for our search query $searchStart = $repetition->startdate; $searchEnd = $repetition->enddate; @@ -151,6 +151,7 @@ class GoogleChartController extends BaseController } $expenses = floatval($budget->transactionjournals()->before($searchEnd)->after($searchStart)->lessThan(0)->sum('amount')) * -1; + \Log::debug('Expenses in budget ' . $budget->name . ' before ' . $searchEnd->format('Y-m-d') . ' and after ' . $searchStart . ' are: ' . $expenses); if ($expenses > 0) { $this->_chart->addRow($budget->name, $limit, $expenses); } @@ -186,6 +187,76 @@ class GoogleChartController extends BaseController } + /** + * @param Bill $bill + * + * @return \Illuminate\Http\JsonResponse + */ + public function billOverview(Bill $bill) + { + + $this->_chart->addColumn('Date', 'date'); + $this->_chart->addColumn('Max amount', 'number'); + $this->_chart->addColumn('Min amount', 'number'); + $this->_chart->addColumn('Current entry', 'number'); + + // get first transaction or today for start: + $first = $bill->transactionjournals()->orderBy('date', 'ASC')->first(); + if ($first) { + $start = $first->date; + } else { + $start = new Carbon; + } + $end = new Carbon; + while ($start <= $end) { + $result = $bill->transactionjournals()->before($end)->after($start)->first(); + if ($result) { + $amount = $result->getAmount(); + } else { + $amount = 0; + } + unset($result); + $this->_chart->addRow(clone $start, $bill->amount_max, $bill->amount_min, $amount); + $start = DateKit::addPeriod($start, $bill->repeat_freq, 0); + } + + $this->_chart->generate(); + + return Response::json($this->_chart->getData()); + + } + + /** + * TODO query move to helper. + * + * @return \Illuminate\Http\JsonResponse + * @throws \FireflyIII\Exception\FireflyException + */ + public function billsOverview() + { + $paid = ['items' => [], 'amount' => 0]; + $unpaid = ['items' => [], 'amount' => 0]; + $this->_chart->addColumn('Name', 'string'); + $this->_chart->addColumn('Amount', 'number'); + + $set = $this->_repository->getBillsSummary($this->_start, $this->_end); + + foreach ($set as $entry) { + if (intval($entry->journalId) == 0) { + $unpaid['items'][] = $entry->name; + $unpaid['amount'] += floatval($entry->averageAmount); + } else { + $paid['items'][] = $entry->description; + $paid['amount'] += floatval($entry->actualAmount); + } + } + $this->_chart->addRow('Unpaid: ' . join(', ', $unpaid['items']), $unpaid['amount']); + $this->_chart->addRow('Paid: ' . join(', ', $paid['items']), $paid['amount']); + $this->_chart->generate(); + + return Response::json($this->_chart->getData()); + } + /** * TODO still in use? * @@ -223,12 +294,12 @@ class GoogleChartController extends BaseController /** * TODO still in use? * - * @param Budget $component + * @param Budget $budget * @param $year * * @return \Illuminate\Http\JsonResponse */ - public function budgetsAndSpending(Budget $component, $year) + public function budgetsAndSpending(Budget $budget, $year) { try { new Carbon('01-01-' . $year); @@ -247,11 +318,14 @@ class GoogleChartController extends BaseController $end = clone $start; $end->endOfYear(); while ($start <= $end) { - $spent = $budgetRepository->spentInMonth($component, $start); - $repetition = $budgetRepository->repetitionOnStartingOnDate($component, $start); + $spent = $budgetRepository->spentInMonth($budget, $start); + $repetition = $budgetRepository->repetitionOnStartingOnDate($budget, $start); + if ($repetition) { $budgeted = floatval($repetition->amount); + \Log::debug('Found a repetition on ' . $start->format('Y-m-d'). ' for budget ' . $budget->name.'!'); } else { + \Log::debug('No repetition on ' . $start->format('Y-m-d'). ' for budget ' . $budget->name); $budgeted = null; } @@ -334,76 +408,6 @@ class GoogleChartController extends BaseController } - /** - * @param Bill $bill - * - * @return \Illuminate\Http\JsonResponse - */ - public function billOverview(Bill $bill) - { - - $this->_chart->addColumn('Date', 'date'); - $this->_chart->addColumn('Max amount', 'number'); - $this->_chart->addColumn('Min amount', 'number'); - $this->_chart->addColumn('Current entry', 'number'); - - // get first transaction or today for start: - $first = $bill->transactionjournals()->orderBy('date', 'ASC')->first(); - if ($first) { - $start = $first->date; - } else { - $start = new Carbon; - } - $end = new Carbon; - while ($start <= $end) { - $result = $bill->transactionjournals()->before($end)->after($start)->first(); - if ($result) { - $amount = $result->getAmount(); - } else { - $amount = 0; - } - unset($result); - $this->_chart->addRow(clone $start, $bill->amount_max, $bill->amount_min, $amount); - $start = DateKit::addPeriod($start, $bill->repeat_freq, 0); - } - - $this->_chart->generate(); - - return Response::json($this->_chart->getData()); - - } - - /** - * TODO query move to helper. - * - * @return \Illuminate\Http\JsonResponse - * @throws \FireflyIII\Exception\FireflyException - */ - public function billsOverview() - { - $paid = ['items' => [], 'amount' => 0]; - $unpaid = ['items' => [], 'amount' => 0]; - $this->_chart->addColumn('Name', 'string'); - $this->_chart->addColumn('Amount', 'number'); - - $set = $this->_repository->getBillsSummary($this->_start, $this->_end); - - foreach ($set as $entry) { - if (intval($entry->journalId) == 0) { - $unpaid['items'][] = $entry->name; - $unpaid['amount'] += floatval($entry->averageAmount); - } else { - $paid['items'][] = $entry->description; - $paid['amount'] += floatval($entry->actualAmount); - } - } - $this->_chart->addRow('Unpaid: ' . join(', ', $unpaid['items']), $unpaid['amount']); - $this->_chart->addRow('Paid: ' . join(', ', $paid['items']), $paid['amount']); - $this->_chart->generate(); - - return Response::json($this->_chart->getData()); - } - /** * TODO see reports for better way to do this. * diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 3f5468e7ec..8520a98043 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -109,18 +109,24 @@ class TestContentSeeder extends Seeder $euro = TransactionCurrency::whereCode('EUR')->first(); + $rentBill = Bill::where('name', 'Rent')->first(); + $current = clone $this->_yearAgoStartOfMonth; - while ($current < $this->_startOfMonth) { + while ($current <= $this->_startOfMonth) { $cur = $current->format('Y-m-d'); $formatted = $current->format('F Y'); // create expenses for rent, utilities, TV, phone on the 1st of the month. - $this->createTransaction($checking, $landLord, 800, $withdrawal, 'Rent for ' . $formatted, $cur, $euro, $bills, $house); + $this->createTransaction($checking, $landLord, 800, $withdrawal, 'Rent for ' . $formatted, $cur, $euro, $bills, $house, $rentBill); $this->createTransaction($checking, $utilities, 150, $withdrawal, 'Utilities for ' . $formatted, $cur, $euro, $bills, $house); $this->createTransaction($checking, $television, 50, $withdrawal, 'TV for ' . $formatted, $cur, $euro, $bills, $house); $this->createTransaction($checking, $phone, 50, $withdrawal, 'Phone bill for ' . $formatted, $cur, $euro, $bills, $house); + // two transactions. One without a budget, one without a category. + $this->createTransaction($checking, $phone, 10, $withdrawal, 'Extra charges on phone bill for ' . $formatted, $cur, $euro, null, $house); + $this->createTransaction($checking, $television, 5, $withdrawal, 'Extra charges on TV bill for ' . $formatted, $cur, $euro, $bills, null); + // income from job: $this->createTransaction($employer, $checking, rand(3500, 4000), $deposit, 'Salary for ' . $formatted, $cur, $euro); $this->createTransaction($checking, $savings, 2000, $transfer, 'Salary to savings account in ' . $formatted, $cur, $euro); @@ -225,9 +231,10 @@ class TestContentSeeder extends Seeder public function createBudgets(User $user) { - $groceries = Budget::create(['user_id' => $user->id, 'name' => 'Groceries']); - $bills = Budget::create(['user_id' => $user->id, 'name' => 'Bills']); - $deleteMe = Budget::create(['user_id' => $user->id, 'name' => 'Delete me']); + $groceries = Budget::create(['user_id' => $user->id, 'name' => 'Groceries']); + $bills = Budget::create(['user_id' => $user->id, 'name' => 'Bills']); + $deleteMe = Budget::create(['user_id' => $user->id, 'name' => 'Delete me']); + Budget::create(['user_id' => $user->id, 'name' => 'Budget without repetition']); $groceriesLimit = BudgetLimit::create( ['startdate' => $this->som, 'amount' => 201, 'repeats' => 0, 'repeat_freq' => 'monthly', 'budget_id' => $groceries->id] ); @@ -405,8 +412,9 @@ class TestContentSeeder extends Seeder // bill Bill::create( [ - 'user_id' => $user->id, 'name' => 'Huur', 'match' => 'huur,portaal', 'amount_min' => 500, - 'amount_max' => 700, + 'user_id' => $user->id, 'name' => 'Rent', 'match' => 'rent,landlord', + 'amount_min' => 700, + 'amount_max' => 900, 'date' => $this->som, 'active' => 1, 'automatch' => 1, diff --git a/tests/functional/GoogleChartControllerCest.php b/tests/functional/GoogleChartControllerCest.php index b0697dcc42..274da2e0de 100644 --- a/tests/functional/GoogleChartControllerCest.php +++ b/tests/functional/GoogleChartControllerCest.php @@ -108,8 +108,9 @@ class GoogleChartControllerCest */ public function budgetsAndSpending(FunctionalTester $I) { + $year = date('Y'); $I->wantTo('see the chart for a budget in a specific year'); - $I->amOnPage('/chart/budget/1/spending/2014'); + $I->amOnPage('/chart/budget/1/spending/'.$year); $I->seeResponseCodeIs(200); } @@ -129,8 +130,9 @@ class GoogleChartControllerCest */ public function categoriesAndSpending(FunctionalTester $I) { + $year = date('Y'); $I->wantTo('see the chart for a category in a specific year'); - $I->amOnPage('/chart/category/1/spending/2014'); + $I->amOnPage('/chart/category/1/spending/'.$year); $I->seeResponseCodeIs(200); } From cb8e082414f61d7ae874ab84525b59ed06ac05a7 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:06:24 +0100 Subject: [PATCH 56/84] Fixed the bill tests. --- tests/functional/BillControllerCest.php | 37 +++++++++++++++++-------- 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/tests/functional/BillControllerCest.php b/tests/functional/BillControllerCest.php index 88a8b571b9..05f9c270a5 100644 --- a/tests/functional/BillControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -38,9 +38,10 @@ class BillControllerCest */ public function delete(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('delete a bill'); - $I->amOnPage('/bills/delete/1'); - $I->see('Delete "Huur"'); + $I->amOnPage('/bills/delete/' . $bill->id); + $I->see('Delete "' . $bill->name . '"'); } /** @@ -48,9 +49,10 @@ class BillControllerCest */ public function destroy(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('destroy a bill'); - $I->amOnPage('/bills/delete/1'); - $I->see('Delete "Huur"'); + $I->amOnPage('/bills/delete/' . $bill->id); + $I->see('Delete "' . $bill->name . '"'); $I->submitForm('#destroy', []); $I->see('The bill was deleted.'); @@ -61,8 +63,10 @@ class BillControllerCest */ public function edit(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('edit a bill'); - $I->amOnPage('/bills/edit/1'); + $I->amOnPage('/bills/edit/' . $bill->id); + $I->see($bill->name); } @@ -72,8 +76,11 @@ class BillControllerCest */ public function index(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('see all bills'); $I->amOnPage('/bills'); + $I->see('Bills'); + $I->see($bill->name); } /** @@ -81,8 +88,9 @@ class BillControllerCest */ public function rescan(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('rescan a bill'); - $I->amOnPage('/bills/rescan/1'); + $I->amOnPage('/bills/rescan/' . $bill->id); $I->see('Rescanned everything.'); } @@ -91,8 +99,9 @@ class BillControllerCest */ public function rescanInactive(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->where('active', 0)->first(); $I->wantTo('rescan an inactive bill'); - $I->amOnPage('/bills/rescan/3'); + $I->amOnPage('/bills/rescan/' . $bill->id); $I->see('Inactive bills cannot be scanned.'); } @@ -101,9 +110,10 @@ class BillControllerCest */ public function show(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('show a bill'); - $I->amOnPage('/bills/show/1'); - $I->see('Huur'); + $I->amOnPage('/bills/show/' . $bill->id); + $I->see($bill->name); } /** @@ -201,8 +211,9 @@ class BillControllerCest */ public function update(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('update a bill'); - $I->amOnPage('/bills/edit/1'); + $I->amOnPage('/bills/edit/' . $bill->id); $I->submitForm( '#update', [ 'name' => 'Some bill', @@ -222,8 +233,9 @@ class BillControllerCest */ public function updateFail(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('update a bill and fail'); - $I->amOnPage('/bills/edit/1'); + $I->amOnPage('/bills/edit/' . $bill->id); $I->submitForm( '#update', [ 'name' => 'Some bill', @@ -243,8 +255,9 @@ class BillControllerCest */ public function updateReturn(FunctionalTester $I) { + $bill = User::whereEmail('thegrumpydictator@gmail.com')->first()->bills()->first(); $I->wantTo('update a bill and return to edit it'); - $I->amOnPage('/bills/edit/1'); + $I->amOnPage('/bills/edit/' . $bill->id); $I->submitForm( '#update', [ 'name' => 'Some bill', From 823afe877b3ccace65314145a5f0a6d0af60b855 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:20:41 +0100 Subject: [PATCH 57/84] First attempt to make the year charts and month reports report the same thing [skip ci] --- app/controllers/GoogleChartController.php | 2 -- .../TransactionJournal/TransactionJournal.php | 20 +++++++++---------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index eb6bfab8e8..88c405d9ed 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -47,7 +47,6 @@ class GoogleChartController extends BaseController $this->_chart->addColumn('Day of month', 'date'); $this->_chart->addColumn('Balance for ' . $account->name, 'number'); - // TODO this can be combined in some method, it's coming up quite often, is it? $start = $this->_start; $end = $this->_end; $count = $account->transactions()->count(); @@ -62,7 +61,6 @@ class GoogleChartController extends BaseController $start = new Carbon($first->date); $end = new Carbon($last->date); } - // todo until this part. $current = clone $start; diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index ab476a09b6..0d76c4e984 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -468,24 +468,24 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData } /** + * TODO This query includes incomes to "shared" accounts which arent income. + * * @param Carbon $date * * @return float */ public function getSumOfIncomesByMonth(Carbon $date) { - $end = clone $date; - $date->startOfMonth(); - $end->endOfMonth(); + /** @var \FireflyIII\Report\ReportInterface $reportRepository */ + $reportRepository = \App::make('FireflyIII\Report\ReportInterface'); - $sum = \DB::table('transactions')->leftJoin('transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id')->leftJoin( - 'transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id' - )->where('amount', '>', 0)->where('transaction_types.type', '=', 'Deposit')->where('transaction_journals.date', '>=', $date->format('Y-m-d'))->where( - 'transaction_journals.date', '<=', $end->format('Y-m-d') - )->sum('transactions.amount'); - $sum = floatval($sum); + $incomes = $reportRepository->getIncomeForMonth($date); + $totalIn = 0; + foreach ($incomes as $entry) { + $totalIn += floatval($entry->transactions[1]->amount); + } - return $sum; + return $totalIn; } /** From b4bdb48f1eba771b9aa12112b5c3632178178d8b Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:23:12 +0100 Subject: [PATCH 58/84] First attempt to make the year charts and month reports report the same thing [skip ci] --- .../Database/TransactionJournal/TransactionJournal.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 0d76c4e984..749d467643 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -481,8 +481,9 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData $incomes = $reportRepository->getIncomeForMonth($date); $totalIn = 0; + /** @var \TransactionJournal $entry */ foreach ($incomes as $entry) { - $totalIn += floatval($entry->transactions[1]->amount); + $totalIn += $entry->getAmount(); } return $totalIn; From 6c3262e176f514a39f44865eff5de4312fbc4b1e Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:26:40 +0100 Subject: [PATCH 59/84] First attempt to make the year charts and month reports report the same thing [skip ci] --- .../TransactionJournal/TransactionJournal.php | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 749d467643..99741a017f 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -453,16 +453,15 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData */ public function getSumOfExpensesByMonth(Carbon $date) { - $end = clone $date; - $date->startOfMonth(); - $end->endOfMonth(); + /** @var \FireflyIII\Report\ReportInterface $reportRepository */ + $reportRepository = \App::make('FireflyIII\Report\ReportInterface'); - $sum = \DB::table('transactions')->leftJoin('transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id')->leftJoin( - 'transaction_types', 'transaction_journals.transaction_type_id', '=', 'transaction_types.id' - )->where('amount', '>', 0)->where('transaction_types.type', '=', 'Withdrawal')->where('transaction_journals.date', '>=', $date->format('Y-m-d'))->where( - 'transaction_journals.date', '<=', $end->format('Y-m-d') - )->sum('transactions.amount'); - $sum = floatval($sum); + $set = $reportRepository->getExpenseGroupedForMonth($date, 200); + $sum = 0; + foreach ($set as $entry) { + $sum += $entry['amount']; + } + return $sum; } From 1a1f89f555b6181b223cc5bcd32684656da5e60b Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:27:51 +0100 Subject: [PATCH 60/84] First attempt to make the year charts and month reports report the same thing [skip ci] --- .../Database/TransactionJournal/TransactionJournal.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 99741a017f..5637cf7856 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -461,14 +461,12 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData foreach ($set as $entry) { $sum += $entry['amount']; } - + return $sum; } /** - * TODO This query includes incomes to "shared" accounts which arent income. - * * @param Carbon $date * * @return float From ac6f98fc47a0bd929429669120911d310619bc68 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 21:35:05 +0100 Subject: [PATCH 61/84] First attempt to make the year charts and month reports report the same thing [skip ci] --- app/views/reports/year.blade.php | 41 +++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/app/views/reports/year.blade.php b/app/views/reports/year.blade.php index db918e2718..e7fc7c5d7a 100644 --- a/app/views/reports/year.blade.php +++ b/app/views/reports/year.blade.php @@ -30,7 +30,7 @@
    Account balance
    - +
    + +
    +
    + Income vs. expense +
    + sum); + } + foreach($groupedExpenses as $exp) { + $expenseSum += floatval($exp['amount']); + } + $incomeSum = floatval($incomeSum*-1); + + ?> + + + + + + + + + + + + + + +
    In{{mf($incomeSum)}}
    Out{{mf($expenseSum*-1)}}
    Difference{{mf($incomeSum - $expenseSum)}}
    +
    @@ -69,12 +102,18 @@ Income
    + @foreach($groupedIncomes as $income) + sum)*-1;?> @endforeach + + + +
    {{{$income->name}}} {{mf(floatval($income->sum)*-1)}}
    Sum{{mf($sum)}}
    From fa1695672a6e5ca15c230bae2ac1aa738277b06c Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 22:32:25 +0100 Subject: [PATCH 62/84] Cleaning up. --- app/database/seeds/TestContentSeeder.php | 3 +++ app/lib/FireflyIII/Database/Account/Account.php | 1 + .../Database/TransactionJournal/TransactionJournal.php | 1 + app/lib/FireflyIII/Database/User/User.php | 2 +- app/lib/FireflyIII/Report/Report.php | 1 + app/lib/FireflyIII/Report/ReportQuery.php | 1 + 6 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 8520a98043..16773fd33a 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -526,6 +526,9 @@ class TestContentSeeder extends Seeder } } + /** + * @param $date + */ public function createBigExpense($date) { $date->addDays(12); diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index e4facd4374..f0a2e058e3 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -361,6 +361,7 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface $model->save(); if (isset($data['openingbalance']) && isset($data['openingbalancedate']) && strlen($data['openingbalancedate']) > 0) { + /** @noinspection PhpParamsInspection */ $openingBalance = $this->openingBalanceTransaction($model); // TODO this needs cleaning up and thinking over. if (is_null($openingBalance)) { diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 5637cf7856..406c5d075f 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -106,6 +106,7 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData list($fromAccount, $toAccount) = $this->storeAccounts($data); + /** @noinspection PhpParamsInspection */ $this->storeBudget($data, $model); $this->storeCategory($data, $model); diff --git a/app/lib/FireflyIII/Database/User/User.php b/app/lib/FireflyIII/Database/User/User.php index 698eb6033b..0c8888d758 100644 --- a/app/lib/FireflyIII/Database/User/User.php +++ b/app/lib/FireflyIII/Database/User/User.php @@ -14,7 +14,7 @@ class User /** * @param $mail * - * @return null|User + * @return null|\User */ public function findByEmail($mail) { diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index e12567a9a1..d96a676900 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -118,6 +118,7 @@ class Report implements ReportInterface /** @var \Account $account */ foreach ($list as $account) { $id = intval($account->id); + /** @noinspection PhpParamsInspection */ $accounts[$id] = [ 'name' => $account->name, 'startBalance' => \Steam::balance($account, $start), diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 355568bd1a..e2ccc51ed7 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -139,6 +139,7 @@ class ReportQuery implements ReportQueryInterface ->get(['accounts.*']); $set->each( function (\Account $account) use ($start, $end) { + /** @noinspection PhpParamsInspection */ $account->startBalance = \Steam::balance($account, $start); $account->endBalance = \Steam::balance($account, $end); } From 05ea8216ff67dc90d3b18c4014b7305d814a2fa0 Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 22:51:38 +0100 Subject: [PATCH 63/84] Fixed transaction coverage. --- app/tests/factories/Transaction.php | 4 +++- composer.json | 4 +++- composer.lock | 2 +- tests/unit/TransactionTest.php | 7 +++---- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/app/tests/factories/Transaction.php b/app/tests/factories/Transaction.php index 42b056a423..9f812b8ce0 100644 --- a/app/tests/factories/Transaction.php +++ b/app/tests/factories/Transaction.php @@ -5,6 +5,8 @@ League\FactoryMuffin\Facade::define( 'account_id' => 'factory|Account', 'transaction_journal_id' => 'factory|TransactionJournal', 'description' => 'sentence', - 'amount' => 'numberBetween:1,100', + 'amount' => function() { + return round(rand(100,10000) / 100,2); + } ] ); diff --git a/composer.json b/composer.json index a1d3a88366..7081b40e81 100644 --- a/composer.json +++ b/composer.json @@ -40,7 +40,9 @@ "sebastian/phpdcd": "*", "codeception/phpbuiltinserver": "*", "codeception/specify": "*", - "codeception/verify": "*" + "codeception/verify": "*", + "fzaninotto/faker": "1.*" + }, "autoload": { diff --git a/composer.lock b/composer.lock index 084857beb1..e419de84ae 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", "This file is @generated automatically" ], - "hash": "66a93b738537ed20455648f477585c88", + "hash": "3ac71ef711586f9c2bf7c36482284a13", "packages": [ { "name": "classpreloader/classpreloader", diff --git a/tests/unit/TransactionTest.php b/tests/unit/TransactionTest.php index 3d89e735c5..b571dccbb2 100644 --- a/tests/unit/TransactionTest.php +++ b/tests/unit/TransactionTest.php @@ -46,16 +46,15 @@ class TransactionTest extends TestCase { $transaction = f::create('Transaction'); $amount = floatval($transaction->amount); - $amount--; - $this->assertCount(1, Transaction::moreThan($amount)->get()); + $amount++; + $this->assertCount(1, Transaction::lessThan($amount)->get()); } public function testMoreThan() { $transaction = f::create('Transaction'); $amount = floatval($transaction->amount); - $amount++; - + $amount--; $this->assertCount(1, Transaction::moreThan($amount)->get()); } From ba9968bde0a392184ce31ce4c785d92f538e4a5f Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 22:53:03 +0100 Subject: [PATCH 64/84] Fixed a bug in "number between" tests. --- app/tests/factories/PiggyBank.php | 16 +++++++++++----- app/tests/factories/PiggyBankRepetition.php | 4 +++- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/app/tests/factories/PiggyBank.php b/app/tests/factories/PiggyBank.php index 18a18fc984..36f89debf8 100644 --- a/app/tests/factories/PiggyBank.php +++ b/app/tests/factories/PiggyBank.php @@ -4,7 +4,9 @@ League\FactoryMuffin\Facade::define( 'PiggyBank', [ 'account_id' => 'factory|Account', 'name' => 'word', - 'targetamount' => 'numberBetween|10;400', + 'targetamount' => function () { + return rand(1, 400); + }, 'startdate' => 'date|Y-m-d', 'targetdate' => 'date|Y-m-d', 'repeats' => 'boolean', @@ -13,16 +15,20 @@ League\FactoryMuffin\Facade::define( return $set[rand(0, count($set) - 1)]; }, - 'rep_every' => 'numberBetween:0,3', - 'rep_times' => 'numberBetween:0,3', + 'rep_every' => function() {return rand(0,3);}, + 'rep_times' => function() {return rand(0,3);}, 'reminder' => function () { $set = ['day', 'week', 'quarter', 'month', 'year']; return $set[rand(0, count($set) - 1)]; }, - 'reminder_skip' => 'numberBetween:0,3', + 'reminder_skip' => function () { + return rand(0, 3); + }, 'remind_me' => 'boolean', - 'order' => 'numberBetween:0,10', + 'order' => function () { + return rand(0, 10); + }, ] ); diff --git a/app/tests/factories/PiggyBankRepetition.php b/app/tests/factories/PiggyBankRepetition.php index dd1bbbaf76..a266af2283 100644 --- a/app/tests/factories/PiggyBankRepetition.php +++ b/app/tests/factories/PiggyBankRepetition.php @@ -5,7 +5,9 @@ League\FactoryMuffin\Facade::define( 'piggy_bank_id' => 'factory|PiggyBank', 'startdate' => 'date|Y-m-d', 'targetdate' => 'date|Y-m-d', - 'currentamount' => 'numberBetween:0,100', + 'currentamount' => function () { + return rand(0, 100); + }, ] ); From f27919f91b8766d3f5f64f5744735bfbaf4bf77a Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 22:57:15 +0100 Subject: [PATCH 65/84] Fixed transaction journal test. --- tests/unit/TransactionJournalTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/TransactionJournalTest.php b/tests/unit/TransactionJournalTest.php index 8b9e11946f..c6f4f42c19 100644 --- a/tests/unit/TransactionJournalTest.php +++ b/tests/unit/TransactionJournalTest.php @@ -26,7 +26,7 @@ class TransactionJournalTest extends TestCase $journal->transactions()->save($other); $amount = floatval($transaction->amount); - $amount++; + $amount--; $this->assertCount(1, TransactionJournal::moreThan($amount)->get()); } From e44de572f5245ada71f008b4b83a35ca5343b9fb Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Jan 2015 23:12:12 +0100 Subject: [PATCH 66/84] Code cleanup [skip ci] --- app/controllers/AccountController.php | 18 +++++++++--------- app/controllers/BillController.php | 6 +++--- app/controllers/CategoryController.php | 4 ++-- app/controllers/TransactionController.php | 8 ++++---- .../FireflyIII/Database/Account/Account.php | 8 ++++---- app/lib/FireflyIII/Event/Piggybank.php | 4 ++-- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/app/controllers/AccountController.php b/app/controllers/AccountController.php index 74fbe299ca..7ca74d1cf3 100644 --- a/app/controllers/AccountController.php +++ b/app/controllers/AccountController.php @@ -70,7 +70,7 @@ class AccountController extends BaseController public function create($what) { $subTitleIcon = $this->_subIconsByIdentifier[$what]; - $subTitle = 'Create a new ' . $what . ' account'; + $subTitle = 'Create a new ' . e($what) . ' account'; return View::make('accounts.create', compact('subTitleIcon', 'what', 'subTitle')); } @@ -82,7 +82,7 @@ class AccountController extends BaseController */ public function delete(Account $account) { - $subTitle = 'Delete ' . strtolower($account->accountType->type) . ' "' . $account->name . '"'; + $subTitle = 'Delete ' . strtolower(e($account->accountType->type)) . ' "' . e($account->name) . '"'; return View::make('accounts.delete', compact('account', 'subTitle')); } @@ -101,7 +101,7 @@ class AccountController extends BaseController $this->_repository->destroy($account); - Session::flash('success', 'The ' . $typeName . ' account "' . e($name) . '" was deleted.'); + Session::flash('success', 'The ' . e($typeName) . ' account "' . e($name) . '" was deleted.'); return Redirect::route('accounts.index', $typeName); } @@ -116,7 +116,7 @@ class AccountController extends BaseController $openingBalance = $this->_repository->openingBalanceTransaction($account); $subTitleIcon = $this->_subIconsByIdentifier[$account->accountType->type]; - $subTitle = 'Edit ' . strtolower($account->accountType->type) . ' "' . $account->name . '"'; + $subTitle = 'Edit ' . strtolower(e($account->accountType->type)) . ' "' . e($account->name) . '"'; // pre fill some useful values. $preFilled = [ @@ -157,7 +157,7 @@ class AccountController extends BaseController $subTitleIcon = $this->_subIconsByIdentifier[$account->accountType->type]; $what = $this->_shortNamesByFullName[$account->accountType->type]; $journals = $this->_repository->getTransactionJournals($account, 50, $range); - $subTitle = 'Details for ' . strtolower($account->accountType->type) . ' "' . $account->name . '"'; + $subTitle = 'Details for ' . strtolower(e($account->accountType->type)) . ' "' . e($account->name) . '"'; return View::make('accounts.show', compact('account', 'what', 'range', 'subTitleIcon', 'journals', 'subTitle')); } @@ -184,17 +184,17 @@ class AccountController extends BaseController // return to create screen: if ($data['post_submit_action'] == 'validate_only' || $messages['errors']->count() > 0) { - return Redirect::route('accounts.create', $data['what'])->withInput(); + return Redirect::route('accounts.create', e($data['what']))->withInput(); } // store: $this->_repository->store($data); Session::flash('success', 'Account "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { - return Redirect::route('accounts.index', $data['what']); + return Redirect::route('accounts.index', e($data['what'])); } - return Redirect::route('accounts.create', $data['what'])->withInput(); + return Redirect::route('accounts.create', e($data['what']))->withInput(); } /** @@ -231,7 +231,7 @@ class AccountController extends BaseController // go back to list if ($data['post_submit_action'] == 'update') { - return Redirect::route('accounts.index', $data['what']); + return Redirect::route('accounts.index', e($data['what'])); } // go back to update screen. diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index de7e0f3545..2b10e6d242 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -45,7 +45,7 @@ class BillController extends BaseController public function delete(Bill $bill) { return View::make('bills.delete')->with('bill', $bill)->with( - 'subTitle', 'Delete "' . $bill->name . '"' + 'subTitle', 'Delete "' . e($bill->name) . '"' ); } @@ -73,7 +73,7 @@ class BillController extends BaseController $periods = \Config::get('firefly.periods_to_text'); return View::make('bills.edit')->with('periods', $periods)->with('bill', $bill)->with( - 'subTitle', 'Edit "' . $bill->name . '"' + 'subTitle', 'Edit "' . e($bill->name) . '"' ); } @@ -119,7 +119,7 @@ class BillController extends BaseController return View::make('bills.show', compact('journals', 'hideBill', 'bill'))->with( - 'subTitle', $bill->name + 'subTitle', e($bill->name) ); } diff --git a/app/controllers/CategoryController.php b/app/controllers/CategoryController.php index b6d6da5df8..a067224a36 100644 --- a/app/controllers/CategoryController.php +++ b/app/controllers/CategoryController.php @@ -41,7 +41,7 @@ class CategoryController extends BaseController */ public function delete(Category $category) { - return View::make('categories.delete')->with('category', $category)->with('subTitle', 'Delete category "' . $category->name . '"'); + return View::make('categories.delete')->with('category', $category)->with('subTitle', 'Delete category "' . e($category->name) . '"'); } /** @@ -65,7 +65,7 @@ class CategoryController extends BaseController */ public function edit(Category $category) { - return View::make('categories.edit')->with('category', $category)->with('subTitle', 'Edit category "' . $category->name . '"'); + return View::make('categories.edit')->with('category', $category)->with('subTitle', 'Edit category "' . e($category->name) . '"'); } /** diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index dc0648ba89..a7f00e3900 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -98,7 +98,7 @@ class TransactionController extends BaseController $piggies[0] = '(no piggy bank)'; $preFilled = Session::has('preFilled') ? Session::get('preFilled') : []; $respondTo = ['account_id', 'account_from_id']; - $subTitle = 'Add a new ' . $what; + $subTitle = 'Add a new ' . e($what); foreach ($respondTo as $r) { if (!is_null(Input::get($r))) { @@ -123,7 +123,7 @@ class TransactionController extends BaseController public function delete(TransactionJournal $journal) { $type = strtolower($journal->transactionType->type); - $subTitle = 'Delete ' . $type . ' "' . $journal->description . '"'; + $subTitle = 'Delete ' . e($type) . ' "' . e($journal->description) . '"'; return View::make('transactions.delete', compact('journal', 'subTitle')); @@ -197,7 +197,7 @@ class TransactionController extends BaseController public function edit(TransactionJournal $journal) { $what = strtolower($journal->transactiontype->type); - $subTitle = 'Edit ' . $what . ' "' . $journal->description . '"'; + $subTitle = 'Edit ' . e($what) . ' "' . e($journal->description) . '"'; $budgets = FFForm::makeSelectList($this->_helper->getBudgets(), true); $accounts = FFForm::makeSelectList($this->_helper->getAssetAccounts()); $piggies = FFForm::makeSelectList($this->_helper->getPiggyBanks(), true); @@ -346,7 +346,7 @@ class TransactionController extends BaseController } return View::make('transactions.show', compact('journal', 'members'))->with( - 'subTitle', $journal->transactionType->type . ' "' . $journal->description . '"' + 'subTitle', e($journal->transactionType->type) . ' "' . e($journal->description) . '"' ); } diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index f0a2e058e3..2db40a05e6 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -208,8 +208,8 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface return true; } else { - var_dump($validation['errors']); - exit; + \Log::error($validation['errors']->all()); + \App::abort(500); } } @@ -314,8 +314,8 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface $data = array_except($data, ['_token', 'what']); $account = new \Account($data); if (!$account->isValid()) { - var_dump($account->getErrors()->all()); - exit; + \Log::error($account->getErrors()->all()); + \App::abort(500); } $account->save(); if (isset($data['openingbalance']) && floatval($data['openingbalance']) != 0) { diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index 52ca7e727b..f204a7ea8c 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -285,8 +285,8 @@ class PiggyBank $event->amount = $diff; $event->date = new Carbon; if (!$event->isValid()) { - var_dump($event->getErrors()); - exit(); + \Log::error($event->getErrors()); + \App::abort(500); } $event->save(); } From 2c4454418ed9658e8c22091b8410a87dec02a6bb Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 05:36:05 +0100 Subject: [PATCH 67/84] Remove possible xsrf [skip ci] --- app/breadcrumbs.php | 46 ++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 68d1e10a5f..522c06f048 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -18,7 +18,7 @@ Breadcrumbs::register( Breadcrumbs::register( 'accounts.index', function (Generator $breadcrumbs, $what) { $breadcrumbs->parent('home'); - $breadcrumbs->push(ucfirst($what) . ' accounts', route('accounts.index', $what)); + $breadcrumbs->push(ucfirst(e($what)) . ' accounts', route('accounts.index', $what)); } ); Breadcrumbs::register( @@ -43,20 +43,20 @@ Breadcrumbs::register( break; } $breadcrumbs->parent('accounts.index', $what); - $breadcrumbs->push($account->name, route('accounts.show', $account->id)); + $breadcrumbs->push(e($account->name), route('accounts.show', $account->id)); } ); Breadcrumbs::register( 'accounts.delete', function (Generator $breadcrumbs, \Account $account) { $breadcrumbs->parent('accounts.show', $account); - $breadcrumbs->push('Delete ' . $account->name, route('accounts.delete', $account->id)); + $breadcrumbs->push('Delete ' . e($account->name), route('accounts.delete', $account->id)); } ); Breadcrumbs::register( 'accounts.edit', function (Generator $breadcrumbs, \Account $account) { $breadcrumbs->parent('accounts.show', $account); - $breadcrumbs->push('Edit ' . $account->name, route('accounts.edit', $account->id)); + $breadcrumbs->push('Edit ' . e($account->name), route('accounts.edit', $account->id)); } ); @@ -77,20 +77,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'budgets.edit', function (Generator $breadcrumbs, Budget $budget) { $breadcrumbs->parent('budgets.show', $budget); - $breadcrumbs->push('Edit ' . $budget->name, route('budgets.edit', $budget->id)); + $breadcrumbs->push('Edit ' . e($budget->name), route('budgets.edit', $budget->id)); } ); Breadcrumbs::register( 'budgets.delete', function (Generator $breadcrumbs, Budget $budget) { $breadcrumbs->parent('budgets.show', $budget); - $breadcrumbs->push('Delete ' . $budget->name, route('budgets.delete', $budget->id)); + $breadcrumbs->push('Delete ' . e($budget->name), route('budgets.delete', $budget->id)); } ); Breadcrumbs::register( 'budgets.show', function (Generator $breadcrumbs, Budget $budget, LimitRepetition $repetition = null) { $breadcrumbs->parent('budgets.index'); - $breadcrumbs->push($budget->name, route('budgets.show', $budget->id)); + $breadcrumbs->push(e($budget->name), route('budgets.show', $budget->id)); if (!is_null($repetition)) { $breadcrumbs->push( DateKit::periodShow($repetition->startdate, $repetition->budgetlimit->repeat_freq), route('budgets.show', $budget->id, $repetition->id) @@ -116,20 +116,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'categories.edit', function (Generator $breadcrumbs, Category $category) { $breadcrumbs->parent('categories.show', $category); - $breadcrumbs->push('Edit ' . $category->name, route('categories.edit', $category->id)); + $breadcrumbs->push('Edit ' . e($category->name), route('categories.edit', $category->id)); } ); Breadcrumbs::register( 'categories.delete', function (Generator $breadcrumbs, Category $category) { $breadcrumbs->parent('categories.show', $category); - $breadcrumbs->push('Delete ' . $category->name, route('categories.delete', $category->id)); + $breadcrumbs->push('Delete ' . e($category->name), route('categories.delete', $category->id)); } ); Breadcrumbs::register( 'categories.show', function (Generator $breadcrumbs, Category $category) { $breadcrumbs->parent('categories.index'); - $breadcrumbs->push($category->name, route('categories.show', $category->id)); + $breadcrumbs->push(e($category->name), route('categories.show', $category->id)); } ); @@ -152,20 +152,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'piggyBanks.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.show', $piggyBank); - $breadcrumbs->push('Edit ' . $piggyBank->name, route('piggyBanks.edit', $piggyBank->id)); + $breadcrumbs->push('Edit ' . e($piggyBank->name), route('piggyBanks.edit', $piggyBank->id)); } ); Breadcrumbs::register( 'piggyBanks.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.show', $piggyBank); - $breadcrumbs->push('Delete ' . $piggyBank->name, route('piggyBanks.delete', $piggyBank->id)); + $breadcrumbs->push('Delete ' . e($piggyBank->name), route('piggyBanks.delete', $piggyBank->id)); } ); Breadcrumbs::register( 'piggyBanks.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('piggyBanks.index'); - $breadcrumbs->push($piggyBank->name, route('piggyBanks.show', $piggyBank->id)); + $breadcrumbs->push(e($piggyBank->name), route('piggyBanks.show', $piggyBank->id)); } ); @@ -212,20 +212,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'bills.edit', function (Generator $breadcrumbs, Bill $bill) { $breadcrumbs->parent('bills.show', $bill); - $breadcrumbs->push('Edit ' . $bill->name, route('bills.edit', $bill->id)); + $breadcrumbs->push('Edit ' . e($bill->name), route('bills.edit', $bill->id)); } ); Breadcrumbs::register( 'bills.delete', function (Generator $breadcrumbs, Bill $bill) { $breadcrumbs->parent('bills.show', $bill); - $breadcrumbs->push('Delete ' . $bill->name, route('bills.delete', $bill->id)); + $breadcrumbs->push('Delete ' . e($bill->name), route('bills.delete', $bill->id)); } ); Breadcrumbs::register( 'bills.show', function (Generator $breadcrumbs, Bill $bill) { $breadcrumbs->parent('bills.index'); - $breadcrumbs->push($bill->name, route('bills.show', $bill->id)); + $breadcrumbs->push(e($bill->name), route('bills.show', $bill->id)); } ); @@ -256,20 +256,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'repeated.edit', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.show', $piggyBank); - $breadcrumbs->push('Edit ' . $piggyBank->name, route('repeated.edit', $piggyBank->id)); + $breadcrumbs->push('Edit ' . e($piggyBank->name), route('repeated.edit', $piggyBank->id)); } ); Breadcrumbs::register( 'repeated.delete', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.show', $piggyBank); - $breadcrumbs->push('Delete ' . $piggyBank->name, route('repeated.delete', $piggyBank->id)); + $breadcrumbs->push('Delete ' . e($piggyBank->name), route('repeated.delete', $piggyBank->id)); } ); Breadcrumbs::register( 'repeated.show', function (Generator $breadcrumbs, PiggyBank $piggyBank) { $breadcrumbs->parent('repeated.index'); - $breadcrumbs->push($piggyBank->name, route('repeated.show', $piggyBank->id)); + $breadcrumbs->push(e($piggyBank->name), route('repeated.show', $piggyBank->id)); } ); @@ -342,20 +342,20 @@ Breadcrumbs::register( Breadcrumbs::register( 'transactions.create', function (Generator $breadcrumbs, $what) { $breadcrumbs->parent('transactions.index', $what); - $breadcrumbs->push('Create new ' . $what, route('transactions.create', $what)); + $breadcrumbs->push('Create new ' .e($what), route('transactions.create', $what)); } ); Breadcrumbs::register( 'transactions.edit', function (Generator $breadcrumbs, TransactionJournal $journal) { $breadcrumbs->parent('transactions.show', $journal); - $breadcrumbs->push('Edit ' . $journal->description, route('transactions.edit', $journal->id)); + $breadcrumbs->push('Edit ' . e($journal->description), route('transactions.edit', $journal->id)); } ); Breadcrumbs::register( 'transactions.delete', function (Generator $breadcrumbs, TransactionJournal $journal) { $breadcrumbs->parent('transactions.show', $journal); - $breadcrumbs->push('Delete ' . $journal->description, route('transactions.delete', $journal->id)); + $breadcrumbs->push('Delete ' . e($journal->description), route('transactions.delete', $journal->id)); } ); @@ -363,7 +363,7 @@ Breadcrumbs::register( 'transactions.show', function (Generator $breadcrumbs, TransactionJournal $journal) { $breadcrumbs->parent('transactions.index', strtolower($journal->transactionType->type)); - $breadcrumbs->push($journal->description, route('transactions.show', $journal->id)); + $breadcrumbs->push(e($journal->description), route('transactions.show', $journal->id)); } ); \ No newline at end of file From c3c1a6eb22dedad35cf23a6a1d1aa417d2566464 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 05:36:49 +0100 Subject: [PATCH 68/84] Changed permissions [skip ci] --- app/config/queue.php | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 app/config/queue.php diff --git a/app/config/queue.php b/app/config/queue.php old mode 100755 new mode 100644 From d9bf4d1c0de7e65cc733e4a6f39600f17d14fc44 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 05:37:25 +0100 Subject: [PATCH 69/84] Removed c3.php from lib. [skip ci] --- c3.php | 240 --------------------------------------------------------- 1 file changed, 240 deletions(-) delete mode 100644 c3.php diff --git a/c3.php b/c3.php deleted file mode 100644 index 7f77e7cde2..0000000000 --- a/c3.php +++ /dev/null @@ -1,240 +0,0 @@ - $value) { - $_SERVER["HTTP_X_CODECEPTION_".strtoupper($key)] = $value; - } - } -} - -if (!array_key_exists('HTTP_X_CODECEPTION_CODECOVERAGE', $_SERVER)) { - return; -} - -if (!function_exists('__c3_error')) { - function __c3_error($message) - { - file_put_contents(C3_CODECOVERAGE_MEDIATE_STORAGE . DIRECTORY_SEPARATOR . 'error.txt', $message); - if (!headers_sent()) { - header('X-Codeception-CodeCoverage-Error: ' . str_replace("\n", ' ', $message), true, 500); - } - setcookie('CODECEPTION_CODECOVERAGE_ERROR', $message); - } -} - -// Autoload Codeception classes -if (!class_exists('\\Codeception\\Codecept')) { - if (stream_resolve_include_path(__DIR__ . '/vendor/autoload.php')) { - require_once __DIR__ . '/vendor/autoload.php'; - } elseif (file_exists(__DIR__ . '/codecept.phar')) { - require_once 'phar://'.__DIR__ . '/codecept.phar/autoload.php'; - } elseif (stream_resolve_include_path('Codeception/autoload.php')) { - require_once 'Codeception/autoload.php'; - } else { - __c3_error('Codeception is not loaded. Please check that either PHAR or Composer or PEAR package can be used'); - } -} - -// Load Codeception Config -$config_file = realpath(__DIR__) . DIRECTORY_SEPARATOR . 'codeception.yml'; -if (array_key_exists('HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG', $_SERVER)) { - $config_file = realpath(__DIR__) . DIRECTORY_SEPARATOR . $_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_CONFIG']; -} -if (!file_exists($config_file)) { - __c3_error(sprintf("Codeception config file '%s' not found", $config_file)); -} -try { - \Codeception\Configuration::config($config_file); -} catch (\Exception $e) { - __c3_error($e->getMessage()); -} - -if (!defined('C3_CODECOVERAGE_MEDIATE_STORAGE')) { - - // workaround for 'zend_mm_heap corrupted' problem - gc_disable(); - - if ((integer)ini_get('memory_limit') < 384) { - ini_set('memory_limit', '384M'); - } - - define('C3_CODECOVERAGE_MEDIATE_STORAGE', Codeception\Configuration::logDir() . 'c3tmp'); - define('C3_CODECOVERAGE_PROJECT_ROOT', Codeception\Configuration::projectDir()); - define('C3_CODECOVERAGE_TESTNAME', $_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE']); - - function __c3_build_html_report(PHP_CodeCoverage $codeCoverage, $path) - { - $writer = new PHP_CodeCoverage_Report_HTML(); - $writer->process($codeCoverage, $path . 'html'); - - if (file_exists($path . '.tar')) { - unlink($path . '.tar'); - } - - $phar = new PharData($path . '.tar'); - $phar->setSignatureAlgorithm(Phar::SHA1); - $files = $phar->buildFromDirectory($path . 'html'); - array_map('unlink', $files); - - if (in_array('GZ', Phar::getSupportedCompression())) { - if (file_exists($path . '.tar.gz')) { - unlink($path . '.tar.gz'); - } - - $phar->compress(\Phar::GZ); - - // close the file so that we can rename it - unset($phar); - - unlink($path . '.tar'); - rename($path . '.tar.gz', $path . '.tar'); - } - - return $path . '.tar'; - } - - function __c3_build_clover_report(PHP_CodeCoverage $codeCoverage, $path) - { - $writer = new PHP_CodeCoverage_Report_Clover(); - $writer->process($codeCoverage, $path . '.clover.xml'); - - return $path . '.clover.xml'; - } - - function __c3_send_file($filename) - { - if (!headers_sent()) { - readfile($filename); - } - - return __c3_exit(); - } - - /** - * @param $filename - * @return null|PHP_CodeCoverage - */ - function __c3_factory($filename) - { - $phpCoverage = is_readable($filename) - ? unserialize(file_get_contents($filename)) - : new PHP_CodeCoverage(); - - - if (isset($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_SUITE'])) { - $suite = $_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_SUITE']; - try { - $settings = \Codeception\Configuration::suiteSettings($suite, \Codeception\Configuration::config()); - } catch (Exception $e) { - __c3_error($e->getMessage()); - } - } else { - $settings = \Codeception\Configuration::config(); - } - - try { - \Codeception\Coverage\Filter::setup($phpCoverage) - ->whiteList($settings) - ->blackList($settings); - } catch (Exception $e) { - __c3_error($e->getMessage()); - } - - return $phpCoverage; - } - - function __c3_exit() - { - if (!isset($_SERVER['HTTP_X_CODECEPTION_CODECOVERAGE_DEBUG'])) { - exit; - } - return null; - } - - function __c3_clear() - { - \Codeception\Util\FileSystem::doEmptyDir(C3_CODECOVERAGE_MEDIATE_STORAGE); - } -} - -if (!is_dir(C3_CODECOVERAGE_MEDIATE_STORAGE)) { - if (mkdir(C3_CODECOVERAGE_MEDIATE_STORAGE, 0777, true) === false) { - __c3_error('Failed to create directory "' . C3_CODECOVERAGE_MEDIATE_STORAGE . '"'); - } -} - -// evaluate base path for c3-related files -$path = realpath(C3_CODECOVERAGE_MEDIATE_STORAGE) . DIRECTORY_SEPARATOR . 'codecoverage'; - -$requested_c3_report = (strpos($_SERVER['REQUEST_URI'], 'c3/report') !== false); - -$complete_report = $current_report = $path . '.serialized'; -if ($requested_c3_report) { - set_time_limit(0); - - $route = ltrim(strrchr($_SERVER['REQUEST_URI'], '/'), '/'); - - if ($route == 'clear') { - __c3_clear(); - return __c3_exit(); - } - - $codeCoverage = __c3_factory($complete_report); - - switch ($route) { - case 'html': - try { - __c3_send_file(__c3_build_html_report($codeCoverage, $path)); - } catch (Exception $e) { - __c3_error($e->getMessage()); - } - return __c3_exit(); - case 'clover': - try { - __c3_send_file(__c3_build_clover_report($codeCoverage, $path)); - } catch (Exception $e) { - __c3_error($e->getMessage()); - } - return __c3_exit(); - case 'serialized': - try { - __c3_send_file($complete_report); - } catch (Exception $e) { - __c3_error($e->getMessage()); - } - return __c3_exit(); - } - -} else { - $codeCoverage = __c3_factory($current_report); - $codeCoverage->start(C3_CODECOVERAGE_TESTNAME); - if (!array_key_exists('HTTP_X_CODECEPTION_CODECOVERAGE_DEBUG', $_SERVER)) { - register_shutdown_function( - function () use ($codeCoverage, $current_report) { - $codeCoverage->stop(); - file_put_contents($current_report, serialize($codeCoverage)); - } - ); - } -} - -// @codeCoverageIgnoreEnd \ No newline at end of file From 550f301ba24dd286e74a854de8e831fff06321ec Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 05:52:38 +0100 Subject: [PATCH 70/84] Code cleanup [skip ci] --- app/commands/Cleanup.php | 2 -- app/controllers/AccountController.php | 2 +- app/controllers/BillController.php | 2 +- app/controllers/BudgetController.php | 2 +- app/controllers/CategoryController.php | 2 +- app/controllers/CurrencyController.php | 2 +- app/controllers/PiggybankController.php | 2 +- app/controllers/RepeatedExpenseController.php | 2 +- app/controllers/ReportController.php | 1 - app/controllers/TransactionController.php | 2 +- app/controllers/UserController.php | 2 -- .../2014_07_09_204843_create_session_table.php | 11 ++++++----- .../2014_12_13_190730_changes_for_v321.php | 13 ------------- .../2014_12_24_191544_changes_for_v322.php | 18 ------------------ app/database/seeds/TestContentSeeder.php | 6 +++--- .../FireflyIII/Database/Account/Account.php | 13 +++++++------ app/lib/FireflyIII/Database/Budget/Budget.php | 3 ++- .../TransactionJournal/TransactionJournal.php | 4 ++-- app/lib/FireflyIII/FF3ServiceProvider.php | 6 ++---- app/lib/FireflyIII/Report/Report.php | 8 ++++---- app/lib/FireflyIII/Report/ReportQuery.php | 8 ++++---- app/lib/FireflyIII/Search/Search.php | 5 +++-- app/lib/FireflyIII/Shared/Toolkit/Steam.php | 14 ++------------ app/models/Piggybank.php | 11 ++++++----- app/models/TransactionJournal.php | 2 +- app/routes.php | 4 +--- app/start/global.php | 2 +- 27 files changed, 52 insertions(+), 97 deletions(-) diff --git a/app/commands/Cleanup.php b/app/commands/Cleanup.php index aca68e02a1..db76195588 100644 --- a/app/commands/Cleanup.php +++ b/app/commands/Cleanup.php @@ -1,8 +1,6 @@ withInput(); } - // store: + // store $this->_repository->store($data); Session::flash('success', 'Account "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index 2b10e6d242..092ea2929b 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -149,7 +149,7 @@ class BillController extends BaseController return Redirect::route('bills.create')->withInput(); } - // store: + // store $this->_repository->store($data); Session::flash('success', 'Bill "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { diff --git a/app/controllers/BudgetController.php b/app/controllers/BudgetController.php index a3fa3bd014..4d48ce1e8f 100644 --- a/app/controllers/BudgetController.php +++ b/app/controllers/BudgetController.php @@ -179,7 +179,7 @@ class BudgetController extends BaseController return Redirect::route('budgets.create')->withInput(); } - // store: + // store $this->_repository->store($data); Session::flash('success', 'Budget "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { diff --git a/app/controllers/CategoryController.php b/app/controllers/CategoryController.php index a067224a36..3f4062ceea 100644 --- a/app/controllers/CategoryController.php +++ b/app/controllers/CategoryController.php @@ -116,7 +116,7 @@ class CategoryController extends BaseController return Redirect::route('categories.create')->withInput(); } - // store: + // store $this->_repository->store($data); Session::flash('success', 'Category "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { diff --git a/app/controllers/CurrencyController.php b/app/controllers/CurrencyController.php index 9daadad525..71c3c92b0b 100644 --- a/app/controllers/CurrencyController.php +++ b/app/controllers/CurrencyController.php @@ -145,7 +145,7 @@ class CurrencyController extends BaseController return Redirect::route('currency.create')->withInput(); } - // store: + // store $this->_repository->store($data); Session::flash('success', 'Currency "' . e($data['name']) . '" stored.'); if ($data['post_submit_action'] == 'store') { diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 64e5917d41..cc262a9e42 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -297,7 +297,7 @@ class PiggyBankController extends BaseController return Redirect::route('piggy_banks.create')->withInput(); } - // store: + // store $piggyBank = $this->_repository->store($data); Event::fire('piggy_bank.store', [$piggyBank]); // new and used. Session::flash('success', 'Piggy bank "' . e($data['name']) . '" stored.'); diff --git a/app/controllers/RepeatedExpenseController.php b/app/controllers/RepeatedExpenseController.php index 695b5dbd7b..c97e36bc79 100644 --- a/app/controllers/RepeatedExpenseController.php +++ b/app/controllers/RepeatedExpenseController.php @@ -168,7 +168,7 @@ class RepeatedExpenseController extends BaseController return Redirect::route('repeated.create')->withInput(); } - // store: + // store $piggyBank = $this->_repository->store($data); Event::fire('piggy_bank.store', [$piggyBank]); // new and used. Session::flash('success', 'Piggy bank "' . e($data['name']) . '" stored.'); diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 037b5e2627..449486e13e 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -94,7 +94,6 @@ class ReportController extends BaseController $budgets = $this->_repository->getBudgetsForMonth($date); $categories = $this->_repository->getCategoriesForMonth($date, 10); $accounts = $this->_repository->getAccountsForMonth($date); - //$piggyBanks = $this->_repository->getPiggyBanksForMonth($date); return View::make( 'reports.month', diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index a7f00e3900..3399cc6212 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -382,7 +382,7 @@ class TransactionController extends BaseController return Redirect::route('transactions.create', $data['what'])->withInput(); } - // store: + // store $journal = $this->_repository->store($data); Event::fire('transactionJournal.store', [$journal, Input::get('piggy_bank_id')]); // new and used. /* diff --git a/app/controllers/UserController.php b/app/controllers/UserController.php index 12d35e5d67..5ecd6a4ee4 100644 --- a/app/controllers/UserController.php +++ b/app/controllers/UserController.php @@ -76,8 +76,6 @@ class UserController extends BaseController $user = $repository->register(Input::all()); - - //$user = $this->user->register(Input::all()); if ($user) { $email->sendVerificationMail($user); diff --git a/app/database/migrations/2014_07_09_204843_create_session_table.php b/app/database/migrations/2014_07_09_204843_create_session_table.php index 3100f7e9b8..e09703979a 100644 --- a/app/database/migrations/2014_07_09_204843_create_session_table.php +++ b/app/database/migrations/2014_07_09_204843_create_session_table.php @@ -1,6 +1,7 @@ string('id')->unique(); - $t->text('payload'); - $t->integer('last_activity'); - } + 'sessions', function (Blueprint $table) { + $table->string('id')->unique(); + $table->text('payload'); + $table->integer('last_activity'); + } ); } diff --git a/app/database/migrations/2014_12_13_190730_changes_for_v321.php b/app/database/migrations/2014_12_13_190730_changes_for_v321.php index 10dc2f221d..4a9a743178 100644 --- a/app/database/migrations/2014_12_13_190730_changes_for_v321.php +++ b/app/database/migrations/2014_12_13_190730_changes_for_v321.php @@ -272,19 +272,6 @@ class ChangesForV321 extends Migration $this->dropComponentIdFromBudgetLimits(); // 16. $this->expandCurrencyTable(); // 17. - - // $this->doRenameInLimitRepetitions(); - // $this->doBudgetLimits(); - // $this->doPiggyBankEvents(); - // $this->doCreateCategoryTables(); - // $this->doUpdateTransactionTable(); - // $this->doDropCompRecurTable(); - // $this->doDropCompTransTable(); - // $this->doMoveBudgets(); - // $this->doMoveCategories(); - // $this->doMoveLimitReferences(); - - } public function createBudgetTable() diff --git a/app/database/migrations/2014_12_24_191544_changes_for_v322.php b/app/database/migrations/2014_12_24_191544_changes_for_v322.php index 5fa0ed91fa..0714ea25fe 100644 --- a/app/database/migrations/2014_12_24_191544_changes_for_v322.php +++ b/app/database/migrations/2014_12_24_191544_changes_for_v322.php @@ -1,7 +1,6 @@ dropUnique('unique_ci_combi'); -// } catch (QueryException $e) { -// echo 'Could not delete unique_ci_combi'; -// -// } catch (PDOException $e) { -// echo 'Could not delete unique_ci_combi'; -// } catch (Exception $e) { -// echo 'Could not delete unique_ci_combi'; -// } - - } - ); // recreate it the correct way: Schema::table( 'budget_limits', function (Blueprint $table) { diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index 16773fd33a..fa9d5c34ae 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -268,10 +268,10 @@ class TestContentSeeder extends Seeder */ public function createPiggyBanks(User $user) { - // account: + // account $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); - // some dates: + // some dates $endDate = clone $this->_startOfMonth; $nextYear = clone $this->_startOfMonth; @@ -374,7 +374,7 @@ class TestContentSeeder extends Seeder */ public function createRecurringTransactions(User $user) { - // account: + // account $savings = Account::whereName('Savings account')->orderBy('id', 'DESC')->first(); $recurring = PiggyBank::create( diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index 2db40a05e6..10ebbf5406 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -7,6 +7,7 @@ use FireflyIII\Database\CommonDatabaseCalls; use FireflyIII\Database\CUD; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; +use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; use Illuminate\Support\MessageBag; @@ -224,18 +225,18 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface // delete journals: $journals = \TransactionJournal::whereIn( - 'id', function ($query) use ($model) { + 'id', function (Builder $query) use ($model) { $query->select('transaction_journal_id') ->from('transactions')->whereIn( - 'account_id', function ($query) use ($model) { + 'account_id', function (Builder $query) use ($model) { $query ->select('id') ->from('accounts') ->where( - function ($q) use ($model) { + function (Builder $q) use ($model) { $q->where('id', $model->id); $q->orWhere( - function ($q) use ($model) { + function (Builder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); // TODO magic number! $q->where('accounts.account_type_id', 3); @@ -273,10 +274,10 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface // delete accounts: \Account::where( - function ($q) use ($model) { + function (Builder $q) use ($model) { $q->where('id', $model->id); $q->orWhere( - function ($q) use ($model) { + function (Builder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); // TODO magic number! $q->where('accounts.account_type_id', 3); diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 86f9a9c96c..2717a58f11 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -10,6 +10,7 @@ use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; use Illuminate\Support\MessageBag; +use Illuminate\Database\Eloquent\Builder; /** * Class Budget @@ -265,7 +266,7 @@ class Budget implements CUD, CommonDatabaseCalls, BudgetInterface return $this->getUser() ->transactionjournals() ->whereNotIn( - 'transaction_journals.id', function ($query) use ($start, $end) { + 'transaction_journals.id', function (Builder $query) use ($start, $end) { $query ->select('transaction_journals.id') ->from('transaction_journals') diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 406c5d075f..72e8fc10ea 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -158,7 +158,7 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData $errors->add('description', 'Internal error: need to know type of transaction!'); } /* - * Amount: + * Amount */ if (isset($model['amount']) && floatval($model['amount']) < 0.01) { $errors->add('amount', 'Amount must be > 0.01'); @@ -171,7 +171,7 @@ class TransactionJournal implements TransactionJournalInterface, CUD, CommonData } /* - * Budget: + * Budget */ if (isset($model['budget_id']) && !ctype_digit($model['budget_id'])) { $errors->add('budget_id', 'Invalid budget'); diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index 37daab3d37..14e8682d9b 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -43,8 +43,6 @@ class FF3ServiceProvider extends ServiceProvider */ public function register() { - // FORMAT: - #$this->app->bind('Interface', 'Class'); $this->registerFacades(); $this->registerInterfaces(); $this->registerAliases(); @@ -88,10 +86,10 @@ class FF3ServiceProvider extends ServiceProvider public function registerInterfaces() { - // preferences: + // preferences $this->app->bind('FireflyIII\Shared\Preferences\PreferencesInterface', 'FireflyIII\Shared\Preferences\Preferences'); - // registration and user mail: + // registration and user mail $this->app->bind('FireflyIII\Shared\Mail\RegistrationInterface', 'FireflyIII\Shared\Mail\Registration'); // reports diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index d96a676900..2c91e217ec 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -365,24 +365,24 @@ class Report implements ReportInterface { return \TransactionJournal:: leftJoin( - 'transactions as t_from', function ($join) { + 'transactions as t_from', function (JoinClause $join) { $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); } ) ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') ->leftJoin( - 'account_meta as acm_from', function ($join) { + 'account_meta as acm_from', function (JoinClause $join) { $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); } ) ->leftJoin( - 'transactions as t_to', function ($join) { + 'transactions as t_to', function (JoinClause $join) { $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); } ) ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') ->leftJoin( - 'account_meta as acm_to', function ($join) { + 'account_meta as acm_to', function (JoinClause $join) { $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); } ) diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index e2ccc51ed7..2e5addf156 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -287,24 +287,24 @@ class ReportQuery implements ReportQueryInterface { return \TransactionJournal:: leftJoin( - 'transactions as t_from', function ($join) { + 'transactions as t_from', function (JoinClause $join) { $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); } ) ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') ->leftJoin( - 'account_meta as acm_from', function ($join) { + 'account_meta as acm_from', function (JoinClause $join) { $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); } ) ->leftJoin( - 'transactions as t_to', function ($join) { + 'transactions as t_to', function (JoinClause $join) { $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); } ) ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') ->leftJoin( - 'account_meta as acm_to', function ($join) { + 'account_meta as acm_to', function (JoinClause $join) { $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); } ) diff --git a/app/lib/FireflyIII/Search/Search.php b/app/lib/FireflyIII/Search/Search.php index 810c8f01f6..fb7b648cec 100644 --- a/app/lib/FireflyIII/Search/Search.php +++ b/app/lib/FireflyIII/Search/Search.php @@ -4,6 +4,7 @@ namespace FireflyIII\Search; use Illuminate\Support\Collection; +use Illuminate\Database\Eloquent\Builder; /** * Class Search @@ -20,7 +21,7 @@ class Search public function searchAccounts(array $words) { return \Auth::user()->accounts()->with('accounttype')->where( - function ($q) use ($words) { + function (Builder $q) use ($words) { foreach ($words as $word) { $q->orWhere('name', 'LIKE', '%' . e($word) . '%'); } @@ -96,7 +97,7 @@ class Search public function searchTransactions(array $words) { return \Auth::user()->transactionjournals()->withRelevantData()->where( - function ($q) use ($words) { + function (Builder $q) use ($words) { foreach ($words as $word) { $q->orWhere('description', 'LIKE', '%' . e($word) . '%'); } diff --git a/app/lib/FireflyIII/Shared/Toolkit/Steam.php b/app/lib/FireflyIII/Shared/Toolkit/Steam.php index 7daf2708e5..b4bd26aa18 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Steam.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Steam.php @@ -16,6 +16,8 @@ class Steam { /** + * TODO find a way to reliably remove cache entries for accounts. + * * @param \Account $account * @param Carbon $date * @@ -23,24 +25,12 @@ class Steam */ public function balance(\Account $account, Carbon $date = null) { - \Log::debug('Now in Steam::balance() for account #' . $account->id . ' (' . $account->name . ')'); - if (is_null($date)) { - $key = 'account.' . $account->id . '.latestBalance'; - } else { - $key = 'account.' . $account->id . '.balanceOn' . $date->format('dmy'); - } - if (\Cache::has($key)) { - // TODO find a way to reliably remove cache entries for accounts. - #return \Cache::get($key); - } $date = is_null($date) ? Carbon::now() : $date; - \Log::debug('Now reached the moment we fire the query.'); $balance = floatval( $account->transactions()->leftJoin( 'transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id' )->where('transaction_journals.date', '<=', $date->format('Y-m-d'))->sum('transactions.amount') ); - \Cache::put($key, $balance, 20160); return $balance; } diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 8740e6c61c..23b3b703fb 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -3,6 +3,7 @@ use Carbon\Carbon; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Database\Eloquent\SoftDeletingTrait; use Watson\Validating\ValidatingTrait; +use Illuminate\Database\Eloquent\Builder; /** * Class PiggyBank @@ -77,19 +78,19 @@ class PiggyBank extends Eloquent return $rep; } else { $query = $this->piggyBankRepetitions()->where( - function ($q) { + function (Builder $q) { $q->where( - function ($q) { + function (Builder $q) { $q->where( - function ($q) { + function (Builder $q) { $today = new Carbon; $q->whereNull('startdate'); $q->orWhere('startdate', '<=', $today->format('Y-m-d 00:00:00')); } )->where( - function ($q) { + function (Builder $q) { $today = new Carbon; $q->whereNull('targetdate'); $q->orWhere('targetdate', '>=', $today->format('Y-m-d 00:00:00')); @@ -97,7 +98,7 @@ class PiggyBank extends Eloquent ); } )->orWhere( - function ($q) { + function (Builder $q) { $today = new Carbon; $q->where('startdate', '>=', $today->format('Y-m-d 00:00:00')); $q->where('targetdate', '>=', $today->format('Y-m-d 00:00:00')); diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index c6b7a0415b..0cf88ad00d 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -192,7 +192,7 @@ class TransactionJournal extends Eloquent public function scopeWithRelevantData(Builder $query) { $query->with( - ['transactions' => function ($q) { + ['transactions' => function (Builder $q) { $q->orderBy('amount', 'ASC'); }, 'transactiontype', 'budgets','categories', 'transactions.account.accounttype', 'bill', 'budgets', 'categories'] ); diff --git a/app/routes.php b/app/routes.php index ae34c5cb0a..11b3edf0a4 100644 --- a/app/routes.php +++ b/app/routes.php @@ -1,6 +1,6 @@ 'HomeController@sessionPrev', 'as' => 'sessionPrev']); - //Route::get('/repair', ['uses' => 'HomeController@repair']); Route::get('/next', ['uses' => 'HomeController@sessionNext', 'as' => 'sessionNext']); Route::get('/jump/{range}', ['uses' => 'HomeController@rangeJump', 'as' => 'rangeJump']); @@ -268,7 +267,6 @@ Route::group( Route::get('/reports/{year}', ['uses' => 'ReportController@year', 'as' => 'reports.year']); Route::get('/reports/{year}/{month}', ['uses' => 'ReportController@month', 'as' => 'reports.month']); Route::get('/reports/budget/{year}/{month}', ['uses' => 'ReportController@budget', 'as' => 'reports.budget']); - #Route::get('/reports/unbalanced/{year}/{month}', ['uses' => 'ReportController@unbalanced', 'as' => 'reports.unbalanced']); // reminder controller Route::get('/reminders/{reminder}', ['uses' => 'ReminderController@show', 'as' => 'reminders.show']); diff --git a/app/start/global.php b/app/start/global.php index 36f6db85a9..cbe2ca8b88 100644 --- a/app/start/global.php +++ b/app/start/global.php @@ -68,7 +68,7 @@ App::down( } ); -// forms: +// forms \Form::macro( 'ffText', function ($name, $value = null, array $options = []) { return \FireflyIII\Form\Form::ffText($name, $value, $options); From f1dcc41e42d8b9354e86c335fa2eda6e5fa975f4 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:00:14 +0100 Subject: [PATCH 71/84] Removed invalid composer.json entry [skip ci] --- composer.json | 1 - 1 file changed, 1 deletion(-) diff --git a/composer.json b/composer.json index 7081b40e81..e33048e239 100644 --- a/composer.json +++ b/composer.json @@ -4,7 +4,6 @@ "license": "MIT", "keywords": ["finance", "finances", "manager", "euro", "laravel", "money", "financials", "budgets", "transactions", "transfers", "management"], "homepage": "https://github.com/JC5/firefly-iii", - "php": ">=5.4.0", "type": "project", "authors": [ { From 24bdc319dd60eeba49bdeec3b2e3f8c1f43fd165 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:05:40 +0100 Subject: [PATCH 72/84] Some refactoring [skip ci] --- app/lib/FireflyIII/Database/Account/Account.php | 8 ++++---- .../FireflyIII/Database/AccountType/AccountType.php | 6 +++--- app/lib/FireflyIII/Database/Bill/Bill.php | 6 +++--- app/lib/FireflyIII/Database/Budget/Budget.php | 6 +++--- .../FireflyIII/Database/{CUD.php => CUDInterface.php} | 2 +- app/lib/FireflyIII/Database/Category/Category.php | 6 +++--- ...abaseCalls.php => CommonDatabaseCallsInterface.php} | 2 +- app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php | 6 +++--- .../FireflyIII/Database/PiggyBank/RepeatedExpense.php | 6 +++--- .../FireflyIII/Database/Transaction/Transaction.php | 6 +++--- .../TransactionCurrency/TransactionCurrency.php | 6 +++--- .../Database/TransactionJournal/TransactionJournal.php | 6 +++--- .../Database/TransactionType/TransactionType.php | 6 +++--- app/lib/FireflyIII/Shared/Mail/Registration.php | 10 ++++++---- server.php | 2 +- 15 files changed, 43 insertions(+), 41 deletions(-) rename app/lib/FireflyIII/Database/{CUD.php => CUDInterface.php} (96%) rename app/lib/FireflyIII/Database/{CommonDatabaseCalls.php => CommonDatabaseCallsInterface.php} (95%) diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index 10ebbf5406..e1ba05daa0 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -3,8 +3,8 @@ namespace FireflyIII\Database\Account; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Builder; @@ -18,7 +18,7 @@ use Illuminate\Support\MessageBag; * @package FireflyIII\Database * @implements FireflyIII\Database\Account\AccountInterface */ -class Account implements CUD, CommonDatabaseCalls, AccountInterface +class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInterface { use SwitchUser; @@ -661,4 +661,4 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/AccountType/AccountType.php b/app/lib/FireflyIII/Database/AccountType/AccountType.php index c3b8856f6a..8b3edbb2a0 100644 --- a/app/lib/FireflyIII/Database/AccountType/AccountType.php +++ b/app/lib/FireflyIII/Database/AccountType/AccountType.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\AccountType; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; @@ -14,7 +14,7 @@ use Illuminate\Support\Collection; * * @package FireflyIII\Database */ -class AccountType implements CUD, CommonDatabaseCalls +class AccountType implements CUDInterface, CommonDatabaseCallsInterface { /** diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 6cb839c653..3d0c445a4f 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -4,8 +4,8 @@ namespace FireflyIII\Database\Bill; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; @@ -17,7 +17,7 @@ use Illuminate\Support\MessageBag; * * @package FireflyIII\Database */ -class Bill implements CUD, CommonDatabaseCalls, BillInterface +class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface { use SwitchUser; diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 2717a58f11..7c1dd85d3f 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\Budget; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; @@ -17,7 +17,7 @@ use Illuminate\Database\Eloquent\Builder; * * @package FireflyIII\Database */ -class Budget implements CUD, CommonDatabaseCalls, BudgetInterface +class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterface { use SwitchUser; diff --git a/app/lib/FireflyIII/Database/CUD.php b/app/lib/FireflyIII/Database/CUDInterface.php similarity index 96% rename from app/lib/FireflyIII/Database/CUD.php rename to app/lib/FireflyIII/Database/CUDInterface.php index 5178f5c474..e9bd6d033f 100644 --- a/app/lib/FireflyIII/Database/CUD.php +++ b/app/lib/FireflyIII/Database/CUDInterface.php @@ -10,7 +10,7 @@ use Illuminate\Database\Eloquent\Model as Eloquent; * * @package FireflyIII\Database */ -interface CUD +interface CUDInterface { /** diff --git a/app/lib/FireflyIII/Database/Category/Category.php b/app/lib/FireflyIII/Database/Category/Category.php index dd0167aaf9..c24db39754 100644 --- a/app/lib/FireflyIII/Database/Category/Category.php +++ b/app/lib/FireflyIII/Database/Category/Category.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\Category; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; @@ -16,7 +16,7 @@ use Illuminate\Support\MessageBag; * * @package FireflyIII\Database */ -class Category implements CUD, CommonDatabaseCalls +class Category implements CUDInterface, CommonDatabaseCallsInterface { use SwitchUser; diff --git a/app/lib/FireflyIII/Database/CommonDatabaseCalls.php b/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php similarity index 95% rename from app/lib/FireflyIII/Database/CommonDatabaseCalls.php rename to app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php index ba3bf5d6c7..4842eaaf88 100644 --- a/app/lib/FireflyIII/Database/CommonDatabaseCalls.php +++ b/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php @@ -10,7 +10,7 @@ use Illuminate\Support\Collection; * * @package FireflyIII\Database */ -interface CommonDatabaseCalls +interface CommonDatabaseCallsInterface { /** * Returns an object with id $id. diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index bfcdaf66a5..def8a57596 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\PiggyBank; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; use Illuminate\Support\Collection; @@ -13,7 +13,7 @@ use Illuminate\Support\Collection; * * @package FireflyIII\Database */ -class PiggyBank extends PiggyBankShared implements CUD, CommonDatabaseCalls, PiggyBankInterface +class PiggyBank extends PiggyBankShared implements CUDInterface, CommonDatabaseCallsInterface, PiggyBankInterface { /** * @param \PiggyBank $piggyBank diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index 2c11ff2d2f..b6d4a2d837 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -4,8 +4,8 @@ namespace FireflyIII\Database\PiggyBank; use FireflyIII\Collection\PiggyBankPart; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use Illuminate\Support\Collection; /** @@ -13,7 +13,7 @@ use Illuminate\Support\Collection; * * @package FireflyIII\Database */ -class RepeatedExpense extends PiggyBankShared implements CUD, CommonDatabaseCalls, PiggyBankInterface +class RepeatedExpense extends PiggyBankShared implements CUDInterface, CommonDatabaseCallsInterface, PiggyBankInterface { /** diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index 27dd9c6e39..1f961bbb13 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\Transaction; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; @@ -16,7 +16,7 @@ use Illuminate\Support\MessageBag; * * @package FireflyIII\Database */ -class Transaction implements CUD, CommonDatabaseCalls +class Transaction implements CUDInterface, CommonDatabaseCallsInterface { use SwitchUser; diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index 0c1360aa97..23edb31496 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -2,8 +2,8 @@ namespace FireflyIII\Database\TransactionCurrency; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; @@ -14,7 +14,7 @@ use Illuminate\Support\MessageBag; * * @package FireflyIII\Database */ -class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabaseCalls, CUD +class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabaseCallsInterface, CUDInterface { /** diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 72e8fc10ea..77f91c3812 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -4,8 +4,8 @@ namespace FireflyIII\Database\TransactionJournal; use Carbon\Carbon; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; @@ -18,7 +18,7 @@ use Illuminate\Support\MessageBag; * * @package FireflyIII\Database */ -class TransactionJournal implements TransactionJournalInterface, CUD, CommonDatabaseCalls +class TransactionJournal implements TransactionJournalInterface, CUDInterface, CommonDatabaseCallsInterface { use SwitchUser; diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index e2bb47c1ab..199e94a1df 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -3,8 +3,8 @@ namespace FireflyIII\Database\TransactionType; -use FireflyIII\Database\CommonDatabaseCalls; -use FireflyIII\Database\CUD; +use FireflyIII\Database\CommonDatabaseCallsInterface; +use FireflyIII\Database\CUDInterface; use FireflyIII\Exception\FireflyException; use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; @@ -16,7 +16,7 @@ use Illuminate\Support\Collection; * * @package FireflyIII\Database */ -class TransactionType implements CUD, CommonDatabaseCalls +class TransactionType implements CUDInterface, CommonDatabaseCallsInterface { /** diff --git a/app/lib/FireflyIII/Shared/Mail/Registration.php b/app/lib/FireflyIII/Shared/Mail/Registration.php index af771ff265..f73c835ef5 100644 --- a/app/lib/FireflyIII/Shared/Mail/Registration.php +++ b/app/lib/FireflyIII/Shared/Mail/Registration.php @@ -2,7 +2,7 @@ namespace FireflyIII\Shared\Mail; use Swift_RfcComplianceException; - +use Illuminate\Mail\Message; /** * Class Registration * @@ -28,7 +28,8 @@ class Registration implements RegistrationInterface $data = ['password' => $password]; try { \Mail::send( - ['emails.user.register-html', 'emails.user.register-text'], $data, function ($message) use ($email) { + ['emails.user.register-html', 'emails.user.register-text'], $data, function (Message $message) use ($email) { + $message->to($email, $email)->subject('Welcome to Firefly!'); } ); @@ -51,7 +52,7 @@ class Registration implements RegistrationInterface $data = ['reset' => $reset]; try { \Mail::send( - ['emails.user.remindMe-html', 'emails.user.remindMe-text'], $data, function ($message) use ($email) { + ['emails.user.remindMe-html', 'emails.user.remindMe-text'], $data, function (Message $message) use ($email) { $message->to($email, $email)->subject('Forgot your password?'); } ); @@ -77,7 +78,8 @@ class Registration implements RegistrationInterface try { \Mail::send( - ['emails.user.verify-html', 'emails.user.verify-text'], $data, function ($message) use ($email) { + ['emails.user.verify-html', 'emails.user.verify-text'], $data, function (Message $message) use ($email) { + $message->to($email, $email)->subject('Verify your e-mail address.'); } ); diff --git a/server.php b/server.php index 5f187f3441..dfdf3bcd6b 100644 --- a/server.php +++ b/server.php @@ -11,7 +11,7 @@ $requested = $paths['public'].$uri; // This file allows us to emulate Apache's "mod_rewrite" functionality from the // built-in PHP web server. This provides a convenient way to test a Laravel // application without having installed a "real" web server software here. -if ($uri !== '/' and file_exists($requested)) +if ($uri !== '/' && file_exists($requested)) { return false; } From 5c35fee0c2c41b8e9426025e138201d82c09bb6c Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:16:49 +0100 Subject: [PATCH 73/84] New lines at end of file [skip ci] --- app/breadcrumbs.php | 2 +- app/config/compile.php | 2 +- app/config/dev.php | 2 +- app/config/firefly.php | 2 +- app/config/homestead/app.php | 2 +- app/config/homestead/database.php | 2 +- app/config/testing/app.php | 2 +- app/config/testing/database.php | 2 +- app/config/testingInMemory/app.php | 2 +- app/config/testingInMemory/database.php | 2 +- app/controllers/AccountController.php | 2 +- app/controllers/BillController.php | 2 +- app/controllers/CategoryController.php | 2 +- app/controllers/CurrencyController.php | 2 +- app/controllers/GoogleChartController.php | 2 +- app/controllers/HelpController.php | 2 +- app/controllers/HomeController.php | 2 +- app/controllers/JsonController.php | 2 +- app/controllers/PiggybankController.php | 2 +- app/controllers/PreferencesController.php | 2 +- app/controllers/ProfileController.php | 2 +- app/controllers/ReminderController.php | 2 +- app/controllers/RepeatedExpenseController.php | 2 +- app/controllers/ReportController.php | 2 +- app/controllers/SearchController.php | 2 +- app/controllers/TransactionController.php | 2 +- app/controllers/UserController.php | 2 +- app/database/seeds/AccountTypeSeeder.php | 2 +- app/database/seeds/DefaultUserSeeder.php | 2 +- app/database/seeds/TestContentSeeder.php | 2 +- app/database/seeds/TransactionCurrencySeeder.php | 2 +- app/database/seeds/TransactionTypeSeeder.php | 2 +- app/lib/FireflyIII/Chart/Chart.php | 2 +- app/lib/FireflyIII/Chart/ChartInterface.php | 2 +- app/lib/FireflyIII/Collection/PiggybankPart.php | 2 +- app/lib/FireflyIII/Database/Account/AccountInterface.php | 2 +- app/lib/FireflyIII/Database/AccountType/AccountType.php | 2 +- app/lib/FireflyIII/Database/Bill/Bill.php | 2 +- app/lib/FireflyIII/Database/Bill/BillInterface.php | 2 +- app/lib/FireflyIII/Database/Budget/Budget.php | 2 +- app/lib/FireflyIII/Database/Budget/BudgetInterface.php | 2 +- app/lib/FireflyIII/Database/CUDInterface.php | 2 +- app/lib/FireflyIII/Database/Category/Category.php | 2 +- app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php | 2 +- app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php | 2 +- app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php | 2 +- app/lib/FireflyIII/Database/PiggyBank/PiggybankInterface.php | 2 +- app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php | 2 +- app/lib/FireflyIII/Database/SwitchUser.php | 2 +- app/lib/FireflyIII/Database/Transaction/Transaction.php | 2 +- .../Database/TransactionCurrency/TransactionCurrency.php | 2 +- .../TransactionCurrency/TransactionCurrencyInterface.php | 2 +- .../Database/TransactionJournal/TransactionJournal.php | 2 +- .../Database/TransactionJournal/TransactionJournalInterface.php | 2 +- app/lib/FireflyIII/Database/TransactionType/TransactionType.php | 2 +- app/lib/FireflyIII/Database/User/User.php | 2 +- app/lib/FireflyIII/Event/Account.php | 2 +- app/lib/FireflyIII/Event/Budget.php | 2 +- app/lib/FireflyIII/Event/Event.php | 2 +- app/lib/FireflyIII/Event/Piggybank.php | 2 +- app/lib/FireflyIII/Event/Transaction.php | 2 +- app/lib/FireflyIII/Event/TransactionJournal.php | 2 +- app/lib/FireflyIII/Exception/FireflyException.php | 2 +- app/lib/FireflyIII/Exception/NotImplementedException.php | 2 +- app/lib/FireflyIII/Exception/ValidationException.php | 2 +- app/lib/FireflyIII/FF3ServiceProvider.php | 2 +- app/lib/FireflyIII/Form/Form.php | 2 +- app/lib/FireflyIII/Helper/TransactionJournal/Helper.php | 2 +- .../FireflyIII/Helper/TransactionJournal/HelperInterface.php | 2 +- app/lib/FireflyIII/Report/Report.php | 2 +- app/lib/FireflyIII/Report/ReportHelper.php | 2 +- app/lib/FireflyIII/Report/ReportHelperInterface.php | 2 +- app/lib/FireflyIII/Report/ReportInterface.php | 2 +- app/lib/FireflyIII/Report/ReportQuery.php | 2 +- app/lib/FireflyIII/Report/ReportQueryInterface.php | 2 +- app/lib/FireflyIII/Search/Search.php | 2 +- app/lib/FireflyIII/Shared/Facade/DateKit.php | 2 +- app/lib/FireflyIII/Shared/Facade/FFForm.php | 2 +- app/lib/FireflyIII/Shared/Facade/Filter.php | 2 +- app/lib/FireflyIII/Shared/Facade/Navigation.php | 2 +- app/lib/FireflyIII/Shared/Facade/Reminders.php | 2 +- app/lib/FireflyIII/Shared/Facade/Steam.php | 2 +- app/lib/FireflyIII/Shared/Mail/Registration.php | 2 +- app/lib/FireflyIII/Shared/Mail/RegistrationInterface.php | 2 +- app/lib/FireflyIII/Shared/Preferences/Preferences.php | 2 +- app/lib/FireflyIII/Shared/Preferences/PreferencesInterface.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Filter.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Form.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Navigation.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Reminders.php | 2 +- app/lib/FireflyIII/Shared/Toolkit/Steam.php | 2 +- app/lib/FireflyIII/Shared/Validation/FireflyValidator.php | 2 +- .../FireflyIII/Shared/Validation/ValidationServiceProvider.php | 2 +- app/models/Account.php | 2 +- app/models/AccountMeta.php | 2 +- app/models/AccountType.php | 2 +- app/models/Bill.php | 2 +- app/models/Budget.php | 2 +- app/models/BudgetLimit.php | 2 +- app/models/Category.php | 2 +- app/models/Component.php | 2 +- app/models/LimitRepetition.php | 2 +- app/models/Piggybank.php | 2 +- app/models/PiggybankEvent.php | 2 +- app/models/PiggybankRepetition.php | 2 +- app/models/Preference.php | 2 +- app/models/Reminder.php | 2 +- app/models/Transaction.php | 2 +- app/models/TransactionCurrency.php | 2 +- app/models/TransactionGroup.php | 2 +- app/models/TransactionJournal.php | 2 +- app/models/TransactionRelation.php | 2 +- app/models/TransactionType.php | 2 +- app/models/User.php | 2 +- app/routes.php | 2 +- app/start/artisan.php | 2 +- app/start/local.php | 2 +- app/tests/TestCase.php | 2 +- app/views/accounts/create.blade.php | 2 +- app/views/accounts/delete.blade.php | 2 +- app/views/accounts/edit.blade.php | 2 +- app/views/accounts/index.blade.php | 2 +- app/views/accounts/show.blade.php | 2 +- app/views/bills/create.blade.php | 2 +- app/views/bills/delete.blade.php | 2 +- app/views/bills/edit.blade.php | 2 +- app/views/bills/index.blade.php | 2 +- app/views/bills/show.blade.php | 2 +- app/views/budgets/delete.blade.php | 2 +- app/views/budgets/income.blade.php | 2 +- app/views/budgets/index.blade.php | 2 +- app/views/budgets/show.blade.php | 2 +- app/views/categories/delete.blade.php | 2 +- app/views/categories/edit.blade.php | 2 +- app/views/categories/index.blade.php | 2 +- app/views/categories/show.blade.php | 2 +- app/views/currency/create.blade.php | 2 +- app/views/currency/delete.blade.php | 2 +- app/views/currency/edit.blade.php | 2 +- app/views/currency/index.blade.php | 2 +- app/views/emails/user/register-html.blade.php | 2 +- app/views/emails/user/register-text.blade.php | 2 +- app/views/emails/user/verify-html.blade.php | 2 +- app/views/emails/user/verify-text.blade.php | 2 +- app/views/error.blade.php | 2 +- app/views/index.blade.php | 2 +- app/views/layouts/default.blade.php | 2 +- app/views/layouts/guest.blade.php | 2 +- app/views/list/accounts.blade.php | 2 +- app/views/list/bills.blade.php | 2 +- app/views/list/categories.blade.php | 2 +- app/views/list/journals-full.blade.php | 2 +- app/views/list/journals-small.blade.php | 2 +- app/views/list/journals-tiny.blade.php | 2 +- app/views/list/piggy-bank-events.blade.php | 2 +- app/views/partials/date_nav.blade.php | 2 +- app/views/partials/flashes.blade.php | 2 +- app/views/piggy_banks/add.blade.php | 2 +- app/views/piggy_banks/delete.blade.php | 2 +- app/views/piggy_banks/index.blade.php | 2 +- app/views/piggy_banks/remove.blade.php | 2 +- app/views/preferences/index.blade.php | 2 +- app/views/profile/change-password.blade.php | 2 +- app/views/profile/index.blade.php | 2 +- app/views/reminders/show.blade.php | 2 +- app/views/repeatedExpense/delete.blade.php | 2 +- app/views/repeatedExpense/index.blade.php | 2 +- app/views/repeatedExpense/show.blade.php | 2 +- app/views/reports/budget.blade.php | 2 +- app/views/reports/index.blade.php | 2 +- app/views/reports/month.blade.php | 2 +- app/views/reports/year.blade.php | 2 +- app/views/search/index.blade.php | 2 +- app/views/transactions/create.blade.php | 2 +- app/views/transactions/edit.blade.php | 2 +- app/views/transactions/show.blade.php | 2 +- app/views/user/login.blade.php | 2 +- app/views/user/register.blade.php | 2 +- app/views/user/registered.blade.php | 2 +- app/views/user/remindMe-html.blade.php | 2 +- app/views/user/remindMe.blade.php | 2 +- app/views/user/verification-pending.blade.php | 2 +- bootstrap/functions.php | 2 +- tests/functional/AccountControllerCest.php | 2 +- tests/functional/BillControllerCest.php | 2 +- tests/functional/BudgetControllerCest.php | 2 +- tests/functional/CategoryControllerCest.php | 2 +- tests/functional/CurrencyControllerCest.php | 2 +- tests/functional/GoogleChartControllerCest.php | 2 +- tests/functional/HelpControllerCest.php | 2 +- tests/functional/HomeControllerCest.php | 2 +- tests/functional/JsonControllerCest.php | 2 +- tests/functional/PiggyBankControllerCest.php | 2 +- tests/functional/PreferencesControllerCest.php | 2 +- tests/functional/ProfileControllerCest.php | 2 +- tests/functional/ReminderControllerCest.php | 2 +- tests/functional/RepeatedExpenseControllerCest.php | 2 +- tests/functional/ReportControllerCest.php | 2 +- tests/functional/SearchControllerCest.php | 2 +- tests/functional/TransactionControllerCest.php | 2 +- tests/functional/UserControllerCest.php | 2 +- tests/functional/_bootstrap.php | 2 +- tests/unit/AccountTest.php | 2 +- tests/unit/AccountTypeTest.php | 2 +- tests/unit/BudgetTest.php | 2 +- tests/unit/PiggyBankRepetitionTest.php | 2 +- tests/unit/PiggyBankTest.php | 2 +- tests/unit/ReminderTest.php | 2 +- tests/unit/TransactionGroupTest.php | 2 +- tests/unit/TransactionJournalTest.php | 2 +- tests/unit/TransactionTest.php | 2 +- tests/unit/TransactionTypeTest.php | 2 +- tests/unit/UserTest.php | 2 +- 213 files changed, 213 insertions(+), 213 deletions(-) diff --git a/app/breadcrumbs.php b/app/breadcrumbs.php index 522c06f048..126c478c30 100644 --- a/app/breadcrumbs.php +++ b/app/breadcrumbs.php @@ -366,4 +366,4 @@ Breadcrumbs::register( $breadcrumbs->push(e($journal->description), route('transactions.show', $journal->id)); } -); \ No newline at end of file +); diff --git a/app/config/compile.php b/app/config/compile.php index b993871588..0b67a5fe47 100644 --- a/app/config/compile.php +++ b/app/config/compile.php @@ -1,3 +1,3 @@ '' -]; \ No newline at end of file +]; diff --git a/app/config/firefly.php b/app/config/firefly.php index 9d886aa4f9..c17ca873e3 100644 --- a/app/config/firefly.php +++ b/app/config/firefly.php @@ -46,4 +46,4 @@ return [ '6M' => 'half-year', 'custom' => 'monthly' ], -]; \ No newline at end of file +]; diff --git a/app/config/homestead/app.php b/app/config/homestead/app.php index b6d461000d..0f1dd6a103 100644 --- a/app/config/homestead/app.php +++ b/app/config/homestead/app.php @@ -12,4 +12,4 @@ return [ */ 'debug' => true, 'log_level' => 'debug', -]; \ No newline at end of file +]; diff --git a/app/config/homestead/database.php b/app/config/homestead/database.php index 29737579f8..d585027ae3 100644 --- a/app/config/homestead/database.php +++ b/app/config/homestead/database.php @@ -34,4 +34,4 @@ return [ ], -]; \ No newline at end of file +]; diff --git a/app/config/testing/app.php b/app/config/testing/app.php index e729eb5ab7..7f9d13d6fb 100644 --- a/app/config/testing/app.php +++ b/app/config/testing/app.php @@ -1,2 +1,2 @@ 'debug',]; \ No newline at end of file +return ['log_level' => 'debug',]; diff --git a/app/config/testing/database.php b/app/config/testing/database.php index 3517df8d20..e0be6a4063 100644 --- a/app/config/testing/database.php +++ b/app/config/testing/database.php @@ -9,4 +9,4 @@ return [ ] ] -]; \ No newline at end of file +]; diff --git a/app/config/testingInMemory/app.php b/app/config/testingInMemory/app.php index e729eb5ab7..7f9d13d6fb 100644 --- a/app/config/testingInMemory/app.php +++ b/app/config/testingInMemory/app.php @@ -1,2 +1,2 @@ 'debug',]; \ No newline at end of file +return ['log_level' => 'debug',]; diff --git a/app/config/testingInMemory/database.php b/app/config/testingInMemory/database.php index 0472797a15..06b50aa143 100644 --- a/app/config/testingInMemory/database.php +++ b/app/config/testingInMemory/database.php @@ -9,4 +9,4 @@ return [ ] ] -]; \ No newline at end of file +]; diff --git a/app/controllers/AccountController.php b/app/controllers/AccountController.php index 35583db871..b09766ed02 100644 --- a/app/controllers/AccountController.php +++ b/app/controllers/AccountController.php @@ -237,4 +237,4 @@ class AccountController extends BaseController // go back to update screen. return Redirect::route('accounts.edit', $account->id)->withInput(['post_submit_action' => 'return_to_edit']); } -} \ No newline at end of file +} diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index 092ea2929b..ef25c3ffff 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -202,4 +202,4 @@ class BillController extends BaseController return Redirect::route('bills.edit', $bill->id)->withInput(['post_submit_action' => 'return_to_edit']); } -} \ No newline at end of file +} diff --git a/app/controllers/CategoryController.php b/app/controllers/CategoryController.php index 3f4062ceea..9994e30e2d 100644 --- a/app/controllers/CategoryController.php +++ b/app/controllers/CategoryController.php @@ -169,4 +169,4 @@ class CategoryController extends BaseController } -} \ No newline at end of file +} diff --git a/app/controllers/CurrencyController.php b/app/controllers/CurrencyController.php index 71c3c92b0b..d8c2d5b5d6 100644 --- a/app/controllers/CurrencyController.php +++ b/app/controllers/CurrencyController.php @@ -194,4 +194,4 @@ class CurrencyController extends BaseController } -} \ No newline at end of file +} diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index 88c405d9ed..aadfc8e5a3 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -491,4 +491,4 @@ class GoogleChartController extends BaseController return Response::json($this->_chart->getData()); } -} \ No newline at end of file +} diff --git a/app/controllers/HelpController.php b/app/controllers/HelpController.php index 8d5f57155f..813b8faf5c 100644 --- a/app/controllers/HelpController.php +++ b/app/controllers/HelpController.php @@ -51,4 +51,4 @@ class HelpController extends BaseController return Response::json(['title' => $helpTitle, 'text' => $helpText]); } -} \ No newline at end of file +} diff --git a/app/controllers/HomeController.php b/app/controllers/HomeController.php index 163a3bce99..090e24e3a1 100644 --- a/app/controllers/HomeController.php +++ b/app/controllers/HomeController.php @@ -99,4 +99,4 @@ class HomeController extends BaseController return Redirect::intended('/'); } -} \ No newline at end of file +} diff --git a/app/controllers/JsonController.php b/app/controllers/JsonController.php index 094a3fc040..fedc5768d2 100644 --- a/app/controllers/JsonController.php +++ b/app/controllers/JsonController.php @@ -62,4 +62,4 @@ class JsonController extends BaseController return Response::json($return); } -} \ No newline at end of file +} diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index cc262a9e42..8bf024d9ef 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -353,4 +353,4 @@ class PiggyBankController extends BaseController return Redirect::route('piggy_banks.edit', $piggyBank->id)->withInput(['post_submit_action' => 'return_to_edit']); } -} \ No newline at end of file +} diff --git a/app/controllers/PreferencesController.php b/app/controllers/PreferencesController.php index 6b2b9a08ff..b1a5ca0fc7 100644 --- a/app/controllers/PreferencesController.php +++ b/app/controllers/PreferencesController.php @@ -73,4 +73,4 @@ class PreferencesController extends BaseController return Redirect::route('preferences'); } -} \ No newline at end of file +} diff --git a/app/controllers/ProfileController.php b/app/controllers/ProfileController.php index 19ca37ec0c..e9b397833c 100644 --- a/app/controllers/ProfileController.php +++ b/app/controllers/ProfileController.php @@ -66,4 +66,4 @@ class ProfileController extends BaseController return Redirect::route('profile'); } -} \ No newline at end of file +} diff --git a/app/controllers/ReminderController.php b/app/controllers/ReminderController.php index 9760dedced..7b34fadb04 100644 --- a/app/controllers/ReminderController.php +++ b/app/controllers/ReminderController.php @@ -90,4 +90,4 @@ class ReminderController extends BaseController return View::make('reminders.show', compact('reminder', 'amount')); } -} \ No newline at end of file +} diff --git a/app/controllers/RepeatedExpenseController.php b/app/controllers/RepeatedExpenseController.php index c97e36bc79..652e255578 100644 --- a/app/controllers/RepeatedExpenseController.php +++ b/app/controllers/RepeatedExpenseController.php @@ -224,4 +224,4 @@ class RepeatedExpenseController extends BaseController return Redirect::route('repeated.edit', $repeatedExpense->id)->withInput(['post_submit_action' => 'return_to_edit']); } -} \ No newline at end of file +} diff --git a/app/controllers/ReportController.php b/app/controllers/ReportController.php index 449486e13e..29be01240f 100644 --- a/app/controllers/ReportController.php +++ b/app/controllers/ReportController.php @@ -130,4 +130,4 @@ class ReportController extends BaseController ); } -} \ No newline at end of file +} diff --git a/app/controllers/SearchController.php b/app/controllers/SearchController.php index 978200c8c4..6bcbb73d35 100644 --- a/app/controllers/SearchController.php +++ b/app/controllers/SearchController.php @@ -35,4 +35,4 @@ class SearchController extends BaseController 'mainTitleIcon', 'fa-search' )->with('query', $rawQuery)->with('result', $result); } -} \ No newline at end of file +} diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 3399cc6212..da176b827d 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -473,4 +473,4 @@ class TransactionController extends BaseController } -} \ No newline at end of file +} diff --git a/app/controllers/UserController.php b/app/controllers/UserController.php index 5ecd6a4ee4..82309e2460 100644 --- a/app/controllers/UserController.php +++ b/app/controllers/UserController.php @@ -161,4 +161,4 @@ class UserController extends BaseController return View::make('error')->with('message', 'No reset code found!'); } -} \ No newline at end of file +} diff --git a/app/database/seeds/AccountTypeSeeder.php b/app/database/seeds/AccountTypeSeeder.php index 50f2d7f101..f0fd27b341 100644 --- a/app/database/seeds/AccountTypeSeeder.php +++ b/app/database/seeds/AccountTypeSeeder.php @@ -38,4 +38,4 @@ class AccountTypeSeeder extends Seeder } -} \ No newline at end of file +} diff --git a/app/database/seeds/DefaultUserSeeder.php b/app/database/seeds/DefaultUserSeeder.php index 237d32e17c..1b40e29097 100644 --- a/app/database/seeds/DefaultUserSeeder.php +++ b/app/database/seeds/DefaultUserSeeder.php @@ -19,4 +19,4 @@ class DefaultUserSeeder extends Seeder } -} \ No newline at end of file +} diff --git a/app/database/seeds/TestContentSeeder.php b/app/database/seeds/TestContentSeeder.php index fa9d5c34ae..e2cdebf7d7 100644 --- a/app/database/seeds/TestContentSeeder.php +++ b/app/database/seeds/TestContentSeeder.php @@ -558,4 +558,4 @@ class TestContentSeeder extends Seeder $group->transactionjournals()->save($one); $group->transactionjournals()->save($two); } -} \ No newline at end of file +} diff --git a/app/database/seeds/TransactionCurrencySeeder.php b/app/database/seeds/TransactionCurrencySeeder.php index 67ae8faba3..6bf2eb7010 100644 --- a/app/database/seeds/TransactionCurrencySeeder.php +++ b/app/database/seeds/TransactionCurrencySeeder.php @@ -15,4 +15,4 @@ class TransactionCurrencySeeder extends Seeder TransactionCurrency::create(['code' => 'HUF','name' => 'Hungarian forint','symbol' => 'Ft']); } -} \ No newline at end of file +} diff --git a/app/database/seeds/TransactionTypeSeeder.php b/app/database/seeds/TransactionTypeSeeder.php index a500ce6c00..cf0e6a5e12 100644 --- a/app/database/seeds/TransactionTypeSeeder.php +++ b/app/database/seeds/TransactionTypeSeeder.php @@ -17,4 +17,4 @@ class TransactionTypeSeeder extends Seeder TransactionType::create(['type' => 'Opening balance']); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Chart/Chart.php b/app/lib/FireflyIII/Chart/Chart.php index 3b97eabbc3..6214e5079a 100644 --- a/app/lib/FireflyIII/Chart/Chart.php +++ b/app/lib/FireflyIII/Chart/Chart.php @@ -72,4 +72,4 @@ class Chart implements ChartInterface 'transactions.amount AS actualAmount'] ); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Chart/ChartInterface.php b/app/lib/FireflyIII/Chart/ChartInterface.php index 5617cf8337..62a2efa868 100644 --- a/app/lib/FireflyIII/Chart/ChartInterface.php +++ b/app/lib/FireflyIII/Chart/ChartInterface.php @@ -28,4 +28,4 @@ interface ChartInterface */ public function getBillsSummary(Carbon $start, Carbon $end); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Collection/PiggybankPart.php b/app/lib/FireflyIII/Collection/PiggybankPart.php index 906f4f21d8..7544e4d8e9 100644 --- a/app/lib/FireflyIII/Collection/PiggybankPart.php +++ b/app/lib/FireflyIII/Collection/PiggybankPart.php @@ -176,4 +176,4 @@ class PiggyBankPart } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Account/AccountInterface.php b/app/lib/FireflyIII/Database/Account/AccountInterface.php index 55c7883865..336df90401 100644 --- a/app/lib/FireflyIII/Database/Account/AccountInterface.php +++ b/app/lib/FireflyIII/Database/Account/AccountInterface.php @@ -91,4 +91,4 @@ interface AccountInterface * @return bool */ public function storeInitialBalance(\Account $account, array $data); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/AccountType/AccountType.php b/app/lib/FireflyIII/Database/AccountType/AccountType.php index 8b3edbb2a0..a2ec514338 100644 --- a/app/lib/FireflyIII/Database/AccountType/AccountType.php +++ b/app/lib/FireflyIII/Database/AccountType/AccountType.php @@ -139,4 +139,4 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface // TODO: Implement getByIds() method. throw new NotImplementedException; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 3d0c445a4f..22bc2f2ea0 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -309,4 +309,4 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface return true; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Bill/BillInterface.php b/app/lib/FireflyIII/Database/Bill/BillInterface.php index 7be8a55b73..6c6a247364 100644 --- a/app/lib/FireflyIII/Database/Bill/BillInterface.php +++ b/app/lib/FireflyIII/Database/Bill/BillInterface.php @@ -38,4 +38,4 @@ interface BillInterface */ public function scanEverything(\Bill $bill); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 7c1dd85d3f..f47f745b8f 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -372,4 +372,4 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Budget/BudgetInterface.php b/app/lib/FireflyIII/Database/Budget/BudgetInterface.php index 1e1dc36de0..f001cdd7a3 100644 --- a/app/lib/FireflyIII/Database/Budget/BudgetInterface.php +++ b/app/lib/FireflyIII/Database/Budget/BudgetInterface.php @@ -28,4 +28,4 @@ interface BudgetInterface */ public function transactionsWithoutBudgetInDateRange(Carbon $start, Carbon $end); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/CUDInterface.php b/app/lib/FireflyIII/Database/CUDInterface.php index e9bd6d033f..e4f60a6089 100644 --- a/app/lib/FireflyIII/Database/CUDInterface.php +++ b/app/lib/FireflyIII/Database/CUDInterface.php @@ -45,4 +45,4 @@ interface CUDInterface */ public function validate(array $model); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Category/Category.php b/app/lib/FireflyIII/Database/Category/Category.php index c24db39754..a8d1ef3a37 100644 --- a/app/lib/FireflyIII/Database/Category/Category.php +++ b/app/lib/FireflyIII/Database/Category/Category.php @@ -206,4 +206,4 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface return $sum; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php b/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php index 4842eaaf88..6fbf57c68b 100644 --- a/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php +++ b/app/lib/FireflyIII/Database/CommonDatabaseCallsInterface.php @@ -44,4 +44,4 @@ interface CommonDatabaseCallsInterface */ public function getByIds(array $objectIds); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php index def8a57596..b77f9246bb 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBank.php @@ -59,4 +59,4 @@ class PiggyBank extends PiggyBankShared implements CUDInterface, CommonDatabaseC { return $this->getUser()->piggyBanks()->where('repeats', 0)->orderBy('name')->get(); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index c0e552b441..e4be2c7bf5 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -181,4 +181,4 @@ class PiggyBankShared return ['errors' => $errors, 'warnings' => $warnings, 'successes' => $successes]; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggybankInterface.php b/app/lib/FireflyIII/Database/PiggyBank/PiggybankInterface.php index dbcbea2635..3c26f1c969 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggybankInterface.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggybankInterface.php @@ -16,4 +16,4 @@ interface PiggyBankInterface * @return float */ public function leftOnAccount(\Account $account); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php index b6d4a2d837..171b4c7a88 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php +++ b/app/lib/FireflyIII/Database/PiggyBank/RepeatedExpense.php @@ -119,4 +119,4 @@ class RepeatedExpense extends PiggyBankShared implements CUDInterface, CommonDat return $this->getUser()->piggyBanks()->where('repeats', 1)->get(); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/SwitchUser.php b/app/lib/FireflyIII/Database/SwitchUser.php index 3fa27d3f84..d8c0946274 100644 --- a/app/lib/FireflyIII/Database/SwitchUser.php +++ b/app/lib/FireflyIII/Database/SwitchUser.php @@ -24,4 +24,4 @@ trait SwitchUser { $this->_user = $user; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index 1f961bbb13..7b3823b93c 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -144,4 +144,4 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface // TODO: Implement getByIds() method. throw new NotImplementedException; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index 23edb31496..ff6cf9d12c 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -149,4 +149,4 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas { return \TransactionCurrency::whereCode($code)->first(); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrencyInterface.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrencyInterface.php index e3026ca6c3..bd2c0a159d 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrencyInterface.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrencyInterface.php @@ -17,4 +17,4 @@ interface TransactionCurrencyInterface */ public function findByCode($code); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 77f91c3812..a10ba47570 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -605,4 +605,4 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C return $query; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournalInterface.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournalInterface.php index 54635e088f..0268d53d81 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournalInterface.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournalInterface.php @@ -41,4 +41,4 @@ interface TransactionJournalInterface */ public function getSumOfIncomesByMonth(Carbon $date); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index 199e94a1df..8312e08a2a 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -130,4 +130,4 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface // TODO: Implement getByIds() method. throw new NotImplementedException; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Database/User/User.php b/app/lib/FireflyIII/Database/User/User.php index 0c8888d758..f60bfc3037 100644 --- a/app/lib/FireflyIII/Database/User/User.php +++ b/app/lib/FireflyIII/Database/User/User.php @@ -70,4 +70,4 @@ class User return true; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/Account.php b/app/lib/FireflyIII/Event/Account.php index bdc87d8e9a..6890d5b1e1 100644 --- a/app/lib/FireflyIII/Event/Account.php +++ b/app/lib/FireflyIII/Event/Account.php @@ -50,4 +50,4 @@ class Account \Cache::forget('account.' . $account->id . '.latestBalance'); \Cache::forget('account.' . $account->id . '.lastActivityDate'); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/Budget.php b/app/lib/FireflyIII/Event/Budget.php index f40e02b958..940f87d887 100644 --- a/app/lib/FireflyIII/Event/Budget.php +++ b/app/lib/FireflyIII/Event/Budget.php @@ -64,4 +64,4 @@ class Budget $events->listen('limits.update', 'FireflyIII\Event\Budget@storeOrUpdateLimit'); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/Event.php b/app/lib/FireflyIII/Event/Event.php index 74d334fe07..34980e5a8d 100644 --- a/app/lib/FireflyIII/Event/Event.php +++ b/app/lib/FireflyIII/Event/Event.php @@ -42,4 +42,4 @@ class Event // triggers when others are updated. $events->listen('account.destroy', 'FireflyIII\Event\Event@deleteAccount'); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/Piggybank.php b/app/lib/FireflyIII/Event/Piggybank.php index f204a7ea8c..5c1960a170 100644 --- a/app/lib/FireflyIII/Event/Piggybank.php +++ b/app/lib/FireflyIII/Event/Piggybank.php @@ -292,4 +292,4 @@ class PiggyBank } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/Transaction.php b/app/lib/FireflyIII/Event/Transaction.php index 2b58b3c97e..9c96070cd0 100644 --- a/app/lib/FireflyIII/Event/Transaction.php +++ b/app/lib/FireflyIII/Event/Transaction.php @@ -52,4 +52,4 @@ class Transaction \Cache::forget('account.' . $transaction->account_id . '.latestBalance'); \Cache::forget('account.' . $transaction->account_id . '.lastActivityDate'); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Event/TransactionJournal.php b/app/lib/FireflyIII/Event/TransactionJournal.php index d58aba6bd0..c7cabb911c 100644 --- a/app/lib/FireflyIII/Event/TransactionJournal.php +++ b/app/lib/FireflyIII/Event/TransactionJournal.php @@ -54,4 +54,4 @@ class TransactionJournal $repository->scan($entry, $journal); } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Exception/FireflyException.php b/app/lib/FireflyIII/Exception/FireflyException.php index 69890ddfc4..a2d36d3b59 100644 --- a/app/lib/FireflyIII/Exception/FireflyException.php +++ b/app/lib/FireflyIII/Exception/FireflyException.php @@ -11,4 +11,4 @@ namespace FireflyIII\Exception; class FireflyException extends \Exception { -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Exception/NotImplementedException.php b/app/lib/FireflyIII/Exception/NotImplementedException.php index 208566204f..718e394f3e 100644 --- a/app/lib/FireflyIII/Exception/NotImplementedException.php +++ b/app/lib/FireflyIII/Exception/NotImplementedException.php @@ -10,4 +10,4 @@ namespace FireflyIII\Exception; class NotImplementedException extends \Exception { -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Exception/ValidationException.php b/app/lib/FireflyIII/Exception/ValidationException.php index b33a078b1c..77f6de015e 100644 --- a/app/lib/FireflyIII/Exception/ValidationException.php +++ b/app/lib/FireflyIII/Exception/ValidationException.php @@ -9,4 +9,4 @@ namespace FireflyIII\Exception; class ValidationException extends \Exception { -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index 14e8682d9b..18ad6a4612 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -118,4 +118,4 @@ class FF3ServiceProvider extends ServiceProvider ); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Form/Form.php b/app/lib/FireflyIII/Form/Form.php index 55e20004fa..c44683a674 100644 --- a/app/lib/FireflyIII/Form/Form.php +++ b/app/lib/FireflyIII/Form/Form.php @@ -379,4 +379,4 @@ class Form return self::ffInput('text', $name, $value, $options); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php index b0a9496cdf..304cef0c5d 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/Helper.php @@ -90,4 +90,4 @@ class Helper implements HelperInterface } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php index b500d206a1..f49046a42a 100644 --- a/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php +++ b/app/lib/FireflyIII/Helper/TransactionJournal/HelperInterface.php @@ -49,4 +49,4 @@ interface HelperInterface */ public function getRepeatedExpenses(); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 2c91e217ec..dd396b6cc8 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -442,4 +442,4 @@ class Report implements ReportInterface return $report; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/ReportHelper.php b/app/lib/FireflyIII/Report/ReportHelper.php index feea4ad0fb..d2e79b6d8f 100644 --- a/app/lib/FireflyIII/Report/ReportHelper.php +++ b/app/lib/FireflyIII/Report/ReportHelper.php @@ -139,4 +139,4 @@ class ReportHelper implements ReportHelperInterface return $array; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/ReportHelperInterface.php b/app/lib/FireflyIII/Report/ReportHelperInterface.php index 80dcd648e6..828e322603 100644 --- a/app/lib/FireflyIII/Report/ReportHelperInterface.php +++ b/app/lib/FireflyIII/Report/ReportHelperInterface.php @@ -61,4 +61,4 @@ interface ReportHelperInterface */ public function sortNegativeArray(array $array); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/ReportInterface.php b/app/lib/FireflyIII/Report/ReportInterface.php index 73658f652f..1f50e9bf4e 100644 --- a/app/lib/FireflyIII/Report/ReportInterface.php +++ b/app/lib/FireflyIII/Report/ReportInterface.php @@ -106,4 +106,4 @@ interface ReportInterface * @return array */ public function yearBalanceReport(Carbon $date); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 2e5addf156..c224c80ea0 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -401,4 +401,4 @@ class ReportQuery implements ReportQueryInterface ] ); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Report/ReportQueryInterface.php b/app/lib/FireflyIII/Report/ReportQueryInterface.php index bed6501e71..6a729480f6 100644 --- a/app/lib/FireflyIII/Report/ReportQueryInterface.php +++ b/app/lib/FireflyIII/Report/ReportQueryInterface.php @@ -130,4 +130,4 @@ interface ReportQueryInterface */ public function sharedExpensesByCategory(Carbon $start, Carbon $end); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Search/Search.php b/app/lib/FireflyIII/Search/Search.php index fb7b648cec..4324223d14 100644 --- a/app/lib/FireflyIII/Search/Search.php +++ b/app/lib/FireflyIII/Search/Search.php @@ -104,4 +104,4 @@ class Search } )->get(); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/DateKit.php b/app/lib/FireflyIII/Shared/Facade/DateKit.php index 3a0e75ca7e..afe493b866 100644 --- a/app/lib/FireflyIII/Shared/Facade/DateKit.php +++ b/app/lib/FireflyIII/Shared/Facade/DateKit.php @@ -21,4 +21,4 @@ class DateKit extends Facade return 'datekit'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/FFForm.php b/app/lib/FireflyIII/Shared/Facade/FFForm.php index c5aefd74b8..a060d40eca 100644 --- a/app/lib/FireflyIII/Shared/Facade/FFForm.php +++ b/app/lib/FireflyIII/Shared/Facade/FFForm.php @@ -21,4 +21,4 @@ class FFForm extends Facade return 'ffform'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/Filter.php b/app/lib/FireflyIII/Shared/Facade/Filter.php index f37019bb56..9d07258b87 100644 --- a/app/lib/FireflyIII/Shared/Facade/Filter.php +++ b/app/lib/FireflyIII/Shared/Facade/Filter.php @@ -21,4 +21,4 @@ class Filter extends Facade return 'filter'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/Navigation.php b/app/lib/FireflyIII/Shared/Facade/Navigation.php index 19892870fa..7cce6f33c6 100644 --- a/app/lib/FireflyIII/Shared/Facade/Navigation.php +++ b/app/lib/FireflyIII/Shared/Facade/Navigation.php @@ -21,4 +21,4 @@ class Navigation extends Facade return 'navigation'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/Reminders.php b/app/lib/FireflyIII/Shared/Facade/Reminders.php index b0052a11b7..83eb38905b 100644 --- a/app/lib/FireflyIII/Shared/Facade/Reminders.php +++ b/app/lib/FireflyIII/Shared/Facade/Reminders.php @@ -21,4 +21,4 @@ class Reminders extends Facade return 'reminders'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Facade/Steam.php b/app/lib/FireflyIII/Shared/Facade/Steam.php index 2d5b6b8d86..b5f0cb98ca 100644 --- a/app/lib/FireflyIII/Shared/Facade/Steam.php +++ b/app/lib/FireflyIII/Shared/Facade/Steam.php @@ -21,4 +21,4 @@ class Steam extends Facade return 'steam'; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Mail/Registration.php b/app/lib/FireflyIII/Shared/Mail/Registration.php index f73c835ef5..4a8367c408 100644 --- a/app/lib/FireflyIII/Shared/Mail/Registration.php +++ b/app/lib/FireflyIII/Shared/Mail/Registration.php @@ -87,4 +87,4 @@ class Registration implements RegistrationInterface } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Mail/RegistrationInterface.php b/app/lib/FireflyIII/Shared/Mail/RegistrationInterface.php index 0741757b4e..df104cc50a 100644 --- a/app/lib/FireflyIII/Shared/Mail/RegistrationInterface.php +++ b/app/lib/FireflyIII/Shared/Mail/RegistrationInterface.php @@ -31,4 +31,4 @@ interface RegistrationInterface */ public function sendVerificationMail(\User $user); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Preferences/Preferences.php b/app/lib/FireflyIII/Shared/Preferences/Preferences.php index 40c4ec35f7..85ab05cbc7 100644 --- a/app/lib/FireflyIII/Shared/Preferences/Preferences.php +++ b/app/lib/FireflyIII/Shared/Preferences/Preferences.php @@ -51,4 +51,4 @@ class Preferences implements PreferencesInterface return $pref; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Preferences/PreferencesInterface.php b/app/lib/FireflyIII/Shared/Preferences/PreferencesInterface.php index 1a3cb217eb..3dd5606235 100644 --- a/app/lib/FireflyIII/Shared/Preferences/PreferencesInterface.php +++ b/app/lib/FireflyIII/Shared/Preferences/PreferencesInterface.php @@ -26,4 +26,4 @@ interface PreferencesInterface */ public function set($name, $value); -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Toolkit/Filter.php b/app/lib/FireflyIII/Shared/Toolkit/Filter.php index 0db6bb5d8a..9be82e313a 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Filter.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Filter.php @@ -266,4 +266,4 @@ class Filter return $date; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Toolkit/Form.php b/app/lib/FireflyIII/Shared/Toolkit/Form.php index 65310b1be4..55457dc7d5 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Form.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Form.php @@ -42,4 +42,4 @@ class Form return $selectList; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php index b9c7db5bde..ce99351190 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Navigation.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Navigation.php @@ -66,4 +66,4 @@ class Navigation return true; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php index f545d4fb73..fe3b40ed9b 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Reminders.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Reminders.php @@ -98,4 +98,4 @@ class Reminders } } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Toolkit/Steam.php b/app/lib/FireflyIII/Shared/Toolkit/Steam.php index b4bd26aa18..4348456b4d 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Steam.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Steam.php @@ -59,4 +59,4 @@ class Steam } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php b/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php index 4b656d2723..544174a1c5 100644 --- a/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php +++ b/app/lib/FireflyIII/Shared/Validation/FireflyValidator.php @@ -26,4 +26,4 @@ class FireflyValidator extends Validator return true; } } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Shared/Validation/ValidationServiceProvider.php b/app/lib/FireflyIII/Shared/Validation/ValidationServiceProvider.php index 96a421aeca..b8bc15ac2b 100644 --- a/app/lib/FireflyIII/Shared/Validation/ValidationServiceProvider.php +++ b/app/lib/FireflyIII/Shared/Validation/ValidationServiceProvider.php @@ -24,4 +24,4 @@ class ValidationServiceProvider extends ServiceProvider public function register() { } -} \ No newline at end of file +} diff --git a/app/models/Account.php b/app/models/Account.php index b811e3d23e..a579ff862e 100644 --- a/app/models/Account.php +++ b/app/models/Account.php @@ -141,4 +141,4 @@ class Account extends Eloquent } -} \ No newline at end of file +} diff --git a/app/models/AccountMeta.php b/app/models/AccountMeta.php index 40314b761a..5a481a2c90 100644 --- a/app/models/AccountMeta.php +++ b/app/models/AccountMeta.php @@ -48,4 +48,4 @@ class AccountMeta extends Eloquent $this->attributes['data'] = json_encode($value); } -} \ No newline at end of file +} diff --git a/app/models/AccountType.php b/app/models/AccountType.php index 2d3f968198..eb3f495e87 100644 --- a/app/models/AccountType.php +++ b/app/models/AccountType.php @@ -22,4 +22,4 @@ class AccountType extends Eloquent { return $this->hasMany('Account'); } -} \ No newline at end of file +} diff --git a/app/models/Bill.php b/app/models/Bill.php index a7f0da04a2..586d1146c1 100644 --- a/app/models/Bill.php +++ b/app/models/Bill.php @@ -114,4 +114,4 @@ class Bill extends Eloquent { return $this->belongsTo('User'); } -} \ No newline at end of file +} diff --git a/app/models/Budget.php b/app/models/Budget.php index f5860dd3cd..83368d9143 100644 --- a/app/models/Budget.php +++ b/app/models/Budget.php @@ -47,4 +47,4 @@ class Budget extends Eloquent return $this->belongsTo('User'); } -} \ No newline at end of file +} diff --git a/app/models/BudgetLimit.php b/app/models/BudgetLimit.php index 93f4665d5d..7c21bb74e9 100644 --- a/app/models/BudgetLimit.php +++ b/app/models/BudgetLimit.php @@ -49,4 +49,4 @@ class BudgetLimit extends Eloquent } -} \ No newline at end of file +} diff --git a/app/models/Category.php b/app/models/Category.php index 4c68e41e65..dab2639a0b 100644 --- a/app/models/Category.php +++ b/app/models/Category.php @@ -46,4 +46,4 @@ class Category extends Eloquent { return $this->belongsTo('User'); } -} \ No newline at end of file +} diff --git a/app/models/Component.php b/app/models/Component.php index 151233d950..e09edbe19b 100644 --- a/app/models/Component.php +++ b/app/models/Component.php @@ -17,4 +17,4 @@ class Component extends Eloquent protected $fillable = ['name', 'user_id','class']; protected $table = 'components'; use ValidatingTrait; -} \ No newline at end of file +} diff --git a/app/models/LimitRepetition.php b/app/models/LimitRepetition.php index 9faa85968d..4d38d9054f 100644 --- a/app/models/LimitRepetition.php +++ b/app/models/LimitRepetition.php @@ -53,4 +53,4 @@ class LimitRepetition extends Eloquent return floatval($sum); } -} \ No newline at end of file +} diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 23b3b703fb..55be709037 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -149,4 +149,4 @@ class PiggyBank extends Eloquent { return $this->morphMany('Reminder', 'remindersable'); } -} \ No newline at end of file +} diff --git a/app/models/PiggybankEvent.php b/app/models/PiggybankEvent.php index b159ab360b..1861c45319 100644 --- a/app/models/PiggybankEvent.php +++ b/app/models/PiggybankEvent.php @@ -39,4 +39,4 @@ class PiggyBankEvent extends Eloquent return $this->belongsTo('TransactionJournal'); } -} \ No newline at end of file +} diff --git a/app/models/PiggybankRepetition.php b/app/models/PiggybankRepetition.php index c3ca79f0e7..a12a5b53a3 100644 --- a/app/models/PiggybankRepetition.php +++ b/app/models/PiggybankRepetition.php @@ -51,4 +51,4 @@ class PiggyBankRepetition extends Eloquent } -} \ No newline at end of file +} diff --git a/app/models/Preference.php b/app/models/Preference.php index d56e0304e3..b3e12a7ec6 100644 --- a/app/models/Preference.php +++ b/app/models/Preference.php @@ -38,4 +38,4 @@ class Preference extends Eloquent return $this->belongsTo('User'); } -} \ No newline at end of file +} diff --git a/app/models/Reminder.php b/app/models/Reminder.php index 372ba5d058..8ea1b8dddb 100644 --- a/app/models/Reminder.php +++ b/app/models/Reminder.php @@ -53,4 +53,4 @@ class Reminder extends Eloquent } -} \ No newline at end of file +} diff --git a/app/models/Transaction.php b/app/models/Transaction.php index 7504215ea6..d641262004 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -111,4 +111,4 @@ class Transaction extends Eloquent { return $this->belongsTo('TransactionJournal'); } -} \ No newline at end of file +} diff --git a/app/models/TransactionCurrency.php b/app/models/TransactionCurrency.php index 8f55b14be6..a72d8168df 100644 --- a/app/models/TransactionCurrency.php +++ b/app/models/TransactionCurrency.php @@ -26,4 +26,4 @@ class TransactionCurrency extends Eloquent return $this->hasMany('TransactionJournal'); } -} \ No newline at end of file +} diff --git a/app/models/TransactionGroup.php b/app/models/TransactionGroup.php index 6e35577046..dea100af17 100644 --- a/app/models/TransactionGroup.php +++ b/app/models/TransactionGroup.php @@ -42,4 +42,4 @@ class TransactionGroup extends Eloquent } -} \ No newline at end of file +} diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index 0cf88ad00d..8d2c86f31c 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -240,4 +240,4 @@ class TransactionJournal extends Eloquent return $this->belongsTo('User'); } -} \ No newline at end of file +} diff --git a/app/models/TransactionRelation.php b/app/models/TransactionRelation.php index b9f93873b3..cd34f354e9 100644 --- a/app/models/TransactionRelation.php +++ b/app/models/TransactionRelation.php @@ -7,4 +7,4 @@ use \Illuminate\Database\Eloquent\Model as Eloquent; class TransactionRelation extends Eloquent { -} \ No newline at end of file +} diff --git a/app/models/TransactionType.php b/app/models/TransactionType.php index 9cd87fb280..3e17b3c407 100644 --- a/app/models/TransactionType.php +++ b/app/models/TransactionType.php @@ -19,4 +19,4 @@ class TransactionType extends Eloquent return $this->hasMany('TransactionJournal'); } -} \ No newline at end of file +} diff --git a/app/models/User.php b/app/models/User.php index 810ac6c25c..a3dc1a47ce 100644 --- a/app/models/User.php +++ b/app/models/User.php @@ -99,4 +99,4 @@ class User extends Eloquent implements UserInterface, RemindableInterface } -} \ No newline at end of file +} diff --git a/app/routes.php b/app/routes.php index 11b3edf0a4..0aa5b61cd5 100644 --- a/app/routes.php +++ b/app/routes.php @@ -381,4 +381,4 @@ Route::group( Route::post('/register', ['uses' => 'UserController@postRegister', 'as' => 'register.post','before' => 'allow-register']); Route::post('/remindMe', ['uses' => 'UserController@postRemindMe', 'as' => 'remindMe.post']); } -); \ No newline at end of file +); diff --git a/app/start/artisan.php b/app/start/artisan.php index 3b223f16ec..8e36314924 100644 --- a/app/start/artisan.php +++ b/app/start/artisan.php @@ -11,4 +11,4 @@ | */ -Artisan::add(new Cleanup); \ No newline at end of file +Artisan::add(new Cleanup); diff --git a/app/start/local.php b/app/start/local.php index 3d14850913..3d9949b800 100644 --- a/app/start/local.php +++ b/app/start/local.php @@ -1,3 +1,3 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/accounts/delete.blade.php b/app/views/accounts/delete.blade.php index 0f60d5298d..017224a1fd 100644 --- a/app/views/accounts/delete.blade.php +++ b/app/views/accounts/delete.blade.php @@ -30,4 +30,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/accounts/edit.blade.php b/app/views/accounts/edit.blade.php index cfa7c3357a..547068fae8 100644 --- a/app/views/accounts/edit.blade.php +++ b/app/views/accounts/edit.blade.php @@ -47,4 +47,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/accounts/index.blade.php b/app/views/accounts/index.blade.php index 5c2416ab00..69fb63340e 100644 --- a/app/views/accounts/index.blade.php +++ b/app/views/accounts/index.blade.php @@ -40,4 +40,4 @@ {{HTML::script('assets/javascript/firefly/accounts.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/accounts/show.blade.php b/app/views/accounts/show.blade.php index b7da493119..87297603f8 100644 --- a/app/views/accounts/show.blade.php +++ b/app/views/accounts/show.blade.php @@ -59,4 +59,4 @@ {{HTML::script('assets/javascript/firefly/gcharts.options.js')}} {{HTML::script('assets/javascript/firefly/gcharts.js')}} {{HTML::script('assets/javascript/firefly/accounts.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/bills/create.blade.php b/app/views/bills/create.blade.php index 823716451d..f2ddc3b828 100644 --- a/app/views/bills/create.blade.php +++ b/app/views/bills/create.blade.php @@ -61,4 +61,4 @@ @section('scripts') {{HTML::script('assets/javascript/tagsinput/bootstrap-tagsinput.min.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/bills/delete.blade.php b/app/views/bills/delete.blade.php index ad312dd11b..801db34b94 100644 --- a/app/views/bills/delete.blade.php +++ b/app/views/bills/delete.blade.php @@ -34,4 +34,4 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/bills/edit.blade.php b/app/views/bills/edit.blade.php index 9e55131576..e68d445918 100644 --- a/app/views/bills/edit.blade.php +++ b/app/views/bills/edit.blade.php @@ -59,4 +59,4 @@ @stop @section('scripts') {{HTML::script('assets/javascript/tagsinput/bootstrap-tagsinput.min.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/bills/index.blade.php b/app/views/bills/index.blade.php index a408c29344..3e1b231ec4 100644 --- a/app/views/bills/index.blade.php +++ b/app/views/bills/index.blade.php @@ -17,4 +17,4 @@ @stop @section('scripts') -@stop \ No newline at end of file +@stop diff --git a/app/views/bills/show.blade.php b/app/views/bills/show.blade.php index 366c0ca667..023b3dd515 100644 --- a/app/views/bills/show.blade.php +++ b/app/views/bills/show.blade.php @@ -114,4 +114,4 @@ {{HTML::script('assets/javascript/firefly/gcharts.js')}} {{HTML::script('assets/javascript/firefly/bills.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/budgets/delete.blade.php b/app/views/budgets/delete.blade.php index fde512aa42..1e8a1a68d7 100644 --- a/app/views/budgets/delete.blade.php +++ b/app/views/budgets/delete.blade.php @@ -34,4 +34,4 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/budgets/income.blade.php b/app/views/budgets/income.blade.php index 803b2ce8d5..713c61a20c 100644 --- a/app/views/budgets/income.blade.php +++ b/app/views/budgets/income.blade.php @@ -18,4 +18,4 @@
    - \ No newline at end of file + diff --git a/app/views/budgets/index.blade.php b/app/views/budgets/index.blade.php index 60aa1d4d03..556a6fc6f1 100644 --- a/app/views/budgets/index.blade.php +++ b/app/views/budgets/index.blade.php @@ -139,4 +139,4 @@ @stop @section('scripts') {{HTML::script('assets/javascript/firefly/budgets.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/budgets/show.blade.php b/app/views/budgets/show.blade.php index 7228e03054..4b4d983082 100644 --- a/app/views/budgets/show.blade.php +++ b/app/views/budgets/show.blade.php @@ -87,4 +87,4 @@ {{HTML::script('assets/javascript/firefly/gcharts.js')}} {{HTML::script('assets/javascript/firefly/budgets.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/categories/delete.blade.php b/app/views/categories/delete.blade.php index 399e2762fd..52d457b457 100644 --- a/app/views/categories/delete.blade.php +++ b/app/views/categories/delete.blade.php @@ -34,4 +34,4 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/categories/edit.blade.php b/app/views/categories/edit.blade.php index 24123a7103..69987b85a6 100644 --- a/app/views/categories/edit.blade.php +++ b/app/views/categories/edit.blade.php @@ -35,4 +35,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/categories/index.blade.php b/app/views/categories/index.blade.php index 8a0a4034b1..e9ed09213e 100644 --- a/app/views/categories/index.blade.php +++ b/app/views/categories/index.blade.php @@ -36,4 +36,4 @@ {{HTML::script('assets/javascript/firefly/gcharts.options.js')}} {{HTML::script('assets/javascript/firefly/gcharts.js')}} {{HTML::script('assets/javascript/firefly/categories.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/categories/show.blade.php b/app/views/categories/show.blade.php index a80f0a9bb5..66e091427d 100644 --- a/app/views/categories/show.blade.php +++ b/app/views/categories/show.blade.php @@ -40,4 +40,4 @@ {{HTML::script('assets/javascript/firefly/gcharts.js')}} {{HTML::script('assets/javascript/firefly/categories.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/currency/create.blade.php b/app/views/currency/create.blade.php index 4ce88ea5a0..1cca5bee88 100644 --- a/app/views/currency/create.blade.php +++ b/app/views/currency/create.blade.php @@ -37,4 +37,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/currency/delete.blade.php b/app/views/currency/delete.blade.php index ea333c6641..8fd0af69aa 100644 --- a/app/views/currency/delete.blade.php +++ b/app/views/currency/delete.blade.php @@ -22,4 +22,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/currency/edit.blade.php b/app/views/currency/edit.blade.php index f9482210b4..246f9d5c9d 100644 --- a/app/views/currency/edit.blade.php +++ b/app/views/currency/edit.blade.php @@ -37,4 +37,4 @@
    {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/currency/index.blade.php b/app/views/currency/index.blade.php index f7f3a09367..fdbe0e66ea 100644 --- a/app/views/currency/index.blade.php +++ b/app/views/currency/index.blade.php @@ -64,4 +64,4 @@
    -@stop \ No newline at end of file +@stop diff --git a/app/views/emails/user/register-html.blade.php b/app/views/emails/user/register-html.blade.php index b130d167a1..e81ca6d95e 100644 --- a/app/views/emails/user/register-html.blade.php +++ b/app/views/emails/user/register-html.blade.php @@ -16,4 +16,4 @@

    - \ No newline at end of file + diff --git a/app/views/emails/user/register-text.blade.php b/app/views/emails/user/register-text.blade.php index 7cfa0e4735..0993031a88 100644 --- a/app/views/emails/user/register-text.blade.php +++ b/app/views/emails/user/register-text.blade.php @@ -2,4 +2,4 @@ Hi! Here's the password you need to login at Firefly: {{$password}} -Cya! \ No newline at end of file +Cya! diff --git a/app/views/emails/user/verify-html.blade.php b/app/views/emails/user/verify-html.blade.php index 961b9c79ac..90b477e351 100644 --- a/app/views/emails/user/verify-html.blade.php +++ b/app/views/emails/user/verify-html.blade.php @@ -16,4 +16,4 @@

    - \ No newline at end of file + diff --git a/app/views/emails/user/verify-text.blade.php b/app/views/emails/user/verify-text.blade.php index 5b82b79d99..27f1d553a0 100644 --- a/app/views/emails/user/verify-text.blade.php +++ b/app/views/emails/user/verify-text.blade.php @@ -4,4 +4,4 @@ To verify your registration, please verify your e-mail address: {{route('reset',$reset)}} -Cya! \ No newline at end of file +Cya! diff --git a/app/views/error.blade.php b/app/views/error.blade.php index 27aff067df..4140018572 100644 --- a/app/views/error.blade.php +++ b/app/views/error.blade.php @@ -13,4 +13,4 @@ {{$message or 'General unknown errror'}}
    -@stop \ No newline at end of file +@stop diff --git a/app/views/index.blade.php b/app/views/index.blade.php index d27739d9bd..68bf2afa13 100644 --- a/app/views/index.blade.php +++ b/app/views/index.blade.php @@ -126,4 +126,4 @@ {{HTML::script('assets/javascript/firefly/index.js')}} @stop @section('styles') -@stop \ No newline at end of file +@stop diff --git a/app/views/layouts/default.blade.php b/app/views/layouts/default.blade.php index ffad378639..17595c0643 100644 --- a/app/views/layouts/default.blade.php +++ b/app/views/layouts/default.blade.php @@ -93,4 +93,4 @@ {{HTML::script('assets/javascript/firefly/help.js')}} @yield('scripts') - \ No newline at end of file + diff --git a/app/views/layouts/guest.blade.php b/app/views/layouts/guest.blade.php index 85966199ce..6b5a7d023b 100644 --- a/app/views/layouts/guest.blade.php +++ b/app/views/layouts/guest.blade.php @@ -27,4 +27,4 @@ @yield('content')
    - \ No newline at end of file + diff --git a/app/views/list/accounts.blade.php b/app/views/list/accounts.blade.php index b7976d4df3..4ccf4f36eb 100644 --- a/app/views/list/accounts.blade.php +++ b/app/views/list/accounts.blade.php @@ -35,4 +35,4 @@ @endforeach - \ No newline at end of file + diff --git a/app/views/list/bills.blade.php b/app/views/list/bills.blade.php index 1e4839a20a..70c7989d84 100644 --- a/app/views/list/bills.blade.php +++ b/app/views/list/bills.blade.php @@ -70,4 +70,4 @@ @endforeach - \ No newline at end of file + diff --git a/app/views/list/categories.blade.php b/app/views/list/categories.blade.php index 6cfdb19eb2..29e6d7e27f 100644 --- a/app/views/list/categories.blade.php +++ b/app/views/list/categories.blade.php @@ -25,4 +25,4 @@ @endforeach - \ No newline at end of file + diff --git a/app/views/list/journals-full.blade.php b/app/views/list/journals-full.blade.php index c97a4ca210..e5982e24ae 100644 --- a/app/views/list/journals-full.blade.php +++ b/app/views/list/journals-full.blade.php @@ -117,4 +117,4 @@ @if(is_object($journals) && method_exists($journals, 'links')) {{$journals->links()}} -@endif \ No newline at end of file +@endif diff --git a/app/views/list/journals-small.blade.php b/app/views/list/journals-small.blade.php index 5643db3ad0..113b4224a7 100644 --- a/app/views/list/journals-small.blade.php +++ b/app/views/list/journals-small.blade.php @@ -37,4 +37,4 @@ @endif - \ No newline at end of file + diff --git a/app/views/list/journals-tiny.blade.php b/app/views/list/journals-tiny.blade.php index ff369db70c..c4380ca00c 100644 --- a/app/views/list/journals-tiny.blade.php +++ b/app/views/list/journals-tiny.blade.php @@ -32,4 +32,4 @@ @endforeach -
    \ No newline at end of file +
    diff --git a/app/views/list/piggy-bank-events.blade.php b/app/views/list/piggy-bank-events.blade.php index 9dad0362c7..bbd39d9798 100644 --- a/app/views/list/piggy-bank-events.blade.php +++ b/app/views/list/piggy-bank-events.blade.php @@ -30,4 +30,4 @@ @endforeach - \ No newline at end of file + diff --git a/app/views/partials/date_nav.blade.php b/app/views/partials/date_nav.blade.php index 7cce808a0d..1230471443 100644 --- a/app/views/partials/date_nav.blade.php +++ b/app/views/partials/date_nav.blade.php @@ -25,4 +25,4 @@ {{{\Session::get('next')}}}
    - \ No newline at end of file + diff --git a/app/views/partials/flashes.blade.php b/app/views/partials/flashes.blade.php index e9d28fd3a2..e97d346de0 100644 --- a/app/views/partials/flashes.blade.php +++ b/app/views/partials/flashes.blade.php @@ -24,4 +24,4 @@ Error! {{{Session::get('error')}}} -@endif \ No newline at end of file +@endif diff --git a/app/views/piggy_banks/add.blade.php b/app/views/piggy_banks/add.blade.php index 7dddbeb4b2..f9680880e7 100644 --- a/app/views/piggy_banks/add.blade.php +++ b/app/views/piggy_banks/add.blade.php @@ -21,4 +21,4 @@ - \ No newline at end of file + diff --git a/app/views/piggy_banks/delete.blade.php b/app/views/piggy_banks/delete.blade.php index 6943692500..790ee835bd 100644 --- a/app/views/piggy_banks/delete.blade.php +++ b/app/views/piggy_banks/delete.blade.php @@ -34,4 +34,4 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/piggy_banks/index.blade.php b/app/views/piggy_banks/index.blade.php index 5c99d9951e..ea6009201d 100644 --- a/app/views/piggy_banks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -129,4 +129,4 @@ @stop @section('scripts') {{HTML::script('assets/javascript/firefly/piggy_banks.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/piggy_banks/remove.blade.php b/app/views/piggy_banks/remove.blade.php index 09e3c1f1bb..4d157a8287 100644 --- a/app/views/piggy_banks/remove.blade.php +++ b/app/views/piggy_banks/remove.blade.php @@ -21,4 +21,4 @@ - \ No newline at end of file + diff --git a/app/views/preferences/index.blade.php b/app/views/preferences/index.blade.php index d57aa6636b..9a567a97e1 100644 --- a/app/views/preferences/index.blade.php +++ b/app/views/preferences/index.blade.php @@ -102,4 +102,4 @@ @stop @section('scripts') -@stop \ No newline at end of file +@stop diff --git a/app/views/profile/change-password.blade.php b/app/views/profile/change-password.blade.php index 8cbcc0f8f9..3b15e68988 100644 --- a/app/views/profile/change-password.blade.php +++ b/app/views/profile/change-password.blade.php @@ -41,4 +41,4 @@ @stop @section('scripts') -@stop \ No newline at end of file +@stop diff --git a/app/views/profile/index.blade.php b/app/views/profile/index.blade.php index 14abe537dd..ef0440ffd5 100644 --- a/app/views/profile/index.blade.php +++ b/app/views/profile/index.blade.php @@ -15,4 +15,4 @@ @stop @section('scripts') -@stop \ No newline at end of file +@stop diff --git a/app/views/reminders/show.blade.php b/app/views/reminders/show.blade.php index 115c9aaf24..76cdd56b23 100644 --- a/app/views/reminders/show.blade.php +++ b/app/views/reminders/show.blade.php @@ -29,4 +29,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/repeatedExpense/delete.blade.php b/app/views/repeatedExpense/delete.blade.php index 0c1e15277b..518278e74a 100644 --- a/app/views/repeatedExpense/delete.blade.php +++ b/app/views/repeatedExpense/delete.blade.php @@ -34,4 +34,4 @@ {{Form::close()}} -@stop \ No newline at end of file +@stop diff --git a/app/views/repeatedExpense/index.blade.php b/app/views/repeatedExpense/index.blade.php index 496107e0bf..e8167c42b6 100644 --- a/app/views/repeatedExpense/index.blade.php +++ b/app/views/repeatedExpense/index.blade.php @@ -67,4 +67,4 @@ @stop @section('scripts') -@stop \ No newline at end of file +@stop diff --git a/app/views/repeatedExpense/show.blade.php b/app/views/repeatedExpense/show.blade.php index bce4474181..bc3e5154fa 100644 --- a/app/views/repeatedExpense/show.blade.php +++ b/app/views/repeatedExpense/show.blade.php @@ -58,4 +58,4 @@ @endforeach -@stop \ No newline at end of file +@stop diff --git a/app/views/reports/budget.blade.php b/app/views/reports/budget.blade.php index 86b15e7123..52f64e6a61 100644 --- a/app/views/reports/budget.blade.php +++ b/app/views/reports/budget.blade.php @@ -153,4 +153,4 @@ @stop @section('scripts') {{HTML::script('assets/javascript/firefly/reports.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/reports/index.blade.php b/app/views/reports/index.blade.php index 80e6180f36..75980f7376 100644 --- a/app/views/reports/index.blade.php +++ b/app/views/reports/index.blade.php @@ -47,4 +47,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 30366bcee5..9699f02ea0 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -194,4 +194,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/reports/year.blade.php b/app/views/reports/year.blade.php index e7fc7c5d7a..10a332bf67 100644 --- a/app/views/reports/year.blade.php +++ b/app/views/reports/year.blade.php @@ -161,4 +161,4 @@ var currencyCode = '{{getCurrencyCode()}}'; {{HTML::script('assets/javascript/firefly/reports.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/search/index.blade.php b/app/views/search/index.blade.php index d1431ebe73..c6f6f16a4b 100644 --- a/app/views/search/index.blade.php +++ b/app/views/search/index.blade.php @@ -103,4 +103,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/transactions/create.blade.php b/app/views/transactions/create.blade.php index 5cb557e1fa..5585ddb4c6 100644 --- a/app/views/transactions/create.blade.php +++ b/app/views/transactions/create.blade.php @@ -93,4 +93,4 @@ @section('scripts') {{HTML::script('assets/javascript/typeahead/bootstrap3-typeahead.min.js')}} {{HTML::script('assets/javascript/firefly/transactions.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/transactions/edit.blade.php b/app/views/transactions/edit.blade.php index 03f79385e7..0b60dd357e 100644 --- a/app/views/transactions/edit.blade.php +++ b/app/views/transactions/edit.blade.php @@ -93,4 +93,4 @@ @section('scripts') {{HTML::script('assets/javascript/typeahead/bootstrap3-typeahead.min.js')}} {{HTML::script('assets/javascript/firefly/transactions.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/transactions/show.blade.php b/app/views/transactions/show.blade.php index 8443184239..a6b7446b21 100644 --- a/app/views/transactions/show.blade.php +++ b/app/views/transactions/show.blade.php @@ -128,4 +128,4 @@ @section('scripts') {{HTML::script('assets/javascript/firefly/transactions.js')}} {{HTML::script('assets/javascript/firefly/related-manager.js')}} -@stop \ No newline at end of file +@stop diff --git a/app/views/user/login.blade.php b/app/views/user/login.blade.php index 4f7e8a678e..a2efbcfa9e 100644 --- a/app/views/user/login.blade.php +++ b/app/views/user/login.blade.php @@ -36,4 +36,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/user/register.blade.php b/app/views/user/register.blade.php index 6fbc49a849..a7a11f07fc 100644 --- a/app/views/user/register.blade.php +++ b/app/views/user/register.blade.php @@ -30,4 +30,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/user/registered.blade.php b/app/views/user/registered.blade.php index 3724140e4e..ce4e3e056e 100644 --- a/app/views/user/registered.blade.php +++ b/app/views/user/registered.blade.php @@ -16,4 +16,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/user/remindMe-html.blade.php b/app/views/user/remindMe-html.blade.php index e16c85fafe..16f09cc04d 100644 --- a/app/views/user/remindMe-html.blade.php +++ b/app/views/user/remindMe-html.blade.php @@ -16,4 +16,4 @@

    - \ No newline at end of file + diff --git a/app/views/user/remindMe.blade.php b/app/views/user/remindMe.blade.php index fcf0f179a3..18b48954ac 100644 --- a/app/views/user/remindMe.blade.php +++ b/app/views/user/remindMe.blade.php @@ -24,4 +24,4 @@ -@stop \ No newline at end of file +@stop diff --git a/app/views/user/verification-pending.blade.php b/app/views/user/verification-pending.blade.php index 7e224b82ef..a10b2d53da 100644 --- a/app/views/user/verification-pending.blade.php +++ b/app/views/user/verification-pending.blade.php @@ -16,4 +16,4 @@ -@stop \ No newline at end of file +@stop diff --git a/bootstrap/functions.php b/bootstrap/functions.php index 2424d07741..69c13d834b 100644 --- a/bootstrap/functions.php +++ b/bootstrap/functions.php @@ -163,4 +163,4 @@ if (!function_exists('boolstr')) { return 'NO BOOLEAN: ' . $boolean; } -} \ No newline at end of file +} diff --git a/tests/functional/AccountControllerCest.php b/tests/functional/AccountControllerCest.php index 6577b9ef6d..35ea055806 100644 --- a/tests/functional/AccountControllerCest.php +++ b/tests/functional/AccountControllerCest.php @@ -197,4 +197,4 @@ class AccountControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/BillControllerCest.php b/tests/functional/BillControllerCest.php index 05f9c270a5..5347420f5a 100644 --- a/tests/functional/BillControllerCest.php +++ b/tests/functional/BillControllerCest.php @@ -273,4 +273,4 @@ class BillControllerCest $I->see('Bill "Some bill" updated.'); } -} \ No newline at end of file +} diff --git a/tests/functional/BudgetControllerCest.php b/tests/functional/BudgetControllerCest.php index 79400e7f9a..a81c7e0b33 100644 --- a/tests/functional/BudgetControllerCest.php +++ b/tests/functional/BudgetControllerCest.php @@ -239,4 +239,4 @@ class BudgetControllerCest $I->seeRecord('budgets', ['name' => 'Delete me']); } -} \ No newline at end of file +} diff --git a/tests/functional/CategoryControllerCest.php b/tests/functional/CategoryControllerCest.php index d3452276a0..3a7b5d10ba 100644 --- a/tests/functional/CategoryControllerCest.php +++ b/tests/functional/CategoryControllerCest.php @@ -189,4 +189,4 @@ class CategoryControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/CurrencyControllerCest.php b/tests/functional/CurrencyControllerCest.php index b8b9ed7845..168fffc5cb 100644 --- a/tests/functional/CurrencyControllerCest.php +++ b/tests/functional/CurrencyControllerCest.php @@ -199,4 +199,4 @@ class CurrencyControllerCest $I->seeRecord('transaction_currencies', ['name' => 'US Dollar']); } -} \ No newline at end of file +} diff --git a/tests/functional/GoogleChartControllerCest.php b/tests/functional/GoogleChartControllerCest.php index 274da2e0de..578204b153 100644 --- a/tests/functional/GoogleChartControllerCest.php +++ b/tests/functional/GoogleChartControllerCest.php @@ -210,4 +210,4 @@ class GoogleChartControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/HelpControllerCest.php b/tests/functional/HelpControllerCest.php index 8f4cbac78c..a8bb6c2d66 100644 --- a/tests/functional/HelpControllerCest.php +++ b/tests/functional/HelpControllerCest.php @@ -86,4 +86,4 @@ class HelpControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/HomeControllerCest.php b/tests/functional/HomeControllerCest.php index 4b138831de..176351aa98 100644 --- a/tests/functional/HomeControllerCest.php +++ b/tests/functional/HomeControllerCest.php @@ -94,4 +94,4 @@ class HomeControllerCest $I->amOnPage('/prev'); $I->canSeeResponseCodeIs(200); } -} \ No newline at end of file +} diff --git a/tests/functional/JsonControllerCest.php b/tests/functional/JsonControllerCest.php index 6aee764604..907d6cf724 100644 --- a/tests/functional/JsonControllerCest.php +++ b/tests/functional/JsonControllerCest.php @@ -53,4 +53,4 @@ class JsonControllerCest $I->amOnPage('/json/revenue-accounts'); $I->canSeeResponseCodeIs(200); } -} \ No newline at end of file +} diff --git a/tests/functional/PiggyBankControllerCest.php b/tests/functional/PiggyBankControllerCest.php index 0b717f639b..fc00a93005 100644 --- a/tests/functional/PiggyBankControllerCest.php +++ b/tests/functional/PiggyBankControllerCest.php @@ -329,4 +329,4 @@ class PiggyBankControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/PreferencesControllerCest.php b/tests/functional/PreferencesControllerCest.php index 8149780db8..44080b93d6 100644 --- a/tests/functional/PreferencesControllerCest.php +++ b/tests/functional/PreferencesControllerCest.php @@ -45,4 +45,4 @@ class PreferencesControllerCest $I->submitForm('#preferences', []); $I->see('Preferences saved!'); } -} \ No newline at end of file +} diff --git a/tests/functional/ProfileControllerCest.php b/tests/functional/ProfileControllerCest.php index cb79784cbc..7f6c980d20 100644 --- a/tests/functional/ProfileControllerCest.php +++ b/tests/functional/ProfileControllerCest.php @@ -147,4 +147,4 @@ class ProfileControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php index 41d2bac3c6..01901b2cb5 100644 --- a/tests/functional/ReminderControllerCest.php +++ b/tests/functional/ReminderControllerCest.php @@ -83,4 +83,4 @@ class ReminderControllerCest $I->see('your piggy bank labelled "Nieuwe spullen"'); } -} \ No newline at end of file +} diff --git a/tests/functional/RepeatedExpenseControllerCest.php b/tests/functional/RepeatedExpenseControllerCest.php index 38069520cc..58d2392ee2 100644 --- a/tests/functional/RepeatedExpenseControllerCest.php +++ b/tests/functional/RepeatedExpenseControllerCest.php @@ -241,4 +241,4 @@ class RepeatedExpenseControllerCest ); $I->see('The name field is required.'); } -} \ No newline at end of file +} diff --git a/tests/functional/ReportControllerCest.php b/tests/functional/ReportControllerCest.php index 6d2ff144b0..cd1a546a19 100644 --- a/tests/functional/ReportControllerCest.php +++ b/tests/functional/ReportControllerCest.php @@ -76,4 +76,4 @@ class ReportControllerCest $I->see('Invalid date'); } -} \ No newline at end of file +} diff --git a/tests/functional/SearchControllerCest.php b/tests/functional/SearchControllerCest.php index 973b2c54ab..8b8341f59b 100644 --- a/tests/functional/SearchControllerCest.php +++ b/tests/functional/SearchControllerCest.php @@ -36,4 +36,4 @@ class SearchControllerCest $I->see('Search for ""'); } -} \ No newline at end of file +} diff --git a/tests/functional/TransactionControllerCest.php b/tests/functional/TransactionControllerCest.php index 7049228904..54e337305b 100644 --- a/tests/functional/TransactionControllerCest.php +++ b/tests/functional/TransactionControllerCest.php @@ -232,4 +232,4 @@ class TransactionControllerCest } -} \ No newline at end of file +} diff --git a/tests/functional/UserControllerCest.php b/tests/functional/UserControllerCest.php index d04dfcccd1..a9a5141632 100644 --- a/tests/functional/UserControllerCest.php +++ b/tests/functional/UserControllerCest.php @@ -147,4 +147,4 @@ class UserControllerCest $I->see('You\'re about to get an e-mail.'); } -} \ No newline at end of file +} diff --git a/tests/functional/_bootstrap.php b/tests/functional/_bootstrap.php index c25406adad..e489e45b9e 100644 --- a/tests/functional/_bootstrap.php +++ b/tests/functional/_bootstrap.php @@ -5,4 +5,4 @@ if (!file_exists($db)) { exec('touch ' . $db); exec('php artisan migrate --seed --env=testing', $out); exec('sqlite3 tests/_data/db.sqlite .dump > tests/_data/dump.sql', $out); -} \ No newline at end of file +} diff --git a/tests/unit/AccountTest.php b/tests/unit/AccountTest.php index 5ffff946c7..16145d8932 100644 --- a/tests/unit/AccountTest.php +++ b/tests/unit/AccountTest.php @@ -37,4 +37,4 @@ class AccountTest extends TestCase $this->assertInstanceOf('User', $account->user); } -} \ No newline at end of file +} diff --git a/tests/unit/AccountTypeTest.php b/tests/unit/AccountTypeTest.php index c0d29759ed..94aede8b6a 100644 --- a/tests/unit/AccountTypeTest.php +++ b/tests/unit/AccountTypeTest.php @@ -24,4 +24,4 @@ class AccountTypeTest extends TestCase $this->assertCount(1, $account->accountType()->first()->accounts()->get()); } -} \ No newline at end of file +} diff --git a/tests/unit/BudgetTest.php b/tests/unit/BudgetTest.php index bbe67da42c..88321ee974 100644 --- a/tests/unit/BudgetTest.php +++ b/tests/unit/BudgetTest.php @@ -23,4 +23,4 @@ class BudgetTest extends TestCase $this->assertInstanceOf('User', $budget->user); } -} \ No newline at end of file +} diff --git a/tests/unit/PiggyBankRepetitionTest.php b/tests/unit/PiggyBankRepetitionTest.php index 0d889aad31..3bf35313e6 100644 --- a/tests/unit/PiggyBankRepetitionTest.php +++ b/tests/unit/PiggyBankRepetitionTest.php @@ -26,4 +26,4 @@ class PiggyBankRepetitionTest extends TestCase $this->assertCount(1, PiggyBankRepetition::starts($start)->get()); $this->assertCount(1, PiggyBankRepetition::targets($target)->get()); } -} \ No newline at end of file +} diff --git a/tests/unit/PiggyBankTest.php b/tests/unit/PiggyBankTest.php index 4b9a4f617d..efe7210cc0 100644 --- a/tests/unit/PiggyBankTest.php +++ b/tests/unit/PiggyBankTest.php @@ -24,4 +24,4 @@ class PiggyBankTest extends TestCase $piggyBank->reminders()->save($reminder); $this->assertCount(1, $piggyBank->reminders()->get()); } -} \ No newline at end of file +} diff --git a/tests/unit/ReminderTest.php b/tests/unit/ReminderTest.php index 3801b4aebe..6a792ff9c4 100644 --- a/tests/unit/ReminderTest.php +++ b/tests/unit/ReminderTest.php @@ -35,4 +35,4 @@ class ReminderTest extends TestCase $this->assertEquals($reminder->user->id, $user->id); } -} \ No newline at end of file +} diff --git a/tests/unit/TransactionGroupTest.php b/tests/unit/TransactionGroupTest.php index f6439a7638..9c3b72272b 100644 --- a/tests/unit/TransactionGroupTest.php +++ b/tests/unit/TransactionGroupTest.php @@ -22,4 +22,4 @@ class TransactionGroupTest extends TestCase $group = f::create('TransactionGroup'); $this->assertEquals($group->user_id, $group->user->id); } -} \ No newline at end of file +} diff --git a/tests/unit/TransactionJournalTest.php b/tests/unit/TransactionJournalTest.php index c6f4f42c19..863c87cff8 100644 --- a/tests/unit/TransactionJournalTest.php +++ b/tests/unit/TransactionJournalTest.php @@ -30,4 +30,4 @@ class TransactionJournalTest extends TestCase $this->assertCount(1, TransactionJournal::moreThan($amount)->get()); } -} \ No newline at end of file +} diff --git a/tests/unit/TransactionTest.php b/tests/unit/TransactionTest.php index b571dccbb2..f154d5130e 100644 --- a/tests/unit/TransactionTest.php +++ b/tests/unit/TransactionTest.php @@ -64,4 +64,4 @@ class TransactionTest extends TestCase $type = $transaction->transactionJournal->transactionType->type; $this->assertCount(1, Transaction::transactionTypes([$type])->get()); } -} \ No newline at end of file +} diff --git a/tests/unit/TransactionTypeTest.php b/tests/unit/TransactionTypeTest.php index c0feba77b5..d2b4033d69 100644 --- a/tests/unit/TransactionTypeTest.php +++ b/tests/unit/TransactionTypeTest.php @@ -27,4 +27,4 @@ class TransactionTypeTest extends TestCase } -} \ No newline at end of file +} diff --git a/tests/unit/UserTest.php b/tests/unit/UserTest.php index 86ad425bd6..8a1b60a65f 100644 --- a/tests/unit/UserTest.php +++ b/tests/unit/UserTest.php @@ -31,4 +31,4 @@ class UserTest extends TestCase $this->assertEquals($reminder->user_id, $reminder->user->id); } -} \ No newline at end of file +} From 45aa85d690b6684257868e80716161378a2b4673 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:24:48 +0100 Subject: [PATCH 74/84] Added new lines [skip ci] --- .coveralls.yml | 2 +- .gitignore | 1 - .travis.yml | 2 +- README.md | 2 +- app/config/.gitignore | 2 +- app/lib/FireflyIII/Report/Report.php | 2 +- app/storage/.gitignore | 2 +- app/storage/cache/.gitignore | 2 +- app/storage/debugbar/.gitignore | 2 +- app/storage/logs/.gitignore | 2 +- app/storage/meta/.gitignore | 2 +- app/storage/sessions/.gitignore | 2 +- app/storage/views/.gitignore | 2 +- codeception.yml | 2 +- provider/assets/stylesheets/readme.txt | 2 +- tests/acceptance.suite.yml | 2 +- tests/functional.suite.yml | 2 +- 17 files changed, 16 insertions(+), 17 deletions(-) diff --git a/.coveralls.yml b/.coveralls.yml index 68c3d23770..8951ac7b73 100644 --- a/.coveralls.yml +++ b/.coveralls.yml @@ -1,3 +1,3 @@ src_dir: . coverage_clover: tests/_output/coverage.xml -json_path: tests/_output/coveralls-upload.json \ No newline at end of file +json_path: tests/_output/coveralls-upload.json diff --git a/.gitignore b/.gitignore index ccc58cf470..0ca3cc6632 100644 --- a/.gitignore +++ b/.gitignore @@ -3,7 +3,6 @@ composer.phar .env.*.php .env.php -.DS_Store Thumbs.db .idea/ tests/_output/* diff --git a/.travis.yml b/.travis.yml index 7638995c02..1f82f07b02 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,4 +13,4 @@ script: - php vendor/bin/codecept run --coverage --coverage-xml after_script: - - php vendor/bin/coveralls \ No newline at end of file + - php vendor/bin/coveralls diff --git a/README.md b/README.md index 25c2f0d92b..e61b574ee0 100644 --- a/README.md +++ b/README.md @@ -70,4 +70,4 @@ I have the basics up and running. Test coverage is currently coming, slowly. Although I have not checked extensively, some forms and views have CSRF vulnerabilities. This is because not all views escape all characters by default. Will be fixed. -Questions, ideas or other things to contribute? [Let me know](https://github.com/JC5/firefly-iii/issues/new)! \ No newline at end of file +Questions, ideas or other things to contribute? [Let me know](https://github.com/JC5/firefly-iii/issues/new)! diff --git a/app/config/.gitignore b/app/config/.gitignore index 8205aab29b..10601ce198 100644 --- a/app/config/.gitignore +++ b/app/config/.gitignore @@ -1,4 +1,4 @@ local/ laptop/ vagrant/ -production/ \ No newline at end of file +production/ diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index dd396b6cc8..3b012bcc1c 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -295,7 +295,7 @@ class Report implements ReportInterface $end = clone $date; $end->endOfMonth(); - $set = \PiggyBank:: + \PiggyBank:: leftJoin('accounts', 'accounts.id', '=', 'piggy_banks.account_id') ->where('accounts.user_id', \Auth::user()->id) ->where('repeats', 0) diff --git a/app/storage/.gitignore b/app/storage/.gitignore index 35b719c69a..2fe64d84cc 100644 --- a/app/storage/.gitignore +++ b/app/storage/.gitignore @@ -1 +1 @@ -services.manifest \ No newline at end of file +services.manifest diff --git a/app/storage/cache/.gitignore b/app/storage/cache/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/cache/.gitignore +++ b/app/storage/cache/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/app/storage/debugbar/.gitignore b/app/storage/debugbar/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/debugbar/.gitignore +++ b/app/storage/debugbar/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/app/storage/logs/.gitignore b/app/storage/logs/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/logs/.gitignore +++ b/app/storage/logs/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/app/storage/meta/.gitignore b/app/storage/meta/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/meta/.gitignore +++ b/app/storage/meta/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/app/storage/sessions/.gitignore b/app/storage/sessions/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/sessions/.gitignore +++ b/app/storage/sessions/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/app/storage/views/.gitignore b/app/storage/views/.gitignore index c96a04f008..d6b7ef32c8 100644 --- a/app/storage/views/.gitignore +++ b/app/storage/views/.gitignore @@ -1,2 +1,2 @@ * -!.gitignore \ No newline at end of file +!.gitignore diff --git a/codeception.yml b/codeception.yml index c8dc7c62e3..1c64b071f9 100644 --- a/codeception.yml +++ b/codeception.yml @@ -19,4 +19,4 @@ coverage: - app/models/* - app/lib/FireflyIII/* exclude: - - app/controllers/BaseController.php \ No newline at end of file + - app/controllers/BaseController.php diff --git a/provider/assets/stylesheets/readme.txt b/provider/assets/stylesheets/readme.txt index d8f094f58d..cd3d23335f 100644 --- a/provider/assets/stylesheets/readme.txt +++ b/provider/assets/stylesheets/readme.txt @@ -1 +1 @@ -No vendor/provider stylesheets here at the moment. But this is where you could put things like twitter bootstrap, gumby, font awesome... \ No newline at end of file +No vendor/provider stylesheets here at the moment. But this is where you could put things like twitter bootstrap, gumby, font awesome... diff --git a/tests/acceptance.suite.yml b/tests/acceptance.suite.yml index 407ab416ff..601e703cd6 100644 --- a/tests/acceptance.suite.yml +++ b/tests/acceptance.suite.yml @@ -7,4 +7,4 @@ class_name: AcceptanceTester modules: enabled: - - AcceptanceHelper \ No newline at end of file + - AcceptanceHelper diff --git a/tests/functional.suite.yml b/tests/functional.suite.yml index db06c29796..d3effb537d 100644 --- a/tests/functional.suite.yml +++ b/tests/functional.suite.yml @@ -17,4 +17,4 @@ modules: dump: tests/_data/dump.sql Laravel4: environment: 'testing' - filters: false \ No newline at end of file + filters: false From da056092fb979fef330cca6c9d7f2ab9650200b2 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:26:04 +0100 Subject: [PATCH 75/84] Code cleanup [skip ci] --- composer.lock | 2 +- phpunit.xml | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/composer.lock b/composer.lock index e419de84ae..0cd57619c0 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", "This file is @generated automatically" ], - "hash": "3ac71ef711586f9c2bf7c36482284a13", + "hash": "0d6a322d9bcdb03029984f771d36f10f", "packages": [ { "name": "classpreloader/classpreloader", diff --git a/phpunit.xml b/phpunit.xml index e7253a467b..82d93aac97 100644 --- a/phpunit.xml +++ b/phpunit.xml @@ -37,5 +37,8 @@ ./app/tests/ + + ./tests/unit/ + From 0b2d423c87c4a4842350847b64b4a4f81a692f10 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 06:26:57 +0100 Subject: [PATCH 76/84] Updated ignore file. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0ca3cc6632..4224919aae 100644 --- a/.gitignore +++ b/.gitignore @@ -23,3 +23,4 @@ pi.php tests/_data/db.sqlite tests/_data/dump.sql db.sqlite_snapshot +c3.php From 65ce277a201099c788c2ffa83ed63d44fa313f69 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 08:59:16 +0100 Subject: [PATCH 77/84] Updated models [skip ci] --- app/models/Account.php | 12 +++++++----- app/models/Piggybank.php | 14 ++++++-------- app/models/PiggybankRepetition.php | 10 +++++----- app/models/Transaction.php | 2 +- app/models/TransactionJournal.php | 14 +++++++------- 5 files changed, 26 insertions(+), 26 deletions(-) diff --git a/app/models/Account.php b/app/models/Account.php index a579ff862e..667aae069e 100644 --- a/app/models/Account.php +++ b/app/models/Account.php @@ -1,8 +1,10 @@ joinedAccountTypes)) { $query->leftJoin('account_types', 'account_types.id', '=', 'accounts.account_type_id'); @@ -78,9 +80,9 @@ class Account extends Eloquent /** * - * @param Builder $query + * @param EloquentBuilder $query */ - public function scopeWithMeta(Builder $query) + public function scopeWithMeta(EloquentBuilder $query) { $query->with(['accountmeta']); } diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 55be709037..c3ba7e0054 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -3,7 +3,7 @@ use Carbon\Carbon; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Database\Eloquent\SoftDeletingTrait; use Watson\Validating\ValidatingTrait; -use Illuminate\Database\Eloquent\Builder; +use Illuminate\Database\Eloquent\Builder as EloquentBuilder; /** * Class PiggyBank @@ -73,24 +73,23 @@ class PiggyBank extends Eloquent if ($this->repeats == 0) { $rep = $this->piggyBankRepetitions()->first(['piggy_bank_repetitions.*']); $this->currentRep = $rep; - \Log::debug('currentRelevantRep() reports $rep is null: ' . boolstr(is_null($rep))); return $rep; } else { $query = $this->piggyBankRepetitions()->where( - function (Builder $q) { + function (EloquentBuilder $q) { $q->where( - function (Builder $q) { + function (EloquentBuilder $q) { $q->where( - function (Builder $q) { + function (EloquentBuilder $q) { $today = new Carbon; $q->whereNull('startdate'); $q->orWhere('startdate', '<=', $today->format('Y-m-d 00:00:00')); } )->where( - function (Builder $q) { + function (EloquentBuilder $q) { $today = new Carbon; $q->whereNull('targetdate'); $q->orWhere('targetdate', '>=', $today->format('Y-m-d 00:00:00')); @@ -98,7 +97,7 @@ class PiggyBank extends Eloquent ); } )->orWhere( - function (Builder $q) { + function (EloquentBuilder $q) { $today = new Carbon; $q->where('startdate', '>=', $today->format('Y-m-d 00:00:00')); $q->where('targetdate', '>=', $today->format('Y-m-d 00:00:00')); @@ -108,7 +107,6 @@ class PiggyBank extends Eloquent } )->orderBy('startdate', 'ASC'); $result = $query->first(['piggy_bank_repetitions.*']); - \Log::debug('Result is null: ' . boolstr(is_null($result))); $this->currentRep = $result; \Log::debug('Found relevant rep in currentRelevantRep(): ' . $result->id); diff --git a/app/models/PiggybankRepetition.php b/app/models/PiggybankRepetition.php index a12a5b53a3..e38eabd4b4 100644 --- a/app/models/PiggybankRepetition.php +++ b/app/models/PiggybankRepetition.php @@ -1,6 +1,6 @@ where('startdate', $date->format('Y-m-d 00:00:00')); } /** - * @param Builder $query + * @param EloquentBuilder $query * @param Carbon $date */ - public function scopeTargets(Builder $query, Carbon $date) + public function scopeTargets(EloquentBuilder $query, Carbon $date) { $query->where('targetdate', $date->format('Y-m-d 00:00:00')); } diff --git a/app/models/Transaction.php b/app/models/Transaction.php index d641262004..c4a77ee917 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -1,7 +1,7 @@ joinedTransactions)) { $query->leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id'); @@ -129,7 +129,7 @@ class TransactionJournal extends Eloquent * @param Builder $query * @param $amount */ - public function scopeLessThan(Builder $query, $amount) + public function scopeLessThan($query, $amount) { if (is_null($this->joinedTransactions)) { $query->leftJoin( @@ -145,7 +145,7 @@ class TransactionJournal extends Eloquent * @param Builder $query * @param $amount */ - public function scopeMoreThan(Builder $query, $amount) + public function scopeMoreThan($query, $amount) { if (is_null($this->joinedTransactions)) { $query->leftJoin( @@ -172,7 +172,7 @@ class TransactionJournal extends Eloquent * @param Builder $query * @param array $types */ - public function scopeTransactionTypes(Builder $query, array $types) + public function scopeTransactionTypes($query, array $types) { if (is_null($this->joinedTransactionTypes)) { $query->leftJoin( @@ -189,10 +189,10 @@ class TransactionJournal extends Eloquent * * @param $query */ - public function scopeWithRelevantData(Builder $query) + public function scopeWithRelevantData($query) { $query->with( - ['transactions' => function (Builder $q) { + ['transactions' => function (HasMany $q) { $q->orderBy('amount', 'ASC'); }, 'transactiontype', 'budgets','categories', 'transactions.account.accounttype', 'bill', 'budgets', 'categories'] ); From a6dbd912c6d7e9a1a8d299634e90131e94834a4d Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 09:06:44 +0100 Subject: [PATCH 78/84] Code cleanup. --- README.md | 1 + app/controllers/PiggybankController.php | 8 +- app/controllers/TransactionController.php | 4 +- .../FireflyIII/Database/Account/Account.php | 17 +- app/lib/FireflyIII/Database/Budget/Budget.php | 3 +- .../TransactionCurrency.php | 2 - app/lib/FireflyIII/FF3ServiceProvider.php | 7 + app/lib/FireflyIII/Form/Form.php | 2 +- app/lib/FireflyIII/Report/Report.php | 2 +- app/lib/FireflyIII/Report/ReportQuery.php | 2 +- app/lib/FireflyIII/Search/Search.php | 6 +- app/lib/FireflyIII/Shared/Facade/Amount.php | 24 +++ app/lib/FireflyIII/Shared/Toolkit/Amount.php | 148 ++++++++++++++++ app/lib/FireflyIII/Shared/Toolkit/Steam.php | 19 +- app/models/Reminder.php | 12 +- app/models/Transaction.php | 26 +-- app/models/TransactionJournal.php | 78 ++++----- app/views/accounts/index.blade.php | 2 +- app/views/accounts/show.blade.php | 2 +- app/views/bills/show.blade.php | 4 +- app/views/budgets/index.blade.php | 14 +- app/views/budgets/show.blade.php | 4 +- app/views/categories/index.blade.php | 2 +- app/views/categories/show.blade.php | 2 +- app/views/index.blade.php | 2 +- app/views/list/accounts.blade.php | 2 +- app/views/list/bills.blade.php | 4 +- app/views/list/journals-full.blade.php | 6 +- app/views/list/journals-small.blade.php | 8 +- app/views/list/journals-tiny.blade.php | 4 +- app/views/list/piggy-bank-events.blade.php | 4 +- app/views/piggy_banks/add.blade.php | 2 +- app/views/piggy_banks/index.blade.php | 16 +- app/views/piggy_banks/remove.blade.php | 2 +- app/views/piggy_banks/show.blade.php | 8 +- app/views/reminders/show.blade.php | 4 +- app/views/repeatedExpense/index.blade.php | 6 +- app/views/repeatedExpense/show.blade.php | 4 +- app/views/reports/budget.blade.php | 36 ++-- app/views/reports/month.blade.php | 38 ++-- app/views/reports/year.blade.php | 26 +-- app/views/transactions/show.blade.php | 6 +- bootstrap/functions.php | 165 ------------------ tests/functional/ReminderControllerCest.php | 2 +- 44 files changed, 384 insertions(+), 352 deletions(-) create mode 100644 app/lib/FireflyIII/Shared/Facade/Amount.php create mode 100644 app/lib/FireflyIII/Shared/Toolkit/Amount.php diff --git a/README.md b/README.md index e61b574ee0..06fc100514 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,7 @@ Firefly III [![Build Status](https://travis-ci.org/JC5/firefly-iii.svg?branch=develop)](https://travis-ci.org/JC5/firefly-iii) [![Project Status](http://stillmaintained.com/JC5/firefly-iii.png?a=b)](http://stillmaintained.com/JC5/firefly-iii) [![Coverage Status](https://coveralls.io/repos/JC5/firefly-iii/badge.png?branch=master)](https://coveralls.io/r/JC5/firefly-iii?branch=master) +[![SensioLabsInsight](https://insight.sensiolabs.com/projects/d44c7012-5f50-41ad-add8-8445330e4102/mini.png)](https://insight.sensiolabs.com/projects/d44c7012-5f50-41ad-add8-8445330e4102) [![Latest Stable Version](https://poser.pugx.org/grumpydictator/firefly-iii/v/stable.svg)](https://packagist.org/packages/grumpydictator/firefly-iii) [![Total Downloads](https://poser.pugx.org/grumpydictator/firefly-iii/downloads.svg)](https://packagist.org/packages/grumpydictator/firefly-iii) diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 8bf024d9ef..58924755ae 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -199,9 +199,9 @@ class PiggyBankController extends BaseController */ Event::fire('piggy_bank.addMoney', [$piggyBank, $amount]); // new and used. - Session::flash('success', 'Added ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); + Session::flash('success', 'Added ' . Amount::format($amount, false) . ' to "' . e($piggyBank->name) . '".'); } else { - Session::flash('error', 'Could not add ' . mf($amount, false) . ' to "' . e($piggyBank->name) . '".'); + Session::flash('error', 'Could not add ' . Amount::format($amount, false) . ' to "' . e($piggyBank->name) . '".'); } return Redirect::route('piggy_banks.index'); @@ -228,9 +228,9 @@ class PiggyBankController extends BaseController */ Event::fire('piggy_bank.removeMoney', [$piggyBank, $amount]); // new and used. - Session::flash('success', 'Removed ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); + Session::flash('success', 'Removed ' . Amount::format($amount, false) . ' from "' . e($piggyBank->name) . '".'); } else { - Session::flash('error', 'Could not remove ' . mf($amount, false) . ' from "' . e($piggyBank->name) . '".'); + Session::flash('error', 'Could not remove ' . Amount::format($amount, false) . ' from "' . e($piggyBank->name) . '".'); } return Redirect::route('piggy_banks.index'); diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index da176b827d..167da8a6c0 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -69,7 +69,7 @@ class TransactionController extends BaseController $set = $this->_repository->getByIds($unique); $set->each( function (TransactionJournal $journal) { - $journal->amount = mf($journal->getAmount()); + $journal->amount = Amount::format($journal->getAmount()); } ); @@ -308,7 +308,7 @@ class TransactionController extends BaseController $result = $this->_repository->searchRelated($search, $journal); $result->each( function (TransactionJournal $j) { - $j->amount = mf($j->getAmount()); + $j->amount = Amount::format($j->getAmount()); } ); diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index e1ba05daa0..0cfa42dd03 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -7,11 +7,11 @@ use FireflyIII\Database\CommonDatabaseCallsInterface; use FireflyIII\Database\CUDInterface; use FireflyIII\Database\SwitchUser; use FireflyIII\Exception\NotImplementedException; -use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; use Illuminate\Support\MessageBag; - +use Illuminate\Database\Query\Builder as QueryBuilder; +use Illuminate\Database\Eloquent\Builder as EloquentBuilder; /** * Class Account * @@ -223,20 +223,21 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte public function destroy(Eloquent $model) { + // delete piggy banks // delete journals: $journals = \TransactionJournal::whereIn( - 'id', function (Builder $query) use ($model) { + 'id', function (QueryBuilder $query) use ($model) { $query->select('transaction_journal_id') ->from('transactions')->whereIn( - 'account_id', function (Builder $query) use ($model) { + 'account_id', function (QueryBuilder $query) use ($model) { $query ->select('id') ->from('accounts') ->where( - function (Builder $q) use ($model) { + function (QueryBuilder $q) use ($model) { $q->where('id', $model->id); $q->orWhere( - function (Builder $q) use ($model) { + function (QueryBuilder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); // TODO magic number! $q->where('accounts.account_type_id', 3); @@ -274,10 +275,10 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte // delete accounts: \Account::where( - function (Builder $q) use ($model) { + function (EloquentBuilder $q) use ($model) { $q->where('id', $model->id); $q->orWhere( - function (Builder $q) use ($model) { + function (EloquentBuilder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); // TODO magic number! $q->where('accounts.account_type_id', 3); diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index f47f745b8f..770e703c1d 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -10,7 +10,7 @@ use FireflyIII\Exception\NotImplementedException; use Illuminate\Database\Eloquent\Model as Eloquent; use Illuminate\Support\Collection; use Illuminate\Support\MessageBag; -use Illuminate\Database\Eloquent\Builder; +use Illuminate\Database\Query\Builder; /** * Class Budget @@ -336,7 +336,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf $limit->repeat_freq = 'monthly'; $limit->repeats = 0; $result = $limit->save(); - \Log::info('Created new limit? ' . boolstr($result)); \Log::info('ID: ' . $limit->id); /* * A newly stored limit also created a limit repetition. diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index ff6cf9d12c..d85daa266c 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -35,7 +35,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas public function store(array $data) { $currency = new \TransactionCurrency($data); - \Log::debug('Is valid? ' . boolstr($currency->isValid())); $currency->save(); return $currency; @@ -52,7 +51,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas $model->symbol = $data['symbol']; $model->code = $data['code']; $model->name = $data['name']; - \Log::debug('Is valid? ' . boolstr($model->isValid())); $model->save(); return true; diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index 18ad6a4612..6495f65f51 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -7,6 +7,7 @@ use FireflyIII\Shared\Toolkit\Form; use FireflyIII\Shared\Toolkit\Navigation; use FireflyIII\Shared\Toolkit\Reminders; use FireflyIII\Shared\Toolkit\Steam; +use FireflyIII\Shared\Toolkit\Amount; use FireflyIII\Shared\Validation\FireflyValidator; use Illuminate\Foundation\AliasLoader; use Illuminate\Support\ServiceProvider; @@ -82,6 +83,11 @@ class FF3ServiceProvider extends ServiceProvider return new Steam; } ); + $this->app->bind( + 'amount', function () { + return new Amount; + } + ); } public function registerInterfaces() @@ -114,6 +120,7 @@ class FF3ServiceProvider extends ServiceProvider $loader->alias('Navigation', 'FireflyIII\Shared\Facade\Navigation'); $loader->alias('FFForm', 'FireflyIII\Shared\Facade\FFForm'); $loader->alias('Steam', 'FireflyIII\Shared\Facade\Steam'); + $loader->alias('Amount', 'FireflyIII\Shared\Facade\Amount'); } ); } diff --git a/app/lib/FireflyIII/Form/Form.php b/app/lib/FireflyIII/Form/Form.php index c44683a674..68409ab2df 100644 --- a/app/lib/FireflyIII/Form/Form.php +++ b/app/lib/FireflyIII/Form/Form.php @@ -123,7 +123,7 @@ class Form $html .= \Form::input('text', $name, $value, $options); break; case 'amount': - $html .= '
    ' . getCurrencySymbol() . '
    '; + $html .= '
    ' . \Amount::getCurrencySymbol() . '
    '; $html .= \Form::input('number', $name, $value, $options); $html .= '
    '; break; diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 3b012bcc1c..340179db5e 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -6,7 +6,7 @@ use Carbon\Carbon; use FireflyIII\Database\Account\Account as AccountRepository; use FireflyIII\Database\SwitchUser; use FireflyIII\Database\TransactionJournal\TransactionJournal as JournalRepository; -use Illuminate\Database\Eloquent\Builder; +use Illuminate\Database\Query\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index c224c80ea0..23d8113363 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -3,9 +3,9 @@ namespace FireflyIII\Report; use Carbon\Carbon; -use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; +use Illuminate\Database\Eloquent\Builder; /** * Class ReportQuery diff --git a/app/lib/FireflyIII/Search/Search.php b/app/lib/FireflyIII/Search/Search.php index 4324223d14..859d83b7b4 100644 --- a/app/lib/FireflyIII/Search/Search.php +++ b/app/lib/FireflyIII/Search/Search.php @@ -4,7 +4,7 @@ namespace FireflyIII\Search; use Illuminate\Support\Collection; -use Illuminate\Database\Eloquent\Builder; +use Illuminate\Database\Eloquent\Builder as EloquentBuilder; /** * Class Search @@ -21,7 +21,7 @@ class Search public function searchAccounts(array $words) { return \Auth::user()->accounts()->with('accounttype')->where( - function (Builder $q) use ($words) { + function (EloquentBuilder $q) use ($words) { foreach ($words as $word) { $q->orWhere('name', 'LIKE', '%' . e($word) . '%'); } @@ -97,7 +97,7 @@ class Search public function searchTransactions(array $words) { return \Auth::user()->transactionjournals()->withRelevantData()->where( - function (Builder $q) use ($words) { + function (EloquentBuilder $q) use ($words) { foreach ($words as $word) { $q->orWhere('description', 'LIKE', '%' . e($word) . '%'); } diff --git a/app/lib/FireflyIII/Shared/Facade/Amount.php b/app/lib/FireflyIII/Shared/Facade/Amount.php new file mode 100644 index 0000000000..4a3eb4dba4 --- /dev/null +++ b/app/lib/FireflyIII/Shared/Facade/Amount.php @@ -0,0 +1,24 @@ +getCurrencySymbol(); + + return $this->formatWithSymbol($currencySymbol, $amount, $coloured); + + + } + + /** + * @return string + */ + public function getCurrencySymbol() + { + if (defined('FFCURRENCYSYMBOL')) { + return FFCURRENCYSYMBOL; + } + if (\Cache::has('FFCURRENCYSYMBOL')) { + define('FFCURRENCYSYMBOL', \Cache::get('FFCURRENCYSYMBOL')); + + return FFCURRENCYSYMBOL; + } + + /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ + $currencies = \App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); + + /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ + $preferences = \App::make('FireflyIII\Shared\Preferences\Preferences'); + + $currencyPreference = $preferences->get('currencyPreference', 'EUR'); + $currency = $currencies->findByCode($currencyPreference->data); + + \Cache::forever('FFCURRENCYSYMBOL', $currency->symbol); + + define('FFCURRENCYSYMBOL', $currency->symbol); + + return $currency->symbol; + } + + /** + * @param string $symbol + * @param float $amount + * @param bool $coloured + * + * @return string + */ + protected function formatWithSymbol($symbol, $amount, $coloured = true) + { + $amount = floatval($amount); + $amount = round($amount, 2); + $string = number_format($amount, 2, ',', '.'); + + if ($coloured === true) { + if ($amount === 0.0) { + return '' . $symbol . ' ' . $string . ''; + } + if ($amount > 0) { + return '' . $symbol . ' ' . $string . ''; + } + + return '' . $symbol . ' ' . $string . ''; + } + + // € + return $symbol . ' ' . $string; + } + + /** + * @param \TransactionJournal $journal + * @param float $amount + * @param bool $coloured + * + * @return string + */ + public function formatJournal(\TransactionJournal $journal, $amount, $coloured = true) + { + $symbol = $journal->transactionCurrency->symbol; + + return $this->formatWithSymbol($symbol, $amount, $coloured); + + + } + + /** + * @param \Transaction $transaction + * @param bool $coloured + * + * @return string + */ + public function formatTransaction(\Transaction $transaction, $coloured = true) + { + $symbol = $transaction->transactionJournal->transactionCurrency->symbol; + $amount = floatval($transaction->amount); + + return $this->formatWithSymbol($symbol, $amount, $coloured); + + + } + + /** + * @return string + */ + public function getCurrencyCode() + { + if (defined('FFCURRENCYCODE')) { + return FFCURRENCYCODE; + } + if (\Cache::has('FFCURRENCYCODE')) { + define('FFCURRENCYCODE', \Cache::get('FFCURRENCYCODE')); + + return FFCURRENCYCODE; + } + + /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ + $currencies = \App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); + + /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ + $preferences = \App::make('FireflyIII\Shared\Preferences\Preferences'); + + $currencyPreference = $preferences->get('currencyPreference', 'EUR'); + $currency = $currencies->findByCode($currencyPreference->data); + + \Cache::forever('FFCURRENCYCODE', $currency->code); + + define('FFCURRENCYCODE', $currency->code); + + return $currency->code; + } + +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Shared/Toolkit/Steam.php b/app/lib/FireflyIII/Shared/Toolkit/Steam.php index 4348456b4d..03f644bafc 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Steam.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Steam.php @@ -25,7 +25,7 @@ class Steam */ public function balance(\Account $account, Carbon $date = null) { - $date = is_null($date) ? Carbon::now() : $date; + $date = is_null($date) ? Carbon::now() : $date; $balance = floatval( $account->transactions()->leftJoin( 'transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id' @@ -35,6 +35,23 @@ class Steam return $balance; } + /** + * @param $boolean + * + * @return string + */ + public function boolString($boolean) + { + if ($boolean === true) { + return 'BOOLEAN TRUE'; + } + if ($boolean === false) { + return 'BOOLEAN FALSE'; + } + + return 'NO BOOLEAN: ' . $boolean; + } + /** * @param \PiggyBank $piggyBank * @param \PiggyBankRepetition $repetition diff --git a/app/models/Reminder.php b/app/models/Reminder.php index 8ea1b8dddb..b9c7b326b8 100644 --- a/app/models/Reminder.php +++ b/app/models/Reminder.php @@ -1,8 +1,10 @@ where('startdate', $start->format('Y-m-d 00:00:00'))->where('enddate', $end->format('Y-m-d 00:00:00')); } diff --git a/app/models/Transaction.php b/app/models/Transaction.php index c4a77ee917..bb5c423bec 100644 --- a/app/models/Transaction.php +++ b/app/models/Transaction.php @@ -1,7 +1,7 @@ where('transactions.account_id', $account->id); } /** - * @param Builder $query + * @param EloquentBuilder $query * @param Carbon $date */ - public function scopeAfter(Builder $query, Carbon $date) + public function scopeAfter(EloquentBuilder $query, Carbon $date) { if (is_null($this->joinedJournals)) { $query->leftJoin( @@ -51,10 +51,10 @@ class Transaction extends Eloquent } /** - * @param Builder $query + * @param EloquentBuilder $query * @param Carbon $date */ - public function scopeBefore(Builder $query, Carbon $date) + public function scopeBefore(EloquentBuilder $query, Carbon $date) { if (is_null($this->joinedJournals)) { $query->leftJoin( @@ -66,28 +66,28 @@ class Transaction extends Eloquent } /** - * @param Builder $query + * @param EloquentBuilder $query * @param $amount */ - public function scopeLessThan(Builder $query, $amount) + public function scopeLessThan(EloquentBuilder $query, $amount) { $query->where('amount', '<', $amount); } /** - * @param Builder $query + * @param EloquentBuilder $query * @param $amount */ - public function scopeMoreThan(Builder $query, $amount) + public function scopeMoreThan(EloquentBuilder $query, $amount) { $query->where('amount', '>', $amount); } /** - * @param Builder $query + * @param EloquentBuilder $query * @param array $types */ - public function scopeTransactionTypes(Builder $query, array $types) + public function scopeTransactionTypes(EloquentBuilder $query, array $types) { if (is_null($this->joinedJournals)) { $query->leftJoin( diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index 66aa050a00..e39a8a4c81 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -1,10 +1,11 @@ 'required|exists:transaction_types,id', 'transaction_currency_id' => 'required|exists:transaction_currencies,id', 'description' => 'required|between:1,255', 'date' => 'required|date', 'completed' => 'required|between:0,1']; - protected $fillable - = ['transaction_type_id', 'transaction_currency_id', 'user_id', - 'description', 'date', 'completed']; + + /** + * @return \Illuminate\Database\Eloquent\Relations\BelongsTo + */ + public function bill() + { + return $this->belongsTo('Bill'); + } /** * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany @@ -43,7 +52,6 @@ class TransactionJournal extends Eloquent ); } - /** * TODO remove this method in favour of something in the FireflyIII libraries. * @@ -83,18 +91,10 @@ class TransactionJournal extends Eloquent } /** - * @return \Illuminate\Database\Eloquent\Relations\BelongsTo + * @param EloquentBuilder $query + * @param Account $account */ - public function bill() - { - return $this->belongsTo('Bill'); - } - - /** - * @param Builder $query - * @param Account $account - */ - public function scopeAccountIs($query, \Account $account) + public function scopeAccountIs(EloquentBuilder $query, \Account $account) { if (!isset($this->joinedTransactions)) { $query->leftJoin('transactions', 'transactions.transaction_journal_id', '=', 'transaction_journals.id'); @@ -104,32 +104,32 @@ class TransactionJournal extends Eloquent } /** - * @param $query - * @param Carbon $date + * @param EloquentBuilder $query + * @param Carbon $date * * @return mixed */ - public function scopeAfter($query, Carbon $date) + public function scopeAfter(EloquentBuilder $query, Carbon $date) { return $query->where('transaction_journals.date', '>=', $date->format('Y-m-d 00:00:00')); } /** - * @param $query - * @param Carbon $date + * @param EloquentBuilder $query + * @param Carbon $date * * @return mixed */ - public function scopeBefore($query, Carbon $date) + public function scopeBefore(EloquentBuilder $query, Carbon $date) { return $query->where('transaction_journals.date', '<=', $date->format('Y-m-d 00:00:00')); } /** - * @param Builder $query - * @param $amount + * @param EloquentBuilder $query + * @param $amount */ - public function scopeLessThan($query, $amount) + public function scopeLessThan(EloquentBuilder $query, $amount) { if (is_null($this->joinedTransactions)) { $query->leftJoin( @@ -142,10 +142,10 @@ class TransactionJournal extends Eloquent } /** - * @param Builder $query - * @param $amount + * @param EloquentBuilder $query + * @param $amount */ - public function scopeMoreThan($query, $amount) + public function scopeMoreThan(EloquentBuilder $query, $amount) { if (is_null($this->joinedTransactions)) { $query->leftJoin( @@ -158,21 +158,21 @@ class TransactionJournal extends Eloquent } /** - * @param $query - * @param Carbon $date + * @param EloquentBuilder $query + * @param Carbon $date * * @return mixed */ - public function scopeOnDate($query, Carbon $date) + public function scopeOnDate(EloquentBuilder $query, Carbon $date) { return $query->where('date', '=', $date->format('Y-m-d')); } /** - * @param Builder $query - * @param array $types + * @param EloquentBuilder $query + * @param array $types */ - public function scopeTransactionTypes($query, array $types) + public function scopeTransactionTypes(EloquentBuilder $query, array $types) { if (is_null($this->joinedTransactionTypes)) { $query->leftJoin( @@ -187,14 +187,14 @@ class TransactionJournal extends Eloquent * Automatically includes the 'with' parameters to get relevant related * objects. * - * @param $query + * @param EloquentBuilder $query */ - public function scopeWithRelevantData($query) + public function scopeWithRelevantData(EloquentBuilder $query) { $query->with( - ['transactions' => function (HasMany $q) { + ['transactions' => function (HasMany $q) { $q->orderBy('amount', 'ASC'); - }, 'transactiontype', 'budgets','categories', 'transactions.account.accounttype', 'bill', 'budgets', 'categories'] + }, 'transactiontype', 'budgets', 'categories', 'transactions.account.accounttype', 'bill', 'budgets', 'categories'] ); } diff --git a/app/views/accounts/index.blade.php b/app/views/accounts/index.blade.php index 69fb63340e..e837940541 100644 --- a/app/views/accounts/index.blade.php +++ b/app/views/accounts/index.blade.php @@ -30,7 +30,7 @@ @section('scripts') diff --git a/app/views/accounts/show.blade.php b/app/views/accounts/show.blade.php index 87297603f8..e5b4fc9e04 100644 --- a/app/views/accounts/show.blade.php +++ b/app/views/accounts/show.blade.php @@ -52,7 +52,7 @@ diff --git a/app/views/bills/show.blade.php b/app/views/bills/show.blade.php index 023b3dd515..b4ad8d9e1e 100644 --- a/app/views/bills/show.blade.php +++ b/app/views/bills/show.blade.php @@ -42,7 +42,7 @@ @foreach(explode(',',$bill->match) as $word) {{{$word}}} @endforeach - between {{mf($bill->amount_min)}} and {{mf($bill->amount_max)}}. + between {{Amount::format($bill->amount_min)}} and {{Amount::format($bill->amount_max)}}. Repeats {{$bill->repeat_freq}}. @@ -106,7 +106,7 @@ @section('scripts') diff --git a/app/views/budgets/index.blade.php b/app/views/budgets/index.blade.php index 556a6fc6f1..2b5f62be48 100644 --- a/app/views/budgets/index.blade.php +++ b/app/views/budgets/index.blade.php @@ -10,11 +10,11 @@
    - Budgeted: {{mf(300)}} + Budgeted: {{Amount::format(300)}}
    Income {{\Session::get('start', \Carbon\Carbon::now()->startOfMonth())->format('F Y')}}: - {{mf($amount)}} + {{Amount::format($amount)}}
    @@ -29,7 +29,7 @@
    - Spent: {{mf($spent)}} + Spent: {{Amount::format($spent)}}
    @@ -100,21 +100,21 @@ @if($budget->currentRep->amount > $budget->spent) - {{getCurrencySymbol()}} + {{Amount::getCurrencySymbol()}} @else - {{getCurrencySymbol()}} + {{Amount::getCurrencySymbol()}} @endif @else No budget - + @endif

    - Spent: {{mf($budget->spent)}} + Spent: {{Amount::format($budget->spent)}}

    diff --git a/app/views/budgets/show.blade.php b/app/views/budgets/show.blade.php index 4b4d983082..b6c35c646d 100644 --- a/app/views/budgets/show.blade.php +++ b/app/views/budgets/show.blade.php @@ -29,10 +29,10 @@
    - Amount: {{mf($rep->amount)}} + Amount: {{Amount::format($rep->amount)}}
    - Spent: {{mf($rep->spentInRepetition())}} + Spent: {{Amount::format($rep->spentInRepetition())}}
    diff --git a/app/views/categories/index.blade.php b/app/views/categories/index.blade.php index e9ed09213e..3c176f36b6 100644 --- a/app/views/categories/index.blade.php +++ b/app/views/categories/index.blade.php @@ -29,7 +29,7 @@ @stop @section('scripts') diff --git a/app/views/categories/show.blade.php b/app/views/categories/show.blade.php index 66e091427d..37fa8d0e2d 100644 --- a/app/views/categories/show.blade.php +++ b/app/views/categories/show.blade.php @@ -32,7 +32,7 @@ diff --git a/app/views/index.blade.php b/app/views/index.blade.php index 68bf2afa13..22520f85b5 100644 --- a/app/views/index.blade.php +++ b/app/views/index.blade.php @@ -114,7 +114,7 @@ @stop @section('scripts') diff --git a/app/views/list/accounts.blade.php b/app/views/list/accounts.blade.php index 4ccf4f36eb..84f88bdfcc 100644 --- a/app/views/list/accounts.blade.php +++ b/app/views/list/accounts.blade.php @@ -17,7 +17,7 @@ {{{$account->name}}} {{{$account->accountRole}}} - {{mf(Steam::balance($account))}} + {{Amount::format(Steam::balance($account))}} @if($account->active) diff --git a/app/views/list/bills.blade.php b/app/views/list/bills.blade.php index 70c7989d84..a603bd9617 100644 --- a/app/views/list/bills.blade.php +++ b/app/views/list/bills.blade.php @@ -27,9 +27,9 @@ @endforeach - {{mf($entry->amount_min)}} + {{Amount::format($entry->amount_min)}} — - {{mf($entry->amount_max)}} + {{Amount::format($entry->amount_max)}} lastFoundMatch();?> diff --git a/app/views/list/journals-full.blade.php b/app/views/list/journals-full.blade.php index e5982e24ae..4979b6a428 100644 --- a/app/views/list/journals-full.blade.php +++ b/app/views/list/journals-full.blade.php @@ -58,13 +58,13 @@ @if($journal->transactiontype->type == 'Withdrawal') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Deposit') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Transfer') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif diff --git a/app/views/list/journals-small.blade.php b/app/views/list/journals-small.blade.php index 113b4224a7..9bf33f4b0b 100644 --- a/app/views/list/journals-small.blade.php +++ b/app/views/list/journals-small.blade.php @@ -9,13 +9,13 @@ transactions[1]->amount);?> @if($journal->transactiontype->type == 'Withdrawal') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Deposit') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif @if($journal->transactiontype->type == 'Transfer') - {{mft($journal->transactions[1],false)}} + {{Amount::formatTransaction($journal->transactions[1],false)}} @endif @@ -33,7 +33,7 @@ @if(isset($displaySum) && $displaySum === true) Sum - {{mf($tableSum)}} + {{Amount::format($tableSum)}} @endif diff --git a/app/views/list/journals-tiny.blade.php b/app/views/list/journals-tiny.blade.php index c4380ca00c..9987e28ae4 100644 --- a/app/views/list/journals-tiny.blade.php +++ b/app/views/list/journals-tiny.blade.php @@ -18,13 +18,13 @@ @if(isset($account)) @foreach($journal->transactions as $index => $t) @if($t->account_id == $account->id) - {{mft($t)}} + {{Amount::formatTransaction($t)}} @endif @endforeach @else @foreach($journal->transactions as $index => $t) @if($index == 0) - {{mft($t)}} + {{Amount::formatTransaction($t)}} @endif @endforeach @endif diff --git a/app/views/list/piggy-bank-events.blade.php b/app/views/list/piggy-bank-events.blade.php index bbd39d9798..e7527ed54e 100644 --- a/app/views/list/piggy-bank-events.blade.php +++ b/app/views/list/piggy-bank-events.blade.php @@ -23,9 +23,9 @@ @if($event->amount < 0) - Removed {{mf($event->amount*-1,false)}} + Removed {{Amount::format($event->amount*-1,false)}} @else - Added {{mf($event->amount,false)}} + Added {{Amount::format($event->amount,false)}} @endif diff --git a/app/views/piggy_banks/add.blade.php b/app/views/piggy_banks/add.blade.php index f9680880e7..b9ee7be0d0 100644 --- a/app/views/piggy_banks/add.blade.php +++ b/app/views/piggy_banks/add.blade.php @@ -8,7 +8,7 @@

    - The maximum amount you can add is {{mf($maxAmount)}} + The maximum amount you can add is {{Amount::format($maxAmount)}}

    €
    diff --git a/app/views/piggy_banks/index.blade.php b/app/views/piggy_banks/index.blade.php index ea6009201d..73b7744545 100644 --- a/app/views/piggy_banks/index.blade.php +++ b/app/views/piggy_banks/index.blade.php @@ -50,7 +50,7 @@
    - {{mf($piggyBank->savedSoFar,true)}} + {{Amount::format($piggyBank->savedSoFar,true)}}
    @@ -68,12 +68,12 @@
    - {{mf($piggyBank->targetamount,true)}} + {{Amount::format($piggyBank->targetamount,true)}}
    @if($piggyBank->leftToSave > 0) - {{mf($piggyBank->leftToSave)}} + {{Amount::format($piggyBank->leftToSave)}} @endif
    @@ -109,11 +109,11 @@ @foreach($accounts as $id => $info) {{{$info['name']}}} - {{mf($info['balance'])}} - {{mf($info['leftForPiggyBanks'])}} - {{mf($info['sumOfTargets'])}} - {{mf($info['sumOfSaved'])}} - {{mf($info['leftToSave'])}} + {{Amount::format($info['balance'])}} + {{Amount::format($info['leftForPiggyBanks'])}} + {{Amount::format($info['sumOfTargets'])}} + {{Amount::format($info['sumOfSaved'])}} + {{Amount::format($info['leftToSave'])}} @endforeach diff --git a/app/views/piggy_banks/remove.blade.php b/app/views/piggy_banks/remove.blade.php index 4d157a8287..90129fecc6 100644 --- a/app/views/piggy_banks/remove.blade.php +++ b/app/views/piggy_banks/remove.blade.php @@ -8,7 +8,7 @@

    - The maximum amount you can remove is {{mf($piggyBank->currentRelevantRep()->currentamount)}} + The maximum amount you can remove is {{Amount::format($piggyBank->currentRelevantRep()->currentamount)}}

    €
    diff --git a/app/views/piggy_banks/show.blade.php b/app/views/piggy_banks/show.blade.php index 33366e2f2b..47c4e86327 100644 --- a/app/views/piggy_banks/show.blade.php +++ b/app/views/piggy_banks/show.blade.php @@ -40,15 +40,15 @@ Target amount - {{mf($piggyBank->targetamount)}} + {{Amount::format($piggyBank->targetamount)}} Saved so far - {{mf($piggyBank->currentRelevantRep()->currentamount)}} + {{Amount::format($piggyBank->currentRelevantRep()->currentamount)}} Left to save - {{mf($piggyBank->targetamount-$piggyBank->currentRelevantRep()->currentamount)}} + {{Amount::format($piggyBank->targetamount-$piggyBank->currentRelevantRep()->currentamount)}} Start date @@ -95,7 +95,7 @@ Expected amount per reminder - {{mf($amountPerReminder)}} + {{Amount::format($amountPerReminder)}} @endif diff --git a/app/views/reminders/show.blade.php b/app/views/reminders/show.blade.php index 76cdd56b23..d0fcd29f7a 100644 --- a/app/views/reminders/show.blade.php +++ b/app/views/reminders/show.blade.php @@ -14,8 +14,8 @@

    @if(get_class($reminder->remindersable) == 'Piggybank') Somewhere between {{$reminder->startdate->format('j F Y')}} and {{$reminder->enddate->format('j F Y')}} you - should deposit {{mf($amount)}} in piggy bank {{{$reminder->remindersable->name}}} - in order to make your goal of saving {{mf($reminder->remindersable->targetamount)}} on {{$reminder->remindersable->targetdate->format('j F Y')}} + should deposit {{Amount::format($amount)}} in piggy bank {{{$reminder->remindersable->name}}} + in order to make your goal of saving {{Amount::format($reminder->remindersable->targetamount)}} on {{$reminder->remindersable->targetdate->format('j F Y')}} @endif

    diff --git a/app/views/repeatedExpense/index.blade.php b/app/views/repeatedExpense/index.blade.php index e8167c42b6..9690c5d830 100644 --- a/app/views/repeatedExpense/index.blade.php +++ b/app/views/repeatedExpense/index.blade.php @@ -17,7 +17,7 @@
    {{{$entry->name}}} - ({{mf($entry->targetamount)}}) + ({{Amount::format($entry->targetamount)}})
    @@ -37,11 +37,11 @@
    @if(Steam::percentage($entry,$entry->currentRep) > 30) - {{mf($entry->currentRep->currentamount,false)}} + {{Amount::format($entry->currentRep->currentamount,false)}} @endif
    @if(Steam::percentage($entry,$entry->currentRep) <= 30) -  {{mf($entry->currentRep->currentamount,false)}} +  {{Amount::format($entry->currentRep->currentamount,false)}} @endif
    diff --git a/app/views/repeatedExpense/show.blade.php b/app/views/repeatedExpense/show.blade.php index bc3e5154fa..f5678bb688 100644 --- a/app/views/repeatedExpense/show.blade.php +++ b/app/views/repeatedExpense/show.blade.php @@ -21,7 +21,7 @@

    - Target amount: {{mf($repeatedExpense->targetamount)}}. Currently saved: {{mf($rep->currentamount)}}. + Target amount: {{Amount::format($repeatedExpense->targetamount)}}. Currently saved: {{Amount::format($rep->currentamount)}}.

    @foreach($rep->bars as $bar) @@ -41,7 +41,7 @@ @endif @endif @if($bar->percentage() > 50 && $bar->percentage() < 100) - {{mf($rep->currentamount,false)}} + {{Amount::format($rep->currentamount,false)}} @endif
    diff --git a/app/views/reports/budget.blade.php b/app/views/reports/budget.blade.php index 52f64e6a61..bab3a63918 100644 --- a/app/views/reports/budget.blade.php +++ b/app/views/reports/budget.blade.php @@ -13,9 +13,9 @@ @foreach($accounts as $account) {{{$account->name}}} - {{mf($account->startBalance)}} - {{mf($account->endBalance)}} - {{mf($account->startBalance - $account->endBalance,false)}} + {{Amount::format($account->startBalance)}} + {{Amount::format($account->endBalance)}} + {{Amount::format($account->startBalance - $account->endBalance,false)}} @endforeach @@ -47,15 +47,15 @@ @endif - {{mf($budget['amount'])}} + {{Amount::format($budget['amount'])}} @foreach($accounts as $account) @if(isset($account->budgetInformation[$id])) @if($id == 0) - {{mf($account->budgetInformation[$id]['amount'])}} + {{Amount::format($account->budgetInformation[$id]['amount'])}} @else - {{mf($account->budgetInformation[$id]['amount'])}} + {{Amount::format($account->budgetInformation[$id]['amount'])}} @endif id] += floatval($account->budgetInformation[$id]['amount']); ?> @else - {{mf(0)}} + {{Amount::format(0)}} @endif @endforeach - {{mf($budget['amount'] + $budget['spent'])}} - {{mf($budget['amount'] + $spent)}} + {{Amount::format($budget['amount'] + $budget['spent'])}} + {{Amount::format($budget['amount'] + $spent)}} @endforeach @@ -77,10 +77,10 @@ @foreach($accounts as $account) @if(isset($account->budgetInformation[0])) - {{mf($account->budgetInformation[0]['amount'])}} + {{Amount::format($account->budgetInformation[0]['amount'])}} @else - {{mf(0)}} + {{Amount::format(0)}} @endif @endforeach   @@ -89,7 +89,7 @@ Balanced by transfers @foreach($accounts as $account) - {{mf($account->balancedAmount)}} + {{Amount::format($account->balancedAmount)}} @endforeach   @@ -98,14 +98,14 @@ Balancing transfers @foreach($accounts as $account) - {{mf(0)}} + {{Amount::format(0)}} @endforeach   Income @foreach($accounts as $account) - {{mf(0)}} + {{Amount::format(0)}} @endforeach   @@ -118,10 +118,10 @@ ?> @if(isset($account->budgetInformation[0])) - {{mf($account->budgetInformation[0]['amount'] + $account->balancedAmount)}} + {{Amount::format($account->budgetInformation[0]['amount'] + $account->balancedAmount)}} @else - {{mf(0)}} + {{Amount::format(0)}} @endif @endforeach   @@ -129,14 +129,14 @@ Sum @foreach($accounts as $account) - {{mf($accountSums[$account->id])}} + {{Amount::format($accountSums[$account->id])}} @endforeach   Expected balance @foreach($accounts as $account) - {{mf($account->startBalance + $accountSums[$account->id])}} + {{Amount::format($account->startBalance + $accountSums[$account->id])}} @endforeach   diff --git a/app/views/reports/month.blade.php b/app/views/reports/month.blade.php index 9699f02ea0..c60d473d62 100644 --- a/app/views/reports/month.blade.php +++ b/app/views/reports/month.blade.php @@ -21,12 +21,12 @@ @else {{{$expense['name']}}} @endif - {{mf($expense['amount'])}} + {{Amount::format($expense['amount'])}} @endforeach Sum - {{mf($sum)}} + {{Amount::format($sum)}}
    @@ -43,15 +43,15 @@ - + - + - +
    In{{mf($in)}}{{Amount::format($in)}}
    Out{{mf($sum)}}{{Amount::format($sum)}}
    Difference{{mf($in - $sum)}}{{Amount::format($in - $sum)}}
    @@ -87,16 +87,16 @@ {{{$budget['name']}}} @endif - {{mf($budget['amount'])}} - {{mf($budget['spent'],false)}} - {{mf($budget['amount'] + $budget['spent'])}} + {{Amount::format($budget['amount'])}} + {{Amount::format($budget['spent'],false)}} + {{Amount::format($budget['amount'] + $budget['spent'])}} @endforeach Sum - {{mf($sumEnvelope)}} - {{mf($sumSpent)}} - {{mf($sumLeft)}} + {{Amount::format($sumEnvelope)}} + {{Amount::format($sumSpent)}} + {{Amount::format($sumLeft)}}
    @@ -120,12 +120,12 @@ {{{$category['name']}}} @endif - {{mf($category['amount'],false)}} + {{Amount::format($category['amount'],false)}} @endforeach Sum - {{mf($sum)}} + {{Amount::format($sum)}}
    @@ -149,16 +149,16 @@ ?> {{{$account['name']}}} - {{mf($account['startBalance'])}} - {{mf($account['endBalance'])}} - {{mf($account['difference'])}} + {{Amount::format($account['startBalance'])}} + {{Amount::format($account['endBalance'])}} + {{Amount::format($account['difference'])}} @endforeach Sum - {{mf($sumStart)}} - {{mf($sumEnd)}} - {{mf($sumDiff)}} + {{Amount::format($sumStart)}} + {{Amount::format($sumEnd)}} + {{Amount::format($sumDiff)}} diff --git a/app/views/reports/year.blade.php b/app/views/reports/year.blade.php index 10a332bf67..2911af39fa 100644 --- a/app/views/reports/year.blade.php +++ b/app/views/reports/year.blade.php @@ -49,16 +49,16 @@ shared @endif - {{mf($balance['start'])}} - {{mf($balance['end'])}} - {{mf($balance['end']-$balance['start'])}} + {{Amount::format($balance['start'])}} + {{Amount::format($balance['end'])}} + {{Amount::format($balance['end']-$balance['start'])}} @endforeach Sum of sums - {{mf($start)}} - {{mf($end)}} - {{mf($diff)}} + {{Amount::format($start)}} + {{Amount::format($end)}} + {{Amount::format($diff)}} @@ -83,15 +83,15 @@ - + - + - +
    In{{mf($incomeSum)}}{{Amount::format($incomeSum)}}
    Out{{mf($expenseSum*-1)}}{{Amount::format($expenseSum*-1)}}
    Difference{{mf($incomeSum - $expenseSum)}}{{Amount::format($incomeSum - $expenseSum)}}
    @@ -107,12 +107,12 @@ sum)*-1;?> {{{$income->name}}} - {{mf(floatval($income->sum)*-1)}} + {{Amount::format(floatval($income->sum)*-1)}} @endforeach Sum - {{mf($sum)}} + {{Amount::format($sum)}} @@ -126,7 +126,7 @@ @foreach($groupedExpenses as $id => $expense) {{{$expense['name']}}} - {{mf(floatval($expense['amount'])*-1)}} + {{Amount::format(floatval($expense['amount'])*-1)}} @endforeach @@ -156,7 +156,7 @@ {{HTML::script('assets/javascript/firefly/reports.js')}} diff --git a/app/views/transactions/show.blade.php b/app/views/transactions/show.blade.php index a6b7446b21..2bdc086cf1 100644 --- a/app/views/transactions/show.blade.php +++ b/app/views/transactions/show.blade.php @@ -74,7 +74,7 @@ {{{$jrnl->description}}} - {{mfj($jrnl, $jrnl->getAmount())}} + {{Amount::formatJournal($jrnl, $jrnl->getAmount())}} @endforeach @@ -97,11 +97,11 @@ - + - + @if(!is_null($t->description)) diff --git a/bootstrap/functions.php b/bootstrap/functions.php index 69c13d834b..b3d9bbc7f3 100644 --- a/bootstrap/functions.php +++ b/bootstrap/functions.php @@ -1,166 +1 @@ transactionJournal->transactionCurrency->symbol; - $amount = floatval($transaction->amount); - - return mfc($symbol, $amount, $coloured); - - - } -} - -if (!function_exists('mfj')) { - /** - * @param \TransactionJournal $journal - * @param float $amount - * @param bool $coloured - * - * @return string - */ - function mfj(\TransactionJournal $journal, $amount, $coloured = true) - { - $symbol = $journal->transactionCurrency->symbol; - - return mfc($symbol, $amount, $coloured); - - - } -} - -if (!function_exists('mfc')) { - /** - * @param string $symbol - * @param float $amount - * @param bool $coloured - * - * @return string - */ - function mfc($symbol, $amount, $coloured = true) - { - $amount = floatval($amount); - $amount = round($amount, 2); - $string = number_format($amount, 2, ',', '.'); - - if ($coloured === true) { - if ($amount === 0.0) { - return '' . $symbol . ' ' . $string . ''; - } - if ($amount > 0) { - return '' . $symbol . ' ' . $string . ''; - } - - return '' . $symbol . ' ' . $string . ''; - } - - // € - return $symbol . ' ' . $string; - } -} - -if (!function_exists('getCurrencySymbol')) { - /** - * @return string - */ - function getCurrencySymbol() - { - if (defined('FFCURRENCYSYMBOL')) { - return FFCURRENCYSYMBOL; - } - if (Cache::has('FFCURRENCYSYMBOL')) { - define('FFCURRENCYSYMBOL', Cache::get('FFCURRENCYSYMBOL')); - - return FFCURRENCYSYMBOL; - } - - /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ - $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); - - /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ - $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - - $currencyPreference = $preferences->get('currencyPreference', 'EUR'); - $currency = $currencies->findByCode($currencyPreference->data); - - Cache::forever('FFCURRENCYSYMBOL', $currency->symbol); - - define('FFCURRENCYSYMBOL', $currency->symbol); - - return $currency->symbol; - } -} - -if (!function_exists('getCurrencyCode')) { - /** - * @return string - */ - function getCurrencyCode() - { - if (defined('FFCURRENCYCODE')) { - return FFCURRENCYCODE; - } - if (Cache::has('FFCURRENCYCODE')) { - define('FFCURRENCYCODE', Cache::get('FFCURRENCYCODE')); - - return FFCURRENCYCODE; - } - - /** @var \FireflyIII\Database\TransactionCurrency\TransactionCurrency $currencies */ - $currencies = App::make('FireflyIII\Database\TransactionCurrency\TransactionCurrency'); - - /** @var \FireflyIII\Shared\Preferences\Preferences $preferences */ - $preferences = App::make('FireflyIII\Shared\Preferences\Preferences'); - - $currencyPreference = $preferences->get('currencyPreference', 'EUR'); - $currency = $currencies->findByCode($currencyPreference->data); - - Cache::forever('FFCURRENCYCODE', $currency->code); - - define('FFCURRENCYCODE', $currency->code); - - return $currency->code; - } -} - -if (!function_exists('boolstr')) { - /** - * @param $boolean - * - * @return string - */ - function boolstr($boolean) - { - if (is_bool($boolean) && $boolean === true) { - return 'BOOLEAN TRUE'; - } - if (is_bool($boolean) && $boolean === false) { - return 'BOOLEAN FALSE'; - } - - return 'NO BOOLEAN: ' . $boolean; - } -} diff --git a/tests/functional/ReminderControllerCest.php b/tests/functional/ReminderControllerCest.php index 01901b2cb5..139e4e279b 100644 --- a/tests/functional/ReminderControllerCest.php +++ b/tests/functional/ReminderControllerCest.php @@ -33,7 +33,7 @@ class ReminderControllerCest ['reminders.*'] ); - $I->wantTo('act on reminder ' . boolstr(is_null($reminder))); + $I->wantTo('act on a reminder'); $I->amOnPage('/reminders/' . $reminder->id . '/act'); $I->see('Money for Nieuwe spullen'); } From fb58bf1bf518e7c82cc59871cfa53d2bef492ee1 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 10:01:33 +0100 Subject: [PATCH 79/84] Cleaned up some todo entries [skip ci] --- app/controllers/BudgetController.php | 1 - app/controllers/GoogleChartController.php | 6 - .../Database/AccountType/AccountType.php | 7 - app/lib/FireflyIII/Database/Bill/Bill.php | 3 - app/lib/FireflyIII/Database/Budget/Budget.php | 4 +- .../FireflyIII/Database/Category/Category.php | 3 - .../Database/PiggyBank/PiggyBankShared.php | 1 - .../Database/Transaction/Transaction.php | 6 - .../TransactionCurrency.php | 3 - .../TransactionJournal/TransactionJournal.php | 1 - .../TransactionType/TransactionType.php | 7 - app/lib/FireflyIII/Report/Report.php | 2 - app/lib/FireflyIII/Shared/Toolkit/Amount.php | 2 +- app/tests/PiggybankPartTest.php | 222 ------------------ app/views/repeatedExpense/index.blade.php | 1 - bootstrap/start.php | 2 +- 16 files changed, 3 insertions(+), 268 deletions(-) delete mode 100644 app/tests/PiggybankPartTest.php diff --git a/app/controllers/BudgetController.php b/app/controllers/BudgetController.php index 4d48ce1e8f..c2888d1eab 100644 --- a/app/controllers/BudgetController.php +++ b/app/controllers/BudgetController.php @@ -99,7 +99,6 @@ class BudgetController extends BaseController /** * The index of the budget controller contains all budgets and the current relevant limit repetition. - * TODO move currentRep to the repository. * * @return $this */ diff --git a/app/controllers/GoogleChartController.php b/app/controllers/GoogleChartController.php index aadfc8e5a3..8edd0fe797 100644 --- a/app/controllers/GoogleChartController.php +++ b/app/controllers/GoogleChartController.php @@ -225,7 +225,6 @@ class GoogleChartController extends BaseController } /** - * TODO query move to helper. * * @return \Illuminate\Http\JsonResponse * @throws \FireflyIII\Exception\FireflyException @@ -256,7 +255,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Budget $budget * @param LimitRepetition $repetition @@ -290,7 +288,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Budget $budget * @param $year @@ -341,7 +338,6 @@ class GoogleChartController extends BaseController } /** - * TODO still in use? * * @param Category $component * @param $year @@ -407,7 +403,6 @@ class GoogleChartController extends BaseController } /** - * TODO see reports for better way to do this. * * @param $year * @@ -447,7 +442,6 @@ class GoogleChartController extends BaseController } /** - * TODO see reports for better way to do this. * * @param $year * diff --git a/app/lib/FireflyIII/Database/AccountType/AccountType.php b/app/lib/FireflyIII/Database/AccountType/AccountType.php index a2ec514338..58f6cebb13 100644 --- a/app/lib/FireflyIII/Database/AccountType/AccountType.php +++ b/app/lib/FireflyIII/Database/AccountType/AccountType.php @@ -25,7 +25,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -37,7 +36,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function store(array $data) { - // TODO: Implement store() method. throw new NotImplementedException; } @@ -50,7 +48,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -65,7 +62,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function validate(array $model) { - // TODO: Implement validate() method. throw new NotImplementedException; } @@ -79,7 +75,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -124,7 +119,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -136,7 +130,6 @@ class AccountType implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 22bc2f2ea0..65133d8441 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -142,7 +142,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -156,7 +155,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -178,7 +176,6 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/Budget/Budget.php b/app/lib/FireflyIII/Database/Budget/Budget.php index 770e703c1d..070a39adc2 100644 --- a/app/lib/FireflyIII/Database/Budget/Budget.php +++ b/app/lib/FireflyIII/Database/Budget/Budget.php @@ -119,7 +119,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -143,7 +142,6 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } @@ -335,7 +333,7 @@ class Budget implements CUDInterface, CommonDatabaseCallsInterface, BudgetInterf $limit->amount = $amount; $limit->repeat_freq = 'monthly'; $limit->repeats = 0; - $result = $limit->save(); + $limit->save(); \Log::info('ID: ' . $limit->id); /* * A newly stored limit also created a limit repetition. diff --git a/app/lib/FireflyIII/Database/Category/Category.php b/app/lib/FireflyIII/Database/Category/Category.php index a8d1ef3a37..a928c2d34e 100644 --- a/app/lib/FireflyIII/Database/Category/Category.php +++ b/app/lib/FireflyIII/Database/Category/Category.php @@ -108,7 +108,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -122,7 +121,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -144,7 +142,6 @@ class Category implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php index e4be2c7bf5..5a878e37f4 100644 --- a/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php +++ b/app/lib/FireflyIII/Database/PiggyBank/PiggyBankShared.php @@ -67,7 +67,6 @@ class PiggyBankShared */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/Transaction/Transaction.php b/app/lib/FireflyIII/Database/Transaction/Transaction.php index 7b3823b93c..a92f110d2e 100644 --- a/app/lib/FireflyIII/Database/Transaction/Transaction.php +++ b/app/lib/FireflyIII/Database/Transaction/Transaction.php @@ -28,7 +28,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -68,7 +67,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -103,7 +101,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -117,7 +114,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -129,7 +125,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -141,7 +136,6 @@ class Transaction implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php index d85daa266c..55b7c5f502 100644 --- a/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php +++ b/app/lib/FireflyIII/Database/TransactionCurrency/TransactionCurrency.php @@ -98,7 +98,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -112,7 +111,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -134,7 +132,6 @@ class TransactionCurrency implements TransactionCurrencyInterface, CommonDatabas */ public function getByIds(array $objectIds) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index a10ba47570..73bc4e3877 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -390,7 +390,6 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php index 8312e08a2a..b3b5191de4 100644 --- a/app/lib/FireflyIII/Database/TransactionType/TransactionType.php +++ b/app/lib/FireflyIII/Database/TransactionType/TransactionType.php @@ -27,7 +27,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function destroy(Eloquent $model) { - // TODO: Implement destroy() method. throw new NotImplementedException; } @@ -39,7 +38,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function store(array $data) { - // TODO: Implement store() method. throw new NotImplementedException; } @@ -52,7 +50,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function update(Eloquent $model, array $data) { - // TODO: Implement update() method. throw new NotImplementedException; } @@ -67,7 +64,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function validate(array $model) { - // TODO: Implement validate() method. throw new NotImplementedException; } @@ -81,7 +77,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function find($objectId) { - // TODO: Implement find() method. throw new NotImplementedException; } @@ -115,7 +110,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } @@ -127,7 +121,6 @@ class TransactionType implements CUDInterface, CommonDatabaseCallsInterface */ public function getByIds(array $ids) { - // TODO: Implement getByIds() method. throw new NotImplementedException; } } diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index 340179db5e..a032068318 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -10,8 +10,6 @@ use Illuminate\Database\Query\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; -// todo add methods to interface - /** * Class Report * diff --git a/app/lib/FireflyIII/Shared/Toolkit/Amount.php b/app/lib/FireflyIII/Shared/Toolkit/Amount.php index a419a6b993..39a1db073b 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Amount.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Amount.php @@ -145,4 +145,4 @@ class Amount return $currency->code; } -} \ No newline at end of file +} diff --git a/app/tests/PiggybankPartTest.php b/app/tests/PiggybankPartTest.php deleted file mode 100644 index 5e98b7f5e4..0000000000 --- a/app/tests/PiggybankPartTest.php +++ /dev/null @@ -1,222 +0,0 @@ -object = new PiggyBankPart; - } - - /** - * Tears down the fixture, for example, closes a network connection. - * This method is called after a test is executed. - */ - protected function tearDown() - { - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getReminder - * @todo Implement testGetReminder(). - */ - public function testGetReminder() - { - $this->object->getReminder(); - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setReminder - * @todo Implement testSetReminder(). - */ - public function testSetReminder() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getStartdate - * @todo Implement testGetStartdate(). - */ - public function testGetStartdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setStartdate - * @todo Implement testSetStartdate(). - */ - public function testSetStartdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getTargetdate - * @todo Implement testGetTargetdate(). - */ - public function testGetTargetdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setTargetdate - * @todo Implement testSetTargetdate(). - */ - public function testSetTargetdate() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getRepetition - * @todo Implement testGetRepetition(). - */ - public function testGetRepetition() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setRepetition - * @todo Implement testSetRepetition(). - */ - public function testSetRepetition() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::hasReminder - * @todo Implement testHasReminder(). - */ - public function testHasReminder() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::percentage - * @todo Implement testPercentage(). - */ - public function testPercentage() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getCurrentamount - * @todo Implement testGetCurrentamount(). - */ - public function testGetCurrentamount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setCurrentamount - * @todo Implement testSetCurrentamount(). - */ - public function testSetCurrentamount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getCumulativeAmount - * @todo Implement testGetCumulativeAmount(). - */ - public function testGetCumulativeAmount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setCumulativeAmount - * @todo Implement testSetCumulativeAmount(). - */ - public function testSetCumulativeAmount() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::getAmountPerBar - * @todo Implement testGetAmountPerBar(). - */ - public function testGetAmountPerBar() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } - - /** - * @covers FireflyIII\Collection\PiggyBankPart::setAmountPerBar - * @todo Implement testSetAmountPerBar(). - */ - public function testSetAmountPerBar() - { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); - } -} diff --git a/app/views/repeatedExpense/index.blade.php b/app/views/repeatedExpense/index.blade.php index 9690c5d830..a25336619a 100644 --- a/app/views/repeatedExpense/index.blade.php +++ b/app/views/repeatedExpense/index.blade.php @@ -9,7 +9,6 @@ - @foreach($expenses as $entry)
    diff --git a/bootstrap/start.php b/bootstrap/start.php index a45a61456c..1b7c257703 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -97,5 +97,5 @@ Event::subscribe('FireflyIII\Event\TransactionJournal'); // set very tight rules on all models // create custom uniquely rules. // TODO add "Create new X" button to any list there is: categories, accounts, piggies, etc. -// TODO Install PHP5 and code thing and create very small methods. +// Install PHP5 and code thing and create very small methods. return $app; From 9a3aed80389fc5435156d97485893c319cf50a87 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 10:53:18 +0100 Subject: [PATCH 80/84] Moved code to relate transfers to another class. Still needs some work. --- app/controllers/RelatedController.php | 139 +++++++++++++++++ app/controllers/TransactionController.php | 145 ------------------ .../TransactionJournal/TransactionJournal.php | 33 ---- app/lib/FireflyIII/FF3ServiceProvider.php | 3 + app/lib/FireflyIII/Helper/Related/Related.php | 69 +++++++++ .../Helper/Related/RelatedInterface.php | 29 ++++ app/routes.php | 17 ++ .../relate.blade.php | 0 .../javascript/firefly/related-manager.js | 10 +- 9 files changed, 262 insertions(+), 183 deletions(-) create mode 100644 app/controllers/RelatedController.php create mode 100644 app/lib/FireflyIII/Helper/Related/Related.php create mode 100644 app/lib/FireflyIII/Helper/Related/RelatedInterface.php rename app/views/{transactions => related}/relate.blade.php (100%) diff --git a/app/controllers/RelatedController.php b/app/controllers/RelatedController.php new file mode 100644 index 0000000000..1a65ae4c15 --- /dev/null +++ b/app/controllers/RelatedController.php @@ -0,0 +1,139 @@ +_repository = $repository; + + } + + /** + * @param TransactionJournal $journal + * + * @return \Illuminate\Http\JsonResponse + */ + public function alreadyRelated(TransactionJournal $journal) + { + $ids = []; + /** @var TransactionGroup $group */ + foreach ($journal->transactiongroups()->get() as $group) { + /** @var TransactionJournal $loopJournal */ + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id != $journal->id) { + $ids[] = $loopJournal->id; + } + } + } + $unique = array_unique($ids); + if (count($unique) > 0) { + + $set = $this->_repository->getJournalsByIds($unique); + $set->each( + function (TransactionJournal $journal) { + $journal->amount = Amount::format($journal->getAmount()); + } + ); + + return Response::json($set->toArray()); + } else { + return Response::json((new Collection)->toArray()); + } + } + + /** + * @param TransactionJournal $parentJournal + * @param TransactionJournal $childJournal + * + * @return \Illuminate\Http\JsonResponse + */ + public function relate(TransactionJournal $parentJournal, TransactionJournal $childJournal) + { + $group = new TransactionGroup; + $group->relation = 'balance'; + $group->user_id = $this->_repository->getUser()->id; + $group->save(); + $group->transactionjournals()->save($parentJournal); + $group->transactionjournals()->save($childJournal); + + return Response::json(true); + + } + + /** + * @param TransactionJournal $journal + * + * @return \Illuminate\View\View + */ + public function related(TransactionJournal $journal) + { + $groups = $journal->transactiongroups()->get(); + $members = new Collection; + /** @var TransactionGroup $group */ + foreach ($groups as $group) { + /** @var TransactionJournal $loopJournal */ + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id != $journal->id) { + $members->push($loopJournal); + } + } + } + + return View::make('related.relate', compact('journal', 'members')); + } + + /** + * @param TransactionJournal $parentJournal + * @param TransactionJournal $childJournal + * + * @return \Illuminate\Http\JsonResponse + * @throws Exception + */ + public function removeRelation(TransactionJournal $parentJournal, TransactionJournal $childJournal) + { + $groups = $parentJournal->transactiongroups()->get(); + /** @var TransactionGroup $group */ + foreach ($groups as $group) { + foreach ($group->transactionjournals()->get() as $loopJournal) { + if ($loopJournal->id == $childJournal->id) { + // remove from group: + $group->transactionjournals()->detach($childJournal); + } + } + if ($group->transactionjournals()->count() == 1) { + $group->delete(); + } + } + + return Response::json(true); + } + + /** + * @param TransactionJournal $journal + * + * @return \Illuminate\Http\JsonResponse + */ + public function search(TransactionJournal $journal) + { + + $search = e(trim(Input::get('searchValue'))); + + $result = $this->_repository->search($search, $journal); + $result->each( + function (TransactionJournal $j) { + $j->amount = Amount::format($j->getAmount()); + } + ); + + return Response::json($result->toArray()); + } + +} \ No newline at end of file diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index 167da8a6c0..d62fe5a3cb 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -40,44 +40,6 @@ class TransactionController extends BaseController View::share('mainTitleIcon', 'fa-repeat'); } - /** - * - * TODO this needs cleaning up and thinking over. - * - * @param TransactionJournal $journal - * - * @codeCoverageIgnore - * - * @return array|\Illuminate\Http\JsonResponse - */ - public function alreadyRelated(TransactionJournal $journal) - { - - $ids = []; - /** @var TransactionGroup $group */ - foreach ($journal->transactiongroups()->get() as $group) { - /** @var TransactionJournal $loopJournal */ - foreach ($group->transactionjournals()->get() as $loopJournal) { - if ($loopJournal->id != $journal->id) { - $ids[] = $loopJournal->id; - } - } - } - $unique = array_unique($ids); - if (count($unique) > 0) { - - $set = $this->_repository->getByIds($unique); - $set->each( - function (TransactionJournal $journal) { - $journal->amount = Amount::format($journal->getAmount()); - } - ); - - return Response::json($set->toArray()); - } else { - return (new Collection)->toArray(); - } - } /** * Shows the view helping the user to create a new transaction journal. @@ -156,37 +118,6 @@ class TransactionController extends BaseController return Redirect::route('transactions.index', $return); } - /** - * TODO this needs cleaning up and thinking over. - * - * @return \Illuminate\Http\JsonResponse - * @codeCoverageIgnore - * - */ - public function doRelate() - { - $brother = intval(Input::get('id')); - $sister = intval(Input::get('relateTo')); - - $journal = $this->_repository->find($brother); - $sis = $this->_repository->find($sister); - - if ($journal && $sis) { - $group = new TransactionGroup; - $group->relation = 'balance'; - $group->user_id = $this->_repository->getUser()->id; - $group->save(); - $group->transactionjournals()->save($journal); - $group->transactionjournals()->save($sis); - - return Response::json(true); - } - - return Response::json(false); - - - } - /** * Shows the view to edit a transaction. * @@ -266,54 +197,7 @@ class TransactionController extends BaseController } - /** - * TODO refactor relate stuff into another controller. - * - * @param TransactionJournal $journal - * - * @return \Illuminate\View\View - * @codeCoverageIgnore - * - */ - public function relate(TransactionJournal $journal) - { - $groups = $journal->transactiongroups()->get(); - $members = new Collection; - /** @var TransactionGroup $group */ - foreach ($groups as $group) { - /** @var TransactionJournal $loopJournal */ - foreach ($group->transactionjournals()->get() as $loopJournal) { - if ($loopJournal->id != $journal->id) { - $members->push($loopJournal); - } - } - } - return View::make('transactions.relate', compact('journal', 'members')); - } - - /** - * TODO this needs cleaning up and thinking over. - * - * @param TransactionJournal $journal - * - * @codeCoverageIgnore - * - * @return \Illuminate\Http\JsonResponse - */ - public function relatedSearch(TransactionJournal $journal) - { - $search = e(trim(Input::get('searchValue'))); - - $result = $this->_repository->searchRelated($search, $journal); - $result->each( - function (TransactionJournal $j) { - $j->amount = Amount::format($j->getAmount()); - } - ); - - return Response::json($result->toArray()); - } /** * @param TransactionJournal $journal @@ -401,35 +285,6 @@ class TransactionController extends BaseController return Redirect::route('transactions.create', $data['what'])->withInput(); } - /** - * TODO this needs cleaning up and thinking over. - * - * @param TransactionJournal $journal - * - * @codeCoverageIgnore - * @return \Illuminate\Http\JsonResponse - * @throws Exception - */ - public function unrelate(TransactionJournal $journal) - { - $groups = $journal->transactiongroups()->get(); - $relatedTo = intval(Input::get('relation')); - /** @var TransactionGroup $group */ - foreach ($groups as $group) { - foreach ($group->transactionjournals()->get() as $loopJournal) { - if ($loopJournal->id == $relatedTo) { - // remove from group: - $group->transactionjournals()->detach($relatedTo); - } - } - if ($group->transactionjournals()->count() == 1) { - $group->delete(); - } - } - - return Response::json(true); - - } /** * @param TransactionJournal $journal diff --git a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php index 73bc4e3877..ff7cafa8e2 100644 --- a/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php +++ b/app/lib/FireflyIII/Database/TransactionJournal/TransactionJournal.php @@ -571,37 +571,4 @@ class TransactionJournal implements TransactionJournalInterface, CUDInterface, C return \Paginator::make($items, $count, $limit); } - - /** - * @param string $query - * @param \TransactionJournal $journal - * - * @return Collection - */ - public function searchRelated($query, \TransactionJournal $journal) - { - $start = clone $journal->date; - $end = clone $journal->date; - $start->startOfMonth(); - $end->endOfMonth(); - - // get already related transactions: - $exclude = [$journal->id]; - foreach ($journal->transactiongroups()->get() as $group) { - foreach ($group->transactionjournals() as $current) { - $exclude[] = $current->id; - } - } - $exclude = array_unique($exclude); - - $query = $this->getUser()->transactionjournals() - ->withRelevantData() - ->before($end) - ->after($start) - ->whereNotIn('id', $exclude) - ->where('description', 'LIKE', '%' . $query . '%') - ->get(); - - return $query; - } } diff --git a/app/lib/FireflyIII/FF3ServiceProvider.php b/app/lib/FireflyIII/FF3ServiceProvider.php index 6495f65f51..879313a2d2 100644 --- a/app/lib/FireflyIII/FF3ServiceProvider.php +++ b/app/lib/FireflyIII/FF3ServiceProvider.php @@ -102,6 +102,9 @@ class FF3ServiceProvider extends ServiceProvider $this->app->bind('FireflyIII\Report\ReportInterface', 'FireflyIII\Report\Report'); $this->app->bind('FireflyIII\Report\ReportQueryInterface', 'FireflyIII\Report\ReportQuery'); $this->app->bind('FireflyIII\Report\ReportHelperInterface', 'FireflyIII\Report\ReportHelper'); + + $this->app->bind('FireflyIII\Helper\Related\RelatedInterface', 'FireflyIII\Helper\Related\Related'); + $this->app->bind('FireflyIII\Helper\TransactionJournal\HelperInterface', 'FireflyIII\Helper\TransactionJournal\Helper'); // chart diff --git a/app/lib/FireflyIII/Helper/Related/Related.php b/app/lib/FireflyIII/Helper/Related/Related.php new file mode 100644 index 0000000000..2c54bd6451 --- /dev/null +++ b/app/lib/FireflyIII/Helper/Related/Related.php @@ -0,0 +1,69 @@ +setUser(\Auth::user()); + } + + /** + * @param array $objectIds + * + * @return Collection + */ + public function getJournalsByIds(array $objectIds) + { + /** @var \FireflyIII\Database\TransactionJournal\TransactionJournal $repository */ + $repository = \App::make('FireflyIII\Database\TransactionJournal\TransactionJournal'); + + return $repository->getByIds($objectIds); + } + + /** + * @param string $query + * @param \TransactionJournal $journal + * + * @return Collection + */ + public function search($query, \TransactionJournal $journal) + { + $start = clone $journal->date; + $end = clone $journal->date; + $start->startOfMonth(); + $end->endOfMonth(); + + // get already related transactions: + $exclude = [$journal->id]; + foreach ($journal->transactiongroups()->get() as $group) { + foreach ($group->transactionjournals() as $current) { + $exclude[] = $current->id; + } + } + $exclude = array_unique($exclude); + + $query = $this->getUser()->transactionjournals() + ->withRelevantData() + ->before($end) + ->after($start) + ->whereNotIn('id', $exclude) + ->where('description', 'LIKE', '%' . $query . '%') + ->get(); + + return $query; + } +} \ No newline at end of file diff --git a/app/lib/FireflyIII/Helper/Related/RelatedInterface.php b/app/lib/FireflyIII/Helper/Related/RelatedInterface.php new file mode 100644 index 0000000000..cde8e7e54a --- /dev/null +++ b/app/lib/FireflyIII/Helper/Related/RelatedInterface.php @@ -0,0 +1,29 @@ +where('user_id', Auth::user()->id)->first(); + } + + return null; +} +); Route::bind( 'currency', function ($value, $route) { @@ -247,6 +257,13 @@ Route::group( Route::get('/profile', ['uses' => 'ProfileController@index', 'as' => 'profile']); Route::get('/profile/change-password', ['uses' => 'ProfileController@changePassword', 'as' => 'change-password']); + // related controller: + Route::get('/related/removeRelation/{tj}/{tjSecond}', ['uses' => 'RelatedController@removeRelation','as' => 'related.removeRelation']); + Route::get('/related/related/{tj}', ['uses' => 'RelatedController@related','as' => 'related.related']); + Route::post('/related/search/{tj}', ['uses' => 'RelatedController@search','as' => 'related.search']); + Route::post('/related/relate/{tj}/{tjSecond}', ['uses' => 'RelatedController@relate','as' => 'related.relate']); + Route::get('/related/alreadyRelated/{tj}', ['uses' => 'RelatedController@alreadyRelated','as' => 'related.alreadyRelated']); + // bills controller Route::get('/bills', ['uses' => 'BillController@index', 'as' => 'bills.index']); Route::get('/bills/rescan/{bill}', ['uses' => 'BillController@rescan', 'as' => 'bills.rescan']); # rescan for matching. diff --git a/app/views/transactions/relate.blade.php b/app/views/related/relate.blade.php similarity index 100% rename from app/views/transactions/relate.blade.php rename to app/views/related/relate.blade.php diff --git a/public/assets/javascript/firefly/related-manager.js b/public/assets/javascript/firefly/related-manager.js index dc4171512a..923afb5147 100644 --- a/public/assets/javascript/firefly/related-manager.js +++ b/public/assets/javascript/firefly/related-manager.js @@ -9,7 +9,7 @@ function unrelateTransaction(e) { var id = target.data('id'); var relatedTo = target.data('relatedto'); - $.post('transactions/unrelate/' + relatedTo, {relation: id}).success(function (data) { + $.post('related/removeRelation/' + id + '/' + relatedTo).success(function (data) { target.parent().parent().remove(); }).fail(function () { alert('Could not!'); @@ -23,7 +23,7 @@ function relateTransaction(e) { console.log($('#searchRelated').length); - $('#relationModal').empty().load('transaction/relate/' + ID, function () { + $('#relationModal').empty().load('related/related/' + ID, function () { $('#relationModal').modal('show'); getAlreadyRelatedTransactions(e, ID); @@ -42,7 +42,7 @@ function relateTransaction(e) { function searchRelatedTransactions(e, ID) { var searchValue = $('#relatedSearchValue').val(); if (searchValue != '') { - $.post('transactions/relatedSearch/' + ID, {searchValue: searchValue}).success(function (data) { + $.post('related/search/' + ID, {searchValue: searchValue}).success(function (data) { // post each result to some div. $('#relatedSearchResults').empty(); // TODO this is the worst. @@ -74,7 +74,7 @@ function doRelateNewTransaction(e) { var relateToId = target.data('relateto'); if (!target.checked) { var relateID = target.data('id'); - $.post('transactions/doRelate', {relateTo: relateToId, id: id}).success(function (data) { + $.post('related/relate/' + id + '/' + relateToId).success(function (data) { // success! target.parent().parent().remove(); getAlreadyRelatedTransactions(null, relateToId); @@ -91,7 +91,7 @@ function doRelateNewTransaction(e) { function getAlreadyRelatedTransactions(e, ID) { //#alreadyRelated - $.post('transactions/alreadyRelated/' + ID).success(function (data) { + $.get('related/alreadyRelated/' + ID).success(function (data) { $('#alreadyRelated').empty(); $.each(data, function (i, row) { var tr = $('
    '); From 426d3d948c0ca37f8e57862852134ce2cec48af4 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 10:55:59 +0100 Subject: [PATCH 81/84] Added newlines [skip ci] --- app/controllers/RelatedController.php | 2 +- app/lib/FireflyIII/Helper/Related/Related.php | 2 +- app/lib/FireflyIII/Helper/Related/RelatedInterface.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/RelatedController.php b/app/controllers/RelatedController.php index 1a65ae4c15..747dad5e3f 100644 --- a/app/controllers/RelatedController.php +++ b/app/controllers/RelatedController.php @@ -136,4 +136,4 @@ class RelatedController extends BaseController return Response::json($result->toArray()); } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Helper/Related/Related.php b/app/lib/FireflyIII/Helper/Related/Related.php index 2c54bd6451..0627374e74 100644 --- a/app/lib/FireflyIII/Helper/Related/Related.php +++ b/app/lib/FireflyIII/Helper/Related/Related.php @@ -66,4 +66,4 @@ class Related implements RelatedInterface return $query; } -} \ No newline at end of file +} diff --git a/app/lib/FireflyIII/Helper/Related/RelatedInterface.php b/app/lib/FireflyIII/Helper/Related/RelatedInterface.php index cde8e7e54a..f2072cf823 100644 --- a/app/lib/FireflyIII/Helper/Related/RelatedInterface.php +++ b/app/lib/FireflyIII/Helper/Related/RelatedInterface.php @@ -26,4 +26,4 @@ interface RelatedInterface */ public function getJournalsByIds(array $objectIds); -} \ No newline at end of file +} From 3be1cdb249272680ad4e02dde8c41e14e1ea898b Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 11:04:51 +0100 Subject: [PATCH 82/84] Some cleaning up in the reports. [skip ci] --- app/lib/FireflyIII/Report/Report.php | 32 +------------- app/lib/FireflyIII/Report/ReportQuery.php | 44 ++++++++++++++++++- .../Report/ReportQueryInterface.php | 9 ++++ app/views/reports/year.blade.php | 6 +-- 4 files changed, 57 insertions(+), 34 deletions(-) diff --git a/app/lib/FireflyIII/Report/Report.php b/app/lib/FireflyIII/Report/Report.php index a032068318..56deca08ec 100644 --- a/app/lib/FireflyIII/Report/Report.php +++ b/app/lib/FireflyIII/Report/Report.php @@ -361,36 +361,8 @@ class Report implements ReportInterface */ public function revenueGroupedByAccount(Carbon $start, Carbon $end, $limit = 15) { - return \TransactionJournal:: - leftJoin( - 'transactions as t_from', function (JoinClause $join) { - $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); - } - ) - ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') - ->leftJoin( - 'account_meta as acm_from', function (JoinClause $join) { - $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); - } - ) - ->leftJoin( - 'transactions as t_to', function (JoinClause $join) { - $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); - } - ) - ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') - ->leftJoin( - 'account_meta as acm_to', function (JoinClause $join) { - $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); - } - ) - ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') - ->where('transaction_types.type', 'Deposit') - ->where('acm_to.data', '!=', '"sharedExpense"') - ->before($end)->after($start) - ->where('transaction_journals.user_id', \Auth::user()->id) - ->groupBy('t_from.account_id')->orderBy('sum')->limit(15) - ->get(['t_from.account_id as account_id', 'ac_from.name as name', \DB::Raw('SUM(t_from.amount) as `sum`')]); + return $this->_queries->journalsByRevenueAccount($start, $end); + } diff --git a/app/lib/FireflyIII/Report/ReportQuery.php b/app/lib/FireflyIII/Report/ReportQuery.php index 23d8113363..1a143cbb44 100644 --- a/app/lib/FireflyIII/Report/ReportQuery.php +++ b/app/lib/FireflyIII/Report/ReportQuery.php @@ -3,9 +3,9 @@ namespace FireflyIII\Report; use Carbon\Carbon; +use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Query\JoinClause; use Illuminate\Support\Collection; -use Illuminate\Database\Eloquent\Builder; /** * Class ReportQuery @@ -319,6 +319,48 @@ class ReportQuery implements ReportQueryInterface ->get(['t_to.account_id as id', 'ac_to.name as name', \DB::Raw('SUM(t_to.amount) as `amount`')]); } + /** + * This method returns all deposits into asset accounts, grouped by the revenue account, + * + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByRevenueAccount(Carbon $start, Carbon $end) + { + return \TransactionJournal:: + leftJoin( + 'transactions as t_from', function (JoinClause $join) { + $join->on('t_from.transaction_journal_id', '=', 'transaction_journals.id')->where('t_from.amount', '<', 0); + } + ) + ->leftJoin('accounts as ac_from', 't_from.account_id', '=', 'ac_from.id') + ->leftJoin( + 'account_meta as acm_from', function (JoinClause $join) { + $join->on('ac_from.id', '=', 'acm_from.account_id')->where('acm_from.name', '=', 'accountRole'); + } + ) + ->leftJoin( + 'transactions as t_to', function (JoinClause $join) { + $join->on('t_to.transaction_journal_id', '=', 'transaction_journals.id')->where('t_to.amount', '>', 0); + } + ) + ->leftJoin('accounts as ac_to', 't_to.account_id', '=', 'ac_to.id') + ->leftJoin( + 'account_meta as acm_to', function (JoinClause $join) { + $join->on('ac_to.id', '=', 'acm_to.account_id')->where('acm_to.name', '=', 'accountRole'); + } + ) + ->leftJoin('transaction_types', 'transaction_types.id', '=', 'transaction_journals.transaction_type_id') + ->where('transaction_types.type', 'Deposit') + ->where('acm_to.data', '!=', '"sharedExpense"') + ->before($end)->after($start) + ->where('transaction_journals.user_id', \Auth::user()->id) + ->groupBy('t_from.account_id')->orderBy('amount') + ->get(['t_from.account_id as account_id', 'ac_from.name as name', \DB::Raw('SUM(t_from.amount) as `amount`')]); + } + /** * With an equally misleading name, this query returns are transfers to shared accounts. These are considered * expenses. diff --git a/app/lib/FireflyIII/Report/ReportQueryInterface.php b/app/lib/FireflyIII/Report/ReportQueryInterface.php index 6a729480f6..a2097c6635 100644 --- a/app/lib/FireflyIII/Report/ReportQueryInterface.php +++ b/app/lib/FireflyIII/Report/ReportQueryInterface.php @@ -108,6 +108,15 @@ interface ReportQueryInterface */ public function journalsByExpenseAccount(Carbon $start, Carbon $end); + /** + * This method returns all deposits into asset accounts, grouped by the revenue account, + * @param Carbon $start + * @param Carbon $end + * + * @return Collection + */ + public function journalsByRevenueAccount(Carbon $start, Carbon $end); + /** * With an equally misleading name, this query returns are transfers to shared accounts. These are considered * expenses. diff --git a/app/views/reports/year.blade.php b/app/views/reports/year.blade.php index 2911af39fa..130f29ec55 100644 --- a/app/views/reports/year.blade.php +++ b/app/views/reports/year.blade.php @@ -71,7 +71,7 @@ $incomeSum = 0; $expenseSum = 0; foreach($groupedIncomes as $income) { - $incomeSum += floatval($income->sum); + $incomeSum += floatval($income->amount); } foreach($groupedExpenses as $exp) { $expenseSum += floatval($exp['amount']); @@ -104,10 +104,10 @@
    Amount{{mft($t)}}{{Amount::formatTransaction($t)}}
    New balance{{mf($t->before)}} → {{mf($t->after)}}{{Amount::format($t->before)}} → {{Amount::format($t->after)}}
    @foreach($groupedIncomes as $income) - sum)*-1;?> + amount)*-1;?> - + @endforeach From 5707dc7579528a14808ed2fb1763cbad26a1dba0 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 12:38:13 +0100 Subject: [PATCH 83/84] Lots of cleaning up. --- .gitignore | 1 + app/controllers/BillController.php | 7 ++ app/controllers/PiggybankController.php | 4 +- app/controllers/TransactionController.php | 2 +- .../FireflyIII/Database/Account/Account.php | 7 -- app/lib/FireflyIII/Database/Bill/Bill.php | 67 +++++++++++++ .../Database/Bill/BillInterface.php | 14 +++ app/lib/FireflyIII/Shared/Toolkit/Steam.php | 1 - app/models/Bill.php | 67 ------------- app/models/Piggybank.php | 21 ---- app/models/TransactionJournal.php | 2 - app/routes.php | 4 +- app/views/bills/index.blade.php | 1 - app/views/bills/show.blade.php | 5 +- app/views/categories/show.blade.php | 1 - app/views/list/bills.blade.php | 10 +- app/views/piggy_banks/show.blade.php | 6 +- bootstrap/start.php | 2 +- .../javascript/firefly/related-manager.js | 1 - tests/functional/RelatedControllerCest.php | 99 +++++++++++++++++++ 20 files changed, 201 insertions(+), 121 deletions(-) create mode 100644 tests/functional/RelatedControllerCest.php diff --git a/.gitignore b/.gitignore index 4224919aae..90cd6c6a45 100644 --- a/.gitignore +++ b/.gitignore @@ -24,3 +24,4 @@ tests/_data/db.sqlite tests/_data/dump.sql db.sqlite_snapshot c3.php +db.sqlite-journal diff --git a/app/controllers/BillController.php b/app/controllers/BillController.php index ef25c3ffff..521c21736b 100644 --- a/app/controllers/BillController.php +++ b/app/controllers/BillController.php @@ -83,6 +83,12 @@ class BillController extends BaseController public function index() { $bills = $this->_repository->get(); + $bills->each( + function (Bill $bill) { + $bill->nextExpectedMatch = $this->_repository->nextExpectedMatch($bill); + $bill->lastFoundMatch = $this->_repository->lastFoundMatch($bill); + } + ); return View::make('bills.index', compact('bills')); } @@ -115,6 +121,7 @@ class BillController extends BaseController public function show(Bill $bill) { $journals = $bill->transactionjournals()->withRelevantData()->orderBy('date', 'DESC')->get(); + $bill->nextExpectedMatch = $this->_repository->nextExpectedMatch($bill); $hideBill = true; diff --git a/app/controllers/PiggybankController.php b/app/controllers/PiggybankController.php index 58924755ae..ce7da9f704 100644 --- a/app/controllers/PiggybankController.php +++ b/app/controllers/PiggybankController.php @@ -262,11 +262,9 @@ class PiggyBankController extends BaseController * Number of reminders: */ - $amountPerReminder = $piggyBank->amountPerReminder(); - $remindersCount = $piggyBank->countFutureReminders(); $subTitle = e($piggyBank->name); - return View::make('piggy_banks.show', compact('amountPerReminder', 'remindersCount', 'piggyBank', 'events', 'subTitle')); + return View::make('piggy_banks.show', compact('piggyBank', 'events', 'subTitle')); } diff --git a/app/controllers/TransactionController.php b/app/controllers/TransactionController.php index d62fe5a3cb..a7c9b12e71 100644 --- a/app/controllers/TransactionController.php +++ b/app/controllers/TransactionController.php @@ -249,7 +249,7 @@ class TransactionController extends BaseController $data['transaction_currency_id'] = $transactionCurrency->id; $data['completed'] = 0; $data['what'] = $what; - $data['currency'] = 'EUR'; // TODO allow custom currency + $data['currency'] = 'EUR'; // always validate: $messages = $this->_repository->validate($data); diff --git a/app/lib/FireflyIII/Database/Account/Account.php b/app/lib/FireflyIII/Database/Account/Account.php index 0cfa42dd03..661db8d40c 100644 --- a/app/lib/FireflyIII/Database/Account/Account.php +++ b/app/lib/FireflyIII/Database/Account/Account.php @@ -239,7 +239,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte $q->orWhere( function (QueryBuilder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); - // TODO magic number! $q->where('accounts.account_type_id', 3); $q->where('accounts.active', 0); } @@ -280,7 +279,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte $q->orWhere( function (EloquentBuilder $q) use ($model) { $q->where('accounts.name', 'LIKE', '%' . $model->name . '%'); - // TODO magic number! $q->where('accounts.account_type_id', 3); $q->where('accounts.active', 0); } @@ -324,7 +322,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte $this->storeInitialBalance($account, $data); } - // TODO this needs cleaning up and thinking over. switch ($account->accountType->type) { case 'Asset account': case 'Default account': @@ -352,7 +349,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte $model->name = $data['name']; $model->active = isset($data['active']) ? intval($data['active']) : 0; - // TODO this needs cleaning up and thinking over. switch ($model->accountType->type) { case 'Asset account': case 'Default account': @@ -365,7 +361,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte if (isset($data['openingbalance']) && isset($data['openingbalancedate']) && strlen($data['openingbalancedate']) > 0) { /** @noinspection PhpParamsInspection */ $openingBalance = $this->openingBalanceTransaction($model); - // TODO this needs cleaning up and thinking over. if (is_null($openingBalance)) { $this->storeInitialBalance($model, $data); } else { @@ -483,7 +478,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte */ public function findByWhat($what) { - // TODO: Implement findByWhat() method. throw new NotImplementedException; } @@ -495,7 +489,6 @@ class Account implements CUDInterface, CommonDatabaseCallsInterface, AccountInte */ public function get() { - // TODO: Implement get() method. throw new NotImplementedException; } diff --git a/app/lib/FireflyIII/Database/Bill/Bill.php b/app/lib/FireflyIII/Database/Bill/Bill.php index 65133d8441..6e17ffe827 100644 --- a/app/lib/FireflyIII/Database/Bill/Bill.php +++ b/app/lib/FireflyIII/Database/Bill/Bill.php @@ -202,6 +202,73 @@ class Bill implements CUDInterface, CommonDatabaseCallsInterface, BillInterface } + /** + * @param \Bill $bill + * + * @return Carbon|null + */ + public function lastFoundMatch(\Bill $bill) + { + $last = $bill->transactionjournals()->orderBy('date', 'DESC')->first(); + if ($last) { + return $last->date; + } + + return null; + } + + /** + * @param \Bill $bill + * + * @return Carbon|null + */ + public function nextExpectedMatch(\Bill $bill) + { + /* + * The date Firefly tries to find. If this stays null, it's "unknown". + */ + $finalDate = null; + if ($bill->active == 0) { + return $finalDate; + } + + /* + * $today is the start of the next period, to make sure FF3 won't miss anything + * when the current period has a transaction journal. + */ + $today = \DateKit::addPeriod(new Carbon, $bill->repeat_freq, 0); + + /* + * FF3 loops from the $start of the bill, and to make sure + * $skip works, it adds one (for modulo). + */ + $skip = $bill->skip + 1; + $start = \DateKit::startOfPeriod(new Carbon, $bill->repeat_freq); + /* + * go back exactly one month/week/etc because FF3 does not care about 'next' + * bills if they're too far into the past. + */ + + $counter = 0; + while ($start <= $today) { + if (($counter % $skip) == 0) { + // do something. + $end = \DateKit::endOfPeriod(clone $start, $bill->repeat_freq); + $journalCount = $bill->transactionjournals()->before($end)->after($start)->count(); + if ($journalCount == 0) { + $finalDate = clone $start; + break; + } + } + + // add period for next round! + $start = \DateKit::addPeriod($start, $bill->repeat_freq, 0); + $counter++; + } + + return $finalDate; + } + /** * @param \Bill $bill * @param \TransactionJournal $journal diff --git a/app/lib/FireflyIII/Database/Bill/BillInterface.php b/app/lib/FireflyIII/Database/Bill/BillInterface.php index 6c6a247364..f6dca6325f 100644 --- a/app/lib/FireflyIII/Database/Bill/BillInterface.php +++ b/app/lib/FireflyIII/Database/Bill/BillInterface.php @@ -23,6 +23,20 @@ interface BillInterface */ public function getJournalForBillInRange(\Bill $bill, Carbon $start, Carbon $end); + /** + * @param \Bill $bill + * + * @return Carbon|null + */ + public function lastFoundMatch(\Bill $bill); + + /** + * @param \Bill $bill + * + * @return Carbon|null + */ + public function nextExpectedMatch(\Bill $bill); + /** * @param \Bill $bill * @param \TransactionJournal $journal diff --git a/app/lib/FireflyIII/Shared/Toolkit/Steam.php b/app/lib/FireflyIII/Shared/Toolkit/Steam.php index 03f644bafc..2a2696372f 100644 --- a/app/lib/FireflyIII/Shared/Toolkit/Steam.php +++ b/app/lib/FireflyIII/Shared/Toolkit/Steam.php @@ -16,7 +16,6 @@ class Steam { /** - * TODO find a way to reliably remove cache entries for accounts. * * @param \Account $account * @param Carbon $date diff --git a/app/models/Bill.php b/app/models/Bill.php index 586d1146c1..00d7d2c1e4 100644 --- a/app/models/Bill.php +++ b/app/models/Bill.php @@ -30,21 +30,6 @@ class Bill extends Eloquent return ['created_at', 'updated_at', 'date']; } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * @return null - */ - public function lastFoundMatch() - { - $last = $this->transactionjournals()->orderBy('date', 'DESC')->first(); - if ($last) { - return $last->date; - } - - return null; - } - /** * @return \Illuminate\Database\Eloquent\Relations\HasMany */ @@ -54,58 +39,6 @@ class Bill extends Eloquent } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * Find the next expected match based on the set journals and the date stuff from the bill. - */ - public function nextExpectedMatch() - { - - /* - * The date Firefly tries to find. If this stays null, it's "unknown". - */ - $finalDate = null; - if ($this->active == 0) { - return $finalDate; - } - - /* - * $today is the start of the next period, to make sure FF3 won't miss anything - * when the current period has a transaction journal. - */ - $today = DateKit::addPeriod(new Carbon, $this->repeat_freq, 0); - - /* - * FF3 loops from the $start of the bill, and to make sure - * $skip works, it adds one (for modulo). - */ - $skip = $this->skip + 1; - $start = DateKit::startOfPeriod(new Carbon, $this->repeat_freq); - /* - * go back exactly one month/week/etc because FF3 does not care about 'next' - * bills if they're too far into the past. - */ - - $counter = 0; - while ($start <= $today) { - if (($counter % $skip) == 0) { - // do something. - $end = DateKit::endOfPeriod(clone $start, $this->repeat_freq); - $journalCount = $this->transactionjournals()->before($end)->after($start)->count(); - if ($journalCount == 0) { - $finalDate = clone $start; - break; - } - } - - // add period for next round! - $start = DateKit::addPeriod($start, $this->repeat_freq, 0); - $counter++; - } - - return $finalDate; - } /** * @return \Illuminate\Database\Eloquent\Relations\BelongsTo diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index c3ba7e0054..1e375b7dee 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -37,27 +37,6 @@ class PiggyBank extends Eloquent return $this->belongsTo('Account'); } - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * @return int - */ - public function amountPerReminder() - { - return 0; - - } - - /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * - * @return int - */ - public function countFutureReminders() - { - return 0; - } - /** * TODO remove this method in favour of something in the FireflyIII libraries. * diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index e39a8a4c81..ffbd0f32e5 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -70,8 +70,6 @@ class TransactionJournal extends Eloquent return floatval($t->amount); } } - - return -0.01; } /** diff --git a/app/routes.php b/app/routes.php index 4e37cce682..9513bb3e20 100644 --- a/app/routes.php +++ b/app/routes.php @@ -258,11 +258,11 @@ Route::group( Route::get('/profile/change-password', ['uses' => 'ProfileController@changePassword', 'as' => 'change-password']); // related controller: + Route::get('/related/alreadyRelated/{tj}', ['uses' => 'RelatedController@alreadyRelated','as' => 'related.alreadyRelated']); + Route::post('/related/relate/{tj}/{tjSecond}', ['uses' => 'RelatedController@relate','as' => 'related.relate']); Route::get('/related/removeRelation/{tj}/{tjSecond}', ['uses' => 'RelatedController@removeRelation','as' => 'related.removeRelation']); Route::get('/related/related/{tj}', ['uses' => 'RelatedController@related','as' => 'related.related']); Route::post('/related/search/{tj}', ['uses' => 'RelatedController@search','as' => 'related.search']); - Route::post('/related/relate/{tj}/{tjSecond}', ['uses' => 'RelatedController@relate','as' => 'related.relate']); - Route::get('/related/alreadyRelated/{tj}', ['uses' => 'RelatedController@alreadyRelated','as' => 'related.alreadyRelated']); // bills controller Route::get('/bills', ['uses' => 'BillController@index', 'as' => 'bills.index']); diff --git a/app/views/bills/index.blade.php b/app/views/bills/index.blade.php index 3e1b231ec4..c9319ac213 100644 --- a/app/views/bills/index.blade.php +++ b/app/views/bills/index.blade.php @@ -6,7 +6,6 @@
    {{{$title}}} -
    @include('list.bills') diff --git a/app/views/bills/show.blade.php b/app/views/bills/show.blade.php index b4ad8d9e1e..6437e6fdcb 100644 --- a/app/views/bills/show.blade.php +++ b/app/views/bills/show.blade.php @@ -49,9 +49,8 @@
    @endif - @if($remindersCount > 0) - + - + - @endif
    {{{$income->name}}}{{Amount::format(floatval($income->sum)*-1)}}{{Amount::format(floatval($income->amount)*-1)}}
    Next expected match - nextExpectedMatch();?> - @if($nextExpectedMatch) - {{$nextExpectedMatch->format('j F Y')}} + @if($bill->nextExpectedMatch) + {{$bill->nextExpectedMatch->format('j F Y')}} @else Unknown @endif diff --git a/app/views/categories/show.blade.php b/app/views/categories/show.blade.php index 37fa8d0e2d..bdfefd3e52 100644 --- a/app/views/categories/show.blade.php +++ b/app/views/categories/show.blade.php @@ -22,7 +22,6 @@
    - BLa bla something here.
    diff --git a/app/views/list/bills.blade.php b/app/views/list/bills.blade.php index a603bd9617..1540af42de 100644 --- a/app/views/list/bills.blade.php +++ b/app/views/list/bills.blade.php @@ -32,17 +32,15 @@ {{Amount::format($entry->amount_max)}}     		- lastFoundMatch();?> - @if($lastMatch) - {{$lastMatch->format('j F Y')}} + @if($entry->lastFoundMatch) + {{$entry->lastFoundMatch->format('j F Y')}} @else Unknown @endif - nextExpectedMatch();?> - @if($nextExpectedMatch) - {{$nextExpectedMatch->format('j F Y')}} + @if($entry->nextExpectedMatch) + {{$entry->nextExpectedMatch->format('j F Y')}} @else Unknown @endif diff --git a/app/views/piggy_banks/show.blade.php b/app/views/piggy_banks/show.blade.php index 47c4e86327..f11b4a74ac 100644 --- a/app/views/piggy_banks/show.blade.php +++ b/app/views/piggy_banks/show.blade.php @@ -88,16 +88,14 @@
    Reminders left{{$remindersCount}}(in progress...)
    Expected amount per reminder{{Amount::format($amountPerReminder)}}(in progress...)
    diff --git a/bootstrap/start.php b/bootstrap/start.php index 1b7c257703..30dc7625b0 100644 --- a/bootstrap/start.php +++ b/bootstrap/start.php @@ -96,6 +96,6 @@ Event::subscribe('FireflyIII\Event\TransactionJournal'); // see if the various has-many-throughs actually get used. // set very tight rules on all models // create custom uniquely rules. -// TODO add "Create new X" button to any list there is: categories, accounts, piggies, etc. +// add "Create new X" button to any list there is: categories, accounts, piggies, etc. // Install PHP5 and code thing and create very small methods. return $app; diff --git a/public/assets/javascript/firefly/related-manager.js b/public/assets/javascript/firefly/related-manager.js index 923afb5147..2c3e55f8af 100644 --- a/public/assets/javascript/firefly/related-manager.js +++ b/public/assets/javascript/firefly/related-manager.js @@ -45,7 +45,6 @@ function searchRelatedTransactions(e, ID) { $.post('related/search/' + ID, {searchValue: searchValue}).success(function (data) { // post each result to some div. $('#relatedSearchResults').empty(); - // TODO this is the worst. $.each(data, function (i, row) { var tr = $(''); diff --git a/tests/functional/RelatedControllerCest.php b/tests/functional/RelatedControllerCest.php new file mode 100644 index 0000000000..629ee5e975 --- /dev/null +++ b/tests/functional/RelatedControllerCest.php @@ -0,0 +1,99 @@ +amLoggedAs(['email' => 'thegrumpydictator@gmail.com', 'password' => 'james']); + + } + + public function alreadyRelated(FunctionalTester $I) + { + $group = TransactionGroup::first(); + $journal = $group->transactionjournals()->first(); + + $I->wantTo('see already related transactions'); + $I->amOnPage('/related/alreadyRelated/' . $journal->id); + $I->see('Big expense in '); + + } + + public function alreadyRelatedNoRelations(FunctionalTester $I) + { + $journal = TransactionJournal::first(); + + $I->wantTo('see already related transactions for a journal without any'); + $I->amOnPage('/related/alreadyRelated/' . $journal->id); + $I->see('[]'); + + } + + public function relate(FunctionalTester $I) + { + $journal = TransactionJournal::leftJoin( + 'transaction_group_transaction_journal', 'transaction_journals.id', '=', 'transaction_group_transaction_journal.transaction_journal_id' + ) + ->whereNull('transaction_group_transaction_journal.transaction_group_id')->first(['transaction_journals.*']); + $otherJournal = TransactionJournal::leftJoin( + 'transaction_group_transaction_journal', 'transaction_journals.id', '=', 'transaction_group_transaction_journal.transaction_journal_id' + ) + ->whereNull('transaction_group_transaction_journal.transaction_group_id')->where( + 'transaction_journals.id', '!=', $journal->id + )->first( + ['transaction_journals.*'] + ); + $I->wantTo('relate two journals'); + $I->sendAjaxPostRequest('/related/relate/' . $journal->id . '/' . $otherJournal->id); + $I->see('true'); + } + + public function related(FunctionalTester $I) + { + $group = TransactionGroup::first(); + $journal = $group->transactionjournals()->first(); + + $I->wantTo('see the popup with already related transactions'); + $I->amOnPage('/related/related/' . $journal->id); + $I->see('Big expense in '); + } + + public function removeRelation(FunctionalTester $I) + { + $group = TransactionGroup::first(); + $one = $group->transactionjournals[0]; + $two = $group->transactionjournals[1]; + $I->wantTo('relate two journals'); + $I->amOnPage('/related/removeRelation/' . $one->id . '/' . $two->id); + $I->see('true'); + + } + + public function search(FunctionalTester $I) + { + $group = TransactionGroup::first(); + $one = $group->transactionjournals[0]; + + $I->wantTo('search for a transaction to relate'); + + $I->sendAjaxPostRequest('/related/search/' . $one->id . '?searchValue=expense'); + $I->see('Big expense in'); + } +} \ No newline at end of file From 423f9fefa9506267a8d654874e81910b26fc4e38 Mon Sep 17 00:00:00 2001 From: James Cole Date: Fri, 2 Jan 2015 12:42:29 +0100 Subject: [PATCH 84/84] Removed todo entries and made issues instead. [skip ci] --- app/models/LimitRepetition.php | 1 - app/models/Piggybank.php | 2 -- app/models/TransactionJournal.php | 2 -- 3 files changed, 5 deletions(-) diff --git a/app/models/LimitRepetition.php b/app/models/LimitRepetition.php index 4d38d9054f..fc9eec5943 100644 --- a/app/models/LimitRepetition.php +++ b/app/models/LimitRepetition.php @@ -34,7 +34,6 @@ class LimitRepetition extends Eloquent } /** - * TODO remove this method in favour of something in the FireflyIII libraries. * * @return float */ diff --git a/app/models/Piggybank.php b/app/models/Piggybank.php index 1e375b7dee..49e7563445 100644 --- a/app/models/Piggybank.php +++ b/app/models/Piggybank.php @@ -38,8 +38,6 @@ class PiggyBank extends Eloquent } /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * * Grabs the PiggyBankRepetition that's currently relevant / active * * @returns \PiggyBankRepetition diff --git a/app/models/TransactionJournal.php b/app/models/TransactionJournal.php index ffbd0f32e5..48b25b2ece 100644 --- a/app/models/TransactionJournal.php +++ b/app/models/TransactionJournal.php @@ -53,8 +53,6 @@ class TransactionJournal extends Eloquent } /** - * TODO remove this method in favour of something in the FireflyIII libraries. - * * @param Account $account * * @return float