diff --git a/app/Generator/Chart/Account/ChartJsAccountChartGenerator.php b/app/Generator/Chart/Account/ChartJsAccountChartGenerator.php index b084678de0..a6ab113571 100644 --- a/app/Generator/Chart/Account/ChartJsAccountChartGenerator.php +++ b/app/Generator/Chart/Account/ChartJsAccountChartGenerator.php @@ -20,6 +20,7 @@ class ChartJsAccountChartGenerator implements AccountChartGenerator /** * @codeCoverageIgnore + * * @param Collection $accounts * @param Carbon $start * @param Carbon $end diff --git a/app/Generator/Chart/Budget/GoogleBudgetChartGenerator.php b/app/Generator/Chart/Budget/GoogleBudgetChartGenerator.php index a463a6b296..848c493b68 100644 --- a/app/Generator/Chart/Budget/GoogleBudgetChartGenerator.php +++ b/app/Generator/Chart/Budget/GoogleBudgetChartGenerator.php @@ -37,6 +37,7 @@ class GoogleBudgetChartGenerator implements BudgetChartGenerator /** * @codeCoverageIgnore + * * @param Collection $entries * * @return array diff --git a/app/Generator/Chart/Category/ChartJsCategoryChartGenerator.php b/app/Generator/Chart/Category/ChartJsCategoryChartGenerator.php index 49f92827b7..42e17d875c 100644 --- a/app/Generator/Chart/Category/ChartJsCategoryChartGenerator.php +++ b/app/Generator/Chart/Category/ChartJsCategoryChartGenerator.php @@ -17,7 +17,7 @@ class ChartJsCategoryChartGenerator implements CategoryChartGenerator /** * @param Collection $entries - * @param string $dateFormat + * @param string $dateFormat * * @return array */ @@ -76,6 +76,7 @@ class ChartJsCategoryChartGenerator implements CategoryChartGenerator /** * @codeCoverageIgnore + * * @param Collection $entries * * @return array diff --git a/app/Generator/Chart/Category/GoogleCategoryChartGenerator.php b/app/Generator/Chart/Category/GoogleCategoryChartGenerator.php index b6187f64ed..476f90c998 100644 --- a/app/Generator/Chart/Category/GoogleCategoryChartGenerator.php +++ b/app/Generator/Chart/Category/GoogleCategoryChartGenerator.php @@ -99,6 +99,7 @@ class GoogleCategoryChartGenerator implements CategoryChartGenerator $chart->addRowArray($entry); } $chart->generate(); + return $chart->getData(); } diff --git a/app/Generator/Chart/Report/ChartJsReportChartGenerator.php b/app/Generator/Chart/Report/ChartJsReportChartGenerator.php index c1b5cdf5a7..516d2f5332 100644 --- a/app/Generator/Chart/Report/ChartJsReportChartGenerator.php +++ b/app/Generator/Chart/Report/ChartJsReportChartGenerator.php @@ -3,7 +3,6 @@ namespace FireflyIII\Generator\Chart\Report; use Config; -use Grumpydictator\Gchart\GChart; use Illuminate\Support\Collection; use Preferences; @@ -78,6 +77,7 @@ class ChartJsReportChartGenerator implements ReportChartGenerator $data['datasets'][1]['data'][] = round($expense, 2); $data['datasets'][0]['data'][] = round(($income / $count), 2); $data['datasets'][1]['data'][] = round(($expense / $count), 2); + return $data; } } diff --git a/app/Helpers/Csv/Converter/ConverterInterface.php b/app/Helpers/Csv/Converter/ConverterInterface.php index aad4e3999a..f6a0cae84d 100644 --- a/app/Helpers/Csv/Converter/ConverterInterface.php +++ b/app/Helpers/Csv/Converter/ConverterInterface.php @@ -15,6 +15,17 @@ interface ConverterInterface */ public function convert(); + /** + * @param array $data + */ + public function setData(array $data); + + /** + * @param string $field + * + */ + public function setField($field); + /** * @param int $index */ @@ -35,15 +46,4 @@ interface ConverterInterface */ public function setValue($value); - /** - * @param array $data - */ - public function setData(array $data); - - /** - * @param string $field - * - */ - public function setField($field); - } \ No newline at end of file diff --git a/app/Helpers/Csv/Converter/CurrencyCode.php b/app/Helpers/Csv/Converter/CurrencyCode.php index 2e0baf50d5..e416257f92 100644 --- a/app/Helpers/Csv/Converter/CurrencyCode.php +++ b/app/Helpers/Csv/Converter/CurrencyCode.php @@ -1,6 +1,7 @@ accounts()->with('accountType')->orderBy('accounts.name', 'ASC')->get(['accounts.*']); - $list = []; + $list = []; /** @var Account $account */ foreach ($result as $account) { $list[$account->id] = $account->name . ' (' . $account->accountType->type . ')'; diff --git a/app/Helpers/Csv/PostProcessing/Currency.php b/app/Helpers/Csv/PostProcessing/Currency.php index 66c77ef189..f985c6a881 100644 --- a/app/Helpers/Csv/PostProcessing/Currency.php +++ b/app/Helpers/Csv/PostProcessing/Currency.php @@ -1,8 +1,9 @@ data['currency'])) { - $currencyPreference = Preferences::get('currencyPreference', 'EUR'); - $this->data['currency'] = TransactionCurrency::whereCode($currencyPreference->data)->first(); + $currencyPreference = Preferences::get('currencyPreference', 'EUR'); + $this->data['currency'] = TransactionCurrency::whereCode($currencyPreference->data)->first(); } return $this->data; diff --git a/app/Helpers/Csv/PostProcessing/PostProcessorInterface.php b/app/Helpers/Csv/PostProcessing/PostProcessorInterface.php index dc2b04e64c..88a8ad1da7 100644 --- a/app/Helpers/Csv/PostProcessing/PostProcessorInterface.php +++ b/app/Helpers/Csv/PostProcessing/PostProcessorInterface.php @@ -14,15 +14,16 @@ namespace FireflyIII\Helpers\Csv\PostProcessing; * * @package FireflyIII\Helpers\Csv\PostProcessing */ -interface PostProcessorInterface { - - /** - * @param array $data - */ - public function setData(array $data); +interface PostProcessorInterface +{ /** * @return array */ public function process(); + + /** + * @param array $data + */ + public function setData(array $data); } \ No newline at end of file diff --git a/app/Helpers/Csv/Wizard.php b/app/Helpers/Csv/Wizard.php index 92291e7f45..a443fa06f1 100644 --- a/app/Helpers/Csv/Wizard.php +++ b/app/Helpers/Csv/Wizard.php @@ -129,7 +129,7 @@ class Wizard implements WizardInterface */ public function showOptions(array $map) { - $options = []; + $options = []; foreach ($map as $index => $columnRole) { $mapper = Config::get('csv.roles.' . $columnRole . '.mapper'); diff --git a/app/Helpers/Csv/WizardInterface.php b/app/Helpers/Csv/WizardInterface.php index bd938ad248..bd86a21495 100644 --- a/app/Helpers/Csv/WizardInterface.php +++ b/app/Helpers/Csv/WizardInterface.php @@ -1,6 +1,7 @@