Some code cleanup.

This commit is contained in:
James Cole 2016-01-15 13:08:25 +01:00
parent 0809cfdc6d
commit 41f200e630
5 changed files with 32 additions and 27 deletions

View File

@ -10,11 +10,8 @@
namespace FireflyIII\Http\Controllers; namespace FireflyIII\Http\Controllers;
use Auth; use Auth;
use Config;
use ExpandedForm;
use FireflyIII\Http\Requests; use FireflyIII\Http\Requests;
use FireflyIII\Http\Requests\RuleFormRequest; use FireflyIII\Http\Requests\RuleFormRequest;
use FireflyIII\Http\Requests\RuleGroupFormRequest;
use FireflyIII\Models\Rule; use FireflyIII\Models\Rule;
use FireflyIII\Models\RuleAction; use FireflyIII\Models\RuleAction;
use FireflyIII\Models\RuleGroup; use FireflyIII\Models\RuleGroup;
@ -284,14 +281,19 @@ class RuleController extends Controller
Session::flash('gaEventCategory', 'rules'); Session::flash('gaEventCategory', 'rules');
Session::flash('gaEventAction', 'edit-rule'); Session::flash('gaEventAction', 'edit-rule');
return view('rules.rule.edit', compact('rule', 'subTitle', 'primaryTrigger', return view(
'oldTriggers', 'oldActions', 'triggerCount', 'actionCount')); 'rules.rule.edit', compact(
'rule', 'subTitle', 'primaryTrigger',
'oldTriggers', 'oldActions', 'triggerCount', 'actionCount'
)
);
} }
/** /**
* @param RuleRepositoryInterface $repository * @param RuleRepositoryInterface $repository
* @param RuleFormRequest $request * @param RuleFormRequest $request
* @param Rule $rule * @param Rule $rule
*
* @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*/ */
public function updateRule(RuleRepositoryInterface $repository, RuleFormRequest $request, Rule $rule) public function updateRule(RuleRepositoryInterface $repository, RuleFormRequest $request, Rule $rule)
@ -328,10 +330,10 @@ class RuleController extends Controller
} }
/** /**
* @param RuleRepositoryInterface $repository
* @param Rule $rule * @param Rule $rule
* *
* @return View * @return View
* @internal param RuleRepositoryInterface $repository
*/ */
public function deleteRule(Rule $rule) public function deleteRule(Rule $rule)
{ {
@ -346,8 +348,6 @@ class RuleController extends Controller
} }
/** /**
* @param Rule $rule * @param Rule $rule
* @param RuleRepositoryInterface $repository * @param RuleRepositoryInterface $repository

View File

@ -6,7 +6,6 @@ use Auth;
use ExpandedForm; use ExpandedForm;
use FireflyIII\Http\Requests\RuleGroupFormRequest; use FireflyIII\Http\Requests\RuleGroupFormRequest;
use FireflyIII\Models\RuleGroup; use FireflyIII\Models\RuleGroup;
use FireflyIII\Repositories\Rule\RuleRepositoryInterface;
use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface; use FireflyIII\Repositories\RuleGroup\RuleGroupRepositoryInterface;
use Input; use Input;
use Preferences; use Preferences;
@ -53,7 +52,7 @@ class RuleGroupController extends Controller
/** /**
* @param RuleGroupFormRequest $request * @param RuleGroupFormRequest $request
* @param RuleRepositoryInterface $repository * @param RuleGroupRepositoryInterface $repository
* *
* @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
*/ */
@ -104,7 +103,7 @@ class RuleGroupController extends Controller
/** /**
* @param RuleGroupFormRequest $request * @param RuleGroupFormRequest $request
* @param RuleRepositoryInterface $repository * @param RuleGroupRepositoryInterface $repository
* @param RuleGroup $ruleGroup * @param RuleGroup $ruleGroup
* *
* @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @return $this|\Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
@ -135,7 +134,7 @@ class RuleGroupController extends Controller
} }
/** /**
* @param RuleRepositoryInterface $repository * @param RuleGroupRepositoryInterface $repository
* @param RuleGroup $ruleGroup * @param RuleGroup $ruleGroup
* *
* @return View * @return View
@ -156,8 +155,9 @@ class RuleGroupController extends Controller
} }
/** /**
* @param RuleGroupRepositoryInterface $repository
*
* @param RuleGroup $ruleGroup * @param RuleGroup $ruleGroup
* @param RuleRepositoryInterface $repository
* *
* @return \Illuminate\Http\RedirectResponse * @return \Illuminate\Http\RedirectResponse
*/ */
@ -179,7 +179,7 @@ class RuleGroupController extends Controller
/** /**
* @param RuleRepositoryInterface $repository * @param RuleGroupRepositoryInterface $repository
* @param RuleGroup $ruleGroup * @param RuleGroup $ruleGroup
* *
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
@ -193,7 +193,7 @@ class RuleGroupController extends Controller
} }
/** /**
* @param RuleRepositoryInterface $repository * @param RuleGroupRepositoryInterface $repository
* @param RuleGroup $ruleGroup * @param RuleGroup $ruleGroup
* *
* @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector * @return \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector

View File

@ -5,6 +5,11 @@ namespace FireflyIII\Http\Middleware;
use Closure; use Closure;
use FireflyIII\Support\Domain; use FireflyIII\Support\Domain;
/**
* Class Binder
*
* @package FireflyIII\Http\Middleware
*/
class Binder class Binder
{ {
protected $binders = []; protected $binders = [];