IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2024-12-26 17:01:20 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue with casting.

Browse Source
This commit is contained in:
James Cole 2020-04-19 06:00:11 +02:00
parent fbfd8475de
commit 43436ae942
No known key found for this signature in database
GPG Key ID: B5669F9493CDE38D
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/Factory/TransactionJournalFactory.php
View File

@ -607,7 +607,7 @@ class TransactionJournalFactory
// validate source account. // validate source account.
$sourceId = isset($data['source_id']) ? (int) $data['source_id'] : null; $sourceId = isset($data['source_id']) ? (int) $data['source_id'] : null;
$sourceName = $data['source_name'] ?? null; $sourceName = isset($data['source_name']) ? (string) $data['source_name'] : null;
$validSource = $this->accountValidator->validateSource($sourceId, $sourceName, null); $validSource = $this->accountValidator->validateSource($sourceId, $sourceName, null);
// do something with result: // do something with result:
@ -617,7 +617,7 @@ class TransactionJournalFactory
Log::debug('Source seems valid.'); Log::debug('Source seems valid.');
// validate destination account // validate destination account
$destinationId = isset($data['destination_id']) ? (int) $data['destination_id'] : null; $destinationId = isset($data['destination_id']) ? (int) $data['destination_id'] : null;
$destinationName = (string)($data['destination_name'] ?? null); $destinationName = isset($data['destination_name']) ? (string) $data['destination_name'] : null;
$validDestination = $this->accountValidator->validateDestination($destinationId, $destinationName, null); $validDestination = $this->accountValidator->validateDestination($destinationId, $destinationName, null);
// do something with result: // do something with result:
if (false === $validDestination) { if (false === $validDestination) {

4
app/Http/Controllers/Transaction/ConvertController.php
View File

@ -206,9 +206,9 @@ class ConvertController extends Controller
// double check its not an empty string. // double check its not an empty string.
$sourceId = '' === $sourceId || null === $sourceId ? null : (int) $sourceId; $sourceId = '' === $sourceId || null === $sourceId ? null : (int) $sourceId;
$sourceName = '' === $sourceName ? null : $sourceName; $sourceName = '' === $sourceName ? null : (string) $sourceName;
$destinationId = '' === $destinationId || null === $destinationId ? null : (int) $destinationId; $destinationId = '' === $destinationId || null === $destinationId ? null : (int) $destinationId;
$destinationName = (string)('' === $destinationName ? null : $destinationName); $destinationName = '' === $destinationName ? null : (string) $destinationName;
$validSource = $validator->validateSource($sourceId, $sourceName, null); $validSource = $validator->validateSource($sourceId, $sourceName, null);
$validDestination = $validator->validateDestination($destinationId, $destinationName, null); $validDestination = $validator->validateDestination($destinationId, $destinationName, null);

8
app/Validation/TransactionValidation.php
View File

@ -73,8 +73,8 @@ trait TransactionValidation
// validate source account. // validate source account.
$sourceId = isset($transaction['source_id']) ? (int) $transaction['source_id'] : null; $sourceId = isset($transaction['source_id']) ? (int) $transaction['source_id'] : null;
$sourceName = $transaction['source_name'] ?? null; $sourceName = isset($transaction['source_name']) ? (string) $transaction['source_name'] : null;
$sourceIban = $transaction['source_iban'] ?? null; $sourceIban = isset($transaction['source_iban']) ? (string) $transaction['source_iban'] : null;
$validSource = $accountValidator->validateSource($sourceId, $sourceName, $sourceIban); $validSource = $accountValidator->validateSource($sourceId, $sourceName, $sourceIban);
// do something with result: // do something with result:
@ -86,8 +86,8 @@ trait TransactionValidation
} }
// validate destination account // validate destination account
$destinationId = isset($transaction['destination_id']) ? (int) $transaction['destination_id'] : null; $destinationId = isset($transaction['destination_id']) ? (int) $transaction['destination_id'] : null;
$destinationName = $transaction['destination_name'] ?? null; $destinationName = isset($transaction['destination_name']) ? (string) $transaction['destination_name'] : null;
$destinationIban = $transaction['destination_iban'] ?? null; $destinationIban = isset($transaction['destination_iban']) ? (string) $transaction['destination_iban'] : null;
$validDestination = $accountValidator->validateDestination($destinationId, $destinationName, $destinationIban); $validDestination = $accountValidator->validateDestination($destinationId, $destinationName, $destinationIban);
// do something with result: // do something with result:
if (false === $validDestination) { if (false === $validDestination) {