Remove TODO's.

This commit is contained in:
James Cole
2021-06-12 14:14:49 +02:00
parent 91b08d1772
commit 4614625f82
22 changed files with 54 additions and 54 deletions

View File

@@ -198,19 +198,19 @@ export default {
if (this.transactionType.toString() !== '' && this.index > 0) {
if (this.transactionType.toString().toLowerCase() === 'transfer') {
this.inputDisabled = true;
// todo: needs to copy value from very first input
// See reference nr. 2
return;
}
if (this.transactionType.toString().toLowerCase() === 'withdrawal' && this.inputName.substr(0, 6).toLowerCase() === 'source') {
// todo also clear value?
// See reference nr. 3
this.inputDisabled = true;
return;
}
if (this.transactionType.toString().toLowerCase() === 'deposit' && this.inputName.substr(0, 11).toLowerCase() === 'destination') {
// todo also clear value?
// See reference nr. 4
this.inputDisabled = true;
}
}
@@ -240,7 +240,7 @@ export default {
this.$emit('clear:value')
},
handleEnter: function (e) {
// todo feels sloppy
// See reference nr. 5
if (e.keyCode === 13) {
//e.preventDefault();
}

View File

@@ -166,7 +166,7 @@ export default {
this.$emit('input', this.name.name);
},
handleEnter: function (e) {
// todo feels sloppy
// See reference nr. 1
if (e.keyCode === 13) {
//e.preventDefault();
}

View File

@@ -96,7 +96,7 @@ export default {
};
},
computed: {
// TODO this seems a pretty weird way of doing it.
// See reference nr. 6
dateComponent() {
return 'custom-date';
},

View File

@@ -138,7 +138,7 @@ export default {
this.$emit('input', this.$refs.descr.value);
},
handleEnter: function (e) {
// todo feels sloppy
// See reference nr. 7
if (e.keyCode === 13) {
//e.preventDefault();

View File

@@ -125,7 +125,7 @@
{% if journal.reconciled %}
<span class="fa fa-check" aria-hidden="true"></span>
{% else %}
<!-- TODO include icon -->
<!-- See reference nr. 1 -->
{% endif %}
{% endif %}

View File

@@ -16,7 +16,7 @@
<td data-value="{{ transaction.description }}">{{ transaction.description }}</td>
<td data-value="{{ transaction.date.format('Y-m-d') }}">
{{ transaction.date.formatLocalized(monthAndDayFormat) }}
</td><!-- TODO i dont think transactionAmount will work -->
</td><!-- See reference nr. 3 -->
<td style="text-align: right;" data-value="{{ transaction.amount}}"><span
style="margin-right:5px;">

View File

@@ -3,7 +3,7 @@
<a href="#" class="btn btn-danger btn-sm remove-action"><span class="fa fa-trash"></span></a>
</td>
<td style="width:30%;">
{# todo error when invalid name. #}
{# See reference nr. 2 #}
<select name="actions[{{ count }}][type]" class="form-control">
{% for key,type in allRuleActions() %}
<option value="{{ key }}" label="{{ type }}" {% if key == oldAction %} selected{% endif %}>{{ type }}</option>