Fix some issues that triggered in scrutinizer.

app/Helpers/Attachments/AttachmentHelper.php

@@ -249,7 +249,7 @@ class AttachmentHelper implements AttachmentHelperInterface
             $attachment->filename = $file->getClientOriginalName();
             $attachment->mime     = $file->getMimeType();
             $attachment->size     = $file->getSize();
-            $attachment->uploaded = 0;
+            $attachment->uploaded = false;
             $attachment->save();
             Log::debug('Created attachment:', $attachment->toArray());
 

app/Models/Category.php

@@ -22,6 +22,7 @@ declare(strict_types=1);
 
 namespace FireflyIII\Models;
 
+use Carbon\Carbon;
 use Crypt;
 use FireflyIII\User;
 use Illuminate\Database\Eloquent\Model;

app/Repositories/ImportJob/ImportJobRepository.php

@@ -300,7 +300,7 @@ class ImportJobRepository implements ImportJobRepositoryInterface
         $attachment->filename = $name;
         $attachment->mime     = 'plain/txt';
         $attachment->size     = \strlen($content);
-        $attachment->uploaded = 0;
+        $attachment->uploaded = false;
         $attachment->save();
         $encrypted = Crypt::encrypt($content);
 
@@ -351,7 +351,7 @@ class ImportJobRepository implements ImportJobRepositoryInterface
         $attachment->filename = $name;
         $attachment->mime     = $file->getMimeType();
         $attachment->size     = $file->getSize();
-        $attachment->uploaded = 0;
+        $attachment->uploaded = false;
         $attachment->save();
         $fileObject = $file->openFile('r');
         $fileObject->rewind();

app/Repositories/Rule/RuleRepository.php

@@ -288,7 +288,7 @@ class RuleRepository implements RuleRepositoryInterface
 
         $rule->rule_group_id   = $data['rule_group_id'];
         $rule->order           = ($order + 1);
-        $rule->active          = 1;
+        $rule->active          = true;
         $rule->strict          = $data['strict'] ?? false;
         $rule->stop_processing = 1 === (int)$data['stop-processing'];
         $rule->title           = $data['title'];
@@ -316,7 +316,7 @@ class RuleRepository implements RuleRepositoryInterface
         $ruleAction = new RuleAction;
         $ruleAction->rule()->associate($rule);
         $ruleAction->order           = $values['order'];
-        $ruleAction->active          = 1;
+        $ruleAction->active          = true;
         $ruleAction->stop_processing = $values['stopProcessing'];
         $ruleAction->action_type     = $values['action'];
         $ruleAction->action_value    = $values['value'] ?? '';
@@ -336,7 +336,7 @@ class RuleRepository implements RuleRepositoryInterface
         $ruleTrigger = new RuleTrigger;
         $ruleTrigger->rule()->associate($rule);
         $ruleTrigger->order           = $values['order'];
-        $ruleTrigger->active          = 1;
+        $ruleTrigger->active          = true;
         $ruleTrigger->stop_processing = $values['stopProcessing'];
         $ruleTrigger->trigger_type    = $values['action'];
         $ruleTrigger->trigger_value   = $values['value'] ?? '';

app/Rules/BelongsUser.php

@@ -52,7 +52,7 @@ class BelongsUser implements Rule
      *
      * @return string
      */
-    public function message()
+    public function message(): string
     {
         return (string)trans('validation.belongs_user');
     }

app/Support/FireflyConfig.php

@@ -51,7 +51,7 @@ class FireflyConfig
 
     /**
      * @param string $name
-     * @param null   $default
+     * @param mixed   $default
      *
      * @return \FireflyIII\Models\Configuration|null
      */
@@ -79,7 +79,7 @@ class FireflyConfig
 
     /**
      * @param string $name
-     * @param null   $default
+     * @param mixed   $default
      *
      * @return \FireflyIII\Models\Configuration|null
      */

app/Support/Preferences.php

@@ -80,7 +80,7 @@ class Preferences
 
     /**
      * @param string $name
-     * @param null   $default
+     * @param mixed   $default
      *
      * @return \FireflyIII\Models\Preference|null
      */

app/TransactionRules/Triggers/AmountExactly.php

@@ -43,11 +43,11 @@ final class AmountExactly extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/AmountLess.php

@@ -43,11 +43,11 @@ final class AmountLess extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/AmountMore.php

@@ -43,11 +43,11 @@ final class AmountMore extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = 0 === bccomp('0', (string)$value);

app/TransactionRules/Triggers/BudgetIs.php

@@ -43,11 +43,11 @@ final class BudgetIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/CategoryIs.php

@@ -43,11 +43,11 @@ final class CategoryIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/CurrencyIs.php

@@ -44,11 +44,11 @@ final class CurrencyIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/DescriptionContains.php

@@ -42,11 +42,11 @@ final class DescriptionContains extends AbstractTrigger implements TriggerInterf
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/DescriptionEnds.php

@@ -42,11 +42,11 @@ final class DescriptionEnds extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/DescriptionIs.php

@@ -42,11 +42,11 @@ final class DescriptionIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/DescriptionStarts.php

@@ -42,11 +42,11 @@ final class DescriptionStarts extends AbstractTrigger implements TriggerInterfac
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/FromAccountContains.php

@@ -43,11 +43,11 @@ final class FromAccountContains extends AbstractTrigger implements TriggerInterf
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/FromAccountEnds.php

@@ -43,11 +43,11 @@ final class FromAccountEnds extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/FromAccountIs.php

@@ -43,11 +43,11 @@ final class FromAccountIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/FromAccountStarts.php

@@ -43,11 +43,11 @@ final class FromAccountStarts extends AbstractTrigger implements TriggerInterfac
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/HasAnyBudget.php

@@ -43,11 +43,11 @@ final class HasAnyBudget extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/HasAnyCategory.php

@@ -43,11 +43,11 @@ final class HasAnyCategory extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/HasAnyTag.php

@@ -42,11 +42,11 @@ final class HasAnyTag extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/HasAttachment.php

@@ -42,11 +42,11 @@ class HasAttachment extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         $value = (int)$value;
 

app/TransactionRules/Triggers/HasNoBudget.php

@@ -43,11 +43,11 @@ final class HasNoBudget extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/HasNoCategory.php

@@ -43,11 +43,11 @@ final class HasNoCategory extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/HasNoTag.php

@@ -42,11 +42,11 @@ final class HasNoTag extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/NotesAny.php

@@ -43,11 +43,11 @@ final class NotesAny extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/NotesAre.php

@@ -43,11 +43,11 @@ final class NotesAre extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/NotesContain.php

@@ -43,11 +43,11 @@ final class NotesContain extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/NotesEmpty.php

@@ -43,11 +43,11 @@ final class NotesEmpty extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return false;
     }

app/TransactionRules/Triggers/NotesEnd.php

@@ -43,11 +43,11 @@ final class NotesEnd extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/NotesStart.php

@@ -43,11 +43,11 @@ final class NotesStart extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/TagIs.php

@@ -43,11 +43,11 @@ final class TagIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/ToAccountContains.php

@@ -43,11 +43,11 @@ final class ToAccountContains extends AbstractTrigger implements TriggerInterfac
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/ToAccountEnds.php

@@ -43,11 +43,11 @@ final class ToAccountEnds extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/ToAccountIs.php

@@ -43,11 +43,11 @@ final class ToAccountIs extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/ToAccountStarts.php

@@ -43,11 +43,11 @@ final class ToAccountStarts extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             $res = '' === (string)$value;

app/TransactionRules/Triggers/TransactionType.php

@@ -42,11 +42,11 @@ final class TransactionType extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         if (null !== $value) {
             return false;

app/TransactionRules/Triggers/TriggerInterface.php

@@ -41,11 +41,11 @@ interface TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null);
+    public static function willMatchEverything($value = null): bool;
 
     /**
      * Triggers on a value and journal.

app/TransactionRules/Triggers/UserAction.php

@@ -42,13 +42,13 @@ final class UserAction extends AbstractTrigger implements TriggerInterface
      * (even if it will still include 99.9% of the users transactions), this method MUST return
      * false.
      *
-     * @param null $value
+     * @param mixed $value
      *
      * @codeCoverageIgnore
      *
      * @return bool
      */
-    public static function willMatchEverything($value = null)
+    public static function willMatchEverything($value = null): bool
     {
         return true;
     }