From 5664d516950df46bfd93eda51a1cfc4de53b286e Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Mon, 21 May 2018 20:04:30 +0200
Subject: [PATCH] Fix #1439

---
 public/js/ff/piggy-banks/index.js     | 21 ++++++++-------------
 resources/views/list/piggy-banks.twig |  2 +-
 2 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/public/js/ff/piggy-banks/index.js b/public/js/ff/piggy-banks/index.js
index 6a67810c38..009e2dda6f 100644
--- a/public/js/ff/piggy-banks/index.js
+++ b/public/js/ff/piggy-banks/index.js
@@ -88,28 +88,23 @@ function stopSorting() {
         var holder = $(v);
         var position = parseInt(holder.data('position'));
         var originalOrder = parseInt(holder.data('order'));
+        var name = holder.data('name');
         var id = holder.data('id');
-        console.log('Now at row ' + i);
         var newOrder;
         if (position === i) {
+            // not changed, position is what it should be.
             return;
         }
         if (position < i) {
-            console.log('Row ' + i + ' has moved up!');
-            // update position:
-            holder.data('position', i);
-            newOrder = originalOrder + 1;
-
-
+            // position is less.
+            console.log('"' + name + '" has moved up from position ' + originalOrder + ' to ' + (i+1));
         }
         if (position > i) {
-            console.log('Row ' + i + ' has moved down!');
-            // update position:
-            holder.data('position', i);
-            newOrder = originalOrder - 1;
-
-
+            console.log('"' + name + '" has moved up from position ' + originalOrder + ' to ' + (i+1));
         }
+        // update position:
+        holder.data('position', i);
+        newOrder = i+1;
 
         $.post('piggy-banks/set-order/' + id, {order: newOrder, _token: token})
     });
diff --git a/resources/views/list/piggy-banks.twig b/resources/views/list/piggy-banks.twig
index 2902d639db..c6474908d1 100644
--- a/resources/views/list/piggy-banks.twig
+++ b/resources/views/list/piggy-banks.twig
@@ -14,7 +14,7 @@
     </thead>
     <tbody>
     {% for piggy in piggyBanks %}
-        <tr data-id="{{ piggy.id }}" data-order="{{ piggy.order }}" data-position="{{ loop.index0 }}">
+        <tr data-id="{{ piggy.id }}" data-name="{{ piggy.name }}" data-order="{{ piggy.order }}" data-position="{{ loop.index0 }}">
             <td class="visible-xs visible-sm hidden-md hidden-lg">
                 &nbsp;
             </td>