IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove JSON exceptions that are not thrown anyway.

Browse Source
This commit is contained in:
James Cole 2023-12-22 07:47:13 +01:00
parent 34e22e0747
commit 58dea55d38
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
52 changed files with 105 additions and 211 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Api/V1/Controllers/Autocomplete/AccountController.php
View File

@ -67,7 +67,6 @@ class AccountController extends Controller
* Documentation for this endpoint:
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getAccountsAC
*
* @throws \JsonException
* @throws FireflyException
* @throws FireflyException
*/

3
app/Api/V1/Controllers/Chart/AccountController.php
View File

@ -70,8 +70,7 @@ class AccountController extends Controller
* https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/charts/getChartAccountOverview
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function overview(DateRequest $request): JsonResponse

9
app/Api/V1/Controllers/Models/TransactionCurrency/ShowController.php
View File

@ -71,8 +71,7 @@ class ShowController extends Controller
* Display a listing of the resource.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function index(): JsonResponse
{
$pageSize = $this->parameters->get('limit');
@ -102,8 +101,7 @@ class ShowController extends Controller
* Show a currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function show(TransactionCurrency $currency): JsonResponse
{
/** @var User $user */
@ -131,8 +129,7 @@ class ShowController extends Controller
* Show a currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function showDefault(): JsonResponse
{
/** @var User $user */

3
app/Api/V1/Controllers/Models/TransactionCurrency/StoreController.php
View File

@ -68,8 +68,7 @@ class StoreController extends Controller
* Store new currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(StoreRequest $request): JsonResponse
{
$currency = $this->repository->store($request->getAll());

9
app/Api/V1/Controllers/Models/TransactionCurrency/UpdateController.php
View File

@ -69,8 +69,7 @@ class UpdateController extends Controller
* Disable a currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function disable(TransactionCurrency $currency): JsonResponse
{
// must be unused.
@ -134,8 +133,7 @@ class UpdateController extends Controller
* Enable a currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function enable(TransactionCurrency $currency): JsonResponse
{
$this->repository->enable($currency);
@ -162,8 +160,7 @@ class UpdateController extends Controller
* Update a currency.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(UpdateRequest $request, TransactionCurrency $currency): JsonResponse
{
$data = $request->getAll();

9
app/Console/Commands/Upgrade/MigrateRecurrenceMeta.php
View File

@ -49,8 +49,7 @@ class MigrateRecurrenceMeta extends Command
* Execute the console command.
*
* @throws ContainerExceptionInterface
* @throws \JsonException
* @throws NotFoundExceptionInterface
* * @throws NotFoundExceptionInterface
*/
public function handle(): int
{
@ -88,8 +87,7 @@ class MigrateRecurrenceMeta extends Command
}
/**
* @throws \JsonException
*/
* */
private function migrateMetaData(): int
{
$count = 0;
@ -105,8 +103,7 @@ class MigrateRecurrenceMeta extends Command
}
/**
* @throws \JsonException
*/
* */
private function migrateEntry(RecurrenceMeta $meta): int
{
/** @var null|Recurrence $recurrence */

12
app/Factory/AccountFactory.php
View File

@ -68,8 +68,7 @@ class AccountFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function findOrCreate(string $accountName, string $accountType): Account
{
app('log')->debug(sprintf('findOrCreate("%s", "%s")', $accountName, $accountType));
@ -101,8 +100,7 @@ class AccountFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function create(array $data): Account
{
app('log')->debug('Now in AccountFactory::create()');
@ -173,8 +171,7 @@ class AccountFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function createAccount(AccountType $type, array $data): Account
{
$this->accountRepository->resetAccountOrder();
@ -242,8 +239,7 @@ class AccountFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function cleanMetaDataArray(Account $account, array $data): array
{
$currencyId = array_key_exists('currency_id', $data) ? (int)$data['currency_id'] : 0;

3
app/Factory/BillFactory.php
View File

@ -43,8 +43,7 @@ class BillFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function create(array $data): ?Bill
{
app('log')->debug(sprintf('Now in %s', __METHOD__), $data);

3
app/Factory/RecurrenceFactory.php
View File

@ -52,8 +52,7 @@ class RecurrenceFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function create(array $data): Recurrence
{
try {

3
app/Factory/TransactionGroupFactory.php
View File

@ -49,8 +49,7 @@ class TransactionGroupFactory
*
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
public function create(array $data): TransactionGroup
{
app('log')->debug('Now in TransactionGroupFactory::create()');

21
app/Factory/TransactionJournalFactory.php
View File

@ -91,8 +91,7 @@ class TransactionJournalFactory
*
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
public function create(array $data): Collection
{
app('log')->debug('Now in TransactionJournalFactory::create()');
@ -185,8 +184,7 @@ class TransactionJournalFactory
/**
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
private function createJournal(NullArrayObject $row): ?TransactionJournal
{
$row['import_hash_v2'] = $this->hashArray($row);
@ -346,8 +344,7 @@ class TransactionJournalFactory
}
/**
* @throws \JsonException
*/
* */
private function hashArray(NullArrayObject $row): string
{
$dataRow = $row->getArrayCopy();
@ -364,8 +361,7 @@ class TransactionJournalFactory
* If this transaction already exists, throw an error.
*
* @throws DuplicateTransactionException
* @throws \JsonException
*/
* */
private function errorIfDuplicate(string $hash): void
{
app('log')->debug(sprintf('In errorIfDuplicate(%s)', $hash));
@ -463,8 +459,7 @@ class TransactionJournalFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function getCurrencyByAccount(string $type, ?TransactionCurrency $currency, Account $source, Account $destination): TransactionCurrency
{
app('log')->debug('Now in getCurrencyByAccount()');
@ -477,8 +472,7 @@ class TransactionJournalFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function getCurrency(?TransactionCurrency $currency, Account $account): TransactionCurrency
{
app('log')->debug('Now in getCurrency()');
@ -512,8 +506,7 @@ class TransactionJournalFactory
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function getForeignByAccount(string $type, ?TransactionCurrency $foreignCurrency, Account $destination): ?TransactionCurrency
{
if (TransactionType::TRANSFER === $type) {

6
app/Generator/Report/Audit/MonthReportGenerator.php
View File

@ -45,8 +45,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
* Generates the report.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function generate(): string
{
$auditData = [];
@ -111,8 +110,7 @@ class MonthReportGenerator implements ReportGeneratorInterface
* Get the audit report.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getAuditReport(Account $account, Carbon $date): array
{
/** @var AccountRepositoryInterface $accountRepository */

6
app/Generator/Webhook/StandardMessageGenerator.php
View File

@ -115,8 +115,7 @@ class StandardMessageGenerator implements MessageGeneratorInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function runWebhook(Webhook $webhook): void
{
app('log')->debug(sprintf('Now in runWebhook(#%d)', $webhook->id));
@ -129,8 +128,7 @@ class StandardMessageGenerator implements MessageGeneratorInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function generateMessage(Webhook $webhook, Model $model): void
{
$class = get_class($model);

6
app/Http/Controllers/Account/IndexController.php
View File

@ -69,8 +69,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function inactive(Request $request, string $objectType)
@ -125,8 +124,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Request $request, string $objectType)

9
app/Http/Controllers/Account/ReconcileController.php
View File

@ -76,8 +76,7 @@ class ReconcileController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function reconcile(Account $account, Carbon $start = null, Carbon $end = null)
@ -151,8 +150,7 @@ class ReconcileController extends Controller
* @return Redirector|RedirectResponse
*
* @throws DuplicateTransactionException
* @throws \JsonException
*/
* */
public function submit(ReconciliationStoreRequest $request, Account $account, Carbon $start, Carbon $end)
{
if (!$this->isEditableAccount($account)) {
@ -194,8 +192,7 @@ class ReconcileController extends Controller
* Creates a reconciliation group.
*
* @throws DuplicateTransactionException
* @throws \JsonException
*/
* */
private function createReconciliation(Account $account, Carbon $start, Carbon $end, string $difference): string
{
if (!$this->isEditableAccount($account)) {

6
app/Http/Controllers/Account/ShowController.php
View File

@ -76,8 +76,7 @@ class ShowController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function show(Request $request, Account $account, Carbon $start = null, Carbon $end = null)
@ -162,8 +161,7 @@ class ShowController extends Controller
* @return Factory|Redirector|RedirectResponse|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function showAll(Request $request, Account $account)

3
app/Http/Controllers/Budget/IndexController.php
View File

@ -86,8 +86,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function index(Carbon $start = null, Carbon $end = null)

18
app/Http/Controllers/Chart/AccountController.php
View File

@ -79,8 +79,7 @@ class AccountController extends Controller
*
* This chart is (multi) currency aware.
*
* @throws \JsonException
*/
* */
public function expenseAccounts(): JsonResponse
{
/** @var Carbon $start */
@ -298,8 +297,7 @@ class AccountController extends Controller
* Shows the balances for all the user's frontpage accounts.
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function frontpage(AccountRepositoryInterface $repository): JsonResponse
@ -386,8 +384,7 @@ class AccountController extends Controller
* Shows overview of account during a single period.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function period(Account $account, Carbon $start, Carbon $end): JsonResponse
{
$chartData = [];
@ -423,8 +420,7 @@ class AccountController extends Controller
* TODO this chart is not multi currency aware.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function report(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{
return response()->json($this->accountBalanceChart($accounts, $start, $end));
@ -435,8 +431,7 @@ class AccountController extends Controller
*
* This chart is multi-currency aware.
*
* @throws \JsonException
*/
* */
public function revenueAccounts(): JsonResponse
{
/** @var Carbon $start */
@ -526,8 +521,7 @@ class AccountController extends Controller
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function periodByCurrency(Carbon $start, Carbon $end, Account $account, TransactionCurrency $currency): array
{
app('log')->debug(sprintf('Now in periodByCurrency("%s", "%s", %s, "%s")', $start->format('Y-m-d'), $end->format('Y-m-d'), $account->id, $currency->code));

3
app/Http/Controllers/Chart/ExpenseReportController.php
View File

@ -71,8 +71,7 @@ class ExpenseReportController extends Controller
*
* TODO this chart is not multi currency aware.
*
* @throws \JsonException
*/
* */
public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse
{
$cache = new CacheProperties();

3
app/Http/Controllers/Chart/ReportController.php
View File

@ -133,8 +133,7 @@ class ReportController extends Controller
/**
* Shows income and expense, debit/credit: operations.
*
* @throws \JsonException
*/
* */
public function operations(Collection $accounts, Carbon $start, Carbon $end): JsonResponse
{
// chart properties for cache:

3
app/Http/Controllers/JavascriptController.php
View File

@ -97,8 +97,7 @@ class JavascriptController extends Controller
* Show some common variables to be used in scripts.
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function variables(Request $request, AccountRepositoryInterface $repository): Response

6
app/Http/Controllers/Json/ReconcileController.php
View File

@ -65,8 +65,7 @@ class ReconcileController extends Controller
* Overview of reconciliation.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function overview(Request $request, Account $account = null, Carbon $start = null, Carbon $end = null): JsonResponse
{
$startBalance = $request->get('startBalance');
@ -166,8 +165,7 @@ class ReconcileController extends Controller
* @return JsonResponse
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function transactions(Account $account, Carbon $start = null, Carbon $end = null)
{
if (null === $start || null === $end) {

3
app/Http/Controllers/PiggyBank/IndexController.php
View File

@ -74,8 +74,7 @@ class IndexController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function index()
{
$this->cleanupObjectGroups();

3
app/Http/Controllers/PiggyBank/ShowController.php
View File

@ -66,8 +66,7 @@ class ShowController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function show(PiggyBank $piggyBank)
{
/** @var Carbon $end */

6
app/Http/Controllers/Report/BudgetController.php
View File

@ -66,8 +66,7 @@ class BudgetController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function accountPerBudget(Collection $accounts, Collection $budgets, Carbon $start, Carbon $end)
{
/** @var BudgetReportGenerator $generator */
@ -258,8 +257,7 @@ class BudgetController extends Controller
* @return string
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function general(Collection $accounts, Carbon $start, Carbon $end)
{
/** @var BudgetReportGenerator $generator */

3
app/Http/Controllers/Transaction/CreateController.php
View File

@ -98,8 +98,7 @@ class CreateController extends Controller
* @return Factory|View
*
* @throws FireflyException
* @throws \JsonException
* @throws ContainerExceptionInterface
* * @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public function create(?string $objectType)

12
app/Repositories/Account/AccountRepository.php
View File

@ -221,8 +221,7 @@ class AccountRepository implements AccountRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getCashAccount(): Account
{
/** @var AccountType $type */
@ -343,8 +342,7 @@ class AccountRepository implements AccountRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getReconciliation(Account $account): ?Account
{
if (AccountType::ASSET !== $account->accountType->type) {
@ -619,8 +617,7 @@ class AccountRepository implements AccountRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): Account
{
/** @var AccountFactory $factory */
@ -632,8 +629,7 @@ class AccountRepository implements AccountRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(Account $account, array $data): Account
{
/** @var AccountUpdateService $service */

15
app/Repositories/Account/AccountTasker.php
View File

@ -42,8 +42,7 @@ class AccountTasker implements AccountTaskerInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getAccountReport(Collection $accounts, Carbon $start, Carbon $end): array
{
$yesterday = clone $start;
@ -110,8 +109,7 @@ class AccountTasker implements AccountTaskerInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getExpenseReport(Carbon $start, Carbon $end, Collection $accounts): array
{
// get all expenses for the given accounts in the given period!
@ -142,8 +140,7 @@ class AccountTasker implements AccountTaskerInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getIncomeReport(Carbon $start, Carbon $end, Collection $accounts): array
{
// get all incomes for the given accounts in the given period!
@ -178,8 +175,7 @@ class AccountTasker implements AccountTaskerInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function groupExpenseByDestination(array $array): array
{
$defaultCurrency = app('amount')->getDefaultCurrencyByUserGroup($this->user->userGroup);
@ -239,8 +235,7 @@ class AccountTasker implements AccountTaskerInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function groupIncomeBySource(array $array): array
{
$defaultCurrency = app('amount')->getDefaultCurrencyByUserGroup($this->user->userGroup);

9
app/Repositories/Bill/BillRepository.php
View File

@ -422,8 +422,7 @@ class BillRepository implements BillRepositoryInterface
/**
* Given the date in $date, this method will return a moment in the future where the bill is expected to be paid.
*
* @throws \JsonException
*/
* */
public function nextExpectedMatch(Bill $bill, Carbon $date): Carbon
{
$cache = new CacheProperties();
@ -464,8 +463,7 @@ class BillRepository implements BillRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): Bill
{
/** @var BillFactory $factory */
@ -645,8 +643,7 @@ class BillRepository implements BillRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(Bill $bill, array $data): Bill
{
/** @var BillUpdateService $service */

6
app/Repositories/Budget/BudgetLimitRepository.php
View File

@ -261,8 +261,7 @@ class BudgetLimitRepository implements BudgetLimitRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): BudgetLimit
{
// if no currency has been provided, use the user's default currency:
@ -317,8 +316,7 @@ class BudgetLimitRepository implements BudgetLimitRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(BudgetLimit $budgetLimit, array $data): BudgetLimit
{
$budgetLimit->amount = array_key_exists('amount', $data) ? $data['amount'] : $budgetLimit->amount;

9
app/Repositories/Budget/BudgetRepository.php
View File

@ -233,8 +233,7 @@ class BudgetRepository implements BudgetRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(Budget $budget, array $data): Budget
{
app('log')->debug('Now in update()');
@ -565,8 +564,7 @@ class BudgetRepository implements BudgetRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): Budget
{
$order = $this->getMaxOrder();
@ -752,8 +750,7 @@ class BudgetRepository implements BudgetRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function updateAutoBudget(Budget $budget, array $data): void
{
// update or create auto-budget:

3
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@ -85,8 +85,7 @@ trait ModifiesPiggyBanks
}
/**
* @throws \JsonException
*/
* */
public function canAddAmount(PiggyBank $piggyBank, string $amount): bool
{
$today = today(config('app.timezone'));

6
app/Repositories/PiggyBank/PiggyBankRepository.php
View File

@ -135,8 +135,7 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
* Used for connecting to a piggy bank.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getExactAmount(PiggyBank $piggyBank, PiggyBankRepetition $repetition, TransactionJournal $journal): string
{
app('log')->debug(sprintf('Now in getExactAmount(%d, %d, %d)', $piggyBank->id, $repetition->id, $journal->id));
@ -320,8 +319,7 @@ class PiggyBankRepository implements PiggyBankRepositoryInterface
/**
* Get for piggy account what is left to put in piggies.
*
* @throws \JsonException
*/
* */
public function leftOnAccount(PiggyBank $piggyBank, Carbon $date): string
{
$balance = app('steam')->balanceIgnoreVirtual($piggyBank->account, $date);

6
app/Repositories/Recurring/RecurringRepository.php
View File

@ -259,8 +259,7 @@ class RecurringRepository implements RecurringRepositoryInterface
/**
* Get the tags from the recurring transaction.
*
* @throws \JsonException
*/
* */
public function getTags(RecurrenceTransaction $transaction): array
{
$tags = [];
@ -480,8 +479,7 @@ class RecurringRepository implements RecurringRepositoryInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): Recurrence
{
/** @var RecurrenceFactory $factory */

6
app/Repositories/TransactionGroup/TransactionGroupRepository.php
View File

@ -255,8 +255,7 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
* Return all piggy bank events for all journals in the group.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function getPiggyEvents(TransactionGroup $group): array
{
$return = [];
@ -319,8 +318,7 @@ class TransactionGroupRepository implements TransactionGroupRepositoryInterface
/**
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
public function store(array $data): TransactionGroup
{
/** @var TransactionGroupFactory $factory */

3
app/Repositories/UserGroups/Currency/CurrencyRepository.php
View File

@ -217,8 +217,7 @@ class CurrencyRepository implements CurrencyRepositoryInterface
* Find by object, ID or code. Returns user default or system default.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function findCurrency(?int $currencyId, ?string $currencyCode): TransactionCurrency
{
$result = $this->findCurrencyNull($currencyId, $currencyCode);

18
app/Services/Internal/Support/AccountServiceTrait.php
View File

@ -188,8 +188,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*
* *
* @deprecated
*/
protected function createOBGroup(Account $account, array $data): TransactionGroup
@ -337,8 +336,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function getCurrency(int $currencyId, string $currencyCode): TransactionCurrency
{
// find currency, or use default currency instead.
@ -362,8 +360,7 @@ trait AccountServiceTrait
* Create the opposing "credit liability" transaction for credit liabilities.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function updateCreditTransaction(Account $account, string $direction, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@ -419,8 +416,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createCreditTransaction(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug('Now going to create an createCreditTransaction.');
@ -514,8 +510,7 @@ trait AccountServiceTrait
* Since opening balance and date can still be empty strings, it may fail.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function updateOBGroupV2(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@ -571,8 +566,7 @@ trait AccountServiceTrait
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createOBGroupV2(Account $account, string $openingBalance, Carbon $openingBalanceDate): TransactionGroup
{
app('log')->debug('Now going to create an OB group.');

6
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@ -87,8 +87,7 @@ trait RecurringTransactionTrait
* Store transactions of a recurring transactions. It's complex but readable.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function createTransactions(Recurrence $recurrence, array $transactions): void
{
app('log')->debug('Now in createTransactions()');
@ -164,8 +163,7 @@ trait RecurringTransactionTrait
}
/**
* @throws \JsonException
*/
* */
protected function findAccount(array $expectedTypes, ?int $accountId, ?string $accountName): Account
{
$result = null;

3
app/Services/Internal/Update/AccountUpdateService.php
View File

@ -63,8 +63,7 @@ class AccountUpdateService
* Update account data.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(Account $account, array $data): Account
{
app('log')->debug(sprintf('Now in %s', __METHOD__));

3
app/Services/Internal/Update/BillUpdateService.php
View File

@ -46,8 +46,7 @@ class BillUpdateService
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(Bill $bill, array $data): Bill
{
$this->user = $bill->user;

9
app/Services/Internal/Update/GroupUpdateService.php
View File

@ -41,8 +41,7 @@ class GroupUpdateService
*
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
public function update(TransactionGroup $transactionGroup, array $data): TransactionGroup
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@ -150,8 +149,7 @@ class GroupUpdateService
/**
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
private function updateTransactions(TransactionGroup $transactionGroup, array $transactions): array
{
app('log')->debug(sprintf('Now in %s', __METHOD__));
@ -208,8 +206,7 @@ class GroupUpdateService
/**
* @throws DuplicateTransactionException
* @throws FireflyException
* @throws \JsonException
*/
* */
private function createTransactionJournal(TransactionGroup $transactionGroup, array $data): ?TransactionJournal
{
$submission = [

3
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@ -192,8 +192,7 @@ class RecurrenceUpdateService
* TODO this method is very complex.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
private function updateTransactions(Recurrence $recurrence, array $transactions): void
{
app('log')->debug('Now in updateTransactions()');

3
app/Support/Http/Controllers/ChartGeneration.php
View File

@ -40,8 +40,7 @@ trait ChartGeneration
* Shows an overview of the account balances for a set of accounts.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
protected function accountBalanceChart(Collection $accounts, Carbon $start, Carbon $end): array // chart helper method.
{
// chart properties for cache:

3
app/Support/Report/Budget/BudgetReportGenerator.php
View File

@ -134,8 +134,7 @@ class BudgetReportGenerator
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
public function setUser(User $user): void
{
$this->repository->setUser($user);

3
app/Support/Steam.php
View File

@ -89,8 +89,7 @@ class Steam
* [yyyy-mm-dd] => 123,2
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function balanceInRange(Account $account, Carbon $start, Carbon $end, ?TransactionCurrency $currency = null): array
{
$cache = new CacheProperties();

6
app/TransactionRules/Actions/ConvertToDeposit.php
View File

@ -121,8 +121,7 @@ class ConvertToDeposit implements ActionInterface
* Is converted to a deposit from C to A.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
private function convertWithdrawalArray(TransactionJournal $journal): bool
{
$user = $journal->user;
@ -211,8 +210,7 @@ class ConvertToDeposit implements ActionInterface
* The source account is replaced.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
private function convertTransferArray(TransactionJournal $journal): bool
{
$user = $journal->user;

6
app/TransactionRules/Actions/ConvertToWithdrawal.php
View File

@ -116,8 +116,7 @@ class ConvertToWithdrawal implements ActionInterface
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function convertDepositArray(TransactionJournal $journal): bool
{
$user = $journal->user;
@ -203,8 +202,7 @@ class ConvertToWithdrawal implements ActionInterface
* Output is a withdrawal from A to C.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
private function convertTransferArray(TransactionJournal $journal): bool
{
// find or create expense account.

6
app/Transformers/AccountTransformer.php
View File

@ -49,8 +49,7 @@ class AccountTransformer extends AbstractTransformer
* Transform the account.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function transform(Account $account): array
{
$this->repository->setUser($account->user);
@ -157,8 +156,7 @@ class AccountTransformer extends AbstractTransformer
/**
* @throws FireflyException
* @throws \JsonException
*/
* */
private function getCurrency(Account $account): array
{
$currency = $this->repository->getAccountCurrency($account);

3
app/Transformers/PiggyBankEventTransformer.php
View File

@ -49,8 +49,7 @@ class PiggyBankEventTransformer extends AbstractTransformer
* Convert piggy bank event.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function transform(PiggyBankEvent $event): array
{
// get account linked to piggy bank

3
app/Transformers/PiggyBankTransformer.php
View File

@ -50,8 +50,7 @@ class PiggyBankTransformer extends AbstractTransformer
* Transform the piggy bank.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function transform(PiggyBank $piggyBank): array
{
$account = $piggyBank->account;

3
app/Transformers/V2/PiggyBankTransformer.php
View File

@ -139,8 +139,7 @@ class PiggyBankTransformer extends AbstractTransformer
* Transform the piggy bank.
*
* @throws FireflyException
* @throws \JsonException
*/
* */
public function transform(PiggyBank $piggyBank): array
{
// $account = $piggyBank->account;

3
app/Validation/Api/Data/Bulk/ValidatesBulkTransactionQuery.php
View File

@ -30,8 +30,7 @@ use Illuminate\Validation\Validator;
trait ValidatesBulkTransactionQuery
{
/**
* @throws \JsonException
*/
* */
protected function validateTransactionQuery(Validator $validator): void
{
$data = $validator->getData();