From 5e41641d7ce70926bf2a84d61476e82956fc44db Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Sun, 27 Jan 2019 07:48:49 +0100
Subject: [PATCH] Simplify account transformer

---
 app/Transformers/AccountTransformer.php | 162 +++++++++++++++++-------
 1 file changed, 119 insertions(+), 43 deletions(-)

diff --git a/app/Transformers/AccountTransformer.php b/app/Transformers/AccountTransformer.php
index 8976eec112..f665e5b4b2 100644
--- a/app/Transformers/AccountTransformer.php
+++ b/app/Transformers/AccountTransformer.php
@@ -70,43 +70,14 @@ class AccountTransformer extends AbstractTransformer
         $liabilityType = '' === $liabilityType ? null : $liabilityType;
 
         // get account role (will only work if the type is asset.
-        $accountRole = $this->repository->getMetaValue($account, 'accountRole');
-        if ('asset' !== $accountType || '' === (string)$accountRole) {
-            $accountRole = null;
-        }
+        $accountRole = $this->getAccountRole($account, $accountType);
+        $date        = $this->getDate();
 
-        // get currency. If not 0, get from repository. TODO test me.
-        $currency       = $this->repository->getAccountCurrency($account);
-        $currencyId     = null;
-        $currencyCode   = null;
-        $decimalPlaces  = 2;
-        $currencySymbol = null;
-        if (null !== $currency) {
-            $currencyId     = $currency->id;
-            $currencyCode   = $currency->code;
-            $decimalPlaces  = $currency->decimal_places;
-            $currencySymbol = $currency->symbol;
-        }
+        [$currencyId, $currencyCode, $currencySymbol, $decimalPlaces] = $this->getCurrency($account);
+        [$creditCardType, $monthlyPaymentDate] = $this->getCCInfo($account, $accountRole, $accountType);
+        [$openingBalance, $openingBalanceDate] = $this->getOpeningBalance($account, $accountType, $decimalPlaces);
+        [$interest, $interestPeriod] = $this->getInterest($account, $accountType);
 
-        $date = new Carbon;
-        if (null !== $this->parameters->get('date')) {
-            $date = $this->parameters->get('date');
-        }
-
-        $monthlyPaymentDate = null;
-        $creditCardType     = null;
-        if ('ccAsset' === $accountRole && 'asset' === $accountType) {
-            $creditCardType     = $this->repository->getMetaValue($account, 'ccType');
-            $monthlyPaymentDate = $this->repository->getMetaValue($account, 'ccMonthlyPaymentDate');
-        }
-
-        $openingBalance     = null;
-        $openingBalanceDate = null;
-        if (\in_array($accountType, ['asset', 'liabilities'], true)) {
-            $amount             = $this->repository->getOpeningBalanceAmount($account);
-            $openingBalance     = null === $amount ? null : round($amount, $decimalPlaces);
-            $openingBalanceDate = $this->repository->getOpeningBalanceDate($account);
-        }
         $liabilityAmount = null;
         $liabilityStart  = null;
         if (null !== $liabilityType) {
@@ -114,13 +85,8 @@ class AccountTransformer extends AbstractTransformer
             $liabilityStart  = $openingBalanceDate;
         }
 
-        $interest       = null;
-        $interestPeriod = null;
-        if ('liabilities' === $accountType) {
-            $interest       = $this->repository->getMetaValue($account, 'interest');
-            $interestPeriod = $this->repository->getMetaValue($account, 'interest_period');
-        }
-        $includeNetworth = '0' !== $this->repository->getMetaValue($account, 'include_net_worth');
+
+        $includeNetWorth = '0' !== $this->repository->getMetaValue($account, 'include_net_worth');
 
         $data = [
             'id'                      => (int)$account->id,
@@ -150,7 +116,7 @@ class AccountTransformer extends AbstractTransformer
             'liability_start_date'    => $liabilityStart,
             'interest'                => $interest,
             'interest_period'         => $interestPeriod,
-            'include_net_worth'       => $includeNetworth,
+            'include_net_worth'       => $includeNetWorth,
             'links'                   => [
                 [
                     'rel' => 'self',
@@ -161,4 +127,114 @@ class AccountTransformer extends AbstractTransformer
 
         return $data;
     }
+
+    /**
+     * @param Account $account
+     *
+     * @param string  $accountType
+     *
+     * @return string
+     */
+    private function getAccountRole(Account $account, string $accountType): string
+    {
+        $accountRole = $this->repository->getMetaValue($account, 'accountRole');
+        if ('asset' !== $accountType || '' === (string)$accountRole) {
+            $accountRole = null;
+        }
+
+        return $accountRole;
+    }
+
+    /**
+     * @param Account $account
+     * @param string  $accountRole
+     * @param string  $accountType
+     *
+     * @return array
+     */
+    private function getCCInfo(Account $account, string $accountRole, string $accountType): array
+    {
+        $monthlyPaymentDate = null;
+        $creditCardType     = null;
+        if ('ccAsset' === $accountRole && 'asset' === $accountType) {
+            $creditCardType     = $this->repository->getMetaValue($account, 'ccType');
+            $monthlyPaymentDate = $this->repository->getMetaValue($account, 'ccMonthlyPaymentDate');
+        }
+
+        return [$creditCardType, $monthlyPaymentDate];
+    }
+
+    /**
+     * @param Account $account
+     *
+     * @return array
+     */
+    private function getCurrency(Account $account): array
+    {
+        $currency       = $this->repository->getAccountCurrency($account);
+        $currencyId     = null;
+        $currencyCode   = null;
+        $decimalPlaces  = 2;
+        $currencySymbol = null;
+        if (null !== $currency) {
+            $currencyId     = $currency->id;
+            $currencyCode   = $currency->code;
+            $decimalPlaces  = $currency->decimal_places;
+            $currencySymbol = $currency->symbol;
+        }
+
+        return [$currencyId, $currencyCode, $currencySymbol, $decimalPlaces];
+    }
+
+    /**
+     * @return Carbon
+     */
+    private function getDate(): Carbon
+    {
+        $date = new Carbon;
+        if (null !== $this->parameters->get('date')) {
+            $date = $this->parameters->get('date');
+        }
+
+        return $date;
+    }
+
+    /**
+     * @param Account $account
+     * @param string  $accountType
+     *
+     * @return array
+     */
+    private function getInterest(Account $account, string $accountType): array
+    {
+        $interest       = null;
+        $interestPeriod = null;
+        if ('liabilities' === $accountType) {
+            $interest       = $this->repository->getMetaValue($account, 'interest');
+            $interestPeriod = $this->repository->getMetaValue($account, 'interest_period');
+        }
+
+        return [$interest, $interestPeriod];
+    }
+
+    /**
+     * @param Account $account
+     * @param string  $accountType
+     *
+     * @param int     $decimalPlaces
+     *
+     * @return array
+     */
+    private function getOpeningBalance(Account $account, string $accountType, int $decimalPlaces): array
+    {
+        $openingBalance     = null;
+        $openingBalanceDate = null;
+        if (\in_array($accountType, ['asset', 'liabilities'], true)) {
+            $amount             = $this->repository->getOpeningBalanceAmount($account);
+            $openingBalance     = null === $amount ? null : round($amount, $decimalPlaces);
+            $openingBalanceDate = $this->repository->getOpeningBalanceDate($account);
+        }
+
+        return [$openingBalance, $openingBalanceDate];
+    }
 }