Remove double lines from code.

This commit is contained in:
James Cole 2019-08-28 16:28:14 +02:00
parent fa706d27d8
commit 5fb7635100
83 changed files with 0 additions and 129 deletions

View File

@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class AccountController.
*
*
*/
class AccountController extends Controller
{

View File

@ -45,7 +45,6 @@ use function strlen;
/**
* Class AttachmentController.
*
*
*/
class AttachmentController extends Controller
{

View File

@ -42,7 +42,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class AvailableBudgetController.
*
*
*/
class AvailableBudgetController extends Controller
{

View File

@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class BillController.
*
*
*/
class BillController extends Controller
{

View File

@ -47,7 +47,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class BudgetController.
*
*
*/
class BudgetController extends Controller
{

View File

@ -46,7 +46,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class BudgetLimitController.
*
*
*/
class BudgetLimitController extends Controller
{

View File

@ -44,7 +44,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class CategoryController.
*
*
*/
class CategoryController extends Controller
{

View File

@ -66,7 +66,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class CurrencyController.
*
*
*/
class CurrencyController extends Controller
{

View File

@ -45,7 +45,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class LinkTypeController.
*
*
*/
class LinkTypeController extends Controller
{

View File

@ -42,7 +42,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class PiggyBankController.
*
*
*/
class PiggyBankController extends Controller
{

View File

@ -43,7 +43,6 @@ use League\Fractal\Serializer\JsonApiSerializer;
/**
* Class UserController.
*
*
*/
class UserController extends Controller
{

View File

@ -256,7 +256,6 @@ class TransactionUpdateRequest extends Request
// // validate foreign currency info
// $this->validateForeignCurrencyInformation($validator);
//
//
//
// // make sure all splits have valid source + dest info

View File

@ -45,7 +45,6 @@ class GracefulNotFoundHandler extends ExceptionHandler
* @param Request $request
* @param Exception $exception
*
*
* @return mixed
*/
public function render($request, Exception $exception)

View File

@ -49,7 +49,6 @@ class Handler extends ExceptionHandler
* @param Request $request
* @param Exception $exception
*
*
* @return mixed
*/
public function render($request, Exception $exception)

View File

@ -196,7 +196,6 @@ class ChartJsGenerator implements GeneratorInterface
* Will generate a (ChartJS) compatible array from the given input. Expects this format:.
*
* 'label-of-entry' => value
* 'label-of-entry' => value
*
* @param string $setLabel
* @param array $data

View File

@ -83,7 +83,6 @@ interface GeneratorInterface
* Will generate a (ChartJS) compatible array from the given input. Expects this format:.
*
* 'label-of-entry' => value
* 'label-of-entry' => value
*
* @param string $setLabel
* @param array $data

View File

@ -19,7 +19,6 @@
* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
*/
/** @noinspection PhpUndefinedMethodInspection */
/** @noinspection PhpUndefinedMethodInspection */
declare(strict_types=1);
namespace FireflyIII\Generator\Report;

View File

@ -43,7 +43,6 @@ class VersionCheckEventHandler
/**
* Checks with GitHub to see if there is a new version.
*
*
* @param RequestedVersionCheckStatus $event
*/
public function checkForUpdates(RequestedVersionCheckStatus $event): void

View File

@ -39,7 +39,6 @@ use View;
/**
* Class ShowController
*
*
*/
class ShowController extends Controller
{

View File

@ -44,7 +44,6 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class BillController.
*
*
*/
class BillController extends Controller
{

View File

@ -36,7 +36,6 @@ use Illuminate\Support\Collection;
*
* Class ShowController
*
*
*/
class ShowController extends Controller
{

View File

@ -43,9 +43,6 @@ use Log;
/**
* Class AccountController.
*
*
*
*
*/
class AccountController extends Controller
{

View File

@ -40,9 +40,6 @@ use Illuminate\Support\Collection;
/**
* Class BudgetController.
*
*
*
*
*/
class BudgetController extends Controller
{

View File

@ -39,7 +39,6 @@ use Illuminate\Support\Collection;
*
* Class BudgetReportController
*
*
*/
class BudgetReportController extends Controller
{

View File

@ -189,7 +189,6 @@ class CategoryReportController extends Controller
*
* @return JsonResponse
*
*
*/
public function mainChart(Collection $accounts, Collection $categories, Carbon $start, Carbon $end): JsonResponse
{

View File

@ -77,7 +77,6 @@ class ExpenseReportController extends Controller
*
* @return JsonResponse
*
*
*/
public function mainChart(Collection $accounts, Collection $expense, Carbon $start, Carbon $end): JsonResponse
{

View File

@ -180,7 +180,6 @@ class TagReportController extends Controller
*
* @return JsonResponse
*
*
*/
public function mainChart(Collection $accounts, Collection $tags, Carbon $start, Carbon $end): JsonResponse
{

View File

@ -33,7 +33,6 @@ use Route;
/**
* Class Controller.
*
*
*/
class Controller extends BaseController
{

View File

@ -39,7 +39,6 @@ use Route as RouteFacade;
/**
* Class DebugController
*
*
*/
class DebugController extends Controller
{

View File

@ -44,7 +44,6 @@ use Log;
*
* TODO autocomplete for transaction types.
*
*
*/
class AutoCompleteController extends Controller
{

View File

@ -41,8 +41,6 @@ use Symfony\Component\HttpFoundation\ParameterBag;
/**
* Class PiggyBankController.
*
*
*
*/
class PiggyBankController extends Controller
{

View File

@ -31,7 +31,6 @@ use Illuminate\Http\Request;
/**
* Class ReportController.
*
*
*/
class ReportController extends Controller
{

View File

@ -52,7 +52,6 @@ use PragmaRX\Recovery\Recovery;
*
* @method Guard guard()
*
*
*/
class ProfileController extends Controller
{

View File

@ -38,7 +38,6 @@ use Log;
/**
* Class ReportController.
*
*
*/
class ReportController extends Controller
{
@ -310,7 +309,6 @@ class ReportController extends Controller
*
* @throws \FireflyIII\Exceptions\FireflyException
*
*
*/
public function postIndex(ReportFormRequest $request)
{

View File

@ -47,7 +47,6 @@ use Throwable;
/**
* Class SelectController.
*
*
*/
class SelectController extends Controller
{

View File

@ -42,7 +42,6 @@ use Log;
/**
* Class MassController.
*
*
*/
class MassController extends Controller
{

View File

@ -46,7 +46,6 @@ class Installer
*
* @return mixed
*
*
* @throws FireflyException
*
*/

View File

@ -139,7 +139,6 @@ class RecurrenceFormRequest extends Request
* @return array
* @throws FireflyException
*
*
*/
public function rules(): array
{

View File

@ -33,7 +33,6 @@ use Log;
*
* @codeCoverageIgnore
*
*
*/
class Request extends FormRequest
{

View File

@ -33,9 +33,6 @@ class Amount implements ConverterInterface
* Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems.
* - Jamie Zawinski.
*
*
*
*
* @param $value
*
* @return string

View File

@ -70,7 +70,6 @@ class FakeJobConfiguration implements JobConfigurationInterface
*
* @return MessageBag
*
*
*/
public function configureJob(array $data): MessageBag
{
@ -128,7 +127,6 @@ class FakeJobConfiguration implements JobConfigurationInterface
*
* @return string
*
*
*/
public function getNextView(): string
{

View File

@ -91,7 +91,6 @@ class FileJobConfiguration implements JobConfigurationInterface
*
* @return string
*
*
*@throws FireflyException
*/
public function getNextView(): string
@ -132,7 +131,6 @@ class FileJobConfiguration implements JobConfigurationInterface
* @return FileConfigurationInterface
* @throws FireflyException
*
*
*/
private function getConfigurationObject(): FileConfigurationInterface
{

View File

@ -111,7 +111,6 @@ class SpectreJobConfiguration implements JobConfigurationInterface
* @return SpectreJobConfigurationInterface
* @throws FireflyException
*
*
*/
private function getHandler(): SpectreJobConfigurationInterface
{

View File

@ -109,7 +109,6 @@ class YnabJobConfiguration implements JobConfigurationInterface
* @return YnabJobConfigurationInterface
* @throws FireflyException
*
*
*/
private function getHandler(): YnabJobConfigurationInterface
{

View File

@ -52,8 +52,6 @@ class FakeRoutine implements RoutineInterface
* @return void
* @throws FireflyException
*
*
*
*/
public function run(): void
{

View File

@ -49,8 +49,6 @@ class SpectreRoutine implements RoutineInterface
*
* @throws FireflyException
*
*
*
*/
public function run(): void
{

View File

@ -64,7 +64,6 @@ class AbnAmroDescription implements SpecificInterface
*
* @return array
*
*
*/
public function run(array $row): array
{
@ -132,8 +131,6 @@ class AbnAmroDescription implements SpecificInterface
*
* @return bool true if the description is SEPA format, false otherwise
*
*
*
*/
protected function parseSepaDescription(): bool
{
@ -189,8 +186,6 @@ class AbnAmroDescription implements SpecificInterface
*
* @return bool true if the description is TRTP format, false otherwise
*
*
*
*/
protected function parseTRTPDescription(): bool
{

View File

@ -61,7 +61,6 @@ class Belfius implements SpecificInterface
*
* @return array
*
*
*/
public function run(array $row): array
{

View File

@ -59,7 +59,6 @@ class IngBelgium implements SpecificInterface
*
* @return array
*
*
*/
public function run(array $row): array
{

View File

@ -66,7 +66,6 @@ class IngDescription implements SpecificInterface
*
* @return array
*
*
*/
public function run(array $row): array
{

View File

@ -59,7 +59,6 @@ class RabobankDescription implements SpecificInterface
*
* @return array
*
*
*/
public function run(array $row): array
{

View File

@ -51,7 +51,6 @@ use Log;
*
* Class ImportArrayStorage
*
*
*/
class ImportArrayStorage
{
@ -201,8 +200,6 @@ class ImportArrayStorage
* @return Collection
* @throws FireflyException
*
*
*
*/
private function storeGroupArray(): Collection
{
@ -388,9 +385,6 @@ class ImportArrayStorage
*
* @return bool
*
*
*
*
*/
private function transferExists(array $transaction): bool
{

View File

@ -68,7 +68,6 @@ use Log;
/**
* Class CreateRecurringTransactions.
*
*
*/
class CreateRecurringTransactions implements ShouldQueue
{
@ -442,7 +441,6 @@ class CreateRecurringTransactions implements ShouldQueue
*
* @return bool
*
*
*/
private function validRecurrence(Recurrence $recurrence): bool
{

View File

@ -108,7 +108,6 @@ class FireflyServiceProvider extends ServiceProvider
/**
* Register stuff.
*
*
*/
public function register(): void
{

View File

@ -560,8 +560,6 @@ class AccountRepository implements AccountRepositoryInterface
*
* @return Account
* @throws FireflyException
* @throws FireflyException
* @throws FireflyException
*/
public function update(Account $account, array $data): Account
{

View File

@ -46,9 +46,6 @@ use Navigation;
/**
* Class BudgetRepository.
*
*
*
*
*/
class BudgetRepository implements BudgetRepositoryInterface
{
@ -139,7 +136,6 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @return array
*
*
*/
public function collectBudgetInformation(Collection $budgets, Carbon $start, Carbon $end): array
{
@ -281,7 +277,6 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @return Carbon
*
*
*/
public function firstUseDate(Budget $budget): ?Carbon
{
@ -323,7 +318,6 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @return Collection
*
*
*/
public function getAllBudgetLimits(Carbon $start = null, Carbon $end = null): Collection
{
@ -491,7 +485,6 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @return Collection
*
*
*/
public function getBudgetLimits(Budget $budget, Carbon $start = null, Carbon $end = null): Collection
{
@ -1056,7 +1049,6 @@ class BudgetRepository implements BudgetRepositoryInterface
*
* @return BudgetLimit|null
*
*
*/
public function updateLimitAmount(Budget $budget, Carbon $start, Carbon $end, string $amount): ?BudgetLimit
{

View File

@ -185,7 +185,6 @@ class CategoryRepository implements CategoryRepositoryInterface
*
* @return Carbon|null
*
*
*/
public function lastUseDate(Category $category, Collection $accounts): ?Carbon
{

View File

@ -38,7 +38,6 @@ use Symfony\Component\HttpFoundation\File\UploadedFile;
/**
* Class ImportJobRepository.
*
*
*/
class ImportJobRepository implements ImportJobRepositoryInterface
{

View File

@ -35,7 +35,6 @@ use Log;
/**
* Class LinkTypeRepository.
*
*
*/
class LinkTypeRepository implements LinkTypeRepositoryInterface
{
@ -348,7 +347,6 @@ class LinkTypeRepository implements LinkTypeRepositoryInterface
* @param TransactionJournalLink $link
* @param string $text
*
*
* @throws \Exception
*/
private function setNoteText(TransactionJournalLink $link, string $text): void

View File

@ -37,8 +37,6 @@ use Log;
/**
* Class PiggyBankRepository.
*
*
*
*/
class PiggyBankRepository implements PiggyBankRepositoryInterface
{

View File

@ -34,7 +34,6 @@ use Log;
/**
* Class RuleRepository.
*
*
*/
class RuleRepository implements RuleRepositoryInterface
{

View File

@ -36,7 +36,6 @@ use Log;
/**
* Class TagRepository.
*
*
*/
class TagRepository implements TagRepositoryInterface
{

View File

@ -32,7 +32,6 @@ use Log;
/**
* Class UserRepository.
*
*
*/
class UserRepository implements UserRepositoryInterface
{

View File

@ -69,8 +69,6 @@ class BelongsUser implements Rule
* @return bool
* @throws FireflyException
*
*
*
*/
public function passes($attribute, $value): bool
{
@ -110,7 +108,6 @@ class BelongsUser implements Rule
*
* @return int
*
*
*/
protected function countField(string $class, string $field, string $value): int
{

View File

@ -73,7 +73,6 @@ class UniqueIban implements Rule
*
* @return bool
*
*
*/
public function passes($attribute, $value): bool
{

View File

@ -50,7 +50,6 @@ class ValidRecurrenceRepetitionType implements Rule
*
* @return bool
*
*
*/
public function passes($attribute, $value): bool
{

View File

@ -54,7 +54,6 @@ class ValidRecurrenceRepetitionValue implements Rule
*
* @return bool
*
*
*/
public function passes($attribute, $value): bool
{
@ -104,7 +103,6 @@ class ValidRecurrenceRepetitionValue implements Rule
*
* @return bool
*
*
*/
private function validateNdom(string $value): bool
{

View File

@ -264,7 +264,6 @@ trait JournalServiceTrait
* @param TransactionJournal $journal
* @param array $tags
*
*
* @codeCoverageIgnore
*/
protected function storeTags(TransactionJournal $journal, ?array $tags): void

View File

@ -254,7 +254,6 @@ trait RecurringTransactionTrait
// $piggyName = $data['meta']['piggy_bank_name'] ?? '';
// $this->updatePiggyBank($recurrence, $piggyId, $piggyName);
//
//
// $tags = $data['meta']['tags'] ?? [];
// $this->updateTags($recurrence, $tags);
//

View File

@ -37,7 +37,6 @@ class ImportProvider implements BinderInterface
/**
* @return array
*
*
*/
public static function getProviders(): array
{

View File

@ -79,8 +79,6 @@ trait AugumentData
*
* @return array
*
*
*
*/
protected function earnedByCategory(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info
{
@ -352,7 +350,6 @@ trait AugumentData
*
* @return array
*
*
*/
protected function getExpensesForBudget(Collection $limits, Budget $budget, Carbon $start, Carbon $end): array // get data + augment with info
{
@ -397,8 +394,6 @@ trait AugumentData
*
* @return array
*
*
*
*/
protected function spentInPeriodMulti(Budget $budget, Collection $limits): array // get data + augment with info
{
@ -587,7 +582,6 @@ trait AugumentData
*
* @return array
*
*
*/
protected function spentByBudget(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info
{
@ -647,8 +641,6 @@ trait AugumentData
*
* @return array
*
*
*
*/
protected function spentByCategory(Collection $assets, Collection $opposing, Carbon $start, Carbon $end): array // get data + augment with info
{

View File

@ -47,8 +47,6 @@ trait ChartGeneration
*
* @return array
*
*
*
*/
protected function accountBalanceChart(Collection $accounts, Carbon $start, Carbon $end): array // chart helper method.
{

View File

@ -66,7 +66,6 @@ trait RequestInformation
*
* @return string
*
*
*/
protected function getHelpText(string $route, string $language): string // get from internet.
{

View File

@ -183,7 +183,6 @@ trait UserNavigation
// return redirect(route('index'));
// }
//
//
// $valid = [AccountType::DEFAULT, AccountType::ASSET];
// $transactions = $journal->transactions;
// /** @var Transaction $transaction */

View File

@ -150,7 +150,6 @@ class SelectBudgetHandler implements YnabJobConfigurationInterface
$this->repository->setUser($importJob->user);
$this->currencyRepository->setUser($importJob->user);
$this->accountRepository->setUser($importJob->user);
$this->accountRepository->setUser($importJob->user);
$this->accounts = $this->accountRepository->getAccountsByType([AccountType::ASSET, AccountType::DEFAULT]);
}

View File

@ -132,7 +132,6 @@ class StageNewHandler
/** @var MonetaryAccountSavings $object */
$array = $this->processMas($object);
break;
break;
default:
// @codeCoverageIgnoreStart
throw new FireflyException(sprintf('Bunq import routine cannot handle account of type "%s".', get_class($object)));

View File

@ -92,7 +92,6 @@ class OFXProcessor implements FileProcessorInterface
// var_dump($transaction);
// }
//
//
// die('I am here.');

View File

@ -43,7 +43,6 @@ trait FiltersWeekends
*
* @return array
*
*
*/
protected function filterWeekends(RecurrenceRepetition $repetition, array $dates): array
{

View File

@ -341,7 +341,6 @@ class CurrencyControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\CurrencyController
* @covers \FireflyIII\Http\Controllers\CurrencyController
*/
public function testIndex(): void
@ -376,7 +375,6 @@ class CurrencyControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\CurrencyController
* @covers \FireflyIII\Http\Controllers\CurrencyController
*/
public function testIndexNoRights(): void

View File

@ -92,7 +92,6 @@ class JavascriptControllerTest extends TestCase
}
/**
* @covers \FireflyIII\Http\Controllers\JavascriptController
* @covers \FireflyIII\Http\Controllers\JavascriptController
*
* @param string $range

View File

@ -54,7 +54,6 @@ class BulkControllerTest extends TestCase
/**
* @covers \FireflyIII\Http\Controllers\Transaction\BulkController
* @covers \FireflyIII\Http\Controllers\Transaction\BulkController
*/
public function testEditWithdrawal(): void

View File

@ -42,7 +42,6 @@ use Log;
use Tests\TestCase;
/**
*
*
* Test different combinations:
* Transfer

View File

@ -331,7 +331,6 @@ class StageImportDataHandlerTest extends TestCase
// // todo: improve test thing:
// Preferences::shouldReceive('setForUser');
//
//
// // ignore the deprecated fields:
// $amount->setValue('150');
// $amount->setCurrency('EUR');
@ -410,7 +409,6 @@ class StageImportDataHandlerTest extends TestCase
// $payment->shouldReceive('listing')->once()->andReturn($list);
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturn($deposit);
//
//
// $handler = new StageImportDataHandler;
// $handler->setImportJob($job);
// try {
@ -547,7 +545,6 @@ class StageImportDataHandlerTest extends TestCase
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::REVENUE]])->once()->andReturnNull();
// $accountRepository->shouldReceive('findByIbanNull')->withArgs(['RS88844660406878687897', [AccountType::ASSET]])->once()->andReturn($asset);
//
//
// // set new last transaction ID:
// $lastPref = new Preference;
// $lastPref->data = 0;