IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove TODO annotations

Browse Source
This commit is contained in:
James Cole 2016-11-26 09:07:16 +01:00
parent 8c9f90f1b4
commit 62e41f1997
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
3 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/Http/Controllers/Chart/CategoryReportController.php
View File

@ -32,8 +32,6 @@ use Response;
/**
* Separate controller because many helper functions are shared.
*
* TODO much of this code is actually repeated. First for the object (category, account), then for the direction (in / out).
*
* Class CategoryReportController
*
* @package FireflyIII\Http\Controllers\Chart
@ -98,7 +96,6 @@ class CategoryReportController extends Controller
}
// also collect all transactions NOT in these categories.
// TODO include transfers
if ($others) {
$collector = new JournalCollector(auth()->user());
$collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::WITHDRAWAL]);
@ -147,7 +144,6 @@ class CategoryReportController extends Controller
}
// also collect others?
// TODO include transfers
if ($others) {
$collector = new JournalCollector(auth()->user());
$collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::DEPOSIT]);
@ -196,7 +192,6 @@ class CategoryReportController extends Controller
}
// also collect all transactions NOT in these categories.
// TODO include transfers
if ($others) {
$collector = new JournalCollector(auth()->user());
$collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::WITHDRAWAL]);
@ -245,7 +240,6 @@ class CategoryReportController extends Controller
}
// also collect others?
// TODO include transfers
if ($others) {
$collector = new JournalCollector(auth()->user());
$collector->setAccounts($accounts)->setRange($start, $end)->setTypes([TransactionType::DEPOSIT]);

1
app/Repositories/Budget/BudgetRepositoryInterface.php
View File

@ -92,7 +92,6 @@ interface BudgetRepositoryInterface
/**
*
* todo always collects without budget info
* @param Collection $budgets
* @param Collection $accounts
* @param Carbon $start

3
tests/acceptance/Controllers/AccountControllerTest.php
View File

@ -39,7 +39,6 @@ class AccountControllerTest extends TestCase
/**
* @covers FireflyIII\Http\Controllers\AccountController::destroy
* @todo Implement testDestroy().
*/
public function testDestroy()
{
@ -108,7 +107,6 @@ class AccountControllerTest extends TestCase
/**
* @covers FireflyIII\Http\Controllers\AccountController::store
* @todo Implement testStore().
*/
public function testStore()
{
@ -120,7 +118,6 @@ class AccountControllerTest extends TestCase
/**
* @covers FireflyIII\Http\Controllers\AccountController::update
* @todo Implement testUpdate().
*/
public function testUpdate()
{