IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Shorter method names.

Browse Source
This commit is contained in:
James Cole
2016-01-15 13:13:21 +01:00
parent 9cbfbd41dc
commit 651dff0750
2 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/Repositories/RuleGroup/RuleGroupRepository.php
View File

@@ -16,7 +16,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
*
* @return boolean
*/
public function destroyRuleGroup(RuleGroup $ruleGroup, RuleGroup $moveTo = null)
public function destroy(RuleGroup $ruleGroup, RuleGroup $moveTo = null)
{
/** @var Rule $rule */
foreach ($ruleGroup->rules as $rule) {
@@ -55,7 +55,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
/**
* @return Collection
*/
public function getRuleGroups()
public function get()
{
return Auth::user()->ruleGroups()->orderBy('order', 'ASC')->get();
}
@@ -66,7 +66,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
*
* @return bool
*/
public function moveRuleGroupUp(RuleGroup $ruleGroup)
public function moveUp(RuleGroup $ruleGroup)
{
$order = $ruleGroup->order;
@@ -87,7 +87,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
*
* @return bool
*/
public function moveRuleGroupDown(RuleGroup $ruleGroup)
public function moveDown(RuleGroup $ruleGroup)
{
$order = $ruleGroup->order;
@@ -126,6 +126,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
/**
* @param RuleGroup $ruleGroup
*
* @return bool
*/
public function resetRulesInGroupOrder(RuleGroup $ruleGroup)
@@ -153,7 +154,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
*
* @return RuleGroup
*/
public function storeRuleGroup(array $data)
public function store(array $data)
{
$order = $this->getHighestOrderRuleGroup();
@@ -180,7 +181,7 @@ class RuleGroupRepository implements RuleGroupRepositoryInterface
*
* @return RuleGroup
*/
public function updateRuleGroup(RuleGroup $ruleGroup, array $data)
public function update(RuleGroup $ruleGroup, array $data)
{
// update the account:
$ruleGroup->title = $data['title'];

21
app/Repositories/RuleGroup/RuleGroupRepositoryInterface.php
View File

@@ -6,6 +6,11 @@ namespace FireflyIII\Repositories\RuleGroup;
use FireflyIII\Models\RuleGroup;
use Illuminate\Support\Collection;
/**
* Interface RuleGroupRepositoryInterface
*
* @package FireflyIII\Repositories\RuleGroup
*/
interface RuleGroupRepositoryInterface
{
/**
@@ -14,8 +19,7 @@ interface RuleGroupRepositoryInterface
*
* @return bool
*/
public function destroyRuleGroup(RuleGroup $ruleGroup, RuleGroup $moveTo = null);
public function destroy(RuleGroup $ruleGroup, RuleGroup $moveTo = null);
/**
@@ -26,19 +30,21 @@ interface RuleGroupRepositoryInterface
/**
* @return Collection
*/
public function getRuleGroups();
public function get();
/**
* @param RuleGroup $ruleGroup
*
* @return bool
*/
public function moveRuleGroupUp(RuleGroup $ruleGroup);
public function moveUp(RuleGroup $ruleGroup);
/**
* @param RuleGroup $ruleGroup
*
* @return bool
*/
public function moveRuleGroupDown(RuleGroup $ruleGroup);
public function moveDown(RuleGroup $ruleGroup);
/**
* @return bool
@@ -55,8 +61,7 @@ interface RuleGroupRepositoryInterface
*
* @return RuleGroup
*/
public function storeRuleGroup(array $data);
public function store(array $data);
/**
* @param RuleGroup $ruleGroup
@@ -64,7 +69,7 @@ interface RuleGroupRepositoryInterface
*
* @return RuleGroup
*/
public function updateRuleGroup(RuleGroup $ruleGroup, array $data);
public function update(RuleGroup $ruleGroup, array $data);
}