From 71bf054ab12ed364d6777c253c7f5497b095718c Mon Sep 17 00:00:00 2001
From: James Cole <thegrumpydictator@gmail.com>
Date: Thu, 28 Jan 2016 21:05:26 +0100
Subject: [PATCH] Removed TODO items in favour of issues, or actual fixes.

---
 app/Http/Controllers/Chart/BudgetController.php | 4 +---
 app/Http/Controllers/RuleController.php         | 1 +
 app/Repositories/Rule/RuleRepository.php        | 2 +-
 app/Rules/Processor.php                         | 2 --
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/app/Http/Controllers/Chart/BudgetController.php b/app/Http/Controllers/Chart/BudgetController.php
index 3fc267d732..b3b8b351c4 100644
--- a/app/Http/Controllers/Chart/BudgetController.php
+++ b/app/Http/Controllers/Chart/BudgetController.php
@@ -37,7 +37,6 @@ class BudgetController extends Controller
     }
 
     /**
-     * TODO expand with no budget chart.
      *
      * @param BudgetRepositoryInterface $repository
      * @param                           $reportType
@@ -147,7 +146,7 @@ class BudgetController extends Controller
         $last    = Navigation::endOfX($last, $range, $final);
         $entries = new Collection;
         // get all expenses:
-        $set = $repository->getExpensesPerMonth($budget, $first, $last); // TODO
+        $set = $repository->getExpensesPerMonth($budget, $first, $last);
 
         while ($first < $last) {
             $monthFormatted = $first->format('Y-m');
@@ -294,7 +293,6 @@ class BudgetController extends Controller
     }
 
     /**
-     * TODO expand with no budget chart.
      *
      * @param BudgetRepositoryInterface $repository
      * @param                           $reportType
diff --git a/app/Http/Controllers/RuleController.php b/app/Http/Controllers/RuleController.php
index efb3f4e474..5e9a0fcf0c 100644
--- a/app/Http/Controllers/RuleController.php
+++ b/app/Http/Controllers/RuleController.php
@@ -250,6 +250,7 @@ class RuleController extends Controller
         $data = [
             'rule_group_id'       => $ruleGroup->id,
             'title'               => $request->get('title'),
+            'user_id'             => Auth::user()->id,
             'trigger'             => $request->get('trigger'),
             'description'         => $request->get('description'),
             'rule-triggers'       => $request->get('rule-trigger'),
diff --git a/app/Repositories/Rule/RuleRepository.php b/app/Repositories/Rule/RuleRepository.php
index b21536aa76..213b484e03 100644
--- a/app/Repositories/Rule/RuleRepository.php
+++ b/app/Repositories/Rule/RuleRepository.php
@@ -194,7 +194,7 @@ class RuleRepository implements RuleRepositoryInterface
 
         // start by creating a new rule:
         $rule = new Rule;
-        $rule->user()->associate(Auth::user()); // TODO must be $data['user']
+        $rule->user()->associate($data['user_id']);
 
         $rule->rule_group_id   = $data['rule_group_id'];
         $rule->order           = ($order + 1);
diff --git a/app/Rules/Processor.php b/app/Rules/Processor.php
index 54125bfcac..f12073621b 100644
--- a/app/Rules/Processor.php
+++ b/app/Rules/Processor.php
@@ -120,8 +120,6 @@ class Processor
     }
 
     /**
-     * TODO stop when stop_processing is present.
-     *
      * @return bool
      */
     protected function triggered()