IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Code cleaning stuff.

Browse Source
This commit is contained in:
James Cole
2019-02-13 17:38:41 +01:00
parent 9a461fc7b7
commit 71fb9d8fa5
141 changed files with 495 additions and 482 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Import/Converter/Amount.php
View File

@@ -82,7 +82,7 @@ class Amount implements ConverterInterface
$value = str_replace($search, '', $value);
Log::debug(sprintf('No decimal character found. Converted amount from "%s" to "%s".', $original, $value));
}
if ('.' === $value{0}) {
if (strpos($value, '.') === 0) {
$value = '0' . $value;
}

2
app/Import/Mapper/AssetAccountIbans.php
View File

@@ -53,7 +53,7 @@ class AssetAccountIbans implements MapperInterface
foreach ($set as $account) {
$iban = $account->iban ?? '';
$accountId = (int)$account->id;
if (\strlen($iban) > 0) {
if ('' !== $iban) {
$name = $account->iban . ' (' . $account->name . ')';
// is a liability?

6
app/Import/Mapper/AssetAccounts.php
View File

@@ -40,7 +40,9 @@ class AssetAccounts implements MapperInterface
{
/** @var AccountRepositoryInterface $accountRepository */
$accountRepository = app(AccountRepositoryInterface::class);
$set = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::CREDITCARD, AccountType::MORTGAGE,]);
$set = $accountRepository->getAccountsByType(
[AccountType::DEFAULT, AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::CREDITCARD, AccountType::MORTGAGE,]
);
$list = [];
/** @var Account $account */
@@ -48,7 +50,7 @@ class AssetAccounts implements MapperInterface
$accountId = (int)$account->id;
$name = $account->name;
$iban = $account->iban ?? '';
if (\strlen($iban) > 0) {
if ('' !== $iban) {
$name .= ' (' . $iban . ')';
}

2
app/Import/Mapper/OpposingAccountIbans.php
View File

@@ -55,7 +55,7 @@ class OpposingAccountIbans implements MapperInterface
foreach ($set as $account) {
$iban = $account->iban ?? '';
$accountId = (int)$account->id;
if (\strlen($iban) > 0) {
if ('' !== $iban) {
$name = $account->iban . ' (' . $account->name . ')';
// is a liability?

2
app/Import/Mapper/OpposingAccounts.php
View File

@@ -55,7 +55,7 @@ class OpposingAccounts implements MapperInterface
$accountId = (int)$account->id;
$name = $account->name;
$iban = $account->iban ?? '';
if (\strlen($iban) > 0) {
if ('' !== $iban) {
$name .= ' (' . $iban . ')';
}
// is a liability?

2
app/Import/Routine/BunqRoutine.php
View File

@@ -98,8 +98,6 @@ class BunqRoutine implements RoutineInterface
}
/**
* Set the import job.
*

4
app/Import/Storage/ImportArrayStorage.php
View File

@@ -227,7 +227,7 @@ class ImportArrayStorage
throw new FireflyException('Could not encode import array. Please see the logs.');
// @codeCoverageIgnoreEnd
}
$hash = hash('sha256', $json, false);
$hash = hash('sha256', $json);
Log::debug(sprintf('The hash is: %s', $hash));
return $hash;
@@ -338,7 +338,7 @@ class ImportArrayStorage
'description' => null,
'latitude' => null,
'longitude' => null,
'zoom_level' => null,
'zoom_level' => null,
'tagMode' => 'nothing',
];
$tag = $repository->store($data);