IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Code cleanup should trigger scan.

Browse Source
This commit is contained in:
James Cole 2022-12-30 20:38:54 +01:00
parent 333c348117
commit 742c84269b
No known key found for this signature in database
GPG Key ID: B49A324B7EAD6D80
12 changed files with 19 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/Http/Controllers/Json/RecurrenceController.php
View File

@ -107,17 +107,16 @@ class RecurrenceController extends Controller
$repetition->weekend = (int)$request->get('weekend');
$actualEnd = clone $end;
if('until_date' === $endsAt) {
if ('until_date' === $endsAt) {
$actualEnd = $endDate ?? clone $end;
$occurrences = $this->recurring->getOccurrencesInRange($repetition, $actualStart, $actualEnd);
}
if('times' === $endsAt) {
if ('times' === $endsAt) {
$occurrences = $this->recurring->getXOccurrences($repetition, $actualStart, $repetitions);
}
if('times' !== $endsAt && 'until_date' !== $endsAt) {
if ('times' !== $endsAt && 'until_date' !== $endsAt) {
// 'forever'
$occurrences = $this->recurring->getOccurrencesInRange($repetition, $actualStart, $actualEnd);
}
/** @var Carbon $current */

8
app/Http/Requests/RecurrenceFormRequest.php
View File

@ -315,22 +315,22 @@ class RecurrenceFormRequest extends FormRequest
// TODO either use 'withdrawal' or the strtolower() variant, not both.
$type = $this->convertString('transaction_type');
$throwError = true;
if('withdrawal' === $type) {
if ('withdrawal' === $type) {
$throwError = false;
$sourceId = (int)$data['source_id'];
$destinationId = (int)$data['withdrawal_destination_id'];
}
if('deposit' === $type) {
if ('deposit' === $type) {
$throwError = false;
$sourceId = (int)$data['deposit_source_id'];
$destinationId = (int)$data['destination_id'];
}
if('transfer' === $type) {
if ('transfer' === $type) {
$throwError = false;
$sourceId = (int)$data['source_id'];
$destinationId = (int)$data['destination_id'];
}
if(true === $throwError) {
if (true === $throwError) {
throw new FireflyException(sprintf('Cannot handle transaction type "%s"', $this->convertString('transaction_type')));
}

2
app/Repositories/Budget/BudgetRepository.php
View File

@ -331,7 +331,7 @@ class BudgetRepository implements BudgetRepositoryInterface
return;
}
if (null !== $dbNote) {
$dbNote->delete();
$dbNote->delete();
}
}

2
app/Services/Internal/Destroy/BillDestroyService.php
View File

@ -37,6 +37,6 @@ class BillDestroyService
*/
public function destroy(Bill $bill): void
{
$bill->delete();
$bill->delete();
}
}

2
app/Services/Internal/Destroy/BudgetDestroyService.php
View File

@ -39,7 +39,7 @@ class BudgetDestroyService
*/
public function destroy(Budget $budget): void
{
$budget->delete();
$budget->delete();
// also delete auto budget:
foreach ($budget->autoBudgets()->get() as $autoBudget) {

2
app/Services/Internal/Destroy/CategoryDestroyService.php
View File

@ -39,7 +39,7 @@ class CategoryDestroyService
*/
public function destroy(Category $category): void
{
$category->delete();
$category->delete();
// also delete all relations between categories and transaction journals:
DB::table('category_transaction_journal')->where('category_id', (int)$category->id)->delete();

2
app/Services/Internal/Destroy/CurrencyDestroyService.php
View File

@ -38,6 +38,6 @@ class CurrencyDestroyService
*/
public function destroy(TransactionCurrency $currency): void
{
$currency->delete();
$currency->delete();
}
}

5
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@ -61,7 +61,7 @@ trait RecurringTransactionTrait
if ('' === $note) {
$dbNote = $recurrence->notes()->first();
if (null !== $dbNote) {
$dbNote->delete();
$dbNote->delete();
}
return true;
@ -373,8 +373,7 @@ trait RecurringTransactionTrait
foreach ($recurrence->recurrenceTransactions as $transaction) {
$transaction->recurrenceTransactionMeta()->delete();
$transaction->delete();
$transaction->delete();
}
}
}

4
app/Services/Internal/Update/CategoryUpdateService.php
View File

@ -153,9 +153,7 @@ class CategoryUpdateService
if ('' === $note) {
$dbNote = $category->notes()->first();
if (null !== $dbNote) {
$dbNote->delete();
$dbNote->delete();
}
return;

2
app/Services/Internal/Update/RecurrenceUpdateService.php
View File

@ -132,7 +132,7 @@ class RecurrenceUpdateService
return;
}
if (null !== $dbNote && '' === $text) {
$dbNote->delete();
$dbNote->delete();
}
}

2
app/Support/FireflyConfig.php
View File

@ -46,7 +46,7 @@ class FireflyConfig
if (Cache::has($fullName)) {
Cache::forget($fullName);
}
Configuration::where('name', $name)->forceDelete();
Configuration::where('name', $name)->forceDelete();
}
/**

4
app/Support/Preferences.php
View File

@ -113,7 +113,7 @@ class Preferences
if (Cache::has($fullName)) {
Cache::forget($fullName);
}
Preference::where('user_id', auth()->user()->id)->where('name', $name)->delete();
Preference::where('user_id', auth()->user()->id)->where('name', $name)->delete();
return true;
}
@ -145,7 +145,7 @@ class Preferences
$pref = Preference::where('user_id', $user->id)->where('name', $name)->first(['id', 'name', 'data', 'updated_at', 'created_at']);
if (null !== $pref && null === $value) {
$pref->delete();
$pref->delete();
return new Preference();
}