diff --git a/app/Http/Controllers/BudgetController.php b/app/Http/Controllers/BudgetController.php index 5ba51a5a6b..9605e0b8c6 100644 --- a/app/Http/Controllers/BudgetController.php +++ b/app/Http/Controllers/BudgetController.php @@ -299,12 +299,12 @@ class BudgetController extends Controller public function show(BudgetRepositoryInterface $repository, AccountRepositoryInterface $accountRepository, Budget $budget) { /** @var Carbon $start */ - $start = session('first', Carbon::create()->startOfYear()); - $end = new Carbon; - $page = intval(Input::get('page')) == 0 ? 1 : intval(Input::get('page')); - $pageSize = intval(Preferences::get('transactionPageSize', 50)->data); - $accounts = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]); - + $start = session('first', Carbon::create()->startOfYear()); + $end = new Carbon; + $page = intval(Input::get('page')) == 0 ? 1 : intval(Input::get('page')); + $pageSize = intval(Preferences::get('transactionPageSize', 50)->data); + $accounts = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]); + $repetition = null; // collector: $collector = new JournalCollector(auth()->user()); $collector->setAllAssetAccounts()->setRange($start, $end)->setBudget($budget)->setLimit($pageSize)->setPage($page); diff --git a/app/Http/breadcrumbs.php b/app/Http/breadcrumbs.php index a16717d6c3..8e70cd9dd7 100644 --- a/app/Http/breadcrumbs.php +++ b/app/Http/breadcrumbs.php @@ -255,21 +255,26 @@ Breadcrumbs::register( ); Breadcrumbs::register( - 'budgets.noBudget', function (BreadCrumbGenerator $breadcrumbs, $subTitle) { + 'budgets.no-budget', function (BreadCrumbGenerator $breadcrumbs, $subTitle) { $breadcrumbs->parent('budgets.index'); - $breadcrumbs->push($subTitle, route('budgets.noBudget')); + $breadcrumbs->push($subTitle, route('budgets.no-budget')); } ); Breadcrumbs::register( - 'budgets.show', function (BreadCrumbGenerator $breadcrumbs, Budget $budget, LimitRepetition $repetition = null) { + 'budgets.show', function (BreadCrumbGenerator $breadcrumbs, Budget $budget) { $breadcrumbs->parent('budgets.index'); $breadcrumbs->push(e($budget->name), route('budgets.show', [$budget->id])); - if (!is_null($repetition) && !is_null($repetition->id)) { - $breadcrumbs->push( - Navigation::periodShow($repetition->startdate, $repetition->budgetLimit->repeat_freq), route('budgets.show', [$budget->id, $repetition->id]) - ); - } +} +); + +Breadcrumbs::register( + 'budgets.show.repetition', function (BreadCrumbGenerator $breadcrumbs, Budget $budget, LimitRepetition $repetition) { + $breadcrumbs->parent('budgets.index'); + $breadcrumbs->push(e($budget->name), route('budgets.show.repetition', [$budget->id, $repetition->id])); + $breadcrumbs->push( + Navigation::periodShow($repetition->startdate, $repetition->budgetLimit->repeat_freq), route('budgets.show', [$budget->id, $repetition->id]) + ); } ); @@ -324,9 +329,9 @@ Breadcrumbs::register( ); Breadcrumbs::register( - 'categories.noCategory', function (BreadCrumbGenerator $breadcrumbs, $subTitle) { + 'categories.no-category', function (BreadCrumbGenerator $breadcrumbs, $subTitle) { $breadcrumbs->parent('categories.index'); - $breadcrumbs->push($subTitle, route('categories.noCategory')); + $breadcrumbs->push($subTitle, route('categories.no-category')); } ); @@ -660,7 +665,7 @@ Breadcrumbs::register( 'transactions.mass.edit', function (BreadCrumbGenerator $breadcrumbs, Collection $journals) { $journalIds = $journals->pluck('id')->toArray(); - $what = strtolower($journals->first()->transactionType->type); + $what = strtolower($journals->first()->transactionType->type); $breadcrumbs->parent('transactions.index', $what); $breadcrumbs->push(trans('firefly.mass_edit_journals'), route('transactions.mass.edit', $journalIds)); } @@ -670,7 +675,7 @@ Breadcrumbs::register( 'transactions.mass.delete', function (BreadCrumbGenerator $breadcrumbs, Collection $journals) { $journalIds = $journals->pluck('id')->toArray(); - $what = strtolower($journals->first()->transactionType->type); + $what = strtolower($journals->first()->transactionType->type); $breadcrumbs->parent('transactions.index', $what); $breadcrumbs->push(trans('firefly.mass_edit_journals'), route('transactions.mass.delete', $journalIds)); } diff --git a/routes/web.php b/routes/web.php index 69fe929318..ee7ec39d1f 100755 --- a/routes/web.php +++ b/routes/web.php @@ -162,7 +162,7 @@ Route::group( Route::post('store', ['uses' => 'BudgetController@store', 'as' => 'store']); Route::post('update/{budget}', ['uses' => 'BudgetController@update', 'as' => 'update']); Route::post('destroy/{budget}', ['uses' => 'BudgetController@destroy', 'as' => 'destroy']); - Route::post('amount/{budget}', ['uses' => 'BudgetController@amount']); + Route::post('amount/{budget}', ['uses' => 'BudgetController@amount', 'as' => 'amount']); } ); diff --git a/tests/acceptance/Controllers/BillControllerTest.php b/tests/acceptance/Controllers/BillControllerTest.php index 1863596ee7..efce584e0b 100644 --- a/tests/acceptance/Controllers/BillControllerTest.php +++ b/tests/acceptance/Controllers/BillControllerTest.php @@ -8,6 +8,8 @@ * * See the LICENSE file for details. */ +use FireflyIII\Repositories\Bill\BillRepositoryInterface; +use Illuminate\Support\Collection; /** @@ -28,117 +30,150 @@ class BillControllerTest extends TestCase /** * @covers \FireflyIII\Http\Controllers\BillController::create - * Implement testCreate(). */ public function testCreate() { - // Remove the following lines when you implement this test. - $this->markTestIncomplete( - 'This test has not been implemented yet.' - ); + $this->be($this->user()); + $this->call('GET', route('bills.create')); + $this->assertResponseStatus(200); + // has bread crumb + $this->see('