IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added some todo's.

Browse Source
This commit is contained in:
James Cole 2014-12-05 21:45:48 +01:00
parent 357638a26c
commit 834f8382e9
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/TransactionController.php
View File

@ -23,6 +23,7 @@ class TransactionController extends BaseController
View::share('mainTitleIcon', 'fa-repeat'); View::share('mainTitleIcon', 'fa-repeat');
} }
// TODO this needs cleaning up and thinking over.
public function alreadyRelated(TransactionJournal $journal) public function alreadyRelated(TransactionJournal $journal)
{ {
@ -153,6 +154,7 @@ class TransactionController extends BaseController
} }
} }
// TODO this needs cleaning up and thinking over.
public function doRelate() public function doRelate()
{ {
$id = intval(Input::get('id')); $id = intval(Input::get('id'));
@ -366,6 +368,7 @@ class TransactionController extends BaseController
return View::make('transactions.relate', compact('journal', 'members')); return View::make('transactions.relate', compact('journal', 'members'));
} }
// TODO this needs cleaning up and thinking over.
public function relatedSearch(TransactionJournal $journal) public function relatedSearch(TransactionJournal $journal)
{ {
$search = e(trim(Input::get('searchValue'))); $search = e(trim(Input::get('searchValue')));
@ -487,6 +490,7 @@ class TransactionController extends BaseController
} }
} }
// TODO this needs cleaning up and thinking over.
public function unrelate(TransactionJournal $journal) public function unrelate(TransactionJournal $journal)
{ {
$groups = $journal->transactiongroups()->get(); $groups = $journal->transactiongroups()->get();

4
app/lib/FireflyIII/Database/Account.php
View File

@ -272,6 +272,7 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface
$this->storeInitialBalance($account, $data); $this->storeInitialBalance($account, $data);
} }
// TODO this needs cleaning up and thinking over.
switch ($account->accountType->type) { switch ($account->accountType->type) {
case 'Asset account': case 'Asset account':
case 'Default account': case 'Default account':
@ -299,6 +300,7 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface
$model->name = $data['name']; $model->name = $data['name'];
$model->active = isset($data['active']) ? intval($data['active']) : 0; $model->active = isset($data['active']) ? intval($data['active']) : 0;
// TODO this needs cleaning up and thinking over.
switch ($model->accountType->type) { switch ($model->accountType->type) {
case 'Asset account': case 'Asset account':
case 'Default account': case 'Default account':
@ -310,7 +312,7 @@ class Account implements CUD, CommonDatabaseCalls, AccountInterface
if (isset($data['openingbalance']) && isset($data['openingbalancedate']) && strlen($data['openingbalancedate']) > 0) { if (isset($data['openingbalance']) && isset($data['openingbalancedate']) && strlen($data['openingbalancedate']) > 0) {
$openingBalance = $this->openingBalanceTransaction($model); $openingBalance = $this->openingBalanceTransaction($model);
// TODO this needs cleaning up and thinking over.
if (is_null($openingBalance)) { if (is_null($openingBalance)) {
$this->storeInitialBalance($model, $data); $this->storeInitialBalance($model, $data);
} else { } else {