From 8767bad61e435e933586e3cf1ea6c204849954ab Mon Sep 17 00:00:00 2001 From: James Cole Date: Thu, 1 Oct 2020 07:31:08 +0200 Subject: [PATCH] Fix #3879 --- app/Support/Http/Controllers/RenderPartialViews.php | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/Support/Http/Controllers/RenderPartialViews.php b/app/Support/Http/Controllers/RenderPartialViews.php index 899dc62d7b..0582694a19 100644 --- a/app/Support/Http/Controllers/RenderPartialViews.php +++ b/app/Support/Http/Controllers/RenderPartialViews.php @@ -194,10 +194,7 @@ trait RenderPartialViews $categoryRepository = app(CategoryRepositoryInterface::class); $category = $categoryRepository->findNull((int) $attributes['categoryId']); $journals = $popupHelper->byCategory($category, $attributes); - if (null === $category) { - return 'This is an unknown category. Apologies.'; - } - // @codeCoverageIgnoreStart + try { $view = view('popup.report.category-entry', compact('journals', 'category'))->render(); } catch (Throwable $e) { @@ -205,8 +202,6 @@ trait RenderPartialViews $view = 'Firefly III could not render the view. Please see the log files.'; } - // @codeCoverageIgnoreEnd - return $view; }