Correct transactions for the next release.

app/Console/Commands/Correction/FixUnevenAmount.php

@@ -27,7 +27,6 @@ use FireflyIII\Console\Commands\ShowsFriendlyMessages;
 use FireflyIII\Models\Transaction;
 use FireflyIII\Models\TransactionJournal;
 use FireflyIII\Models\TransactionType;
-use FireflyIII\Support\Facades\Steam;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\Log;
 
@@ -48,6 +47,7 @@ class FixUnevenAmount extends Command
     public function handle(): int
     {
         $this->count = 0;
+        $this->convertOldStyleTransfers();
         $this->fixUnevenAmounts();
         $this->matchCurrencies();
 
@@ -124,8 +124,7 @@ class FixUnevenAmount extends Command
         $journals = \DB::table('transactions')
                        ->groupBy('transaction_journal_id')
                        ->whereNull('deleted_at')
-            ->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')])
-        ;
+                       ->get(['transaction_journal_id', \DB::raw('SUM(amount) AS the_sum')]);
 
         /** @var \stdClass $entry */
         foreach ($journals as $entry) {
@@ -219,4 +218,57 @@ class FixUnevenAmount extends Command
         return false;
 
     }
+
+    private function convertOldStyleTransfers(): void
+    {
+        Log::debug('convertOldStyleTransfers()');
+        // select transactions with a foreign amount and a foreign currency. and it's a transfer. and they are different.
+        $transactions = Transaction::distinct()
+                                   ->whereNotNull('foreign_currency_id')
+                                   ->whereNotNull('foreign_amount')->get(['transactions.transaction_journal_id']);
+        $count = 0;
+
+        Log::debug(sprintf('Found %d potential journal(s)', $transactions->count()));
+        /** @var Transaction $transaction */
+        foreach ($transactions as $transaction) {
+            /** @var TransactionJournal|null $journal */
+            $journal = TransactionJournal::find($transaction->transaction_journal_id);
+            if (null === $journal) {
+                Log::debug('Found no journal, continue.');
+                continue;
+            }
+            // needs to be a transfer.
+            if (TransactionType::TRANSFER !== $journal->transactionType->type) {
+                Log::debug('Must be a transfer, continue.');
+                continue;
+            }
+            /** @var Transaction|null $destination */
+            $destination = $journal->transactions()->where('amount', '>', 0)->first();
+            /** @var Transaction|null $source */
+            $source = $journal->transactions()->where('amount', '<', 0)->first();
+            if (null === $destination || null === $source) {
+                Log::debug('Source or destination transaction is NULL, continue.');
+                // will be picked up later.
+                continue;
+            }
+            if ($source->transaction_currency_id === $destination->transaction_currency_id) {
+                Log::debug('Ready to swap data between transactions.');
+                $destination->foreign_currency_id     = $source->transaction_currency_id;
+                $destination->foreign_amount          = app('steam')->positive($source->amount);
+                $destination->transaction_currency_id = $source->foreign_currency_id;
+                $destination->amount                  = app('steam')->positive($source->foreign_amount);
+                $destination->balance_dirty           = true;
+                $source->balance_dirty                = true;
+                $destination->save();
+                $source->save();
+                $this->friendlyWarning(sprintf('Corrected foreign amounts of transfer #%d.', $journal->id));
+                $count++;
+            }
+        }
+        if (0 === $count) {
+            $this->friendlyPositive('No "old style" foreign currency transfers.');
+
+            return;
+        }
+    }
 }

app/JsonApi/V2/Accounts/AccountSchema.php

@@ -27,7 +27,7 @@ class AccountSchema extends Schema
      */
     public function fields(): array
     {
-        Log::debug(__METHOD__);
+        // Log::debug(__METHOD__);
 
         return [
             ID::make(),
@@ -67,7 +67,7 @@ class AccountSchema extends Schema
      */
     public function filters(): array
     {
-        Log::debug(__METHOD__);
+//        Log::debug(__METHOD__);
 
         return [
             Filter::make('id'),

app/JsonApi/V2/Server.php

@@ -42,7 +42,7 @@ class Server extends BaseServer
      */
     protected function allSchemas(): array
     {
-        Log::debug(__METHOD__);
+        //Log::debug(__METHOD__);
 
         return [
             AccountSchema::class,