IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improve test coverage for API.

Browse Source
This commit is contained in:
James Cole
2018-12-16 13:55:19 +01:00
parent 746bd2ce92
commit 89942ee49c
32 changed files with 1534 additions and 823 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/Api/V1/Controllers/CurrencyExchangeRateControllerTest.php
View File

@@ -29,6 +29,7 @@ use FireflyIII\Models\CurrencyExchangeRate;
use FireflyIII\Models\TransactionCurrency;
use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
use FireflyIII\Services\Currency\ExchangeRateInterface;
use FireflyIII\Transformers\CurrencyExchangeRateTransformer;
use Laravel\Passport\Passport;
use Log;
use Tests\TestCase;
@@ -56,8 +57,9 @@ class CurrencyExchangeRateControllerTest extends TestCase
public function testIndex(): void
{
// mock repository
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$transformer = $this->mock(CurrencyExchangeRateTransformer::class);
$rate = new CurrencyExchangeRate();
$rate->date = new Carbon();
@@ -67,6 +69,13 @@ class CurrencyExchangeRateControllerTest extends TestCase
$rate->to_currency_id = 1;
$rate->from_currency_id = 2;
// mock transformer
$transformer->shouldReceive('setParameters')->withAnyArgs()->atLeast()->once();
$transformer->shouldReceive('setCurrentScope')->withAnyArgs()->atLeast()->once()->andReturnSelf();
$transformer->shouldReceive('getDefaultIncludes')->withAnyArgs()->atLeast()->once()->andReturn([]);
$transformer->shouldReceive('getAvailableIncludes')->withAnyArgs()->atLeast()->once()->andReturn([]);
$transformer->shouldReceive('transform')->atLeast()->once()->andReturn(['id' => 5]);
// mock calls:
$repository->shouldReceive('setUser')->once();
$repository->shouldReceive('findByCodeNull')->withArgs(['EUR'])->andReturn(TransactionCurrency::whereCode('EUR')->first())->once();
@@ -86,17 +95,6 @@ class CurrencyExchangeRateControllerTest extends TestCase
$response->assertJson(
['data' => [
'type' => 'currency_exchange_rates',
'id' => '0',
'attributes' => [
'rate' => 0.5,
],
'links' => [
[
'rel' => 'self',
'uri' => '/currency_exchange_rates/',
],
],
],
]
);
@@ -109,8 +107,9 @@ class CurrencyExchangeRateControllerTest extends TestCase
public function testIndexBadDestination(): void
{
// mock repository
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$transformer = $this->mock(CurrencyExchangeRateTransformer::class);
$rate = new CurrencyExchangeRate();
$rate->date = new Carbon();
@@ -143,8 +142,9 @@ class CurrencyExchangeRateControllerTest extends TestCase
public function testIndexBadSource(): void
{
// mock repository
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$repository = $this->mock(CurrencyRepositoryInterface::class);
$service = $this->mock(ExchangeRateInterface::class);
$transformer = $this->mock(CurrencyExchangeRateTransformer::class);
$rate = new CurrencyExchangeRate();
$rate->date = new Carbon();