Will no longer support extended tag modes.

app/Repositories/Tag/TagRepository.php

@@ -51,21 +51,11 @@ class TagRepository implements TagRepositoryInterface
 
             return false;
         }
+        Log::debug(sprintf('Tag #%d connected', $tag->id));
+        $journal->tags()->save($tag);
+        $journal->save();
 
-        switch ($tag->tagMode) {
-            case 'nothing':
-                Log::debug(sprintf('Tag #%d connected', $tag->id));
-                $journal->tags()->save($tag);
-                $journal->save();
-
-                return true;
-            case 'balancingAct':
-                return $this->connectBalancingAct($journal, $tag);
-            case 'advancePayment':
-                return $this->connectAdvancePayment($journal, $tag);
-        }
-
-        return false;
+        return true;
     }
 
     /**
@@ -237,7 +227,7 @@ class TagRepository implements TagRepositoryInterface
         $tag->latitude    = $data['latitude'];
         $tag->longitude   = $data['longitude'];
         $tag->zoomLevel   = $data['zoomLevel'];
-        $tag->tagMode     = $data['tagMode'];
+        $tag->tagMode     = 'nothing';
         $tag->user()->associate($this->user);
         $tag->save();
 
@@ -268,73 +258,6 @@ class TagRepository implements TagRepositoryInterface
         return strval($sum);
     }
 
-    /**
-     * Can a tag become an advance payment?
-     *
-     * @param Tag $tag
-     *
-     * @return bool
-     */
-    public function tagAllowAdvance(Tag $tag): bool
-    {
-        /*
-         * If this tag is a balancing act, and it contains transfers, it cannot be
-         * changed to an advancePayment.
-         */
-
-        if ($tag->tagMode === 'balancingAct' || $tag->tagMode === 'nothing') {
-            foreach ($tag->transactionjournals as $journal) {
-                if ($journal->isTransfer()) {
-                    return false;
-                }
-            }
-        }
-
-        /*
-         * If this tag contains more than one expenses, it cannot become an advance payment.
-         */
-        $count = 0;
-        foreach ($tag->transactionjournals as $journal) {
-            if ($journal->isWithdrawal()) {
-                $count++;
-            }
-        }
-        if ($count > 1) {
-            return false;
-        }
-
-        return true;
-    }
-
-    /**
-     * Can a tag become a balancing act?
-     *
-     * @param Tag $tag
-     *
-     * @return bool
-     */
-    public function tagAllowBalancing(Tag $tag): bool
-    {
-        /*
-         * If has more than two transactions already, cannot become a balancing act:
-         */
-        if ($tag->transactionjournals->count() > 2) {
-            return false;
-        }
-
-        /*
-         * If any transaction is a deposit, cannot become a balancing act.
-         */
-        foreach ($tag->transactionjournals as $journal) {
-            if ($journal->isDeposit()) {
-                return false;
-            }
-        }
-
-        return true;
-
-    }
-
     /**
      * @param Tag   $tag
      * @param array $data
@@ -349,183 +272,9 @@ class TagRepository implements TagRepositoryInterface
         $tag->latitude    = $data['latitude'];
         $tag->longitude   = $data['longitude'];
         $tag->zoomLevel   = $data['zoomLevel'];
-        $tag->tagMode     = $data['tagMode'];
         $tag->save();
 
         return $tag;
     }
 
-    /**
-     * @param TransactionJournal $journal
-     * @param Tag                $tag
-     *
-     * @return bool
-     */
-    protected function connectAdvancePayment(TransactionJournal $journal, Tag $tag): bool
-    {
-        $type        = $journal->transactionType->type;
-        $withdrawals = $tag->transactionJournals()
-                           ->leftJoin('transaction_types', 'transaction_types.id', 'transaction_journals.transaction_type_id')
-                           ->where('transaction_types.type', TransactionType::WITHDRAWAL)->count();
-        $deposits    = $tag->transactionJournals()
-                           ->leftJoin('transaction_types', 'transaction_types.id', 'transaction_journals.transaction_type_id')
-                           ->where('transaction_types.type', TransactionType::DEPOSIT)->count();
-
-        if ($type === TransactionType::TRANSFER) { // advance payments cannot accept transfers:
-            Log::error(sprintf('Journal #%d is a transfer and cannot connect to tag #%d', $journal->id, $tag->id));
-
-            return false;
-        }
-
-        // the first transaction to be attached to this tag is attached just like that:
-        if ($withdrawals < 1 && $deposits < 1) {
-            Log::debug(sprintf('Tag #%d has 0 withdrawals and 0 deposits so its fine.', $tag->id));
-            $journal->tags()->save($tag);
-            $journal->save();
-
-            return true;
-        }
-
-        // if withdrawal and already has a withdrawal, return false:
-        if ($type === TransactionType::WITHDRAWAL && $withdrawals > 0) {
-            Log::error(sprintf('Journal #%d is a withdrawal but tag already has %d withdrawal(s).', $journal->id, $withdrawals));
-
-            return false;
-        }
-
-        // if already has transaction journals, must match ALL asset account id's:
-        if ($deposits > 0 || $withdrawals === 1) {
-            Log::debug('Need to match all asset accounts.');
-
-            return $this->matchAll($journal, $tag);
-        }
-
-        // this statement is unreachable.
-        return false;
-
-    }
-
-    /**
-     * @param TransactionJournal $journal
-     * @param Tag                $tag
-     *
-     * @return bool
-     */
-    protected function connectBalancingAct(TransactionJournal $journal, Tag $tag): bool
-    {
-        $type        = $journal->transactionType->type;
-        $withdrawals = $tag->transactionJournals()
-                           ->leftJoin('transaction_types', 'transaction_types.id', 'transaction_journals.transaction_type_id')
-                           ->where('transaction_types.type', TransactionType::WITHDRAWAL)->count();
-        $transfers   = $tag->transactionJournals()
-                           ->leftJoin('transaction_types', 'transaction_types.id', 'transaction_journals.transaction_type_id')
-                           ->where('transaction_types.type', TransactionType::TRANSFER)->count();
-
-
-        Log::debug(sprintf('Journal #%d is a %s', $journal->id, $type));
-
-        // only if this is the only withdrawal.
-        if ($type === TransactionType::WITHDRAWAL && $withdrawals < 1) {
-            Log::debug('Will connect this journal because it is the only withdrawal in this tag.');
-            $journal->tags()->save($tag);
-            $journal->save();
-
-            return true;
-        }
-        // and only if this is the only transfer
-        if ($type === TransactionType::TRANSFER && $transfers < 1) {
-            Log::debug('Will connect this journal because it is the only transfer in this tag.');
-            $journal->tags()->save($tag);
-            $journal->save();
-
-            return true;
-        }
-        Log::error(
-            sprintf(
-                'Tag #%d has %d withdrawals and %d transfers and cannot contain %s #%d',
-                $tag->id, $withdrawals, $transfers, $type, $journal->id
-            )
-        );
-
-        // ignore expense
-        return false;
-
-    }
-
-    /**
-     * The incoming journal ($journal)'s accounts (source accounts for a withdrawal, destination accounts for a deposit)
-     * must match the already existing transaction's accounts exactly.
-     *
-     * @param TransactionJournal $journal
-     * @param Tag                $tag
-     *
-     *
-     * @return bool
-     */
-    private function matchAll(TransactionJournal $journal, Tag $tag): bool
-    {
-        $journalSources      = join(',', array_unique($journal->sourceAccountList()->pluck('id')->toArray()));
-        $journalDestinations = join(',', array_unique($journal->destinationAccountList()->pluck('id')->toArray()));
-        $match               = true;
-        $journals            = $tag->transactionJournals()->get(['transaction_journals.*']);
-
-        Log::debug(sprintf('Tag #%d has %d journals to verify:', $tag->id, $journals->count()));
-
-        /** @var TransactionJournal $existing */
-        foreach ($journals as $existing) {
-            Log::debug(sprintf('Now existingcomparing new journal #%d to existing journal #%d', $journal->id, $existing->id));
-            // $checkAccount is the source_account for a withdrawal
-            // $checkAccount is the destination_account for a deposit
-            $existingSources      = join(',', array_unique($existing->sourceAccountList()->pluck('id')->toArray()));
-            $existingDestinations = join(',', array_unique($existing->destinationAccountList()->pluck('id')->toArray()));
-
-            if ($existing->isWithdrawal() && $existingSources !== $journalDestinations) {
-                /*
-                 * There can only be one withdrawal. And the source account(s) of the withdrawal
-                 * must be the same as the destination of the deposit. Because any transaction that arrives
-                 * here ($journal) must be a deposit.
-                 */
-                Log::debug(sprintf('Existing journal #%d is a withdrawal.', $existing->id));
-                Log::debug(sprintf('New journal #%d must have these destination accounts: %s', $journal->id, $existingSources));
-                Log::debug(sprintf('New journal #%d actually these destination accounts: %s', $journal->id, $journalDestinations));
-                Log::debug('So match is FALSE');
-
-                $match = false;
-            }
-            if ($existing->isDeposit() && $journal->isDeposit() && $existingDestinations !== $journalDestinations) {
-                /*
-                 * There can be multiple deposits.
-                 * They must have the destination the same as the other deposits.
-                 */
-                Log::debug(sprintf('Existing journal #%d is a deposit.', $existing->id));
-                Log::debug(sprintf('Journal #%d must have these destination accounts: %s', $journal->id, $existingDestinations));
-                Log::debug(sprintf('Journal #%d actually these destination accounts: %s', $journal->id, $journalDestinations));
-                Log::debug('So match is FALSE');
-
-                $match = false;
-            }
-
-            if ($existing->isDeposit() && $journal->isWithdrawal() && $existingDestinations !== $journalSources) {
-                /*
-                 * There can be one new withdrawal only. It must have the same source as the existing has destination.
-                 */
-                Log::debug(sprintf('Existing journal #%d is a deposit.', $existing->id));
-                Log::debug(sprintf('Journal #%d must have these source accounts: %s', $journal->id, $existingDestinations));
-                Log::debug(sprintf('Journal #%d actually these source accounts: %s', $journal->id, $journalSources));
-                Log::debug('So match is FALSE');
-
-                $match = false;
-            }
-
-        }
-        if ($match) {
-            Log::debug(sprintf('Match is true, connect journal #%d with tag #%d.', $journal->id, $tag->id));
-            $journal->tags()->save($tag);
-            $journal->save();
-
-            return true;
-        }
-
-        return false;
-    }
 }

app/Repositories/Tag/TagRepositoryInterface.php

@@ -135,20 +135,6 @@ interface TagRepositoryInterface
      */
     public function sumOfTag(Tag $tag, ?Carbon $start, ?Carbon $end): string;
 
-    /**
-     * @param Tag $tag
-     *
-     * @return bool
-     */
-    public function tagAllowAdvance(Tag $tag): bool;
-
-    /**
-     * @param Tag $tag
-     *
-     * @return bool
-     */
-    public function tagAllowBalancing(Tag $tag): bool;
-
     /**
      * Update a tag.
      *