remove old inspections

2024-11-21 16:38:36 -06:00 · 2022-10-30 12:12:35 +01:00 · 2022-10-30 12:12:35 +01:00 · 914dc8596b
commit 914dc8596b
parent 6b64a39182
34 changed files with 1 additions and 61 deletions
--- a/.ci/phpstan.neon
+++ b/.ci/phpstan.neon
@ -6,27 +6,11 @@ includes:

 parameters:
  ignoreErrors:
-    - '#is not allowed to extend#'
-    - '#is neither abstract nor final#'
-    - '#Control structures using switch should not be used\.#'
-    - '#has a nullable return type declaration#'
-    - '#with a nullable type declaration#'
-    - '#with null as default value#'
-    - '#Constructor in [a-zA-Z0-9\\_]+ has parameter \$[a-zA-Z0-9\\_]+ with default value#'
-    -
-        message: '#Function compact\(\) should not be used.#'
-        paths:
-            - ../app/Http/Controllers
-            - ../app/Support/Http/Controllers/RenderPartialViews.php
-            - ../app/Support/Form/FormSupport.php
-            - ../app/Support/Form/CurrencyForm.php
-            - ../app/Support/Form/AccountForm.php
-            - ../app/Support/ExpandedForm.php
-            - ../app/Generator/Report
  paths:
    - ../app
    - ../database
    - ../routes
+    - ../tests
    - ../bootstrap/app.php

  # The level 8 is the highest level. original was 5
--- a/app/Console/Commands/Upgrade/BackToJournals.php
+++ b/app/Console/Commands/Upgrade/BackToJournals.php
@ -232,7 +232,6 @@ class BackToJournals extends Command
            $set = DB::table('transactions') // @phpstan-ignore-line
                     ->whereIn('transactions.id', $chunk)
                     ->get(['transaction_journal_id'])->pluck('transaction_journal_id')->toArray();
-            /** @noinspection SlowArrayOperationsInLoopInspection */
            $array = array_merge($array, $set);
        }

--- a/app/Exceptions/Handler.php
+++ b/app/Exceptions/Handler.php
@ -20,8 +20,6 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/** @noinspection MultipleReturnStatementsInspection */
-
 declare(strict_types=1);

 namespace FireflyIII\Exceptions;
--- a/app/Factory/BudgetFactory.php
+++ b/app/Factory/BudgetFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Factory;
--- a/app/Factory/CategoryFactory.php
+++ b/app/Factory/CategoryFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Factory;
--- a/app/Factory/PiggyBankEventFactory.php
+++ b/app/Factory/PiggyBankEventFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Factory;
--- a/app/Factory/PiggyBankFactory.php
+++ b/app/Factory/PiggyBankFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Factory;
--- a/app/Factory/RecurrenceFactory.php
+++ b/app/Factory/RecurrenceFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */

 declare(strict_types=1);

--- a/app/Factory/TagFactory.php
+++ b/app/Factory/TagFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */

 declare(strict_types=1);

--- a/app/Factory/TransactionCurrencyFactory.php
+++ b/app/Factory/TransactionCurrencyFactory.php
@ -19,8 +19,6 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/** @noinspection MultipleReturnStatementsInspection */
-
 declare(strict_types=1);

 namespace FireflyIII\Factory;
--- a/app/Factory/TransactionJournalMetaFactory.php
+++ b/app/Factory/TransactionJournalMetaFactory.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */

 declare(strict_types=1);

--- a/app/Generator/Report/Budget/MonthReportGenerator.php
+++ b/app/Generator/Report/Budget/MonthReportGenerator.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Generator\Report\Budget;
--- a/app/Generator/Report/Category/MonthReportGenerator.php
+++ b/app/Generator/Report/Category/MonthReportGenerator.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Generator\Report\Category;
--- a/app/Generator/Report/Tag/MonthReportGenerator.php
+++ b/app/Generator/Report/Tag/MonthReportGenerator.php
@ -19,7 +19,6 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/** @noinspection MultipleReturnStatementsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Generator\Report\Tag;
--- a/app/Handlers/Events/UserEventHandler.php
+++ b/app/Handlers/Events/UserEventHandler.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection NullPointerExceptionInspection */
 declare(strict_types=1);

 namespace FireflyIII\Handlers\Events;
--- a/app/Handlers/Events/VersionCheckEventHandler.php
+++ b/app/Handlers/Events/VersionCheckEventHandler.php
@ -18,8 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection MultipleReturnStatementsInspection */
-/** @noinspection NullPointerExceptionInspection */
 declare(strict_types=1);

 namespace FireflyIII\Handlers\Events;
--- a/app/Http/Controllers/Account/IndexController.php
+++ b/app/Http/Controllers/Account/IndexController.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection CallableParameterUseCaseInTypeContextInspection */
 declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Account;
--- a/app/Http/Controllers/Account/ReconcileController.php
+++ b/app/Http/Controllers/Account/ReconcileController.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection CallableParameterUseCaseInTypeContextInspection */
 declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Account;
--- a/app/Http/Controllers/Auth/ResetPasswordController.php
+++ b/app/Http/Controllers/Auth/ResetPasswordController.php
@ -144,7 +144,6 @@ class ResetPasswordController extends Controller
            $allowRegistration = false;
        }

-        /** @noinspection PhpUndefinedFieldInspection */
        return view('auth.passwords.reset')->with(
            ['token' => $token, 'email' => $request->email, 'allowRegistration' => $allowRegistration, 'pageTitle' => $pageTitle]
        );
--- a/app/Http/Controllers/Chart/BudgetReportController.php
+++ b/app/Http/Controllers/Chart/BudgetReportController.php
@ -19,7 +19,6 @@
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */

-/** @noinspection MoreThanThreeArgumentsInspection */
 declare(strict_types=1);

 namespace FireflyIII\Http\Controllers\Chart;
--- a/app/Http/Controllers/HomeController.php
+++ b/app/Http/Controllers/HomeController.php
@ -120,7 +120,6 @@ class HomeController extends Controller
        $start = session('start', Carbon::now()->startOfMonth());
        /** @var Carbon $end */
        $end = session('end', Carbon::now()->endOfMonth());
-        /** @noinspection NullPointerExceptionInspection */
        $accounts = $repository->getAccountsById($frontPage->data);
        $today    = today(config('app.timezone'));

--- a/app/Http/Controllers/JavascriptController.php
+++ b/app/Http/Controllers/JavascriptController.php
@ -57,7 +57,6 @@ class JavascriptController extends Controller
            [AccountType::DEFAULT, AccountType::ASSET, AccountType::DEBT, AccountType::LOAN, AccountType::MORTGAGE, AccountType::CREDITCARD]
        );
        $preference = app('preferences')->get('currencyPreference', config('firefly.default_currency', 'EUR'));
-        /** @noinspection NullPointerExceptionInspection */
        $default = $currencyRepository->findByCodeNull((string) $preference->data);

        $data = ['accounts' => []];
@ -66,7 +65,6 @@ class JavascriptController extends Controller
        foreach ($accounts as $account) {
            $accountId = $account->id;
            $currency  = (int) $repository->getMetaValue($account, 'currency_id');
-            /** @noinspection NullPointerExceptionInspection */
            $currency                     = 0 === $currency ? $default->id : $currency;
            $entry                        = ['preferredCurrency' => $currency, 'name' => $account->name];
            $data['accounts'][$accountId] = $entry;
@ -124,7 +122,6 @@ class JavascriptController extends Controller
        $accounting                = app('amount')->getJsConfig();
        $accounting['frac_digits'] = $currency->decimal_places;
        $pref                      = app('preferences')->get('language', config('firefly.default_language', 'en_US'));
-        /** @noinspection NullPointerExceptionInspection */
        $lang      = $pref->data;
        $dateRange = $this->getDateRangeConfig();
        $uid       = substr(hash('sha256', sprintf('%s-%s-%s', (string) config('app.key'), auth()->user()->id, auth()->user()->email)), 0, 12);
--- a/app/Http/Controllers/ReportController.php
+++ b/app/Http/Controllers/ReportController.php
@ -18,7 +18,6 @@
 * You should have received a copy of the GNU Affero General Public License
 * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
-/** @noinspection CallableParameterUseCaseInTypeContextInspection */
 declare(strict_types=1);

 namespace FireflyIII\Http\Controllers;
--- a/app/Http/Controllers/System/InstallController.php
+++ b/app/Http/Controllers/System/InstallController.php
@ -52,8 +52,6 @@ class InstallController extends Controller
    public const OTHER_ERROR     = 'An unknown error prevented Firefly III from executing the upgrade commands. Sorry.';
    private string $lastError;
    private array  $upgradeCommands;
-    /** @noinspection MagicMethodsValidityInspection */
-    /** @noinspection PhpMissingParentConstructorInspection */

    /**
     * InstallController constructor.
--- a/app/Http/Middleware/Authenticate.php
+++ b/app/Http/Middleware/Authenticate.php
@ -91,11 +91,9 @@ class Authenticate
        if (empty($guards)) {
            try {
                // go for default guard:
-                /** @noinspection PhpUndefinedMethodInspection */
                if ($this->auth->check()) {

                    // do an extra check on user object.
-                    /** @noinspection PhpUndefinedMethodInspection */
                    /** @var User $user */
                    $user = $this->auth->authenticate();
                    if (1 === (int) $user->blocked) {
@ -104,7 +102,6 @@ class Authenticate
                            $message = (string) trans('firefly.email_changed_logout');
                        }
                        app('session')->flash('logoutMessage', $message);
-                        /** @noinspection PhpUndefinedMethodInspection */
                        $this->auth->logout();

                        throw new AuthenticationException('Blocked account.', $guards);
@ -121,14 +118,12 @@ class Authenticate

            }

-            /** @noinspection PhpUndefinedMethodInspection */
            return $this->auth->authenticate();
        }


        foreach ($guards as $guard) {
            if ($this->auth->guard($guard)->check()) {
-                /** @noinspection PhpVoidFunctionResultUsedInspection */
                return $this->auth->shouldUse($guard); // @phpstan-ignore-line
            }
        }
--- a/app/Repositories/Budget/NoBudgetRepository.php
+++ b/app/Repositories/Budget/NoBudgetRepository.php
@ -145,7 +145,6 @@ class NoBudgetRepository implements NoBudgetRepositoryInterface
        return $return;
    }

-    /** @noinspection MoreThanThreeArgumentsInspection */
    /**
     * TODO this method does not include multi currency. It just counts.
     * TODO this probably also applies to the other "sumExpenses" methods.
--- a/app/Repositories/Budget/NoBudgetRepositoryInterface.php
+++ b/app/Repositories/Budget/NoBudgetRepositoryInterface.php
@ -58,7 +58,6 @@ interface NoBudgetRepositoryInterface
     */
    public function spentInPeriodWoBudgetMc(Collection $accounts, Carbon $start, Carbon $end): array;

-    /** @noinspection MoreThanThreeArgumentsInspection */
    /**
     * @param Carbon                   $start
     * @param Carbon                   $end
--- a/app/Repositories/Budget/OperationsRepository.php
+++ b/app/Repositories/Budget/OperationsRepository.php
@ -211,7 +211,6 @@ class OperationsRepository implements OperationsRepositoryInterface
        return $repos->getActiveBudgets();
    }

-    /** @noinspection MoreThanThreeArgumentsInspection */

    /**
     * @param User $user
--- a/app/Repositories/Budget/OperationsRepositoryInterface.php
+++ b/app/Repositories/Budget/OperationsRepositoryInterface.php
@ -74,7 +74,6 @@ interface OperationsRepositoryInterface
     */
    public function setUser(User $user): void;

-    /** @noinspection MoreThanThreeArgumentsInspection */

    /**
     * Return multi-currency spent information.
--- a/app/Repositories/Journal/JournalCLIRepository.php
+++ b/app/Repositories/Journal/JournalCLIRepository.php
@ -70,7 +70,6 @@ class JournalCLIRepository implements JournalCLIRepositoryInterface
        if (null !== $budget) {
            return $budget->id;
        }
-        /** @noinspection NullPointerExceptionInspection */
        $budget = $journal->transactions()->first()->budgets()->first();
        if (null !== $budget) {
            return $budget->id;
@ -92,7 +91,6 @@ class JournalCLIRepository implements JournalCLIRepositoryInterface
        if (null !== $category) {
            return $category->id;
        }
-        /** @noinspection NullPointerExceptionInspection */
        $category = $journal->transactions()->first()->categories()->first();
        if (null !== $category) {
            return $category->id;
--- a/app/Support/Amount.php
+++ b/app/Support/Amount.php
@ -66,7 +66,6 @@ class Amount
     * @return string
     *
     * @throws FireflyException
-     * @noinspection MoreThanThreeArgumentsInspection
     */
    public function formatFlat(string $symbol, int $decimalPlaces, string $amount, bool $coloured = null): string
    {
--- a/app/Support/Http/Controllers/ModelInformation.php
+++ b/app/Support/Http/Controllers/ModelInformation.php
@ -81,7 +81,6 @@ trait ModelInformation
        $debt     = $repository->getAccountTypeByType(AccountType::DEBT);
        $loan     = $repository->getAccountTypeByType(AccountType::LOAN);
        $mortgage = $repository->getAccountTypeByType(AccountType::MORTGAGE);
-        /** @noinspection NullPointerExceptionInspection */
        $liabilityTypes = [
            $debt->id     => (string) trans(sprintf('firefly.account_type_%s', AccountType::DEBT)),
            $loan->id     => (string) trans(sprintf('firefly.account_type_%s', AccountType::LOAN)),
--- a/app/Support/Twig/TransactionGroupTwig.php
+++ b/app/Support/Twig/TransactionGroupTwig.php
@ -37,7 +37,6 @@ use Twig\TwigFunction;
 */
 class TransactionGroupTwig extends AbstractExtension
 {
-    /** @noinspection PhpMissingParentCallCommonInspection */
    /**
     * @return array
     *
--- a/public/index.php
+++ b/public/index.php
@ -54,7 +54,6 @@ require __DIR__ . '/../vendor/autoload.php';
 |
 */

-/** @noinspection UsingInclusionOnceReturnValueInspection */
 $app = require_once __DIR__ . '/../bootstrap/app.php';