Various code clean up.

app/Console/Commands/UseEncryption.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * UseEncryption.php
  * Copyright (c) 2017 thegrumpydictator@gmail.com

app/Http/Controllers/HomeController.php

@@ -138,7 +138,7 @@ class HomeController extends Controller
         }
 
         return view(
-            'index', compact('count', 'title', 'subTitle', 'mainTitleIcon', 'transactions', 'showDepositsFrontpage', 'billCount')
+            'index', compact('count', 'subTitle', 'transactions', 'showDepositsFrontpage', 'billCount')
         );
     }
 

app/Http/Controllers/TagController.php

@@ -156,7 +156,7 @@ class TagController extends Controller
         Session::flash('gaEventCategory', 'tags');
         Session::flash('gaEventAction', 'edit');
 
-        return view('tags.edit', compact('tag', 'subTitle', 'subTitleIcon', 'tagOptions', 'apiKey'));
+        return view('tags.edit', compact('tag', 'subTitle', 'subTitleIcon', 'apiKey'));
     }
 
     /**

app/Http/Controllers/Transaction/MassController.php

@@ -131,10 +131,9 @@ class MassController extends Controller
         $filtered = new Collection;
         $messages = [];
         /**
-         * @var int                $index
          * @var TransactionJournal $journal
          */
-        foreach ($journals as $index => $journal) {
+        foreach ($journals as $journal) {
             $sources      = $journal->sourceAccountList();
             $destinations = $journal->destinationAccountList();
             if ($sources->count() > 1) {

app/Http/Controllers/Transaction/SplitController.php

@@ -114,7 +114,7 @@ class SplitController extends Controller
             'transactions.split.edit',
             compact(
                 'subTitleIcon', 'currencies', 'optionalFields',
-                'preFilled', 'subTitle', 'amount', 'sourceAccounts', 'uploadSize', 'destinationAccounts', 'assetAccounts',
+                'preFilled', 'subTitle', 'uploadSize', 'assetAccounts',
                 'budgets', 'journal'
             )
         );

app/Import/FileProcessor/CsvProcessor.php

@@ -260,8 +260,8 @@ class CsvProcessor implements FileProcessorInterface
     private function specifics(array $row): array
     {
         $config = $this->job->configuration;
-        //
+        $names  = array_keys($config['specifics']);
-        foreach ($config['specifics'] as $name => $enabled) {
+        foreach ($names as $name) {
 
             if (!in_array($name, $this->validSpecifics)) {
                 throw new FireflyException(sprintf('"%s" is not a valid class name', $name));

app/Import/Storage/ImportStorage.php

@@ -252,12 +252,11 @@ class ImportStorage
 
     /**
      * @param ImportJournal       $importJournal
-     * @param Account             $account
      * @param TransactionCurrency $localCurrency
      *
      * @return int|null
      */
-    private function getForeignCurrencyId(ImportJournal $importJournal, Account $account, TransactionCurrency $localCurrency): ?int
+    private function getForeignCurrencyId(ImportJournal $importJournal, TransactionCurrency $localCurrency): ?int
     {
         // get journal currency, if any:
         $currency = $importJournal->getCurrency()->getTransactionCurrency();
@@ -394,7 +393,7 @@ class ImportStorage
         $asset             = $importJournal->asset->getAccount();
         $amount            = $importJournal->getAmount();
         $currency          = $this->getCurrency($importJournal, $asset);
-        $foreignCurrencyId = $this->getForeignCurrencyId($importJournal, $asset, $currency);
+        $foreignCurrencyId = $this->getForeignCurrencyId($importJournal, $currency);
         $date              = $importJournal->getDate($this->dateFormat);
         $transactionType   = $this->getTransactionType($amount);
         $opposing          = $this->getOpposingAccount($importJournal->opposing, $amount);

app/Mail/RegisteredUser.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 
 /**

app/Mail/RequestedNewPassword.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 
 /**

app/Repositories/Account/AccountTasker.php

@@ -206,7 +206,8 @@ class AccountTasker implements AccountTaskerInterface
             $expenses[$opposingId]['count']++;
         }
         // do averages:
-        foreach ($expenses as $key => $entry) {
+        $keys = array_keys($expenses);
+        foreach ($keys as $key) {
             if ($expenses[$key]['count'] > 1) {
                 $expenses[$key]['average'] = bcdiv($expenses[$key]['sum'], strval($expenses[$key]['count']));
             }

app/Support/Import/Configuration/Csv/Initial.php

@@ -134,7 +134,8 @@ class Initial implements ConfigurationInterface
     {
         // loop specifics.
         if (isset($data['specifics']) && is_array($data['specifics'])) {
-            foreach ($data['specifics'] as $name => $enabled) {
+            $names = array_keys($data['specifics']);
+            foreach ($names as $name) {
                 // verify their content.
                 $className = sprintf('FireflyIII\Import\Specifics\%s', $name);
                 if (class_exists($className)) {

app/Support/Import/Configuration/Csv/Map.php

@@ -90,10 +90,12 @@ class Map implements ConfigurationInterface
                 }
             }
         }
-        foreach ($this->data as $index => $entry) {
+        $setIndexes = array_keys($this->data);
+        foreach ($setIndexes as $index) {
             $this->data[$index]['values'] = array_unique($this->data[$index]['values']);
             asort($this->data[$index]['values']);
         }
+        unset($setIndexes);
 
         // save number of rows, thus number of steps, in job:
         $steps                      = $rowIndex * 5;
@@ -233,8 +235,8 @@ class Map implements ConfigurationInterface
     {
         // run specifics here:
         // and this is the point where the specifix go to work.
-        foreach ($this->configuration['specifics'] as $name => $enabled) {
+        $names = array_keys($this->configuration['specifics']);
-
+        foreach ($names as $name) {
             if (!in_array($name, $this->validSpecifics)) {
                 throw new FireflyException(sprintf('"%s" is not a valid class name', $name));
             }

app/Support/Import/Configuration/Csv/Roles.php

@@ -228,7 +228,8 @@ class Roles implements ConfigurationInterface
      */
     private function processSpecifics(array $row): array
     {
-        foreach ($this->job->configuration['specifics'] as $name => $enabled) {
+        $names = array_keys($this->configuration['specifics']);
+        foreach ($names as $name) {
             /** @var SpecificInterface $specific */
             $specific = app('FireflyIII\Import\Specifics\\' . $name);
             $row      = $specific->run($row);

app/Support/Search/Search.php

@@ -119,7 +119,7 @@ class Search implements SearchInterface
 
             // Filter transactions that match the given triggers.
             $filtered = $set->filter(
-                function (Transaction $transaction) use ($words) {
+                function (Transaction $transaction) {
 
                     if ($this->matchModifiers($transaction)) {
                         return $transaction;
@@ -237,7 +237,7 @@ class Search implements SearchInterface
             return false;
         }
         foreach ($needle as $what) {
-            if (($pos = strpos($haystack, $what)) !== false) {
+            if (strpos($haystack, $what) !== false) {
                 return true;
             }
         }

config/auth.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * auth.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/broadcasting.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * broadcasting.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/cache.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * cache.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/compile.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * compile.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/database.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * database.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/filesystems.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * filesystems.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/mail.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * mail.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/queue.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * queue.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/services.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * services.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

config/twigbridge.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 /**
  * This file is part of the TwigBridge package.

database/migrations/2016_10_09_150037_expand_transactions_table.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * 2016_10_09_150037_expand_transactions_table.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

database/migrations/2016_10_22_075804_changes_for_v410.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * 2016_10_22_075804_changes_for_v410.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

database/migrations/2016_11_24_210552_changes_for_v420.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * 2016_11_24_210552_changes_for_v420.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

database/migrations/2016_12_22_150431_changes_for_v430.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;

database/migrations/2016_12_28_203205_changes_for_v431.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * 2016_12_28_203205_changes_for_v431.php
  * Copyright (c) 2016 thegrumpydictator@gmail.com

database/migrations/2017_04_13_163623_changes_for_v440.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
@@ -23,6 +25,7 @@ class ChangesForV440 extends Migration
     /**
      * Run the migrations.
      *
+     * @SuppressWarnings(PHPMD.ShortMethodName)
      * @return void
      */
     public function up()

database/migrations/2017_06_02_105232_changes_for_v450.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
@@ -20,6 +22,7 @@ class ChangesForV450 extends Migration
     /**
      * Run the migrations.
      *
+     * @SuppressWarnings(PHPMD.ShortMethodName)
      * @return void
      */
     public function up()

resources/lang/en_US/auth.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * auth.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/breadcrumbs.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 /**
  * breadcrumbs.php

resources/lang/en_US/config.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * config.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/demo.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * demo.php
  * Copyright (c) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/firefly.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * firefly.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/form.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * form.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/help.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * help.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/intro.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * intro.php
  * Copyright (c) 2017 thegrumpydictator@gmail.com
@@ -116,4 +118,4 @@ return [
 
     // create currency
     'currencies_create_code'                                  => 'This code should be ISO compliant (Google it for your new currency).',
-];
+];

resources/lang/en_US/list.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * list.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/pagination.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * pagination.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/passwords.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * passwords.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/lang/en_US/validation.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * validation.php
  * Copyright (C) 2016 thegrumpydictator@gmail.com

resources/views/partials/password-modal.twig

@@ -35,4 +35,4 @@
             </div>
         </div>
     </div>
-</div>
+</div>

tests/CreatesApplication.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 
 
 /**
@@ -14,6 +16,11 @@ namespace Tests;
 
 use Illuminate\Contracts\Console\Kernel;
 
+/**
+ * Trait CreatesApplication
+ *
+ * @package Tests
+ */
 trait CreatesApplication
 {
     /**

tests/Feature/Controllers/AccountControllerTest.php

@@ -31,6 +31,9 @@ use Tests\TestCase;
  * Class AccountControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AccountControllerTest extends TestCase
 {

tests/Feature/Controllers/Admin/ConfigurationControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class ConfigurationControllerTest
  *
  * @package Tests\Feature\Controllers\Admin
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ConfigurationControllerTest extends TestCase
 {

tests/Feature/Controllers/Admin/HomeControllerTest.php

@@ -17,6 +17,9 @@ use Tests\TestCase;
  * Class HomeControllerTest
  *
  * @package Tests\Feature\Controllers\Admin
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class HomeControllerTest extends TestCase
 {

tests/Feature/Controllers/Admin/UserControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class UserControllerTest
  *
  * @package Tests\Feature\Controllers\Admin
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class UserControllerTest extends TestCase
 {

tests/Feature/Controllers/AttachmentControllerTest.php

@@ -17,6 +17,14 @@ use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
 use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
 use Tests\TestCase;
 
+/**
+ * Class AttachmentControllerTest
+ *
+ * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class AttachmentControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/Auth/ForgotPasswordControllerTest.php

@@ -15,6 +15,14 @@ namespace Tests\Feature\Controllers\Auth;
 use FireflyIII\Repositories\User\UserRepositoryInterface;
 use Tests\TestCase;
 
+/**
+ * Class ForgotPasswordControllerTest
+ *
+ * @package Tests\Feature\Controllers\Auth
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class ForgotPasswordControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/Auth/TwoFactorControllerTest.php

@@ -21,6 +21,9 @@ use Tests\TestCase;
  * Class TwoFactorControllerTest
  *
  * @package Tests\Feature\Controllers\Auth
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class TwoFactorControllerTest extends TestCase
 {

tests/Feature/Controllers/BillControllerTest.php

@@ -22,6 +22,14 @@ use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
 use Tests\TestCase;
 
+/**
+ * Class BillControllerTest
+ *
+ * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class BillControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/BudgetControllerTest.php

@@ -23,6 +23,14 @@ use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
 use Tests\TestCase;
 
+/**
+ * Class BudgetControllerTest
+ *
+ * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class BudgetControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/CategoryControllerTest.php

@@ -25,6 +25,14 @@ use Illuminate\Support\Collection;
 use Steam;
 use Tests\TestCase;
 
+/**
+ * Class CategoryControllerTest
+ *
+ * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class CategoryControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/Chart/AccountControllerTest.php

@@ -32,6 +32,9 @@ use Tests\TestCase;
  * Class AccountControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AccountControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/BillControllerTest.php

@@ -23,6 +23,9 @@ use Tests\TestCase;
  * Class BillControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class BillControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/BudgetControllerTest.php

@@ -31,6 +31,9 @@ use Tests\TestCase;
  * Class BudgetControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class BudgetControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/BudgetReportControllerTest.php

@@ -27,6 +27,14 @@ use Illuminate\Support\Collection;
 use Log;
 use Tests\TestCase;
 
+/**
+ * Class BudgetReportControllerTest
+ *
+ * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class BudgetReportControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/Chart/CategoryControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class CategoryControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class CategoryControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/CategoryReportControllerTest.php

@@ -27,6 +27,9 @@ use Tests\TestCase;
  * Class CategoryReportControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class CategoryReportControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/PiggyBankControllerTest.php

@@ -22,6 +22,9 @@ use Tests\TestCase;
  * Class PiggyBankControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class PiggyBankControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/ReportControllerTest.php

@@ -21,6 +21,9 @@ use Tests\TestCase;
  * Class ReportControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ReportControllerTest extends TestCase
 {

tests/Feature/Controllers/Chart/TagReportControllerTest.php

@@ -29,6 +29,9 @@ use Tests\TestCase;
  * Class TagReportControllerTest
  *
  * @package Tests\Feature\Controllers\Chart
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class TagReportControllerTest extends TestCase
 {

tests/Feature/Controllers/CurrencyControllerTest.php

@@ -23,6 +23,9 @@ use Tests\TestCase;
  * Class CurrencyControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class CurrencyControllerTest extends TestCase
 {

tests/Feature/Controllers/ExportControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class ExportControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ExportControllerTest extends TestCase
 {

tests/Feature/Controllers/HelpControllerTest.php

@@ -19,6 +19,9 @@ use Tests\TestCase;
  * Class HelpControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class HelpControllerTest extends TestCase
 {

tests/Feature/Controllers/HomeControllerTest.php

@@ -25,6 +25,9 @@ use Tests\TestCase;
  * Class HomeControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class HomeControllerTest extends TestCase
 {

tests/Feature/Controllers/Import/FileControllerTest.php

@@ -18,7 +18,14 @@ use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
 use Illuminate\Http\UploadedFile;
 use Tests\TestCase;
 
-
+/**
+ * Class FileControllerTest
+ *
+ * @package Tests\Feature\Controllers\Import
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class FileControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/ImportControllerTest.php

@@ -17,6 +17,9 @@ use Tests\TestCase;
  * Class ImportControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ImportControllerTest extends TestCase
 {

tests/Feature/Controllers/JavascriptControllerTest.php

@@ -23,6 +23,9 @@ use Tests\TestCase;
  * Class JavascriptControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class JavascriptControllerTest extends TestCase
 {

tests/Feature/Controllers/Json/ExchangeControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class ExchangeControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ExchangeControllerTest extends TestCase
 {

tests/Feature/Controllers/JsonControllerTest.php

@@ -33,6 +33,9 @@ use Tests\TestCase;
  * Class JsonControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class JsonControllerTest extends TestCase
 {

tests/Feature/Controllers/NewUserControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class NewUserControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class NewUserControllerTest extends TestCase
 {

tests/Feature/Controllers/PiggyBankControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class PiggyBankControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class PiggyBankControllerTest extends TestCase
 {

tests/Feature/Controllers/Popup/ReportControllerTest.php

@@ -28,6 +28,9 @@ use Tests\TestCase;
  * Class ReportControllerTest
  *
  * @package Tests\Feature\Controllers\Popup
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ReportControllerTest extends TestCase
 {

tests/Feature/Controllers/PreferencesControllerTest.php

@@ -25,6 +25,9 @@ use Tests\TestCase;
  * Class PreferencesControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class PreferencesControllerTest extends TestCase
 {

tests/Feature/Controllers/ProfileControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class ProfileControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ProfileControllerTest extends TestCase
 {

tests/Feature/Controllers/Report/AccountControllerTest.php

@@ -19,6 +19,9 @@ use Tests\TestCase;
  * Class AccountControllerTest
  *
  * @package Tests\Feature\Controllers\Report
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AccountControllerTest extends TestCase
 {

tests/Feature/Controllers/Report/BalanceControllerTest.php

@@ -20,6 +20,9 @@ use Tests\TestCase;
  * Class BalanceControllerTest
  *
  * @package Tests\Feature\Controllers\Report
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class BalanceControllerTest extends TestCase
 {

tests/Feature/Controllers/Report/BudgetControllerTest.php

@@ -21,6 +21,9 @@ use Tests\TestCase;
  * Class BudgetControllerTest
  *
  * @package Tests\Feature\Controllers\Report
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class BudgetControllerTest extends TestCase
 {

tests/Feature/Controllers/Report/CategoryControllerTest.php

@@ -17,6 +17,14 @@ use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
 use Illuminate\Support\Collection;
 use Tests\TestCase;
 
+/**
+ * Class CategoryControllerTest
+ *
+ * @package Tests\Feature\Controllers\Report
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class CategoryControllerTest extends TestCase
 {
     /**

tests/Feature/Controllers/Report/OperationsControllerTest.php

@@ -22,6 +22,9 @@ use Tests\TestCase;
  * Class OperationsControllerTest
  *
  * @package Tests\Feature\Controllers\Report
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class OperationsControllerTest extends TestCase
 {

tests/Feature/Controllers/ReportControllerTest.php

@@ -35,6 +35,9 @@ use Tests\TestCase;
  * Class ReportControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ReportControllerTest extends TestCase
 {

tests/Feature/Controllers/RuleControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class RuleControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class RuleControllerTest extends TestCase
 {

tests/Feature/Controllers/RuleGroupControllerTest.php

@@ -25,6 +25,9 @@ use Tests\TestCase;
  * Class RuleGroupControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class RuleGroupControllerTest extends TestCase
 {

tests/Feature/Controllers/SearchControllerTest.php

@@ -18,6 +18,9 @@ use Tests\TestCase;
  * Class SearchControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SearchControllerTest extends TestCase
 {

tests/Feature/Controllers/TagControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class TagControllerTest
  *
  * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class TagControllerTest extends TestCase
 {

tests/Feature/Controllers/Transaction/ConvertControllerTest.php

@@ -26,6 +26,9 @@ use Tests\TestCase;
  * Class ConvertControllerTest
  *
  * @package Tests\Feature\Controllers\Transaction
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ConvertControllerTest extends TestCase
 {

tests/Feature/Controllers/Transaction/MassControllerTest.php

@@ -25,6 +25,9 @@ use Tests\TestCase;
  * Class MassControllerTest
  *
  * @package Tests\Feature\Controllers\Transaction
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class MassControllerTest extends TestCase
 {

tests/Feature/Controllers/Transaction/SingleControllerTest.php

@@ -34,6 +34,9 @@ use Tests\TestCase;
  * Class SingleControllerTest
  *
  * @package Tests\Feature\Controllers\Transaction
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SingleControllerTest extends TestCase
 {

tests/Feature/Controllers/Transaction/SplitControllerTest.php

@@ -29,6 +29,9 @@ use Tests\TestCase;
  * Class SplitControllerTest
  *
  * @package Tests\Feature\Controllers\Transaction
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class SplitControllerTest extends TestCase
 {

tests/Feature/Controllers/TransactionControllerTest.php

@@ -22,6 +22,14 @@ use Illuminate\Support\Collection;
 use Steam;
 use Tests\TestCase;
 
+/**
+ * Class TransactionControllerTest
+ *
+ * @package Tests\Feature\Controllers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class TransactionControllerTest extends TestCase
 {
 

tests/Feature/ExampleTest.php

@@ -1,4 +1,6 @@
 <?php
+declare(strict_types=1);
+
 /**
  * ExampleTest.php
  * Copyright (c) 2017 thegrumpydictator@gmail.com
@@ -11,7 +13,11 @@ namespace Tests\Feature;
 
 use Tests\TestCase;
 
-
+/**
+ * Class ExampleTest
+ *
+ * @package Tests\Feature
+ */
 class ExampleTest extends TestCase
 {
     /**

tests/TestCase.php

@@ -1,5 +1,5 @@
 <?php
-
+declare(strict_types=1);
 
 /**
  * TestCase.php
@@ -23,6 +23,7 @@ use Mockery;
  * Class TestCase
  *
  * @package Tests
+ * @SuppressWarnings(PHPMD.NumberOfChildren)
  */
 abstract class TestCase extends BaseTestCase
 {

tests/Unit/ExampleTest.php

@@ -1,5 +1,6 @@
 <?php
 
+declare(strict_types=1);
 
 /**
  * ExampleTest.php
@@ -14,7 +15,14 @@ namespace Tests\Unit;
 
 use Tests\TestCase;
 
-
+/**
+ * Class ExampleTest
+ *
+ * @package Tests\Unit
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class ExampleTest extends TestCase
 {
     /**

tests/Unit/Handlers/Events/UserEventHandlerTest.php

@@ -21,6 +21,14 @@ use FireflyIII\Repositories\User\UserRepositoryInterface;
 use Illuminate\Support\Facades\Mail;
 use Tests\TestCase;
 
+/**
+ * Class UserEventHandlerTest
+ *
+ * @package Tests\Unit\Handlers\Events
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class UserEventHandlerTest extends TestCase
 {
     /**

tests/Unit/Helpers/AttachmentHelperTest.php

@@ -23,6 +23,9 @@ use Tests\TestCase;
  * Class AttachmentHelperTest
  *
  * @package Tests\Unit\Helpers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class AttachmentHelperTest extends TestCase
 {

tests/Unit/Helpers/MetaPieChartTest.php

@@ -25,6 +25,14 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use Illuminate\Support\Collection;
 use Tests\TestCase;
 
+/**
+ * Class MetaPieChartTest
+ *
+ * @package Tests\Unit\Helpers
+ * @SuppressWarnings(PHPMD.TooManyPublicMethods)
+ * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
+ */
 class MetaPieChartTest extends TestCase
 {
     /**