IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Various code clean up.

Browse Source
This commit is contained in:
James Cole 2017-08-12 10:27:45 +02:00
parent a3a416b5e2
commit 9803932324
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
99 changed files with 322 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Console/Commands/UseEncryption.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* UseEncryption.php
* Copyright (c) 2017 thegrumpydictator@gmail.com

2
app/Http/Controllers/HomeController.php
View File

@ -138,7 +138,7 @@ class HomeController extends Controller
}
return view(
'index', compact('count', 'title', 'subTitle', 'mainTitleIcon', 'transactions', 'showDepositsFrontpage', 'billCount')
'index', compact('count', 'subTitle', 'transactions', 'showDepositsFrontpage', 'billCount')
);
}

2
app/Http/Controllers/TagController.php
View File

@ -156,7 +156,7 @@ class TagController extends Controller
Session::flash('gaEventCategory', 'tags');
Session::flash('gaEventAction', 'edit');
return view('tags.edit', compact('tag', 'subTitle', 'subTitleIcon', 'tagOptions', 'apiKey'));
return view('tags.edit', compact('tag', 'subTitle', 'subTitleIcon', 'apiKey'));
}
/**

3
app/Http/Controllers/Transaction/MassController.php
View File

@ -131,10 +131,9 @@ class MassController extends Controller
$filtered = new Collection;
$messages = [];
/**
* @var int $index
* @var TransactionJournal $journal
*/
foreach ($journals as $index => $journal) {
foreach ($journals as $journal) {
$sources = $journal->sourceAccountList();
$destinations = $journal->destinationAccountList();
if ($sources->count() > 1) {

2
app/Http/Controllers/Transaction/SplitController.php
View File

@ -114,7 +114,7 @@ class SplitController extends Controller
'transactions.split.edit',
compact(
'subTitleIcon', 'currencies', 'optionalFields',
'preFilled', 'subTitle', 'amount', 'sourceAccounts', 'uploadSize', 'destinationAccounts', 'assetAccounts',
'preFilled', 'subTitle', 'uploadSize', 'assetAccounts',
'budgets', 'journal'
)
);

4
app/Import/FileProcessor/CsvProcessor.php
View File

@ -260,8 +260,8 @@ class CsvProcessor implements FileProcessorInterface
private function specifics(array $row): array
{
$config = $this->job->configuration;
//
foreach ($config['specifics'] as $name => $enabled) {
$names = array_keys($config['specifics']);
foreach ($names as $name) {
if (!in_array($name, $this->validSpecifics)) {
throw new FireflyException(sprintf('"%s" is not a valid class name', $name));

5
app/Import/Storage/ImportStorage.php
View File

@ -252,12 +252,11 @@ class ImportStorage
/**
* @param ImportJournal $importJournal
* @param Account $account
* @param TransactionCurrency $localCurrency
*
* @return int|null
*/
private function getForeignCurrencyId(ImportJournal $importJournal, Account $account, TransactionCurrency $localCurrency): ?int
private function getForeignCurrencyId(ImportJournal $importJournal, TransactionCurrency $localCurrency): ?int
{
// get journal currency, if any:
$currency = $importJournal->getCurrency()->getTransactionCurrency();
@ -394,7 +393,7 @@ class ImportStorage
$asset = $importJournal->asset->getAccount();
$amount = $importJournal->getAmount();
$currency = $this->getCurrency($importJournal, $asset);
$foreignCurrencyId = $this->getForeignCurrencyId($importJournal, $asset, $currency);
$foreignCurrencyId = $this->getForeignCurrencyId($importJournal, $currency);
$date = $importJournal->getDate($this->dateFormat);
$transactionType = $this->getTransactionType($amount);
$opposing = $this->getOpposingAccount($importJournal->opposing, $amount);

2
app/Mail/RegisteredUser.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**

2
app/Mail/RequestedNewPassword.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**

3
app/Repositories/Account/AccountTasker.php
View File

@ -206,7 +206,8 @@ class AccountTasker implements AccountTaskerInterface
$expenses[$opposingId]['count']++;
}
// do averages:
foreach ($expenses as $key => $entry) {
$keys = array_keys($expenses);
foreach ($keys as $key) {
if ($expenses[$key]['count'] > 1) {
$expenses[$key]['average'] = bcdiv($expenses[$key]['sum'], strval($expenses[$key]['count']));
}

3
app/Support/Import/Configuration/Csv/Initial.php
View File

@ -134,7 +134,8 @@ class Initial implements ConfigurationInterface
{
// loop specifics.
if (isset($data['specifics']) && is_array($data['specifics'])) {
foreach ($data['specifics'] as $name => $enabled) {
$names = array_keys($data['specifics']);
foreach ($names as $name) {
// verify their content.
$className = sprintf('FireflyIII\Import\Specifics\%s', $name);
if (class_exists($className)) {

8
app/Support/Import/Configuration/Csv/Map.php
View File

@ -90,10 +90,12 @@ class Map implements ConfigurationInterface
}
}
}
foreach ($this->data as $index => $entry) {
$setIndexes = array_keys($this->data);
foreach ($setIndexes as $index) {
$this->data[$index]['values'] = array_unique($this->data[$index]['values']);
asort($this->data[$index]['values']);
}
unset($setIndexes);
// save number of rows, thus number of steps, in job:
$steps = $rowIndex * 5;
@ -233,8 +235,8 @@ class Map implements ConfigurationInterface
{
// run specifics here:
// and this is the point where the specifix go to work.
foreach ($this->configuration['specifics'] as $name => $enabled) {
$names = array_keys($this->configuration['specifics']);
foreach ($names as $name) {
if (!in_array($name, $this->validSpecifics)) {
throw new FireflyException(sprintf('"%s" is not a valid class name', $name));
}

3
app/Support/Import/Configuration/Csv/Roles.php
View File

@ -228,7 +228,8 @@ class Roles implements ConfigurationInterface
*/
private function processSpecifics(array $row): array
{
foreach ($this->job->configuration['specifics'] as $name => $enabled) {
$names = array_keys($this->configuration['specifics']);
foreach ($names as $name) {
/** @var SpecificInterface $specific */
$specific = app('FireflyIII\Import\Specifics\\' . $name);
$row = $specific->run($row);

4
app/Support/Search/Search.php
View File

@ -119,7 +119,7 @@ class Search implements SearchInterface
// Filter transactions that match the given triggers.
$filtered = $set->filter(
function (Transaction $transaction) use ($words) {
function (Transaction $transaction) {
if ($this->matchModifiers($transaction)) {
return $transaction;
@ -237,7 +237,7 @@ class Search implements SearchInterface
return false;
}
foreach ($needle as $what) {
if (($pos = strpos($haystack, $what)) !== false) {
if (strpos($haystack, $what) !== false) {
return true;
}
}

2
config/auth.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* auth.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/broadcasting.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* broadcasting.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/cache.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* cache.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/compile.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* compile.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/database.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* database.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/filesystems.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* filesystems.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/mail.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* mail.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/queue.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* queue.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/services.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* services.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
config/twigbridge.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* This file is part of the TwigBridge package.

2
database/migrations/2016_10_09_150037_expand_transactions_table.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* 2016_10_09_150037_expand_transactions_table.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
database/migrations/2016_10_22_075804_changes_for_v410.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* 2016_10_22_075804_changes_for_v410.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
database/migrations/2016_11_24_210552_changes_for_v420.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* 2016_11_24_210552_changes_for_v420.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
database/migrations/2016_12_22_150431_changes_for_v430.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;

2
database/migrations/2016_12_28_203205_changes_for_v431.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* 2016_12_28_203205_changes_for_v431.php
* Copyright (c) 2016 thegrumpydictator@gmail.com

3
database/migrations/2017_04_13_163623_changes_for_v440.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
@ -23,6 +25,7 @@ class ChangesForV440 extends Migration
/**
* Run the migrations.
*
* @SuppressWarnings(PHPMD.ShortMethodName)
* @return void
*/
public function up()

3
database/migrations/2017_06_02_105232_changes_for_v450.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
@ -20,6 +22,7 @@ class ChangesForV450 extends Migration
/**
* Run the migrations.
*
* @SuppressWarnings(PHPMD.ShortMethodName)
* @return void
*/
public function up()

2
resources/lang/en_US/auth.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* auth.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/breadcrumbs.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* breadcrumbs.php

2
resources/lang/en_US/config.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* config.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/demo.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* demo.php
* Copyright (c) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/firefly.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* firefly.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/form.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* form.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/help.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* help.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/intro.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* intro.php
* Copyright (c) 2017 thegrumpydictator@gmail.com

2
resources/lang/en_US/list.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* list.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/pagination.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* pagination.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/passwords.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* passwords.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

2
resources/lang/en_US/validation.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* validation.php
* Copyright (C) 2016 thegrumpydictator@gmail.com

7
tests/CreatesApplication.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
@ -14,6 +16,11 @@ namespace Tests;
use Illuminate\Contracts\Console\Kernel;
/**
* Trait CreatesApplication
*
* @package Tests
*/
trait CreatesApplication
{
/**

3
tests/Feature/Controllers/AccountControllerTest.php
View File

@ -31,6 +31,9 @@ use Tests\TestCase;
* Class AccountControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AccountControllerTest extends TestCase
{

3
tests/Feature/Controllers/Admin/ConfigurationControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class ConfigurationControllerTest
*
* @package Tests\Feature\Controllers\Admin
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ConfigurationControllerTest extends TestCase
{

3
tests/Feature/Controllers/Admin/HomeControllerTest.php
View File

@ -17,6 +17,9 @@ use Tests\TestCase;
* Class HomeControllerTest
*
* @package Tests\Feature\Controllers\Admin
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class HomeControllerTest extends TestCase
{

3
tests/Feature/Controllers/Admin/UserControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class UserControllerTest
*
* @package Tests\Feature\Controllers\Admin
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class UserControllerTest extends TestCase
{

8
tests/Feature/Controllers/AttachmentControllerTest.php
View File

@ -17,6 +17,14 @@ use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
use FireflyIII\Repositories\Journal\JournalRepositoryInterface;
use Tests\TestCase;
/**
* Class AttachmentControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AttachmentControllerTest extends TestCase
{
/**

8
tests/Feature/Controllers/Auth/ForgotPasswordControllerTest.php
View File

@ -15,6 +15,14 @@ namespace Tests\Feature\Controllers\Auth;
use FireflyIII\Repositories\User\UserRepositoryInterface;
use Tests\TestCase;
/**
* Class ForgotPasswordControllerTest
*
* @package Tests\Feature\Controllers\Auth
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ForgotPasswordControllerTest extends TestCase
{
/**

3
tests/Feature/Controllers/Auth/TwoFactorControllerTest.php
View File

@ -21,6 +21,9 @@ use Tests\TestCase;
* Class TwoFactorControllerTest
*
* @package Tests\Feature\Controllers\Auth
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class TwoFactorControllerTest extends TestCase
{

8
tests/Feature/Controllers/BillControllerTest.php
View File

@ -22,6 +22,14 @@ use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Tests\TestCase;
/**
* Class BillControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BillControllerTest extends TestCase
{
/**

8
tests/Feature/Controllers/BudgetControllerTest.php
View File

@ -23,6 +23,14 @@ use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;
use Tests\TestCase;
/**
* Class BudgetControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetControllerTest extends TestCase
{
/**

8
tests/Feature/Controllers/CategoryControllerTest.php
View File

@ -25,6 +25,14 @@ use Illuminate\Support\Collection;
use Steam;
use Tests\TestCase;
/**
* Class CategoryControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryControllerTest extends TestCase
{
/**

3
tests/Feature/Controllers/Chart/AccountControllerTest.php
View File

@ -32,6 +32,9 @@ use Tests\TestCase;
* Class AccountControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AccountControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/BillControllerTest.php
View File

@ -23,6 +23,9 @@ use Tests\TestCase;
* Class BillControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BillControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/BudgetControllerTest.php
View File

@ -31,6 +31,9 @@ use Tests\TestCase;
* Class BudgetControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetControllerTest extends TestCase
{

8
tests/Feature/Controllers/Chart/BudgetReportControllerTest.php
View File

@ -27,6 +27,14 @@ use Illuminate\Support\Collection;
use Log;
use Tests\TestCase;
/**
* Class BudgetReportControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetReportControllerTest extends TestCase
{
/**

3
tests/Feature/Controllers/Chart/CategoryControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class CategoryControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/CategoryReportControllerTest.php
View File

@ -27,6 +27,9 @@ use Tests\TestCase;
* Class CategoryReportControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryReportControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/PiggyBankControllerTest.php
View File

@ -22,6 +22,9 @@ use Tests\TestCase;
* Class PiggyBankControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class PiggyBankControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/ReportControllerTest.php
View File

@ -21,6 +21,9 @@ use Tests\TestCase;
* Class ReportControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ReportControllerTest extends TestCase
{

3
tests/Feature/Controllers/Chart/TagReportControllerTest.php
View File

@ -29,6 +29,9 @@ use Tests\TestCase;
* Class TagReportControllerTest
*
* @package Tests\Feature\Controllers\Chart
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class TagReportControllerTest extends TestCase
{

3
tests/Feature/Controllers/CurrencyControllerTest.php
View File

@ -23,6 +23,9 @@ use Tests\TestCase;
* Class CurrencyControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CurrencyControllerTest extends TestCase
{

3
tests/Feature/Controllers/ExportControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class ExportControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ExportControllerTest extends TestCase
{

3
tests/Feature/Controllers/HelpControllerTest.php
View File

@ -19,6 +19,9 @@ use Tests\TestCase;
* Class HelpControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class HelpControllerTest extends TestCase
{

3
tests/Feature/Controllers/HomeControllerTest.php
View File

@ -25,6 +25,9 @@ use Tests\TestCase;
* Class HomeControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class HomeControllerTest extends TestCase
{

9
tests/Feature/Controllers/Import/FileControllerTest.php
View File

@ -18,7 +18,14 @@ use FireflyIII\Repositories\ImportJob\ImportJobRepositoryInterface;
use Illuminate\Http\UploadedFile;
use Tests\TestCase;
/**
* Class FileControllerTest
*
* @package Tests\Feature\Controllers\Import
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class FileControllerTest extends TestCase
{
/**

3
tests/Feature/Controllers/ImportControllerTest.php
View File

@ -17,6 +17,9 @@ use Tests\TestCase;
* Class ImportControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ImportControllerTest extends TestCase
{

3
tests/Feature/Controllers/JavascriptControllerTest.php
View File

@ -23,6 +23,9 @@ use Tests\TestCase;
* Class JavascriptControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class JavascriptControllerTest extends TestCase
{

3
tests/Feature/Controllers/Json/ExchangeControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class ExchangeControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ExchangeControllerTest extends TestCase
{

3
tests/Feature/Controllers/JsonControllerTest.php
View File

@ -33,6 +33,9 @@ use Tests\TestCase;
* Class JsonControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class JsonControllerTest extends TestCase
{

3
tests/Feature/Controllers/NewUserControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class NewUserControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class NewUserControllerTest extends TestCase
{

3
tests/Feature/Controllers/PiggyBankControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class PiggyBankControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class PiggyBankControllerTest extends TestCase
{

3
tests/Feature/Controllers/Popup/ReportControllerTest.php
View File

@ -28,6 +28,9 @@ use Tests\TestCase;
* Class ReportControllerTest
*
* @package Tests\Feature\Controllers\Popup
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ReportControllerTest extends TestCase
{

3
tests/Feature/Controllers/PreferencesControllerTest.php
View File

@ -25,6 +25,9 @@ use Tests\TestCase;
* Class PreferencesControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class PreferencesControllerTest extends TestCase
{

3
tests/Feature/Controllers/ProfileControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class ProfileControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ProfileControllerTest extends TestCase
{

3
tests/Feature/Controllers/Report/AccountControllerTest.php
View File

@ -19,6 +19,9 @@ use Tests\TestCase;
* Class AccountControllerTest
*
* @package Tests\Feature\Controllers\Report
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AccountControllerTest extends TestCase
{

3
tests/Feature/Controllers/Report/BalanceControllerTest.php
View File

@ -20,6 +20,9 @@ use Tests\TestCase;
* Class BalanceControllerTest
*
* @package Tests\Feature\Controllers\Report
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BalanceControllerTest extends TestCase
{

3
tests/Feature/Controllers/Report/BudgetControllerTest.php
View File

@ -21,6 +21,9 @@ use Tests\TestCase;
* Class BudgetControllerTest
*
* @package Tests\Feature\Controllers\Report
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class BudgetControllerTest extends TestCase
{

8
tests/Feature/Controllers/Report/CategoryControllerTest.php
View File

@ -17,6 +17,14 @@ use FireflyIII\Repositories\Category\CategoryRepositoryInterface;
use Illuminate\Support\Collection;
use Tests\TestCase;
/**
* Class CategoryControllerTest
*
* @package Tests\Feature\Controllers\Report
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class CategoryControllerTest extends TestCase
{
/**

3
tests/Feature/Controllers/Report/OperationsControllerTest.php
View File

@ -22,6 +22,9 @@ use Tests\TestCase;
* Class OperationsControllerTest
*
* @package Tests\Feature\Controllers\Report
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class OperationsControllerTest extends TestCase
{

3
tests/Feature/Controllers/ReportControllerTest.php
View File

@ -35,6 +35,9 @@ use Tests\TestCase;
* Class ReportControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ReportControllerTest extends TestCase
{

3
tests/Feature/Controllers/RuleControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class RuleControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class RuleControllerTest extends TestCase
{

3
tests/Feature/Controllers/RuleGroupControllerTest.php
View File

@ -25,6 +25,9 @@ use Tests\TestCase;
* Class RuleGroupControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class RuleGroupControllerTest extends TestCase
{

3
tests/Feature/Controllers/SearchControllerTest.php
View File

@ -18,6 +18,9 @@ use Tests\TestCase;
* Class SearchControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class SearchControllerTest extends TestCase
{

3
tests/Feature/Controllers/TagControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class TagControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class TagControllerTest extends TestCase
{

3
tests/Feature/Controllers/Transaction/ConvertControllerTest.php
View File

@ -26,6 +26,9 @@ use Tests\TestCase;
* Class ConvertControllerTest
*
* @package Tests\Feature\Controllers\Transaction
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ConvertControllerTest extends TestCase
{

3
tests/Feature/Controllers/Transaction/MassControllerTest.php
View File

@ -25,6 +25,9 @@ use Tests\TestCase;
* Class MassControllerTest
*
* @package Tests\Feature\Controllers\Transaction
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class MassControllerTest extends TestCase
{

3
tests/Feature/Controllers/Transaction/SingleControllerTest.php
View File

@ -34,6 +34,9 @@ use Tests\TestCase;
* Class SingleControllerTest
*
* @package Tests\Feature\Controllers\Transaction
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class SingleControllerTest extends TestCase
{

3
tests/Feature/Controllers/Transaction/SplitControllerTest.php
View File

@ -29,6 +29,9 @@ use Tests\TestCase;
* Class SplitControllerTest
*
* @package Tests\Feature\Controllers\Transaction
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class SplitControllerTest extends TestCase
{

8
tests/Feature/Controllers/TransactionControllerTest.php
View File

@ -22,6 +22,14 @@ use Illuminate\Support\Collection;
use Steam;
use Tests\TestCase;
/**
* Class TransactionControllerTest
*
* @package Tests\Feature\Controllers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class TransactionControllerTest extends TestCase
{

8
tests/Feature/ExampleTest.php
View File

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* ExampleTest.php
* Copyright (c) 2017 thegrumpydictator@gmail.com
@ -11,7 +13,11 @@ namespace Tests\Feature;
use Tests\TestCase;
/**
* Class ExampleTest
*
* @package Tests\Feature
*/
class ExampleTest extends TestCase
{
/**

3
tests/TestCase.php
View File

@ -1,5 +1,5 @@
<?php
declare(strict_types=1);
/**
* TestCase.php
@ -23,6 +23,7 @@ use Mockery;
* Class TestCase
*
* @package Tests
* @SuppressWarnings(PHPMD.NumberOfChildren)
*/
abstract class TestCase extends BaseTestCase
{

10
tests/Unit/ExampleTest.php
View File

@ -1,5 +1,6 @@
<?php
declare(strict_types=1);
/**
* ExampleTest.php
@ -14,7 +15,14 @@ namespace Tests\Unit;
use Tests\TestCase;
/**
* Class ExampleTest
*
* @package Tests\Unit
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class ExampleTest extends TestCase
{
/**

8
tests/Unit/Handlers/Events/UserEventHandlerTest.php
View File

@ -21,6 +21,14 @@ use FireflyIII\Repositories\User\UserRepositoryInterface;
use Illuminate\Support\Facades\Mail;
use Tests\TestCase;
/**
* Class UserEventHandlerTest
*
* @package Tests\Unit\Handlers\Events
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class UserEventHandlerTest extends TestCase
{
/**

3
tests/Unit/Helpers/AttachmentHelperTest.php
View File

@ -23,6 +23,9 @@ use Tests\TestCase;
* Class AttachmentHelperTest
*
* @package Tests\Unit\Helpers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class AttachmentHelperTest extends TestCase
{

8
tests/Unit/Helpers/MetaPieChartTest.php
View File

@ -25,6 +25,14 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use Illuminate\Support\Collection;
use Tests\TestCase;
/**
* Class MetaPieChartTest
*
* @package Tests\Unit\Helpers
* @SuppressWarnings(PHPMD.TooManyPublicMethods)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class MetaPieChartTest extends TestCase
{
/**