Optimize new JS code.

app/Http/Controllers/JavascriptController.php

@@ -30,12 +30,44 @@ class JavascriptController extends Controller
      */
     public function variables()
     {
+        $picker                    = $this->getDateRangePicker();
+        $start                     = Session::get('start');
+        $end                       = Session::get('end');
+        $linkTitle                 = sprintf('%s - %s', $start->formatLocalized($this->monthAndDayFormat), $end->formatLocalized($this->monthAndDayFormat));
+        $firstDate                 = session('first')->format('Y-m-d');
+        $localeconv                = localeconv();
+        $accounting                = Amount::getJsConfig($localeconv);
+        $localeconv                = localeconv();
+        $defaultCurrency           = Amount::getDefaultCurrency();
+        $localeconv['frac_digits'] = $defaultCurrency->decimal_places;
+        $pref                      = Preferences::get('language', config('firefly.default_language', 'en_US'));
+        $lang                      = $pref->data;
+        $data                      = [
+            'picker'         => $picker,
+            'linkTitle'      => $linkTitle,
+            'firstDate'      => $firstDate,
+            'currencyCode'   => Amount::getCurrencyCode(),
+            'currencySymbol' => Amount::getCurrencySymbol(),
+            'accounting'     => $accounting,
+            'localeconv'     => $localeconv,
+            'language'       => $lang,
+        ];
 
+        return response()
+            ->view('javascript.variables', $data, 200)
+            ->header('Content-Type', 'text/javascript');
+    }
+
+    /**
+     * @return array
+     * @throws FireflyException
+     */
+    private function getDateRangePicker(): array
+    {
         $viewRange = Preferences::get('viewRange', '1M')->data;
         $start     = Session::get('start');
         $end       = Session::get('end');
-        $linkTitle = sprintf('%s - %s', $start->formatLocalized($this->monthAndDayFormat), $end->formatLocalized($this->monthAndDayFormat));
+
-        $firstDate = session('first')->format('Y-m-d');
         $prevStart = clone $start;
         $prevEnd   = clone $start;
         $nextStart = clone $end;
@@ -83,35 +115,18 @@ class JavascriptController extends Controller
                 break;
         }
 
-        $current                   = $start->formatLocalized($format);
+        $current = $start->formatLocalized($format);
-        $next                      = $nextStart->formatLocalized($format);
+        $next    = $nextStart->formatLocalized($format);
-        $prev                      = $prevStart->formatLocalized($format);
+        $prev    = $prevStart->formatLocalized($format);
-        $localeconv                = localeconv();
-        $accounting                = Amount::getJsConfig($localeconv);
-        $localeconv                = localeconv();
-        $defaultCurrency           = Amount::getDefaultCurrency();
-        $localeconv['frac_digits'] = $defaultCurrency->decimal_places;
-        $pref                      = Preferences::get('language', config('firefly.default_language', 'en_US'));
-        $lang                      = $pref->data;
-        $data                      = [
-            'dpStart'        => $start->format('Y-m-d'),
-            'dpEnd'          => $end->format('Y-m-d'),
-            'dpCurrent'      => $current,
-            'dpPrevious'     => $prev,
-            'dpNext'         => $next,
-            'dpRanges'       => $ranges,
-            'linkTitle'      => $linkTitle,
-            'firstDate'      => $firstDate,
-            'currencyCode'   => Amount::getCurrencyCode(),
-            'currencySymbol' => Amount::getCurrencySymbol(),
-            'accounting'     => $accounting,
-            'localeconv'     => $localeconv,
-            'language'       => $lang,
-        ];
 
-        return response()
+        return [
-            ->view('javascript.variables', $data, 200)
+            'start'    => $start->format('Y-m-d'),
-            ->header('Content-Type', 'text/javascript');
+            'end'      => $end->format('Y-m-d'),
+            'current'  => $current,
+            'previous' => $prev,
+            'next'     => $next,
+            'ranges'   => $ranges,
+        ];
     }
 
 }

resources/views/javascript/variables.twig

@@ -1,20 +1,20 @@
 // date range picker configuration:
 var dateRangeConfig = {
-    startDate: moment("{{ dpStart }}"),
+    startDate: moment("{{ picker.start }}"),
-    endDate: moment("{{ dpEnd }}"),
+    endDate: moment("{{ picker.end }}"),
     linkTitle: "{{ linkTitle }}",
     URL: "{{ route('daterange') }}",
     firstDate: moment("{{ firstDate }}"),
-    currentPeriod: "{{ dpCurrent }}",
+    currentPeriod: "{{ picker.current }}",
-    previousPeriod: "{{ dpPrevious }}",
+    previousPeriod: "{{ picker.previous }}",
-    nextPeriod: "{{ dpNext }}",
+    nextPeriod: "{{ picker.next }}",
     everything: '{{ 'everything'|_|escape }}',
     customRangeLabel: '{{ 'customRange'|_|escape }}',
     applyLabel: '{{ 'apply'|_|escape }}',
     cancelLabel: '{{ 'cancel'|_|escape }}',
     fromLabel: '{{ 'from'|_|escape }}',
     toLabel: '{{ 'to'|_|escape }}',
-    ranges: {{ dpRanges|json_encode|raw }}
+    ranges: {{ picker.ranges|json_encode|raw }}
 };
 
 var language = "{{ language|escape }}";