IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add code coverage ignore instructions.

Browse Source
This commit is contained in:
James Cole 2017-03-04 11:19:44 +01:00
parent 45f4395f26
commit 9d22bbee1c
No known key found for this signature in database
GPG Key ID: C16961E655E74B5E
25 changed files with 64 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Http/Controllers/AccountController.php
View File

@ -411,7 +411,7 @@ class AccountController extends Controller
if ($cache->has()) {
Log::debug('Entries are cached, return cache.');
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
// only include asset accounts when this account is an asset:

2
app/Http/Controllers/BudgetController.php
View File

@ -423,7 +423,7 @@ class BudgetController extends Controller
$cache->addProperty('get-limits');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
/** @var AccountRepositoryInterface $accountRepository */

2
app/Http/Controllers/CategoryController.php
View File

@ -339,7 +339,7 @@ class CategoryController extends Controller
$cache->addProperty($category->id);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
while ($end >= $first) {
$end = Navigation::startOfPeriod($end, $range);

18
app/Http/Controllers/Chart/AccountController.php
View File

@ -67,7 +67,7 @@ class AccountController extends Controller
if ($cache->has()) {
Log::debug('Return chart.account.all from cache.');
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
Log::debug('Regenerate chart.account.all from scratch.');
@ -112,7 +112,7 @@ class AccountController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.account.expense-accounts');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$start->subDay();
@ -153,7 +153,7 @@ class AccountController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.account.expense-budget');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$collector = app(JournalCollectorInterface::class);
$collector->setAccounts(new Collection([$account]))->setRange($start, $end)->withBudgetInformation()->setTypes([TransactionType::WITHDRAWAL]);
@ -210,7 +210,7 @@ class AccountController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.account.expense-category');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$collector = app(JournalCollectorInterface::class);
@ -293,7 +293,7 @@ class AccountController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.account.income-category');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
// grab all journals:
@ -359,7 +359,7 @@ class AccountController extends Controller
$cache->addProperty('chart.account.period');
$cache->addProperty($account->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$format = (string)trans('config.month_and_day');
@ -414,7 +414,7 @@ class AccountController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.account.revenue-accounts');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$accounts = $repository->getAccountsByType([AccountType::REVENUE]);
@ -460,7 +460,7 @@ class AccountController extends Controller
$cache->addProperty('chart.account.single');
$cache->addProperty($account->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$format = (string)trans('config.month_and_day');
@ -502,7 +502,7 @@ class AccountController extends Controller
if ($cache->has()) {
Log::debug('Return chart.account.account-balance-chart from cache.');
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
Log::debug('Regenerate chart.account.account-balance-chart from scratch.');

4
app/Http/Controllers/Chart/BillController.php
View File

@ -60,7 +60,7 @@ class BillController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.bill.frontpage');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$paid = $repository->getBillsPaidInRange($start, $end); // will be a negative amount.
@ -88,7 +88,7 @@ class BillController extends Controller
$cache->addProperty('chart.bill.single');
$cache->addProperty($bill->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$results = $collector->setAllAssetAccounts()->setBills(new Collection([$bill]))->getJournals();

10
app/Http/Controllers/Chart/BudgetController.php
View File

@ -80,7 +80,7 @@ class BudgetController extends Controller
$cache->addProperty('chart.budget.budget');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$final = clone $last;
@ -133,7 +133,7 @@ class BudgetController extends Controller
$cache->addProperty($budgetLimit->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$entries = [];
@ -170,7 +170,7 @@ class BudgetController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.budget.frontpage');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$budgets = $this->repository->getActiveBudgets();
$chartData = [
@ -227,7 +227,7 @@ class BudgetController extends Controller
$cache->addProperty($budget->id);
$cache->addProperty('chart.budget.period');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$periods = Navigation::listOfPeriods($start, $end);
$entries = $this->repository->getBudgetPeriodReport(new Collection([$budget]), $accounts, $start, $end); // get the expenses
@ -268,7 +268,7 @@ class BudgetController extends Controller
$cache->addProperty($accounts);
$cache->addProperty('chart.budget.no-budget');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
// the expenses:

2
app/Http/Controllers/Chart/BudgetReportController.php
View File

@ -131,7 +131,7 @@ class BudgetReportController extends Controller
$cache->addProperty($start);
$cache->addProperty($end);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
/** @var BudgetRepositoryInterface $repository */
$repository = app(BudgetRepositoryInterface::class);

10
app/Http/Controllers/Chart/CategoryController.php
View File

@ -62,7 +62,7 @@ class CategoryController extends Controller
$cache->addProperty('chart.category.all');
$cache->addProperty($category->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$start = $repository->firstUseDate($category);
@ -136,7 +136,7 @@ class CategoryController extends Controller
$cache->addProperty($end);
$cache->addProperty('chart.category.frontpage');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$chartData = [];
$categories = $repository->getCategories();
@ -178,7 +178,7 @@ class CategoryController extends Controller
$cache->addProperty($accounts->pluck('id')->toArray());
$cache->addProperty($category);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$expenses = $repository->periodExpenses(new Collection([$category]), $accounts, $start, $end);
$income = $repository->periodIncome(new Collection([$category]), $accounts, $start, $end);
@ -225,7 +225,7 @@ class CategoryController extends Controller
$cache->addProperty('chart.category.period.no-cat');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$expenses = $repository->periodExpensesNoCategory($accounts, $start, $end);
$income = $repository->periodIncomeNoCategory($accounts, $start, $end);
@ -297,7 +297,7 @@ class CategoryController extends Controller
$accounts = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET]);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
// chart data

2
app/Http/Controllers/Chart/CategoryReportController.php
View File

@ -179,7 +179,7 @@ class CategoryReportController extends Controller
$cache->addProperty($start);
$cache->addProperty($end);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$format = Navigation::preferredCarbonLocalizedFormat($start, $end);

2
app/Http/Controllers/Chart/PiggyBankController.php
View File

@ -58,7 +58,7 @@ class PiggyBankController extends Controller
$cache->addProperty('chart.piggy-bank.history');
$cache->addProperty($piggyBank->id);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$set = $repository->getEvents($piggyBank);

8
app/Http/Controllers/Chart/ReportController.php
View File

@ -64,7 +64,7 @@ class ReportController extends Controller
$cache->addProperty($accounts);
$cache->addProperty($end);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$ids = $accounts->pluck('id')->toArray();
$current = clone $start;
@ -103,7 +103,7 @@ class ReportController extends Controller
$cache->addProperty($accounts);
$cache->addProperty($end);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$format = Navigation::preferredCarbonLocalizedFormat($start, $end);
$source = $this->getChartData($accounts, $start, $end);
@ -161,7 +161,7 @@ class ReportController extends Controller
$cache->addProperty($end);
$cache->addProperty($accounts);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$source = $this->getChartData($accounts, $start, $end);
$numbers = [
@ -246,7 +246,7 @@ class ReportController extends Controller
$cache->addProperty($accounts);
$cache->addProperty($end);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}

2
app/Http/Controllers/Chart/TagReportController.php
View File

@ -152,7 +152,7 @@ class TagReportController extends Controller
$cache->addProperty($start);
$cache->addProperty($end);
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$format = Navigation::preferredCarbonLocalizedFormat($start, $end);

4
app/Http/Controllers/JsonController.php
View File

@ -155,7 +155,7 @@ class JsonController extends Controller
$cache->addProperty($end);
$cache->addProperty('box-in');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$accounts = $repository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]);
$assets = $repository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET]);
@ -183,7 +183,7 @@ class JsonController extends Controller
$cache->addProperty($end);
$cache->addProperty('box-out');
if ($cache->has()) {
return Response::json($cache->get());
return Response::json($cache->get()); // @codeCoverageIgnore
}
$accounts = $repository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]);

2
app/Http/Controllers/Report/AccountController.php
View File

@ -44,7 +44,7 @@ class AccountController extends Controller
$cache->addProperty('account-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
/** @var AccountTaskerInterface $accountTasker */

2
app/Http/Controllers/Report/BalanceController.php
View File

@ -47,7 +47,7 @@ class BalanceController extends Controller
$cache->addProperty('balance-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$balance = $helper->getBalanceReport($accounts, $start, $end);

4
app/Http/Controllers/Report/BudgetController.php
View File

@ -49,7 +49,7 @@ class BudgetController extends Controller
$cache->addProperty('budget-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$budgets = $helper->getBudgetReport($start, $end, $accounts);
@ -76,7 +76,7 @@ class BudgetController extends Controller
$cache->addProperty('budget-period-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
// generate budget report right here.

6
app/Http/Controllers/Report/CategoryController.php
View File

@ -47,7 +47,7 @@ class CategoryController extends Controller
if ($cache->has()) {
Log::debug('Return report from cache');
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
/** @var CategoryRepositoryInterface $repository */
$repository = app(CategoryRepositoryInterface::class);
@ -81,7 +81,7 @@ class CategoryController extends Controller
if ($cache->has()) {
Log::debug('Return report from cache');
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
/** @var CategoryRepositoryInterface $repository */
$repository = app(CategoryRepositoryInterface::class);
@ -114,7 +114,7 @@ class CategoryController extends Controller
$cache->addProperty('category-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
/** @var CategoryRepositoryInterface $repository */

6
app/Http/Controllers/Report/OperationsController.php
View File

@ -46,7 +46,7 @@ class OperationsController extends Controller
$cache->addProperty('expense-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$entries = $this->getExpenseReport($start, $end, $accounts);
$type = 'expense-entry';
@ -73,7 +73,7 @@ class OperationsController extends Controller
$cache->addProperty('income-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$entries = $this->getIncomeReport($start, $end, $accounts);
$type = 'income-entry';
@ -101,7 +101,7 @@ class OperationsController extends Controller
$cache->addProperty('inc-exp-report');
$cache->addProperty($accounts->pluck('id')->toArray());
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$incomes = $this->getIncomeReport($start, $end, $accounts);

2
app/Http/Controllers/TagController.php
View File

@ -386,7 +386,7 @@ class TagController extends Controller
$cache->addProperty($tag->id);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$collection = new Collection;

9
app/Http/Controllers/Transaction/ConvertController.php
View File

@ -119,20 +119,20 @@ class ConvertController extends Controller
*/
public function postIndex(Request $request, JournalRepositoryInterface $repository, TransactionType $destinationType, TransactionJournal $journal)
{
// @codeCoverageIgnoreStart
if ($this->isOpeningBalance($journal)) {
return $this->redirectToAccount($journal);
}
// @codeCoverageIgnoreEnd
$data = $request->all();
// cannot convert to its own type.
if ($journal->transactionType->type === $destinationType->type) {
Session::flash('error', trans('firefly.convert_is_already_type_' . $destinationType->type));
return redirect(route('transactions.show', [$journal->id]));
}
// cannot convert split.
if ($journal->transactions()->count() > 2) {
Session::flash('error', trans('firefly.cannot_convert_split_journl'));
@ -173,7 +173,8 @@ class ConvertController extends Controller
$joined = $sourceType->type . '-' . $destinationType->type;
switch ($joined) {
default:
throw new FireflyException('Cannot handle ' . $joined);
throw new FireflyException('Cannot handle ' . $joined); // @codeCoverageIgnore
case TransactionType::WITHDRAWAL . '-' . TransactionType::DEPOSIT: // one
$destination = $sourceAccount;
break;
@ -218,7 +219,7 @@ class ConvertController extends Controller
$joined = $sourceType->type . '-' . $destinationType->type;
switch ($joined) {
default:
throw new FireflyException('Cannot handle ' . $joined);
throw new FireflyException('Cannot handle ' . $joined); // @codeCoverageIgnore
case TransactionType::WITHDRAWAL . '-' . TransactionType::DEPOSIT: // one
case TransactionType::TRANSFER . '-' . TransactionType::DEPOSIT: // six
$data = [

2
app/Models/TransactionJournal.php
View File

@ -170,7 +170,7 @@ class TransactionJournal extends Model
$cache->addProperty($name);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
Log::debug(sprintf('Looking for journal #%d meta field "%s".', $this->id, $name));

4
app/Repositories/Bill/BillRepository.php
View File

@ -396,7 +396,7 @@ class BillRepository implements BillRepositoryInterface
$cache->addProperty('nextDateMatch');
$cache->addProperty($date);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
// find the most recent date for this bill NOT in the future. Cache this date:
$start = clone $bill->date;
@ -433,7 +433,7 @@ class BillRepository implements BillRepositoryInterface
$cache->addProperty('nextExpectedMatch');
$cache->addProperty($date);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
// find the most recent date for this bill NOT in the future. Cache this date:
$start = clone $bill->date;

6
app/Support/Amount.php
View File

@ -220,7 +220,7 @@ class Amount
$cache = new CacheProperties;
$cache->addProperty('getCurrencyCode');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
} else {
$currencyPreference = Prefs::get('currencyPreference', config('firefly.default_currency', 'EUR'));
@ -245,7 +245,7 @@ class Amount
$cache = new CacheProperties;
$cache->addProperty('getCurrencySymbol');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
} else {
$currencyPreference = Prefs::get('currencyPreference', config('firefly.default_currency', 'EUR'));
$currency = TransactionCurrency::whereCode($currencyPreference->data)->first();
@ -264,7 +264,7 @@ class Amount
$cache = new CacheProperties;
$cache->addProperty('getDefaultCurrency');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$currencyPreference = Prefs::get('currencyPreference', config('firefly.default_currency', 'EUR'));
$currency = TransactionCurrency::whereCode($currencyPreference->data)->first();

8
app/Support/Steam.php
View File

@ -43,7 +43,7 @@ class Steam
$cache->addProperty('balance');
$cache->addProperty($date);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$balance = strval(
@ -74,7 +74,7 @@ class Steam
$cache->addProperty('balance-no-virtual');
$cache->addProperty($date);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$balance = strval(
@ -108,7 +108,7 @@ class Steam
$cache->addProperty($start);
$cache->addProperty($end);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$balances = [];
@ -158,7 +158,7 @@ class Steam
$cache->addProperty('balances');
$cache->addProperty($date);
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$balances = Transaction::leftJoin('transaction_journals', 'transaction_journals.id', '=', 'transactions.transaction_journal_id')

8
app/Support/Twig/Journal.php
View File

@ -44,7 +44,7 @@ class Journal extends Twig_Extension
$cache->addProperty('transaction-journal');
$cache->addProperty('destination-account-string');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$list = $journal->destinationAccountList();
@ -116,7 +116,7 @@ class Journal extends Twig_Extension
$cache->addProperty('transaction-journal');
$cache->addProperty('source-account-string');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$list = $journal->sourceAccountList();
@ -152,7 +152,7 @@ class Journal extends Twig_Extension
$cache->addProperty('transaction-journal');
$cache->addProperty('budget-string');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
@ -189,7 +189,7 @@ class Journal extends Twig_Extension
$cache->addProperty('transaction-journal');
$cache->addProperty('category-string');
if ($cache->has()) {
return $cache->get();
return $cache->get(); // @codeCoverageIgnore
}
$categories = [];
// get all categories for the journal itself (easy):