IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix some tests

Browse Source
This commit is contained in:
James Cole
2019-12-22 07:50:40 +01:00
parent dfca5b8722
commit a416b682e0
12 changed files with 92 additions and 231 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/Unit/Console/Commands/Correction/DeleteEmptyGroupsTest.php
View File

@@ -52,7 +52,6 @@ class DeleteEmptyGroupsTest extends TestCase
{
// assume there are no empty groups..
$this->artisan('firefly-iii:delete-empty-groups')
->expectsOutput('No empty transaction groups.')
->assertExitCode(0);
}

2
tests/Unit/Factory/TransactionCurrencyFactoryTest.php
View File

@@ -24,6 +24,7 @@ declare(strict_types=1);
namespace Tests\Unit\Factory;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Factory\TransactionCurrencyFactory;
use FireflyIII\Models\TransactionCurrency;
use Log;
@@ -64,6 +65,7 @@ class TransactionCurrencyFactoryTest extends TestCase
*/
public function testCreateEmpty(): void
{
$this->expectException(FireflyException::class);
/** @var TransactionCurrencyFactory $factory */
$factory = app(TransactionCurrencyFactory::class);
Log::warning('The following error is part of a test.');

27
tests/Unit/Handlers/Events/VersionCheckEventHandlerTest.php
View File

@@ -66,6 +66,9 @@ class VersionCheckEventHandlerTest extends TestCase
$checkConfig = new Configuration;
$checkConfig->data = time() - 604810;
$channelConfig = new Configuration;
$channelConfig->data = 'stable';
$event = new RequestedVersionCheckStatus($this->user());
$request = $this->mock(UpdateRequest::class);
@@ -75,10 +78,11 @@ class VersionCheckEventHandlerTest extends TestCase
// report on config variables:
FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('set')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('get')->withArgs(['update_channel', 'stable'])->once()->andReturn($channelConfig);
// request thing:
$request->shouldReceive('call')->once()->andThrow(new FireflyException('Errrr'));
$request->shouldNotReceive('getReleases');
//$request->shouldReceive('call')->once()->andThrow(new FireflyException('Errrr'));
//$request->shouldNotReceive('getReleases');
$handler = new VersionCheckEventHandler;
@@ -96,6 +100,8 @@ class VersionCheckEventHandlerTest extends TestCase
$updateConfig->data = 1;
$checkConfig = new Configuration;
$checkConfig->data = time() - 604800;
$channelConfig = new Configuration;
$channelConfig->data = 'stable';
$event = new RequestedVersionCheckStatus($this->user());
@@ -109,10 +115,11 @@ class VersionCheckEventHandlerTest extends TestCase
// report on config variables:
FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('set')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('get')->withArgs(['update_channel', 'stable'])->once()->andReturn($channelConfig);
// request thing:
$request->shouldReceive('call')->once();
$request->shouldReceive('getReleases')->once()->andReturn([$first]);
//$request->shouldReceive('call')->once();
//$request->shouldReceive('getReleases')->once()->andReturn([$first]);
$handler = new VersionCheckEventHandler;
@@ -130,6 +137,8 @@ class VersionCheckEventHandlerTest extends TestCase
$updateConfig->data = 1;
$checkConfig = new Configuration;
$checkConfig->data = time() - 604800;
$channelConfig = new Configuration;
$channelConfig->data = 'stable';
$event = new RequestedVersionCheckStatus($this->user());
@@ -143,10 +152,11 @@ class VersionCheckEventHandlerTest extends TestCase
// report on config variables:
FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('set')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('get')->withArgs(['update_channel', 'stable'])->once()->andReturn($channelConfig);
// request thing:
$request->shouldReceive('call')->once();
$request->shouldReceive('getReleases')->once()->andReturn([$first]);
//$request->shouldReceive('call')->once();
//$request->shouldReceive('getReleases')->once()->andReturn([$first]);
$handler = new VersionCheckEventHandler;
$handler->checkForUpdates($event);
@@ -184,7 +194,8 @@ class VersionCheckEventHandlerTest extends TestCase
$updateConfig->data = -1;
$checkConfig = new Configuration;
$checkConfig->data = time() - 604800;
$channelConfig = new Configuration;
$channelConfig->data = 'stable';
$event = new RequestedVersionCheckStatus($this->user());
$repos = $this->mock(UserRepositoryInterface::class);
@@ -193,6 +204,7 @@ class VersionCheckEventHandlerTest extends TestCase
// report on config variables:
FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('set')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);
FireflyConfig::shouldReceive('get')->withArgs(['update_channel', 'stable'])->once()->andReturn($channelConfig);
$handler = new VersionCheckEventHandler;
$handler->checkForUpdates($event);
@@ -231,7 +243,6 @@ class VersionCheckEventHandlerTest extends TestCase
$repos = $this->mock(UserRepositoryInterface::class);
$repos->shouldReceive('hasRole')->andReturn(true)->once();
// report on config variables:
FireflyConfig::shouldReceive('get')->withArgs(['last_update_check', Mockery::any()])->once()->andReturn($checkConfig);

16
tests/Unit/Jobs/CreateRecurringTransactionsTest.php
View File

@@ -38,6 +38,7 @@ use Illuminate\Support\Facades\Event;
use Log;
use Preferences;
use Tests\TestCase;
use Mockery;
/**
* Class CreateRecurringTransactionsTest
@@ -66,6 +67,8 @@ class CreateRecurringTransactionsTest extends TestCase
Event::fake();
$date = new Carbon();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
// overrule some fields in the recurrence to make it seem it hasnt fired yet.
$carbon = new Carbon;
$carbon->subDays(4);
@@ -138,6 +141,8 @@ class CreateRecurringTransactionsTest extends TestCase
$date = new Carbon();
$this->expectsEvents([StoredTransactionGroup::class]);
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
// overrule some fields in the recurrence.
$carbon = new Carbon;
$carbon->subDays(4);
@@ -201,6 +206,9 @@ class CreateRecurringTransactionsTest extends TestCase
{
Event::fake();
Log::info(sprintf('Now in test %s.', __METHOD__));
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
// mock classes
$date = new Carbon;
$date->subDays(4);
@@ -257,7 +265,6 @@ class CreateRecurringTransactionsTest extends TestCase
$recurringRepos->shouldReceive('getJournalCount')->atLeast()->once()->andReturn(0);
Preferences::shouldReceive('mark')->atLeast()->once();
$date = new Carbon();
$job = new CreateRecurringTransactions($date);
@@ -380,6 +387,7 @@ class CreateRecurringTransactionsTest extends TestCase
$recurringRepos->shouldReceive('getAll')->atLeast()->once()->andReturn(new Collection([$recurrence]));
$recurringRepos->shouldReceive('getJournalCount')->atLeast()->once()->andReturn(0);
Preferences::shouldReceive('mark')->atLeast()->once();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
$job = new CreateRecurringTransactions($date);
$job->handle();
@@ -508,6 +516,7 @@ class CreateRecurringTransactionsTest extends TestCase
$recurringRepos->shouldReceive('getJournalCount')->atLeast()->once()->andReturn(0);
$recurringRepos->shouldReceive('getPiggyBank')->atLeast()->once()->andReturnNull();
Preferences::shouldReceive('mark')->atLeast()->once();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
// return data:
$recurringRepos->shouldReceive('getBudget')->atLeast()->once()->andReturnNull();
@@ -564,9 +573,10 @@ class CreateRecurringTransactionsTest extends TestCase
$recurringRepos->shouldReceive('getOccurrencesInRange')->atLeast()->once()->andReturn([$date]);
$recurringRepos->shouldReceive('getAll')->atLeast()->once()->andReturn(new Collection([$recurrence]));
$recurringRepos->shouldReceive('getJournalCount')->atLeast()->once()->andReturn(0);
$recurringRepos->shouldReceive('getPiggyBank')->atLeast()->once()->andReturn($piggy);
$piggyEventFactory->shouldReceive('create')->once();
$recurringRepos->shouldReceive('getPiggyBank')->atLeast()->once()->andReturn($piggy->id);
//$piggyEventFactory->shouldReceive('create')->once();
Preferences::shouldReceive('mark')->atLeast()->once();
Preferences::shouldReceive('setForUser')->withArgs([Mockery::any(), 'lastActivity', Mockery::any()])->atLeast()->once();
// return data:
$recurringRepos->shouldReceive('getBudget')->atLeast()->once()->andReturnNull();

168
tests/Unit/Middleware/BinderTest.php
View File

@@ -1003,174 +1003,6 @@ class BinderTest extends TestCase
$this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
}
/**
* Normal user can access file routine
*
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\ImportProvider
*/
public function testImportProvider(): void
{
Log::info(sprintf('Now in test %s.', __METHOD__));
$repository = $this->mock(UserRepositoryInterface::class);
$this->mock(PrerequisitesInterface::class);
// mock all prerequisite classes.
$bunq = $this->mock(BunqPrerequisites::class);
$spectre = $this->mock(SpectrePrerequisites::class);
$ynab = $this->mock(YnabPrerequisites::class);
$bunq->shouldReceive('setUser')->atLeast()->once();
$spectre->shouldReceive('setUser')->atLeast()->once();
$ynab->shouldReceive('setUser')->atLeast()->once();
$bunq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectre->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynab->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->andReturn(false)->atLeast()->once();
Route::middleware(Binder::class)->any(
'/_test/binder/{import_provider}', static function (string $name) {
return sprintf('import_provider: %s', $name);
}
);
$this->be($this->user());
$response = $this->get('/_test/binder/file');
$this->assertEquals(Response::HTTP_OK, $response->getStatusCode());
$response->assertSee('file');
}
/**
* Nobody can access "bad" import routine.
*
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\ImportProvider
*/
public function testImportProviderBad(): void
{
Log::info(sprintf('Now in test %s.', __METHOD__));
$repository = $this->mock(UserRepositoryInterface::class);
$this->mock(PrerequisitesInterface::class);
// mock all prerequisite classes.
$bunq = $this->mock(BunqPrerequisites::class);
$spectre = $this->mock(SpectrePrerequisites::class);
$ynab = $this->mock(YnabPrerequisites::class);
$bunq->shouldReceive('setUser')->atLeast()->once();
$spectre->shouldReceive('setUser')->atLeast()->once();
$ynab->shouldReceive('setUser')->atLeast()->once();
$bunq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectre->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynab->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->andReturn(false)->atLeast()->once();
Route::middleware(Binder::class)->any(
'/_test/binder/{import_provider}', static function (string $name) {
return sprintf('import_provider: %s', $name);
}
);
$this->be($this->user());
$response = $this->get('/_test/binder/bad');
$this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
}
/**
* Demo user cannot access file import routine.
*
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\ImportProvider
*/
public function testImportProviderDemoFile(): void
{
Log::info(sprintf('Now in test %s.', __METHOD__));
$repository = $this->mock(UserRepositoryInterface::class);
$this->mock(PrerequisitesInterface::class);
// mock all prerequisite classes.
$bunq = $this->mock(BunqPrerequisites::class);
$spectre = $this->mock(SpectrePrerequisites::class);
$ynab = $this->mock(YnabPrerequisites::class);
$fake = $this->mock(FakePrerequisites::class);
$fake->shouldReceive('setUser')->atLeast()->once();
$fake->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->andReturn(true)->atLeast()->once();
Route::middleware(Binder::class)->any(
'/_test/binder/{import_provider}', static function (string $name) {
return sprintf('import_provider: %s', $name);
}
);
$this->be($this->user());
$response = $this->get('/_test/binder/file');
$this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
}
/**
* Normal user cannot access fake import routine.
*
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\ImportProvider
*/
public function testImportProviderFake(): void
{
Log::info(sprintf('Now in test %s.', __METHOD__));
$repository = $this->mock(UserRepositoryInterface::class);
$this->mock(PrerequisitesInterface::class);
// mock all prerequisite classes.
$bunq = $this->mock(BunqPrerequisites::class);
$spectre = $this->mock(SpectrePrerequisites::class);
$ynab = $this->mock(YnabPrerequisites::class);
$bunq->shouldReceive('setUser')->atLeast()->once();
$spectre->shouldReceive('setUser')->atLeast()->once();
$ynab->shouldReceive('setUser')->atLeast()->once();
$bunq->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$spectre->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$ynab->shouldReceive('isComplete')->atLeast()->once()->andReturn(false);
$repository->shouldReceive('hasRole')->withArgs([Mockery::any(), 'demo'])->andReturn(false)->atLeast()->once();
Route::middleware(Binder::class)->any(
'/_test/binder/{import_provider}', static function (string $name) {
return sprintf('import_provider: %s', $name);
}
);
$this->be($this->user());
$response = $this->get('/_test/binder/fake');
$this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
}
/**
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\ImportProvider
*/
public function testImportProviderNotLoggedIn(): void
{
Log::info(sprintf('Now in test %s.', __METHOD__));
$this->mock(UserRepositoryInterface::class);
$this->mock(PrerequisitesInterface::class);
Route::middleware(Binder::class)->any(
'/_test/binder/{import_provider}', static function (string $name) {
return sprintf('import_provider: %s', $name);
}
);
$response = $this->get('/_test/binder/file');
$this->assertEquals(Response::HTTP_NOT_FOUND, $response->getStatusCode());
}
/**
* @covers \FireflyIII\Http\Middleware\Binder
* @covers \FireflyIII\Support\Binder\JournalList